From patchwork Wed Oct 18 15:41:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13427252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C294CDB47E for ; Wed, 18 Oct 2023 15:41:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 90D7910E0BF; Wed, 18 Oct 2023 15:41:33 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8420910E15B for ; Wed, 18 Oct 2023 15:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697643689; x=1729179689; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=5hq1zLN0zGeErJMk7PqKlr22ACcmj9+sredD+/0/peQ=; b=f44DvEs8YU0+FuDzTbYSzOGAOzbpyxMRxm6qqcGxVjyrNPJEh78hMjJZ 9zqFoX3v67TVqJMI6+sJc7kELkh2LERGU/dqO9LSjTRA6U2ErXsHXn30A 09CspvrCgJe4sncYrZvaXBQKltMrwYq+EOzmF/Uou1Rh7AN+1HAfQm7Aw 8X9gqNzz7aaby+usQ+NCroA/8yg/3OILrxBVJXwH6wA+O4ggivZJnKg6F neNyqnkOM9aMS1yLWDmXmSZ6K/eo/nmkmxCT184m0DOXl/g1YOZiHFKQo Ve+YYGtZU+dWtpGpPh6Fy44a73DVhDPBrOPiJEjVx5EajNX8sZmLVCW74 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="388902936" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="388902936" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 08:41:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="733219363" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="733219363" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga006.jf.intel.com with SMTP; 18 Oct 2023 08:41:27 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 18 Oct 2023 18:41:26 +0300 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Date: Wed, 18 Oct 2023 18:41:20 +0300 Message-ID: <20231018154123.5479-2-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231018154123.5479-1-ville.syrjala@linux.intel.com> References: <20231018154123.5479-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 1/4] drm/i915/mst: Swap TRANSCONF vs. FECSTALL_DIS_DPTSTREAM_DPTTG disable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä The DP modeset sequence asks us to disable TRANSCONF before clearing the FECSTALL_DIS_DPTSTREAM_DPTTG bit, although we are still asked to wait for the transcoder to stop only after both steps have been done. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 28d85e1e858e..a994fc2319a3 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -485,6 +485,8 @@ void intel_disable_transcoder(const struct intel_crtc_state *old_crtc_state) if (!IS_I830(dev_priv)) val &= ~TRANSCONF_ENABLE; + intel_de_write(dev_priv, reg, val); + if (DISPLAY_VER(dev_priv) >= 14) intel_de_rmw(dev_priv, MTL_CHICKEN_TRANS(cpu_transcoder), FECSTALL_DIS_DPTSTREAM_DPTTG, 0); @@ -492,7 +494,6 @@ void intel_disable_transcoder(const struct intel_crtc_state *old_crtc_state) intel_de_rmw(dev_priv, CHICKEN_TRANS(cpu_transcoder), FECSTALL_DIS_DPTSTREAM_DPTTG, 0); - intel_de_write(dev_priv, reg, val); if ((val & TRANSCONF_ENABLE) == 0) intel_wait_for_pipe_off(old_crtc_state); } From patchwork Wed Oct 18 15:41:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13427253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84F41CDB47E for ; Wed, 18 Oct 2023 15:41:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 039D910E132; Wed, 18 Oct 2023 15:41:36 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3E8610E3F3 for ; Wed, 18 Oct 2023 15:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697643692; x=1729179692; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=dqalHBqEuIEStAtosI8WNY/cF9VCf4ZwdptoqQ+gEcA=; b=M9HIpJ1Osgn9IAABlvWNMIiVo9SHlDgUuorlJdVPYuPhV4ZzzjG4A77R lDXMWdIIDLppJyswcewioUk8Np5mYioXIMZCnYruOA9XeCtqE6J9Z9Y2M 1OstHvtYsNr+y14IOACO+PirZkfMY7kSrwNBludH1lnILt1qcV6aZUgpe t1+tYMPNKG8GnAOUP9dwVG9XRGNH1+n7ysf6ixlRVIQhg7piMspEa/IAQ 9n5VkVKEQgwWSuvkIMWpfmoVePX3avOQ+E9iBIfmoIqKxUmm19WbHdhTG EUJcysa4+BAgCY/Y5QfwTTQZh+3GvLA3F/UzP7ZG4H99AvkqmKPd3Xy3X A==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="388902950" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="388902950" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 08:41:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="733219370" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="733219370" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga006.jf.intel.com with SMTP; 18 Oct 2023 08:41:30 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 18 Oct 2023 18:41:29 +0300 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Date: Wed, 18 Oct 2023 18:41:21 +0300 Message-ID: <20231018154123.5479-3-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231018154123.5479-1-ville.syrjala@linux.intel.com> References: <20231018154123.5479-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 2/4] drm/i915/mst: Disable transcoder before deleting the payload X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä Bspec tells us that we should disable the transcoder before deleting the payload. Looks like this has been reversed since MST support was added. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index 7b4628f4f124..57eb581b8a50 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -587,10 +587,6 @@ static void intel_mst_disable_dp(struct intel_atomic_state *state, struct intel_dp *intel_dp = &dig_port->dp; struct intel_connector *connector = to_intel_connector(old_conn_state->connector); - struct drm_dp_mst_topology_state *new_mst_state = - drm_atomic_get_new_mst_topology_state(&state->base, &intel_dp->mst_mgr); - struct drm_dp_mst_atomic_payload *new_payload = - drm_atomic_get_mst_payload_state(new_mst_state, connector->port); struct drm_i915_private *i915 = to_i915(connector->base.dev); drm_dbg_kms(&i915->drm, "active links %d\n", @@ -598,8 +594,6 @@ static void intel_mst_disable_dp(struct intel_atomic_state *state, intel_hdcp_disable(intel_mst->connector); - drm_dp_remove_payload_part1(&intel_dp->mst_mgr, new_mst_state, new_payload); - intel_audio_codec_disable(encoder, old_crtc_state, old_conn_state); } @@ -634,6 +628,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state, intel_disable_transcoder(old_crtc_state); + drm_dp_remove_payload_part1(&intel_dp->mst_mgr, new_mst_state, new_payload); + clear_act_sent(encoder, old_crtc_state); intel_de_rmw(dev_priv, TRANS_DDI_FUNC_CTL(old_crtc_state->cpu_transcoder), From patchwork Wed Oct 18 15:41:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13427254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6443BCDB47E for ; Wed, 18 Oct 2023 15:41:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE8EB10E15B; Wed, 18 Oct 2023 15:41:38 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06B5010E15B for ; Wed, 18 Oct 2023 15:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697643696; x=1729179696; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=LY7Dfz6TpA8lsOx84bbQZX5p+Cz3NQ+iVhsJlOpF3QY=; b=BLAnFZm1suSUxwlovohAa5q7JfJMaWOpJmR/USvkwf9+Z3L8Ba6nqeaa ygsQtYXkkAkfXMWFgeNxLQFB5NgUE7HQ0tm8j7Qgr5GL57Q50QuZQm9b4 Z7rAOCeOgf6uuYdqpHfbBAo+RYO2m4NnGC7A0MMtSeF6KhMh1VMwCR/eS swU7hIOdNr8vEI+THgHJ9FdIAyWFWIRZJAm5sECkPAFlkGMHSG/tb5kem fogFxmsBZsTarBLX0q69DMT18llpnO5n4WhvAEbFA3NoQl/NqVuWlkrOj m+idC478airebxOk6FV9fq/UwTatAOoyI+UgRc1pcFq9HjzAKPKWogacj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="388902972" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="388902972" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 08:41:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="733219385" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="733219385" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga006.jf.intel.com with SMTP; 18 Oct 2023 08:41:33 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 18 Oct 2023 18:41:33 +0300 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Date: Wed, 18 Oct 2023 18:41:22 +0300 Message-ID: <20231018154123.5479-4-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231018154123.5479-1-ville.syrjala@linux.intel.com> References: <20231018154123.5479-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 3/4] drm/i915/mst: Clear ACT just before triggering payload allocation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä Follow the bspec sequqnece more closely and clear ACT sent just before triggering the allocation. Can't see why we'd want to deviate from the spec sequence here. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index 57eb581b8a50..3c66a3e3cc5e 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -791,8 +791,6 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state, drm_WARN_ON(&dev_priv->drm, pipe_config->has_pch_encoder); - clear_act_sent(encoder, pipe_config); - if (intel_dp_is_uhbr(pipe_config)) { const struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode; @@ -806,6 +804,8 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state, intel_ddi_enable_transcoder_func(encoder, pipe_config); + clear_act_sent(encoder, pipe_config); + intel_de_rmw(dev_priv, TRANS_DDI_FUNC_CTL(trans), 0, TRANS_DDI_DP_VC_PAYLOAD_ALLOC); From patchwork Wed Oct 18 15:41:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 13427255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D1E4CDB47E for ; Wed, 18 Oct 2023 15:41:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F4BA10E160; Wed, 18 Oct 2023 15:41:41 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B7C510E160 for ; Wed, 18 Oct 2023 15:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697643699; x=1729179699; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=805SXZLnzfS4hl47TNme8O+l/UdByRAyEp06c+czzVk=; b=XgQg8xutvjbf5+qCZ/ok/X5j5lTBhlycmsKBhm4lUiN6GL/ZIGKx3C6P OJhIgZ6GUyREFIjD69AjivOyHzLlAX983U0VNiDCWs1THKNBebSsrUCmJ 8bkop4AVyrDrJMLj0srkY0uywEnirx/wbip0VbUOtfq69PJYH7BlNw0yq /aYOjBSj9Ctw9YqoygU3r/vbPe4sQEc0SfxuONUP1HuurYHnn3116nTRq AaZ5CB2hm2DZ9Yb54yumHJYlWI3z9sS7DCqOVS4Pxr7ILeL1zHsxvFo0Q 8jvzOc2umbzg72wuEoosk8O6VusMqRG0ul4mM+HBlTxsr9OBezMomqUkI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="388903005" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="388903005" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 08:41:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="733219414" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="733219414" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga006.jf.intel.com with SMTP; 18 Oct 2023 08:41:36 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 18 Oct 2023 18:41:36 +0300 From: Ville Syrjala To: intel-gfx@lists.freedesktop.org Date: Wed, 18 Oct 2023 18:41:23 +0300 Message-ID: <20231018154123.5479-5-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231018154123.5479-1-ville.syrjala@linux.intel.com> References: <20231018154123.5479-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 4/4] drm/i915/mst: Always write CHICKEN_TRANS X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Ville Syrjälä Since we're asked to disable FECSTALL_DIS_DPTSTREAM_DPTTG when the transcoder is disabled it seems prudent to also clear it when enabliing the transcoder w/o FEC, just in case someone else left it enabled by mistake. Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index 3c66a3e3cc5e..38ad81d3bbe6 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -817,12 +817,14 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state, drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base, drm_atomic_get_mst_payload_state(mst_state, connector->port)); - if (DISPLAY_VER(dev_priv) >= 14 && pipe_config->fec_enable) - intel_de_rmw(dev_priv, MTL_CHICKEN_TRANS(trans), 0, - FECSTALL_DIS_DPTSTREAM_DPTTG); - else if (DISPLAY_VER(dev_priv) >= 12 && pipe_config->fec_enable) - intel_de_rmw(dev_priv, CHICKEN_TRANS(trans), 0, - FECSTALL_DIS_DPTSTREAM_DPTTG); + if (DISPLAY_VER(dev_priv) >= 14) + intel_de_rmw(dev_priv, MTL_CHICKEN_TRANS(trans), + FECSTALL_DIS_DPTSTREAM_DPTTG, + pipe_config->fec_enable ? FECSTALL_DIS_DPTSTREAM_DPTTG : 0); + else if (DISPLAY_VER(dev_priv) >= 12) + intel_de_rmw(dev_priv, CHICKEN_TRANS(trans), + FECSTALL_DIS_DPTSTREAM_DPTTG, + pipe_config->fec_enable ? FECSTALL_DIS_DPTSTREAM_DPTTG : 0); intel_audio_sdp_split_update(pipe_config);