From patchwork Tue Oct 24 14:01:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13434670 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D87A7C00A8F for ; Tue, 24 Oct 2023 14:02:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.622011.969058 (Exim 4.92) (envelope-from ) id 1qvHyq-0002cN-4p; Tue, 24 Oct 2023 14:02:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 622011.969058; Tue, 24 Oct 2023 14:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qvHyq-0002cG-13; Tue, 24 Oct 2023 14:02:00 +0000 Received: by outflank-mailman (input) for mailman id 622011; Tue, 24 Oct 2023 14:01:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qvHyo-0002cA-Rm for xen-devel@lists.xenproject.org; Tue, 24 Oct 2023 14:01:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4a4efba-7275-11ee-9b0e-b553b5be7939; Tue, 24 Oct 2023 16:01:56 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-95-247-204-25.retail.telecomitalia.it [95.247.204.25]) by support.bugseng.com (Postfix) with ESMTPSA id 27A1A4EE0739; Tue, 24 Oct 2023 16:01:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4a4efba-7275-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper Subject: [XEN PATCH] xen/iommu_init: address a violation of MISRA C:2012 Rule 8.3 Date: Tue, 24 Oct 2023 16:01:35 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Change parameter name and emphasize that it is deliberately not used through a comment followed by the statement '(void) data;'. This also addresses a violation of MISRA C:2012 Rule 2.7 ("A function should not contain unused parameters"). No functional change. Signed-off-by: Federico Serafini --- xen/drivers/passthrough/amd/iommu_init.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 9c01a49435..5bfaa6cdd4 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -692,7 +692,7 @@ static void iommu_check_ppr_log(struct amd_iommu *iommu) spin_unlock_irqrestore(&iommu->lock, flags); } -static void cf_check do_amd_iommu_irq(void *unused) +static void cf_check do_amd_iommu_irq(void *data) { struct amd_iommu *iommu; @@ -702,6 +702,11 @@ static void cf_check do_amd_iommu_irq(void *unused) return; } + /* + * Formal parameter is deliberately unused. + */ + (void) data; + /* * No matter from where the interrupt came from, check all the * IOMMUs present in the system. This allows for having just one