From patchwork Tue Oct 24 21:23:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435273 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5F4C3E49F for ; Tue, 24 Oct 2023 21:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mre7rMk4" Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D99B9D for ; Tue, 24 Oct 2023 14:25:12 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7a67b9cd230so190765639f.1 for ; Tue, 24 Oct 2023 14:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698182712; x=1698787512; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3vQ+QjPwiKbsv6AdYqy3e3uE4inDpXcgKu4yLJ2WWYg=; b=mre7rMk4DAGXGIRAhNidGrigmHusQEy7r5igup+h8gSrCtbZiPdBbRpjKfRJxcKJb8 HB+BwVaI0gtLyaaT0XU/snpzM3MeKHD1FxggL4sp470aUzdFhMUjt2eoW9TBNCZezLTZ XmJZXMN1XTbUC6a1Bz/fCysjgIJh8Oxtqg6c8HR8kCfxfiyu8mk6csdajHZQ4YGqCP+K +Uqx11yDgv6jIyMzKnEM34Bx3rXIikpRjjPS8rTw76+8LEdNDPvZBsHPRut5RXr0z8DO O6ZMj8c0AGEzu0I9hTddeqrMdLksk/lh5jZGfrOgywhKN+ntZIQYl0OJCRT80LVAROb4 +RrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698182712; x=1698787512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3vQ+QjPwiKbsv6AdYqy3e3uE4inDpXcgKu4yLJ2WWYg=; b=agb/LmhnX6apJqFjHiQkg7FopBhpHXTsmU2P7XnzMr5bq8HKlfG+agNCrgt6863KsJ EAueSMzkucpbr8wK0Y+LhOxM7WTI8PpcJcGeYHablS/bN+1cDmgVFeyIlzUYc1mm3urG Zpb8wBMOIwhapRBiuVR6ZYqfpLEzSwCsaOZhBy8f5aW194zgcyrIra1t12wCYhdK1HTv VtSrjbiBw7wCTqy2Xd5NBEnPkHItTTQcN5/1BwCKGS3od0AWihgKxH0VjijZB++cD56Y eeEUVYwfT++jEeBDoyAmyfEF7wp8sfseFpybxs7Zj7NQJOjFmK5mcnGeXKIbNYrYDVQX ovvQ== X-Gm-Message-State: AOJu0YwJqX+t4tHssiPYO36TAGlhkCF5a3I/lAfd8HXU5ETBBrTgRsM/ a1Zagc2RBIWum0a869xwPDg6mJOGn10= X-Google-Smtp-Source: AGHT+IEeh4DYsRSkA0ET7Ad6MHFWF8UugH8hwvkPRC8Et9QlGg0f+ZXdrYYbQsJ89/KMMt6y3ulHSg== X-Received: by 2002:a6b:c84d:0:b0:79f:cdb4:3f87 with SMTP id y74-20020a6bc84d000000b0079fcdb43f87mr16528078iof.4.1698182711764; Tue, 24 Oct 2023 14:25:11 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id ei3-20020a05663829a300b004332f6537e2sm3070830jab.83.2023.10.24.14.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:25:11 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH net-next v2 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Date: Tue, 24 Oct 2023 15:23:07 -0600 Message-ID: <20231024212312.299370-2-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024212312.299370-1-alexhenrie24@gmail.com> References: <20231024212312.299370-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Without this patch, there is nothing to stop the preferred lifetime of a temporary address from being greater than its valid lifetime. If that was the case, the valid lifetime was effectively ignored. Signed-off-by: Alex Henrie Reviewed-by: David Ahern Reviewed-by: Jiri Pirko --- net/ipv6/addrconf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index c2d471ad7922..26aedaab3647 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1399,6 +1399,7 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) idev->cnf.temp_valid_lft + age); cfg.preferred_lft = cnf_temp_preferred_lft + age - idev->desync_factor; cfg.preferred_lft = min_t(__u32, ifp->prefered_lft, cfg.preferred_lft); + cfg.preferred_lft = min_t(__u32, cfg.valid_lft, cfg.preferred_lft); cfg.plen = ifp->prefix_len; tmp_tstamp = ifp->tstamp; From patchwork Tue Oct 24 21:23:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435275 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B16993F4AE for ; Tue, 24 Oct 2023 21:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fGZXvt0O" Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0F66A6 for ; Tue, 24 Oct 2023 14:25:13 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7a93b7fedb8so123326839f.3 for ; Tue, 24 Oct 2023 14:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698182713; x=1698787513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1UME4268LSpoYDogNItG+ed8HIn9jv+2pUrDkVBKYc0=; b=fGZXvt0OpXpe74wg9VgLYyLRh8W48uCA+NPqQ/+GamRCIugArdks0CN8bmxR/7kQcW 5EfqALwpVBZJOudYSREv1AtrMYvh5AuyxaT64OX9QKgpq2WaHqeedyt8z+MOoz3zRWpM funmlwpOr1rFt4pQECyMCxHCLUZQed464RF9J/CH4pM53QAFA7raoyFJ5XNZNJXm6aZt H8ROpem/pPoyoBx1PHTEMkklzruGHvwPrGvvKbjCyXXPOS1wWwos3gwS0mmU4VMJWSOy G90hRpBkJMqJn55jmQT1LnFR+fyIbHnYC7eCO91tdE10L6AXpLpsUqnbp7bBgJeYgv3j xg/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698182713; x=1698787513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1UME4268LSpoYDogNItG+ed8HIn9jv+2pUrDkVBKYc0=; b=vXX6o6UIPPtP5nennYZ2GmFSyN/JaFYnY4YK7S10qpNpxi5dhcvVGPxIAJvMqsc0C+ dO/aK3msRD8Wuk3BmYh6P2QjWocgyje40vM3wrD87lBbT+PoidEkaxS4bkOwoOkFHwOT VXHirsT5Dc2XvD4ji8KCaqabyHZPrYuK/qqXU3PV/121tC0eCW3txKDCZRkK5zYipTWt 3LR1eSNvmLELu5s5P1ql2aiyzxrd3n1dfCoWnrIfFEvhU/E0rdphSH39tPCM8s9pK0qm ziUCXLUgwUo5qH77DVHuZ3n5bTDkOIW7YJWagYYgvg6Zm7BC1lXh6Ut8Uz8fluvgs5iz oOYg== X-Gm-Message-State: AOJu0YxTu7DsZqets42wfoeBE9dSBDhS+yrRLbhUUmEUC/kp02jo9oVE 2BUHLWr9565E94TLvQ6dgh7rhue8DkA= X-Google-Smtp-Source: AGHT+IFsES+8FgLdN0gtDFuZZ9fwv8aQs3fUUCnTVIqvMCwt71C8NDxoN9WLpwIEgNXTEJKFUGQS7Q== X-Received: by 2002:a05:6602:398b:b0:7a9:90db:32d0 with SMTP id bw11-20020a056602398b00b007a990db32d0mr1758443iob.19.1698182712795; Tue, 24 Oct 2023 14:25:12 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id ei3-20020a05663829a300b004332f6537e2sm3070830jab.83.2023.10.24.14.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:25:12 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH net-next v2 2/4] net: ipv6/addrconf: clamp preferred_lft to the minimum required Date: Tue, 24 Oct 2023 15:23:08 -0600 Message-ID: <20231024212312.299370-3-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024212312.299370-1-alexhenrie24@gmail.com> References: <20231024212312.299370-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org If the preferred lifetime was less than the minimum required lifetime, ipv6_create_tempaddr would error out without creating any new address. On my machine and network, this error happened immediately with the preferred lifetime set to 1 second, after a few minutes with the preferred lifetime set to 4 seconds, and not at all with the preferred lifetime set to 5 seconds. During my investigation, I found a Stack Exchange post from another person who seems to have had the same problem: They stopped getting new addresses if they lowered the preferred lifetime below 3 seconds, and they didn't really know why. The preferred lifetime is a preference, not a hard requirement. The kernel does not strictly forbid new connections on a deprecated address, nor does it guarantee that the address will be disposed of the instant its total valid lifetime expires. So rather than disable IPv6 privacy extensions altogether if the minimum required lifetime swells above the preferred lifetime, it is more in keeping with the user's intent to increase the temporary address's lifetime to the minimum necessary for the current network conditions. With these fixes, setting the preferred lifetime to 3 or 4 seconds "just works" because the extra fraction of a second is practically unnoticeable. It's even possible to reduce the time before deprecation to 1 or 2 seconds by also disabling duplicate address detection (setting /proc/sys/net/ipv6/conf/*/dad_transmits to 0). I realize that that is a pretty niche use case, but I know at least one person who would gladly sacrifice performance and convenience to be sure that they are getting the maximum possible level of privacy. Link: https://serverfault.com/a/1031168/310447 Signed-off-by: Alex Henrie Reviewed-by: David Ahern --- net/ipv6/addrconf.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 26aedaab3647..3aaea56b5166 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1407,15 +1407,23 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) write_unlock_bh(&idev->lock); - /* A temporary address is created only if this calculated Preferred - * Lifetime is greater than REGEN_ADVANCE time units. In particular, - * an implementation must not create a temporary address with a zero - * Preferred Lifetime. + /* From RFC 4941: + * + * A temporary address is created only if this calculated Preferred + * Lifetime is greater than REGEN_ADVANCE time units. In + * particular, an implementation must not create a temporary address + * with a zero Preferred Lifetime. + * + * Clamp the preferred lifetime to a minimum of regen_advance, unless + * that would exceed valid_lft. + * * Use age calculation as in addrconf_verify to avoid unnecessary * temporary addresses being generated. */ age = (now - tmp_tstamp + ADDRCONF_TIMER_FUZZ_MINUS) / HZ; - if (cfg.preferred_lft <= regen_advance + age) { + if (cfg.preferred_lft <= regen_advance + age) + cfg.preferred_lft = regen_advance + age + 1; + if (cfg.preferred_lft > cfg.valid_lft) { in6_ifa_put(ifp); in6_dev_put(idev); ret = -1; From patchwork Tue Oct 24 21:23:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435276 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CD1D3F4B3 for ; Tue, 24 Oct 2023 21:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iHn/g0BK" Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4726129 for ; Tue, 24 Oct 2023 14:25:14 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7a94a3b0a49so94314739f.2 for ; Tue, 24 Oct 2023 14:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698182714; x=1698787514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rpv3Ig2r+Ey5CHWiqMkg2QYZg39Hp38jBFwE6JZRnWM=; b=iHn/g0BKOy5fYgsyI2u5m6XzQwNqwv3Imm7tqvTkj6WCqxtwpnyFv7//dpSb/tMavx DXPkwPbhP1wutg+ICCJm8grQjmMP6eM8jY9bIwRneRflqzIWoKfuu54M0AQJb7XEjR4X 7dIdq8jvr+ZlgcHEfaOIrlLPHIUtxEBI1Rxh8vIaqQNdeDRvFOnFdDmiPsr/vXoCYGNt HTTbBqZbZn9KAWMjrmTNetNszUG6WoQoGTZMIdtHktJjA55zmGzL3H93zMVG3C57suLn 6+aJ32JarZXyp/hGdSEgSa52Xfbt91LpFOb9RDkNJQBwH0FbVw0f68ZQBPZR6WBI1X8o rzbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698182714; x=1698787514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rpv3Ig2r+Ey5CHWiqMkg2QYZg39Hp38jBFwE6JZRnWM=; b=ZRdIzvQMhBIqVuZCRD+pHAdJEMISqcfEOydVBGNfaQAqCAReL8H7ESFzkDWC6qqynu UBz5OQ8B/Rpgh9hOhwLlqRzJFcuywkpSDtSHTawRAwMbZgJKB9+yL+YuIJxcvrcXhD67 W+ad7ismism5R6QsB1auLSpgXgXl4YfEJvyl/g9TR5XOOpRYRbfc7pcMpO4zJo8Z6Hum pg6XkEFavKPRCTMa41mL24meFygCW91PUltUIpiRaGQT28ZYa+o97fs9sw45VMcx9+Ov m1iZG/hyh9ul1KrVtf1HY4Ois/7EXq2ntqTo+4fh7z/coYVgFLwP/yOomXOgFflRKv+K zLvQ== X-Gm-Message-State: AOJu0YyemwpGDt3skGgeCiv55Wi7WDvOJmFj2++npU1/hvkPnVMMI73h mXKnzxlkWwict7sW3XqANobOXKNaVF0= X-Google-Smtp-Source: AGHT+IED0zQTeXLyiqoLkr5mSILi/5rEi4Tt04Q+NUs5Uy2MYasAL1fbpgtypDnI47R3KXj6Iwtp4Q== X-Received: by 2002:a05:6602:2d92:b0:7a6:b272:fd78 with SMTP id k18-20020a0566022d9200b007a6b272fd78mr15638462iow.10.1698182713969; Tue, 24 Oct 2023 14:25:13 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id ei3-20020a05663829a300b004332f6537e2sm3070830jab.83.2023.10.24.14.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:25:13 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH net-next v2 3/4] Documentation: networking: explain what happens if temp_valid_lft is too small Date: Tue, 24 Oct 2023 15:23:09 -0600 Message-ID: <20231024212312.299370-4-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024212312.299370-1-alexhenrie24@gmail.com> References: <20231024212312.299370-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Signed-off-by: Alex Henrie Reviewed-by: David Ahern --- Documentation/networking/ip-sysctl.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst index e7ec9026e5db..6134ff4561e8 100644 --- a/Documentation/networking/ip-sysctl.rst +++ b/Documentation/networking/ip-sysctl.rst @@ -2502,7 +2502,9 @@ use_tempaddr - INTEGER * -1 (for point-to-point devices and loopback devices) temp_valid_lft - INTEGER - valid lifetime (in seconds) for temporary addresses. + valid lifetime (in seconds) for temporary addresses. If less than the + minimum required lifetime (typically 5 seconds), temporary addresses + will not be created. Default: 172800 (2 days) From patchwork Tue Oct 24 21:23:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435277 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E3B63F4D0 for ; Tue, 24 Oct 2023 21:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E9NQgHTO" Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E836E133 for ; Tue, 24 Oct 2023 14:25:15 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7a956887c20so93269739f.1 for ; Tue, 24 Oct 2023 14:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698182715; x=1698787515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=igsyGmdDg4YNoKJbIiB398saIC94EtgCOWNzzkFwfg8=; b=E9NQgHTOe6ltMQ8BuNuj4vi5dcOpM+0dvA3t+C9NIkWrDKzBZULTT6lsoBjrJTAezy IZKTpQQG2VJIKS0eMdWktaPXabRxe5dtLFc0KZZw43dbOYNCNOHhztq+xhcEYCGhbaug 5yhFklktjc7O5LDLzQn5d9pdsq/1d7JleFJyY/AMql8udq/61LjzScnkUmpmOVrA79PV bk8V0suSeLt1CwFFwYN9OATeFGT8Vx6V4p6nfDuZRU36sUyMd73XYP0raC0B/AY2HCY5 Yi6L5qLvLLtRmOHDI2tIVtvg8toWpCxYsUxlX6rMVfKJDEsVIBYKNnKs9P0LEqG/NF5c t1KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698182715; x=1698787515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=igsyGmdDg4YNoKJbIiB398saIC94EtgCOWNzzkFwfg8=; b=Z8Crk9FZAcJqhXM2qeRvkgCN406eYLYCHZih2vHPgTCTVJ/tZRcNyE02ZkXWa7RaPN 5f0M41UXwXiBzzPYnUQ/w0KwAYZpYGbbBX8kflCTFf65GdiBZuQ+XnSW733X1CVEz4Iw hmLQ+0RKMxa9wOrHcADflgNo32eRhkWPY532erB1yOx6BjprvDctB8OF5XDsfeCNos95 iC+7rE9Sqd4bNPCRalrskw5fyym/yre85jlaZOqVqWq1Rw7RCNZ46BVdA/XeJ7HAcsuZ qwcntiOzY6e2SmwXhFN/3moxeW3Ldc3Va5t+PN2aSHAs/7PgjOX/vI65qUmEVXD6XYVX C0yg== X-Gm-Message-State: AOJu0YzNEe0oMuCk0dnqhOPFXZONa6ACoF+fKBgtgMWzyfwO+KcMhKfX zl9VtJYPWCWS/x/kK020FwJmbk7hAcI= X-Google-Smtp-Source: AGHT+IF9uazF5rN7IOCnVch5MXeO0erFfMPeKygu4aJRiBx/uLhvj7zjs6dpeOFBN/57C7wP9BirAg== X-Received: by 2002:a05:6602:2e90:b0:7a6:a089:572c with SMTP id m16-20020a0566022e9000b007a6a089572cmr13684981iow.21.1698182715042; Tue, 24 Oct 2023 14:25:15 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id ei3-20020a05663829a300b004332f6537e2sm3070830jab.83.2023.10.24.14.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:25:14 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH net-next v2 4/4] Documentation: networking: explain what happens if temp_prefered_lft is too small or too large Date: Tue, 24 Oct 2023 15:23:10 -0600 Message-ID: <20231024212312.299370-5-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024212312.299370-1-alexhenrie24@gmail.com> References: <20231024212312.299370-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Signed-off-by: Alex Henrie Reviewed-by: David Ahern --- Documentation/networking/ip-sysctl.rst | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst index 6134ff4561e8..4dfe0d9a57bb 100644 --- a/Documentation/networking/ip-sysctl.rst +++ b/Documentation/networking/ip-sysctl.rst @@ -2509,7 +2509,11 @@ temp_valid_lft - INTEGER Default: 172800 (2 days) temp_prefered_lft - INTEGER - Preferred lifetime (in seconds) for temporary addresses. + Preferred lifetime (in seconds) for temporary addresses. If + temp_prefered_lft is less than the minimum required lifetime (typically + 5 seconds), the preferred lifetime is the minimum required. If + temp_prefered_lft is greater than temp_valid_lft, the preferred lifetime + is temp_valid_lft. Default: 86400 (1 day)