From patchwork Wed Oct 25 10:32:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13435933 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9C6C25B47 for ; Wed, 25 Oct 2023 10:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234777AbjJYKdO (ORCPT ); Wed, 25 Oct 2023 06:33:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234538AbjJYKdN (ORCPT ); Wed, 25 Oct 2023 06:33:13 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81DC293 for ; Wed, 25 Oct 2023 03:33:11 -0700 (PDT) Received: from umang.jain (unknown [103.251.226.9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C8B8EBEB; Wed, 25 Oct 2023 12:32:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698229977; bh=zchdBfdBSrxs9LBFtwEEnlIYbRTUEnSVxqasOdMq3QU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C9wXwlGef6XedHa73XKEI0mbVoYn4ZW/8JcJAmPSrtHUOsoa68WJMPuFLdgq1eVxz po1he65cdSDPu3dy70Q9Er7FAcpie3Fb0yqbi2dUtqFQ+fUi/fWD12skxq91Belxz5 qp0cVhgQcb6QEJTE8wvrDX/Qd0QH3JnKm+0qw32I= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Kieran Bingham , Laurent Pinchart , Dan Carpenter , Umang Jain Subject: [PATCH 1/2] staging: vc04_services: Drop completed TODO item Date: Wed, 25 Oct 2023 06:32:59 -0400 Message-ID: <20231025103300.340572-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231025103300.340572-1-umang.jain@ideasonboard.com> References: <20231025103300.340572-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Drop the TODO item which deals with non-essential global structures and per-device structure. All this has been handled now through vchiq-bus and struct vchiq_device. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/TODO | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 6d9d4a800aa7..9c79ed549831 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -46,14 +46,6 @@ The code follows the 80 characters limitation yet tends to go 3 or 4 levels of indentation deep making it very unpleasant to read. This is specially relevant in the character driver ioctl code and in the core thread functions. -* Get rid of all non essential global structures and create a proper per -device structure - -The first thing one generally sees in a probe function is a memory allocation -for all the device specific data. This structure is then passed all over the -driver. This is good practice since it makes the driver work regardless of the -number of devices probed. - * Clean up Sparse warnings from __user annotations. See vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter" is never disclosed to userspace. From patchwork Wed Oct 25 10:33:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13435934 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593A0C25B6E for ; Wed, 25 Oct 2023 10:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234781AbjJYKdP (ORCPT ); Wed, 25 Oct 2023 06:33:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234404AbjJYKdO (ORCPT ); Wed, 25 Oct 2023 06:33:14 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0460993 for ; Wed, 25 Oct 2023 03:33:13 -0700 (PDT) Received: from umang.jain (unknown [103.251.226.9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 19FF5EF2; Wed, 25 Oct 2023 12:32:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698229980; bh=lN/b6aBQlp0QJ2/bKG+wfQaYXsqIJPtPWZLmBnXQuiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DOn2lz3WYp55/+mOCeR5fxgCT8m4Wo34DWUe5MsErrp552yrvALfsTb82mD826qmy QbaD3Vn+Kq9hAZdH0urr6LRzGFYF25nDWkKEGiSBdJbCQpawJILIPTqmbkGypLzCOq GldqMDWPDOH4IOV3vsZ2PegQBTkigPHW4Me/Xw2A= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Kieran Bingham , Laurent Pinchart , Dan Carpenter , Umang Jain Subject: [PATCH 2/2] staging: vc04_services: Drop completed TODO item Date: Wed, 25 Oct 2023 06:33:00 -0400 Message-ID: <20231025103300.340572-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231025103300.340572-1-umang.jain@ideasonboard.com> References: <20231025103300.340572-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Memory barries and remote_event_*() are documented. Drop the TODO item related to them. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/TODO | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 9c79ed549831..2d51f6928e0f 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -33,13 +33,6 @@ such as dev_info, dev_dbg, and friends. A short top-down description of this driver's architecture (function of kthreads, userspace, limitations) could be very helpful for reviewers. -* Review and comment memory barriers - -There is a heavy use of memory barriers in this driver, it would be very -beneficial to go over all of them and, if correct, comment on their merits. -Extra points to whomever confidently reviews the remote_event_*() family of -functions. - * Reformat core code with more sane indentations The code follows the 80 characters limitation yet tends to go 3 or 4 levels of