From patchwork Thu Oct 26 02:01:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fang Xiang X-Patchwork-Id: 13437173 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E32AC0032E for ; Thu, 26 Oct 2023 02:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6mVaThSz8lomhkh3N4RgmsTl7PFcDeCho26bEkKDdbU=; b=NAayC6qf8aR+uC AM1Zq98PA5tjAmqmvUwzBf+mFRhLVCWCZIGioiPhhRbUUFdjYrtL9Q+F5cIHjJEIpOnUlUTRPND+Q rkntqwFyxQYVDvrwx/vEaolV1maWLj0pNitzNf6ttFsF+rnyALCc4BnAbBXJNziyOxyhnaI5ghF3h 4Q9gMFDRiuUU8zBfPHvBKPvX3BePckG6o1ZMVEO1XhXIx0xhLXjk7QJ1rCempjRVlmJQ6L6ZnaPtz OJgMADS2I5hNIfWbmzOofjxa7txBowyGZyXtdwD1Oh0jsiXBWSWi92gG0QF5L/8RVbienZmmjNUpc aWBjNuUlKdv6ItxOipRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvpnn-00DUhl-0L; Thu, 26 Oct 2023 02:08:51 +0000 Received: from outboundhk.mxmail.xiaomi.com ([118.143.206.90]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvpnk-00DUhI-1O for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 02:08:49 +0000 X-IronPort-AV: E=Sophos;i="6.03,252,1694707200"; d="scan'208";a="68935568" From: Fang Xiang To: , , , CC: Subject: [PATCH] irqchip/gic-v3-its: Fix the coherent issue in its_setup_baser() when shr = 0. Date: Thu, 26 Oct 2023 10:01:16 +0800 Message-ID: <20231026020116.4238-1-fangxiang3@xiaomi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.237.8.18] X-ClientProxiedBy: BJ-MBX02.mioffice.cn (10.237.8.122) To BJ-MBX15.mioffice.cn (10.237.8.135) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_190848_672582_E7AD6A23 X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The table would not be flushed if the input parameter shr = 0 in its_setup_baser() and it would cause a coherent problem. Signed-off-by: Fang Xiang --- drivers/irqchip/irq-gic-v3-its.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 75a2dd550625..58a9f24ccfa7 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2394,13 +2394,15 @@ static int its_setup_baser(struct its_node *its, struct its_baser *baser, * non-cacheable as well. */ shr = tmp & GITS_BASER_SHAREABILITY_MASK; - if (!shr) { + if (!shr) cache = GITS_BASER_nC; - gic_flush_dcache_to_poc(base, PAGE_ORDER_TO_SIZE(order)); - } + goto retry_baser; } + if (!shr) + gic_flush_dcache_to_poc(base, PAGE_ORDER_TO_SIZE(order)); + if (val != tmp) { pr_err("ITS@%pa: %s doesn't stick: %llx %llx\n", &its->phys_base, its_base_type_string[type],