From patchwork Wed Feb 13 16:12:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810287 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D41313B5 for ; Wed, 13 Feb 2019 16:12:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 58C512DE6C for ; Wed, 13 Feb 2019 16:12:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 56E742DE92; Wed, 13 Feb 2019 16:12:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D1C182DE7F for ; Wed, 13 Feb 2019 16:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404328AbfBMQMw (ORCPT ); Wed, 13 Feb 2019 11:12:52 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39214 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733017AbfBMQMw (ORCPT ); Wed, 13 Feb 2019 11:12:52 -0500 Received: by mail-wr1-f68.google.com with SMTP id l5so2075471wrw.6 for ; Wed, 13 Feb 2019 08:12:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M7AEEHqJASumjBrkgCtFHeGRFX0dNhojcICusL532jE=; b=RzdlsinUa3PTaLyT1038yP0773wqPnMznZxr+uF60XmbGbZzKkMAh58ink19doBOBE NWTtxvClwARPcuMlTzQArrfmKADbybKjL5ZB89paSReQBqFX7vy6tXbCcWq8wXCUxc6a 6ckOOv/U1heu32nem27Ispnjb69Gl/AEWUx2WIJosF5+9L5iXqs7g4ZYAZdeFM0xYpcN AQrFPojW2UBt4xtbRkrNo1cL0LC53upgK6UJNpzl0gNzw8tTccXmtJmKP/4AaWHyWGzX fsmGoalVADg4durAvb9dNbLuskacTDiUcB3SsVRWYf6pTDTHiZliCwKx0QChf4AzEB2+ UTjQ== X-Gm-Message-State: AHQUAuYBmTS8oGZwvZW1nKNfsUD+dtZ/RHDI9h07cLR5jCToeay0S8ze 5AXoC6hGe0pEZISVsNXwXLN+ZpSj X-Google-Smtp-Source: AHgI3IZdvanaUmO/p0PrTHl01yBz8Gg/d9QKKOR6ur5hdPVX8P62pbH+O87d5t32BZJ4BhdL1Or03Q== X-Received: by 2002:adf:f8c1:: with SMTP id f1mr1002701wrq.31.1550074370379; Wed, 13 Feb 2019 08:12:50 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.12.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:12:49 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 1/8] kernel-shark: Add more sanity checks for model misbehavior detection Date: Wed, 13 Feb 2019 18:12:09 +0200 Message-Id: <20190213161216.14438-2-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I found that those checks are very useful for early detection of misbehavior (bugs) of the visualization model. In particular those checks helped me a lot when developing the multi-stream branch of KernelShark (future version 2.0). Signed-off-by: Yordan Karadzhov --- kernel-shark/src/libkshark-model.c | 28 +++++++++++++++++++--------- kernel-shark/src/libkshark.c | 7 ++++++- 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/kernel-shark/src/libkshark-model.c b/kernel-shark/src/libkshark-model.c index 2094795..a4041c3 100644 --- a/kernel-shark/src/libkshark-model.c +++ b/kernel-shark/src/libkshark-model.c @@ -299,6 +299,7 @@ static void ksmodel_set_next_bin_edge(struct kshark_trace_histo *histo, static void ksmodel_set_bin_counts(struct kshark_trace_histo *histo) { int i = 0, prev_not_empty; + ssize_t count_tmp; histo->tot_count = 0; memset(&histo->bin_count[0], 0, @@ -329,12 +330,18 @@ static void ksmodel_set_bin_counts(struct kshark_trace_histo *histo) * empty bin, which will give us the number of data * rows in the "prev_not_empty" bin. */ - histo->bin_count[prev_not_empty] = - histo->map[i] - histo->map[prev_not_empty]; + count_tmp = histo->map[i] - histo->map[prev_not_empty]; + + /* + * We will do a sanity check. The number of data rows + * in the previous not empty bin must be greater than + * zero. + */ + assert(count_tmp > 0); + histo->bin_count[prev_not_empty] = count_tmp; if (prev_not_empty != LOB(histo)) - histo->tot_count += - histo->bin_count[prev_not_empty]; + histo->tot_count += count_tmp; prev_not_empty = i; } @@ -346,19 +353,22 @@ static void ksmodel_set_bin_counts(struct kshark_trace_histo *histo) * The Upper Overflow bin is empty. Use the size of the dataset * to calculate the content of the previouse not empty bin. */ - histo->bin_count[prev_not_empty] = histo->data_size - - histo->map[prev_not_empty]; + count_tmp = histo->data_size - histo->map[prev_not_empty]; } else { /* * Use the index of the first entry inside the Upper Overflow * bin to calculate the content of the previouse not empty * bin. */ - histo->bin_count[prev_not_empty] = histo->map[UOB(histo)] - - histo->map[prev_not_empty]; + count_tmp = histo->map[UOB(histo)] - histo->map[prev_not_empty]; } - histo->tot_count += histo->bin_count[prev_not_empty]; + /* + * We will do a sanity check. The number of data rows in the last not + * empty bin must be greater than zero. + */ + assert(count_tmp > 0); + histo->tot_count += histo->bin_count[prev_not_empty] = count_tmp; } /** diff --git a/kernel-shark/src/libkshark.c b/kernel-shark/src/libkshark.c index 5033e47..9a41945 100644 --- a/kernel-shark/src/libkshark.c +++ b/kernel-shark/src/libkshark.c @@ -1552,7 +1552,7 @@ const struct kshark_entry dummy_entry = { static const struct kshark_entry * get_entry(const struct kshark_entry_request *req, struct kshark_entry **data, - ssize_t *index, size_t start, ssize_t end, int inc) + ssize_t *index, ssize_t start, ssize_t end, int inc) { struct kshark_context *kshark_ctx = NULL; const struct kshark_entry *e = NULL; @@ -1564,6 +1564,11 @@ get_entry(const struct kshark_entry_request *req, if (!kshark_instance(&kshark_ctx)) return e; + /* + * We will do a sanity check in order to protect against infinite + * loops. + */ + assert((inc > 0 && start < end) || (inc < 0 && start > end)); for (i = start; i != end; i += inc) { if (req->cond(kshark_ctx, data[i], req->val)) { /* From patchwork Wed Feb 13 16:12:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 92484922 for ; Wed, 13 Feb 2019 16:12:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8013A2DE8A for ; Wed, 13 Feb 2019 16:12:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E5002D637; Wed, 13 Feb 2019 16:12:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 271282DE8A for ; Wed, 13 Feb 2019 16:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404330AbfBMQM4 (ORCPT ); Wed, 13 Feb 2019 11:12:56 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36042 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404329AbfBMQMz (ORCPT ); Wed, 13 Feb 2019 11:12:55 -0500 Received: by mail-wm1-f68.google.com with SMTP id j125so3044818wmj.1 for ; Wed, 13 Feb 2019 08:12:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N1lZDA2FMMxFH72nmZgX/iChkGGScgPNZ9sZeSxjjB0=; b=svjlaJgkAWPg5NGNNmh1tORTBmE5KYw6RqfRZDFWUiJrf9zdzaANexW7usNg2JQ/fW Zo7C1n07pard25XcPeIEhkv0h+6yDONXsTMTilpCXo9bl+qfdsLDR2edgQcLDVIc3HDM vKmgnw1ysLbB/Kw3MaHkLabrGO8Ns5MkQMPAyuhKPQXL6YnbOsUAM73d61S1txkubSO8 zCubQ/FVRkkdEAPKDKVjI56X8O1BKu1fa7Hd107O7nf6mFSb13AXV4Bqq1GxTu2IuG1D dxl3QaitHg9hUewbsFSWakHWc1lu/GrvYphcotakhMT57AGEcPQrCnxZ3kAaKTAgvcmh XHdQ== X-Gm-Message-State: AHQUAuZXPQW5OYRyh78Fm+gCp3yt8DYn5hi5llepXz8U7QkbS4tytc8z 5FoPLI01foe6ACCCRPueZRk= X-Google-Smtp-Source: AHgI3IY7uGFVnA4ydDQXZsqQE2UfAGIVPOXbFPAAEVH50vR0FYwpDUPGOnYaoiPOfT9YoONTubT6mw== X-Received: by 2002:a1c:c783:: with SMTP id x125mr975353wmf.6.1550074373924; Wed, 13 Feb 2019 08:12:53 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.12.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:12:53 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 2/8] kernel-shark: Do not copy the Upper Overflow bin when shifting forward Date: Wed, 13 Feb 2019 18:12:10 +0200 Message-Id: <20190213161216.14438-3-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ksmodel_shift_forward() copies the mapping indexes of all overlapping bins of the model starting from bin "0" of the new histo up to bin "histo->n_bins - n". Then the mapping index of the old Upper Overflow bin is considered to be the mapping index of first non-overlapping bin, which is wrong. It is wrong because in ksmodel_set_upper_edge() the value of "histo->max" is considered inside the range of the model hence the Upper Overflow bin starts at "histo->max + 1" but the first non-overlapping bin will start at exactly "histo->max". Fixes: f97e31f00 ("kernel-shark-qt: Introduce the visualization model used by the Qt-based KS") Signed-off-by: Yordan Karadzhov --- kernel-shark/src/libkshark-model.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/kernel-shark/src/libkshark-model.c b/kernel-shark/src/libkshark-model.c index a4041c3..b71a9b8 100644 --- a/kernel-shark/src/libkshark-model.c +++ b/kernel-shark/src/libkshark-model.c @@ -500,13 +500,11 @@ void ksmodel_shift_forward(struct kshark_trace_histo *histo, size_t n) sizeof(histo->map[0]) * (histo->n_bins - n)); /* - * The mapping index of the old Upper Overflow bin is now index of the - * first new bin. + * Calculate only the content of the new (non-overlapping) bins. + * Start from the last copied bin and set the edge of each consecutive + * bin. */ - bin = UOB(histo) - n; - histo->map[bin] = histo->map[UOB(histo)]; - - /* Calculate only the content of the new (non-overlapping) bins. */ + bin = histo->n_bins - n - 1; for (; bin < histo->n_bins; ++bin) { ksmodel_set_next_bin_edge(histo, bin, last_row); if (histo->map[bin + 1] > 0) From patchwork Wed Feb 13 16:12:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810291 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 89E9B13B5 for ; Wed, 13 Feb 2019 16:12:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 781F32DED1 for ; Wed, 13 Feb 2019 16:12:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 766FB2DEEA; Wed, 13 Feb 2019 16:12:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22D392DED1 for ; Wed, 13 Feb 2019 16:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404329AbfBMQM6 (ORCPT ); Wed, 13 Feb 2019 11:12:58 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35063 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733017AbfBMQM5 (ORCPT ); Wed, 13 Feb 2019 11:12:57 -0500 Received: by mail-wm1-f66.google.com with SMTP id t200so3044555wmt.0 for ; Wed, 13 Feb 2019 08:12:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WcE7P/MHFpIoLQiFeu/x9vQG07Pw8oDGNgsupsIbd0I=; b=jfB/YipwpKlwC+sPYxwY1pneV5dWrsakTQfMEy3bEDwZlTihUbd/QhzHS2VdSIhRN+ 7lfG6mhHV++wjbFwHuARNauaBThcJO5tUpsyJ1qXPyCsuTmyJDBmYyddUtjGnADwzstQ JhaVahsxbCYTLhXrBS7G+Zu69xUgwdV9XUlrY3xLktnkLcweFD2JefWA5sQ0o+DlTGFV oPUkTWCqTyFKQxJAnahMP4Bl+q1x5W9BhrhDNIRoaS5veBMrWIUw6y32ff8JL/n7T9Zk tYBQXLitzfQPs/HZtH6khC9Fzfh5RqwaIbhpIs6Eh07+gjSz/Slc96duNGq7NANkF0b3 0ywQ== X-Gm-Message-State: AHQUAuaDlLJ8g2SQLIEaUKMOAarwqq4sOOf6tGg1rGnks7mFFQDVXUzI mfknuL0UIeAbs7FEUg15YCk= X-Google-Smtp-Source: AHgI3Iaa9bjL+3NPRJAZrxJItWBKXDlUAz1szKiP7JXup9E6WJDhGEJiODHwmzdQ+JkhwtFV4OEzRA== X-Received: by 2002:a1c:a58c:: with SMTP id o134mr866669wme.79.1550074375681; Wed, 13 Feb 2019 08:12:55 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.12.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:12:55 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 3/8] kernel-shark: Check bin 0 for sched_switch event when plotting task graphs Date: Wed, 13 Feb 2019 18:12:11 +0200 Message-Id: <20190213161216.14438-4-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Handle the case when task is active in the Lower Overflow bin and the sched_switch event that close the task graph happens to be in bin 0. Fixes: ba206aaa45 ("kernel-shark-qt: Add C++ API for drawing of Graphs") Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsPlotTools.cpp | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/kernel-shark/src/KsPlotTools.cpp b/kernel-shark/src/KsPlotTools.cpp index 816fa56..f97c6e4 100644 --- a/kernel-shark/src/KsPlotTools.cpp +++ b/kernel-shark/src/KsPlotTools.cpp @@ -1020,16 +1020,26 @@ void Graph::fillTaskGraph(int pid) if (cpuFront >= 0) { /* * The Lower Overflow Bin contains data from this Task. - * Now look again in the Lower Overflow Bin and find - * the Pid of the last active task on the same CPU. + * Now look again in the Lower Overflow Bin and Bim 0 + * and find the Pid of the last active task on the same + * CPU. */ - int pidCpu = ksmodel_get_pid_back(_histoPtr, - LOWER_OVERFLOW_BIN, - cpuFront, - false, - _collectionPtr, - nullptr); - if (pidCpu == pid) { + int pidCpu0, pidCpuLOB; + + pidCpu0 = ksmodel_get_pid_back(_histoPtr, + 0, + cpuFront, + false, + _collectionPtr, + nullptr); + + pidCpuLOB = ksmodel_get_pid_back(_histoPtr, + LOWER_OVERFLOW_BIN, + cpuFront, + false, + _collectionPtr, + nullptr); + if (pidCpu0 < 0 && pidCpuLOB == pid) { /* * The Task is the last one running on this * CPU. Set the Pid of the bin. In this case From patchwork Wed Feb 13 16:12:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810297 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F77F17E0 for ; Wed, 13 Feb 2019 16:13:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D63B2DDBD for ; Wed, 13 Feb 2019 16:13:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3BAE22DEE9; Wed, 13 Feb 2019 16:13:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B0DE92DE8A for ; Wed, 13 Feb 2019 16:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404338AbfBMQM7 (ORCPT ); Wed, 13 Feb 2019 11:12:59 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43774 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733017AbfBMQM7 (ORCPT ); Wed, 13 Feb 2019 11:12:59 -0500 Received: by mail-wr1-f65.google.com with SMTP id r2so3127790wrv.10 for ; Wed, 13 Feb 2019 08:12:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iAZcpqX2XPsyR0EA0E+q40Ns0bCdALJhd58oyra0IoE=; b=U6M0XlOI6JHF8UrM4wGDWHif0HANmOt9jtJmMKZNgxaUdBs9bSmdGNYpVosOzm8IDA RE48Vd1j7R04mti9SpyMAL0jgGtAdNEKnMihLaEXIKNHj2Io3kcZjsM0Wd0ekrx0OBnt OFkNz2R6PqEaKglW5QL/53ASBNntYoSNiBp4osJWWVgWLjQXB/IoaomICsrup+Z1SJA3 X2HNKe8UezRDlt0dHn5vqLKVQrT4DMGF//4ZectFgKE2oqy3fj3VGrKFA5SDns6ee20t jY2mqNNod9c/saC+ZfMj1V3G04/FMaJTDBIQUDL6P7laE1zSSaJxdaqzS//wwTwxdl6N JsdA== X-Gm-Message-State: AHQUAubt6zfLfpOdajnIaZu+Xo1V5Sg1qp6hHACsNMvwygnLbJtLJpPp 5PhV9DZt6boA9WxvSeDskZU= X-Google-Smtp-Source: AHgI3IZTZxPhzU9wyYLH8vehCMX8QQYaG42jbVa4tnWFH6Np0PVqavCCUxRwzjM/CnLvs1pq8744+A== X-Received: by 2002:a5d:5042:: with SMTP id h2mr1049842wrt.12.1550074377413; Wed, 13 Feb 2019 08:12:57 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.12.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:12:56 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 4/8] kernel-shark: Don't use Data collection when checking if the bin is empty Date: Wed, 13 Feb 2019 18:12:12 +0200 Message-Id: <20190213161216.14438-5-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When plotting a task graph and no data from the Task is found in the bin, we check the CPU, previously used by the task, searching for data from another task running on the same CPU. However this search will always fail if we use the Data collection of the plotted task. Fixes: ba206aaa45 ("kernel-shark-qt: Add C++ API for drawing of Graphs") Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsPlotTools.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel-shark/src/KsPlotTools.cpp b/kernel-shark/src/KsPlotTools.cpp index f97c6e4..d07f414 100644 --- a/kernel-shark/src/KsPlotTools.cpp +++ b/kernel-shark/src/KsPlotTools.cpp @@ -929,13 +929,15 @@ void Graph::fillTaskGraph(int pid) } else { /* * No data from the Task in this bin. Check the CPU, - * previously used by the task. + * previously used by the task. We are looking for + * data from another task running on the same CPU, + * hence we cannot use the collection of this task. */ int cpuPid = ksmodel_get_pid_back(_histoPtr, bin, lastCpu, false, - _collectionPtr, + nullptr, // No collection nullptr); if (cpuPid != KS_EMPTY_BIN) { From patchwork Wed Feb 13 16:12:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810295 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CEA98922 for ; Wed, 13 Feb 2019 16:13:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B63C32DEDB for ; Wed, 13 Feb 2019 16:13:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A95E32DD9C; Wed, 13 Feb 2019 16:13:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BD0E2DEF2 for ; Wed, 13 Feb 2019 16:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404348AbfBMQNC (ORCPT ); Wed, 13 Feb 2019 11:13:02 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:45777 "EHLO mail-wr1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404331AbfBMQNB (ORCPT ); Wed, 13 Feb 2019 11:13:01 -0500 Received: by mail-wr1-f52.google.com with SMTP id w17so3112815wrn.12 for ; Wed, 13 Feb 2019 08:12:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4djTplACkfBDOsPGPfdNEeN0GpPv52/DN+NCFC7S/uQ=; b=rv/hSvgsZtURvWbCEhSUH7Jo9NR2R+8S885Nrz3McMP+tEEkac7FG72ztN8VXhTxLz In/xHKIDY1Ybx1sargYGjz6ej3tD0ZO8a9jcYCN3LGGuGkNKp1HXcLgnAbXYQiXtcUj+ CHzrEFsNotp1kaodpMSO7QgSagRZj8lnfRDnhd3XpWhnC236NsovP8K7EiUS9PWNkdx9 hkZTkGNBZJh83szGBdY2snyIKJ8VwKeHHT1gs39kRCf9906T24FVQoCKMb63+flH0mY0 kjHqVtTVf7da0lJXOQlfsZbQM4oFxdQkUpM1fMi8s2sjQapU6GJlt+F7CVi4mQddEM6I udrw== X-Gm-Message-State: AHQUAuaiMBiHLP/uCu8iaV6RDM+WGdLl3CrX53DdpwYimhaU8pNBw6Kv DHFTdneH+4X+JjcMtAWN7GU= X-Google-Smtp-Source: AHgI3IaYUWtctPvRW4ujYRHIms2q3gA0rWkO8XGg3d7KNmu3+W1FrmuElo0++d9ScUkuCV7VdLSsGw== X-Received: by 2002:a5d:4145:: with SMTP id c5mr1024193wrq.256.1550074379105; Wed, 13 Feb 2019 08:12:59 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.12.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:12:58 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 5/8] kernel-shark: Make the time labels of the marker more readable Date: Wed, 13 Feb 2019 18:12:13 +0200 Message-Id: <20190213161216.14438-6-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The precision of the displayed time of the two markers is set to 1 microsecond (as in the table). In the same time the precision of the time difference (Delta) is now 1 nanosecond, because we expect that the user do not care that much about the absolute time of the event, but may want to measure the interval between two events with the highest possible precision. The displayed time is formatted (spaces added) in a way that aims to make it easy to read the milliseconds and the microseconds. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsDualMarker.cpp | 42 +++++++++++++++++++------------ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/kernel-shark/src/KsDualMarker.cpp b/kernel-shark/src/KsDualMarker.cpp index 43bc177..5dcbaae 100644 --- a/kernel-shark/src/KsDualMarker.cpp +++ b/kernel-shark/src/KsDualMarker.cpp @@ -329,29 +329,39 @@ void KsDualMarkerSM::updateMarkers(const KsDataStore &data, */ void KsDualMarkerSM::updateLabels() { - QString mark, delta; + char separator(' '); + int precision(6); // 1 microsecond precision. + + auto lamSetTimeLabel = [&precision, &separator] (QLabel &l, int64_t t) { + QString time = KsUtils::Ts2String(t, precision); + int i = time.indexOf('.') + 4; + + /* Insert separators for milliseconds amd microseconds. */ + while (i < time.size()) { + time.insert(i, separator); + i = i + 4; + } + + l.setText(time); + }; // Marker A - if (_markA._isSet) { - mark = KsUtils::Ts2String(_markA._ts, 7); - _labelMA.setText(mark); - } else { - _labelMA.setText(""); - } + if (_markA._isSet) + lamSetTimeLabel(_labelMA, _markA._ts); + else + _labelMA.clear(); // Marker B - if (_markB._isSet) { - mark = KsUtils::Ts2String(_markB._ts, 7); - _labelMB.setText(mark); - } else { - _labelMB.setText(""); - } + if (_markB._isSet) + lamSetTimeLabel(_labelMB, _markB._ts); + else + _labelMB.clear(); // Delta if (_markA._isSet && _markB._isSet) { - delta = KsUtils::Ts2String(_markB._ts - _markA._ts, 7); - _labelDelta.setText(delta); + precision = 9; // 1 nanoseconds precision. + lamSetTimeLabel(_labelDelta, _markB._ts - _markA._ts); } else { - _labelDelta.setText(""); + _labelDelta.clear(); } } From patchwork Wed Feb 13 16:12:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E5265922 for ; Wed, 13 Feb 2019 16:13:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D309B2DDBD for ; Wed, 13 Feb 2019 16:13:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D15992DD91; Wed, 13 Feb 2019 16:13:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 750902DEF0 for ; Wed, 13 Feb 2019 16:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404331AbfBMQNC (ORCPT ); Wed, 13 Feb 2019 11:13:02 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:34626 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404347AbfBMQNC (ORCPT ); Wed, 13 Feb 2019 11:13:02 -0500 Received: by mail-wm1-f68.google.com with SMTP id y185so2235098wmd.1 for ; Wed, 13 Feb 2019 08:13:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mKs1zarKSC8o1Uy90Brrsr+wBlmMCuceYalzEjoBYt4=; b=ekd0KgMdkSGnloLUwlCjuEgz9SuuNbBvv32P5ZccaNDFO+2LPvPICqAzcUXhpSQmg/ INxbu6wisr39E0i87F8O5EsiMzqRiw8dc5eK2Nyk6fmbQzmkaWO8WZA1s2tAT8gFzyW3 4mmYAN5j8kzjfiPueAqCRRs4HUoDqBnTECKKBCvs7HPIKSbYj4/ZFZ1mkvEhel2SOwsu d1qPsW68gFnbcNcL1/C3sOypllPbjTLydUuwB4428mMiLteAWpppQsvT+yPlrm7PJem3 EqxODgEvtaXyu5SgL8pTEIMAt8/RRnU2N7MfcqYHUao99HcAhpAblDSNJFpux0Kw8fFC v6zA== X-Gm-Message-State: AHQUAuYhUCHwTjYI5OwquNRI8WjLcMXftMwOYxldd5Tod7hEXQL9klET 2R1ZF4ZlUefO17cfCeseg/0= X-Google-Smtp-Source: AHgI3Ia+qybbPRmPMhWan0yTdYD3DGCR35T81ZfW2bli5SWhaym88JYQPsqGdO9dZm+Eusxs3jRuBw== X-Received: by 2002:a1c:c008:: with SMTP id q8mr818983wmf.99.1550074380616; Wed, 13 Feb 2019 08:13:00 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.12.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:13:00 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 6/8] kernel-shark: Fix the compile warnings about _GNU_SOURCE being redefined Date: Wed, 13 Feb 2019 18:12:14 +0200 Message-Id: <20190213161216.14438-7-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes wornings from: kernel-shark/src/libkshark-configio.c and kernel-shark/src/libkshark-plugin.c Signed-off-by: Yordan Karadzhov --- kernel-shark/src/libkshark-configio.c | 4 ++++ kernel-shark/src/libkshark-plugin.c | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/kernel-shark/src/libkshark-configio.c b/kernel-shark/src/libkshark-configio.c index d7b8a69..ab88864 100644 --- a/kernel-shark/src/libkshark-configio.c +++ b/kernel-shark/src/libkshark-configio.c @@ -10,8 +10,12 @@ */ // C +#ifndef _GNU_SOURCE /** Use GNU C Library. */ #define _GNU_SOURCE + +#endif + #include #include diff --git a/kernel-shark/src/libkshark-plugin.c b/kernel-shark/src/libkshark-plugin.c index 10e4647..4b21392 100644 --- a/kernel-shark/src/libkshark-plugin.c +++ b/kernel-shark/src/libkshark-plugin.c @@ -10,7 +10,12 @@ */ // C +#ifndef _GNU_SOURCE +/** Use GNU C Library. */ #define _GNU_SOURCE + +#endif + #include #include #include From patchwork Wed Feb 13 16:12:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7554F17E0 for ; Wed, 13 Feb 2019 16:13:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 643712DEC1 for ; Wed, 13 Feb 2019 16:13:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 58EDC2DEEE; Wed, 13 Feb 2019 16:13:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC2452DEF0 for ; Wed, 13 Feb 2019 16:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404349AbfBMQNE (ORCPT ); Wed, 13 Feb 2019 11:13:04 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40139 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404347AbfBMQNE (ORCPT ); Wed, 13 Feb 2019 11:13:04 -0500 Received: by mail-wr1-f67.google.com with SMTP id q1so3145118wrp.7 for ; Wed, 13 Feb 2019 08:13:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dA42NAyp03OmKSnXPKzpIZYNjCBZS1suUM1XVRJ8X2Q=; b=ruEcghU152EO2H1lKw+fQOwm23QOILaoh5sS/k51iCLI4bYgrmMofxy4i2Mei55ieK wTl/6Ydx49zv1hkRAdam4aO5L9+yliZ7HVM2aEosr9Lnh6lDl56xnUJQO2d+jPBI6q21 RshlH4rm7flZaU55g5BIG0MztSB2AyU0DpLPjoedgQS5FMH1PBPvO2LNg5TymXK2Zy9j BAihEiDF0Tm/5+Z9uAO0h3qiJApsihpUeJtNahj53iWTuAFub4C3+YXBARr+fJNN8IwG CKEIqZk9IIx5DDx0mS4h8El0oDy62t/090a68PGMjPsQSb8Q3Qz2iwK/zu9QY6BCmsrn z4Ow== X-Gm-Message-State: AHQUAuZV/WbxkIBMDPF9pdZ5e5dsTnXCL95L4kXeJ2EHrQ1oKWkTtCTC 26VoyP1OgoowQQSXqE/IRMvPjDpB X-Google-Smtp-Source: AHgI3Ibm5DAQXZkW4S/CQl7esTc+IKbmI/mBoWfX0B6jMURE+Omjmjb2feop6YVVjb0MLIburhKOqA== X-Received: by 2002:adf:d0c9:: with SMTP id z9mr1029442wrh.132.1550074382420; Wed, 13 Feb 2019 08:13:02 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.13.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:13:02 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 7/8] trace-cmd: Fix the printout of the KernelShark executable path Date: Wed, 13 Feb 2019 18:12:15 +0200 Message-Id: <20190213161216.14438-8-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Adding ‘@’ to the line that is echoing in order to suppress echoing the line itself. Signed-off-by: Yordan Karadzhov --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index f0f7e92..b780718 100644 --- a/Makefile +++ b/Makefile @@ -258,8 +258,8 @@ $(kshark-dir)/build/Makefile: $(kshark-dir)/CMakeLists.txt gui: force $(CMD_TARGETS) $(kshark-dir)/build/Makefile $(Q)$(MAKE) $(S) -C $(kshark-dir)/build - echo "gui build complete" - echo " kernelshark located at $(kshark-dir)/bin" + @echo "gui build complete" + @echo " kernelshark located at $(kshark-dir)/bin" trace-cmd: force $(LIBTRACEEVENT_STATIC) $(LIBTRACECMD_STATIC) $(Q)$(MAKE) -C $(src)/tracecmd $(obj)/tracecmd/$@ From patchwork Wed Feb 13 16:12:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10810303 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DBEFF13B5 for ; Wed, 13 Feb 2019 16:13:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB2F02DEDF for ; Wed, 13 Feb 2019 16:13:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C969A2DE6F; Wed, 13 Feb 2019 16:13:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 770AE2DE6F for ; Wed, 13 Feb 2019 16:13:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404350AbfBMQNJ (ORCPT ); Wed, 13 Feb 2019 11:13:09 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:56134 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404347AbfBMQNJ (ORCPT ); Wed, 13 Feb 2019 11:13:09 -0500 Received: by mail-wm1-f66.google.com with SMTP id r17so3085671wmh.5 for ; Wed, 13 Feb 2019 08:13:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fC08RJNBECFF0zrX5WZNBuB/w7yIiuy3nkjIvVmaKJk=; b=D2IG/w+PdB2MaHmyjFvvkObXS/Pw6Ytzb7HXEnKMfs3jsZwQ+2DoMtA+aZpGOw26ge /xwS9V/j44BuWH8YABRpZ5Zv659RMupfnWi0vmQO5IXXEjP/u5XTEff46TkXMIuIGThK DjBFnaibaJ2X45eNWezO7VZlgQtGfc8szSLRyOPCIfgQHW3tycHDo2iv39e5yz4M+yfz VBxNvZZmcWKxh9BgFsRSAoI3n/5fkU9h5Rjvtx8PDbg053wWc7/jysktW8sLMAurDODZ 1Q5Jh+o8iGRJDAfcdQbHmBUaFjDxA+Fq8r8huTDgKI1RuTIoh+MS/R352s1lUqOIcOkr CE6w== X-Gm-Message-State: AHQUAubpBK7cEkt9I9ZfFBQ0t/U199UypkcW1xLSEXFnEfANZK3JAc+D WarJUtfirLNwRuC9u6vh4Wc= X-Google-Smtp-Source: AHgI3IbP4JzHpfMXzBt3yk+WsXDSzYXgH/X9jHtnf+xIhWbVx+5ovx1bUmgJfcUJ8MCSPklBgtHcGQ== X-Received: by 2002:a1c:47:: with SMTP id 68mr865591wma.89.1550074387116; Wed, 13 Feb 2019 08:13:07 -0800 (PST) Received: from localhost.localdomain ([95.87.211.218]) by smtp.gmail.com with ESMTPSA id h9sm3111631wrv.11.2019.02.13.08.13.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 08:13:06 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 8/8] kernel-shark: Version 1.0.0 Date: Wed, 13 Feb 2019 18:12:16 +0200 Message-Id: <20190213161216.14438-9-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213161216.14438-1-ykaradzhov@vmware.com> References: <20190213161216.14438-1-ykaradzhov@vmware.com> Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Yordan Karadzhov --- kernel-shark/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt index 9460026..a1859af 100644 --- a/kernel-shark/CMakeLists.txt +++ b/kernel-shark/CMakeLists.txt @@ -4,9 +4,9 @@ cmake_minimum_required(VERSION 2.8.11 FATAL_ERROR) # Set the name and version of the project project(kernel-shark) -set(KS_VERSION_MAJOR 0) -set(KS_VERSION_MINOR 9) -set(KS_VERSION_PATCH 8) +set(KS_VERSION_MAJOR 1) +set(KS_VERSION_MINOR 0) +set(KS_VERSION_PATCH 0) set(KS_VERSION_STRING ${KS_VERSION_MAJOR}.${KS_VERSION_MINOR}.${KS_VERSION_PATCH}) message("\n project: Kernel Shark: (version: ${KS_VERSION_STRING})\n")