From patchwork Fri Nov 3 23:34:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB617C41535 for ; Fri, 3 Nov 2023 23:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbjKCXft (ORCPT ); Fri, 3 Nov 2023 19:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjKCXft (ORCPT ); Fri, 3 Nov 2023 19:35:49 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2915D5A for ; Fri, 3 Nov 2023 16:35:45 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6b5af4662b7so2526458b3a.3 for ; Fri, 03 Nov 2023 16:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054545; x=1699659345; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VSqLYgRbivKKnYF2aYcQthhro+1b5nXgEwvXxzPNrJI=; b=Xpudmcym95weo5RMydYrt3wBcmheGvdph6nKmkUnU/Ms2To1kqu9g6HiijwWWmWO3r MHjQ5cT0Ea3uTmQb71ASJVsSO+cZKzi+o+rOoZ2ZIE+P9A0qtXsuK2z6HSsPkpdNntl7 NrikQ6u03vqSS2PDSTs0Q3T1b5jmFyajs/1Dc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054545; x=1699659345; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VSqLYgRbivKKnYF2aYcQthhro+1b5nXgEwvXxzPNrJI=; b=Wm/el2srkdwZNcn/XJvvQNW2RETW6EM1TsW161wA1nLHr7Jc0o3Sm0J7L5exIuH5j3 gp1yh5sErYTWuUQtSDWGH5xbgsC5Rj5qVn92XWj+CKRQsUaDV2osGNWvPpW49H7jvEJh t5UFIWteDVS+xTdMF5CyN6f8XxhHuSxzOctyrs3blZsg+vxYqLgaatPilXvSFD3nAcmQ i8EU2Oth5ZPU77LRXOfOIy3KkrhlVfRd7GgvHUvkc+mtju2bZY8qUw898F8MFDieYIp2 gVUdGIRtDza/yjcDvUow1HpbgEf7ubJwB5FB2gRx8m83Pwntuhh6u/oyrZz5LjyMhVIK 3+fw== X-Gm-Message-State: AOJu0YzdEW4gbh9h9tyLA4MiqxUixnukTn94a2LLK04jdYCSjiRnAwf+ kzkz7eop2CF1INjV2+aXQQf48Q== X-Google-Smtp-Source: AGHT+IGivJm72G8Ok/Dga94KQLsX+IkSW0u6XGPI33zFZ+PCZIj6TFlSL7IcmjdbwjmZbUt1yJ1mbg== X-Received: by 2002:a05:6a20:938e:b0:180:7df:76a4 with SMTP id x14-20020a056a20938e00b0018007df76a4mr19623287pzh.45.1699054545136; Fri, 03 Nov 2023 16:35:45 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:44 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , "Guilherme G. Piccoli" , Kees Cook , Sai Prakash Ranjan , Tony Luck , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:27 -0700 Message-ID: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On sc7180 when the watchdog timer fires your logs get filled with: watchdog0: pretimeout event watchdog0: pretimeout event watchdog0: pretimeout event ... watchdog0: pretimeout event If you're using console-ramoops to debug crashes the above gets quite annoying since it blows away any other log messages that might have been there. The issue is that the "bark" interrupt (AKA the "pretimeout" interrupt) remains high until the watchdog is pet. Since we've got things configured as "level" triggered we'll keep getting interrupted over and over. Let's switch to edge triggered. Now we'll get one interrupt when the "bark" interrupt goes off we'll get one interrupt and won't get another one until the "bark" interrupt is cleared and asserts again. This matches how many older Qualcomm SoCs have things configured. Fixes: 28cc13e4060c ("arm64: dts: qcom: sc7180: Add watchdog bark interrupt") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 11f353d416b4..c0365832c315 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3576,7 +3576,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sc7180", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Fri Nov 3 23:34:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77AA2C0018A for ; Fri, 3 Nov 2023 23:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229461AbjKCXfv (ORCPT ); Fri, 3 Nov 2023 19:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229973AbjKCXfu (ORCPT ); Fri, 3 Nov 2023 19:35:50 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98CD4D5F for ; Fri, 3 Nov 2023 16:35:47 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1c9c5a1b87bso20541855ad.3 for ; Fri, 03 Nov 2023 16:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054547; x=1699659347; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=glqKkAPKAL3EHMHf844juTHG+DunzJOhi1xGd5NnG1c=; b=YIoppzqAkJO3cS+fn1+y1jvWXp+Rm5ZD3IMcFOEqKbj5a5Vv3nlTIwTfYAe+v0FkTw Qu+qBwFIn+Y2wOZM0DrhT+Nu2X+j1REkiwVyWAlklXIWqAlzeoHuZ9MbbgDMTn8XG9qZ IKeJ+fzpJI3Jxbp95QxqM1j572end4SyiInPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054547; x=1699659347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=glqKkAPKAL3EHMHf844juTHG+DunzJOhi1xGd5NnG1c=; b=ExI/9f6qPcRb/CYMhTMa8v2O3yhlfOzvZMND++EYH2ElF6WQVxC5evgiZGnRs4Cst/ Mibmd3zVSfJI4GVB2eRn+nIKU8j3ksdZFlwtVJ0lZRGlK2/TvQuAdtJI0LAkyQjdGDy7 Lhos7n9BOahBQLPGWVAw2umvJOIalTj+Rc69U74Eci2mefi9oqVNh+e9GxnJlw+9EOFP BnJPC8DIW4a0CWkY+JUKms2f5ywhNHQH4w2TqCu1gPr8buf1a4zH3aL9c8B0dH8su4Gx LTW9/Fl8Y+xQodIRqYpSfMWR4UbTZDO4DJcZjmkbAOeTJq568dqIoweQ09OAWPgqI3bu p6Xg== X-Gm-Message-State: AOJu0Ywx+5yCtjA6Q8IkrR3An73SXrEOWUOgiq+bRZb+k5RRhOnRePDs eD24EXKU1CTeBgve2VKD6/z0sA== X-Google-Smtp-Source: AGHT+IESldym4inn9YATUmmbeyfTvQh1Z0+qOzIN7GxWrFVd6kUFyFVEeE0OwqhAo/+IL9HHXCZF+w== X-Received: by 2002:a17:903:11c8:b0:1cc:7ebe:4db6 with SMTP id q8-20020a17090311c800b001cc7ebe4db6mr9731129plh.39.1699054547026; Fri, 03 Nov 2023 16:35:47 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:46 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , Rajendra Nayak , Sai Prakash Ranjan , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/9] arm64: dts: qcom: sc7280: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:28 -0700 Message-ID: <20231103163434.2.I11f77956d2492c88aca0ef5462123f225caf4fb4@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 0e51f883daa9 ("arm64: dts: qcom: sc7280: Add APSS watchdog node") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 04bf85b0399a..1964ef66492f 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -5389,7 +5389,7 @@ watchdog: watchdog@17c10000 { compatible = "qcom,apss-wdt-sc7280", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; status = "reserved"; /* Owned by Gunyah hyp */ }; From patchwork Fri Nov 3 23:34:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0032CC4167B for ; Fri, 3 Nov 2023 23:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231322AbjKCXf6 (ORCPT ); Fri, 3 Nov 2023 19:35:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230486AbjKCXfw (ORCPT ); Fri, 3 Nov 2023 19:35:52 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64EBBD5A for ; Fri, 3 Nov 2023 16:35:49 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1cc5b705769so23455925ad.0 for ; Fri, 03 Nov 2023 16:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054549; x=1699659349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mw+uldh2RwvGjKOhMreCBsCH8sZS6gcDHUS2RnYpsko=; b=Hpl4ZxsFpgsqWlj5Ny8O3WhgqFihKaBz/L6zLNDczsJZcrsa2MpyUbREr7v4k2sJlE xPQDWbOCIiHohVeL+zqPJf+nkUfsdwoRdDFqgTpvZrBcF27SNhdvoNI9bYtVeHNrClCx VDJL4kS3PWfKQ7i39gTg9AGE7bBwr0lX41ATY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054549; x=1699659349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mw+uldh2RwvGjKOhMreCBsCH8sZS6gcDHUS2RnYpsko=; b=o6pTkQ2gWWWBspYFRfDUpdC3BTFUPLqekWR7xpwSIzqiD7QCS58WqCHONBgkwJ6sWr MjmDabuZEyidOEz0SeGyIBtNMoIbzkGdz7lg6zfq7WRPPnT/uC1v3h6M+7Mxxci6lMMX OksANmjRQg4V8GUgyh1i+6zlleClNTzhyUt6BLretJFE1HF98WjU1ZQ/oJXB+0PlDNQv 4wiZafvmdorglNIXs1LCGcsCEMrGvsfluo23LlkeDWQwg22GhA5ScwVqUuy1k62siOdY 38/YLu2ZiNX5m3yf4qhhs9mAbnh3zAdfFxcz4cvWfloT+T2OFUAnQ3G2M/rM8ToxkRm7 icOg== X-Gm-Message-State: AOJu0Yx6gi/ODVs4GVoauXpw1ll/nOyc9x7drEbYXYev9fvLjeJybsmX bY97AQOQofp2hnwaboi3RXEdXA== X-Google-Smtp-Source: AGHT+IEy9cZdR6sRdDcPylg21w3fn21uHyJ53vSXSY9OJb00KDbf/ag2V5ENuIhA6oI9Qy/7dL4rzQ== X-Received: by 2002:a17:902:dacc:b0:1cc:4677:2f0e with SMTP id q12-20020a170902dacc00b001cc46772f0emr21613646plx.45.1699054548862; Fri, 03 Nov 2023 16:35:48 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:48 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/9] arm64: dts: qcom: sdm845: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:29 -0700 Message-ID: <20231103163434.3.I16675ebe5517c68453a1bd7f4334ff885f806c03@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 36c436b03c58 ("arm64: dts: qcom: sdm845: Add watchdog bark interrupt") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index bf5e6eb9d313..9648505644ff 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -5088,7 +5088,7 @@ watchdog@17980000 { compatible = "qcom,apss-wdt-sdm845", "qcom,kpss-wdt"; reg = <0 0x17980000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; apss_shared: mailbox@17990000 { From patchwork Fri Nov 3 23:34:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445278 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FBCAC0018A for ; Fri, 3 Nov 2023 23:36:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231425AbjKCXf7 (ORCPT ); Fri, 3 Nov 2023 19:35:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231147AbjKCXf5 (ORCPT ); Fri, 3 Nov 2023 19:35:57 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A362D6A for ; Fri, 3 Nov 2023 16:35:51 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1cc53d0030fso21571325ad.0 for ; Fri, 03 Nov 2023 16:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054551; x=1699659351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zz68Dpk5/BPogrJUoLb+ojt78NoitxE3Zt6yEq9LG2U=; b=momXYVMY+bw+3Dv62fdAW7nOnWhR68hRjnpbXq59K5XvakR4hadBzJAgaVHEi89cKJ dvMNHjQSAvReZ1SX+WzvnjoJBkrJ06J6Tb9u4+QoThxtjwqmUrRXIjt8VLEO25jYY4SV ntjHz7PWlTVFCUxFRs4DAT+x9ku5v+xalby6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054551; x=1699659351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zz68Dpk5/BPogrJUoLb+ojt78NoitxE3Zt6yEq9LG2U=; b=DR8dXGKmfC7ARH2fyuAYEHQ6AOgd+TS29x0FN5rwdpG2ymvxiiH6rfwv57600Z+BAN /GOm70bbkjvd/lbGJN3ucPuReqeUBFzUKESDStBSTs+S0ccWLFn2NDD/sEo3HLC1tr8I l9aBaxzKQNvHubwKWI3Euqyidchx/8jVgwklDQMqsjtp+FPFxgzVCq7kLEMtjzPN94wt 8zpuaT39YhOBw+cqp94wE0K3WFA/TjelWbqpnVKiYVJe/Uk3a6abEPxGNlFTGfzOEaQo EhA+vEdtzlWiRos08P8OqjE6Ike/09sMIa2XVIVcnk+QCPYfBgOzEmwJefabi927Q7iA RIiw== X-Gm-Message-State: AOJu0Yz9hpt158hYxmlhMQWp04pCiJjrDA1/s0BsFS/cee4TDtDVZLTu A0qywUvSpSlKcUmgIDYTfwbFyw== X-Google-Smtp-Source: AGHT+IFK1hHfcpBeh0knlfyxQFyC6Jxkd70kmnEy3Aot5NkHmsPwatjZSDR3YYJuCABjHH3P6t4sxw== X-Received: by 2002:a17:902:c40c:b0:1c3:e2eb:f79d with SMTP id k12-20020a170902c40c00b001c3e2ebf79dmr5655555plk.8.1699054551130; Fri, 03 Nov 2023 16:35:51 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:50 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/9] arm64: dts: qcom: sm8150: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:30 -0700 Message-ID: <20231103163434.4.I23d0aa6c8f1fec5c26ad9b3c610df6f4c5392850@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: b094c8f8dd2a ("arm64: dts: qcom: sm8150: Add watchdog bark interrupt") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 97623af13464..ad4fab61222b 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -4170,7 +4170,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Fri Nov 3 23:34:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1980DC001B0 for ; Fri, 3 Nov 2023 23:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231580AbjKCXgA (ORCPT ); Fri, 3 Nov 2023 19:36:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231390AbjKCXf6 (ORCPT ); Fri, 3 Nov 2023 19:35:58 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC96BD78 for ; Fri, 3 Nov 2023 16:35:53 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1cc58219376so23775155ad.1 for ; Fri, 03 Nov 2023 16:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054553; x=1699659353; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XoOyn7ZU2hMXx7hgfAQE4i5cJVVLZXv3kQJ/BlZC4zM=; b=EEfTxfVAYYU1Ai0rReDxmia/xQ+70WFKt20A8sYqI6MDD5E2WqAE+JZyRDdAYNjDs/ Nv3RlFyJZTYfxxbVwnzn/iiXsV/IDWcptJSgwItfKR0caAVNCTxihqtxuobsr5lf0ZP5 Jxh1k0Qpt831qcZz/azEH/Ea8C6E0531z+0Vg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054553; x=1699659353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XoOyn7ZU2hMXx7hgfAQE4i5cJVVLZXv3kQJ/BlZC4zM=; b=wE0w48kqwZh6BJB21RC6SgLzg9mcOCxshvckl0/wqadNY7E1h9LXMau0bPmlw5TbKk vdgkLXHnhJZxMMCBWW7tVyK9FtZd3JqRg8MQ2wDYKyEDyU4iYr3XsXkUw4EkMInj3Y9v CpV6WdF5YacGJPjxoW7T4EApmLZ59e7xeX2jFChVslEZScuFbCKOjopVoX2fkMZ+PsXH AsWOVd1g/w/JwrXwR0nvA42SWEkTMkaMu2PCzikk9W6GpNNg45K+1IikDM87vLmItzO7 htGkvITpdIdPd86Qx32HhqSmGQ15cnHCihaycO2gCJddpTcoZr6XgT1VYWKhVNGbd7Kd tF6A== X-Gm-Message-State: AOJu0YzsHZ7XyxbuXQU+QqiKjAJfwQMMCki5zniWfxcO9qhheiw2WBYc BMcSuEUwOojBP/WwGxTmhIXGOg== X-Google-Smtp-Source: AGHT+IHlJZV6Zi12fevoNRAI0nCJ5nZ2LsBAkFmVa3HGcoUhsACMAoJS8o5w/mEXDqBuOA0dOx8SmQ== X-Received: by 2002:a17:902:b593:b0:1cc:ab06:e6c8 with SMTP id a19-20020a170902b59300b001ccab06e6c8mr2351313pls.19.1699054553182; Fri, 03 Nov 2023 16:35:53 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:52 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/9] arm64: dts: qcom: sm8250: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:31 -0700 Message-ID: <20231103163434.5.I2910e7c10493d896841e9785c1817df9b9a58701@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 46a4359f9156 ("arm64: dts: qcom: sm8250: Add watchdog bark interrupt") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index be970472f6c4..72db75ca7731 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -6018,7 +6018,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sm8250", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Fri Nov 3 23:34:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445280 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F80C0018A for ; Fri, 3 Nov 2023 23:36:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231726AbjKCXgF (ORCPT ); Fri, 3 Nov 2023 19:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231492AbjKCXgA (ORCPT ); Fri, 3 Nov 2023 19:36:00 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F04C0D5A for ; Fri, 3 Nov 2023 16:35:55 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3b512dd7d5bso1662097b6e.1 for ; Fri, 03 Nov 2023 16:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054555; x=1699659355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wiEUlSSWbK5aXGpKKuCRTpJDpYU9/xeKROGc7SoElvk=; b=B6/ey8VjF83LjlQVn34uVtjab9DcyPqw+TxXsNumuvLMj+ub2Oz7xj2qz9YMX8vh5G 59ua6kgBjCNy/uFUnRQD7XNnaJArAghsaCJ9KX5cc+2OaSu/BgqttgbM6dFIs5rxmPHK 5qpg5SQbnH3gDMw1snuT1gZ5wVRjDX8NLcRH8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054555; x=1699659355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wiEUlSSWbK5aXGpKKuCRTpJDpYU9/xeKROGc7SoElvk=; b=GKoME6XsTaDvl7GoAhHmYanOyy5MGAycDYMEHrRLx8wNIYs8uKlo+sPj8m+GIQ2f9r NKIN3xTDmx5JXPI6FPrI3IXbCkW/FeAM1pIOTYSFgtCrau2m7045Z38PCqyVUQ94oSyo VW/YbPAx7pF6J2kXNFqRfzuiVSSmqQp0QgRZN+IOTUt89aiAR8SBG+oGnZrtOVUUIrV6 FzdLUv9BrT2Jtk8EsinikfZvxsPA6fLQfH+AUX+3sxEkOrc/9z1UqWXbeqFu2NV7L3z9 NlkCyQyGzdP4UqtKiK+SUAI+cWVnTn8DkXHFUa4qhsTD82/s6LXElDl3D3YvdWfg0GQT YePA== X-Gm-Message-State: AOJu0Yx5x+0ERwUqlwJwGRgaFf39nMfZr1dYWDPmOlhINce9KG7nDnAb VGqu3+eAaaGH2oNwi+tnSrT6gg== X-Google-Smtp-Source: AGHT+IGNXKE0Eqvr+nKt0x8vTGl4sK2fVjOqSWGGsG2ZJ//eLO5dLTdecPHWuOKBgiXWqY2m5Ti8SA== X-Received: by 2002:a05:6358:e49f:b0:169:8140:adc1 with SMTP id by31-20020a056358e49f00b001698140adc1mr18817714rwb.7.1699054555121; Fri, 03 Nov 2023 16:35:55 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:54 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , Bartosz Golaszewski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/9] arm64: dts: qcom: sa8775p: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:32 -0700 Message-ID: <20231103163434.6.I909b7c4453d7b7fb0db4b6e49aa21666279d827d@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 09b701b89a76 ("arm64: dts: qcom: sa8775p: add the watchdog node") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 13dd44dd9ed1..6b92f9083104 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -2235,7 +2235,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sa8775p", "qcom,kpss-wdt"; reg = <0x0 0x17c10000 0x0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; memtimer: timer@17c20000 { From patchwork Fri Nov 3 23:34:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C68FC4167D for ; Fri, 3 Nov 2023 23:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231592AbjKCXgI (ORCPT ); Fri, 3 Nov 2023 19:36:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231652AbjKCXgB (ORCPT ); Fri, 3 Nov 2023 19:36:01 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8D6D6F for ; Fri, 3 Nov 2023 16:35:57 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6c3443083f2so1891113b3a.0 for ; Fri, 03 Nov 2023 16:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054557; x=1699659357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xb8JsrX5d6MFcJDdSA4UiCRqCBZzbS6joY26UIgwWL4=; b=GtQIQU4SLxZlb2bm7rrC43JN6bYg4YGugmo9AWLNo5pRYD9vIN/w7EDhF5zGOSp0+j 34gNThY1Yhkb6FoAZFxi4aCe4FS2mshF02UWv1j35rA3X4dvhCo+ykeRESMy+fIVgHLW 0V6ZsWcp1eKyzdDiToYTxbLXqSausfu1aoR9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054557; x=1699659357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xb8JsrX5d6MFcJDdSA4UiCRqCBZzbS6joY26UIgwWL4=; b=LGV1wqXL9kJ5c9qp9yw8hUMIOZJ3EkKSnnsoPdsD8wP90x540INC8y2tOKS+lGcswF uqLs6DVCgp3SRvAvoiiMDv7+qvBRD3yCCJrd8crhLwkvUZHbfPCq6wFCIMxDiXnIDU0O Erf3NHl65yFkfIbTMIXiZpe0GHaNjI5oCAYFoylsy7634MzW/a0mkxA2kmTA8KScJGYv OwWPZBz/n6sLJSuMrMMoGT83YM8gocAd48WRZ/B01xkPue+6HSW4yE3Y7H/p83q3ex2d EKIbxDsLQn+VAp+rzrtrCsoFedOpkitbPBJvr2uUFxI4Cpo9G1/afM2Lx+4xLoTL/kYH sAIw== X-Gm-Message-State: AOJu0YwSBGQZuMGuwHkh07RxKHCPpJqfaDg5P5IrPpJ2bDWpvme35pM3 hC74XHPXb8Au/pLEnRUC+BtaWg== X-Google-Smtp-Source: AGHT+IHZFtWMPycHBKtwCqbtmyUlVrCGcQ2vWizPaYDMhaiamQlC/2iMPYNgM07+ZC14dALGWDhH8Q== X-Received: by 2002:a05:6a21:71c7:b0:181:261f:f346 with SMTP id ay7-20020a056a2171c700b00181261ff346mr10955837pzc.26.1699054556970; Fri, 03 Nov 2023 16:35:56 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:56 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , Johan Hovold , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/9] arm64: dts: qcom: sc8280xp: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:33 -0700 Message-ID: <20231103163434.7.I1c8ab71570f6906fd020decb80675f05fbe1fe74@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index cad59af7ccef..b8081513176a 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -4225,7 +4225,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sc8280xp", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Fri Nov 3 23:34:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445282 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178C4C4167B for ; Fri, 3 Nov 2023 23:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231357AbjKCXgL (ORCPT ); Fri, 3 Nov 2023 19:36:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231367AbjKCXgC (ORCPT ); Fri, 3 Nov 2023 19:36:02 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DF71D7A for ; Fri, 3 Nov 2023 16:35:59 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1cc3bb4c307so26994745ad.0 for ; Fri, 03 Nov 2023 16:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054558; x=1699659358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f1BlnpLKRujmj++l/dAo18/lb6NbFp3/th0VKiPzT+I=; b=O+fHFKu7OrbA8r/9UBvLMQF7TBJZFiAerfsEcmkBqiv6w8Lb5cCyr0jkWXhTPiGx5D f7pEDPaJZqcRoO/2l0MKK4DfLkx3006xd8lqV1UUcf/BhiMh06CmLWQdeBxcM/Y6KAyb M0Q/MGejeiGQXrnih+HadgcTmIqTE3YH/Ngpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054558; x=1699659358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f1BlnpLKRujmj++l/dAo18/lb6NbFp3/th0VKiPzT+I=; b=W78p5f2llGk/RkQWY2NiD6l8P7ZTchnuFwTReUtUwnDQpBvXu0VL0C20NfM/0eQsdg OkpBuGBe5A7zviH/bmH91+hgVv1sfwf0hVOGobpQJQ+ug5fJnmvMaeilu67drCrjb/It K90d4BYeyllMbV0SRiF7+zMsfjXm2ytHh0JHbVti0b/+1pCyX+8FL/4evdNZLinJe787 3rhGTLjMIUi1FHqVdnYlV9pHwytPvI2/KYj/aVMYosncVnlOkbbhTlnxILN3PUA6TDHI q5ImqMLhkK6dbgn8MLlSTdyfX313NevloA2DDwzfupRRkg/gxhO6NwqbVM2cTtWjNmgU IPvw== X-Gm-Message-State: AOJu0YwMUX2minsNzDywMR3xlqTr5kxxWKJtCstaLxmQBORcSlZLxG7C xQmNtfJkTyMiyNZSFongLnrqwA== X-Google-Smtp-Source: AGHT+IGiKPEOOZ6icuMTp8Vu2YYI0J74G85B7ofaE4byNM28eWtIGjWhTQ1O9/bkWhFhSoGq0O8KIw== X-Received: by 2002:a17:902:d2cf:b0:1cc:3302:7354 with SMTP id n15-20020a170902d2cf00b001cc33027354mr17375680plc.17.1699054558674; Fri, 03 Nov 2023 16:35:58 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:58 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 8/9] arm64: dts: qcom: sm6350: Make watchdog bark interrupt edge triggered Date: Fri, 3 Nov 2023 16:34:34 -0700 Message-ID: <20231103163434.8.Ic1d4402e99c70354d501ccd98105e908a902f671@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 5f82b9cda61e ("arm64: dts: qcom: Add SM6350 device tree") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 8fd6f4d03490..6464e144c228 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -2524,7 +2524,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sm6350", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; }; timer@17c20000 { From patchwork Fri Nov 3 23:34:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13445283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F546C4167B for ; Fri, 3 Nov 2023 23:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232383AbjKCXg1 (ORCPT ); Fri, 3 Nov 2023 19:36:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231788AbjKCXgG (ORCPT ); Fri, 3 Nov 2023 19:36:06 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AE9510D1 for ; Fri, 3 Nov 2023 16:36:01 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1c9b7c234a7so23669335ad.3 for ; Fri, 03 Nov 2023 16:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699054560; x=1699659360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z1s0HtUb56FJexT+QBsAgKXm2XZYTg/G7gzdgJqBk4g=; b=ivw3kAB0wg+FRoxBawA14FUFgASd0Y39q+vgLD3W2KoDZ7qJ1PgQ2FZBmnsF2gfSz7 qe0FdAYZxE8Sz0yq9jE2efW35v82vXJEhaSTFkDiR+UIq4Grf3LDlatkP1pA0VW7xLHo f7h+Z8IT1sEySKjdm078vBpQxgQCbjp/HPEp4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699054560; x=1699659360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z1s0HtUb56FJexT+QBsAgKXm2XZYTg/G7gzdgJqBk4g=; b=sEswnyPzvN6K9cy5pUsB6EDci5/jVXTXi9JkNnfH/TvAXhOAtBqst1szOJvNyBY7GG UJKEIUNNPBNwO+JjVDbyh2Cuf+N6irwJYmu0nij9SF8i3jYTOyRwH0fEmIwx/uLWQQus OlIKto8HmFSmIDZZjaizz7k+lYztTBZqOvJDWwj0ExbXgqiOdbD0sjpGFHmQ3yojarVX 8EQbuz6JmX6CWvNjwzBEkjSEX51zqF1ZBtmeNCj08KPD/cu7BCrg3FjmqQ/lLrhv0+u5 u1fqNqtZVzDd0C68sG6aFcNa8X58ln2yPynHf8nwgb5fR3ePWdRVGaSJsSjlDHnm5QuM u1/w== X-Gm-Message-State: AOJu0YzUOuX0JmGoxIVeL41SEHhDGJvn2yNuVSdZoW/Kdw4MwTijrk17 hj12E/08gm2mbJSvNaeJ95NWwg== X-Google-Smtp-Source: AGHT+IFQR7Nep3YfpY2xPcCAywlJbGHYPaDT0QE2ucIjE0ouT2fVM4EsiBFgSd7g4MIqCTN/Acs+Yw== X-Received: by 2002:a17:903:1390:b0:1cc:2f05:7edb with SMTP id jx16-20020a170903139000b001cc2f057edbmr19381125plb.35.1699054560588; Fri, 03 Nov 2023 16:36:00 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:5195:5e72:f5bb:e3f0]) by smtp.gmail.com with ESMTPSA id jg5-20020a17090326c500b001b8b2a6c4a4sm1878114plb.172.2023.11.03.16.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 16:35:59 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Wim Van Sebroeck , swboyd@chromium.org, Douglas Anderson , Andy Gross , Sai Prakash Ranjan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 9/9] dt-bindings: watchdog: qcom-wdt: Make the interrupt example edge triggered Date: Fri, 3 Nov 2023 16:34:35 -0700 Message-ID: <20231103163434.9.Ie30c1d3f780666f6906fd2fd7c437632c229d987@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231103163434.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Update the example in the bindings. Fixes: 7c631cdff391 ("dt-bindings: watchdog: qcom-wdt: allow interrupts") Signed-off-by: Douglas Anderson Reviewed-by: Guenter Roeck Acked-by: Krzysztof Kozlowski Reviewed-by: Stephen Boyd --- Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 5046dfa55f13..681d1efbaf2f 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -121,7 +121,7 @@ examples: compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; reg = <0x17c10000 0x1000>; clocks = <&sleep_clk>; - interrupts = ; + interrupts = ; timeout-sec = <10>; };