From patchwork Mon Nov 6 09:52:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13446517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88A8EC4332F for ; Mon, 6 Nov 2023 09:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j0c7xIQJh4IOmcY0dVvHuBSUgYY5CHHk02TixHbfvno=; b=BhpWR7VY+4GvCH MmW5qmvnPCqvISi3mfDjD8/46qdXvFuCeBxLmED4G3owC9AgSt/3Y/AU0c4Y5m9d4YJZH0FX2rl+L 1QwIpPKfgiFepNYGwFq6T+Mpg1zkuN26OT6zQQjaObhzDR9naIWg3Z4fD2sHBAMr1DqeL/L+Yxwzl H26++vGXfhFkPcF1LF9aD+Bg/hpoUXV+B7ua/N01/VFzlHY5dVxPtf7OWT25CjsSqv5pC7c4rali5 2JvdPFANv6H6giFk9zquPZ0FmTOE5SniP9CxcUUw46o5TVobuW2sPe5G/+l89kXxcxKLw/YHS/i2m pfFIZl33h1GUdndIQT0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzwHH-00GC8K-0a; Mon, 06 Nov 2023 09:52:15 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzwHE-00GC63-1q for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 09:52:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1699264332; x=1730800332; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jd6MUcWKRJ1RmTUfwIIEw+3tKFwk7+0cW8fgrk+BS8c=; b=gqSZE5SEqcEm1dbaSsTmOHhNKXsnXtaRUiKizVWu2UgcOgz4B0NsKzqm PeB8CHM1c+n0FpC0hECvOtB0dbozK7sVy6TB2L/iXXp849dxXrcloyDJw YEXWr3nbnK/xpja2KxPWMGOcww/r65DTrLbwRjHh/MhpHuT1WwIcXjD2z X+yLxcDhmdwIpJ4KvN21ZEfPVRUSyWUphTzfeIZMbOcYYgZ9x7qxJBvlj RYkCGFQEltNOcYUFZE6APkjr/X6QdabUlWxikg9yd4yym81jWU8Ys9kRO nSH+gK4t0mnaaIWuQUssLIQARMJi8nawpub+U33qlch78ZhdJiPIsomyc g==; X-IronPort-AV: E=Sophos;i="6.03,281,1694728800"; d="scan'208";a="33823100" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Nov 2023 10:52:05 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 34F5F280084; Mon, 6 Nov 2023 10:52:05 +0100 (CET) From: Alexander Stein To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , Philippe Schenker , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] dt-bindings: pwm: imx-pwm: Add constraints for #pwm-cells Date: Mon, 6 Nov 2023 10:52:03 +0100 Message-Id: <20231106095205.231210-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231106095205.231210-1-alexander.stein@ew.tq-group.com> References: <20231106095205.231210-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_015212_913438_8D8F2A0C X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Only fsl,imx1-pwm comptabile devices use #pwm-cells = <2>. Newer SoCs supportinverted PWM output, thus #pwm-cells needs to be set to 3. Signed-off-by: Alexander Stein --- .../devicetree/bindings/pwm/imx-pwm.yaml | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml index c01dff3b7f843..59a981c0f39ab 100644 --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml @@ -9,9 +9,6 @@ title: Freescale i.MX PWM controller maintainers: - Philipp Zabel -allOf: - - $ref: pwm.yaml# - properties: "#pwm-cells": description: | @@ -74,6 +71,23 @@ required: additionalProperties: false +allOf: + - $ref: pwm.yaml# + + - if: + properties: + compatible: + contains: + const: fsl,imx1-pwm + then: + properties: + "#pwm-cells": + enum: [2] + else: + properties: + "#pwm-cells": + enum: [3] + examples: - | #include From patchwork Mon Nov 6 09:52:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13446518 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87C3BC4167D for ; Mon, 6 Nov 2023 09:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rYCzKpbzc5UIfLrHY/jVUeHSh+GCQpy8no4SxkFXDBA=; b=MgdE5ANv7bkzAq vmD0a0fw2aYmNJoIX5LDik44u+I10Ec0ikFMAdLJ3ApVf1FB4UYGuAfbHfK2Y5g64Z8ifYDdkjxri RB6ZZVvOyy7Ux/VwgX1Zvu30b0MwK+Rd+3Lp2rsHvRmPEkt/7cma0qKQ9agZziQR7kpfTP87U40jp lnindAf1ygRpfDTEIJzd0l2SQCw1egSkha+G0qd2G12JWa4O0aDQ2Ti/3hEp/iRE9OWYcO1+gQD1K foI8IwXIWhuYdysliPDALfalJgkoa8rRvmEmEBz0FjwUXBJwLdCnV6+tDFNWUnrTGxqufm/oLZJdl DW9zcxRMC8TYCcndF1+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzwHI-00GC8r-2Z; Mon, 06 Nov 2023 09:52:16 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzwHF-00GC6W-28 for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 09:52:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1699264333; x=1730800333; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EGTF9v07Bby5eR466771r5R+MLgJZA5MIcBkAOpXjrg=; b=JPN2SB/SaWWw+Zk/n9tNMjVeLZzNjUfrnH+Z0k2or9tfxvBkw7c3iEQD BOI/vjfuFbW+NbnQHBVX9eHpSbMpcXD8EQGp7Dp0Rh0eWwr/P+75z2g2M +Wtg5w2cEGqfpNJtxp4lKPRD4blWJ/EItmyM7pgN9oJAgpZ2UGPbV7asM yziOSiHUujrEh1iPHunFASEiGm0Xx3iUHXmEU9wKAXmOf7P1v7bGNI7K4 zMqMO/ooQKKK/5NBJi12GvvkGRla3TGwF9t6ftp5/xWPmUdl5h/VMjM+w K74YQWa3tc9aUpWlOy5sfMoqj6Kcqbz21gABVQCeuqNJdYmEzSS7cCkev w==; X-IronPort-AV: E=Sophos;i="6.03,281,1694728800"; d="scan'208";a="33823101" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Nov 2023 10:52:05 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 73FB7280085; Mon, 6 Nov 2023 10:52:05 +0100 (CET) From: Alexander Stein To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , Philippe Schenker , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells Date: Mon, 6 Nov 2023 10:52:04 +0100 Message-Id: <20231106095205.231210-3-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231106095205.231210-1-alexander.stein@ew.tq-group.com> References: <20231106095205.231210-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_015214_005285_77184D1A X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org i.MX8QM/QXP supports inverted PWM output, thus #pwm-cells needs to be set to 3. Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3") Signed-off-by: Alexander Stein Reviewed-by: Uwe Kleine-König --- arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi index 49ad3413db948..7e510b21bbac5 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi @@ -29,7 +29,7 @@ lsio_pwm0: pwm@5d000000 { <&pwm0_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = ; status = "disabled"; }; @@ -42,7 +42,7 @@ lsio_pwm1: pwm@5d010000 { <&pwm1_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = ; status = "disabled"; }; @@ -55,7 +55,7 @@ lsio_pwm2: pwm@5d020000 { <&pwm2_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = ; status = "disabled"; }; @@ -68,7 +68,7 @@ lsio_pwm3: pwm@5d030000 { <&pwm3_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = ; status = "disabled"; }; From patchwork Mon Nov 6 09:52:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13446520 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E988DC4167D for ; Mon, 6 Nov 2023 09:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4+R3N2NqnQfXGijkXfllzVPEDU5GQBch330i6LuUCAc=; b=badk2FcPhHHjbw 4+eIeEPIC/KjNaBO79gVJlDqf/gS1Jeuk7GfXwHatB7GdabCu8oqnccKVeXmQ0lhZLVDKUieknf3T Z65vCgPsi3cpwyaLj0tRRoX8COIyj78wAjOP7ORFsNzZtYg0ZXYUSLwNZGhX6I5Kum2Pt3VxXpL7X jI0qWMqQnuDK3phFag5POfrBfo5A66nZtAuq6nWcoWiaIf6u1X3AkCCmL+8XYEDNCriTQxxsDzeOr Dq44Oy+gGOzOdoq7u/Ez6A1gzoRMsYVryfIio8KSBuZzS8pI+Q+jx6+NEcD8vTwr9mxxJ+nnhpbEf u7NcbgsOGCCKEgJ1O5Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzwHK-00GC9f-3C; Mon, 06 Nov 2023 09:52:18 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzwHG-00GC63-1h for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 09:52:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1699264334; x=1730800334; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n3w1++R+tKubh/JShRcdfaY4sdWM0Thnc5B85fY3mYw=; b=a5lvfE3B46TCts+oSwXTq3h4Wpyne4wdbu8/42daeRcK4boJjZpMZo9V LO+5ZlqyaFIHBG2suaRRQNh5YOCa2p3wgoj2Ju4Dy2cFz46ZL5J4vRKw/ 9EnatSCgiIRVyIt5R6L+TE1JiCFE60DICvLUVdQnLC+z0xJMKfvlk7yZg LkBWZSYU/9o02XX161qoG9EJDt7b9YAjGZ0dzcGwXHgNnjLJ/ZP1EpnlS xRqANQ5PrA1UH1QQ2vh+YsLPUO/R5bBiGaxHKh8FByTWBq8yVEx5Me2L5 Zy/8hgDaRigKChmbXhKME85JCeWzKmmzhSbbkjtTgcQgBLc9GG/wD++2N A==; X-IronPort-AV: E=Sophos;i="6.03,281,1694728800"; d="scan'208";a="33823102" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Nov 2023 10:52:05 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id B1F0928007F; Mon, 6 Nov 2023 10:52:05 +0100 (CET) From: Alexander Stein To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , Philippe Schenker , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] arm64: dts: freescale: imx8-ss-dma: Fix #pwm-cells Date: Mon, 6 Nov 2023 10:52:05 +0100 Message-Id: <20231106095205.231210-4-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231106095205.231210-1-alexander.stein@ew.tq-group.com> References: <20231106095205.231210-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_015214_871521_144E1140 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org i.MX8QXP supports inverted PWM output, thus #pwm-cells needs to be set to 3. Fixes: f1d6a6b991ef9 ("arm64: dts: imx8qxp: add adma_pwm in adma") Signed-off-by: Alexander Stein Reviewed-by: Uwe Kleine-König --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index ce66d30a4839b..b0bb77150adcc 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -149,7 +149,7 @@ adma_pwm: pwm@5a190000 { clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>; };