From patchwork Mon Nov 6 16:03:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 13447159 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7261C250FE for ; Mon, 6 Nov 2023 16:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="GBumYzC3" Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2068.outbound.protection.outlook.com [40.107.105.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ED0C134; Mon, 6 Nov 2023 08:03:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXB7EOVUjm1lAzOGiJAKeTZnzw7i+q+BOJv1dOlnrHKcJfBZA5zccWNYg9OwjvKvbSEqrwlT9ugAeoowhgUr0ylSml+TTUcJFfPz2tZl4ToeBta0xONfyIpE8CuoWDrfIkjswLJh9/10o3Zvt3TmdK30vI2m/VbA/WwWp32A5HZGvq5L8+o73fyTjvtktsbBIsmkY3crkRXyShIdSKSTdot0L3zRjGynFtkVQmanBPzXYKO+tVKzFFZaVIuidj25qeayuDC0q8I3LOygno857idQQhgmnR9NXDUV6SrlLWv8JFyVWNcGwjQKla+ilQhtVBRggtUXT5d9QtOWvDBp6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cDgwUeBqwwKhmZdjN+bEofx5j1gxSJezZ4jPaMrzevM=; b=J5hxtnSS5+GZN7LvOyapOI6nwbG5vM/2bJdB5KlEfErNFOu8TbRfNflf+qjhcoqYc3EnxQazG9R1CQhV+eL1gPqFJXbZy1rO3aKvimMy/dbj8RivwBqcc9JnirwNWp1BvcuL5RHjptYOySK6bGzS2MHThRaxRqWXtTbnQ5ronx9CHbravqeomQjGslcSbVSUPXPUjEr+niBfcqAMXg3bgGxtpg6ecd9yxuhuxzoDcC/bPYCM2LbZQE5wOB8j4uQZs6HR/y/PoNKcJg8MD9U0SodZqxtAaw7brfHTu0TXh3VheeqYRqHvKjlYHDoM5iabpGNf7YHRdrWhwzddfZ+itg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cDgwUeBqwwKhmZdjN+bEofx5j1gxSJezZ4jPaMrzevM=; b=GBumYzC3B5dfxaBF582Wul/RimkX8psWpgH6gW/cibmcUOE8bwNiswelrdaB5UKnNiwPMPX5eY3deuOW8S8X02weQnZ9VcZ+oQUNIHPVgoAW47HAa3WjNlCwTCy8cx9hsdDoD7gXYdUWmLzNpsljXRurFSfP8hhwE1ogfN3GY4I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB6452.eurprd04.prod.outlook.com (2603:10a6:208:16d::21) by VI1PR04MB9762.eurprd04.prod.outlook.com (2603:10a6:800:1d3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.13; Mon, 6 Nov 2023 16:03:25 +0000 Received: from AM0PR04MB6452.eurprd04.prod.outlook.com ([fe80::dd33:f07:7cfd:afa4]) by AM0PR04MB6452.eurprd04.prod.outlook.com ([fe80::dd33:f07:7cfd:afa4%6]) with mapi id 15.20.6977.013; Mon, 6 Nov 2023 16:03:25 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Simon Horman , Claudiu Manoil , kernel test robot Subject: [PATCH net] net: enetc: shorten enetc_setup_xdp_prog() error message to fit NETLINK_MAX_FMTMSG_LEN Date: Mon, 6 Nov 2023 18:03:11 +0200 Message-Id: <20231106160311.616118-1-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: AM0PR01CA0107.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::48) To AM0PR04MB6452.eurprd04.prod.outlook.com (2603:10a6:208:16d::21) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB6452:EE_|VI1PR04MB9762:EE_ X-MS-Office365-Filtering-Correlation-Id: 1acec5ef-60c0-43d3-8928-08dbdee1e855 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +qGsMGmmyBlR41ChUSRUggqPlNH6D/Z/p+iBBW4Y18lsCeWeDWMI+F/nj1UAGrRK3St7tCEKOIL5GDOsBSwUDn+zx49ZUtkiwLSQC57VZbO2uXXEISyegFtQ11PaZyGs1rdda64wjIkgA+yVJwzS/kfbE975gkV14V/259tzmG0GtAi5OK7avjinmqI4cANfLy1kiMGRN/emKYSmCDTO/Ni09eqxnMMJeuVPO+wSabNM9WqtUQ/sVNTpifIoHyKgmKqIGKe8mbGDTlNFYQ7k6WPjgZ/cZnzYFV1ntmrg57RT+FeUV55TX6ZbbwNaNkD4D5iBfCa1v6Bkrl5/d07NSIKni3mYhqx2JHuhMpQPwM9Hp70g/Xu/xjCm0cWEgBl5/7/Nk7XqpRPweUnOOa4HjWB1Eh5VqEpDeBrVoYwCIoINmwxGgKmUw9Odq71HLMAKC97Kpw0Oy53rBzre6rbazrEmk4HoiuyMyddQkXQyQTvfiwnQecaLSPcKk5uI4uWKomM6e26kHzcocqCT0nuAUJj8VITaXgaV+IBjN/oeeytvaaX3lrMdTXGUyJr7sfIuaNdcCMxxT4NrAsSYuRQSL8f12GxuYIMVO9cMRGhrsaU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB6452.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(346002)(396003)(39860400002)(136003)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(26005)(1076003)(6506007)(52116002)(2616005)(6666004)(8676002)(6512007)(83380400001)(8936002)(966005)(4326008)(5660300002)(6486002)(41300700001)(2906002)(44832011)(478600001)(316002)(6916009)(66946007)(66476007)(54906003)(66556008)(36756003)(86362001)(38100700002)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OqEx/Ed4N3WEcJ0eRuAZ8n6biEQJ9ygNtRJ+2GwK1ONiiRIIze1fpQWOdH1LHQLJj8yZsOAGK9xrPxtAg6Sk9SG8G0X8d/zz65EVf5E3S0FRqGZi9Ca5MU7/sPeJl+XKii8ioyv+vRuNkRwkGOUBdNGidxbjN+bXFIBqN7Zv8ejOU8oGRfhK8vgdysrfMXqr8ciuX/tEfeSSTwGJl0RMiwwWdGbKcnEo9/yteD0QeBDPFEO0Icrj6oBj+HkzlNw9cYjqMAcjl2aKjfK2GpQb5EPFa2sBl6fehk7rr8TuZSnnt5sVlu/9Nvo6Y1DvMfvqXTACxQzIP3mIsl5GdoB33oaZZ8u99xULUB4B3+BKOogh9EipfXndtusm+dia36MZkFuugPxHa3udXDnEoldU9NTYCM7rKLExO8DNLgmzPmMSgtsxA2BpW844wRrhNtf0YpYMnj6D8ATeTEgYXoWgh2X+78d9rzJDZm3KUbKFR64LjqgSC3WnS1bSwgmKm2XX2bhh/PqSurR7mTYeL50zZqf3HF/Ki7DbiBmEafKn1U5urQ7knDB9eRpx88XhO1VZY2bKXb+Kfny7cLZxGe/cv1ZB/CztIU6L7yhQq/ehTTEOmAKvYdK7W7OtjOhnk1D8CGLzit0uT3yU/kD8ZA02RlQ4SyHm0ml+HICp6hPSCDibw3SqLiEOb+5hJqnmD36P+pmdXP/NJ4R+PzXF2fuu4n7jszjj3sy2SHgrR/P1blYEn4Z5u5HL+RawXYGCUspMa1ZLoKtiOnJDCHtAMjvGXHi57V1dTFphu095lngsztfSE6VDJUv03xZ5dT/rtoEtvn3pM01boNQilkL+LW9eiSFXWvnqfvYoKEr0t1HXSMsRKp+IF5+vC8+xvFKJylIFv1DZsU3nbEvjjVT56yIAH1aI9arpDYSHJ5qC5IyjuAuvkIIkr5yBUC1XxGExqjoHu7wIhZp288VioK2PkuzciDnQdCFYUNlQimIdQW8u+HL3xCQms5QMTKTBUpvTABFlX7z9jT5aPb7WwgqxAPc4Jfkn/yWDraegfBTWSG4QlgXVJTbTOTBKZU+NJvsLPHq1Mp9BKAn9uyUhFJHwSBhA5y+beskkaWGTcJ5/qQ80CJWXe19i48tnS1ydHwX55gPQbYkRuRWmahhiQ65yOE8ihVHXgwc02dtDeKizpp/WXjtxmsLEmOdqv4YDmIaxhhSsrt6vA7Ucs9pK85es2IIIeIJE8tqIHoi6+AAz2/+GHw5+TgydnQ84x4mGcJnq8RKqhZF6NV5NxVvzgzvsxYR4pgjTjHB6zXtAZ4IMAHfvF6am25+aWAUgVgeAar8nrpRVBJlPZrFyGP9wpfO/bqgYTGfoZAItHMBywo41+MP2dNqBuIfUwwAhQjLA73VD1PDYmPB8DggOVfv4xjc9T95L5M4qlnhKwYWfGRlWaYx0smMlesS/1IiwQdmyoWp599lhhhlb2g799TeXIwbfCK6qLltyKIDJ2010R+XeCzMkegKQ22eXznhPxXX0+zPCiJhUx4b8kpeJYtUXLXvMOk7dva6oQovYDrNEq40E2TTgiGvDz7MKuRiAgoAMx9pRRAFCvOIl5EWTRoK7OGcC6z7YNw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1acec5ef-60c0-43d3-8928-08dbdee1e855 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2023 16:03:25.1727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 37xWTL9nRVyK+VzFCn5ui8bG9H4nnhT4HVV0AeJsSjqcW18Bd4ei+6FRyoi3xQqWwfR45zRHeDKx1cBo784C5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9762 X-Patchwork-Delegate: kuba@kernel.org NETLINK_MAX_FMTMSG_LEN is currently hardcoded to 80, and we provide an error printf-formatted string having 96 characters including the terminating \0. Assuming each %d (representing a queue) gets replaced by a number having at most 2 digits (a reasonable assumption), the final string is also 96 characters wide, which is too much. Reduce the verbiage a bit by removing some (partially) redundant words, which makes the new printf-formatted string be 73 characters wide with the trailing newline. Fixes: 800db2d125c2 ("net: enetc: ensure we always have a minimum number of TXQs for stack") Reported-by: kernel test robot Closes: https://lore.kernel.org/lkml/202311061336.4dsWMT1h-lkp@intel.com/ Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index 30bec47bc665..cffbf27c4656 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -2769,7 +2769,7 @@ static int enetc_setup_xdp_prog(struct net_device *ndev, struct bpf_prog *prog, if (priv->min_num_stack_tx_queues + num_xdp_tx_queues > priv->num_tx_rings) { NL_SET_ERR_MSG_FMT_MOD(extack, - "Reserving %d XDP TXQs does not leave a minimum of %d TXQs for network stack (total %d available)", + "Reserving %d XDP TXQs does not leave a minimum of %d for stack (total %d)", num_xdp_tx_queues, priv->min_num_stack_tx_queues, priv->num_tx_rings);