From patchwork Tue Nov 7 16:55:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13449115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9129C4332F for ; Tue, 7 Nov 2023 16:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234808AbjKGQzl (ORCPT ); Tue, 7 Nov 2023 11:55:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234919AbjKGQzj (ORCPT ); Tue, 7 Nov 2023 11:55:39 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4C7693 for ; Tue, 7 Nov 2023 08:55:37 -0800 (PST) Received: from umang.jain (unknown [103.251.226.96]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 499138CC; Tue, 7 Nov 2023 17:55:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699376115; bh=1H6/Xs6rlQM2lcXsSBsc50FMtGsuBvxFv3yX7+RhGmA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YEYI598tvMB2spg0c8f5okp2xivKMIENKixTtnx69eZO6kF3XUhdB1nG3jgyGDjcd U9uyXVwSokq9cx42/V+HowPBzEU8bywZ1IE5nou93cLEJ/B+l2W+ePcDlCa4XIDSRn kI8K5oJdcO+BgOvqYwLRgpHNPP8CPMeU3tDZ+SJg= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Dave Stevenson , Phil Elwell , "Ricardo B . Marliere" , Umang Jain Subject: [PATCH 1/2] staging: vc04_services: Use %p to log pointer address Date: Tue, 7 Nov 2023 11:55:22 -0500 Message-ID: <20231107165523.638555-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231107165523.638555-1-umang.jain@ideasonboard.com> References: <20231107165523.638555-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Solves the following Smatch warnings: vchiq_arm.c:1113 service_callback() warn: argument 7 to %lx specifier is cast from pointer vchiq_arm.c:1113 service_callback() warn: argument 11 to %lx specifier is cast from pointer vchiq_arm.c:1113 service_callback() warn: argument 12 to %lx specifier is cast from pointer vchiq_arm.c:1113 service_callback() warn: argument 13 to %lx specifier is cast from pointer %p will print the hashed pointer to dynamic debug. In order to print the unmodified pointer address, one can use the `no_hash_pointers` via kernel parameters. Signed-off-by: Umang Jain --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 4a2023919f5f..34b8985a57e2 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1111,11 +1111,10 @@ service_callback(struct vchiq_instance *instance, enum vchiq_reason reason, rcu_read_unlock(); dev_dbg(service->state->dev, - "%s: %s: %s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx\n", + "%s: %s: %s - service %p(%d,%p), reason %d, header %p, instance %p, bulk_userdata %p\n", log_cat(VCHIQ_ARM), log_type(TRACE), - __func__, (unsigned long)user_service, service->localport, - user_service->userdata, reason, (unsigned long)header, - (unsigned long)instance, (unsigned long)bulk_userdata); + __func__, user_service, service->localport, + user_service->userdata, reason, header, instance, bulk_userdata); if (header && user_service->is_vchi) { spin_lock(&msg_queue_spinlock); From patchwork Tue Nov 7 16:55:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13449116 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642FFC4332F for ; Tue, 7 Nov 2023 16:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234956AbjKGQzo (ORCPT ); Tue, 7 Nov 2023 11:55:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234929AbjKGQzm (ORCPT ); Tue, 7 Nov 2023 11:55:42 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4668A2 for ; Tue, 7 Nov 2023 08:55:40 -0800 (PST) Received: from umang.jain (unknown [103.251.226.96]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C311E9CC; Tue, 7 Nov 2023 17:55:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699376118; bh=SbvUXnDBOpBoaHTh7Ug+PnfVgeplXwBy5YpgCG7S3A0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h/KqH/DwlIh+9ZR+XREN/ECd0nlw16RccjVnd8F5/Ov4QYObm70JJKjZhaYAlAgHr 0DcZ6SCDGib7fBfIlY72Te7uC5upjNH6Vs0mtGxDO9UhxSe485rdfWM8XxX3BovXSb A0JghFWANuUCTczXRNO+cjBn34C4g9TLdRvxcFK8= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Dave Stevenson , Phil Elwell , "Ricardo B . Marliere" , Umang Jain Subject: [PATCH 2/2] staging: vc04_services: Use %p to log pointer address Date: Tue, 7 Nov 2023 11:55:23 -0500 Message-ID: <20231107165523.638555-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231107165523.638555-1-umang.jain@ideasonboard.com> References: <20231107165523.638555-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Solves the following Smatch warnings: vchiq_dev.c:1220 vchiq_release() warn: argument 7 to %lx specifier is cast from pointer %p will print the hashed pointer to dynamic debug. In order to print the unmodified pointer address, one can use the `no_hash_pointers` via kernel parameters. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c index a64d6333cf0a..16e951b2570f 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c @@ -1217,9 +1217,9 @@ static int vchiq_release(struct inode *inode, struct file *file) int ret = 0; int i; - dev_dbg(state->dev, "%s: %s: %s: instance=%lx\n", + dev_dbg(state->dev, "%s: %s: %s: instance=%p\n", log_cat(VCHIQ_ARM), log_type(DEBUG), - __func__, (unsigned long)instance); + __func__, instance); if (!state) { ret = -EPERM;