From patchwork Tue Nov 7 20:28:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C9EEC41535 for ; Tue, 7 Nov 2023 20:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YImTrfYP0KYqd972n8PVE0qbvC3FMDkTeIyFN2BOelw=; b=cX9O0DyEZQTz6v cPeFi+mt7gBO2XExtrD5e+1cManh35xuOEjzmdHdFmQGrTBaMIlQJuvMhELt4fAe2S9dEutx3V0kC M8fBJJwsy84m+VWQwmPB+Ev+UtWdX8IyznslejVQwkpqlxz50oOALhV7yJO9bAHiZJTO4pbQCxxwv J9sk/O5WHV/4NecDeKe+z+lVDZ/Db5lm5tkgWrDrIvNZcD2D0tcpLxhJ/VDzVSvX9nIeZyM/bf5Eo La4aM+A34AD5mHZJzID8pTglGF3UKz3Z12vHMR1B/8sZtn/XbY05y5hmTm2QHPJzCy/DfKyklCFj2 N/R//3/7j0kL5F1MqOZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sh1-002M5t-25; Tue, 07 Nov 2023 20:28:59 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgz-002M4J-1s for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:58 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgg-00061s-Rl; Tue, 07 Nov 2023 21:28:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sgd-007NNv-W2; Tue, 07 Nov 2023 21:28:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sgd-00EokM-Ml; Tue, 07 Nov 2023 21:28:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , Junhao He , Qi Liu , Jonathan Cameron , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 1/8] coresight: ultrasoc-smb: Fix resource leak in .remove() Date: Tue, 7 Nov 2023 21:28:20 +0100 Message-ID: <20231107202818.4005791-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1181; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=74JK09BJ9tVc67yTfia0xpkZiAHFR5AlVp4MOEs4PCI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3jauPxd/lMtSAylZcrURzNT5YQhT1uy7fzh j2F+yDxnUOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd4wAKCRCPgPtYfRL+ TpWjB/4vw0VSHbjguaUOdpgiSXshBH5mU3B/zYDR+oP3XLcMrn4sAmsg+J9iwQQ0XGZqMERp711 HNhe+OUr5sYtDoz1dzYQhMnpvI3DLMNQBb/DVJmFRq9X6PirQomMNCafY8163WkUOejcaNY+Nsd yoD21rtG8F5Knw6Gos1o1oXkRsz3v8QQKg20erQFelVyK2a+DGMAgWQcVd4DdZGV5jzqtBiCjyU bnPl7NpYI+vtd9giuTT50E58nh0HvofgtOUSMx0EM8FDX8HkMlXutZ4FA4EIWxoDdy25caJROrH GdoEj5dPeXiXpr0q1XIdopxgPJrUqlzo/Q/zGdg8SrgXxys4 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122857_616456_5FA30F04 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If smb_config_inport() fails it's still necessary to unregister all resources. As smb_config_inport() already emits an error message on failure, there is no need to add another one. By not returning the error code, a second error message (about the return value being ignored) is suppressed. Fixes: 06f5c2926aaa ("drivers/coresight: Add UltraSoc System Memory Buffer driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/ultrasoc-smb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/ultrasoc-smb.c b/drivers/hwtracing/coresight/ultrasoc-smb.c index e9a32a97fbee..10e7d4852112 100644 --- a/drivers/hwtracing/coresight/ultrasoc-smb.c +++ b/drivers/hwtracing/coresight/ultrasoc-smb.c @@ -613,11 +613,8 @@ static int smb_probe(struct platform_device *pdev) static int smb_remove(struct platform_device *pdev) { struct smb_drv_data *drvdata = platform_get_drvdata(pdev); - int ret; - ret = smb_config_inport(&pdev->dev, false); - if (ret) - return ret; + smb_config_inport(&pdev->dev, false); smb_unregister_sink(drvdata); From patchwork Tue Nov 7 20:28:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 658D4C4332F for ; Tue, 7 Nov 2023 20:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uztd48zyRxlvpExFYXAclnTVkl7cbRYxxU7ttFh5TBc=; b=ZoK/YTJZBaBj7R afnc2v/Mlbj2aCs3csEMM4zIoAkgAXYLae5AJL0+/+1Z+X5B4+iRZfLpLPtg+MJ3W2IE9XN6jSKuZ xd9XHTBpNRLrwK76V4DrgikLV62PM9xr9D16CgzvCTfYJqylUD4uOyEArAhEq9YONwbAnipT8uMdv OWXnyrKWzfOOZ9aMtHEHEMMG95Pcg4KD0iWNqy+FzPVFZFJ7dalwYd78/6zbA9k03W7JpVB8f5XR/ 8O56q7tG7Xa5BAkcY6pHSMUfO/WSPv5CYSGHcSySYSmGmL//PBE29IXnEumcu6C1svIkrgWqwHEcy c3PwCWQ2rKUnv1aRnoPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgq-002M1U-1m; Tue, 07 Nov 2023 20:28:48 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzH-33 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:45 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00061t-77; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sge-007NNy-A5; Tue, 07 Nov 2023 21:28:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sge-00EokQ-0z; Tue, 07 Nov 2023 21:28:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/8] coresight: dummy: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:21 +0100 Message-ID: <20231107202818.4005791-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1876; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=kDSbPhEnRTaF07v01xUBPsnezFcNE7nYzeMIOj+oAPA=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlSvuU9Ugmbxd0aFph8WfXRk7YOiXbI7Poaf6A+oEU1T6 Quz0w/tZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAi2zk4GPo8OYKLYhf5fZoS ZsU+o39HeOv2PGOhHSs8shSuFdduv6au92CKbLDZzimPVbbVz85LT+HYt6T3e2DsVAHB/8YnF8v P+3JIbIZOtqCZOutWsckzZV8L1bCuyI6o0cnoXdhUIfil419L2bnGhAtr0tWFIjaIuccLct3SXW jwb01EEcvH2qXnX6eePuJvnPAkyMR4r233zCUSd++ErCp9tDCS4cqptfuVbD6sSLE7nXSwYMrC8 E6+3mcCKQwX2mdUFbM/3PHYK4Np/kGDm2HHbjtHrsn7rPE7v+wKd+zi48rbPBTN7wq1KXeLP1hd Hsb3oUBy0p1p+1Uc3fyXR6mEtiZZyt07nT9NIoxhU5w9AA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_032093_D82F2D0A X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-dummy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-dummy.c b/drivers/hwtracing/coresight/coresight-dummy.c index e4deafae7bc2..ac70c0b491be 100644 --- a/drivers/hwtracing/coresight/coresight-dummy.c +++ b/drivers/hwtracing/coresight/coresight-dummy.c @@ -122,14 +122,13 @@ static int dummy_probe(struct platform_device *pdev) return 0; } -static int dummy_remove(struct platform_device *pdev) +static void dummy_remove(struct platform_device *pdev) { struct dummy_drvdata *drvdata = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; pm_runtime_disable(dev); coresight_unregister(drvdata->csdev); - return 0; } static const struct of_device_id dummy_match[] = { @@ -140,7 +139,7 @@ static const struct of_device_id dummy_match[] = { static struct platform_driver dummy_driver = { .probe = dummy_probe, - .remove = dummy_remove, + .remove_new = dummy_remove, .driver = { .name = "coresight-dummy", .of_match_table = dummy_match, From patchwork Tue Nov 7 20:28:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D2C6C4167B for ; Tue, 7 Nov 2023 20:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DYiChz4yW1xBdN/+0DxGFTTNRJf4uCEdLXt1IkCuDL0=; b=2x6oOdhvuYRp1q sI8eSTAWGvbIdweTfoumTN5YHmsMrdYa2oKTd32nj/OmerkYZsT9+goRJo+dyBms/v30nC35qLXHc sJtmfMUpI8i+ZB0WX7tuuEM4kVti/dXmpwHr2/Xpo8RiaR7PxX2jnOujEXOkl05oURdfox0L2NDId hXoNav2i19JMdaxh0RDteRtSOoxHu+xXlfAy4BYdjWx0tuP18mN7kQyEnMMTwX55QwPS6/dxc8dmT M5pzrQatk2dqwk2CYhi9+Jr1acYfbMUDWcIeCPYu24QKp0Boj6gBnzx1ZjaWTP5mI0POQ7VYNoH3U v3uN18mDo3nWJSRLBk8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgo-002M0y-2j; Tue, 07 Nov 2023 20:28:46 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzJ-32 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:45 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00061u-77; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sge-007NO1-J7; Tue, 07 Nov 2023 21:28:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sge-00EokU-A2; Tue, 07 Nov 2023 21:28:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 3/8] coresight: etm4x: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:22 +0100 Message-ID: <20231107202818.4005791-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2055; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=YrwusRvrW9dCT+4cGioWpJgl55bUARdlmK03ZyUiu0A=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3lkIz2qy11jkd9F1I0jJZ8Pvu/s67PeS3/X tRg5027S4mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd5QAKCRCPgPtYfRL+ Tk9zB/0RF6wlzFrfe0pa+FTRa8HQEBf+zo4dcHfO/mS80HPqXaVWlCQHc6/OCbpHdi1276Km0vN js2aKZRZaPWT2xoM5YMfGasHLyoh7rT6r9NFN7iyGzXnnV3pqSHet/8ItTQxY8GLNj6ha43b/S1 mvA8Q8uwj5uaySQLM/LqhauBsSK6LSRq+j9QJhjcJeaPggyKK5R8MgaAMjibGhpbCIccwT5MzHQ z6kJUteiTNWmCa0UMNwEEsC0iPKz8kSKeM2scVT02DOs8ipbR+13uSuoIWMAtCSeRdObUM/H0BM jG4HfB01BZV6ve8p64Lxayd5+zhurrO0qAS0jNJZHEpJv74M X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_029358_1E02028C X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index 285539104bcc..ce1995a2827f 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -2303,7 +2303,7 @@ static void etm4_remove_amba(struct amba_device *adev) etm4_remove_dev(drvdata); } -static int etm4_remove_platform_dev(struct platform_device *pdev) +static void etm4_remove_platform_dev(struct platform_device *pdev) { struct etmv4_drvdata *drvdata = dev_get_drvdata(&pdev->dev); @@ -2313,8 +2313,6 @@ static int etm4_remove_platform_dev(struct platform_device *pdev) if (drvdata && !IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - - return 0; } static const struct amba_id etm4_ids[] = { @@ -2400,7 +2398,7 @@ MODULE_DEVICE_TABLE(acpi, etm4x_acpi_ids); static struct platform_driver etm4_platform_driver = { .probe = etm4_probe_platform_dev, - .remove = etm4_remove_platform_dev, + .remove_new = etm4_remove_platform_dev, .driver = { .name = "coresight-etm4x", .of_match_table = etm4_sysreg_match, From patchwork Tue Nov 7 20:28:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22950C4332F for ; Tue, 7 Nov 2023 20:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9E6gy4DWzC7ukvAMh2sRKMtpp0SX6NcUsGzOVdHuvTw=; b=JoCdXdoosXiKJa zTjj2d8QsrpzcegU0nNAYDStMl2gHoTSvo0dRWK0RAcmNnaG1vTsf66E+kmsQL48Y44K7BZMIFswZ n203PGUybytVehTNm+gqRvcvX9CC8f/JXPbv1c1mTZ2aSPyxR+Sly5MVj/ih/oHvBMkpnDw0IYYBk m8HWnFxOYR/MERvlpi8CjZiDakoRP0ve60n/UhFNxL5lr9pAsVctst6Vbg0MvxZYttx2lAEjG36yn c1FPj/iRyzm2GnzVrzC/Woa/f6L9LkjfZcJRQNaeQPlEpfeOWUrIq6u4FsQHCkgxu1nh0nrIDXvrY Zwm33S10VG1H5BbFqJsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgr-002M1Y-0A; Tue, 07 Nov 2023 20:28:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzI-33 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00061v-EI; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sge-007NO4-UO; Tue, 07 Nov 2023 21:28:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sge-00EokY-LD; Tue, 07 Nov 2023 21:28:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 4/8] coresight: funnel: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:23 +0100 Message-ID: <20231107202818.4005791-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1909; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ckxzLwYzLr/oPdmBU/IGTPID3/yg3Zuge/AMtvNE1GE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3nrZ6cdUnRNQLscJi3mdw64qPSzSn4XA1OC +lsIQ3tq6+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd5wAKCRCPgPtYfRL+ TsTZB/4pJF/USgJ5JCRG6r3HH1rcJAw2goaWKP/H8yaYnJfVq1aQpIVU80P3T844Tf9+L0kI8TQ oJarC92yDgG5FIfNnSfA3sNRJDU7ZSXH2R9rwz03o0y7KvYTuHkezW1ZbL97jkVbQGjKC8NwJ2G XN58sbGX7LMsRu4ZITpS9h5yaniFEnMMEJKHudne5DquUuPRCIQSO/TEUWE6OAi23FXtfC2+ppq MnUyCYCTWxc2ElOdGVWBWWMam122L1zz89cgr5wx8tI2J04WaJKhvrP7yGec8IaHJ9V6bsAUPZg U9OTHQTgZtToZhyBvxAwk640JM72N8cPPWlLO76M1PfTGLH1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_038468_B0833A98 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-funnel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index b8e150e45b27..a5b1fc787766 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -335,11 +335,10 @@ static int static_funnel_probe(struct platform_device *pdev) return ret; } -static int static_funnel_remove(struct platform_device *pdev) +static void static_funnel_remove(struct platform_device *pdev) { funnel_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } static const struct of_device_id static_funnel_match[] = { @@ -360,7 +359,7 @@ MODULE_DEVICE_TABLE(acpi, static_funnel_ids); static struct platform_driver static_funnel_driver = { .probe = static_funnel_probe, - .remove = static_funnel_remove, + .remove_new = static_funnel_remove, .driver = { .name = "coresight-static-funnel", /* THIS_MODULE is taken care of by platform_driver_register() */ From patchwork Tue Nov 7 20:28:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449272 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BE4BC4167B for ; Tue, 7 Nov 2023 20:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8YCHEfnS7DowRR9++EqDiyDUeWNZ0JtjUc+IvqlvN8s=; b=sKnokZq8nVgmK6 VtjnNVi7UJqguWl6TT29F1RtSY+1Jrcjzc0jr5GQecSzGuhuaddzFPa7J+59nio6ngyDTT0ucKpD/ 57oMHxtlnQcv4Hkg93wAA+nI58vGAgRYwLr79ZBvZH3Lrgu1d2HChRCrI2hE475RKQgLLBmLR+KMM awKaxJko5zFR1wcp5PgX3hrVS3HLGAZOWkY/Vf9buF9hb/IpnRg6br0JbVQvAYODmFqHGJpzPczjy dhllm8qejHHzUh6RVuJLjO/l1I4W6B5iNjtk8EOHfyuOj4eWDKSO3M0W5hlxIhwsnYHysjxOtw3a1 obftchYWlbPb4cdfBImQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgs-002M1i-0F; Tue, 07 Nov 2023 20:28:50 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzN-32 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00062K-Nf; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sgf-007NOA-Aj; Tue, 07 Nov 2023 21:28:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sgf-00Eokc-1X; Tue, 07 Nov 2023 21:28:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 5/8] coresight: replicator: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:24 +0100 Message-ID: <20231107202818.4005791-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1930; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=4gwK1dyeiVLM++LqvnfFvxq0IcHYha+lEqNnIXDY8Wc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3ooBdmk9AQC0Bp3BwIMKEWdCdC/rFSnh9dk HkN8iqU/GCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd6AAKCRCPgPtYfRL+ TvqIB/964OF/FvTcWf0xnej3PePmMbAwXg04medTPCqqH/xu2xSvLAjfYI/KFVGbk6Xde1FL8lo J8QzG+MQJxtuTK5HO3pelu19LCK0fuuVegxR5730Xqb2iMZ3k1kmt/l8I1ynJZGCICbKn417opc qg/44cagVPPDsYmc6zMi9C0dx3z44qdCdu3L+zjuUUAcz6BDianL/u5jKwIL2typS+f/kjo0/0h jLZpSbEm24fHEBzQHX0APrYhvK/aloPBNE9+8i+4DuK5EXTPNx/1qqEvCz40BAp3Yxcc2/BLmWl qqu8+l+fziH8Vur3pMXEpj3ElVOVT3bEuvRrRWh+EonPfIMh X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_052669_6DFF4192 X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-replicator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b6be73034996..91d93060dda5 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -320,11 +320,10 @@ static int static_replicator_probe(struct platform_device *pdev) return ret; } -static int static_replicator_remove(struct platform_device *pdev) +static void static_replicator_remove(struct platform_device *pdev) { replicator_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } #ifdef CONFIG_PM @@ -373,7 +372,7 @@ MODULE_DEVICE_TABLE(acpi, static_replicator_acpi_ids); static struct platform_driver static_replicator_driver = { .probe = static_replicator_probe, - .remove = static_replicator_remove, + .remove_new = static_replicator_remove, .driver = { .name = "coresight-static-replicator", /* THIS_MODULE is taken care of by platform_driver_register() */ From patchwork Tue Nov 7 20:28:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA84DC4167D for ; Tue, 7 Nov 2023 20:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=btoT75DIC/+XTI0AVbAQdXIB1GRd7zyIkyo9UNDo3G4=; b=qBILGwHEkwdjJN jGisQjb7MXvV80/qEjgxtq16ZYdyW8yhBW2Io2sPH9mFnGCsFnx3e1yPNZFjnqXLfdbqw8TF4qhZP qFHMcmym1wgyYBpU085j/dKl23n+R6bu4TY1BBqcaedFHsogKpr20xo3zouINqB84F+kHhRDAQ65e R8GSEsCtGL+fY4gwJLCq81YHeQAdysMGvhJSnLPmxyEY5Kz2xmbcYZ2NO5he70NCIVHsWPLm37rbS 4q1ZcPdIIf5SrSb1f6oXshTRcJGJ6gq6ymIWlkRsBzt4AtYeXZDjOTau7+nmdI/5hHIZVMVvzviun Zz9jKsI9bGYKDJlV5KEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgs-002M2a-1y; Tue, 07 Nov 2023 20:28:50 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzO-32 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00062U-V1; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sgf-007NOH-IA; Tue, 07 Nov 2023 21:28:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sgf-00Eokg-99; Tue, 07 Nov 2023 21:28:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 6/8] coresight: trbe: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:25 +0100 Message-ID: <20231107202818.4005791-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1895; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=KNvGLjYulDOon5MFKbMtWOyJgqmqqD8sX9roesDaPJI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3pPC4/2a9B/0eEDTNOIF4aXQ9k/VHRyRSmF jotNQq8GmWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd6QAKCRCPgPtYfRL+ TgebB/91lY73FPE9RpcNNTiVRlXMlJH2MKF4w9vAWZYb/kRlM2+dTK2N74+geI0rKMAMoCDJz1c GxWT/78KIGf/5PyFSS/sFTjy6pM/ZQ3ZAZrSIeKGBol7BxhLIbSL49SUEzx1IQNZq2S6DPNPVCx U/xQiIxxvbLCjnHgRYpvDELvTU+c98A1NLxwZNh0kXdNi51yxpU2QVTKpptcdxHf1WpyJiSOtdG Byv0LNAoYVHVf5GVo4b/rFtbnc+/sEcQOQJW7TN6QEXHcioGSE7OXIaf722SESUqunJ7QvULoIg BG/dl7OJ2SDafiUdaJoYBxg72QaqTmZVjpH0rDPovNlfU+Dw X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_065518_A55A81B4 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-trbe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c index a3954be7b1f3..6136776482e6 100644 --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -1530,14 +1530,13 @@ static int arm_trbe_device_probe(struct platform_device *pdev) return ret; } -static int arm_trbe_device_remove(struct platform_device *pdev) +static void arm_trbe_device_remove(struct platform_device *pdev) { struct trbe_drvdata *drvdata = platform_get_drvdata(pdev); arm_trbe_remove_cpuhp(drvdata); arm_trbe_remove_coresight(drvdata); arm_trbe_remove_irq(drvdata); - return 0; } static const struct of_device_id arm_trbe_of_match[] = { @@ -1562,7 +1561,7 @@ static struct platform_driver arm_trbe_driver = { .suppress_bind_attrs = true, }, .probe = arm_trbe_device_probe, - .remove = arm_trbe_device_remove, + .remove_new = arm_trbe_device_remove, }; static int __init arm_trbe_init(void) From patchwork Tue Nov 7 20:28:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BB4CC4332F for ; Tue, 7 Nov 2023 20:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=br8zfjiD71fZ/xJFM7XSTeRQmXZlkswQTEJtcL4rQ58=; b=lOSsCO+alaDdEI h5RBl0se5IVML8YBHA34aNpPF+oX52etJz0NqUMsE/KkgyKb9s5iBv4Lpnhyhq9esWp01uMAMiKnQ JLzZcl2ywfUah8mk89RxyMHaojlb477lOtdM9hJxQPadQWDhTNYOzvbPhaKC+FXOQHPK0IJIJQC4a f74GKCJGW8sBQJQkPA/j32FrOsQWbH3hI3mcoYy/YV7tODdET1B8p7dtjDl2UYm/Kk+ujaX0HnicQ MEcvVpglGfU7HOpiiOw3r/3qncwmtUarQWxNuXJDt9hSaTILtZDjBHUafggUl4JfMufW60peR5kFo 5NIDIhGdGP/4WJpBfzFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgr-002M1c-1p; Tue, 07 Nov 2023 20:28:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzP-32 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgg-00062u-Gw; Tue, 07 Nov 2023 21:28:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sgg-007NOQ-49; Tue, 07 Nov 2023 21:28:38 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sgf-00Eoko-RO; Tue, 07 Nov 2023 21:28:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 8/8] coresight: ultrasoc-smb: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:27 +0100 Message-ID: <20231107202818.4005791-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=LbFQ1eAsrkcDQEirId5SgIegPZO6qwmRnFQsDU//pRU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3rbeSz59yGOpm4d5v5TIXcAsWvSRnQfAQYv N+ZqPOcgoGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd6wAKCRCPgPtYfRL+ TuJUB/9yhI0/BHNW4gBSx5OiR0p76k6wXAeExGzF1XYsCr2aa0CysgtLDMLFukX0otADhqmshdG qkVVrufgAKJtKYc41aekz/i8mm+JqI7YP2Ost8xKtLfIPndExkSyMO678eJDiOO1yh2qTULMdR7 rfbCBx5oBd/WP45xV5ZiZakC2HWiGwRj1wTn5wWJ2xViMTzMyk9LQ0cjCEl0vFSnTYX6P+2xBqx IZOsAW4rBE0SyrUJzZSt2BEjkaxTP9RbYuLkLDj7PaTWJkE8u33f3tn8kmsjSe6uJfLotuB5fcF YN9yb82Lj4qMu8R68L2PLuqE/y4CLdUeX8zA5T0AWBMJN2HF X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_050340_131FB67E X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/ultrasoc-smb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/ultrasoc-smb.c b/drivers/hwtracing/coresight/ultrasoc-smb.c index 10e7d4852112..35be22d66417 100644 --- a/drivers/hwtracing/coresight/ultrasoc-smb.c +++ b/drivers/hwtracing/coresight/ultrasoc-smb.c @@ -610,15 +610,13 @@ static int smb_probe(struct platform_device *pdev) return 0; } -static int smb_remove(struct platform_device *pdev) +static void smb_remove(struct platform_device *pdev) { struct smb_drv_data *drvdata = platform_get_drvdata(pdev); smb_config_inport(&pdev->dev, false); smb_unregister_sink(drvdata); - - return 0; } #ifdef CONFIG_ACPI @@ -636,7 +634,7 @@ static struct platform_driver smb_driver = { .suppress_bind_attrs = true, }, .probe = smb_probe, - .remove = smb_remove, + .remove_new = smb_remove, }; module_platform_driver(smb_driver);