From patchwork Sun Nov 12 10:09:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Emmanuel Grumbach X-Patchwork-Id: 13453322 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD05EC4332F for ; Sun, 12 Nov 2023 10:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbjKLKJ7 (ORCPT ); Sun, 12 Nov 2023 05:09:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjKLKJ6 (ORCPT ); Sun, 12 Nov 2023 05:09:58 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 091462D61 for ; Sun, 12 Nov 2023 02:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699783796; x=1731319796; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xXHqVWMtHsu0LMfNepi9whPOeRugBkLp+axt8KAHX7A=; b=djFpTDQDlzWjiHQhP2mLvCRb1Ivn/4pLUkLlOVccRw8J/AWr59GMy6mG tvtCHolHcfdXeNZ4DWB6tnfLk7BImyYJ95uXF9zGEUrCQl0qRhQC4BX5S LpKTK4kPenCEUTNaJedYdWcoVnCeDrF+6IljxzP2Q5qALPFFFfCDPWZVf J8a4pLZJn9g2TaTgHMgRV82cLtU7M30mKaGxBieafyTqDAGVOeSrxXJLr t7rxd0JFcH/TmkrrJjZhmp+b6kBaYRsyh34vpUB94jTpBbELmFYK7sY3n nKGYUvPrugFibHvifF1gxblFLoo3gN5yuEjv3aXH8ANEbD2wHjgcd1zje g==; X-IronPort-AV: E=McAfee;i="6600,9927,10891"; a="389188498" X-IronPort-AV: E=Sophos;i="6.03,297,1694761200"; d="scan'208";a="389188498" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 02:09:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10891"; a="830008545" X-IronPort-AV: E=Sophos;i="6.03,297,1694761200"; d="scan'208";a="830008545" Received: from egrumbac-mobl1.ger.corp.intel.com (HELO egrumbac-mobl1.lan) ([10.255.198.134]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 02:09:52 -0800 From: Emmanuel Grumbach To: Linus Torvalds Cc: Kalle Valo , Linux Wireless , pagadala.yesu.anjaneyulu@intel.com, gregory.greenman@intel.com, Linux Regressions , Johannes Berg , Bagas Sanjaya , Miri Korenblit , Emmanuel Grumbach Subject: [PATCH v3] wifi: iwlwifi: fix system commands group ordering Date: Sun, 12 Nov 2023 12:09:44 +0200 Message-ID: <20231112100944.21177-1-emmanuel.grumbach@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231112095943.19353-1-emmanuel.grumbach@intel.com> References: <20231112095943.19353-1-emmanuel.grumbach@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Miri Korenblit The commands should be sorted inside the group definition. Fix the ordering so we won't get following warning: WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg)) Fixes: b6e3d1ba4fcf ("wifi: iwlwifi: mvm: implement new firmware API for statistics") Signed-off-by: Miri Korenblit Signed-off-by: Emmanuel Grumbach Tested-by: Niklāvs Koļesņikovs Tested-by: Damian Tometzki --- v3: remove changeId for real... --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index fef86a8b4163..1627b2f819db 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -550,9 +550,9 @@ static const struct iwl_hcmd_names iwl_mvm_system_names[] = { HCMD_NAME(RFI_CONFIG_CMD), HCMD_NAME(RFI_GET_FREQ_TABLE_CMD), HCMD_NAME(SYSTEM_FEATURES_CONTROL_CMD), - HCMD_NAME(RFI_DEACTIVATE_NOTIF), HCMD_NAME(SYSTEM_STATISTICS_CMD), HCMD_NAME(SYSTEM_STATISTICS_END_NOTIF), + HCMD_NAME(RFI_DEACTIVATE_NOTIF), }; /* Please keep this array *SORTED* by hex value.