From patchwork Mon Nov 13 11:23:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453837 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F76C4332F for ; Mon, 13 Nov 2023 11:24:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BFB610E066; Mon, 13 Nov 2023 11:24:05 +0000 (UTC) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47EC510E066 for ; Mon, 13 Nov 2023 11:24:03 +0000 (UTC) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-507a55302e0so5970096e87.0 for ; Mon, 13 Nov 2023 03:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874641; x=1700479441; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Opo2n1kgRGyqTe3TRkg8x+CZ1bdNAAuwb0HOdaOfFW0=; b=J5QlwjHifa9svUjoAPJwig6b3KGr/+omst0g2nYUYQkjgtqljadJu9lqb+MOVSJWZp SDnN0cl8kJSBHFhyXUgQAXarxiwZPLLMNvQETU5BwBpRa9jMf3qSnF77JhPK7xcZIq2h QgZknk8nVp0mKXyHhWdJ5U0blpUB9ENI1U2Jnm7NVKDv2iuqGsu4QdPT7FhyEP8C8ZE4 GCZD7ktYdluEkqoUtEKrbm1XLXviY+XkfcnzGvwbsEsbemJqov7SV5YR2NrRXEfMjWB9 sNbCIhlKM2ZEMP8p0oZs87Z+krQVidqVT0SiunBFZPgrbDQIwmPb4ZkrBkKYeK6sWGBA +QJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874641; x=1700479441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Opo2n1kgRGyqTe3TRkg8x+CZ1bdNAAuwb0HOdaOfFW0=; b=f/CkfWFggVcg0+pfV/wlb5IHGaxf5Gzma3Cxa9nwD1xSL+Hgrsv6Sbit+6VSTRSNZd moZT5/m31X8R2vzZ4RNioc+wD8RHu3GcYJUzZBBj+spmToScXKzc3yyi6d7tsJ4hPR+K 60SWOLZD5A0FefGhft9dgZHOpVXsRohBn1sFSfKEvsSvX8DuB2U/+1LzqTyw4E+Nt81T CxUA1HqxkKtIQq2c/DwlEKbrTptu4XUuvRgPCpkn6afVQLo6OM0+yDfoNUpBtZdc/N5f xGcET3uZZoHOXh5VKoI9WmhATs59Dz38eX8JEgXal3KUDVpb0knPlOXLCajUhiJ0olYP PSOg== X-Gm-Message-State: AOJu0YxOIMRc1Y/DldlTSl1dnlT+SuYmzi0ueXGpBGtB0dax4AhfBNbA 5vVO++Qx6mLtu+piQjPGja8= X-Google-Smtp-Source: AGHT+IEC4bNxMxVLe61hoEBoRm/P4z68EeACSaOaY2P2h8vmjgRJS7MeWj+M0EXY9PL6tHaJ0DbGAg== X-Received: by 2002:a05:6512:3e0f:b0:507:9628:afb with SMTP id i15-20020a0565123e0f00b0050796280afbmr5515817lfv.68.1699874641249; Mon, 13 Nov 2023 03:24:01 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:00 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Subject: [PATCH 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:25 +0100 Message-ID: <20231113112344.719-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Mon Nov 13 11:23:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453839 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA674C4332F for ; Mon, 13 Nov 2023 11:24:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7450110E346; Mon, 13 Nov 2023 11:24:09 +0000 (UTC) Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60F7510E066 for ; Mon, 13 Nov 2023 11:24:04 +0000 (UTC) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c523ac38fbso55119821fa.0 for ; Mon, 13 Nov 2023 03:24:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874642; x=1700479442; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=FgcLJWEzrCjXg6tMIZ7OpCsGMvQYn+RvjZ8h+GzJllzyrHkJpzwPwcWVydNqeEQqJB IZ2zyJSTLlf4HR70yo6popbx3vawh/gvIjcgGCWToaT1fprIRXxFNQCa8/sgC3rmTaKg W8lcUDtZOHdRrD5E9Y5JLrY1+B8pwq4CGnEHILPshUU8iqRpqqwVY5RAAq3eNbaWRmRe h+U1YMoE79PCjuadWqyTXFXEGcY1TGkEOiDfKiJqOQa6wTxBNscfWjBhado3pvDf4M2j mn2bBrUd9ecRyn25/8jYbdMAeiXerzzu5pjWydokHiBpYK3X2z/rOncLPYnaC6s9/dsl VcJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874642; x=1700479442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=NUc8IAK89PMZ+m2pBLCHgnJ7my0hU11vpf2mj6do4TkvK6BcW7D0AdlIW5u9voDeXC bFqrToRrKsUPKNLnCgEt2uxgX1CgxRXWws3U16jRykkfOcj8f/G7Xri7CS54ur/n6ebJ vRssSCgrj798pHOnjY/+AcqEdTdFReyaVKF/5E2h901lmgD3Qzc6hreDRPWhyrkhzp2L P/wglTCmsM6Zho/b11/ifUfBAIuYPjg8aLPnAMSyqLPyDVVdXQtyLcyd2eQECkXUZDLR If8RvPxr/uDgCtiul3XE4x1d4iJpBk6qRLp/stROvJJtUN+4tCgSPV00KURnJgun+zv9 nqYQ== X-Gm-Message-State: AOJu0YxBUC9M6Ch+MI5r7qSd5qwOb3p2LXTUszgWyvqwuXYDNR4IQ/0v 6cRa7zJoMqDhMsZ7mt6dqGE= X-Google-Smtp-Source: AGHT+IE36bB2OzfEe98E4kghGaMPiIC5IuFFaTAdSXGE7DLScBaoAyzyOno2sf4r1XZ7tYHmWv/iyg== X-Received: by 2002:a2e:9d95:0:b0:2c6:ee98:de85 with SMTP id c21-20020a2e9d95000000b002c6ee98de85mr4239843ljj.23.1699874642417; Mon, 13 Nov 2023 03:24:02 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:01 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:26 +0100 Message-ID: <20231113112344.719-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 13 11:23:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453838 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EE88C4332F for ; Mon, 13 Nov 2023 11:24:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 945DA10E347; Mon, 13 Nov 2023 11:24:09 +0000 (UTC) Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A5DB10E08A; Mon, 13 Nov 2023 11:24:05 +0000 (UTC) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2c72e275d96so58624311fa.2; Mon, 13 Nov 2023 03:24:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874644; x=1700479444; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3o3s7Gg19og8FHPmLJsossp9CoxmOk03jVqJSNlvYEE=; b=IZrU5OVhXfKJFXAOnk970ALcy+jkE1mU16CREasU4tdtcbYcbmJZ+egUn2cIms/8AK tGCik8l/gFb+BTEVEAXQLQXdorAGKfaWU4j0Vo4X1EZ6kZb/ZdikRf4J9rBE56WSgCmz OeF0XAGPc0eGs7mEfzGGN8dAlGdabGr/K23HsLMsJF39PZy0/983AThq2s0pmKTxZXrz 2W4zzlCvBoDckLcFMH4yCdgBltdFAyfKDGR6zpPrLDWjwNhzDr1CKPoZLOgfEPmeJObV DMvIaNsFGrcl9cYCULut3HIiC+xpBCLh9mhTZWyq02Y6ET7ULkHaCXgvHStIX/f0Ibpq cbGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874644; x=1700479444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3o3s7Gg19og8FHPmLJsossp9CoxmOk03jVqJSNlvYEE=; b=qMi/kHErPh4AToCwAGf8ygRka4S7d29FUz6M8OF7FVqwN2w+HNX7MUUXbkP/ajpDv+ fJ7Wr5wWIJOWnE4gOM2hXwf6jUe3P7T5UqdcZxi1awZJLudhbFi3Q7TfP4bB+Kl28UvU e4L0tyONEe2tYh0BWPzNtMw2zfZGrdO2uNjqcWHsWWblxUx3QLI+CoOSdmiWpo1708pK Wmljpq2ySnn0ySqXLwCBGtn20WoKl+zw9pIaUgnLUnM+IoupMx9SuQu5QOsTB5sJsYGt FZUjTLPZVINz6Iz6NVZMyM0ZCVxDSQm8zuGJCs1EBAbeJ80z6qWCBGyH5VA2SKTtrENw KRIQ== X-Gm-Message-State: AOJu0Yz+qaahqxy+yagL6X0h40rPHZy8VNjv/M8hjfXTLQpbf2a8KpiR tU0ANeySjVK3NfTqP6nsMy0= X-Google-Smtp-Source: AGHT+IH61A5pPCfNwMBXGGsskBdp/S7K92gc20LeFda5wnWDvVisuAv0N9mZOP0o4Cx1RRVOFVPMyQ== X-Received: by 2002:a05:651c:102a:b0:2c8:323b:9207 with SMTP id w10-20020a05651c102a00b002c8323b9207mr4450710ljm.11.1699874643357; Mon, 13 Nov 2023 03:24:03 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:03 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Subject: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:27 +0100 Message-ID: <20231113112344.719-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , dri-devel@lists.freedesktop.org, "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Harry Wentland Acked-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Mon Nov 13 11:23:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8907CC4167D for ; Mon, 13 Nov 2023 11:24:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EDF5E10E34A; Mon, 13 Nov 2023 11:24:11 +0000 (UTC) Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3DC410E08A for ; Mon, 13 Nov 2023 11:24:06 +0000 (UTC) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2c72e275d96so58624601fa.2 for ; Mon, 13 Nov 2023 03:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874645; x=1700479445; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2A7KgJeMP1lI74vlMRztf0ZeAIQKlR0j/L1YwdkkguA=; b=ZT57/40tYY4WPRIYww7Har/qc4sTUhwHUCJOdfOwJjiyJ8f3mapgSB3S07fRptJrYh qlK80nIT9O5D5knEHNPIXIjnqQOvwZa7mE4EIFByCauuC0gFR4x232VotrXUHQAQKWkJ qbjRNcyNjrpzDW2Sg222F97XjpYBLdMW5VTR0YVweB8dk4cMINB3JXwxuRJa/5gaO9z9 X7RBP5DQYOB7Nl1HETFN8zll1ik/Oze4d2+3h+gx52eLQ1LxyJ8tVRIkH2DQ7iDbkhXw UniDWuRM/XW9lLdYSwCu4bEf3IJHwmfQMsGTnaeqeKealx3duOcBURMw0YCchyqC47hE oOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874645; x=1700479445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2A7KgJeMP1lI74vlMRztf0ZeAIQKlR0j/L1YwdkkguA=; b=S7eOSA5hj1CxS5OL6LlH3MDnmh1rupBdInTEjIFtkxXLyhZ4vWNBvACd7AqWne9/pP otswrf/u5y6UKg9xDTs4Q6BpijJEf/0YbcGl8NflzPVCyYgZqr1diiko5BK/C9VX62z/ ckV/UagvBkVFIQIXy3z2koAfaLq/EUk6lMn/ClBHQr5cgQ6KUhwj867prCpcfRyUmAlF agb8gIs/LdBxIwzgnpXLPwvteOSsFePP4rnKft/CbmTp5lghvo1BQl6/Zb3Ll/qMq3Tj +r5Wavz9ShqT7sVzPS05crNOWwS1eqJ/r6woIxkgtosmp9Hj21RZIfMkzGlHCrpFafJ3 M5yg== X-Gm-Message-State: AOJu0YxdxTZU34GfxjUJG8tPDUXymzuiymvLWlU25gf/4l4CtPyyH+GK NpXcwqjioPOSaEboQdcebRM= X-Google-Smtp-Source: AGHT+IE/vWt8sIluAJGbzp4DA3YgSD9QnVjHE9gZQVa6sNYXW8a/yNVaWFtAUhPLeeYxcoE+kXqeow== X-Received: by 2002:a2e:8954:0:b0:2c7:7b65:60b5 with SMTP id b20-20020a2e8954000000b002c77b6560b5mr5041996ljk.30.1699874644560; Mon, 13 Nov 2023 03:24:04 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:04 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Subject: [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:28 +0100 Message-ID: <20231113112344.719-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Chen-Yu Tsai , linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Mon Nov 13 11:23:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453842 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28A96C4332F for ; Mon, 13 Nov 2023 11:24:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4AE910E34D; Mon, 13 Nov 2023 11:24:12 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2845310E08A for ; Mon, 13 Nov 2023 11:24:07 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4083f613275so35514505e9.2 for ; Mon, 13 Nov 2023 03:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874645; x=1700479445; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ibVEHgtEJ5eQu45MMiPygdDJxNCKoN0M/oBQUtm4Q4=; b=NC0VOzO6MTKoE2oWZC4ncJXjMKZu461rRiiNmHm5GyMNGfgQMOVfhRVVKKfpeyJ+/+ 7Knz2eh/hRF+CQbmB+NvmNTFuAqQPeEdyb8cXH/CAeoX6j6ALz8xgsS1evl9oowVEjsh hno9bNUZtaKX4pM8oaC/VShPlgqat4tLIDwMphDpHfKn7znbJItOavCYWVmRFhxNRv3h oWapA52lkPMxLeGBSM491pzhNGwVV+jO3VCXsBM/k7JqLP5IBkTn7faU/zglWNnH7gdO RugeNTHZlyQDcCtpMLR8aOkcsS9RuxMzQeYyN2AJepnNs0UBCeMAD2E4D5hUUmK+E0Rx MVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874645; x=1700479445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ibVEHgtEJ5eQu45MMiPygdDJxNCKoN0M/oBQUtm4Q4=; b=cBOVVldchEy5dL7hmsZ0sGjdvi+Bo9ku9869q3bEOQcYE07/RMbEhVomYs8v5akonz Y1s81ZsQqCKUI/1DGAaUlDUJSIMNmDeNAiyMU0sZTSWSqQrtXAkXpyewofHlPyXg9n4A SvREUpGpyxfqY6GWHIz2rV1l44BeoSwyBwkmnO03QOwaYtlv8/iezv91oCjxZsF05Q0/ BYfLYAS0pvDe6xls03eAMghsO3rhhH8jO3lXlIUlKLRUvq9Rch5/KeRlWisg1x/fnLw8 youaAPZOSOegYTs3NXRpLYUcvBgSwgNgG/r7aK67jNvMF4e/ForsYhBXHmldioYuCPZQ 2IBw== X-Gm-Message-State: AOJu0YzGVml8sXxQGidDudL2bYn87ODlLcvGIujadg073nzEbVmB0dNv bsJjeeh6X2ba8vRGLSWO1QM= X-Google-Smtp-Source: AGHT+IFwoPnKRqNYZ50VTFF9dpExU5UAtXF1Gn/qxxZ3ZoO0LlwSRlRkjGu84hHJe+NLBkdc3zHFzA== X-Received: by 2002:a05:600c:3595:b0:406:849f:f3cd with SMTP id p21-20020a05600c359500b00406849ff3cdmr5399554wmq.29.1699874645374; Mon, 13 Nov 2023 03:24:05 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:05 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Subject: [PATCH 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:29 +0100 Message-ID: <20231113112344.719-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..fa07e1e5c 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,20 +158,18 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Mon Nov 13 11:23:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453840 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C644AC074FD for ; Mon, 13 Nov 2023 11:24:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9613010E344; Mon, 13 Nov 2023 11:24:11 +0000 (UTC) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4046710E08A for ; Mon, 13 Nov 2023 11:24:08 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4083f613272so37353895e9.1 for ; Mon, 13 Nov 2023 03:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874646; x=1700479446; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=A+Wdc9KmwX5Wy0zV9CPmJHVvuVLfIVGLVKvZeQkC8EekMIh3ao/Dz0RfGRPIYH6gsT oGeEiYKe+xiwzGgF4lJGSeK0NnEYCrdUqVoXnec4JH402H2ZMrkFIWpkPGQbZCIRm0FJ AU5IzzP3T25fr0a3nN1qGp03jZMlINddPeZ5H4bi/QfjFP8Eippdkuvw7hnf4QFUWInk 4gI9WpfqP2XurVuSDbUMaZIpsHai7FXKlSHqj+ejicI9TxridZyQ4/vG6DGqvQFqR6da e40jGsHkgIZbbYBv5tF1N3RqZtTSHcneRg1aRkTCwo21RSJRgctcofStzBExamQYt4nU 1h+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874646; x=1700479446; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=mX/mAIi9kuDgaGGSfMHzBA8a14sd7nhvIwXqP44px4wc6/WGgRsxmAc13fpAv9A0Yg cKL+yhSg2K0ohowqBgXh1wStZ3XIHZg1yviQ/u5cX6ph/8P9sJdZWy6wmp4JAhhJBrGp e4OVr3+HbLttkFKGOPzbTY0x+mRl8iUfQLJjc+VNvpVXdgyHYaSiHaF3AzyX2NrNEHlX XEWeWZbRMRiff0SAVPHN4tL6FM0tibRr/5R7+745TSs8ECavPnI1v2VMsqwOHbrkme3q sby5lPGy0N3YreSkCCONJDWgaP4LXhyHLYboDsU8G/9EZvGs61aDtc0bcDAhxwgEh4WJ EqjA== X-Gm-Message-State: AOJu0YwwcL2OxWFWxyln92wYprbPsC3TjWudz8rjT6bpNO+YCixUaKvi O+k3h2pRUOfdxNSKWfsJAbs= X-Google-Smtp-Source: AGHT+IGL3EktaBJFjj+0Glil7T8bNSbTgzf/Pqk4mNBNsYEc7WZFPHt2hi+DW9OAvH9O20i3TarP6A== X-Received: by 2002:a05:600c:1910:b0:40a:3e41:7df1 with SMTP id j16-20020a05600c191000b0040a3e417df1mr5289314wmq.37.1699874646477; Mon, 13 Nov 2023 03:24:06 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:05 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Subject: [PATCH 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:30 +0100 Message-ID: <20231113112344.719-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Mon Nov 13 11:23:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453844 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 660D0C4332F for ; Mon, 13 Nov 2023 11:24:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B8B510E352; Mon, 13 Nov 2023 11:24:13 +0000 (UTC) Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 623F110E08A; Mon, 13 Nov 2023 11:24:09 +0000 (UTC) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2c50ec238aeso60840871fa.0; Mon, 13 Nov 2023 03:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874647; x=1700479447; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5Op/de/de9WVnMjIIu+X6jQDnWmnKOCxjgzgj2VkHDA=; b=ETiJdIxrCiymCDydg4ENXjR9Te2yvObiLkJSQMU1wdMq4risx6L0AtFtAhNQhe3XNx VLhszNtF0HX5Mox97rPdMRf4rsQmi58So3rKA+1wOs13CigEjiAcy58WCvvh2Ljl96pE t71lF0QZxQ52vwUQzR4sHM/4qiSTi/cAGxsffAxSuTbUjjXHOvRiYqYXJqM1HTlG5VDB dq0TuiR9IWtiu+6yZyMe1HYlGl64DwEPSiPGWwYe7PBgR6oZXbcV3xvj4MdMx38Po2EN JebtYH9FPLfF0F/wtFRrmw+k5WXvfdY+LqQQ3K7/eVcJIKo37RsVVC13r9/xaToFrqUq QYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874647; x=1700479447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Op/de/de9WVnMjIIu+X6jQDnWmnKOCxjgzgj2VkHDA=; b=VX/jn0K56P1CeErYLZ5ayyRlVESf/pHsjUrsWW7PPUuS5e7EQXMZCtKEkNiqhVSPCq Di0AhEI6NTSXTTRdDkcMEXslXfjyFph9FK215WqQLYQcomEPEueB6VZC/af7CmmiZE8R c7DtbUgQEf3YvaxQVYx4eJaafEqyXepHa3ayisP4ZeIF5Dwa29sy1dmiHGxeKwaSSwtY CJtFtImMFldYIoB4fyylpFok7yCWzwAEE8OtsA8Pjs6AuX1G+rg4NpNgwPCYwwTP6stV e90/J3ew6CQpcK+b1+KTBTApVUipm3y5zPAcPWsfJ86LiLA5/VbdKR3CyQoLCFwmSNYd QqBQ== X-Gm-Message-State: AOJu0Yxmpz+aBrx7GdrM/6c240WgfBFrdDbJvy5m258RixLwC5CK/V5M k+ZqdULEuF7iNcdgnbxxA9Y= X-Google-Smtp-Source: AGHT+IEJsBMp4JbvFi4pspNX0Uzx9z5MBDoZN9PZxWzXZcpLsSgHiFtlq5yu+gjphO5CZmj++0wsZw== X-Received: by 2002:a05:651c:1049:b0:2c5:1f70:a266 with SMTP id x9-20020a05651c104900b002c51f70a266mr4020462ljm.50.1699874647541; Mon, 13 Nov 2023 03:24:07 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:07 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Subject: [PATCH 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:31 +0100 Message-ID: <20231113112344.719-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 13 11:23:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453843 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4910C4167D for ; Mon, 13 Nov 2023 11:24:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4AE4210E351; Mon, 13 Nov 2023 11:24:13 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50E5E10E08A for ; Mon, 13 Nov 2023 11:24:10 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c50ec238aeso60841101fa.0 for ; Mon, 13 Nov 2023 03:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874648; x=1700479448; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=AZTkHQI/9GVzspULMGH/sFy6qgU9BkA8amksFpvzMzY2yYHUyfA0jtlm8AZwcqp7yX Rdjn8Gi0QKvzc1pDXgymkRzfmrgvZWfAEHNtggrlkcxrggK8wfYW6Xk/Hncd2rU8Xr9b HU/ADk+o9JvUV2EZs3VhzORTYLKtw8nx6wY0ufbVn4qSYTkQh+PKZZj7994zwPaB0Ko7 p9xWZh7YC5oz1EuqWtjYa7ZCsDLCswAeKrmpVTrjQaiG9EZyado0TK6t0p2EGuDnn7/X +XHMiAf1sLHVBs78nLeundcN+f13AEVdT6xU4TxQsmMPtwfsiE7g3RGtzGu5NkXEsbiy Vw8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874648; x=1700479448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=JQ+yhywzF8evtoy6v4wA+4T87LE+x2XtTEjGk9k8xS0gM5m4ez0Y40v4/MK1Ht7lFD ZAsIgsBQU2RYnhbwiC02bu32B9ZgUm63HiHLOSpELClJkxYhe33RAX6e95r9P+aBa70k yUkH/yM+F9fuAg3pE/ArlmNUZkRJx0y08LObE8YOcSBXlfzTN9o3zEv542E6BA62nqC2 oy3isPMTFi9a1l98YWYG8Om24Sgyh/vt3mX8zc/yRl/q+SHN7IPLyvCLSh55zkogYWvC SFrA9tvOTcQrmE9DbdR+mlR29W8n4FR79DLmijC2sCpEsqcBRC7uzZZevDldqtloXSKm d+Ew== X-Gm-Message-State: AOJu0Yx08qgaUX34gsPnIS/gTmxEwS0kpWyMCBep8XzZ3Sq1GSUJ4+7+ BKoQ2pYUc5s8fE9WBPBFU38= X-Google-Smtp-Source: AGHT+IF2LC+FtafvR61kuDtbo2rv3av6bi24h2BSF0FTWH3WvMa6H2hTWbFG6Bmtzn7VrYm9qOaXwA== X-Received: by 2002:a2e:f0a:0:b0:2c6:f17d:ae84 with SMTP id 10-20020a2e0f0a000000b002c6f17dae84mr4752809ljp.3.1699874648370; Mon, 13 Nov 2023 03:24:08 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:08 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Subject: [PATCH 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:32 +0100 Message-ID: <20231113112344.719-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Mon Nov 13 11:23:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453846 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BF11C4332F for ; Mon, 13 Nov 2023 11:24:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BF8510E081; Mon, 13 Nov 2023 11:24:23 +0000 (UTC) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by gabe.freedesktop.org (Postfix) with ESMTPS id 083C310E344 for ; Mon, 13 Nov 2023 11:24:11 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40853c639abso33451345e9.0 for ; Mon, 13 Nov 2023 03:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874649; x=1700479449; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=CWI3PRqLKXaZIWSRoAR7QWWLPVyMZ/jBEHxGEUxPba7uflI5rZmmN6yWRxNNJ71ptB VEpL8TiZDgOahFcEXro9ccREK9Rb6eMMrhoyX8wM2RvEam4Kl7bZCaql9m8AUPZwXz1M xs6mdLbI1+hZ8GMyPW6ncEkOIeaE98dtSD0N0YTJ8cuTcY8A14FqvmTEJqKJ3SCbNroK iBLWetAj35vHIluLVkbE7nDXBhPGr+DnTvTWRHkQmiAJhkHIJ78Uqvk3X9Gh42T6NaIN READbt/Ic91HPs9IUrwUyFKgDhiscSeWE2LIaOmEwuFP0IIvwxPbKIlk2KbFpCcDtX6l 60lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874649; x=1700479449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=cgfPA8ndbivMZUshaIaMCM8NkVJPnJ05G73EjAiARdYt2EjF+RPIDeyx+bPMpyF9PD dN0qr+xonkjTjTPZVdXXMPshQg8b8FVawsnlz/TulZg7BnZl/ebpQ/oQfChlm+dqrDFD kZTznbzeqrSBhJ3/Od0T6PhdH3+lf2tk3k8Ra+LLbmURSm5KeWY25fki+tiWubggmxuy FVUmo00YNAXfJHQwHQ6kqD57wbVqCqvZ2tCQIv2cbW/X9VICe3afdV0q91vDWsuwf9kX R7x4iOMbWCwydkcjfMr6apXyiHA5gBDNL1QcSEkBTWPUE0oED0DpVMjXDHUNihPFSSoZ 9ELg== X-Gm-Message-State: AOJu0YzrdY9Qg2nVy51J5QSPazEyU9wb8kdB9PlN8fyi+1jG1jqtjL92 2W/EowyTjkuqdm+Sk6b2f1I= X-Google-Smtp-Source: AGHT+IFWxagdYbQ04Cy1zXQ8J3RXxuSkeTrcraaBkbbYjfhgHWD8ZbRjLDfDALyWkgIWGKQzSnNbyA== X-Received: by 2002:a05:600c:4f0e:b0:406:5359:769f with SMTP id l14-20020a05600c4f0e00b004065359769fmr5703626wmq.0.1699874649154; Mon, 13 Nov 2023 03:24:09 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:08 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Subject: [PATCH 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:33 +0100 Message-ID: <20231113112344.719-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Mon Nov 13 11:23:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89BE9C05021 for ; Mon, 13 Nov 2023 11:24:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7A4E10E353; Mon, 13 Nov 2023 11:24:24 +0000 (UTC) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id B228710E34A for ; Mon, 13 Nov 2023 11:24:11 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40859c466efso33254375e9.3 for ; Mon, 13 Nov 2023 03:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874650; x=1700479450; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=XKMbrChvYXXicBq6jLNwD42PEV9jd4gKy8NE6qCuNnIjWbfgNrbpcSUd15RvLAa3H+ uWF45S//rD3v3zRxhQuVsQjOLbbGcPOZ6IKJaroDq+aBLgrzusH3YMg0uO35KtMd61eW CSc3q3xKSy7auvaVOZNjE/OPyrgDgbzhscmCLKYoTIssay2oG7DO04/ikPusk+4Ly9vc Z0mykrb/1GnYAwBfx/8/LXVxeBFvLv9jEjWUw8LZe/Nh7FcJcYg/Z2Z1epTc85zVFY8F 7bV2wdBzKWoDVXnWc09Lyh90+8YQJpgpmxJ/LJffmHqKFL78bb2M+RpArRlrDuyFXjIT xsrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874650; x=1700479450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=X+OdfU6LJhxkV//Mo7t5uP0ekYYd3V3rg/Ofd5o2brOq2IiIAVn1TMe8VvHmNwSC52 cBSSaV7cZn5g6prJtl/mNtCPFNibHW5v/Sbrg5epX0/3ZJQ4tpN3kNN1U2BN+EKq+neA 3lyOtYX1brqwzhUlVBnm2+DXIUVjtQ+tYAC0ent0/XEGhSpQLsuISFst7WpCKHK76E56 s3AiVvvaONHZoZCR1/RVXalvQfqqWzMkjVP6rIyJ9/p0iGVP2yC/2xPQEh8U6PqPOq+G 3h06vdhhAiwS7YLDZqXGC4XPxnhUgUfKK93G+kf6L8IwV7otpxv0Gx/N1cLkepCDWAyn RDJA== X-Gm-Message-State: AOJu0Yw/P02wvTBnHWt9btAAfnmD/z+VMiN2LwB/RgOmzzTgk0erma3r c+RCT39DTMNRfk+1Ag4yQgI= X-Google-Smtp-Source: AGHT+IFLTl+fAOmA9wfAnqq5QL35Y8l0EQWxEuKGeK/UmNhJYPQBWfJpPA26uHWh9GGQv+cTL2zTow== X-Received: by 2002:a05:600c:348f:b0:406:411f:742e with SMTP id a15-20020a05600c348f00b00406411f742emr5433441wmq.34.1699874649928; Mon, 13 Nov 2023 03:24:09 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:09 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Subject: [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:34 +0100 Message-ID: <20231113112344.719-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Mon Nov 13 11:23:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35B97C4167D for ; Mon, 13 Nov 2023 11:24:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3B7010E349; Mon, 13 Nov 2023 11:24:23 +0000 (UTC) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 984C810E34B for ; Mon, 13 Nov 2023 11:24:12 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4084e49a5e5so37220125e9.3 for ; Mon, 13 Nov 2023 03:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874651; x=1700479451; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=hjUmG32FYoOaOoIEQUKSmext4PDa2aFb2kyQnnxxD1dQU8eIzvnFMNn8LsDips6F91 DjnP/ugtfVS27WBryXzcFIom1nfLps3Ltcw7M1YoKSAW2V90y/rNl55RfG+6GrBINi4H WM7BsbUzr2OHdCOElOAk9pwrGgrL9xVVyDTd8YRzoCEgKkZh0Hx1rLWskJizRn3hx7aH FqdUv+HHGQyPx2R2BW7cILwcZoUXIZxAuZMHtbaht6NZYyJ7bSEBgG1RpX2C/z391RkU Se6yE949b+jn2rZh6LuOKzYN6E06IdYxm1VsUuBwjM25kSlkyo2ZIwzIPfbb5Qr82k3i u00Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874651; x=1700479451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=PcvJtz1Rt/CFTSEG1235MzY5sNsS9/GjRGVNGfuoGMca/C1y4VVm7zNK0OU/SHhw/o 7SY3QFGcyWP5rUpkCSX2thltYhzXBG6fOLWYM2EJc/i/ho9raPV+M0fd9atHTAokrCCS G50M/+ErI8sVUyrczFDWrmXQb4i8lGlKk12ppLw0zcrvF1bUwU+JJSu0XhZzNkwfqKVt 8i2zANQ9dSBL7AMveEW+9WXukh7aHXxPM6D3HlsGta1282RLVzIQJtx57lTUDoYzbly4 wokVCY9m+wqiFfAvJa96HL2dhZo8tqVo8zDSs6WU6IATUTf6mcdyxAD96h8tIfgzGEwA y5vg== X-Gm-Message-State: AOJu0YzvpQZ5YdiTEqLg28lwUruIrZuuABw20E1jbEJ9F/Roej//l29c fekVrrh3FmOVyaiDDGVq8lo= X-Google-Smtp-Source: AGHT+IGFHS306bbRiz2f+lNTVzDFOlLgNqhmA6tscwfIyFuanprmk3KxQkw7tNj8GMTBgarDSCdngg== X-Received: by 2002:a05:600c:21c2:b0:40a:463c:1d8c with SMTP id x2-20020a05600c21c200b0040a463c1d8cmr5105398wmj.21.1699874650883; Mon, 13 Nov 2023 03:24:10 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:10 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Subject: [PATCH 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:35 +0100 Message-ID: <20231113112344.719-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Neil Armstrong , Robert Foss , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Mon Nov 13 11:23:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453851 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05F15C4167D for ; Mon, 13 Nov 2023 11:24:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D79C410E350; Mon, 13 Nov 2023 11:24:24 +0000 (UTC) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 888E810E353 for ; Mon, 13 Nov 2023 11:24:13 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40842752c6eso35114825e9.1 for ; Mon, 13 Nov 2023 03:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874652; x=1700479452; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=i4XRB2UtSBixmVdFcojHTHFbx5yFnqaRA2pqHbq+vOI8uk28OmneAf/LPoZIsiBbIa Hn75Nvc20u+xPf0quHFErWG0x3Suf7YbuYT6PHCFnOI0czVmYWNchmqZ89v/E5gTC/dy KGjT2n9CdSVo7SdaWQETl81XRaMBBUxknDpV9SmKUvbKpnJtO8mYZJnjVGHT43QSt8jd QmLYVqmvun021QnIl54oT8TjmfAXZMJ8riTKiuVrRUQvj4e8ykU7P7p+kLlAlvpB7tcJ lroJrjbkbjthrCfugAm0e40icQgVWE0yIVUDVspHQbcfqmBrZcNroyh6tVromJ/qK88d QYYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874652; x=1700479452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=iFTCEMwAVTaH59atHMi/pokhxFeiXhLokgvTq+JGLLKdt1at9bpHd1/GJjQ0/iYZcc 7LWCBYH73BSGEJiLuIO95CSwBOgzTyYrZib8NvNj1TJQw4uent/qzbqdPoYP4hNXhDAK dW2HfHzTLYei4/lbGf+r/K+/oEF6LnEGv3Cu8/eUpesb/pHbVauyX32D5U04K8XCvrP3 noWtRA8fx6z99b48ID5xv1c4hzrTWY3bwwUB0zBDbPFu1tlSsvDbsJpI8OnlRSP36R1V P1nEK+8V0TvmZ5X21pe6UMWN0AoRR9WTvmrSJolHz1yeAT2JpFHYKyTK/6CE67g6re/1 U9hQ== X-Gm-Message-State: AOJu0Yxt+LnNnY2ZNw7TEWmucMhgIMDSGn/nMBBPW3QG+S6IpUvg5Rh5 6e8Ezcpnd+EIPHGz6POYMJw= X-Google-Smtp-Source: AGHT+IEb96vRjjDVhf2WWvt4ATSMI0ZIHMZT2M821fnApL0F6zP0tqP/mZlSqQGsQCCeZ+/3gKjOXw== X-Received: by 2002:a05:600c:4f09:b0:405:336b:8307 with SMTP id l9-20020a05600c4f0900b00405336b8307mr5644653wmq.7.1699874651755; Mon, 13 Nov 2023 03:24:11 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:11 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Subject: [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:36 +0100 Message-ID: <20231113112344.719-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Mon Nov 13 11:23:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE5AAC4167B for ; Mon, 13 Nov 2023 11:24:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5C7B10E34B; Mon, 13 Nov 2023 11:24:24 +0000 (UTC) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93DB510E350 for ; Mon, 13 Nov 2023 11:24:14 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4079ed65582so33751865e9.1 for ; Mon, 13 Nov 2023 03:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874653; x=1700479453; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=fwrHTycREC3fXYEuexiNbh3+as/eaJxkyVD4NHtRyrXvH6/DzxmBDWSDUzcW6bpj8/ EZn0C4KMQlpw9JBepec+UbDyx2mlQOh5A2X9KRJbzRTvm/hssNfnj/Uq3EUC0jFduYLy SsQArVTvQBY9I50pxMJ/tVyO4MPbuP7xlKAbu7idhANhCr0UUUcB8zhaoEAJt+KP7A5R vqAS+1veEXIHfIvJGwqsC1OheQUg0EkD8LWickFr3WHzbQz3acSLYxlcMusSUxYCYSY4 KX8gRKhl3AdK2eBYm3OEwGrfDnt/FJc+eT11nAs0GLGUORXIuXymUVtBvUgZY7HhMOVg ojSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874653; x=1700479453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=FrPpdinPXZLJKcNsH+HXo06751y0crJmMT+HFcSvQPxnNgWvikdXRYC4HHfOPIGSww BYsaDEkwQmOQRPYV9ZiF95tR+KioWkfv+Cb5iHPIY0Ll0Xqy9/7/z8BSgn6MJZ5TVC4h 0XyvDLJng/85d8TRupw0yKth8S/+sb9wi6wAZkzfbwNGgDP9YlaGjEko41ozl5/8pM5o lGVmROOxX9ZVri8bGiWE7qfrLCCX9nileWArMGqrZjpFyqtbL4zNoguhvep7V3X2x7AL BajNw4qTC1+JmQajo0j0wMWMswGORf8Cu772kf3Azs9v4ZP+6vLy4azcJLhRqAIxnNKV h8Dw== X-Gm-Message-State: AOJu0Yy3NSvtBeWz62BfEV63Fdj10+74zed+HYo9c4oeNGToTXTgCqlj pkir0tvcP2ApjPaFBMAoUXA= X-Google-Smtp-Source: AGHT+IHy+wgfr5xLKsgYxJHWa4lnkaxfLqJyegu6hthXuvkFsozVMyaPKqUw4LKtY+yJp0F7WGOiug== X-Received: by 2002:a05:600c:35c9:b0:409:2c35:7b3e with SMTP id r9-20020a05600c35c900b004092c357b3emr5232809wmq.8.1699874652877; Mon, 13 Nov 2023 03:24:12 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:12 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Subject: [PATCH 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:37 +0100 Message-ID: <20231113112344.719-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Mon Nov 13 11:23:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453854 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E162EC074FD for ; Mon, 13 Nov 2023 11:24:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4427710E354; Mon, 13 Nov 2023 11:24:35 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EEBD10E353; Mon, 13 Nov 2023 11:24:15 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-407da05f05aso31960505e9.3; Mon, 13 Nov 2023 03:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874654; x=1700479454; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=H57oAMA+MtBP40SJQZeKxDrQb0sz60tJWol0vK7/Vr0gh7KJT5AWBPg+chuVIMHx7M jgmhwNpuxoGBZbWA68Y1z3LbPE3rP4s63SnG4E3zxji1WLn3IL5A6iRCQARWM4vNGfHm xw9eyOOYE35WeithXrxxkkvyopWMwJvKpIGI2DHCRnps6niWlVQoesKJUWE0ZeclIYan UEB5ee7iAVxH87Z1UCIGphhkYIH6/EtTERtUz9caZqNcMvh3mns+EQivbZo+zfp35ahU WdmoAzyy/mz0Zyj0gT2AbS9JlRHhq8SWw/cGb11b/1UB1MZzvWpU+yLKnamB3m88WiTg segw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874654; x=1700479454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=GEyDlpMyUdpg51Q0WnKsSKVvDAREXma6RPaa+jGHlK+eHUACZxoHxjImUTHHb0+l8E rNwcCLJVFPJAEy8y4iwnYDsTuEcJkmYnRrQF0pFkpYHg6j3XLV06uca3JlnkSf2Ajkdb tn6QUsuGY+6dbDThwxyhGsrWFg6EKWbDLtpv9a049Qccj3a9+njQXbH2vbshyO1Afd+a jweFDTbqhsWXn9EDnMM5rV++XJmjK/LRklo1Oh56oSlpsRrznxnaM8sUay3pZtevdpMd KOrYuTxSmSdz1LwEk/601MaC7DYQWT0w4btGGSsK2bzZ2wtBqYeVQoCkeSjxnhYs+tsw nhzg== X-Gm-Message-State: AOJu0YydcV5S/HT5oDiboHIMPy4D99862yIzNs0LuEgG2+b1TZyZsE5A 9iinuyJulkbMIbbISyfkwgE= X-Google-Smtp-Source: AGHT+IFbNwXT87/A3jEt8J3J2IIJaKfXP5VLFa7X0d4Q5ivIh7Rq49/jVdFtcRm7vBeOvUh6yIYXWQ== X-Received: by 2002:a05:600c:4f54:b0:401:daf2:2735 with SMTP id m20-20020a05600c4f5400b00401daf22735mr5024747wmq.31.1699874653800; Mon, 13 Nov 2023 03:24:13 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:13 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Subject: [PATCH 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:38 +0100 Message-ID: <20231113112344.719-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , Sean Paul , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Mon Nov 13 11:23:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453845 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F193EC4167D for ; Mon, 13 Nov 2023 11:24:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE25510E08A; Mon, 13 Nov 2023 11:24:22 +0000 (UTC) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4319B10E353; Mon, 13 Nov 2023 11:24:16 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4083dbc43cfso30655975e9.3; Mon, 13 Nov 2023 03:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874655; x=1700479455; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JvPd1H+dWTCx2RVITrv+behT2FwWqNCuM6LTqdrhGms=; b=Lt6mjN/S5sFFwgaajjSalz9SsHzFKxdLcUNOYeJNLwr28vkjXN6U1wfXei5STnfOJn ZWdeQ6h/qDJfOiBw0xeFDPVt841befOtehYzly7buxGRgXz8BLg92pGMawPLewitIkC9 xRCGhb/VCNuIaet/RC2ZrlpFfwV+XzvUj0yi7XtglyddW91OZoAiQgXOlcQua4KdMi2P h0kbPahfon9s7ZGRhjOOGUBE2g/yTaIg9zjImlmvIGE+Uzf1AveHeRTDE2nPSxopbpsp fwSwAT9xAoBVZVJPttBsNhui3dvI+WbnygRjraCWL3tp3FV5CubYzJU+vtLLlZtQhy0S QuuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874655; x=1700479455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JvPd1H+dWTCx2RVITrv+behT2FwWqNCuM6LTqdrhGms=; b=SoWRfbn0Qr0Nm15vhr1RESqDsBVFZQfub6YZof4ucQI+4uSDR2DHHlYmacVQxozmGJ sYi0kVWtCbMI6zs9/dK+w4pnLUp9nBMwnjDvE1w/PEOYOFoFX3Mv6XfqnC6qTGQ4KSYX LzPbaImP5IGGhzAiEhEo4WJV20ZN1O0+K637Xzj9fQebRm5NQxRhboy9jj+kBlfgpi37 o/OIek8PCXEPh3ZTtWB+TrIfRDgYfeGBPqbeXZLA6bJvUmWel7Zkvfj3m6BKaGd7Cdsv slMDFLwqU/fh23802UXZsTWQqjNGE8VOQpuSxpU4X90PAW84bZGi1eCDy9/+9RBb+bgE KFFA== X-Gm-Message-State: AOJu0YyzGaxActCoRoILfXAf//+ibcvzav8Jf6SnUuCg5a7jb/frEsfo IXJ8OHttE0dqt31pbdfTPio= X-Google-Smtp-Source: AGHT+IEP+gQ/J990DBm09WsofRknlQRFM+I5k3Yr34oHvEhPlK+QyTp3PDB57QWr/1O4qd8w6uHuiw== X-Received: by 2002:a05:600c:4ecc:b0:408:40e2:773b with SMTP id g12-20020a05600c4ecc00b0040840e2773bmr5743943wmq.34.1699874654607; Mon, 13 Nov 2023 03:24:14 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:14 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Subject: [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:39 +0100 Message-ID: <20231113112344.719-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Rodrigo Vivi , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Mon Nov 13 11:23:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453855 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C09D2C4332F for ; Mon, 13 Nov 2023 11:24:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17D0710E35B; Mon, 13 Nov 2023 11:24:36 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C20610E081 for ; Mon, 13 Nov 2023 11:24:17 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40859c466efso33255255e9.3 for ; Mon, 13 Nov 2023 03:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874656; x=1700479456; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=LHF7S4ILBRjncW9F0TGCaIbKue3/nI57CSa4iCBi7yhCaxS6xdU0WwHJoowBGG1HWy wTwON8KyjWEJ0q7dX+Xc6SvyOXvCmNCGB1aDUCBQ5pirhAPCfDbESA6f+VdOw03ISPe9 FZbI9ojrfaPAOOy8+rQuCJqbwhMZVxzPXJOOPgO4XspSptsAOxyD3hwJvEL8Mlv1RYBA T0q0sDujRHF9+eA0q0wtkJnPm6CwXgttJ7BBssJta9dFBPPSqvMPqLuBBaL7bIU2hUuo T3VUVsnx6d4BnQ8mLD5o392cZt+7MmMNS8AAuTM0TFBT/X8l0pGrvPwW+201feoApUQo y7AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874656; x=1700479456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=i0D9KoXjrQ5oL+qbEd7ZY3n4UzKkj2wlj+6sE8xGeNBltFeYkMUTv91Smdf0Jpsa5Z 7MflnEdzmlidcGZ+T0zMTYK/4LeUqzRdR8tbpmxxijTmzkaiL63fOHSPrrk5lb2yXz/4 vOHNXuoiwXOJGPRs+O0hWmS+mGVK1e1FqnH0tuFbYyCbMc6M+4UzqA1LLvYKmBe0r1VT pvqr6WkQfzACXIldFe9zuyV3lTT9P7fBFaQyp5hihH+XcqtqyI2luaLKLgAu+U8jdvnx fUagYCMhAlxB4qoVO9/BXS/2rxxilOCM1krOWRO1oj2yuVgWJo7nUAH/0ZyYoepkJxnx MjvA== X-Gm-Message-State: AOJu0YzFt6ejjgVvpCGxkpjCPfD6yYH+cx6SDNk0pJ382aIcjkTh2kQV XaaFFZDsBURNP7fhK4F8Hkg= X-Google-Smtp-Source: AGHT+IGb+/PX8N/YBLSMktQPtV1TVThx5TMgiemxOvWo2/x4okWcnwzbKL/ul1BqwEI+X1zzPo4MTw== X-Received: by 2002:a05:600c:4691:b0:401:38dc:8916 with SMTP id p17-20020a05600c469100b0040138dc8916mr5424949wmo.10.1699874655563; Mon, 13 Nov 2023 03:24:15 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:15 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Subject: [PATCH 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:40 +0100 Message-ID: <20231113112344.719-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , John Stultz , Xinwei Kong , Yongqin Liu , linux-i2c@vger.kernel.org, Thomas Zimmermann , Tian Tao , Sumit Semwal , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Mon Nov 13 11:23:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453853 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81BF6C4167B for ; Mon, 13 Nov 2023 11:24:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91DCC10E356; Mon, 13 Nov 2023 11:24:34 +0000 (UTC) Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75E3110E081 for ; Mon, 13 Nov 2023 11:24:18 +0000 (UTC) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c50ec238aeso60843601fa.0 for ; Mon, 13 Nov 2023 03:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874656; x=1700479456; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=T79ghEM5OWRo/EGIsGU1zjgPHJAtJzwh6zhG4XsHM0hL6WhenVM1iHWdmaIOgj14/X vjjPCwBEq56tA0KOpVfE0EU0uSWhcgzkw2szsZkOsc3LQNzg/DCPttKpDqKAtxu9CpeL ki7i4xeVZbuTHoMjip8MNdAv2y7SZBSzwJlGg03EsniWI26BbaSSaJwpFfAwZujo0ZaX P5vKdWg2KHq4EHPbyFpwcZZmZQWY/pdFsKzY7iXQOQtbH3BXOqMN8w+bavAW237VZOGu GkMlH4VL7SaebxEAbyDTDVKRNlsHkALPGGIzy3DfewXiZBdyj5qDyP/M7l34dQMGBUla gghg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874656; x=1700479456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=lqhXKHY78j5Me0arf6fMO+hYjo4cSscBXjVNxHlu/uszTBvYdhvgLJGkFfrsKJthxz cPUhP4fJCzGwgDueRAOMHQAF5K+EpBUbBxBU22o7nfF5EBhtewCdG/o4C+81NQWvdje0 Brd0/06soTFmZjMalzOOqjxPTpGnb2x1plNKuRHkW0kTyvAMtdPGORHSBx7DIXcVRY8Y 9glvjgHH0hR8fIAzo4WOKEv7i0rF6/AEJgJZjShpTqu2M1gQZv7OqGmRBVe/VdgIgB4+ 92X8atUYQ/ErSvXWtp7qezLX3McnceJXD2fT7SuxihusEHeKBRzZZEA6rUWoO9yK8uTL yJrQ== X-Gm-Message-State: AOJu0YzRUrhsTUuizHt9jQhkuZ9BmdUHvbpy3VpGY2yWnYI8KUkYANqj TanBVDdtYRmq96z8FRRKsu0= X-Google-Smtp-Source: AGHT+IGwZkPMUDnYf7aWTcm7+nEKhgTcMFQj/pdloNSaCeOKlzkBATJoAqDNZ0r9EMoXYM2oSPX3zA== X-Received: by 2002:a05:651c:1049:b0:2c5:1f70:a266 with SMTP id x9-20020a05651c104900b002c51f70a266mr4020668ljm.50.1699874656613; Mon, 13 Nov 2023 03:24:16 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:16 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:41 +0100 Message-ID: <20231113112344.719-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 13 11:23:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453852 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C2E7C4332F for ; Mon, 13 Nov 2023 11:24:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C0C410E355; Mon, 13 Nov 2023 11:24:26 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4855B10E353 for ; Mon, 13 Nov 2023 11:24:19 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-409299277bbso32033195e9.2 for ; Mon, 13 Nov 2023 03:24:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874657; x=1700479457; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=HL/WaCDE9yOqFmRvpInsCB1GFrbytW9+2zM9HGRoWKIVruyt1DarOkynMZbUay6jzM /fT4XjmO10BIgpsxnuTYUib3xae7v53J893OpbZKavQQPHtHTXxcAxb435RSbPQK2y2f dUVfN09mJjlWrjGXb7K7n9UQP7kLCriTHQSdprC3attuaFxjjg1FEVozL9IfxLyRrpED X0/Ju3+CDevDaSB/z3f0OPfOPEIvpTUBCXxeeF+NSthkMhAu3l3zag6rhwEAiuZ97Adc 0slQErNh+o3n/yb5/6GZiEDhYfXJZzfaYQHDv785lp4V+lsUATNNoPbJSc1ZQSF9Woit O0eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874657; x=1700479457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=XmZ3ZlSGFv3aQ4hakxmOxrncQzFfSrJe+8tK9F+Vc+QdqfpPggwVAuDPxruBUcK0I2 5ABKrGq8HXGUL85fxlGJbb0m7uCQgLDceFJGxcaSWXW//OfK/eYv7zDdv/E9HKVrywpm bFOsFzEonKCh6NBw8Jm5VdGgPDMRqjcwS+GVz7iF6it4YsBL02k4HJZsQCYHYj+oIsRn 0qnFPWm2wqacbF/XJ7E/9Rdo4SZ3XSMXDl/0/7//geBCdtCoWTPyoAB7+97voJ7jN77E joENHPk42oYujQd2Rr+a/L1yT0hSeM6/qzcVqpCHV5GUNsbq34QORdztZCYJIianAP9W /Kuw== X-Gm-Message-State: AOJu0YzkWgNa563+hGtuRpTODI8IDAqnEPgeTF14VmEYJ1lhjhfek5eX KfdX+jj695xpt8Q7yYnJ/8w= X-Google-Smtp-Source: AGHT+IE7eFojeiNDrcKNmX5F2m1S5iERu3l7sTJdkhZInxXfHkDe3DfDng4ExEJMZ05PAGHbWKiS3w== X-Received: by 2002:a05:600c:4710:b0:401:b1c6:97dc with SMTP id v16-20020a05600c471000b00401b1c697dcmr4475019wmo.23.1699874657598; Mon, 13 Nov 2023 03:24:17 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:17 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Subject: [PATCH 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:42 +0100 Message-ID: <20231113112344.719-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Mon Nov 13 11:23:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13453847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 023B0C4167B for ; Mon, 13 Nov 2023 11:24:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 88D7910E341; Mon, 13 Nov 2023 11:24:23 +0000 (UTC) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6517710E081 for ; Mon, 13 Nov 2023 11:24:20 +0000 (UTC) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c5071165d5so12110791fa.0 for ; Mon, 13 Nov 2023 03:24:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699874658; x=1700479458; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8o2HXYJRUVQ1Lpbm7zM61UahrNOCCIAHF27L8iRvJeA=; b=EbYRLcwxupyOJ3bk2Xj+BkwNNzNvs6sCJq/fRGqLClJnfORNx8NPhzlJUDjID08115 f7a/6UjX0w52azE56VplBsRm5iruhc/31kUCjQ/JbEKjSFmXBax3nqPmN9f4bb3+IIBF 58WSGmwlNid3CXYorw/0BHgFKk3Lmbk5ZCYNmSRVQdRFIyxT7zkSCkQAvdeUo/Z7ZNAU exsuzIjLNFZP5GVaUnt2HtQ4j0Kd55/s/GVaRw5CgSft2V9inTlCcw/TnWCFzs1jy2SH Dur+IbBZLcTr4C8QqLqV9cA1istHN8rnC4HAeVDumzcXjT29Czrd7ejxaO0V9sIbt4vL XurA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699874658; x=1700479458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8o2HXYJRUVQ1Lpbm7zM61UahrNOCCIAHF27L8iRvJeA=; b=HqZvg0UzzA5rME9XF5d03mTkA2TLgqqcn0nWleHV+GLuwfN+w71x2sAmxTkgpflR+v z8jT/KyjpW5dO4wO2Cf/uUjBJfqAXbEHa/dzlVP+EhuNmxsugqRx9FqLCwLnMzInBomv tKcjiJjbQuRPqHdjK8c5yxMEWGArP1v0eR9XO6HBjvR3caZHwgxOeakJlAi4WfgNuXYi CgwX1ckHmqVMIpAD6g2eyQL8FjjHq2rHrCeSVKyCrEC8x29sOEF+yBlXwn+YnuSWXogJ 33/ZZqd/yQ+Z72Njwj7nJuNj0s8IVxl0TogpsbdXI0K+0tOdmUY7OoDDwch1CGjGzWUD 3QoA== X-Gm-Message-State: AOJu0YwX88tB8BWvKvbG5T+OLZA9V/TC62wt6jh8ZVWtmzekQx0mVV0H Av+jQLxicYfZDtYjACBc9vw= X-Google-Smtp-Source: AGHT+IFM+nvF+UETcm6JP5xDJkQVdoRgP72tN5q6tLWm5ga4IahPJk8LYKIlkJQCwwcn7w1SgkhZHQ== X-Received: by 2002:ac2:5e87:0:b0:508:19be:fb2e with SMTP id b7-20020ac25e87000000b0050819befb2emr4055348lfq.58.1699874658428; Mon, 13 Nov 2023 03:24:18 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-6e16-fe00-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:6e16:fe00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c4f1300b0040772138bb7sm13565787wmq.2.2023.11.13.03.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 03:24:18 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Subject: [PATCH 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:43 +0100 Message-ID: <20231113112344.719-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> References: <20231113112344.719-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Alex Deucher --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev;