From patchwork Mon Nov 13 17:44:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 13454252 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E89E22EE2 for ; Mon, 13 Nov 2023 17:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tkos.co.il header.i=@tkos.co.il header.b="pwJTzAxe" X-Greylist: delayed 112 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 13 Nov 2023 09:44:48 PST Received: from mail.tkos.co.il (guitar.tkos.co.il [84.110.109.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F97B10EC for ; Mon, 13 Nov 2023 09:44:48 -0800 (PST) Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 20656440CD1; Mon, 13 Nov 2023 19:43:46 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1699897426; bh=1rfJ16FI/W6yq+b3hiKtTrCWZXLvLTjA0Qnt7vb/GHM=; h=From:To:Cc:Subject:Date:From; b=pwJTzAxe05o7kyaoBXa9reTmxverBwxARjDofMha4b0ONof7ATlbKEJwilLOukS4L yjlCqrCZySCtKdZc2cp7LWMUv7gw+ZQeQGoa0bDE3rYCJjP8nmJgURBB9RWiFaFVeN QbqkKMyomB4X/qwRsxBcHLBYmfXap7udoC8K6aAH3MJ3QbkwNB3T+EutGT8qSlJx63 0P3N5E0BjXnjNUDAXNmLGFZifBcSfRBEvGvRdVyonsOBoiXffG/xOz9CEm+gDUxrLe v8+CEpthMmKADftzu1A/wWPBRQJS/W3wb0VHWNA5MqyFJG+UmlJ9wUL0AdZoGvC7d7 85B27yVUFwgnA== From: Baruch Siach To: Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, Baruch Siach Subject: [PATCH net-next 1/2] net: stmmac: remove extra newline from descriptors display Date: Mon, 13 Nov 2023 19:44:42 +0200 Message-ID: <8e3121170d479cbe095f985e01fc5e0386f2afff.1699897483.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org One newline per line should be enough. Reduce the verbosity of descriptors dump. Signed-off-by: Baruch Siach --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3e50fd53a617..39336fe5e89d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6202,7 +6202,6 @@ static void sysfs_display_ring(void *head, int size, int extend_desc, le32_to_cpu(p->des2), le32_to_cpu(p->des3)); p++; } - seq_printf(seq, "\n"); } } From patchwork Mon Nov 13 17:44:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 13454251 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E86822EE0 for ; Mon, 13 Nov 2023 17:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tkos.co.il header.i=@tkos.co.il header.b="H/wQHR+1" Received: from mail.tkos.co.il (hours.tkos.co.il [84.110.109.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EE0210F4 for ; Mon, 13 Nov 2023 09:44:49 -0800 (PST) Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 6DFDA440DAA; Mon, 13 Nov 2023 19:43:46 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1699897426; bh=MW871yMW+SlH+sDGpXeIRnmhp7FvyDE/Bs/X6DKNx4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H/wQHR+1hDaQQLWslaOJmc7rhh4UQOEsvSBm6xncV4LkcJE0taaHd48dcIyyK8K6Y cljzk9Wak7yG1M94/DgBQ9uzl0a1MLoh65KunPBCAoE2zE7i5dmFLxdtGiZ6dAXDm7 4d+i1F/6GBY/RFG59UKGfWmusxmH77P+fJv4dC+wU9XTkkzaQWV9qZftga54bfGlgn EIjVtuQnJSeN8iEZ5t2HDELjuAanD4avHyxrg14fvJWHl70+xAjlV5H45TRwPm0j7M oNMtRKpCh1BVzej4Zv6aWoDLuacog7nPtV+4Crn3ezXrwhvn+Ls/hPHPoM6skxcYRi kAFeqnj8qcW9A== From: Baruch Siach To: Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, Baruch Siach Subject: [PATCH net-next 2/2] net: stmmac: reduce dma ring display code duplication Date: Mon, 13 Nov 2023 19:44:43 +0200 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: <8e3121170d479cbe095f985e01fc5e0386f2afff.1699897483.git.baruch@tkos.co.il> References: <8e3121170d479cbe095f985e01fc5e0386f2afff.1699897483.git.baruch@tkos.co.il> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org The code to show extended descriptor is identical to normal one. Consolidate the code to remove duplication. Signed-off-by: Baruch Siach --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 26 +++++++------------ 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 39336fe5e89d..f39e2bde325f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6184,24 +6184,16 @@ static void sysfs_display_ring(void *head, int size, int extend_desc, struct dma_desc *p = (struct dma_desc *)head; dma_addr_t dma_addr; + if (extend_desc) + p = &ep->basic; + for (i = 0; i < size; i++) { - if (extend_desc) { - dma_addr = dma_phy_addr + i * sizeof(*ep); - seq_printf(seq, "%d [%pad]: 0x%x 0x%x 0x%x 0x%x\n", - i, &dma_addr, - le32_to_cpu(ep->basic.des0), - le32_to_cpu(ep->basic.des1), - le32_to_cpu(ep->basic.des2), - le32_to_cpu(ep->basic.des3)); - ep++; - } else { - dma_addr = dma_phy_addr + i * sizeof(*p); - seq_printf(seq, "%d [%pad]: 0x%x 0x%x 0x%x 0x%x\n", - i, &dma_addr, - le32_to_cpu(p->des0), le32_to_cpu(p->des1), - le32_to_cpu(p->des2), le32_to_cpu(p->des3)); - p++; - } + dma_addr = dma_phy_addr + i * sizeof(*p); + seq_printf(seq, "%d [%pad]: 0x%x 0x%x 0x%x 0x%x\n", + i, &dma_addr, + le32_to_cpu(p->des0), le32_to_cpu(p->des1), + le32_to_cpu(p->des2), le32_to_cpu(p->des3)); + p++; } }