From patchwork Wed Feb 13 08:47:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: kernel test robot via dri-devel X-Patchwork-Id: 10811993 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 34A9F922 for ; Thu, 14 Feb 2019 08:22:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2521A2D8C5 for ; Thu, 14 Feb 2019 08:22:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 19BC82D8CB; Thu, 14 Feb 2019 08:22:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD09A2D8C5 for ; Thu, 14 Feb 2019 08:22:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C365A89D84; Thu, 14 Feb 2019 08:22:46 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id D46D56E0D7 for ; Wed, 13 Feb 2019 08:47:27 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id v16so1254029ljg.13 for ; Wed, 13 Feb 2019 00:47:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bQKwEsId6JLgTtjw3Rjr7HrL/WSfNzzQCt6QFtE+6CE=; b=DlgphlDrIFYW7QW+mfMMG+kkAHEcL+yoyTNaLGYzyBa218ufAVtRvr0SgYNo8BcmOK rBCOWFRg/MgBqrV9v0z5Rz94GzES2Ebqpk8OLDnqkvNC5ALCXwL3oNwywgRTq1+P2+Ec 5iVoWZ5iocDYeDc452AmgWTFNQVpCbrFr2rBuPLjv1QMc3Dh2bNEMlWIoJwzIbpAw0iI dvtWVf41QqwmHAy7OyVXtH1My4eHvjST8r3kaS71rujIbGDipFrJWp+aE2LpSmM8nA7f j1+EXF/ELO0X+a0NH25Ah7TcLE7qUWABqeVAUX2mKt2fESvsLLQ9FlbDANr+nQQLjuog U8UA== X-Gm-Message-State: AHQUAuYYyPngRFNnkWfeDm877gmGoy+vkBGDs7nDuX8g0RjW/H+JlhTr cBUHA3sFf1uDZ9ZSmIs86Y6JEA== X-Google-Smtp-Source: AHgI3IZws0QWK8imzOTRnZT9SCN+xIH6k+c+7yeJ5437xHEWz8ntkEZzVxRVx+i1Hhp2RtIhJyh02w== X-Received: by 2002:a2e:81c1:: with SMTP id s1mr202136ljg.29.1550047646117; Wed, 13 Feb 2019 00:47:26 -0800 (PST) Received: from localhost (c-573670d5.07-21-73746f28.bbcust.telenor.se. [213.112.54.87]) by smtp.gmail.com with ESMTPSA id g85-v6sm3325972lji.17.2019.02.13.00.47.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 00:47:25 -0800 (PST) To: b.zolnierkie@samsung.com Subject: [PATCH] fbdev: omap2: fix warnings in dss core Date: Wed, 13 Feb 2019 09:47:21 +0100 Message-Id: <20190213084721.29624-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 14 Feb 2019 08:22:46 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bQKwEsId6JLgTtjw3Rjr7HrL/WSfNzzQCt6QFtE+6CE=; b=huPTkm7YuTfgMiO3pS+jCGn8NhUCcSn8F3KQWlpn+sfAWdE03+0xZExbkXBqTQQ4Ms wSC5XGBYQ7n/wYVCJZxHRgNxIs0hdbjkEbiIaoincu8wJFzdVEshpaJd84a9VZnaoASY Wa6ExZJisdmciQHpsAk7/zKJeXa2gjhMLdH+QUhaJbDwDTUyBIj0opR/VRuerdRwNGyj N9X+1nLZ5zI6Zxcmf7tfsnG2iWQ7k4zFcRbQzQek1to6poNy/Pr3We/zzhbBAGbYO6Ro oA0YEz8XGmiBrSNZMRNtvdxS/XYybCvhCWzfnOj3l2QKu4NtZYQ5GbMXRXw8JVXFYSWv NaXw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Anders Roxell via dri-devel From: kernel test robot via dri-devel Reply-To: Anders Roxell Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, Anders Roxell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of debugfs_create functions") changed the declaration of the return value of function dss_debugfs_create_file() and the following two warnings appeared: drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘dss_debugfs_create_file’: drivers/video/fbdev/omap2/omapfb/dss/core.c:139:9: warning: ‘return’ with a value, in function returning void return 0; ^ drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘omap_dss_probe’: drivers/video/fbdev/omap2/omapfb/dss/core.c:172:6: warning: unused variable ‘r’ [-Wunused-variable] int r; ^ Rework so function dss_debugfs_create_file() that is declared to return void don't 'return 0' and remove the declaration of the unused variable 'r'. Signed-off-by: Anders Roxell --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index 7e6a3eb266d0..b5956a1a30d4 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) } void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - return 0; } #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { static int __init omap_dss_probe(struct platform_device *pdev) { - int r; - core.pdev = pdev; dss_features_init(omapdss_get_version());