From patchwork Sat Nov 18 17:42:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460206 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AD72C5ACB3 for ; Sat, 18 Nov 2023 17:42:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F05D510E177; Sat, 18 Nov 2023 17:42:37 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id C515910E332 for ; Sat, 18 Nov 2023 17:42:28 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-408382da7f0so5042755e9.0 for ; Sat, 18 Nov 2023 09:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329347; x=1700934147; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=kCzK5+Yi0WurqgQ8KVft9a20/Ea5nE//cDKjyodUFA3eW81mdeIS/bV+7kvGLfyMBC 7ZHCJ/K8IyS74L/ZqN+2WkszYkSHeXQ85u3FOLllcg9wkso6Fv8PcoRV843ZIOwwbq98 Q5lzTDKL8es8k3n7v+GPq9JYLKP8xTT1nq2/k4pie8CrtxvVEB3RG58uZvBtEdcTsOFv 3u06iN6Xu6Dr+Z2/xMDbBfJgDXRDR4P/IabpceTvfydfNQfqnGcb73ANSQhqgH2kKOf8 edHuSxM3QZ9e5SXVlN7W/d6b4O16n97JCKN5y9ksJvaxJtc5inkwa2pW5Pi6TF3YvI1B Wotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329347; x=1700934147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=YzJaVeB3O4d2r3dTSlFllFSXNaDNed4ND+u/pkxygAR8F9AVrmXV72Ue6HZf2Xj3tW EAw7l7CxQXQEwvvyPf6Z6vsPNNbagbtdWTC6+r25foWqAEQvU2IUX4uu9r2Dc1c7bRfF tfRk7u6rTll9guWKp2OTb+vd3Qegd5Wp0p/6lKNhMGXLwvHAG1KEvuVK5BolBOJh7cNk KLR1DqrDmAgJ39afB/Y4HR3eCsSjfYd7bkIEl+n6wxMk66Em9mPMXwDxldzwPFuqR/Xm 7E+ew0H1SCswzYHtb6fXwgmY3myOk9yehq5kTFVULvnpb7ubRPnUo49xw5230Q5DVC5F 9kkQ== X-Gm-Message-State: AOJu0YxVruTEHDxtnwD8WmbU6Vk7bS9bL2ZMdJsuDLLFJybGc4K/Vb+w DCz5quj3lVyiuvT41xXPTwc= X-Google-Smtp-Source: AGHT+IGchLGNn/UTh+TSPBum/ynhaPI5RIfSnYeSODGRmp9mYu+xtswabBOKG8QD70Eu929TNCd0ww== X-Received: by 2002:a05:600c:358d:b0:406:849f:f3cd with SMTP id p13-20020a05600c358d00b00406849ff3cdmr2461814wmq.29.1700329346812; Sat, 18 Nov 2023 09:42:26 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:26 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Subject: [PATCH v2 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:01 +0100 Message-ID: <20231118174221.851-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Sat Nov 18 17:42:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460204 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 252D2C5ACB3 for ; Sat, 18 Nov 2023 17:42:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F78210E33A; Sat, 18 Nov 2023 17:42:37 +0000 (UTC) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85DEE10E332 for ; Sat, 18 Nov 2023 17:42:29 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-408425c7c10so4783205e9.0 for ; Sat, 18 Nov 2023 09:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329348; x=1700934148; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=VQF7MMYJW/J/VHULzr+n0u0ZgYLAnIbHFwNHU8G4bw8LGp69m8PmVKsKN9nsgv6VWE 9b1eB5r4S6hwo/SE8r8DIKsKGDGb/IGh0iHTslqYEhWs66QopbAGDkDzTeclbR7OzUZD etbk5j4fXg2r6xpH5ipsNm+iUvbplVYkhYwdfagL0vTjedfRINkiKe3w/BjH0Ba2Ld7G 8sgzLWycJEwQiFkwebZnnTv+KAxyLWjCS3rlkJUzMu2EbzjEDNeJnT+OCIWCuA06Q8em qlnij2kQYhq6sbhFaHxPryOcMC+C8qbgFlynbUYfgim0la0oM8jgmrEe1Z8pKf6i7BlG BtUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329348; x=1700934148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=t+0yVqFNaoYx7Haej6Jds3ev2PudPs3WlUsggepcSIG7VzwF71Y7IkzPEEDjeaEEdX qT6oeOyFCcDB2aFT9ORjVENdj2If+fZtlQd0OX23WvnL4+7G4cRdTCtF1ik/uje4mL9K F+dJQL0yA/UNQpxjp5HDnkoE2D7C+xZMnkTekrWvtYOfcedthWL/oHFqt3xAAj5m0OLq yV2Z3eg44V+CxWJwQtrHs/SG5eI8epaKpTaq+Urt3GNSAeHNT5Em5Tu/mtKVkZauBpto OVmKdKXvAQwqU9mikDx/4ZUKMf+EDdtam7CDd/Jzoypj/1EfcfHF+uMCWjWjiZYvwzGP V6tQ== X-Gm-Message-State: AOJu0YyvPschr+iWIsSZ5ru1c+96Mgto8xj3l7wc6VaLm7aoGmC2x9v7 Q00MUtCBSAI4+sO2cnsWK88= X-Google-Smtp-Source: AGHT+IE+/T5akrgcd8jfoxC+27DJiLMD9yywl/rsoQi2NbXCmSA/211Cuyy0UCxwYrsOXe7kSYSepw== X-Received: by 2002:a05:600c:4f14:b0:406:f833:d853 with SMTP id l20-20020a05600c4f1400b00406f833d853mr1767049wmq.15.1700329347662; Sat, 18 Nov 2023 09:42:27 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:27 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v2 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:02 +0100 Message-ID: <20231118174221.851-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sat Nov 18 17:42:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 536EEC5AE5B for ; Sat, 18 Nov 2023 17:42:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67BAE10E338; Sat, 18 Nov 2023 17:42:37 +0000 (UTC) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4814510E336; Sat, 18 Nov 2023 17:42:31 +0000 (UTC) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c87acba73bso1396411fa.1; Sat, 18 Nov 2023 09:42:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329349; x=1700934149; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=NS+YbM7ysVb7lWQSSsU/b0b1kEbXeOdCjkLG8JC1xquBVzJZRnE2Uz6SIqbYeIss2E kcAQX6GginkvltkmDvaC7WBfmxtcnOJbBNG1V5h18hWeVvUvJv6i8HxlGyWssQcjcaS9 LBQEUWBmt0LTfLUG0PmpPJML4BQiikj4IHrF2JT1p0dzxfIWWHztK9AT3Hv9YkF9d37i n1hpLHIPcRhW14DruuzrmNn82ivzX7K5VE98JoTPkIgPw8sZKZETZsfJk37Y0jh+2FQq hMS6AfNQa6yfMBGRIBoZq8ueEE3V7ZhLnNgNdIEGuF2sEnn9alrBUVydcWSfEhALSZ+E XPMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329349; x=1700934149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=vCcmi1LwKAcarUYb7bo1OKsMd59L1tx5bqxj9xq9As+9ZQNCvPHk25YlzL/XZpJuLc 4IU1wJN6M+arPa1ZRRkFZIvNf559YTaJ9voD5FnAic5UNF6wI74+6naW7ZqSWs/k0tgV n6owD2LW/6zDVzWWycsKA2XJ8Zjb30ZM8SmlNr2tVB0asrXO591U04/VXmK3adIrDAfb Bdb4xba5sKrE9jZC1SFnii3S6p8BtDEjq8sN+er17MSqFpRjVRSr0NoTxzwckbzcjpwv 61kkyskH+SFy73aVaaLjLa4jfjbtPt2jbG5acsa5o32jI6lv589BLKK1GqSNzKV5QK6K QvwQ== X-Gm-Message-State: AOJu0YxMUyyhSd0NMEk3XsHoQfVW1krDK77XlWzkl6lJYJAQeYA/LfnB xhNrdHSXuH/iUzOaLgRpDH0= X-Google-Smtp-Source: AGHT+IHnFgNWvQQzwc0XOhpUWTcrcN2j6CYFonTN+gof5Zy5XsRr775SK97ByQAzYdXjmLv3xio01A== X-Received: by 2002:a2e:82cc:0:b0:2c8:3254:bde5 with SMTP id n12-20020a2e82cc000000b002c83254bde5mr1493466ljh.50.1700329348922; Sat, 18 Nov 2023 09:42:28 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:28 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Subject: [PATCH v2 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:03 +0100 Message-ID: <20231118174221.851-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , dri-devel@lists.freedesktop.org, "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Sat Nov 18 17:42:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460202 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B7B6C5AD4C for ; Sat, 18 Nov 2023 17:42:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCF4C88FAE; Sat, 18 Nov 2023 17:42:35 +0000 (UTC) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id 94C4010E177 for ; Sat, 18 Nov 2023 17:42:31 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40859dee28cso5420915e9.0 for ; Sat, 18 Nov 2023 09:42:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329350; x=1700934150; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2A7KgJeMP1lI74vlMRztf0ZeAIQKlR0j/L1YwdkkguA=; b=nXTyofjICM1m2IKAfL++M2bi4IvcRxRwfuOP/N9LCZvy+uF/IV7HG72UITCkTmKamf KncM0+0xUpa2QCXslPst/ogxD4/qdFeoSo/qE1OwUZdSVL/8CGB40qDVJEIUMRcwMV5t 6fCi88JEfJYiQzltApUlFUMT5NUVZfVX59mgLUCP2UWEg5H1oV0WV42jkBa6poB+2wII 36kiwCMcGklrmfc09RtGyt+9eX+iOmwEwD7N8uSQqu3wD2DU7XXRGTv9kHaN6/lIXtB1 8AMzQ+R1+U/c45/nrHef3v3ytPrmqrDeqpanhAyA/Y5ox0Ki+ynmDhUZ/Ms2T53rmgmK FgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329350; x=1700934150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2A7KgJeMP1lI74vlMRztf0ZeAIQKlR0j/L1YwdkkguA=; b=Qc3TNcLgWAzKkrz8tONlJE+3sUYVAW3ZMGCYhtr9Yz8cV1kmv9ZmrTscrtDH74CMsG NX/9Ny5Er0LHRe5xKMuQ07l7Vs+1ZcPpFAEiA+ffRyz8FdpZjdB2Z+kn3DJ4V0bAWMVe 5jbf8ZeV37TlKw1eKIRp58mdtftnMoXXtdcCDg9f3zXx0hVfaW5492OBzxYYPfu8EtXJ OZsMdwZavq1JEgjIBFz9XyCOnVP2N2ZBBkqv0ZoaBOlX92SvZS/Uzc4yqfjTDde2wBda VjC2T/qCw0XvQOxQ6bS1+hqN0/tbpviUrGqMShOAKUFV6cDiXMlq82J9TZiWZrxYcnQf OAvw== X-Gm-Message-State: AOJu0YwMEPn/FtP5mdPBPJ1Ww7TYqTOEA1nnqpQOGG6/Lxp+LhcT/iJi eGc1QQf7u+Qc0FYIjLPcezs= X-Google-Smtp-Source: AGHT+IFhcmh+HF8fxApZE0ppjzudwwON5aQtR0W323i40dvMUD5YGJYLj4L/jEO65VvDn1fpwc/WhA== X-Received: by 2002:a7b:cd97:0:b0:408:3b8d:f7e8 with SMTP id y23-20020a7bcd97000000b004083b8df7e8mr2221493wmj.33.1700329349862; Sat, 18 Nov 2023 09:42:29 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:29 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Subject: [PATCH v2 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:04 +0100 Message-ID: <20231118174221.851-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Chen-Yu Tsai , linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Sat Nov 18 17:42:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460205 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D09DEC2BB3F for ; Sat, 18 Nov 2023 17:42:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 80EE610E336; Sat, 18 Nov 2023 17:42:38 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8C4B10E177 for ; Sat, 18 Nov 2023 17:42:32 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4084b0223ccso4618305e9.2 for ; Sat, 18 Nov 2023 09:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329351; x=1700934151; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ibVEHgtEJ5eQu45MMiPygdDJxNCKoN0M/oBQUtm4Q4=; b=BBXDYBpadwB+RQyQEvopg7gIP2z76rL57n2oIZAKFTM/78lZGEUJJf9GvkO49phiOp /4sQ8dipE2LuCOl3c/RD1uRyN785EXYH/J5crYHMvBbQrxKyMzG5lJcz9w+E5XKKlOKW DnXHGvJJfscnOg1yiCrCeRaf67LNqAEmKYqVorvG+1PeoDpOGiVb4nklCLiXEoghbhvD ugbQ9c9B8OQjb05QCR663lviIrZ9P7mYE3a1dXS8YusnvxqxXaSk7I4X4Gs8tJ3t+wTF j8DCIRN0seFYelyLAhp0lMwEgJ1aOQKd0zttq/ELW54TG7fs3TJ4SY6dzlxkHRY9YLbn n8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329351; x=1700934151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ibVEHgtEJ5eQu45MMiPygdDJxNCKoN0M/oBQUtm4Q4=; b=O7nYwDroAZ1aTv/iCByUlS33A2jFzL9lB0CkLxsukaQh6G+Av8bMsUqo5X7L8Qi2vU pW8x1gYs2K3hPVTdGVpKnnfQFNel1Gmfb2DSA47dgE9Vc8+OX2W7CbG2T65skeqLRR5B ZKCFyri9jHKgNnoYDYhJv2i4rrECBi53lq2oZUtKGAyPZ/1DG3kn5WDBsdl93aQoJwEI y5O7/zOvtu5vTECq/kiK6mFGyeuRHcLxGlkRRFh2F1hWdtIAgg/zrKcDlT8gMd+0lar4 I1Tybu4SWfIWcrz1Exx+oGJU976g9jI3gspCuJCtzkRJ3Cuo7abifXExRMxVZa0vWTvh c/tg== X-Gm-Message-State: AOJu0YzEYGWmp660rsBqefxtPhtMZGZhi2lCF0bwJV8BAfnlpgTrQAn9 XbdIfFfANf7d0DmJRLU2hk8= X-Google-Smtp-Source: AGHT+IEQSzp6MnzL/fUmwzKrW5jX/twilEpFfjkl7pHWIY4U5ArUWiAEvlzUu/AsvV7T/l2f2LM3IQ== X-Received: by 2002:a05:600c:4e92:b0:401:38dc:8916 with SMTP id f18-20020a05600c4e9200b0040138dc8916mr2681496wmq.10.1700329350876; Sat, 18 Nov 2023 09:42:30 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:30 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Subject: [PATCH v2 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:05 +0100 Message-ID: <20231118174221.851-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++-------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..fa07e1e5c 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,20 +158,18 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Sat Nov 18 17:42:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460211 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 430FBC5AD4C for ; Sat, 18 Nov 2023 17:43:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0857510E33E; Sat, 18 Nov 2023 17:42:42 +0000 (UTC) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B0C988A27 for ; Sat, 18 Nov 2023 17:42:33 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40a4848c6e1so3849635e9.1 for ; Sat, 18 Nov 2023 09:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329352; x=1700934152; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=huLXFv48A7Sa6nYsEitWmkgRbjv3iP/K7DOkmhklt28mNxi6AtKOt+IOWWLADHIIbb Noy6lG58q2I0NVT7bFtOQDbKAZr1mCJuFMQaCC8e3jHKlEHswcb8qsy5dqZSuRFr5eTn zDLRWzioKvCnxwLPZIrLv+t+fen6JdfHlnYaR+CaI1ThDgIFxQbI2XiPVTEvzXRwzZcv hy5bIQVQySJf0QfIFjlqOqOiR7dru59rkds7Bnu0y0J9ZQYWqlWsYUenWzxxppZYSUbw NRx3quAQwsW+79Aci2Bzvz6lsozgwKW8DXGU8USX6kM3DjWzZS7SUsS8Z8XU11cWfMad W9wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329352; x=1700934152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=kSwZ9Qn35c6qQQzuX4n3Ktw35KRPvSpYGY/3fCqmDgaovPjiXvWuPbcpGZvYDeypDG DB5frVbN2r3TbtZ6TQCk3UF5E3OWqZcrn4VwtFTPro4SJDLZIZz9iU9yofqOQp5HX5Ya oAkPGuJOlZBFYytR81vfFLV2sAumPUIxi0UX/M8L6VoY0gsWOYL8UAIQC6HALofSpSMo 5BXCgZ5KgWHx2qPrnUsnC+XzMjFTKTiegVX/KXCYYOaBmOzEBGeKca50o8gjLTexzGt2 Dv4o1LwRMSpdq6r2HvE0qWycQNKhNePN771Pu/ajjDF2gvxIjc/63dCy8hv45DxFIkIH a1Mg== X-Gm-Message-State: AOJu0Yzte34w1E2SOwk/TE4C97ajSJI2rxrSNkkOkVlDtNwG/DBGzb1+ iSEYkr3On32HUHL2ppeGsHpiVA4vwHE= X-Google-Smtp-Source: AGHT+IF2uuCnONQDkgVMYOEey1RFRUe8GnD9gILj5PaZk9ukHNBactX5XsSTUMsKSBKRWlQHaR36FQ== X-Received: by 2002:a05:600c:35c7:b0:3ff:233f:2cfb with SMTP id r7-20020a05600c35c700b003ff233f2cfbmr2013183wmq.23.1700329351574; Sat, 18 Nov 2023 09:42:31 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Subject: [PATCH v2 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:06 +0100 Message-ID: <20231118174221.851-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Sat Nov 18 17:42:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460208 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E627C5AE5B for ; Sat, 18 Nov 2023 17:42:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D41510E33D; Sat, 18 Nov 2023 17:42:40 +0000 (UTC) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6247488FAE; Sat, 18 Nov 2023 17:42:34 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4083dbc43cfso3834945e9.3; Sat, 18 Nov 2023 09:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329353; x=1700934153; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=V0IIEnVAJbk3l6lMor0Vc4V9j+6CNX+m4pEo00OPku4pcIStI4x2NZUnXTC7I0rxUO hRXCTwAKSchE3e93JA0lbmRLLqaaoMnArrk9IyZ2l5oJLnC2OIInYv7OvPeQv8I4ck5V Lw0s79YErPaFasrr3li9AzaXTqPhpDvtlYb+xi2ezMJiyS2WeLyheCEMf/dHluMlSe3K LXfKYfl4Dk55b1WdKvvedpKYTkDWc/fTc9LzJpWxKJJ1kiIDQr7sGJaTvSdAez5JkFX1 j1S6oj5YdT4QoPcTRx1OeDCwQRU4vrfTlBYTgcDmZGcXVmWJnf0viFkCJh91UlyOL5hE K12A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329353; x=1700934153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=JTMfoKPV2OB+e2Ow/UGu7r4SGuewwm8GQFFyArxIy86klImrW3FLvfNOWLqimqoY0Q tBHbkP/iM/NTShLT2YhARmop8WzyLB5Qon2aFSV54VZpDdAdnPFIGb8+j1uinY25apZb asxrGWX75w9WqqiFOPn4Z0XdWXXRBIUPuMNUFhZNOQrMUcphmZjCu8xNEPqe5a53nnQN WPCAxg9r2dydGHLUc4EETbC0mywxOJY5j3mHAfiqI5rnFy6mjz4Jnc+tYqNvP6lWgPhv kSJCVVlG+gv0XzYfPkkMLBfFGEW9UPSSaZ7mk0t55XZVhP7SNmWQ/kf6Z5AlTtZ6PTrB QETg== X-Gm-Message-State: AOJu0Yz15KofnDDb6LFkQQDql0OpgBthExnaJbrilgob60XJQMHhYpqP lUddX3QlyP5da0iGxj8cE7s= X-Google-Smtp-Source: AGHT+IH+vVNTNRuNzx5HCBAwdawDR0oj+mid80kQSKCziiwvte/UEe7naf5BwwoyEL1Bwr25F9JxEg== X-Received: by 2002:a05:600c:1f94:b0:408:4160:1528 with SMTP id je20-20020a05600c1f9400b0040841601528mr2146365wmb.30.1700329352609; Sat, 18 Nov 2023 09:42:32 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:32 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Subject: [PATCH v2 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:07 +0100 Message-ID: <20231118174221.851-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sat Nov 18 17:42:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460207 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F2FC2BB3F for ; Sat, 18 Nov 2023 17:42:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66FFE10E33C; Sat, 18 Nov 2023 17:42:38 +0000 (UTC) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71502891D7 for ; Sat, 18 Nov 2023 17:42:35 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4083cd3917eso4655335e9.3 for ; Sat, 18 Nov 2023 09:42:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329354; x=1700934154; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=cOoCLqZ+jV6FySxU2yYDOm9nAyytoMZoJaGO4MzJ9WU+1TqyjkjsUxRoQI5HdmYU+v 0qIK3C0/B7K1ATWHqs2PvvHr6DGgbLeA9EOiSTLwDK2EGb2MwOc3nZle9BJlUBsV4BVA hc9d/d7FbkvGNVJGput1MlZPCU6up+DBxW18ka1KYC9YkmFGhUefhqseJk0PzfHQbDwn R61JBgyLUVHqQJm89zo9wOVQ7WYDoMxliBd1FeSwvOB+FHEwgeQH4VABnxTuefcPxsIr spghp1h1zqT1T5IOKvEt6xk1WnX5cE0bRdjzsjclOlM0utEMiO7i9ccQgemNQY3hC32a QReQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329354; x=1700934154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=U0lASHkCZczkto6P7SKzZ/MtKYVqrC2/jo43uD4l6PntL2XKB+uXtASGZayUjwNI93 y1WvPqqxGaKreBRFJ24nWSeVMgiolsWJcIy2m1LC+8jPIEyCM0P8lpU6EQr98kbC1cUX FgxEe2QFkZ0JQ47lxZuV7Iu6x2qglSO4RRzFWK6p30Ms7CfuTrx1ktIvIo0WTyU+ad9Q V0aGRiqxd8JWa/xOYNB4TIL1c9JSDZw1zjCni+RcSoLBDuwiz5vS2UyYdthCKVt9MNtf 0LcrDpz1ADdLlcyoX1EWPUy68pneL4T4s2BZdMyXnXDXn4irpGTrZ9rh4m+GgVxT9D4w zjhQ== X-Gm-Message-State: AOJu0YyxQw93UIByVMrKcC0fGElzPyocE6kBHH7NCTKOSSXS7lbz6J8C fjtaZjlXhWR6lmBRTrimoNE= X-Google-Smtp-Source: AGHT+IHFeQem3GC7lyXfhuux3W0nXFchU62Mp5yU1I3tjQqqacuqysAcTGeFS+2WghbyMr4dvj9rxw== X-Received: by 2002:a05:600c:4712:b0:405:348e:aa43 with SMTP id v18-20020a05600c471200b00405348eaa43mr2139830wmo.12.1700329353750; Sat, 18 Nov 2023 09:42:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:33 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Subject: [PATCH v2 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:08 +0100 Message-ID: <20231118174221.851-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Sat Nov 18 17:42:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A221C5AD4C for ; Sat, 18 Nov 2023 17:43:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DDBF10E342; Sat, 18 Nov 2023 17:42:41 +0000 (UTC) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86F3210E177 for ; Sat, 18 Nov 2023 17:42:36 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4079ed65582so3881975e9.1 for ; Sat, 18 Nov 2023 09:42:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329355; x=1700934155; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=E9PJiZG6FtYZkLaLgQA60qRmiIivuNtg2rIZT1s0Pt2yL9rQkpeJiLm9lsfrrwxv+u 7XhX1MBGdDbFXTXOHAOl1PVLpAk/yPFdwpF69dDKGkPuiVtFzhIrIEv4JtPKr6y+rA8G MY2dbpO5GrFpEIBm21U7nlSeSFtbX2FTyV1irXAeuVQJHHPgBNe1S46NMr/DM7BtnQhQ Uzhdzh9jjp4FKOOjwmyB4Ame6UBLquOZv6hUdOHYEW9rfEi1MTjSqNGxiE7mSqEhVWme +ZwPhMUxQhozHC2bNUrAYIo0V5m7rbcqCGN/4dSNQE0rmH4XjjVgF6mfwZev0D+Q36vy tbGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329355; x=1700934155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=IpKJDWZCNGf0e1UPFfTRZpCtJ6qKIcgS2TpyCSL/L0BhNbf1isuGThzUFzciB4xdix /pRFe/+2y7GqdlVbvePsdTVovfjmCR4j/v4JCOTAGM13sidtS392HYPJ44ugq1L4bT4E hjc2gxOi1C5X1JsS3XQ+EPyM5MoFxuutL4YPqorKd75U7ZL+4FbqfKVQaFKTW/WjJspA kcUzvo4ktETnyJXugxJF3D6G6jfS0NX5CXyxYOriRVvBMXGHog9LonCNG5OlTwoLYiCM 5vHQR2e5RoH2e1/cr73/iAG0cGQsHDmvVn5FICBfzmhEfbZuuJCL9g5kl5SXsJ1qY0cH Mu6g== X-Gm-Message-State: AOJu0YxQN38TtWb6XYieahoC0mQrIOko5pNTEWcqr+RWZB/elLDm7Fby U5ErOUI2CCpMHqzRV1Jl5Bs= X-Google-Smtp-Source: AGHT+IFq5BOx+Vn0YrjLip0ldY3nSGhqRKbTkmX9+Fy3Wz36IeGI2djpG63W1qV3nbXzFeP/oHp0mA== X-Received: by 2002:a05:600c:154c:b0:405:75f0:fd31 with SMTP id f12-20020a05600c154c00b0040575f0fd31mr2291085wmg.31.1700329354751; Sat, 18 Nov 2023 09:42:34 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:34 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Subject: [PATCH v2 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:09 +0100 Message-ID: <20231118174221.851-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Sat Nov 18 17:42:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460210 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5D9DC5ACB3 for ; Sat, 18 Nov 2023 17:43:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F13B610E344; Sat, 18 Nov 2023 17:42:42 +0000 (UTC) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7275910E339 for ; Sat, 18 Nov 2023 17:42:37 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4084e49a5e5so5442715e9.3 for ; Sat, 18 Nov 2023 09:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329356; x=1700934156; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=Q+p9wbbDp5F9M7Pg8Q56D7ARaJXqCqm9suR1CkZgkFIx0Dc9MHy0wOth6Pbwaf73jj oEItFyOz1T4fjOwXYrrtd//yDfpidLdtso+SCvDWqyc7vWlkSAIvPRfXMiUQ9mVKKPNi vjhx498xpLO44c0Twtpp1x1Qakt31aOcz4YqR3B484WGGuAAjIAR4+sL6qhoJwezYreh 1vAnIn4492r33yFzSiVIjoPSOKEOiTgnad3rSy90cHNzofGmk4KsgYY/ZYuIQcDWbJk+ p1S3sEcfMV+ncizLf3K59IJ7r56BHvYw5/6XciZ66gprifzqCNZZGdbs+ItYNMc9utww WXhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329356; x=1700934156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=TyBroiJUF4p6Cf+EUEQzGY9DEe2ojH93E7i12hwkJaw4d1DXKHAlsExAPGcXpzcUKK x9DwI+evmXe5zJ7ntGU2YzDshXH51tlhasis6fb3fy4dSTi3GMX4NkYSZ8W5/2EQK20H LDgJaAaW7eOjuTiqXi/N8R0HuXJoHUlzLIb+gvZE/LrdtypkqH1ewbgvDtO5waxlBo8H 8ncr3kqTZTStO8pFa+UbBGzo9ccCLNmZ2sm2KUpyj3oA8K7Ic77JFiPcB2m6I2Jm3leg LR+I6PE8dvBbjEihFBmMHGbN60Qg4rH3u299ihoiTvwZTP14Lk6dyotrjDPCdOeol7Vi pmTw== X-Gm-Message-State: AOJu0Yy5rCXxCZtYqf2B/0CMVBiXaqlhK4anI1Y7TVsAxsoj31VHgxwK a6AhiKxgXwvQSwFsG3zXqR1Llj3mjUU= X-Google-Smtp-Source: AGHT+IH/UONni9JBi2RCMivHlBv+H1UGwnLkk3yuImh+ir7/RnEejhHlDGLGWXdlNBwBR0HTwihAzg== X-Received: by 2002:a05:600c:4ec6:b0:409:3f53:c9c7 with SMTP id g6-20020a05600c4ec600b004093f53c9c7mr2232492wmq.35.1700329355808; Sat, 18 Nov 2023 09:42:35 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:35 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Subject: [PATCH v2 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:10 +0100 Message-ID: <20231118174221.851-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Sat Nov 18 17:42:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460212 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC117C5AE5B for ; Sat, 18 Nov 2023 17:43:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9B3410E343; Sat, 18 Nov 2023 17:42:43 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1F2610E33E for ; Sat, 18 Nov 2023 17:42:38 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40a46ea95f0so5327375e9.2 for ; Sat, 18 Nov 2023 09:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329357; x=1700934157; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=lnqm68TY7T35IHn+waJLriotQRev9L4RPCnOBo9r2BKNf5AyTTJ7+m1R57URResLJ+ OPOlLjBsnBi27obBM7MtDoONEkLL1Ftv0q3NwvuwCLpa7+wC+a/NCr2lAac+LWNe/RBS 75TVaQKHvHMA8N9yFtCPZ5G0m653SyVizRhFcsBr2E+sjxSVeWCmQoeCT8k/lV0ei9Mp QHA4f6r3EGqYaZovTMgIMp0k9tsFHN7mjYYOVFbP67gfkHLBCnfN41U7k+wV+y3caRfS j7MpXl3hmJyIJMf4EvQZ51Y1gy7Vi2+vOji6nmdEjgD/zM+hJMGsgc1QwCteg81+tiFs 9o0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329357; x=1700934157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=pi7nVwRi0EzB59fwNteWv7fn3vlL5aHTIuYXGK027Bo9SrMbGRu6eIJTqoc4Vth1Qy Pm+aKh7I0R/ar54+J5SXGF4f7kERaRvQ8n2vl6eZ0Gj+RaxMcaYw5NzJTSJv4a9Kpjps c743yVoPWAaCbo/nhgZxG6/Noufe00CbGwiGuaj7vSrTPRkf4wYNBOdKAHWlmugeh+zy Pn4xJYPeLjR7l/9LjFgaeMsvusI4JGR28xkfXHpb7M/HHBXBpI5TdAWxCoUsnaUPWGxZ fe/Xv7LGDArrrtQUVPJfii3pzQMhAfpueHqp2LctfPKEW1LIl7jRmPucKtdObwQQdWiC HJOw== X-Gm-Message-State: AOJu0YwQ0v+AmiLot+iKiCTpJfxGuORlNgXJ4239qjHlBFXO5+M0LFid 2rWqaoOo+hKVxUtYKQSRCDQ= X-Google-Smtp-Source: AGHT+IEYtipVOmHkmNUNcpfhd7yRWRn/fCm6xuayGvnoz64EspqjxwBcgwutFlkQhj/M1VwINT6WNw== X-Received: by 2002:a05:600c:470a:b0:405:4a78:a892 with SMTP id v10-20020a05600c470a00b004054a78a892mr1927675wmo.9.1700329356850; Sat, 18 Nov 2023 09:42:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:36 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Subject: [PATCH v2 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:11 +0100 Message-ID: <20231118174221.851-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Neil Armstrong , Robert Foss , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Sat Nov 18 17:42:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460218 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D89E6C5ACB3 for ; Sat, 18 Nov 2023 17:43:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2EC110E33F; Sat, 18 Nov 2023 17:43:51 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id C55A810E343 for ; Sat, 18 Nov 2023 17:42:39 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40853c639abso4729095e9.0 for ; Sat, 18 Nov 2023 09:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329358; x=1700934158; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=hmw8Nr7juuEcku7jIAbcK1czf4dMRmbbIK0W0jheGusR54NMKqSfRxbK8Do1yb+vFd IKfGLsSv+ZTTpeK0uHvESMynYJRmbmGt/5MnxXo98H6PpTPO2c4/UhbqZDpCLvUnjHTi GpjGmYZO8JazHjUi8ET/7I0BBv4GRvDMpTyPK0NPto3nIFxPNTAJfKmCLvQQGmNFzOaf pOCKJ3s/4bhB0cIcF55GFUU8APxNA6dTKqVmFP618+OWvT3g++eYOBXgVLxHWT1ldzFE IoB79R96Vtn5KIpF6rvvssqrjg/E80GvfXKm5RP/QbliVOg4dYe9O8e3ioCexPaKLgfw Blbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329358; x=1700934158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=Ikzmlt+QanhEsQ9WYWADLQk3haWk/ePDSR9V3DpZgyMb+AZZmBiv6MxM3EqUA3MWza XzbM4Q4T9VeMlQxj9qlztF0XRwGftb8JLE2efAPM2chlTkEJb0i45+52oxyJoQY6uzML bgHSs016Paj5F29Qw/emVTEALNldu/BnF/EsNtpI7HPJTxDzBh9Vf86zdKhMaSkjn+6Z zD0VY2BvcHbBGr/B96MhvXJJwQxLlEcljWugYmgpBsEQspApiUofDNkltq38GE2EfvnV 5/2l5NxkVjj10dSFULe1VNT8Av/9T5CFODRYjnHCjEvU6Iqa0n6kC2GszB+qgSN2IV1m U4cA== X-Gm-Message-State: AOJu0YzdlxiWc1MygESD1H6qhL2thcmqc09uRfqZdshamltgJ2mNtXlI XCLuJpCHJkoZwK7/TeRMKpM= X-Google-Smtp-Source: AGHT+IE8c5V85RdvcwMzWAbBlQPGXZHeMjHZ0eSrzhGIJjdv16HbHYiNDOuMRSlBwb03Yc7GkrviVQ== X-Received: by 2002:a05:600c:22da:b0:409:136:469f with SMTP id 26-20020a05600c22da00b004090136469fmr2103392wmg.38.1700329357997; Sat, 18 Nov 2023 09:42:37 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Subject: [PATCH v2 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:12 +0100 Message-ID: <20231118174221.851-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Sat Nov 18 17:42:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6353CC5AD4C for ; Sat, 18 Nov 2023 17:43:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14BDB10E335; Sat, 18 Nov 2023 17:43:32 +0000 (UTC) Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id D89A410E341 for ; Sat, 18 Nov 2023 17:42:40 +0000 (UTC) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2c5071165d5so38340921fa.0 for ; Sat, 18 Nov 2023 09:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329359; x=1700934159; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=QpBKM4ET/0h0gCJS8q+/+V1e2HT4B/dknGsCs5WiUrnMBAMJ7V+cA7lEG29BNVi1in naNYSbPR0XJnTMTRuXRiXnEGE2cjQ/4UhXw/EStPiBiNC5Z4ilWo8rlH2nOOkZoIH2KJ kXFtC0tVNGGQxbCd8Zv6HVnFrUw5Fne9QV/9dm6oPYFcgtE2FAGd+qye/608BQnJ4mO5 wqxnyZ2CTNnQtCkaf4m4CYaKoA8CVPkZLvfdcd2LtbKYflcIqflcJozOFccM0W+GBIuV kqBj+2EENvDMIgVOfKL7EB+9v/G6KV8qSrlsJfKufwQgpAbbk8pDREZtoonanx16QvQW GJzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329359; x=1700934159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=RVE9rSrXY3PZP7DgKtS6G+Roj2unefWIhitUbJDAMuuJAk79kiDEz1O0m6fP59WxwZ FJhXXRQelhpRDKzvc32d1nPUaYl39hn3aL7mNnNeRQw+vItZ7YoxDqf/mtBY12wVFlm8 enkKFBXj0T3AcsfFnch9CJYjMYblO3xxEzadIERRqT6xt096za/Mg+tdhXLUch45LclU b8N6xwOo1wZozM+86SQdfJnlJ8cs2STL3k386axec/drVt+ftxsXolcOJqWKq3J7Ifhp 7qqzDtvuJbDrmureip7WX2FLAAd2CZp4PQamUBT2dbRT89Z+ANrGICf7jxzDrt09B3en kzHg== X-Gm-Message-State: AOJu0Yz45rh+MOU9yB8dpF0/5rHEZNCU01lJK9omyfD1Lis4XJRGSSgr 2SNMwOCyxaS5pnhjrbnGiyk= X-Google-Smtp-Source: AGHT+IEwInUOdyb9JTIvDlzQjDOqKv7guvhmJ93ahOLgFcvY/4Q4hp0zaJwgva0TXnWM4RKYhWoN3Q== X-Received: by 2002:a2e:80c7:0:b0:2c6:f0a0:8bf3 with SMTP id r7-20020a2e80c7000000b002c6f0a08bf3mr2023765ljg.11.1700329358992; Sat, 18 Nov 2023 09:42:38 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:38 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Subject: [PATCH v2 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:13 +0100 Message-ID: <20231118174221.851-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Sat Nov 18 17:42:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460213 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84DC1C5ACB3 for ; Sat, 18 Nov 2023 17:43:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B72BA10E334; Sat, 18 Nov 2023 17:43:31 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90C7B10E343; Sat, 18 Nov 2023 17:42:41 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40859c466efso4638455e9.3; Sat, 18 Nov 2023 09:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329360; x=1700934160; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=Dj5mNAgVCiN7+tr1JHvw6X5kvAjMRF7A5Wvq6JobJSCmb41i513vjP1H0wUoJwOiFN k38/D2bpYemph/A7rAuIUr5JMmlvinGy3156HDVM2kYcFAlKuom+CgoMhU1krRsFwKk1 BJMpBoMqLn+S8Z++48vFQOVl3KTWsGvlS0ntz3339YAPURr0XhxhRzPSvBih4gGFEcPP WM6udrLoeVaMBXfDKI7aB4g+XPG/1Q06XvnZheeyyIJgELOQViG1tlTJ5Fy8+VObN7o9 jlqu+hh3o3I0jPUxRxBgxhU/s4laFlRjRqbrREnS8DmIiscDl/1+8RX4j56AolYE3+r7 CBLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329360; x=1700934160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=Rr9srXeEMULUst1RMDnn9tEzsN7Lk8YQmaaVT2HrIdPdSQDkHmegVg4ys/8/fkXiiY YFNVBZCVvJAjM1lQ5aTQZ9HRXmU+2lcTJUONtMlHqWMzpmjNK9FGUHxAeRgJ+PWuEN2e Qrl627EjBiS8KM3L+J37I3sA9VhwOOzgfvsp92CGsKuR4GEy87F72f3P10nlIGaKcwEA cDbSOfasK979A1Iva2qaSQYsVrX8yy92OECs6jtpz5QL4PJ4VhcFQ4+DNxmkCVbgeoA9 gBslWSlmbeVuSM2fiVCKKA9wo/XzfnTi7tsSquff2JnDBvc/7V1E5G/MqXA10HTs3vLL ywvA== X-Gm-Message-State: AOJu0Yy0i7RCcmCHeq9qLvKb399JsGBdZIcoK1Fz6OODk3kkR7QHFiIG nvCA/5z4mEAjf1cM9mgTuIU= X-Google-Smtp-Source: AGHT+IEDEAp2JxX1TrsPD+58kjm/UMuphpwbs1HtNIKAuhJlTjYYuA4bjSnwRduobt/RGzGOZOWLeQ== X-Received: by 2002:a05:600c:4f01:b0:40a:5b3c:403 with SMTP id l1-20020a05600c4f0100b0040a5b3c0403mr2242232wmq.14.1700329359934; Sat, 18 Nov 2023 09:42:39 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:39 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Subject: [PATCH v2 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:14 +0100 Message-ID: <20231118174221.851-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , Sean Paul , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Sat Nov 18 17:42:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460217 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6469EC2BB3F for ; Sat, 18 Nov 2023 17:43:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2890C10E349; Sat, 18 Nov 2023 17:43:50 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C2DD10E343; Sat, 18 Nov 2023 17:42:42 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4079ed65471so5026955e9.1; Sat, 18 Nov 2023 09:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329361; x=1700934161; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=Dirh13s/Cu5eOmg4N83HyvozfVdybFAm3SXUMuWDNF7SuwNsSvb9kKt4dpVZQpQ832 ymLCURjToNzdKZfdj9U9HYoBNoe2BDLalDACSR8xUp9PlKE5c54okflhchv+BH4sm76Z GkvopiSCe+pT+Y9hqdmJvYCKaVPeu+Th/0qPMu/XKPmLNb6qaFaClT7leLctX+WawQmq VNF9koxNQbnltfVGGaBBKZ9Ovvk1jtzQFSnx4UX0urmR7heWQ4r6YEHmdqixxMi2FvhS r8TFV6RfG1j4w+07C2EqVV8jBfSxNCxgT+VulIGEyvzXjJlxN865GCgi4xtOIyrbTK6w dc9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329361; x=1700934161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=UcDjQDu6/4yPs0AdK2Wn0NMj6eyrQfWV7IIaqMHbJUNfe2eRRsnDpbhzxOu3dRiDz9 tELn+3NJLPueOwld4FKWh8NlWVa63xdPogFh5TrgOni3sl5jSV5SOS/kHK4lTFzu8+me h2hBiqAp7/8R8J4bqE4QEljTR2aPGmAb+QBntpUwDgLG7Wx2PN218AXSt6jgs78jHyJx dRs5quyHv/uuSKwO2AsTXBQBufv7bs66fNRSp2chNg7Nn/NSdKuPfLHBau69dBA26bcM Je+IZytrFoN+WZZPAWB2k57hFqKF6t4tjpGxu7yFXjRrcAkHOAxBjU19Kc2anpF1+cmK 4nTQ== X-Gm-Message-State: AOJu0Yy4l9roclBFWotANZF26QB4iB53ZQnQ49Yog11pRfosfkJso5Wo B87QHYLJu1MQrnPRT9/lTi8= X-Google-Smtp-Source: AGHT+IEkxDeGvExBagSpF2r2LyZYIYynbcTphCNzYg+c+I50dSmhTAOksLkHYQ3bRD9pqUIHOvui6Q== X-Received: by 2002:a05:600c:35d6:b0:405:95ae:4a94 with SMTP id r22-20020a05600c35d600b0040595ae4a94mr2254158wmq.5.1700329360770; Sat, 18 Nov 2023 09:42:40 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:40 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Subject: [PATCH v2 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:15 +0100 Message-ID: <20231118174221.851-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Rodrigo Vivi , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Sat Nov 18 17:42:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460214 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70E21C2BB3F for ; Sat, 18 Nov 2023 17:43:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A67910E339; Sat, 18 Nov 2023 17:43:32 +0000 (UTC) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9207610E343 for ; Sat, 18 Nov 2023 17:42:43 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4084e49a5e5so5443215e9.3 for ; Sat, 18 Nov 2023 09:42:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329362; x=1700934162; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=HIWsSFySi7xqF7lIO+9z/e1SQ4AkV2TSun3VrUMM5Aq9KY17vWVgLk749Eh1mLernJ hQVYKlmhCYpsDKbnPRXatCyPkoADLBDq0Lj/8nvDKgyOC/nTGRmZA5pj3hcwgRnviD11 2tXr+EsxJZxzqgEMStPqY4ZrVeBJwyuLTOu1gieinmpNoFv7zbQcP1DhCiczWug52KZt W5a5SbJDQhDbEkRhquiNe3n4CAN/R1JBWH2K7KJHvnRcnGlCcaMJZNtVOhPi0Kz/h7W9 HJ5ow/iIntS7zRoeJSU51o9xRjoxYhkoo+UycCAuIcRevX1LR240GuZHDc8XNCaNYiCE D3CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329362; x=1700934162; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=hJQsRYqjsHXku3JkSmL+JmJagoXdJzVnWMV4qi+sC8cPaVSdAxdYfP0ORliPYqDNcI cSTIfoeylBNBm6wfuGCFO1Zrg+YZU+Vm2464vMar9COMvvEEEIWR4kR/4ZSvuUPp3v1+ BKfLckTtxDXJdj1bKvz+z1bf/TCk7UbmcenOYXjma4N+N5DaMB2x9YlD9ahcjCk7VEKW fvpYYOCWlkr27ZCxaU2EQQ0to1/+CFoF1/5h6LyDy0iIiOpqLHX9B3Mq72U/nDF7KZvo jXnGZ+pRI/wVItflChw96bpkOqPbozrcsi2rAGrBhSQUCh2qrPxbzrVcCqykK/6pZSVp sang== X-Gm-Message-State: AOJu0YynB5fcB8D8wgeaJ+XZ/yq/Bv3NMPzrIneB4COg5+GEheTbTndh 6JwP95p3kdO8uq7MjkQwmes= X-Google-Smtp-Source: AGHT+IGt7l6o5PwKsvFViCwmf1r0WoQMwWrQxBmVxuyxOMjlfRS4f3YKQ2XLunb2gXYw1covaoaGKg== X-Received: by 2002:a05:600c:468f:b0:40a:4429:a994 with SMTP id p15-20020a05600c468f00b0040a4429a994mr2234920wmo.28.1700329361729; Sat, 18 Nov 2023 09:42:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:41 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Subject: [PATCH v2 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:16 +0100 Message-ID: <20231118174221.851-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , John Stultz , Xinwei Kong , Yongqin Liu , linux-i2c@vger.kernel.org, Thomas Zimmermann , Tian Tao , Sumit Semwal , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Sat Nov 18 17:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460216 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A297DC5ACB3 for ; Sat, 18 Nov 2023 17:43:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A0C8110E34B; Sat, 18 Nov 2023 17:43:49 +0000 (UTC) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9660310E346 for ; Sat, 18 Nov 2023 17:42:44 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40859c466efso4638705e9.3 for ; Sat, 18 Nov 2023 09:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329363; x=1700934163; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=YNpPVHqrIXRzcOcM5270jqR5KSjwBjhpHBaTmdHtgGVox5z/RK9wsUrAn3+MWCxljP xUF6P23VNSlKDICOkfffnK5p38oZZcZMBwmiPZnDM8ea8UvMO5l3rN3FZYzKonsF/bWt h5MBCtzBScOfK5b2agRpacAbVOoMDBFDe5dqrWtbzbAofxLj6f1SDBskGoiuf0hdiC/E fICBlwO3Yt6Um/DoMX/8HukM7M1pnK3wnxR7LvVLPmuEkA3nQUqqdAm6/WBJ+ULySbJI Fg9bNKrkgSsHjrTb1FaoBgsc7J240RjbE3OnFvsrA+7h7ttBkgubJ3QwI8X5fToEMSTy h0yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329363; x=1700934163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=tM241u+r9duQbMg82+YVkv42xqnS093E9DpPeLbygeGRNQUMK58zQ9b0CU4VB0aGPQ J9Hsp6/4e1KObPgKyk9FrnqXg0mNdlJ+YQNPNZnYP4jIz7hccYvdw/+3kwI9dBUoqQ4d CpGwqFVL9KaDZ2sOKn8rehhy7MjHmhmdpEMTCyckxpALdP4CKRq991SeFUtvqADq50Ab 8FHYrbyjxGY9iefW7dcCdh7NMUwO4uHA//jiWVms9/l2oYw/ECbiYZqvT6AML6m/Qvqx nPNNoF4gVuUvoUvBvJaza9FEnlQQp+Rr/tfRTcU8YsSrZvH61q+nN+gADzBF+z8cFagi 7i7A== X-Gm-Message-State: AOJu0YzA2QO3Cg51qYDhz3XtFmMzREYzyoZbNQsX3CM6lDaFtJMgzg5+ UDqYpUBKvxpzTDkwpehcxQE= X-Google-Smtp-Source: AGHT+IG/rpSoscDMsjiZahKHW5DKav0OGOlQ6bqp04xYQwKcY1sQ1AOt05hiLcK74Hz4Jvo+yXtCJg== X-Received: by 2002:a05:600c:3542:b0:408:3f64:6553 with SMTP id i2-20020a05600c354200b004083f646553mr2565974wmq.16.1700329362877; Sat, 18 Nov 2023 09:42:42 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v2 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:17 +0100 Message-ID: <20231118174221.851-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sat Nov 18 17:42:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32880C5AD4C for ; Sat, 18 Nov 2023 17:43:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0EF5B10E346; Sat, 18 Nov 2023 17:43:53 +0000 (UTC) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by gabe.freedesktop.org (Postfix) with ESMTPS id B438610E346 for ; Sat, 18 Nov 2023 17:42:45 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40a48775c58so4982045e9.3 for ; Sat, 18 Nov 2023 09:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329364; x=1700934164; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=WVp/pnVcLk89/rxSznHuG5K1Idox53gWfspd5Nc0a6ApBwb3lWzEdrgWdob2oZAmQd 3H36Wq/hMqPpWB9qqkiRu5Z8P9T2N1zX9qR4tSrFnHO+h23lj2spWA4S5L08YBQz6Lo5 mzgtADXCEbYI7LWMdkENSFtYXChcMTgjs1zhk8t9ochwQj1BwY6tfFBcTF3b68zpn34Y VM4oz9WDJIw88oxuooBETfBmm9DT4arTv/Di31A5X/uxRPYGIllJtt8unkPjvMvJVPJ9 VvsScpHLbCbAKI2m+evYdmaSQxgkvfiZBhRnLyWaXTxyfc41kroVs0RuWh7emkK6T2Ov 4T8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329364; x=1700934164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=gqXViYTYNQ4rXy/Z2M/Ppz6l7iZZ9r4j5bFd9tpm3MzmBZU0UkAyzlcq7RFuKZz919 DnRgLXHpxJh3Kp6wor4cAlZ9ThA7PlFTzr6U8qKtUZk8j8vvqH+30B3O7O2Npn5hFC/t P//5/3/B6hoDIULlOBAEzlFyjihroXHQpPkK6WJSWJGvI29Do5HS/ewm3xvDKhwWQY+Y aUBY+KcEMrPsnyWKTPf0kNF8ZiMdm9Md7q+nJ20vmwxjdk3VLQED0/v0JaNH5zS3cUOG 3S30U+Qrsc8GRCFCixxAUHhDYT/B9Yj0D6k8zCs42KVDDO93jjclTT3IO8guVbdxF3qN xgFA== X-Gm-Message-State: AOJu0YyulNUTuQKk+XHurNpKrHTl3CrlMK8mmfWvNCLt9KmAnpPeyAvy mK/V3kH64TuVAWMZI8xaCN8= X-Google-Smtp-Source: AGHT+IE0BbMsvTSWTVOENdiMPkZHzodITfzmcl8KlNhZRnTozdLCx9oIUql/Zj2eZN+2ewtb0OZtew== X-Received: by 2002:a05:600c:198b:b0:405:3e9a:f1e3 with SMTP id t11-20020a05600c198b00b004053e9af1e3mr2171546wmq.11.1700329364007; Sat, 18 Nov 2023 09:42:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:43 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Subject: [PATCH v2 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:18 +0100 Message-ID: <20231118174221.851-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Sat Nov 18 17:42:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3D16C2BB3F for ; Sat, 18 Nov 2023 17:43:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82EEB10E341; Sat, 18 Nov 2023 17:43:52 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8542A10E347 for ; Sat, 18 Nov 2023 17:42:46 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40906fc54fdso4732235e9.0 for ; Sat, 18 Nov 2023 09:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329365; x=1700934165; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=FJL+gRqVD6hr4yN5cOh8Fbeg4pE27yoSStJgud8W+wUhTMfw+kcJVb6mNrwE/gICWq sUTgssTxNIDkpQFnulohiJDyGfWirZSNP8rWmLAKSk3oBYqUWe5kgYZ9xdcf+ObiJMfc CoCIIzzmuC0BCmsOE9P+vbgVAxT1FHxh2+sF+dGyNHUzAy11yCUduQHKSoyEjovpfbV8 oe7L2Rd/+kmpa6Vs4py4MYyQzQ8KFxzkWcrpcjkdF5AD+9xQnBn1dLBKR5ciao/ApOA/ F/3LMWebBaVoqqI6o7W6cyH+l999iRhoDsq/5W+W3PAx1tErOUEBxOiGLz4y5TL7hdqh lRWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329365; x=1700934165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=pKeM8tWC53j7pbc9juzO9s7mKnloD/5Wl+8MkLlbyzpnbQdacRp4jd8bICfwKpBVzW ArGvVxU3NwVH6P0HvtpEfAhwPjy1eBhrDOEaV07GQDquvWajz2cNtUqIlD/tu5G9C43S i8hwByxiOybFUV25YYEfuMqY6sbk6bO65NicpHnSjjP/GEnzytoZYX11GOETNdTwG0Fe biw7Ym9sIPR8B0pfxRpObQbq5Dn9EyI+OfRjnVbYOVWHNh2Uoyqy2cPYtcaya6ZJQjlu GrrbFhjPwiL+n0+4zrzUokVuVlBDMBOkcl3ynvQi/vOhQ/jOMefx1esQ8ny5rGz+ipJY h1Iw== X-Gm-Message-State: AOJu0YyeoI0uZ1g6bo16ThgQSTXfUGN9zBWFFoED07V3OUILO/nrK0Bk AkCoiOosBmd8kNq7x9Bar8o= X-Google-Smtp-Source: AGHT+IG1bPAOgl9NUb3ZPEvQdEyTHO+knTlvlp83e0Ttem8msHJ/hnBaJ5EBV2Fub43robL8FmGQHA== X-Received: by 2002:a05:600c:4ec8:b0:409:5580:bc9f with SMTP id g8-20020a05600c4ec800b004095580bc9fmr2199231wmq.34.1700329364830; Sat, 18 Nov 2023 09:42:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:44 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Subject: [PATCH v2 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:19 +0100 Message-ID: <20231118174221.851-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Alex Deucher , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev;