From patchwork Sun Nov 19 10:14:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460354 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81769C5AE5B for ; Sun, 19 Nov 2023 10:15:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 605EA10E1AB; Sun, 19 Nov 2023 10:14:59 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BB6E10E19C for ; Sun, 19 Nov 2023 10:14:52 +0000 (UTC) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9d216597f64so461944666b.3 for ; Sun, 19 Nov 2023 02:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388891; x=1700993691; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=N2OEhs8svYe/1qAqE4n+jPsQMYU63JC1lJGUNi9AxJqFq8lvtJWFMSQjVwNqO2pQlz 1mzoZ3CkY1C5EgFtJjf6crpxPXimYLHCIp4sHtv5KSbwLvLfSJYp9x90y53UdAYFEnl+ 3qoiDAw9aSzquJBxLtRwG88pVxk/8VX7yFI5CAB5JJusgQ8bcfF9/LSzJMd+8H9iBjhN lr+KAJXndDUFniU0WsPlMnANZz7xFSLyfMdbw8yBJDiOndr74pkSMzb2aMI9/3L3QNOF xSq1FWXKCLFKA0dYuNbtpbqCLnoa3ZGvBUQyG+MfIF0C95hRHa5cBEz2HJg88UfHB6TH E/7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388891; x=1700993691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=SrZNh7taXzNbIB3sYerUQkB/1XG0VCKJ/AtnPxiY8SYA6hj7ipVw4Fqbtksy5l1YOh HANf1vSHEUR9EW3AC9EzymnZt8bTKph1MB/YyuclX2tHUiO2mDp4L5X1yuFKzH0JEZfr dq3L6ZmHJcb9iaiiZNtnsocvRTktZzv5cbiprRZE8VDUq04eP2kF4U3nkfvdaa3uHCM/ POyzfczt1mXG0yFpOeuZdjVgIEfDyLXhQr4S180332qHClG6QbYZtPRvdXtVTYsrxv4C 2bzWTueDe6XdSzjZFzUQKhR1wnB1BUGO1ZxBMlO5wQLCT6ex5sWY3cjt9wpnJVsEMce/ a9xA== X-Gm-Message-State: AOJu0YzxTWQlYyvYR6KmbT+zvlrhtN/mRqRql9Ki/VuEJ96mJrdTWW3V JCjSPk1bSul7nx7P1rWCBEk= X-Google-Smtp-Source: AGHT+IEEVozgrh/6Rx9qN+MfKy5rNAZjGHZv+pzm8pL0WUjL9KQQ2Sv26qqyIC1UTM8PRyGpjsraBQ== X-Received: by 2002:a17:906:7394:b0:9c7:db3:8b31 with SMTP id f20-20020a170906739400b009c70db38b31mr3495931ejl.59.1700388890388; Sun, 19 Nov 2023 02:14:50 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:50 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Subject: [PATCH v3 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:26 +0100 Message-ID: <20231119101445.4737-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Sun Nov 19 10:14:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61729C5ACB3 for ; Sun, 19 Nov 2023 10:15:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68D4510E19D; Sun, 19 Nov 2023 10:14:58 +0000 (UTC) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by gabe.freedesktop.org (Postfix) with ESMTPS id E979A10E19C for ; Sun, 19 Nov 2023 10:14:52 +0000 (UTC) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-53e08b60febso4889280a12.1 for ; Sun, 19 Nov 2023 02:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388891; x=1700993691; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=QGrDUVdwHeS9uLohJ8ItSxzWM17pYU1wm8beVqLYZKbbF4KbJrESxEDDAt6FUikHfz pSmjwpeuelhLfwKDmsUaJsv4rN75tbL46Kza+ZGuTweGHVb7W2Gt8rnwvYRaiZKVWGZR InXprjXSd9ATgLK8yY1x0ODw/8f0apncGwYmUac9rErBLaxlIoMiNentMhOyIGvO2gyX tbPfLwswgQr3Oq6Oc6+NyHVBh2pP7ASLx4bh2aJJhyAsnji6Lh0O2A8q50wTWVlM5pkt ktTzVXUed/4pmSnkWyhTzM8CTyQJ4gjEk9WBqtnvW4L6q3JHW+dhIU08nM71NLmnHjA3 MMCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388891; x=1700993691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=itraD2cC1qguMqHrW3H1nUZ86ko+y8IwvJZGiWXgXSNC4ge04rFJ/DsAo9d7LWkdD2 fvgSsaqoLaOhXfMrLupxFkv1Oei1RaFPbJdfGW3Nev5SHZAFefqUKDwQvbgIPB0FurPA LqfyesnL111uVymC/9jz/N7lmY5mEJMauo7Yh3YBslHEGJOL8patjUgy1HHIzDYBjDD8 XNPHn9ZRchKMnSsESfAsRs4ou2XTB8RKAa6v4VWPHenKpel71iSMsAmvI+LusrUwal1b 0RszCxjVLpe/vWeeCqafwU8TuTT8worxkpL61LBnsaxrYH75z7HNpoIBwAF+qQgqxtPD kFMQ== X-Gm-Message-State: AOJu0Yzvqu7yj4/MI3IJG+AErkA9UKkuamlnQl2QIh4KmacYjiz3GxGG Va7toYbyzbBk3w9iVV5rNCo= X-Google-Smtp-Source: AGHT+IHk2xu3Z7VHdNC0cDI4LceA/80hAyskiv/hXJYF6ETvfNGrJOqk/TU7oB4w9TiA7tO07j1rfQ== X-Received: by 2002:a17:907:9483:b0:9ba:1d08:ad43 with SMTP id dm3-20020a170907948300b009ba1d08ad43mr4137673ejc.70.1700388891276; Sun, 19 Nov 2023 02:14:51 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:50 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v3 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:27 +0100 Message-ID: <20231119101445.4737-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 10:14:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460357 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD081C5AD4C for ; Sun, 19 Nov 2023 10:15:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89BE910E19C; Sun, 19 Nov 2023 10:15:00 +0000 (UTC) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0689310E19D; Sun, 19 Nov 2023 10:14:54 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9c773ac9b15so460390466b.2; Sun, 19 Nov 2023 02:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388892; x=1700993692; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=Z0ToENAqsQLAQbCbW8QFiK4QslmA4LffzE+nlBDuU/sQmDO9/O1KLN5kjRDSoSwm3y E+Pg3pVohT7A8XNCq8FysFXmEdI/j6V5NbQcj2Avq+CB/MATJ3rfCpw0txEsoYaQLEwK B2BFWJ7VjfXNdp0Xgb4ylu7I7vfoVqQqtEBN3x7Cs3rUJFyr3yAk1zTpoj+hbdFhUDsR Xd6yGTDxp3jWfjMwXD5Yiw+nZ29WvSDWNslAwcOG/fSc3lLWe6QeVcQ0tsnqoiROaWMW CG6eIK8LcsK18RsTDe33qmkH5qiJJUrKk1sqB6wZviFWOFXb3kRTlosLIrKMNNdG184k 3rhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388892; x=1700993692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=rw0VA/u406Fd3CshmIQIHWFeDVN2CDia4Dlcn/NPzoL5YfwNuEC1gNkeT2jdxL5adu cYrR7Y1tj2Gg1LtAu1YPuXgX/etpykFa29JYqRmjRO12ADeXfHLdNoBhDQKcTDtXdFoQ KvFMFNkh2iNGhhej4l0ajMC/AyfRhXgNqgCMnk+L1n/q6e6E0nP5X1LCV8ACnBHAvxC+ zpKTPihleCB+8HetTpZv6rKfSBwpItekNZnmzLzlkEx/fqaJpCKRpoI1crgluf817h3c B11ilBV7WFhgjOn+gTsXnj2R/retU4mRWveDOODrQ1Iiyu0LUOyKUnWOpdWNDenoZmcJ IKMw== X-Gm-Message-State: AOJu0YydgS1h7i1mwJFWruM5wGCZY59MmJEWGTI4jUGmdQSyid8WB58B tHm1n5Ex/6muiDLCKdb737HMfAJXZoo72Q== X-Google-Smtp-Source: AGHT+IHpCHj1EcCfnxWb2sNRSzs45S3cm1uALa2nvx3KgSG12OobKbSms5AW5GyKzojkEb4lxF1FVw== X-Received: by 2002:a17:907:c018:b0:9bd:bbc1:1c5f with SMTP id ss24-20020a170907c01800b009bdbbc11c5fmr3589189ejc.35.1700388892263; Sun, 19 Nov 2023 02:14:52 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:51 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Subject: [PATCH v3 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:28 +0100 Message-ID: <20231119101445.4737-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , dri-devel@lists.freedesktop.org, "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Sun Nov 19 10:14:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6575DC5AD4C for ; Sun, 19 Nov 2023 10:15:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70C9810E1A4; Sun, 19 Nov 2023 10:14:58 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ABE910E19D for ; Sun, 19 Nov 2023 10:14:55 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9e62ab773f1so474983366b.0 for ; Sun, 19 Nov 2023 02:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388893; x=1700993693; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=AJcB7RALb3yAPj3MXGZgcKhWuX8ABWBlLnpYY/r6n+ZxeVcTYaUhG/U6xOChKYkuss 4OGdBdwAveqCG6hHF4WzOuUOOMC1V/xZPeNPXpSrcLPEUjqovwYeFqe7uhoF1o7okl5i QJT2XqfNlruIeRbNvq/SJ/MN1VzrJaie+RBrDlAegzCQ108COi1VCGRz1N639YoR6vCT BazI8XGfpvdc6IyAj+1KF9sTS8XPBHZksKHCiGIMcEI+OaYPFCSoFAUMk0JHgFLscHEt Pn8WSDK9hUvYB+YmRZP5Md2d/8gPIhjgUbhyKgya+JXZdawkIbxv0eNSc59UXsZSUcsU HQaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388893; x=1700993693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=Uw6e3b/hLzn5/av68ZN07w3RqXJnQwwehDt3gJT4BoU3xG6bST+DJ9lKlr9Jnm8a81 GPonCsMpjwDcFNi6xeJMa+6fgR9f4durdwlXvoSea/8ZR+rtSsv6Ze1zd7+k958wYYAh P1Q7jPNEjQq4Ny+00jKXbU2rrt4YbXXwA9+ktskcPIXxDCfKMIsrvcNrAA+Fz2TdQkj9 Sj4bvm/IBut33QrnWVHnxLerMElZQHkQ4+qzMaG9XlnhGDI2iC1XguQYFPdNPi9iTXPU c6UjPSuMpkSzgA4Utx1MxJ3ElJv4O8X9Qyi1LEXwchDhoIuNpf+/zXLL2EZ9O2gNR4Qi BD1g== X-Gm-Message-State: AOJu0YwcwxwSb28hBycwtsU6LPfTLyuwe65gtaC8YupKmC5dLCw5L0HZ /QkoMhZ7aFf8CQ6jqoj0BVc= X-Google-Smtp-Source: AGHT+IFcb1Rra71IEq6JfJPC58ag489QhCbPNIPTSnf82g6F4cllHuVlGQs/WMup357oql3Lum0POQ== X-Received: by 2002:a17:906:158:b0:9fd:a833:996e with SMTP id 24-20020a170906015800b009fda833996emr416969ejh.77.1700388893152; Sun, 19 Nov 2023 02:14:53 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:52 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Subject: [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:29 +0100 Message-ID: <20231119101445.4737-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Chen-Yu Tsai , linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jernej Skrabec Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Sun Nov 19 10:14:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460355 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59CA3C5AD4C for ; Sun, 19 Nov 2023 10:15:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D6AE10E1AE; Sun, 19 Nov 2023 10:15:00 +0000 (UTC) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A7D710E19D for ; Sun, 19 Nov 2023 10:14:55 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-53e07db272cso4881465a12.3 for ; Sun, 19 Nov 2023 02:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388894; x=1700993694; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DB25C7bMVd6OfgWCKQSEO94Aa30Zg5F+mwrgxtdXDA=; b=A/ftU/jBZOb8Yx8YRmcbGKKLCi2ZkylA+dRYjsKXuCVm1R2B977oIueCYs/i18Fjt2 BHgptkCBmRaqZbEmhZE+VjBgKvWooaXJUopRmUvS2o5hFVDfDt4wJtQypvL/dkW5hsf/ z9dM+yYqJ2ytx494a18Ja8FFw8+9C5M+122Ge+FJIPG8Z6/FM0RPo+yXNs9NqUjIInw2 S14zYhUYItAP8MkkCgnaxaFnt6CoXM0+J9Doym1Lz8BSz4rmR55lY5vfJBTzLSCI4ER0 S4f8YzjZjR3mRt4Ub8O59oNJo5Ae+CzuklTaGLEkzoRXzQisRSAs3clakz6T0Gf0NPqX Ipyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388894; x=1700993694; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6DB25C7bMVd6OfgWCKQSEO94Aa30Zg5F+mwrgxtdXDA=; b=ryty7metf2v2hSkN+YELiVQsMidohsd10HUyQJQihRw63dNRPpUBoqiRmMGDjWLQWg VNtJapx8VZ/voinjX+Tod9+SWr7Gvv2DLGX3VjUIg8aDSwN7Ru/vCCQW9iP+20pXOLwW Mj1c2CvW+ROWl05vxNBoXjPuelFWsVudv+xTLjgkloT6Wo5DvHy/+08MUGtZo9d00kyc 84V10RTZN25SuW8oZ5WNNgSKD8q+okWx0hyx1qyFiJ+r4CkmZj3l0tkhaLdQM2mw0GO8 XS/9+lftrcHga8IJD17wxaRIyk1vKVx4gxiKAi/9dwv1ppAcleX6AHIw8LdBvNn6Z70x mlJQ== X-Gm-Message-State: AOJu0YxJQxoxohC7eDr4nbxAcoJKE7La1XwzZcu7wReoemIQRtWWA0lk TDiDGOH+F2lMIUw04NCgY1A= X-Google-Smtp-Source: AGHT+IFSg9U5qIMb4AcJbjF+T77S5CydHJz/amx7poWoeUOMU+9+UHjyyGXBcelTE4xsBAI3I9B5Tg== X-Received: by 2002:a17:906:2253:b0:9b9:4509:d575 with SMTP id 19-20020a170906225300b009b94509d575mr3597295ejr.2.1700388893905; Sun, 19 Nov 2023 02:14:53 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:53 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Subject: [PATCH v3 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:30 +0100 Message-ID: <20231119101445.4737-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- v3: - fix compile error --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 15 +++++---------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..bb048e14b 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,27 +158,24 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) printk(KERN_INFO "i2c-matroxfb: Could not register secondary output i2c bus. Continuing anyway.\n"); /* Register maven bus even on G450/G550 */ - err = i2c_bus_reg(&m2info->maven, minfo, - MAT_DATA, MAT_CLK, "MAVEN:fb%u", 0); + err = i2c_bus_reg(&m2info->maven, minfo, MAT_DATA, MAT_CLK, "MAVEN:fb%u"); if (err) printk(KERN_INFO "i2c-matroxfb: Could not register Maven i2c bus. Continuing anyway.\n"); else { diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Sun Nov 19 10:14:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B24EC072A2 for ; Sun, 19 Nov 2023 10:15:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B66910E1A5; Sun, 19 Nov 2023 10:14:59 +0000 (UTC) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7593910E19D for ; Sun, 19 Nov 2023 10:14:56 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9e2838bcb5eso473470166b.0 for ; Sun, 19 Nov 2023 02:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388895; x=1700993695; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=CH7UWnraT/ArktHEXi83qgiUmHry2K8i/Kchaj2tzAeRgkWR7r20RG5ubyQ9QkPZVU gDPdqb1woJjpV1Z+KF2+QCi4PRVAF/SxbSocYECPCq1OtUPzuLyf7Wb03VOLrsYuE9qz C+B6bnQjT/+UR1rBVygT4SsozUDFkA9OOA9PP7sRFvSO5bM3rBMQSw4Hmnk0pmrRj7dk USwCaQdD/EAWMy25FHVxCnDzDZ3PklZ0PDygEM3GF4mQRwWm8DR0N/KkDW6ZUAkpfEI/ PZk7FR6tQzZ9UPAGB01Y0JiUqSFqI9LdU43N0X0ykY0LRkiIxiJoSjD/AsfFy8KfMcio gWPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388895; x=1700993695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=mqJ07Bz7gwFaBBCtmSU+lHj24pPvMWXV3XrI0TO0xQvmMlpjTzH4S1QcDpb8qg9AFv rfPBzVd4jtqOb7hdpZOanRMasPp5bn/84bu+4fugI7/+GA4a7Yva8PTZlKDx2H3fvJy6 Sl+wOAz54Fy/7QNMmdmYsWWzY+egGzyCRQb1A2qHY7XjKOLf4UCNuwXepwgzYknck5kK +oU0qrQOkt9aU4/AAjAH3MG2r2iRolZnGH2IiCEsdVXqDzoA4mNG8oEjXdaa7J4b3rVi 9t12VhZgdJgTX7f4SqNH5z7nmJ5Lu2AYhwzqypMOvTHFkbFZOgMCkKVGGXujAMtq+nCp OLVw== X-Gm-Message-State: AOJu0YwD3ept0FfuNeGGLST2MxvZzLbijFEuXqPuOaDgrvDIVuQXSME3 +nbU99/ARjSSrt1vnpObX6U= X-Google-Smtp-Source: AGHT+IGBo5TDe+9oNNSJJ/7D94Y6LpcpavrjXJu+KHrikjnvpOJEV08xR/3GbhvbP9lm9HCrbdPOJQ== X-Received: by 2002:a17:906:74c1:b0:9fa:fb8c:3904 with SMTP id z1-20020a17090674c100b009fafb8c3904mr2090466ejl.65.1700388894616; Sun, 19 Nov 2023 02:14:54 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:54 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Subject: [PATCH v3 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:31 +0100 Message-ID: <20231119101445.4737-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Sun Nov 19 10:14:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460352 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4131FC5AD4C for ; Sun, 19 Nov 2023 10:15:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F168310E1A9; Sun, 19 Nov 2023 10:14:58 +0000 (UTC) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F83010E19D; Sun, 19 Nov 2023 10:14:57 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9f27af23441so462789466b.2; Sun, 19 Nov 2023 02:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388895; x=1700993695; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=PtDdXlrXW80Shn8D19JM1joNx9qJBt9q2PnpmCUSpx/SeJw6QQBvqsGhwtKLEAJoxN aJsMVYovzseL3WSKozwUNNOq4Dxs478IYYMFf/xkj4TMAKlN6KXcZD6iogWfRQB7RMmh FotVIp61H9A4DxHCu3gP4p8MxWjRd1MJb+W8MLLfB3tGDManQ4PFc5hYYk1KUXiWf5E/ kF8DoGfreE2gwxZ9bRM9DMOFtBYyI/ZBmWpVixJxQAABN1xkZZ5Oh1M1o0LDgvWE8Uu6 fmUeynSiSqUMwv+YnuGpmpV66gyvwQSUXp0b5XOwx/uMZ6uv7iUaKm3FR2KQkdO1OBd/ fysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388895; x=1700993695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=Y7mFPzIGU0jkDXN7ibGmO0kCDa1zceRTbBe9KWeFpJoaVQVJOosyoIFfHF2XBb9UD3 vc3afJGL7jdfQO+v9w8Pluk23lQb7i583fRAgrTXX9QfNEpqqAo8O8YZJWVmeyizlWIA 3vorkAdT3jYdCfpjusj8YGZihMx0M+CRyw4GnswWYN08yia69Tdo9bXTX4jRw6Byw8lD C/1QvTCIK1cITq9My2QpIJHlEHIx80XeSRNyy9DqxLpjxYITFxZyPA/SnufiPG1HZW3J 8XvSxAdMA9NtWxjDWpnr/1fNfDzWCKg9g9UCctPfxU4Zz5xdj5Xf0nEBj43MlAKmFp9D qpgw== X-Gm-Message-State: AOJu0YzyphDl9qqfGRA02gzxrczROZMPHKE+7UhDzv8PdkNNxeF/O1m0 B728ZV3EGSYK29T4BCwxGWE= X-Google-Smtp-Source: AGHT+IGcxHwORYlBS6UfqYLTAlk7jFkDNf4Zgyz4V+4rMe/1cLzpIIDW4QHLGADivIY95M311Q5DQg== X-Received: by 2002:a17:906:10d2:b0:9fd:f325:1317 with SMTP id v18-20020a17090610d200b009fdf3251317mr304396ejv.24.1700388895427; Sun, 19 Nov 2023 02:14:55 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:55 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Subject: [PATCH v3 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:32 +0100 Message-ID: <20231119101445.4737-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 10:14:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460356 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3698FC072A2 for ; Sun, 19 Nov 2023 10:15:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4931910E1AF; Sun, 19 Nov 2023 10:15:00 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06E0410E19D for ; Sun, 19 Nov 2023 10:14:58 +0000 (UTC) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-991c786369cso474449566b.1 for ; Sun, 19 Nov 2023 02:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388896; x=1700993696; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=R8Nfkg0RQoEAuxIgP8zOZqmnsL8sHY5vtVdnS/T2j/fn2o2RADKbO4ZvTpXh9v4Kb+ /M0Nnx3kG5+zlAtCU66kbl5Vg+hU1f3C7+HEUW6jN6J2KgQBWDErd5zSk5Rt46rxNTnx VRsL+BCpglezfnPy/tIkfIVE1VsRsbbbApw8F8zDCj0bwy5WTYiKV25JnwoRuZmNFy6l Elq5GiPE7flV2Z6rWsszTijhcfhXrXdrFXTqUee2d078VSqOAhnANO7Y9Up6QcjNsnuL y12WUuaNX9K19bnH1CMKL2zOolyVMeP3+tOHRfmkmMCPOFBMqMuslStRM75lGTLxhSJV +t1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388896; x=1700993696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=Q3lEbQ9wdYAhYx3WTRELhjWlJI1eswLgOztxWhnyyl7lNPZun8nS80Mi1aEds8wYmq IfD7f9OWE/3PJxUtoIMhBI752UYxGL2VfgoSABgqe4qWmejaqiFEUnKX8DBG+5Uga89u zM30iWCbEM2GC3F0JwX8WZetJt2mycWAn5dx30ung8L3NSt1f7lvLDKS1cbFhD5H2Usf DY5GRmue9wJuj1s100EdxtIs4uKqxWK2pWJ+mcKR9mVKBQwpiseaRv9+IV4EYWW8yd/K RZh54XGCrV7qhS5J/5UwnSkuttiJ9rLe8Y7Nuysfoss6pRbGK7imMhdn/Q+uIKm0L2wR lNHA== X-Gm-Message-State: AOJu0YyPSz7Uwx43QWxZl/9XR6MIgY0WhkZBKB+5K1GuRopusOYTl3V4 MHtI0/3zHIrqlcM6DzLtl4U= X-Google-Smtp-Source: AGHT+IGNzCPy8DY6OUpPEzcikwvV3TQNAAHEQOERuY2DqLuCmbBKa7aBRaSFRQKH6eGa/KeJALv/Hg== X-Received: by 2002:a17:906:8f:b0:9c7:5db4:c943 with SMTP id 15-20020a170906008f00b009c75db4c943mr3606445ejc.40.1700388896314; Sun, 19 Nov 2023 02:14:56 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:55 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Subject: [PATCH v3 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:33 +0100 Message-ID: <20231119101445.4737-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Sun Nov 19 10:14:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460359 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDD1BC5ACB3 for ; Sun, 19 Nov 2023 10:15:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 007F710E1A3; Sun, 19 Nov 2023 10:15:01 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CE9510E1AA for ; Sun, 19 Nov 2023 10:14:59 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9e28724ac88so474030266b.2 for ; Sun, 19 Nov 2023 02:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388897; x=1700993697; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=XKZUbPTezbl8MWsDP8w0UTxUs77rsT5iTfPSZbJD2Ws8yohjDhyStfjDq/1gAoDgRl MFm8iOVjITSh9fwpk+YCj3KaXDatigK3RNS66b3OdQXGlz1zlDQE+1otL+OOvLi2IUyO zvUmka/IRFaRbVSZLSRme9TdMhCeDUPmw2JqVD7iiwRcVdFf/iz6PjEcGmXJRBx9+OCu Lq8AHSmt4YvleqfNG8tdE97D5LoPT7bONQbQWC4iys0Kyv0ofnDOAiarOnVv4V8Gq9UN x8i5ngyeys1Kl3ejdt56/crxPyfqhxO0yr9gQlHIngjDfKFMa74Vod3H72J7oC1P4AlG +IcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388897; x=1700993697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=MFL4uDbTjaOWp7NJs9z2t0ZnR/IINhpaf7Qdzux5Wc/pJ2ZCw7g9FpN3c1kyQou60g YK7yKTQCLy19ylIVYpjrj7MmSd+Q1/EU9WG3bMywXb4OSN6vjLHfwX2YRlrwRgOt8oMk NgOT12Xr2tBZH+ZHQ1nwL9s1HAXOXkX8YBqMgG6AeFDWLdE91MHaAu7yCYNUgmqkhrYn Flc/YMEUGagk3YTv4bQ1G9GvhdphKRrlCSRNvc06wyokI34uXidkuF9c6Ecmy3xgMLt3 6lxA+IK0+VCdo5sW7tLlv5mmfKDV5rbMC/1/N/G1sDSWhfrOmXR5v8TyG28Rwcjz0K1D d23g== X-Gm-Message-State: AOJu0YxCI9VOjByeikqD3AyIZG8O9X+hFzWcKBJmqW061wsGCJx2+Y/o uWXUH27JygyE92Af+MWItlA= X-Google-Smtp-Source: AGHT+IFOvnTj9XaGTXmf0kg4u9vN5bhBNAlFozIlZLALi3K4N5pNEJsRCsiqKinvY6T58jw2eiJA3Q== X-Received: by 2002:a17:906:1051:b0:9ef:c408:a4fd with SMTP id j17-20020a170906105100b009efc408a4fdmr3609738ejj.14.1700388897489; Sun, 19 Nov 2023 02:14:57 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:56 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Subject: [PATCH v3 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:34 +0100 Message-ID: <20231119101445.4737-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Sun Nov 19 10:14:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460358 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6023EC5AE5B for ; Sun, 19 Nov 2023 10:15:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A3BD110E1B1; Sun, 19 Nov 2023 10:15:01 +0000 (UTC) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by gabe.freedesktop.org (Postfix) with ESMTPS id D223A10E1AE for ; Sun, 19 Nov 2023 10:14:59 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9c603e2354fso649638566b.1 for ; Sun, 19 Nov 2023 02:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388898; x=1700993698; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=Xt0KFG/SnE+1Ua7fqzYJwVnq5MA9re8pAHZObD2HXO6LzOdEUFiqdqXYeKfGWVQ3Rh an9Tz3cRNuXq5YO3xL36vsnxZyTpPo02mZ6yvTjU1uP7mGCMDllxc0Sh0YDNgI4wn84R eQ6SEfHuZ/yQC/DW2Gn7QkNy5oqgHwnqOdsOcn7Wx51Q/f3ByP6Up3zzLUKCz9OrVz0w JQVT/5Lw/WwEi3qBwWDeIkkPma1253pdrUfIKzPI1j5Sta0mpcKP23en7eUiGNZ+tpDG MRez+vy5Tfn1/ri0wt+am0OIu/NmBBVijov7c7MvzQMNQOAWMxcJh2+w1AtSdD8Lu0J+ qM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388898; x=1700993698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=imBVJmO9o3pPwPnHSO4UFwtHqAA383CS1EaFGCRTIvLSIE/g/5jvzIK8RpQGOAcey0 WYYwOtyX7Ib/vOwAEleOBI8uasFq8Q1oROqRkeGLbMk4gu6BPZsZ8RBZ7oQRUtWWrn9y hkyQ90NeIMzpE0aMH9SyLJvggHBCummVPfOl7xbnhSjBzFQaob8UlwNX7dHkFuFLy/e+ FRinKFl2C7zvi1uiIXuCSIhOQkPec2EZS7FXGrKo/xcP3t21+KUTrp2KK+VKvCVffj7o iLhquC1YjxLfo3VI+G3kT9sue2qloanxHZ4gCeCpZjNt6NPPf1HKRnhzi2HmE5i8HBvI IbXQ== X-Gm-Message-State: AOJu0YwGV+CwEcTfqje1+e29ke0C7XyKBEcbbobcat428eu2DdvbeMp6 NWlvLZSeOg7cB3LMueyi1gs= X-Google-Smtp-Source: AGHT+IHFle1RXfTk6vKi5iOy+vzFpLJkczRWQhYONzqvKagrUs3pBjmQadRi0jtysCiaCW9sqta1Qg== X-Received: by 2002:a17:906:c111:b0:9ee:9d98:7d8c with SMTP id do17-20020a170906c11100b009ee9d987d8cmr11093291ejc.6.1700388898244; Sun, 19 Nov 2023 02:14:58 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:57 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Subject: [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:35 +0100 Message-ID: <20231119101445.4737-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Sun Nov 19 10:14:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460360 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BC16C5AD4C for ; Sun, 19 Nov 2023 10:15:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DCAB10E1B2; Sun, 19 Nov 2023 10:15:03 +0000 (UTC) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00F0210E1A3 for ; Sun, 19 Nov 2023 10:15:00 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9de7a43bd1aso460277666b.3 for ; Sun, 19 Nov 2023 02:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388899; x=1700993699; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=gap7q+RelcT+ZZJj74TtFaVnAIiNmLjHdDh24qaw+gbu6Ay+KruG9WOoddI/HBrb4P tavGu6dZNAZvyoTgP93l5zuhj5V9sQGEea2gGOxumQ1LT6rtur8Y+f6RFp/AvKPHuWar Djxv0FciDgqK2BJa92eAl6x5CfDBWnOg7U9M8eWuvb5sI486jslNrQ/Vxywixaclbccs 6LSdVvMz/5lKisr1Gtwi5qtMgUkLZxd791lnBVz2Mw4JqiHpqTwiqzvQtn57aFQrSV0L azJKRmfhqH1FWKtIw/Iw7y5cUbkgA5luhwtRNMUwBAum1xh5G8mw+B3GpyZKKzjewRXt oh2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388899; x=1700993699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=LkMOSvurej5hNLvnWEjdmWvDDtJ6vqpZEltcHmubZMNfCzJ1Y+5kO23mJKTeugOcpM avLSEi+P3TY4+BkpukYg1yuhsMakvJHUpdPTfs5vTz9j/R0I+u2jzCtzCYMKD6QazHhf 0FLZwdY8XQmhTzW5BXyebrlpYza43x5I4FdLgwoCDjh1LeAQ0WWGloJc0v3xNxE6ssV0 J7m9184vveWWWZJOt8l1q32aEBd23cBVosbVYJOwRR5CMMDpNfLirujLt4e909ouXe8X GLMqna2bkQq5t3ipj9MkewTIschAavO/4rhkrVDHXu9AVYN3lSc1cA4fEnF00XhooKT0 iB2w== X-Gm-Message-State: AOJu0YxwrRQaBrzNq8YEE8IFlrxQudAI980No9geqgldiMkbtlc73gIe izleUWkLkDBCCa/BQLjBCSU= X-Google-Smtp-Source: AGHT+IGxVgtj8iBRN4Uc5cMOHBm70nnnpeBmu/gwXvx3Y3ra4Uxo51EceybqbcoqUopaknIFYYEiQA== X-Received: by 2002:a17:907:c018:b0:9bd:bbc1:1c5f with SMTP id ss24-20020a170907c01800b009bdbbc11c5fmr3589383ejc.35.1700388899176; Sun, 19 Nov 2023 02:14:59 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:58 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Subject: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:36 +0100 Message-ID: <20231119101445.4737-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Neil Armstrong , Robert Foss , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Robert Foss --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Sun Nov 19 10:14:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460362 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF13DC5AD4C for ; Sun, 19 Nov 2023 10:15:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF0C510E1C1; Sun, 19 Nov 2023 10:15:04 +0000 (UTC) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0B2C10E1B2 for ; Sun, 19 Nov 2023 10:15:01 +0000 (UTC) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-548b54ed16eso68865a12.0 for ; Sun, 19 Nov 2023 02:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388900; x=1700993700; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=ITGtzTeIgRzEeWG1DdxepeiHfZBj+IhnNf9CER5qB960vMdo1PquhAUzuPsNL7yloJ 8HNGWeodF7jwF3RtjsinYcq4PRJIgJCc/DPo3SFIrpfrZJV8W5s5xL8vtearUTIVeYND jCSDRAgXkC/MlfrwNAToVKrqS0LFzAO4luLHzW4te7A95RbISmLFP73hsQFUJah9pNf4 ot+WRa4Vswx8y8LVrVw9yzJk3yL0ZJjvixRD3paZsGvI9G/+pHl71Jkp8PpJUsNkh+ln p5jsbX2b/KnoKJqAkfjAty9nPyLfYEsFQPd8mTJY3BOfh5aOg/AbCLLqLTin54AQgA7A S46g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388900; x=1700993700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=enarmB1wBcziPtxUvEtJ9ytL3M9T+e1TCl98ZpKBrYOQ6nnfyaGivpq7yIIIjwT/O2 MHSXlQpN3ZBcm2QYzo4C10lH6hx5toLbr4Q65D1ibeYBcYG+HZqGE97ecWwCRwy0PRsy kwgJ66SMWu4XJc75ocR5lFF0Q6MoNCBP3SPuXHTNc9bO2NcBqIqnucY3wQC6unoS92i4 TIh9AFYvqFeiY6C4XkFgsPkOOeUSVQGFDYI+Ye9asxY89oY6fkAZzHKCg3sqAiezWjZ7 kcCYVNqgo+Juth79KXKOffoSpSwHelq3mnGmocieQwF8J9JkVtQV7q3ptWfKIwE1dHae aL5Q== X-Gm-Message-State: AOJu0YxfXUFQNFeFs3fxGVkOiwEkmijfx0SAsnXlcGfWLx0ZfmbHxz25 R+8IaKv7JehkdHC7Up0DpYk= X-Google-Smtp-Source: AGHT+IEA+I/p5Y2kpMMwz/wbD8AVKRFd+63nqxTeNaPbKOxKJmEk1Il1T/beHX2wdaQOaGPL4A2UqQ== X-Received: by 2002:a17:906:221c:b0:9c7:5a14:ecf2 with SMTP id s28-20020a170906221c00b009c75a14ecf2mr3807104ejs.56.1700388900287; Sun, 19 Nov 2023 02:15:00 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:14:59 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Subject: [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:37 +0100 Message-ID: <20231119101445.4737-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Sun Nov 19 10:14:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460361 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99E24C072A2 for ; Sun, 19 Nov 2023 10:15:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A310B10E1BF; Sun, 19 Nov 2023 10:15:04 +0000 (UTC) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2EDE10E1BE for ; Sun, 19 Nov 2023 10:15:02 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9e62f903e88so446934166b.2 for ; Sun, 19 Nov 2023 02:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388901; x=1700993701; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=hF8wGjVv6r2XZbgKOWjqYFM95EcMEFu5gYM/B9vx2uKBiivc3qYxtEKDOAIMdyD5MO 5svLiGLudWbz88+TRdhq+SZvibyCPRxjvJoTX0vdY8QcRVTWZ+LhrEPafPgJgMc1omQs 5FseeEkzs0N4VmQ1OorQ/eOX6a71MRBfVmduCkgJeve5R3W+htVCuQwVpzYoMltvh5yd yzNRVCDdoy1RT1w7VIyvIiJ9XL+lnaeOUTQ5PijZDhFujwH9IxXnpj8jta0W/AjnQcV2 nkEvO3gM/MreTNtQjUyl2k2/z2hQ03sSZl02D1pV3eZ3c801PIJwBRqxFrii668828qq mFjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388901; x=1700993701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=tAM5nlVxUG6lQ1MCruz8kLwvWNhGf9BTKGkcwilk166+fi3wdpCJnCIpdYP3GN4drE KJqfJ1x8cq+4pi2MQft0VT2ODFNNUSPUV+WhdvzxwGoVoDyDlk2PuSlvm9kl3J+oDuWa sQv1F7u8UCyfm3N/3tqKpcxigNNJ7UjZFc1A2/mSWd5pwx5PrVi3bSj0+eIDggnwp0Pb fKtYiqID/a7ioSAPEwkAp+MlJAVhuzH46SGVNVyw03vdO3psbNWhfnO3cP8buSmU0il0 WDKL1aphR7r9bBV95IPN9FqglJXxIMo/g6WwrjjCVZdjDLqaLC6G0APC5DI1AhXGBlR+ vOAw== X-Gm-Message-State: AOJu0Yy6pO+WIKBoRL55GBx/T1z1tbR4zNhLj8JYUKl13WbI2CtZ0dWW l6Nh+HZgyLqo+Uyswi1dixs= X-Google-Smtp-Source: AGHT+IEUMMC5ITmLhQ++xTxsq0EC3YjolDxqXOJe5kffmWkOeFgA/YeGu7mWuST9nb8zkP/u6wQ1cA== X-Received: by 2002:a17:907:d510:b0:9e2:af56:c375 with SMTP id wb16-20020a170907d51000b009e2af56c375mr4580366ejc.52.1700388901208; Sun, 19 Nov 2023 02:15:01 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:15:00 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Subject: [PATCH v3 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:38 +0100 Message-ID: <20231119101445.4737-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Sun Nov 19 10:14:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460363 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F689C5ACB3 for ; Sun, 19 Nov 2023 10:15:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B17E10E1AA; Sun, 19 Nov 2023 10:15:06 +0000 (UTC) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4CD410E1BF; Sun, 19 Nov 2023 10:15:03 +0000 (UTC) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-53dd3f169d8so4629806a12.3; Sun, 19 Nov 2023 02:15:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388902; x=1700993702; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=fnL1iQzbQuIP5jP5LRnd/omRbh6XLqPYmBkjRm8ADdOMWnAeEcWfFjE97dC5aVNvIo PgjlzcSCQdmKTIyPRGbMuMIa8zkhfEXwxeECrRU1q1KHeJetkFH+ZH2Km6D6IdnZye6l XsHuq4iloNt3KrAEjbvUcq343r0LjkZCDjeNw/t8cjpU/8OYOW4/rkWJL4WCYgCDSh1I te8cDEgW5XsQ+0L6bE3Bl5U7oa/JD74CwaqzvzWCVbSVP4cwcm+OWaoCxQBPGhcPwAo6 X9fMa4Nx1RpQ6WxgcgIB/FrNR0vfySfrHcnwFrU4IKtiodUzONpH+Vyy4yYQHT4Uazs0 BVjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388902; x=1700993702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=RvsnFioYYXCoRewUqjaqOcpG4PDjBJsnjjkDQUVuKegRd1BQjEFdPoGscpPgxQGTp6 PBBPTvhYhzB5Yc5ov68960LJfUARYBW5SE9u2TgfFn8GhrJ9VtWXD4+BKSPVfFqTVG0w 6O5ZstpQKfUaGid5r1uHlki+1BsPF1Qa7im0e5jFj58GjMV1KO1EWihqRv2TmZYG2ID7 YSsp4o5o+t//oo2NPDwK/3CSEoK+rRIYe6AuMKLARE5hswg3HVKkI7m51VMd2Cmppg6j JGaxSjHyaRNG6QEa+f17z5YIHtX1GVfxl3OikL9LjthWyQF5pv0lGqneaos47EYLbv19 P3PA== X-Gm-Message-State: AOJu0YzqGG8uNWzNYflUfLyNTOvHReRV9+sztdJCV2b8MSoqxwg1AM3w YJenR7ARyh0eMByOee1nCiM= X-Google-Smtp-Source: AGHT+IFev9QS7E6H4FnlLJ9liXoF5szMOjAZoTWwnTK7QH9BaW1t5+tIQ2w2UPUQ8sPueN6bcCrDGA== X-Received: by 2002:a17:906:1001:b0:9e5:1db7:31b1 with SMTP id 1-20020a170906100100b009e51db731b1mr2848642ejm.2.1700388902097; Sun, 19 Nov 2023 02:15:02 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:15:01 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Subject: [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:39 +0100 Message-ID: <20231119101445.4737-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , Sean Paul , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Sun Nov 19 10:14:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 337EBC5ACB3 for ; Sun, 19 Nov 2023 10:16:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C47710E1BC; Sun, 19 Nov 2023 10:16:08 +0000 (UTC) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by gabe.freedesktop.org (Postfix) with ESMTPS id C947910E1C0; Sun, 19 Nov 2023 10:15:04 +0000 (UTC) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9fa45e75ed9so135156066b.1; Sun, 19 Nov 2023 02:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388903; x=1700993703; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=VxNgpcmNAn7eHe0lOWbCl8LRxwNfC8f5bYROqvoKOmtsiukJMxDImHhyhXrhc9NuLD gTKT77s5+mQ1MDyspaJNnQqEggAE2vFEL1Niaui1Kx+ZoBYM/SzlFCl/bDN2sytRbtcy GiAHzt2KCJhzvuqYGpiRPfjaFwC2m7/4zdz903+6iQYL0j7qrOm6yuqMz243b4vV52a3 hKA7WgOwmoMK8jQCglTW7zcM+IM7m0n4VVuGXYO9ygJQth/PoRBqc+ayO3fdYN9TEJ/N u1EJIXFa47pEtDg9XUoIXLZSz20B24EHLj8iigzRVMKTrfj79F9MWbSvKk2EU4qnONX+ gQww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388903; x=1700993703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=bpwx859zSfVneGwAkI6YZ78aa2bSbc1Pt7JtCNk1rwDK7qGzV78+8TFQJYRP96IuPH 2yvV/2lpvWepr//6aeKiw7WflnDg2xTGEtUaMzrAPhAzvJHCtzpMvn0HKu9qhBE6vnhv +9R6C9qLx5VJCyCyuj6nqxcLJpU6YUhfz4Lpdt8idOZx9HchOxCIzycCar/fIHQsnOMO DMrvn1gOoCC5iWvK3bQKfWXBSyVFtkQOcI2iw8GmtFjxBX5kdIbDpjDdFzFc4qNukzMd Fw0+Jezb0s9BOvM+RjBX6IV1J+TtPG6RAfGxFUyK5wt/drQvkOSnO5SYOSkr3wywi1CB ejpA== X-Gm-Message-State: AOJu0YxPdzRMdFpiSQzja2kgMcrQ9MTwF+FAb1CO0Xeq027ffJzVN5QQ TVjn37eyziwyOgzo1x37u5s= X-Google-Smtp-Source: AGHT+IHP6byAlqIoVwDbbgjuChf3oN9zUpAvK+yJPawUfgKyxdFFP80iOw8k2baYpP8MVO/1Y6ukEg== X-Received: by 2002:a17:907:1ca4:b0:9c7:5200:e4f4 with SMTP id nb36-20020a1709071ca400b009c75200e4f4mr4905232ejc.41.1700388903204; Sun, 19 Nov 2023 02:15:03 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:15:02 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Subject: [PATCH v3 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:40 +0100 Message-ID: <20231119101445.4737-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Rodrigo Vivi , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Sun Nov 19 10:14:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE50AC072A2 for ; Sun, 19 Nov 2023 10:16:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 088A910E1B0; Sun, 19 Nov 2023 10:16:06 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCE3D10E1AA for ; Sun, 19 Nov 2023 10:15:05 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9de7a43bd1aso460286266b.3 for ; Sun, 19 Nov 2023 02:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388904; x=1700993704; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=BB48L4Qwi78zV2e4OfopLe4VGKxDEffoF+W9wgOhIg9W9ha5La5RrhTTXhpkdyus+F ma/RYMyTN50aLPdg4oUirTC5/R6y0Vi5S14P1RMzmvojzTngW6HkH9qFaWWEIEfqPW1y GPtCI03JrFD8xbyU9chvUFfTkouLycUyKqmmgF7RBcqCIsEMvZTfJqadp0tiXBeCzEXW 3KiPQaXQTb2Uxa7d7BPfQu9slyc2boitDm2cIDEvM5pAjoQiyRzJ4KqcXsDyfssAcF4/ 1vLNVU+Tvle4Iiy5/c+aQJwgZynEyBz4H3DbedvSuwrdQ5lNN61oPmBOPImfIFxVhoFW 8nPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388904; x=1700993704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=L3Kpzoy2uRtMB/8UQP++UkmQxnXyLwYaE/vrXX4l1nEgFQZm29F+dTSlWdKVSRNkBI +yjOinkgcFnPicuFhBv+Au7P+z14wotefBpqshKCagZoI5nvgtm6xdZZBxlAg2XMLFob O5zDGoTR1VvfxFwM2+F6vib+wj9VjwF/bk7ofFXYoPIU0plUFI8rkh9JCh9w9dHM7lun +9+/R2HNVZdTCsuTz6+8K3IRLIiOPUJ7ufk0aBEMgZjhrNhXPIX3MmpGoB7+9RddxOxq NxZixy+wirtSHb0x1tIxF5bIvLuvXDuo/vMP5J/h/cWIDrCgRw87DAhrkc7nNEmcLnlx Dszw== X-Gm-Message-State: AOJu0YyOJq19G4s59v/XfTJ7zCn2t54TvMCWhAYUnLnr6Ng9lyQb5D0P J7UaO/XePmL2vBp4yqS1pjA= X-Google-Smtp-Source: AGHT+IE8GHFq7uiHSNV4+P+yG9Uk8xKqFaoBRiYyFD0p/QlJu9rTxI9UZij7OIQ47Q1zPCUxvVwxGw== X-Received: by 2002:a17:907:8b90:b0:9dd:7133:881 with SMTP id tb16-20020a1709078b9000b009dd71330881mr4222135ejc.40.1700388904176; Sun, 19 Nov 2023 02:15:04 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:15:03 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Subject: [PATCH v3 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:41 +0100 Message-ID: <20231119101445.4737-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , John Stultz , Xinwei Kong , Yongqin Liu , linux-i2c@vger.kernel.org, Thomas Zimmermann , Tian Tao , Sumit Semwal , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Sun Nov 19 10:14:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460364 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EEE2C072A2 for ; Sun, 19 Nov 2023 10:16:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1501110E19E; Sun, 19 Nov 2023 10:16:04 +0000 (UTC) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id C38B310E1C0 for ; Sun, 19 Nov 2023 10:15:06 +0000 (UTC) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9e28724ac88so474036366b.2 for ; Sun, 19 Nov 2023 02:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388905; x=1700993705; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=Y2IowoXktNvmW7ZH429UTwF8P2nAOUZHdDyTGljvOaLjJ3ourIYO5nviBpKaI5hkzM TXAW8s/7UwRM6tfU1x9NqVrkSw3fgu/H2fa9V9qQYtoQJR28gzqOBK0am0+P6IsRJ2Fq VKqVuEQQwt5m5VsJvmkieBZtpZP9Yv7ZGZtjEhEpAr0CKXKT8vAYwmbOsx1ZQlJ6Xomb CTo9Fx4VG9Vakx06aJbjdt+9x0jQHxZ7rJwGm96DeIWUquiGWNtDwBBU47lVIU8p9RZS 0dMFSBVfcYKUC/x4F2oWYuvbwHmU4CHB2lvdgxmA4euNRc/J69MQHZo73kfPiXG7kxIM 6jZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388905; x=1700993705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=QzG/7jaPa9niIprxvn0T+yQ33vl/EPOk0JGE7ccWm9rbe3hkAEUL+7hZX/xiv5nNWg XBLLziTMdcUOmz6IzxpHL3VSjO4Eqt7RycrIlTmZlsxs/Q12NLJL6KWbAAgyEyRGmXHc w4GLMuMH4k1WDovn10qEWDOz8v421/KAjDx5pcRdFRFA0IfOpy/Q5Vh5KbihdlNTs/jL EOzymzW395Gn76fn9vSN/310GalVpukpPmM9GZYCHOxRA4jue5fR+SN99goSs+OU2VD0 D4No1iib0+OIk97UbwdSkcIVVFoIHe5XW5uUj4EtRuzaJ1RK+uGB2dP0mEuegfJccUYP IIHQ== X-Gm-Message-State: AOJu0YyOvvP3VCPgxZapyoTGQFrikRbWcYT3QWn7n6Okarhq4dTE6cjS TqmIrv1iE6yz343wodhi0c0= X-Google-Smtp-Source: AGHT+IFVvZzXcZMoSvdXbtJGqi8lBJ7fXTKr3foFJmhtdb3r+iUKMa2DPobEi14a5i6AA9++GYiikg== X-Received: by 2002:a17:907:cbc6:b0:9e5:2c72:9409 with SMTP id vk6-20020a170907cbc600b009e52c729409mr4079477ejc.43.1700388905079; Sun, 19 Nov 2023 02:15:05 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:15:04 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v3 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:42 +0100 Message-ID: <20231119101445.4737-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 10:14:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460368 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EF71C072A2 for ; Sun, 19 Nov 2023 10:16:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC62C10E1C3; Sun, 19 Nov 2023 10:16:23 +0000 (UTC) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by gabe.freedesktop.org (Postfix) with ESMTPS id E94F610E1C3 for ; Sun, 19 Nov 2023 10:15:07 +0000 (UTC) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-507975d34e8so4803464e87.1 for ; Sun, 19 Nov 2023 02:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388906; x=1700993706; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=aqMXaODNmGogQQ/B1MB6jWbLWoNt3dcahgKrT0LfY6QxxcpAVlfvNzRLHybVzhUOcP Q+llO3nzXOlH+heLxn9szwaE/RLDlKx+JCWowQTskEznQi7TOqCfFYOkBGg9ZouRcSr4 I5MKr3hq0C7C33IW75UXAOTptG9HXOqvEUt1RZ95y8+m5ZZWG0YzCEe2NQAZyozznRr+ iQJD93ECRsKymxfNw32dNWG6CTtbxKLE5g3AKstr8EOiCFk92Cl/dBw26zIqKz3T9sNv BCOOZZDrIIOhZcQ5NqeOXt7/pWpHPAEDpkP389OPZfBP3G45lbw47cpLp7iszjWR4Z7+ of8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388906; x=1700993706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=E6//227ir3XNyzLBhjaUP0vBNeY564NVTfBf9U5hEqT9DRO9GCOAb0SlJGDTQNYEOh yp9M7j9rPeioFeHSjf3W8rRJsh3B6ayrtLZhoftOFkwZ47I+zTUJk/ABoygHeZO3aKKu E3cAMgO7B8Exh6gxRSWsnTMzULRRA38p/6XyLBb3j7nd7lGPOWzrM7ecWXXungnKv4Gw MLUoDtq2JGVuVHZi8+cl6EnAIoCiHLHfxEEZ4hURrRu2j6mS6+73qWdnusFpgGcmOxH6 8fcKv5NoPNwaiN9mwFXT2JPuEZ7lVGcaozJ10io2D5LE0RWCDbuiuPuKWd7l+HpOukRp 8GQg== X-Gm-Message-State: AOJu0Yw1mJCMOKdqCsak034SEG2Y83xChDEuQ5aJ3+yO3Lbch6cuwpnd MS3LgqVnuQdvoIbwpoG1Drg= X-Google-Smtp-Source: AGHT+IEBNtGupNZRx3Bh47nQqEJXfOErC07S8qM8sDytc7myG1s2fvCfEFr35fDEICFajV/VyH7P/w== X-Received: by 2002:a05:6512:615:b0:507:9608:4a87 with SMTP id b21-20020a056512061500b0050796084a87mr2690869lfe.56.1700388905907; Sun, 19 Nov 2023 02:15:05 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:15:05 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Subject: [PATCH v3 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:43 +0100 Message-ID: <20231119101445.4737-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Sun Nov 19 10:14:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460366 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 597F5C5AD4C for ; Sun, 19 Nov 2023 10:16:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8972210E1BE; Sun, 19 Nov 2023 10:16:07 +0000 (UTC) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D3F210E1C3 for ; Sun, 19 Nov 2023 10:15:08 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9c603e235d1so474285166b.3 for ; Sun, 19 Nov 2023 02:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700388907; x=1700993707; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=NQCTh6FF/RvtkkLAT4Z7gFKhkTKyLHegVr8ag8z3z66yEjQjIYlE2RpMrLUT/rhWoo m4jpbriOP90WbZKddoJrh4guXH8yVr5+pyB2/HkEKKTprsaciGhikOy0fT7Qr3NmpIpR OVid21/OEk4oOg5xAFd5iyhOxuOD3N84yvRWDJa3OeyC6TSUjr8ylugBK2rx5GLe+ddQ cMiR3VzSwyccSA9uDIY/PmEQmMENqgH+Cr4TvhQl04gDq+Fuf4KvyzIt63DUR+9RblIf /5EA0NU2kvoGQ2mXLgLcuBhGnUgW8NJq9DNsHY02/j5xyZJQ8z3bxHzStugQcOETs/Sd gQeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700388907; x=1700993707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=iK/z/s2hjTyWFDutzS+qXckogcX5yBHH7ze4j8oUstQXT6MVwbsgNvONNjYPliKutt 7prfV1KD9qnyuxj2GJtk2vfRGGKbf5SMQccoLEq0wZJvtwYcu299KycBKTrNW0NwKU1E qhYb6sIYUV8n1Yn1MPYvIhilFuVqDZ+zpN6QndgxXg0F15V+dX4sT6FH9eAvMeOjKU2d vfpzRYlghQGQ9LW7CRnPUHM7X+RHXRSSqPr4kvD2Qmavb8UyiKoX2mPM+HbnbKpHYg7p bSmeihfThjF7I4YoWSG8xm+5D7Tg+xxWLFClzE82zGrkx6cexINt46dK8dYsqAil3gIm hycA== X-Gm-Message-State: AOJu0YypV9B3G8jSRlbTeMtYcJgG27QQGtCC5rhl8De0ux61IVF1G8DA qj/pVis9vtcUbHU7n54bb0o= X-Google-Smtp-Source: AGHT+IHz4Mkuei+5Zlm1vnh7Y4mgzhrej2LzRNWm+r0PgkV3RcbkaFxreIMEyEHshEm5B+Cmem+Rtw== X-Received: by 2002:a17:907:9708:b0:9e5:e56b:9b7 with SMTP id jg8-20020a170907970800b009e5e56b09b7mr3842857ejc.42.1700388907007; Sun, 19 Nov 2023 02:15:07 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id p20-20020a17090628d400b009928b4e3b9fsm2743581ejd.114.2023.11.19.02.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 02:15:06 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Subject: [PATCH v3 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 11:14:44 +0100 Message-ID: <20231119101445.4737-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com> References: <20231119101445.4737-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Alex Deucher , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev;