From patchwork Sun Nov 19 11:28:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460404 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACC19C072A2 for ; Sun, 19 Nov 2023 11:28:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E3C510E1D0; Sun, 19 Nov 2023 11:28:42 +0000 (UTC) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by gabe.freedesktop.org (Postfix) with ESMTPS id A25A210E1C9 for ; Sun, 19 Nov 2023 11:28:32 +0000 (UTC) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-543923af573so4944280a12.0 for ; Sun, 19 Nov 2023 03:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393311; x=1700998111; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=PhAznhoij6cUKja9tOtbKahq2DDy8w2QWLfhqtohAgVrKyCWnreubwcQqFpelX1tOx +OTZ102/0v1aD50YPajPduAWOmmTYyRQPUWP+Hk/WTFGtHEKMe9MB9W9fthSS6iblEWy OErm6OqoofK6JePRIMOQFnpD5lI5lO7cxRykPwrtY9XOLV7uVtkH4RLq6RZ8NDOcjFXe qH1G1bkgZm2wP7+8zxrQY4AGNx7VT4kqP4hyeyMH6/L37xxhX2gLH/V/dn60AbHPdH0V LgbkBh8aQXv6rC/GAzean6tQ2x7nOCzZOSoO1FCiMK6lhxo1Jnk4A/F9V8rTsXDY2mPm wH5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393311; x=1700998111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=bUQCZBUdjRxIGQ0HG0NBVxwL7T/4F9mVpaOE3HNSE7v9F76VXwyUKZlBQ4dlLWGHES VVdhibMGgRd+p+jn/PUWjvqIN4wSi/d50tD9LfZzZeUujF2QJeGA/1EgbBtisKVzDyuF oXK5mKOEv+7cSaOxeNlXsbGeG80jwlPe3gD0Q/bnw391z7YIfz9mm8QOvTlz+HRZUoFr dIKQo9ZOtTlcLKzuxg8QVBZGB74ZYiKvM5OO65TdBfxC9RrwOQs3BE2QnxJw99qPjvFp 5hXy90TTfBSZ9M94IZlCavlsrlguCT+oJwXW8/E028LU0MP2i1cHx3Ko/yG/36E1QE2W 9noA== X-Gm-Message-State: AOJu0YxYv/oDTknzEgjfLcgCoLeH6GdpWwtVeRJ1sHhvUM3XP8wmH9Wv UNceZV3KV2AR4/JTSrn/Mro= X-Google-Smtp-Source: AGHT+IHPtJDz6Y9TbEJbQOyBB/Oo4sosA/jONsRYvNjJizHcLos8hKdg2Z5bR3z0yhjciXL0cwqKOg== X-Received: by 2002:a17:906:309a:b0:9df:2fb1:1a83 with SMTP id 26-20020a170906309a00b009df2fb11a83mr3398055ejv.39.1700393310552; Sun, 19 Nov 2023 03:28:30 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:29 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Subject: [PATCH v3 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:06 +0100 Message-ID: <20231119112826.5115-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Sun Nov 19 11:28:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B9AEC5AE5E for ; Sun, 19 Nov 2023 11:28:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F23A210E1CE; Sun, 19 Nov 2023 11:28:35 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46FA010E1CE for ; Sun, 19 Nov 2023 11:28:33 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9df8d0c2505so656999866b.0 for ; Sun, 19 Nov 2023 03:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393311; x=1700998111; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=VfWwM/NFyhDtVm7wBEBoGPYtoj45i5vMyBObE6rEE/yDvjmGxw+CXbIk8QdB1GTauk q/Bd/qn9fnY4mSUIsZeBTg1+h7sfGi/7UOCqKZh3c5pYyzqt8J/TlTlLizt5AZWzST/S esHegIMlhiZM1zoqdYKVZ/06Gk+pcdEp0xp3Mb/a6lgY3qZvNqGySiEv7NK4TiW8x9W7 DNFFNXFiZZpXvEoDdHoquhC84OiZYr/3/bg8UbTiYKNDobngsaCHiwTZkCOvELDoAc+e e8+/YniTqLRYaxt9bwypoT8Lfhj75Dm366d3GXnmvVesFRUL4tC9S/TtNR/n45sn9+gy 08jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393311; x=1700998111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3j9ifWvhNZGTq3IiSm2aJzZT95r7nTZmkK8TlD5sXtw=; b=ZQxYYrApY1GBhWDvCTwJxemODov4WaNtwHGvXVUxnxQFNwK1+uWulpPO/aBf6TD4XC VGgGY6R1Du2hytKgvhapTCWn2euAt1vqllPy6KeNAWmGeEY+1FTYjHaySmCqe3zozGge RWf2sFLQ6/2CebDblUuHzqBG7tL1nfqPX6HofbHl+KKBGndOPTo1p2WXGWKmiTW2UQku 6eiA7dHi+OCSPXFY5X613FQ6+JhbsNWht/yuMeeTLlp7g/sRA5JxLDcnTFymcaQabTy+ RR3QF6unfBsLFpNc4/CcwszvSjmP+WKIYI6nXxRO2yjlbYyevK4tI4UjmAvK8tfJ6Irw tRGQ== X-Gm-Message-State: AOJu0Ywj2Sma0cB0D9iB0X0FaSp3ewnTL3CnrHw93q0HeX28gs5q9nt8 JZPf3+khH6OJFSfBtWawb9D+ub2FzrIFsw== X-Google-Smtp-Source: AGHT+IEolPQnFux6ptEBdIgIWLfFvK+a9fTJaZAE2jvnmd47z8KPXEbmFvRb3A0Nnlw8LWex2IJNnw== X-Received: by 2002:a17:906:2215:b0:9a1:f1b2:9f2e with SMTP id s21-20020a170906221500b009a1f1b29f2emr4088533ejs.2.1700393311373; Sun, 19 Nov 2023 03:28:31 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v3 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:07 +0100 Message-ID: <20231119112826.5115-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 11:28:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04607C072A2 for ; Sun, 19 Nov 2023 11:28:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C1C710E1CF; Sun, 19 Nov 2023 11:28:36 +0000 (UTC) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD30A10E1CF; Sun, 19 Nov 2023 11:28:33 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9e2838bcb5eso477329566b.0; Sun, 19 Nov 2023 03:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393312; x=1700998112; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=hgTISipO1I0B/8TC7A4rgIxsAbbgVofohpkPQVuGv6uDmzT1xOG8ZYDo68eS7GLlM/ EIyFsw+XT6xdLlaXGBrUAzK+McKKiexigNcGBilqykVSgtXdUVZsg4W+QxG/89yBrTkE bAJbFfO6W2t5tB7JxmdITmzuM0iix3cCol7g/UhLJhZhPqMgdg29sz/7OC+44trRJnCq Mpem7uuSfgfHXHbI3Dgi5SX+Gee1RlXZhGW1uM42lMphZo1hFIyipvfMEGLgKGB7gf3+ FN0nKqK8TpqSeuI9UQ9FOHXPyK+j5cDRS/iGW2O4kaPYTqHqZZQuNfeiCxv8HEMJnH85 c+dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393312; x=1700998112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=XjK8mWmi4d3E8RtTGNkfF5Y6pHgNMi+2jg1UwlRHHMwgeRpUFBRlUacpV0IJ8A8esh zu33PUi2ak7VOY/7CqXvTSFLuvJJHAodTEzwDuQrQbd9AKxGWaAlPHFOb62Ccqz1eN5J 7LvUIrhwFSytJEwGcl7I2K4UQ2vtPasGHGUIY5L1Ek13DvD9HCU1IgsReTZiI+dlJfZW MbJDuQAk+Iz7H1s/GFxYvFG4ll+dYDQbRSS6v0UIvsi3s6pCwSaCRXvxMyOaqR3ydNMG vueKfnhDYNFILkdUCNUHwC3sbUUZejzWHMLEFOF0PWk93AXJODhBjMKixqS0rrUlWDdf U7Bw== X-Gm-Message-State: AOJu0YwH9C4ZoYDjLTUnSsCaNthBNpP+PtkBoblk74lfAqiQKwn8U/IT M9UYdy72YFig+sT6VfuUWY8= X-Google-Smtp-Source: AGHT+IHCBymhmMkLDgf8c72aSm6rVzHfrFKwC46JDn+N6dKLAc0aMYGmFbO3t7kmKygycOOk6QrJ/A== X-Received: by 2002:a17:907:6d0a:b0:9a5:b878:7336 with SMTP id sa10-20020a1709076d0a00b009a5b8787336mr3794771ejc.7.1700393312239; Sun, 19 Nov 2023 03:28:32 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Subject: [PATCH v3 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:08 +0100 Message-ID: <20231119112826.5115-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , dri-devel@lists.freedesktop.org, "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Sun Nov 19 11:28:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43995C072A2 for ; Sun, 19 Nov 2023 11:28:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6759B10E1DA; Sun, 19 Nov 2023 11:28:43 +0000 (UTC) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 170A010E1CF for ; Sun, 19 Nov 2023 11:28:35 +0000 (UTC) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-53d8320f0easo4884548a12.3 for ; Sun, 19 Nov 2023 03:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393313; x=1700998113; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=R0kVnAJBLRxJHS7dFLI1DO0PzNV2sOBs2nCAx2hRiQtGWmEyBgsRP2q7VdWZ0Ot/sr dzP/R2+tOxxptuyRIQLghBDmAZsmMbazqGu5rcnQEszOujYMPJW+C+hUjYUOoy72uNla SJgs/EOJyMXJc3AqhP8IQp0qK3hP++f1hrfMmHpOAE/MDlHl56uYOfq3gBv9uDSDVEDs TjFZM5gnYt5uqZhiF+U3N8ne3AYVZ539w8Tey3tJ0F5mvMPcI/JmC+qCewoKYuopVvDD 936KVtZKKqLmzBHpHcZQPVedTC5fAQIPHnqUI22WQpRtvlVJtMnOGT1gRu32m0p1U0du zaaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393313; x=1700998113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=g3xTcJujTKd4w0gCctoLja7eSeuWTDDT4NFM1EZPhVw20aPkInjJcjY2rwpY+OiyXj Cbw3WRo4WJGwKcxJzusrNY39Vn+HqGocadjUig1JV/qiQyolX7USi5WDlrfbNfRjXVXW lPv7ghujSW8ptFC1LLT3OQaGoRD71hfvD7/wJDzenF+pFWWspxa8XKJ7t4cfXoW3gtmI NrAWUVLnyOTkkReOMmV+G7lL+BHZbvnMizrnzGVxHNOWgI2817DVIXyMi68Wxr48Wq9y QYdxp4vxDGVtaStjETNVIudJY310wA7kZTh8RwHcYED2lw85lJW7rPjrkbohXf9ck3Eu y6rA== X-Gm-Message-State: AOJu0YxZpil62NG+Jbog9uLYwEWlINxa6TOg33cwV9XpJfSklat7rogg t1eq4MiN3y1QKdtvjQGrjeiJAoerbGEQ6w== X-Google-Smtp-Source: AGHT+IGsco/wc6xKX5vo5lzmFcA2w842hBPgh5O17c6HmrxwSBPZRu/jKD563TwiQ42AUE9ZznEjpw== X-Received: by 2002:a17:907:8b93:b0:9c7:6087:49a7 with SMTP id tb19-20020a1709078b9300b009c7608749a7mr3289054ejc.43.1700393313184; Sun, 19 Nov 2023 03:28:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:32 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Subject: [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:09 +0100 Message-ID: <20231119112826.5115-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Chen-Yu Tsai , linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jernej Skrabec Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Sun Nov 19 11:28:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 681C2C5AE5B for ; Sun, 19 Nov 2023 11:28:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1AC210E1D5; Sun, 19 Nov 2023 11:28:41 +0000 (UTC) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by gabe.freedesktop.org (Postfix) with ESMTPS id A85DC10E1CF for ; Sun, 19 Nov 2023 11:28:35 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5441ba3e53cso4666904a12.1 for ; Sun, 19 Nov 2023 03:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393314; x=1700998114; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DB25C7bMVd6OfgWCKQSEO94Aa30Zg5F+mwrgxtdXDA=; b=adtEAxrvcdBnnX2F/aY4FKe0GBXC9Kx/6WCo6HxxW7fBvqvQUJz7+4ggqTDy+x3Uhf t2iLgEGXJIKpTEoQdI3N8G3NLYr2CC90X9zti7Tf9TJEvV6gmIuyiiEuT227t8KALzrS Yoz/NGib7dFNVdlY0LwwMorp1/zKp03GmZY4RQeWdBQB0j8F+GKypwciXsRJRctzoiFX anVnF9fUYx+scNLl/nO20Z5R+uH3UGt5s7rv6b9V7k+/zGLPKLsLi1mICRUwlwXjzzTG 4Yt6br3mFoiL70n7DaUxGnfocRnrzF9DkdoVingDzIUfOmnCLVFVPL6kr5btqBv8sY2f V6Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393314; x=1700998114; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6DB25C7bMVd6OfgWCKQSEO94Aa30Zg5F+mwrgxtdXDA=; b=ANrFMngvs2OqDW4sRPzOelNdtv10TdMdVgcxZIF2yF5N8PUUOAqZYu7f1EtD5SAd5n dakGs5oFBliTlAYpP38w5Y/2/ay+SAD6TDgo/A7SrJQNYD0DlMxbz+Wr0/E8GPRtANOM IUk+Qw73V8La6HncX47xuVwhqEpLcADwb7e3QZVYhTS8KCTo6Vfb5ha9oyV5UKs0IFt5 YHTlOl2vzpGvmrwTwoeecuETk/gHMdnuCnunaVN0uitNIOTrL27F+kVZL7kfqu71s+ii ODG/Ilk/BwTA0mDFpZ9rEcoqBqghWWDO1j/qUxz2v5rfO3PRL+LOVFqqjwbIXJhbVKZV 2DdQ== X-Gm-Message-State: AOJu0Yy29zlY/rBRcrd0nN64d1ReHgDzO3cqfDZtQPyPOYiQNUeIJTht 1Hc2TWxm35747wMSv4IBQ7E= X-Google-Smtp-Source: AGHT+IH2fnvLE9Y6eVfFKztByCM9+1ZwApSr8kek3DtNxua0cNXLNxfmHPPCiBsAptA+rR6QXC1RVw== X-Received: by 2002:a05:6402:885:b0:540:9d0c:75fc with SMTP id e5-20020a056402088500b005409d0c75fcmr2974587edy.26.1700393313913; Sun, 19 Nov 2023 03:28:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:33 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Subject: [PATCH v3 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:10 +0100 Message-ID: <20231119112826.5115-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- v3: - fix compile error --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 15 +++++---------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..bb048e14b 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,27 +158,24 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) printk(KERN_INFO "i2c-matroxfb: Could not register secondary output i2c bus. Continuing anyway.\n"); /* Register maven bus even on G450/G550 */ - err = i2c_bus_reg(&m2info->maven, minfo, - MAT_DATA, MAT_CLK, "MAVEN:fb%u", 0); + err = i2c_bus_reg(&m2info->maven, minfo, MAT_DATA, MAT_CLK, "MAVEN:fb%u"); if (err) printk(KERN_INFO "i2c-matroxfb: Could not register Maven i2c bus. Continuing anyway.\n"); else { diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Sun Nov 19 11:28:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10FC4C5AD4C for ; Sun, 19 Nov 2023 11:28:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 572AF10E1DE; Sun, 19 Nov 2023 11:28:43 +0000 (UTC) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9E6810E1D0 for ; Sun, 19 Nov 2023 11:28:36 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-53e08e439c7so4933583a12.0 for ; Sun, 19 Nov 2023 03:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393315; x=1700998115; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=nsJCRXQfiKMfxrblMcHM7UoioSJR/jn6wU6I7oQSFVMV3jH14d9CMyrmCbtYv8H0oB MxqrX6MJFxqIWJ2mtOlJK2+eBSNFagnVR3qIjybtcJLwNxoXsoWvhWry9NmaZV1BBg1E jVqIhsfwIXRiS1dgZJs25+26p3vr2FA7J2CPtIZj67NMoA85IvhTO/bdW9fUQls61cKq jT1kc5iA4qTKRDbhzUo24+IDnhUQuueZLuP2c6NWUxh/iMQh6d6lg/KmnkH74J2j8oCs IJZT/K+NpuU1BX6TwoMhFTY4zScZFVlkc3JvsUcGJ0rbOiWQxBnHmSSRl51xOLaCCKHU 8qJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393315; x=1700998115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTrCOgNzORg+kX6P4q5KSwq1S4WQ2CSsbEPwGEitBjk=; b=T8e4gvkuICnH8yzQZ5EMlv7mUrZBDuiCqe2o2qnLxUObE9CSG8sXxKfo+prIPkF3Sq GOB+GaSuKdI761L6C1dYv1va9CDFCf3oZhgiz0sPUcDWSkjD3fBSuMCFScpX1KkmSvZa hnZOjvBF1BeQI52MKHwEogV/C0r4TQXfKzJZo2qmQQuvhfUaNH9dIjCLAU90Zh6vyKBi SwPcboe2xIoTGtzL/2znPuF0WoxSUYst2dcCReTmyVfNerVWtljqoNczPtbm8aMxOnvJ jYVFbYM/mgwjGwOzqmcv754WgbN/gJ47zt0fLyOrOZLYg8DmCYnBQMvuYVV1EDTSDbFo Va/g== X-Gm-Message-State: AOJu0Yz+Gvza/sqPFQwZoo7WgOccT0z3RK6BEFE4DXFc5QNo2Hr3+HEx vB8V2C6eggDDNkB1KtCljp2xVI2TBuQVWA== X-Google-Smtp-Source: AGHT+IGjalgverwn4S+5/ObyVC+zY2/IsZIJGBRuqRZihGBcwWfCh8FC+wiaF3tbr+HAjd7T9RyHjQ== X-Received: by 2002:a17:906:1b:b0:9e2:af56:c380 with SMTP id 27-20020a170906001b00b009e2af56c380mr3594717eja.6.1700393314983; Sun, 19 Nov 2023 03:28:34 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:34 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Subject: [PATCH v3 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:11 +0100 Message-ID: <20231119112826.5115-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Sun Nov 19 11:28:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0830DC5AD4C for ; Sun, 19 Nov 2023 11:28:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC2CD10E1D3; Sun, 19 Nov 2023 11:28:41 +0000 (UTC) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DD0410E1D1; Sun, 19 Nov 2023 11:28:37 +0000 (UTC) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-543c3756521so4657524a12.2; Sun, 19 Nov 2023 03:28:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393316; x=1700998116; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=XkiULVtf20Bn3eEyr64K7RWOsJwqsL83pqESsvQSgf7xOdfuYctByVdBsO3Jy4Nxc0 YxC9fkmHQp5cx0b6MPXssdxtgJwUfRqNN65Gy0ozH6XL1h4tfdSUgN3chE7wagXhpABS WRmh2k1ivYnN05MF2TNzqnLvbxm+UIV4koLnm00d8wxXaqS7tY1hcsRMhv6e1PFeVZIq XM7IdMR28dKKo1rzNuoCCkYvJ/K4c3Am2pM5XqAEbaRClk8bWoU4XVkH5dTMN9m/isZN XleBNbdIHTYE9sKRbVIohq9yfw+oj6+p+p4uY6qdem0osw60IPiTQYizdL31D1C8+mVl I5yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393316; x=1700998116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=uz4sSJzh51MYNo4mmpOZO81pcrdlVY2f2DFHEnOtgNq+2Vny/Bl36JmOWDkhGjCocR FEFX1W67Oy+s38MJ38GzHqg1Xx7JFLDsvv5Kx3EDtBnXwnl7O5l61nc87CPmZO3hqjtr A6NxA9I+boGYi3Tex3l1nbkJReBFecmTmn/FkfDuoPnnDdUUBiNbMplti0tcOEznACDM ru0lXHV0Euz1JQXOV+KgcNqOi9AfpSFicGIBr/IUkFkyyIOXwHEQ2RUq7AvoOdPbC+9u hxARXPjO+EpYBD9ZzPcTrRjlhkUwxGEq8ZH4bpbWmGUmMODiMBctDs41+ZwQluwn6RbP 66ww== X-Gm-Message-State: AOJu0Yy0i13jhrcD5yG1/trDrIXs97KhCNap/PPdCkHW9PeCphjhuOnC 4j6ZS3n5Ds9WXY6mrI9IQDc= X-Google-Smtp-Source: AGHT+IHI2Q6G5KgXpMdvYcK+AMXMsl9sksekFidT3A1JwDhyvE5DtqVUCJVruR3PsUB6x6IR6xT6Zg== X-Received: by 2002:a17:906:74cb:b0:9fa:783b:c197 with SMTP id z11-20020a17090674cb00b009fa783bc197mr2843048ejl.13.1700393315790; Sun, 19 Nov 2023 03:28:35 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:35 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Subject: [PATCH v3 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:12 +0100 Message-ID: <20231119112826.5115-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 11:28:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8102C5AE5B for ; Sun, 19 Nov 2023 11:28:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E677410E1E0; Sun, 19 Nov 2023 11:28:43 +0000 (UTC) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C72E10E1D1 for ; Sun, 19 Nov 2023 11:28:38 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9bf86b77a2aso469973066b.0 for ; Sun, 19 Nov 2023 03:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393316; x=1700998116; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=QqtvF9y+7YCM94Ee2gys1QLUz6hsaGCkqYApO80dQ5K1P3FzQ9FLgVL4qDTohQasM7 fi1ocZa8Sv2GW35E75HFWlVWY/qHOsMehvZqScr/XW6CxweH5tc2XsU3k8W6ziov8sx2 LAa7TOG/jnGsl/RiInHXZmRZnyezysZqH1tke8sc3dDeJ/WpvSV+qJfBPVh9SuvS+aBW +dkc69F81cpr4Uf7jSanVsjLJjWwKPfM3YrUbFbw2y5AVAeaSKD4lBXhVvL+qCglbEiO D+LuKJEuKYrMwrd6tifdLOksNagvXm6BS8m6ajRrdUBl7SmwJQuag8y0vLljdCTHkMxJ lSyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393316; x=1700998116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=IHMWp7S/rihi6BVD0+22AJ8hyxSFSLoG+tKu1IKQhJG/2PuWAhJXSWk+UXbkCXepU2 kUxOm1mJ61aYTm8QhXQgL4j8Trw7bFD7kRXZm+ogHev2FJNDbVrQRwbvxPWOShEgnV+s ai4XUiuepj5YfnTH/CvJxDBxarafKze1upm9KRyUXuTH9KQoNxPgQJ5o7z6q3S21kRy/ 1Yw+laN0naNkwVLODe3dmWKw7gZwJ/eyCxpCZpINmAJ8OZOFM/HS2HeuWJLhWHffwLOb KTR9UeDAWTUa/GSzICrijcwyKJ/OKFmTklD1xQiEi0DA8m9JpPBtqF05lDd7pA+ZOpZf +CHg== X-Gm-Message-State: AOJu0YxEoC9x5CAV7b95nruE4ZtsW9mbKhVSiSFjt9x2tR8pb9OIEZz/ FQUWzR2r13+VMwTXYQ480Ws= X-Google-Smtp-Source: AGHT+IFAzJyXCJEw3gxpP4VAZc4O/kxe4jDCoc7MCgJsBx9nZyrHJVYwUkbM5vIdYXckmNcBLAEJ4A== X-Received: by 2002:a17:906:51c5:b0:9e7:2d0b:8c41 with SMTP id v5-20020a17090651c500b009e72d0b8c41mr3246047ejk.0.1700393316640; Sun, 19 Nov 2023 03:28:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:36 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Subject: [PATCH v3 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:13 +0100 Message-ID: <20231119112826.5115-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Sun Nov 19 11:28:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460402 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EF74C072A2 for ; Sun, 19 Nov 2023 11:28:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D98F110E1D2; Sun, 19 Nov 2023 11:28:41 +0000 (UTC) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A58610E1D2 for ; Sun, 19 Nov 2023 11:28:39 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9c603e235d1so479277466b.3 for ; Sun, 19 Nov 2023 03:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393318; x=1700998118; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=c6al4HvQMhOyrwduPG4xTeIzawLllWUbeZ7aDTWTo7/xsVxau9RycKYE5UgmAALn7D CtMfRM1NLfq1xSWOCwoKWTCYAKZBg/9h7v7Fc1Zii/BiAnm5oJPEWjC1zaGP60yZ+G5u GWX4WnXuui9LZJ3Z58CAiiFBbk83hKtMoC3Di/HdoXsD19m9fIbdrPJaWaThL0AstXjS e5Eye0q5uv79nw7CNRyM+638IZJSOA218g3L+8C2LJ5/q4Vao/EOP2mHhqP/W5xN1WOj EyLroWSWueXBGRf2Z5ArAyF2Wmiv7WVatYOVQ7uyAUORLvyvhphnurFL5if/xlNFuCHw 1R5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393318; x=1700998118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytoy8pfr5Vxi1e0JcRyR6n1bj9XY0g4pH3ARHnOackE=; b=jXNYEOPPpRyktlOqFQEpUsG9wYGllUO/LMaTxU6a6TN4U0SlmvdVy9NTWiOneo0SrJ vYOLSU3DBb2xATc4SbcI9zTgBl+4xGm8+k3pATnWhuWrY2v1oveRLAkYet9e4nLFH7vK 5oArIRnAfPy10D/nQpjT2DsB3PIu70+v1yzrnnCwk3UZuhEX9aayqbdaNPIrVvn/P94X mkeI5WYx4lcxGgCMzf7p8loXBYBg9bVf45mJ1Giv2lsGcw7dvQq4M4DuEROqF2oJn/hb QfoluGz5HzbkqRf5RaXamsaOiP21RaEhzfAyJdIaek+R4jWkwKP0jmmu6WL70R97hwsU ievw== X-Gm-Message-State: AOJu0YwG6DEoW7ninT7HYYwEB66KaDI4CcqLAYVeKEyrlnTU+q8wu18z 3J5bkAl0p75dGccrFyXukkA= X-Google-Smtp-Source: AGHT+IEnmNpCAkcRrOzwrSosgUk4OeD4St9qXEp+f9gvbMOTGQeLWy9ztO80popOTUrnH8s4A6uwug== X-Received: by 2002:a17:906:520b:b0:9e6:38f2:8439 with SMTP id g11-20020a170906520b00b009e638f28439mr2984313ejm.60.1700393317363; Sun, 19 Nov 2023 03:28:37 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Subject: [PATCH v3 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:14 +0100 Message-ID: <20231119112826.5115-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Sun Nov 19 11:28:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460408 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C91BC5AD4C for ; Sun, 19 Nov 2023 11:28:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D80D10E1DC; Sun, 19 Nov 2023 11:28:43 +0000 (UTC) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 254E710E1D2 for ; Sun, 19 Nov 2023 11:28:40 +0000 (UTC) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5482df11e73so3121468a12.0 for ; Sun, 19 Nov 2023 03:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393318; x=1700998118; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=SCDC2n0qZLB+i9e6+xtodVyWznFGI3PXmTn2iEFrBENYIYakxPo+A66FJGJ4OQG0nu amGNRdK8DQh89qaPt0zlyTX7gJIPNw245mZwl0rCSo/E0JJYiFrjz1WbNhWdxOuzGIkS 5fe4Hma+kT+6QJTZEQ8yBeGDwNM2vH8oq+VlzsmsWtIJY4kZ0FHrGHeVSioEEahKlLTn JUuqhNrg4Ee53Ll98eWzrCCMAEuMQj+sSfPZBYVjbeYfuHGT0lHHe1hXNDnJ0esO7VsK G13BY9Qu2XQ6oFhpP93u4CNNNgQYcoLlBWD4k8Rbge5vET9z7lQ+pk7ippnf1QmdVAs+ jeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393318; x=1700998118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lj6lXffwhPaiA+tttg2gWfCsavHU7fIAFEm3bWLvYqY=; b=WVmr+czMqBt+VY/YhDAfC0dwHCEda4rt9QFTVTsEeQMUyWi3ORi3ntgn2lttNwiNFD 3DPk9Wb2CpDdCNgtEKdZKnV3tuXABKWR8CGPI080lUxPkwRhMt9DfnfrlMOoOe8nXKUu MsZa0/SvlQLQq33KfvbRjouB26X/pf1L4fs3JmP8oXQhOoAu3I/GwRKYOWrfCYybdWTm X7VXAJ9rNN1U1ToMQbyzuGZZbkHrEFLQupIFEKIkqnHya2u9pwl0jdLhnF5gndvwVzdk ZfuGZWXdozhUMI4m7zXMtBnPvW3l+3uTMqzQZenyjIyG9TXL5DRQQGBGIqds1KN/+xdk kMlg== X-Gm-Message-State: AOJu0Yytax7z8st0dVarwwJcmzj+1Swgjq39pmp2xg7wGJmBS33dgUKl AOv8yy1zQel8m/dyajtJN18= X-Google-Smtp-Source: AGHT+IFZggot9AqS3X6Qt+Jt5dcuKalJ7+U5FRGLkcM87LKer+UjD3CjY5GltxnAdA4qRjb5SMpr7Q== X-Received: by 2002:a17:906:10cc:b0:9fc:1236:beff with SMTP id v12-20020a17090610cc00b009fc1236beffmr1696210ejv.65.1700393318307; Sun, 19 Nov 2023 03:28:38 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Subject: [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:15 +0100 Message-ID: <20231119112826.5115-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Sun Nov 19 11:28:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 892E1C5AE5B for ; Sun, 19 Nov 2023 11:28:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51BEE10E1DD; Sun, 19 Nov 2023 11:28:43 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B3D910E1D2 for ; Sun, 19 Nov 2023 11:28:41 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9e62ab773f1so479662966b.0 for ; Sun, 19 Nov 2023 03:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393319; x=1700998119; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=EPpuKc1D2JdbVTQhybJ4YlA4G5g+vkCuRqCZu6/gfaBnxImIo0mu/D0CDJ7IwrgNVv xZisRXW3tRQ9ueYW+xiXbbxz/QalslRRDmOz2OK9mC9I1KibOaQQs9hNTkiB4Sqxqr0B tGo35lvfIzk1NFseAx66MCsmI0RQKomjDWY9n6qvz6iMWGnmhbgr7EEVUrRonlyYJBD7 EuRtNyj7vopV5RwkuzE0cJgBcQcmwczvQd4I7y3XySHInslkathb5DWH+IbQQdItLe/M agnYf610uE5pZhKqOjoDxtT/ahdAgL0rBPmmLoGI9sebPCL/BvigsG8IisTKWEhg7TfE 0Ivw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393319; x=1700998119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x0UShpfjCPfBIWng5J4/pQaeext1SYGd0ovoJY2VHzk=; b=uukvrYV1rujLGDvXBFk/ezJ7AiYVUE9MUB8d99N6dfyt96zQCSIGKRYJA2UEmd9+ZD DxEyo+Kk5FID8cCy8NQe7UQtkgfyH9nppdOMaUaxXS6MjisvrIEm4NZrLrC8mS6u8XRq yMJcMBVSJzMWBleAMnpiM2O8lxhxfsV0tDNSKweXuwbsbuF4/xSzy3zdeSl84GMOMNGZ 96EAo5s7cg+i8l+v3ofGEOaGN2QdeRlQtfgyqE7IkJ2k+ljw/GI9FSA1T1Z8ZwY30uZd D5lpZTgtGd+weGHhcn76ih1D/WnvDIPNnZc6qlcc8vmjoP7KHPkebTUOi67UiJbGTRgi 0V8A== X-Gm-Message-State: AOJu0YxFPjmJPUOuiEBYGB2Upbb0LZ3ORb/qgdJzePRU4g9ZgquoeGGO BTmpKuergnlOF6pDgTpdlEo= X-Google-Smtp-Source: AGHT+IGW8bdZ2RS0eD/PKhlU2KiBuoc9GKfQcR1+tjuS9TfpWDLNx8Ift2fVRfhA8+J2YatXx72CBA== X-Received: by 2002:a17:907:3f8a:b0:9b8:b683:5837 with SMTP id hr10-20020a1709073f8a00b009b8b6835837mr3412002ejc.46.1700393319210; Sun, 19 Nov 2023 03:28:39 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:38 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Subject: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:16 +0100 Message-ID: <20231119112826.5115-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Neil Armstrong , Robert Foss , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Sun Nov 19 11:28:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460415 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D692C5ACB3 for ; Sun, 19 Nov 2023 11:29:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FB3110E1E7; Sun, 19 Nov 2023 11:28:55 +0000 (UTC) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3778210E1DA for ; Sun, 19 Nov 2023 11:28:42 +0000 (UTC) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5409bc907edso4725300a12.0 for ; Sun, 19 Nov 2023 03:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393320; x=1700998120; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=Uo1YR0vk9ssKUoa38j7r3nz5rvyURP8LND59v2Qf8xS5ZqVS1ykA3u3X9F599f8CPS VUF5rb8xpwa22PAGayK8ugObsNF1Zb/Q3Y/gJqEKNhKlKAyoA8flY/6phjNL3YLC8S79 IDhDuIlEOfc2ja9ZGnBb+L/db45wzm23fHd7yhUz9rfx8b5R4Z7P0yeJu1vPQnJ9Hv95 VevQGSNO/pZ0fiafxYQ5UFi67t8CoU6fTp5tGnNc7INLqiwYKjHSfN70s1BIBl3ivAzo 45fObhrHlj4ylauuuzgMWAMYij7MlcC1nQsNjFu1o6EPTb/H7fMOStvtFEE1184Yx7kr knDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393320; x=1700998120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihe5CWoYwzVYQa0PIBn4FXCZubjqfqZzL14QGGmAy2E=; b=M/+NYrWwm39yxAUH0vML6HYsImq+zEV3nNZEgeN5iXvN58Jnn7Pv+N95h5aMEp8ug/ cOmws1duskgAl4bgNkelPivJZlZBrH8ApRebGuWZ/vl1LxHBrEVieA0rDFB1x/9PvVHZ Y/izE1vqnwQe2v1aQJZ5REeqn3q+mr3fbne56AfkDziIjXlRXw7dZ1MhhnyRPPcsVcrn tbcBpM00fcJEB9UpCmkiEOFvx5ODYjAaJOYeMoSvfZ+UsNgkzmptUAxSl+etJpgXGDuL SBwExxrin8Fo9hDk9BGJPg1Ndj8Mw+0O0/VNfdEGoBxihJhf6FaMGzCXjyiT8RdqbqAK 1JIw== X-Gm-Message-State: AOJu0YyelCazQ4SWwbKM9UBrfBc49Mlz2fMYJsJ/xcN3bJvcGrlMFQ7x 8Oeiet8pBsaUpcmNiBb1viA= X-Google-Smtp-Source: AGHT+IE+w9pgQvDl2Y3wxx8qGfyopeIAjzUYE/Lxfmit0zeTDVBO1PBeuPJks8PhZkZ7FJV0jaU+YQ== X-Received: by 2002:a17:906:7396:b0:9fd:8da1:5c9f with SMTP id f22-20020a170906739600b009fd8da15c9fmr571228ejl.15.1700393320105; Sun, 19 Nov 2023 03:28:40 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:39 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Subject: [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:17 +0100 Message-ID: <20231119112826.5115-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Sun Nov 19 11:28:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460414 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84536C5AE5B for ; Sun, 19 Nov 2023 11:29:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E3A010E1DF; Sun, 19 Nov 2023 11:28:55 +0000 (UTC) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B80410E1DA for ; Sun, 19 Nov 2023 11:28:42 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5437269a661so8799557a12.0 for ; Sun, 19 Nov 2023 03:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393321; x=1700998121; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=NPOg8n+Q3DN6ydULSd22NuLfXs7H8xt0JQkdx6uyoomDPD6rqesvKfgG2OnOkgpZk2 /dHzDbGrAbez2+SKUI/GJ00UXWJDNb0Rx4WlzEXTyYGG9Szsc1rsPXo9tukVPhcvQEV7 MfXezgjS5I+3xregpsfzdQNEI4kxDpT0KeazRLHoBEYJy/OZ5N99LfdYugCJVsQfVKSS 1/y//zrZs4RiedgukrUWp2frbXRt6Aa5EVeGg91hkaQKunOJhoZkdZ/+dhv81k+QNvta 2Xi9FBVBAh3kem/qsH/OIu9Yawm7+SwPJOwvBTrzDv3IBpTcmyFIKr80ChfHbTV922wj V0Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393321; x=1700998121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=Ed7Jg/Tq2dqyJ0BHzATiSJdus32EfYqAsvjNgOEUG6U4ovH2IQclMSOj0fSg3IWrvy ooiAXru9paAjzmm0yLNsKDC7ieTt/yWAw65XJ1fmW/iqsEwHo/NrbU3pPxz2T7jPoxXj 60c+xrXxgMmC1sPUgsno2xccg4ar8ZweNPrJqqmA0lb6/j+CRlf+4GM65cYY//g6IcGa LoPArAC0ebbLe92fVMGDFQuQg/xgqWnY7on+jK1uIvmSbbS+qbrzF0Su3RwwVJMsT0Ou Rt2vSWEGDCVlr7jyRQJHgi7i0C97EBxo+/jDuWqeoOT8e1bzU2exKHVDQdvxwsAY2AYF TZhQ== X-Gm-Message-State: AOJu0Yx5SaTPoYmuIw4YB0F5ubkH59/xYWFI/MqjNCUe4woPsD85wouW D4FAnUWOtoeDZ3smhB/Yw+4= X-Google-Smtp-Source: AGHT+IFOQx1CLu4gRyNAZImWfbKRXYxuIkAJlM3SnSjaoqSkAxs60CqJJdA60K/QCwcTb894UlOqCg== X-Received: by 2002:a17:907:d21:b0:9f4:1bd6:2d26 with SMTP id gn33-20020a1709070d2100b009f41bd62d26mr12971501ejc.0.1700393321074; Sun, 19 Nov 2023 03:28:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:40 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Subject: [PATCH v3 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:18 +0100 Message-ID: <20231119112826.5115-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Sun Nov 19 11:28:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460416 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A805C5AD4C for ; Sun, 19 Nov 2023 11:29:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 283B610E1E3; Sun, 19 Nov 2023 11:29:18 +0000 (UTC) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8F5510E1DF; Sun, 19 Nov 2023 11:28:43 +0000 (UTC) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-548696eac92so1644377a12.3; Sun, 19 Nov 2023 03:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393322; x=1700998122; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=g1ufn48LKTMX0XvhRNy21Y8eGJzKCWeKORKNa5V2XuW5Ttk8VOysaDWWZOyv7Yl5kF NN9WhRw0VFJST2VmAkvRkF4F5hXefbQ7Vp7ce4Sp54TV+aGJuiL3fSXvGaY77ZmxOc9N ZapiC9/+TiHM1qlby4bHSUETo0wJc4PCes1FFF80+yCpLHogsA7FL2/boLWF7V89KjIN o4YTLsuQU7bES9mJYDp2qhS+clPJZ05ftgbEZZa585xnQ7ABhZUbTMPZd7BfHsanhjY4 L/Nbl+XZTLXws7f07XCEL//f5HtnAEkRa5kAhv7/xPYdkvxQQY+UTVJAv6QYIamxB2VG hXSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393322; x=1700998122; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RwYQsxTIlPnpbp305mlbq5GplvUv/n/Jh48i1GH8+AY=; b=ABax4eiV4CG7BazLgvPz+0vjT2c5kQgxFUop56sFHKywrezQlSv76H3pO2CfAbhamH 7SmpG+jqVASKH5hmhKi2sziksrMzNg3oGnGvIb6zPrPCOBcQRiRUg9A1Hkr2Cb3MEtFc FeBnRKVwaEZARHa85baqJ3f4uH4puBtj+fubOKhRJHbn6OY54EnHQR/BADu8Mlv263gq qtelG2fTtj0x4qvkzKRz8NS+mniZx64CG7WvrobpV+R5oI/gF7XxU5QeDIdTghZ4CbHW dJBwCmKvtVYI2cVBJSfZ6mfGbWyJVgssIpVvYxI+LtGAvhJkGB9gnjgU8yynclgeok4i KKrg== X-Gm-Message-State: AOJu0YwzspED0h5t1DUKe84LYdL8IyhNXtCpJ6CFrKWlxJTjT5rXPQZ4 dz7xy2gJk2i8LST6zXMjwOA= X-Google-Smtp-Source: AGHT+IErpTouVgXqlh3TisiJyv9Y7lrxQ2t5uB7O/C5V8sCHaKfqSNKhBvmGLqTZ7BYeJj6wkdbyzQ== X-Received: by 2002:a17:906:1099:b0:9fb:d7cb:6e03 with SMTP id u25-20020a170906109900b009fbd7cb6e03mr1924992eju.20.1700393321970; Sun, 19 Nov 2023 03:28:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:41 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Subject: [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:19 +0100 Message-ID: <20231119112826.5115-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , Sean Paul , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit Acked-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Sun Nov 19 11:28:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC6F2C5AE5B for ; Sun, 19 Nov 2023 11:29:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3F6F10E1E6; Sun, 19 Nov 2023 11:28:53 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 859BF10E1E2; Sun, 19 Nov 2023 11:28:44 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9d216597f64so465832266b.3; Sun, 19 Nov 2023 03:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393323; x=1700998123; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=DU3Poux8VJSwHrI0VFEtnfCwmZlZau01PNZ2Q1F2TZ4OzNQz8sYCsfTFCMQJ0rROCT StzQ6OuThx7oAEVqYfuFfCT43pDruW/5XNw+gzgbsqqU3JO19EmmcsSTgvlEDwWhmmss lU5i/IUJyYoEIxIIOKlY0Hok/L9s7XroP69WDIzozYZ+YHQEM0NF0tsX2TwOCJmXYMIX ZEYtGrdLvlEr49xN/8s/RY+k+PMY1WTYzZH3JMz+IuuGGYsjgm6boxuUkjxw4LSVurZH H+84lUmn1Hg2P/e7FnZHyKjMOKBByppAcWOgSPBfDGJgqg1eZTpqgMoV1Y3li1AW3O72 g6ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393323; x=1700998123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=BeRxGYPBFTZejiyS/r1GXf2c6yGczAMM22634DuDni8Y/vqKwCdgf6k2rXZO+n9pYI inygkkuvm6+NvrzH5mWh0zVoO+BV43osYy7USELfQH+/Bnf6PaspjeZKPKSe3r8t34as WxQ15qqczzu8ibvRv3qvwQTLTI7oaM3gsPJm49ba/xmPe3l1P6ScO/YhI5KxBYaTu2XE qxrI3V3elrGYcCNC4UDRlqW9oqK8lfXmcTlrYksD6Ex8l2MKO+1HN/CF4o5Bz0GV9tnr Ke6VgnGyNPP4IwV6H7O2bKN5lXxsVvJpGtO4r6gY/z+TGrb41cuwbBIxxE117t3vXG7b SgdA== X-Gm-Message-State: AOJu0YxUO9H2nMEPW9r5xPyB45/rhe9IiO2HMXA4nDTEcHj4yJlBH1Ur m9CTdkOhuaMv52jHESNCoRw= X-Google-Smtp-Source: AGHT+IF98s8aEn0w1sgMJYs8s2hcKMxZPSkooSx15XAU5tgESM/m3QK98+ws4NtnHf+xbrajq9DL3g== X-Received: by 2002:a17:906:1859:b0:9e8:2c4d:40d4 with SMTP id w25-20020a170906185900b009e82c4d40d4mr4394226eje.30.1700393322803; Sun, 19 Nov 2023 03:28:42 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Subject: [PATCH v3 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:20 +0100 Message-ID: <20231119112826.5115-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Rodrigo Vivi , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Sun Nov 19 11:28:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460410 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE54FC072A2 for ; Sun, 19 Nov 2023 11:28:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A96C10E1CC; Sun, 19 Nov 2023 11:28:52 +0000 (UTC) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by gabe.freedesktop.org (Postfix) with ESMTPS id 649DE10E1D1 for ; Sun, 19 Nov 2023 11:28:45 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-548b54ed16eso121498a12.0 for ; Sun, 19 Nov 2023 03:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393324; x=1700998124; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=mhj610T/tFWoTDM/7okNCFL9NRHD3v0FhKSJfaEbi6orxY8Ub1TJUXeewCWO+n7IMd +K2WDYQoveWXVOA11ppmlzCTgoCeP7pn70tisaWT33buPVmDJqH1VfvirUEqIk/PgPEi j5e4PWusbbmkMz3C9qdesTcEgMBdW9ZepcNo2aF6aDb4q1qdqpJY/B0fbW93sPTLG3iK 5V8tLiZ7bmWU0ClvNJ4OixQOFADutlWylhQ16NWSvPPr/7sHzRxIz6X5rZcriDQ4lOaK OPhsEEASpteHzjvdvV7+sB1zAHONjFQzKkhGe4TEfim6rftCDv4tPxeTuDohwQ3miwfC pG4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393324; x=1700998124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=JAu8UqRyI7nIidW6RNc/sSV3cceUux3rbDNCfcWouWEmi8Yuw1huy+aSClebaY8Tqt H/WEGblAR2eae0klcQ22KShgCk/h4pGOLOSCz/LG/+1YB1Y2QHaJZtOHraxvojWgAeoO CiYqRk5opMhNIsx7BHf0w4DCkeVjSsAdUtcws2dKKtztLIW733rDzDwdSxsUX6P4P8nI sNszXUkkou/7N0WAcjDi+7GhnmAWMkj8O4T6V90GZspdT/IXOijxePSfgs0R8X35Ns5J H32d9OkKnrILNgwi4U0dtbc+IF867UVBb0Nuj/U+GTAOLgk5l0b4SYgCNg16hdpnn7IF UcuA== X-Gm-Message-State: AOJu0YwI7M3cLO4+keIEcKCu+cluxvuZBlYMjIiYke0K/pyThxGSZ7PR Vt5yvnNOR4J+Vwr6k7k9CWs= X-Google-Smtp-Source: AGHT+IEvkXiyvHrlLOpdjdZVnWlbUgrD89NC8HGpVTBiL34yZJObBE5/8pr84pk4cSZoZHrmT9MXOw== X-Received: by 2002:a17:907:1ca4:b0:9c7:5200:e4f4 with SMTP id nb36-20020a1709071ca400b009c75200e4f4mr5046586ejc.41.1700393323809; Sun, 19 Nov 2023 03:28:43 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:43 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Subject: [PATCH v3 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:21 +0100 Message-ID: <20231119112826.5115-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , John Stultz , Xinwei Kong , Yongqin Liu , linux-i2c@vger.kernel.org, Thomas Zimmermann , Tian Tao , Sumit Semwal , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Sun Nov 19 11:28:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A505C5ACB3 for ; Sun, 19 Nov 2023 11:29:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34CD910E1E9; Sun, 19 Nov 2023 11:29:18 +0000 (UTC) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 328F710E1CC for ; Sun, 19 Nov 2023 11:28:46 +0000 (UTC) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5484ef5e3d2so2689398a12.3 for ; Sun, 19 Nov 2023 03:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393324; x=1700998124; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=ae3QS3eSQtfo2vUbwiVftuu8OjupILWuQQosrE082q7FJb7SbAgPGmoJdTdpkmcypg jWr5ejw1H1Qtcze6MGYFKHdWWQwj0DxX21+ooj/GAShpj0d1EqBf8fxp456UTKZmaIMa Jb45i5/Dqz/frGpMUCGkpqEXqUMOjjMvjFz98Ofr1HTO5KohXLg8mTwtfT8jZkFVUzqM EMLYp7rCcuOLWnaE2FxHymvGFUNLvRDj8m2ATztHkq2FUBWVA3EAAJD+8uK7+WtsFumQ rdBqJAarGsc1kpQmITdfBmyYsnitlLrq6YTtAjei5M1zpyN1OmSjzAVPK7sKrjIKXZwU a2bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393324; x=1700998124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e72KmLCJ3CDoJCk97GYas08RIDfDHJvByQpoDflcW58=; b=JZb9Io3XjrE4GMB2ODmJXvgzJ3aSLk3oIu6eVKvhp2G5QDamC3KLyaXELwaBkLbaJq fctAUQG4l5FXvfQvxXbyUWhTDc2gf6xQ7vEr1hsLyCcnkpfg1dhYIZ+X+FucNuRGlF+v zrPQI6PU1WqRTrTcpuI4KmE6nLuitI9+XSNL5eYcdyHd30t+5kixq03cJsLgQ2zr3xmF 3eUrwQ7kVMaX4IzyDCGCNzVZGPKE725P8wLFzQTA1h2Yvl5Pjh1p2qmYZ4oEl0HpUFmb pPQaZOmlsu/VnGVaD/1Iq1e++UikZKF6k4ml6ghNqwV+Pn48mqew3rclIEmy+Po3vZw9 1oRg== X-Gm-Message-State: AOJu0Yzw0++UGfl2QPTqr4x6bVy7czVePUNMdSbdarAj4eW0wIUsdCgS CKVwuEF3cbRsUfIJCFaWouM= X-Google-Smtp-Source: AGHT+IFb7FJqtaozsUjTf6lsnbfpB7UGN4+3ECKCKWY6V95FP/oQIeTwzIueiarO6eHMyVbgM8bRWg== X-Received: by 2002:a17:906:446:b0:9e7:3af8:1fd2 with SMTP id e6-20020a170906044600b009e73af81fd2mr3244286eja.58.1700393324637; Sun, 19 Nov 2023 03:28:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:44 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v3 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:22 +0100 Message-ID: <20231119112826.5115-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Sun Nov 19 11:28:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460413 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFCAEC5AE5C for ; Sun, 19 Nov 2023 11:29:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF15C10E1E8; Sun, 19 Nov 2023 11:28:53 +0000 (UTC) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F6C510E1CC for ; Sun, 19 Nov 2023 11:28:47 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9f27af23441so466719666b.2 for ; Sun, 19 Nov 2023 03:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393325; x=1700998125; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=VpCIsGl72hXd45z98EsX8meGao6Smo4HhpHNTV4Eyl9YQg5hOWZfGUZe6u9+oTADJt TqKvPvw6LjW+J1AQQW+M9oOTb521wKecUw95UDC5abplRTNTHaGEjdQgSLEvBGwgc545 xY86823d1J5AtsiyfU98pGiUMvLOJjp691+MLJcZvjJ5SX8DRhkQBoamE2+NnfXjdLBE gKuOYUj02wqGLkGzu6ECYNkDmuD1A1rx2IILl5MxIx7aOly8MSk466Zlic5omtwKe2Iq IP1sVDcxvTWLKn7Gk1I0e0c2cZcXocA9Qz3uiZOCwtV+62P+OuhO2Qug6kBISXgkZhQ8 P9Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393325; x=1700998125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=wyP2L4+A37MGy5Le1ldPLc5/L2eJ11iXqpmpAP/lxXEUP6GK/S/VWrbFMvY54BE/As 22kTkkqLOCwtW9Fxe6pIONRCjVsWWQ/+9sM5P0c8wnVLvOCsulwKgHesXa7zmYN1xp/l lazBf8S+NpDSepfIXeLOU+f3NLnFkyjXeVEyXHeyK83jwCkvUsFFLJQV6dktPZ0h9Hd3 IuWir1zUNgzwEsvFXwiUiJaWJkVDZ9VYP7ptzkAgN73t9josbzRU4192irRxN9R6AnZ2 a2zPUfTm8w7hafBNxkVDIz/UF6RgcaBj7ZeLWDSWsuUGheFALqlDq7FOXO9s8mg1CG+4 tmWQ== X-Gm-Message-State: AOJu0Ywst5j+L/Iap3R1875dV095gYWDyG69qhYNd9lOBqAX+uCDEXAA X4eMWrBcHFLZobKHK5Y6TbA= X-Google-Smtp-Source: AGHT+IEpB5ZnqGJppm4SyfFOjTFFzlNbJ5j1oKwnqCNhlB7TTiFFtmEVrL1Fkxgp4PWg2oSUQjk53Q== X-Received: by 2002:a17:907:9394:b0:9d0:2e6b:f47f with SMTP id cm20-20020a170907939400b009d02e6bf47fmr3500186ejc.36.1700393325493; Sun, 19 Nov 2023 03:28:45 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:45 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Subject: [PATCH v3 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:23 +0100 Message-ID: <20231119112826.5115-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Sun Nov 19 11:28:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13460411 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCC2FC5AD4C for ; Sun, 19 Nov 2023 11:28:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5C2610E1E2; Sun, 19 Nov 2023 11:28:52 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by gabe.freedesktop.org (Postfix) with ESMTPS id E6D2E10E1CC for ; Sun, 19 Nov 2023 11:28:47 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9e1fb7faa9dso476677066b.2 for ; Sun, 19 Nov 2023 03:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700393326; x=1700998126; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=ABqUhmxRia83k4OAXhi8w1QuUUHV++xcZlAKe4lzu4yO/8BQAYvcd6XJhble4WdlF1 zp6wtJzXnNeaYA5TMG1D6XEvlH/100hY5Sv56cFFoh8gpJTwC9zqQX/9cn45CFOANr7A bfdTzuhipkzzGPaigPE3gdxcdSr7GOJ2dz1k66APRMP8RyC5DgbP2x5x4vArbD2s39NP rWytUXS8/7671GPWbffref4JvT9b+3h6gRtwxho1VMIv6A2f++eUz985BQPlBZgbgntr Fw+dXzB7pk9yvLaR8sxKK7cyFl77/o9pdgHQ/SS53IU+FOCPGMhrM22vYGfz243NyOyf Dj8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700393326; x=1700998126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=PW9Z/Yh91PCP2M1MrVH/9xDqDUcVKRVh+n/9fY4UnvOgTKtM8QboYd63ed99PMGouI GINytf1RoxXTy4tcPSPxvpBPZXCrGQld5nJbqfCfxzgRVxksOGGJzRBRaJvMSEeUoq+w 0SnA6zGz4sTPfUsG+EiMz2/A7ua7gA2TJ2Dt29TmKqI5K+mFqXWLoqI+YhRKXmKF1cv1 JYf6D2SUD0nQy3blXvHW0BpPooJkBh7fMqYOYcvoEUCJao4DfIewZLuxh+VunZ55DRn7 cWPTTPtrfDIdL4N8kx943o8ZkxmgfBlF5m694dXg+UFMjBk/LWQofFwO9ux2mKKEOLf6 BNXw== X-Gm-Message-State: AOJu0YwlxfUsi7tYgEoMLd6fgmtiexu0yvXALjAkbLrVpRUFNTOhcHpX XwS2/ey445vKGro6Xy1r680= X-Google-Smtp-Source: AGHT+IHKw/gC9gJLG/4vNKZ0Qe1xoAFlXwe05kjZcQmwp8jadVTM2Ill34LRBvmTqhTjC6YBAI0o8w== X-Received: by 2002:a17:907:11c9:b0:9be:30c2:b8fd with SMTP id va9-20020a17090711c900b009be30c2b8fdmr3210885ejb.66.1700393326334; Sun, 19 Nov 2023 03:28:46 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-bde4-3e00-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:bde4:3e00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id k22-20020a1709063fd600b009f8af454d0dsm2420378ejj.112.2023.11.19.03.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 03:28:46 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Subject: [PATCH v3 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Sun, 19 Nov 2023 12:28:24 +0100 Message-ID: <20231119112826.5115-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231119112826.5115-1-hkallweit1@gmail.com> References: <20231119112826.5115-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Alex Deucher , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev;