From patchwork Mon Nov 20 12:29:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 13461171 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BB54C197A0 for ; Mon, 20 Nov 2023 12:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ctzpI3l7sdWNL6qUP9ORMytnDF3JAHHGlser/4dkL38=; b=YL0ypMaUOYtg64 UNaUtVYf/DyQQ3fKOr9mnHFQMKrkiaCJ+emizajXR5Oj/AB5gvuMbYqn7NuTCcEL3iv31QfzPG4fv Zc4o/ztTlanORnc7XiyUaXWiOQfJYxDFhSxizq+Q3/0q5NHcVb+cri/bx0Ex8CEVzDQbnVli1GQxX x7oxl+1nJZxz8aH5jbqzQCpajBXoGXXQ1BB5RGAnGOSiTdo1eIhdXWwjwbYODkB2Qo2v4QsJ2JX1I TJTvK6WoBgv4LPd3qL4qEvm2nW6JyIWakOnTW+qj9qsLAmrDR59MWk0IMx+p7K/Wx5V5WnZMA+upw yD2KICTPXrJ14F3uXdaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r53QF-00C09A-0F; Mon, 20 Nov 2023 12:30:41 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r53Pu-00C027-0w; Mon, 20 Nov 2023 12:30:32 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0143AFF813; Mon, 20 Nov 2023 12:30:08 +0000 (UTC) From: Quentin Schulz To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Mark Yao Cc: Quentin Schulz , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Fabio Estevam , Quentin Schulz Subject: [PATCH v2 1/2] drm/rockchip: lvds: do not overwrite error code Date: Mon, 20 Nov 2023 13:29:48 +0100 Message-ID: <20231120-rk-lvds-defer-msg-v2-1-9c59a5779cf9@theobroma-systems.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> References: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> MIME-Version: 1.0 X-Mailer: b4 0.12.4 X-GND-Sasl: foss@0leil.net X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_043018_866746_3293007B X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Quentin Schulz ret variable stores the return value of drm_of_find_panel_or_bridge which can return error codes different from EPROBE_DEFER. Therefore, let's just return that error code instead of forcing it to EPROBE_DEFER. Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index f0f47e9abf5a..17d8fc797151 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -578,7 +578,6 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, goto err_put_port; } else if (ret) { DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n"); - ret = -EPROBE_DEFER; goto err_put_port; } if (lvds->panel) From patchwork Mon Nov 20 12:29:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 13461170 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D8CDC54E76 for ; Mon, 20 Nov 2023 12:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gOA7V+OlmntMROCDF40oLLSljl2snSXSbiM7O8i/8c8=; b=j8qs1pd4KWOlwt W9Hw5ZaRIh4kULoeTkG3tiCvMXXq10WLVT5md0TurwQ+31T4b6G1z/JfPUVixuB7lHzMbn02dsKhA ABTwv/izq5BAlGO9DI70gvHwMWVWavL4sa1IjvATLAXnlSk4EUCtpWHEj9I4ciVYD4/bjBCckaHj6 YmosriyuaowOQRpfaEvqKQrL/P5wc37s/CCHwBrq1hnWl4eMnTV/gcIDRLDn/N3rN+gtzIsnr7hib HH0JZp2CLtG3hgMaDSj6LmJNQklsOyxeK/ZMLhVbvOJoB5fkIkEvpolp5Hx0T5Rx1/IAC9p5PX80q J2sCkAHm6Svtah7jqgjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r53Q7-00C07C-1s; Mon, 20 Nov 2023 12:30:32 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r53Q5-00C06a-0X; Mon, 20 Nov 2023 12:30:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=50pOZ0w3lX1kQsHW7UY2rCQqOF5d6MobisARI6xgQR0=; b=ACqlkRtcbc2kfifxQ4MJfd8Zpx k6xnB5yiUv3J6ve0OehLp5VwyLYOllFSpNwVGMZGsPoyvcfcG5iAch4GPd34J1RZkdcPodML4Q448 rgKLO3g7IDON+rSgQylg/a9OGXbl/TWEfqeG4WrOOOt/5qpPbP7z2QYZ+8UuwTfHX5Fbg7+mwfwBK Kckxvee3oKMYHRf9VsqX04Gkuo+1TL0l/ahK5JVxUfT239hyQOeJ1PemQcdbclPTuUnE1PLX5YBDT NSlBPH7ZsyVpOViEUztyvovvF5oYCJz3m8x155oZph4h3zMlCujroyPUK9sbmYNiEr0y3r7S7ag7B TGzUf3CQ==; Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r53Pw-00AxAL-23; Mon, 20 Nov 2023 12:30:27 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id ACC3CFF811; Mon, 20 Nov 2023 12:30:10 +0000 (UTC) From: Quentin Schulz To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Mark Yao Cc: Quentin Schulz , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Fabio Estevam , Quentin Schulz Subject: [PATCH v2 2/2] drm/rockchip: lvds: do not print scary message when probing defer Date: Mon, 20 Nov 2023 13:29:49 +0100 Message-ID: <20231120-rk-lvds-defer-msg-v2-2-9c59a5779cf9@theobroma-systems.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> References: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> MIME-Version: 1.0 X-Mailer: b4 0.12.4 X-GND-Sasl: foss@0leil.net X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_123020_985125_042B90F6 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Quentin Schulz This scary message can misled the user into thinking something bad has happened and needs to be fixed, however it could simply be part of a normal boot process where EPROBE_DEFER is taken into account. Therefore, let's use dev_err_probe so that this message doesn't get shown (by default) when the return code is EPROBE_DEFER. Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index 17d8fc797151..f2831d304e7b 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -577,7 +577,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, ret = -EINVAL; goto err_put_port; } else if (ret) { - DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n"); + dev_err_probe(dev, ret, "failed to find panel and bridge node\n"); goto err_put_port; } if (lvds->panel)