From patchwork Mon Nov 20 21:46:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA77C197A0 for ; Mon, 20 Nov 2023 21:46:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49E0810E1D7; Mon, 20 Nov 2023 21:46:33 +0000 (UTC) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93FBF10E1BB for ; Mon, 20 Nov 2023 21:46:30 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-32f78dcf036so3595572f8f.0 for ; Mon, 20 Nov 2023 13:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516789; x=1701121589; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=XZ5z0KpD9GZKiS2I5oh0KmwMFDF2KsFhlx48vdnQqzf4ujaw3XsMFIkl1QudlhsMM0 vfLsR/Msawe/klfgQJdgzjma0wG6KoGhGqFajzxNr4hKaOTFJy4s00FhxDIF2l2LDIFS dT5le2r6gSg5PTeu1Q+/+0NzCMSbgHUNA/9i4bkASXit4akYR36MZujyzu3GM57HCq1a APzl0Vv8gVRX3Sl4gi92yeAPmkWGKERbpmDYU2zruKIHOEeFGx0QlXI4InheM8H9aaoo 9aZyGFdEyGJ+aThRBIACg3BxOlz91TyLQe8qaiJfTtO+6bZ5Cs4OPawrI+bEj37HQRes g8yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516789; x=1701121589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flg3cjX3M0BMzkNxd6dhw9SgkIHrrzmjyvbrc5ZWO1w=; b=TcT1o8goTK8jbpEhZnV2idJiWvn0L/qRzX1SCnMS9bksCQQ/R2YX8KbuDzJpZ/p+Lq pn7et0hk4N1+KrhEv8KwSzh7877nA8QAPenN5coFXdEP8dtb5fULrslB9Owz16rI6R3K u3u+lrQx6u2HlenUZFIrfHkCGht1BFxlYUKGuaZtrcz+ckR8bfLAFpa7UfSTco7khgm8 NdYW4Y7LZP+2ivMjSExg2ADHuw4TU+52fgd849qIZqKw7JeAilMhQGElZs269crhHAaV LOoroCX1Y0H2ohuJx9tFHGn2Kl4LBHsDCvgPIvNmKp4Ae6CKPt1Xm0JANdPmNJq7DS5T snqg== X-Gm-Message-State: AOJu0Yw2MaPtGsQkVxF7frUSweHVAovU8/krKA4pEObfEZekUcKAQa8o uysHP2PpTOTWVRuaCTPkttA= X-Google-Smtp-Source: AGHT+IE5KIoURghYVkvfU5wQxiGM06yHQWDaD6hu7bxfA9LnXbZJ41nQqt1tLyyxToNmpgxikLPPeA== X-Received: by 2002:a05:6000:156f:b0:332:c432:b7aa with SMTP id 15-20020a056000156f00b00332c432b7aamr663360wrz.2.1700516788640; Mon, 20 Nov 2023 13:46:28 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:28 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Subject: [PATCH v4 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:04 +0100 Message-ID: <20231120214624.9378-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->dev.of_node = hdmi->dev->of_node; From patchwork Mon Nov 20 21:46:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC84DC197A0 for ; Mon, 20 Nov 2023 21:46:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE07F10E1E5; Mon, 20 Nov 2023 21:46:50 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CF4C10E1B9 for ; Mon, 20 Nov 2023 21:46:31 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-32faea0fa1fso2864778f8f.1 for ; Mon, 20 Nov 2023 13:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516790; x=1701121590; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H76sh9TJa21kiF09BweriFrW/UpEK7sOhe75l5gn76g=; b=Km5ODfGIUYv/m/A488BzNCGuN8O2FHY94a/N9ebvrsEoA7N1P5s7KFBWGVkQ6P8+XI hIv0ejYLWzHV13dGSH1r9CitqYWsFOXMYhFPD2BFNRjQ+ozSBDCJlY0vEQqIpnvl/kf2 +0996Le9KrD+hQwTC0Q1lyG/c9XjzPmkwog8R4aZF+5cFQVBJhRfY/DlwJQRkQ56vcjH 4RfNPsjHHOkz1huLXj0UN85qAk6aT9yfosEzzRNkOYIsv1d+EEcWauDLnlJy6tQ8mvaJ 9pybdegKQyY6V3hlsemBvz4VGpj9yMDjfchsdguV1OLTwuEpVzpd+VTzVIeS6psVgqjw zYYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516790; x=1701121590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H76sh9TJa21kiF09BweriFrW/UpEK7sOhe75l5gn76g=; b=h5smORrFwWDb/NkEdUQCaJKtgj9fXwhiw0V+QKNhK5/TzcBcTw6tR4a+uQ7Jehaixt sMZJCQKMUSF+EHz5nZ+HQ/gLJI54ifBhZHMPah/CTTLu8r7uFMtZnRiHsiWovDTJy9d3 MuV631ikoiRCaGXyMKsgosltat0cisgrOsJwEeO2lt5b13+SmZrRYzflgZlEDLzgl7e/ KxqcoLhy6Frf9hpdp314zJ6ywn0nKvAdICiEO6LQ8k2sDZITd40C9ENqOMUufvuAbSQP tJ2D3U3IlOe9CWAM6MozeBtIKNJQLvEqGOc0DwQTpygLWJDEyxec5sNygXc+WJ3Zl/4D z0gg== X-Gm-Message-State: AOJu0YykA8Zs0e2WdssWOyKHLf3bDydXQ2khaSYB58pxbtZ08ma3UJ/A 1cV3DwMZduTc9awuSdjggrE= X-Google-Smtp-Source: AGHT+IE2ErATm2xBrVPTmReU5ycJuHnLDpRJNW4Slun/A9h1smmlE3tedG4RsPPOlF2k6luf9dWXyw== X-Received: by 2002:a5d:648b:0:b0:332:c726:ed5c with SMTP id o11-20020a5d648b000000b00332c726ed5cmr612415wri.32.1700516789457; Mon, 20 Nov 2023 13:46:29 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:29 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v4 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:05 +0100 Message-ID: <20231120214624.9378-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag200/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mga_i2c_chan *i2c) i2c->data = BIT(info->i2c.data_bit); i2c->clock = BIT(info->i2c.clock_bit); i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 20 21:46:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99792C2BB3F for ; Mon, 20 Nov 2023 21:46:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A41E910E1BB; Mon, 20 Nov 2023 21:46:49 +0000 (UTC) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2295510E1B5; Mon, 20 Nov 2023 21:46:32 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40a46ea95f0so22466115e9.2; Mon, 20 Nov 2023 13:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516790; x=1701121590; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=KCV+ty5FKQ2YOgq9Hs/1j7wZr6s7xdYZYl8UBFfR/jtRtlyhPJJWc1kg+RYOFdJvn7 HlbZfu+1FPbt9ZdzICzpFYXkk9PN2IgpN/S/SAMfJp9rdq1poadnc2d7Q+2XwlvhtxL6 JvTPHClm14MTjWklHAgHhiNy8AGzhClDncHWtCAgGJ/5Y5fmgLTHq5KW5Z/+lPhAyfgf eomcgfX/I1M2oIZ/DBh7mb4B5rDi1kIm1RHhNvndoSOWfGby6Vcnv2pvhmjyGVtznBGZ G9RFmi1KiSjIhqeluhfPjO13L5s3EAak83NyD5sSpfPEfmLrqC2kVxD8lqbiJYl0WB8r cQwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516790; x=1701121590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cyZ/cbQESDC/MGT/kN0ThvfGObcymEWZy6uoIIRVQcA=; b=kfaR7VjCaq/L/dlhP+6X2tLxdX/xjG0KY98+BAB5ZEegVg4cw+osgvBozteUm7p1dl zPdg1qxem+vKjDBM9sqUd3BD2JGbmJLoWm8PROg2H+tM/aWXvy2MalFpiMy1A3dDfbT7 IJnFAjVmegGy7MC50WaCzhToEh72idR5hqcE2v59OTEUJhpOwlPqaTvje2WFW4NcbdZa zQDcEBZpK6gddKp6pYkgBa3zDWpej51MP4Ftu7ykTSZ+ehcGKqJEf/+0j5FqX5b7oUdY LZxhBvQcyqXb1L2u0dsB+oUPef+eVVDp3FHRSN9iRpbrY055GCVtex0yXxgmCyIDazs7 mZIA== X-Gm-Message-State: AOJu0Yx+tk0uhrMOBd1meNKnCLk4LhcjZa+Sx+2RXEIVtPGPz28OocNH mep2T3M8oVKcRgvsnvMap8E= X-Google-Smtp-Source: AGHT+IGkGQ59cG9edqQvwqmwpMO+1LuO35o+25wMSjuR193ctRjhKyTjuIwWviwx/q0Qr5EuxLxwOQ== X-Received: by 2002:a5d:62c4:0:b0:332:c648:c646 with SMTP id o4-20020a5d62c4000000b00332c648c646mr2880040wrv.53.1700516790376; Mon, 20 Nov 2023 13:46:30 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:30 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Subject: [PATCH v4 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:06 +0100 Message-ID: <20231120214624.9378-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , dri-devel@lists.freedesktop.org, "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner = THIS_MODULE; - i2c->base.class = I2C_CLASS_DDC; i2c->base.dev.parent = &adev->pdev->dev; i2c->base.algo = &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index); From patchwork Mon Nov 20 21:46:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B558C2BB3F for ; Mon, 20 Nov 2023 21:47:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A4D9C10E1F9; Mon, 20 Nov 2023 21:47:50 +0000 (UTC) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 077B110E1BB for ; Mon, 20 Nov 2023 21:46:33 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-332c0c32d19so1647657f8f.3 for ; Mon, 20 Nov 2023 13:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516791; x=1701121591; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=J7aBbuW8APLDKvLfpWFmuchVyws+/aBhydDJc3JqaeX3NiOjMf/YOJrOKEnvyWtb8z K5/zzIkKbFaPnp3RZE5PAkA7VGAIEfoOu2jYGlnWIY1odpnsVxHh+imuWU8vRffC2WdL IyMeFi798VyVr9VT6DR+g512s5+yTkog5ozThoPFFVSPXuwdlng+pS1qOJgxhUAHaUIC OEK/B2CNxOnBz+eCk0qdDJPh0EOEJMiwe/sSBufjnsrujYLVCkr7nor5xvXkKwY8WpNp zCc9Ius9nnlnaYqIvpQvkv0aGlIcOegbWc1T6X9yNKwRIiBzQgU0wBFpRRjMGmyfahCW hV8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516791; x=1701121591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UFS8KKprIzFM0zE+Ai6M4ORed6sy7M8DbezDgWX5KRQ=; b=HdH81wBf24kwym+Mz7GAOBKvQ53Xp+t1e/T5rN11XHpYIQbCYcUNdPI7UG4ac7iLV4 InmLUS39TDGa1MdhZXG2z53seDBTSy4RMIHQ+31tc2d/nMdNNuMXMi1zpz1mTaQuyAJb /0coRcqy8qcNET2Rx5urQmTIj44bG161MzikphAkXAIdIKpQcOHMt5n75Chf+8S5ib/T D518PZ2bl1EipOo5Xz/ffjiyC78kCL7mDh3FjQwtgJ2WUJ92vXJKkyCO+AHoLT77K/cG W5n00lvYR1bOWFq8+tVpj240V8CCxTxRU+8EemOx0x/WdoSEWD92/XI/t0WH+wiwzLGU lOzg== X-Gm-Message-State: AOJu0YwqhV8qOdnaNmhUzI7YWzG1zz8dbu/9+o/W/6JzcJvlXwbh9wxA PxomTO2TEHqHCd6o1mr6fVkGRrD7qzU= X-Google-Smtp-Source: AGHT+IGIRCD7UdLrZN9lSzHXmAgpmrQY5+HhoNLOuQvKT6vBAsOc+D+u9/DgXsMWlG54R5krCGbd6A== X-Received: by 2002:a5d:4151:0:b0:332:ca69:2fb5 with SMTP id c17-20020a5d4151000000b00332ca692fb5mr1904733wrq.11.1700516791362; Mon, 20 Nov 2023 13:46:31 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Subject: [PATCH v4 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:07 +0100 Message-ID: <20231120214624.9378-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Chen-Yu Tsai , linux-i2c@vger.kernel.org, Thomas Zimmermann , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jernej Skrabec Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct sun4i_hdmi *hdmi) return -ENOMEM; adap->owner = THIS_MODULE; - adap->class = I2C_CLASS_DDC; adap->algo = &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From patchwork Mon Nov 20 21:46:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462156 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59D41C197A0 for ; Mon, 20 Nov 2023 21:47:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C5A2510E1FE; Mon, 20 Nov 2023 21:47:57 +0000 (UTC) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AA0610E1DB for ; Mon, 20 Nov 2023 21:46:34 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3316bd84749so2239038f8f.2 for ; Mon, 20 Nov 2023 13:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516792; x=1701121592; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3q7Wv0ykBXfyqStd9azoeaEamTJsEK38bA0+KKsVDzQ=; b=HlovMCzN2Ud3cNSjsFs6m5RJ2gP/Ykzdw7ELj9YMhv8RTWsxJYWm94wCzFMZOQiD7r 9/dknYIrQUt/qrv6CRv7cc0Pl1Tjs5hYzCpLWhhA1Mhz8ovpo1eATLGiDOQM5Bnsfqjo s2iYV2gyaE30XfxHXNgV7odhMD8zCQzrVfM43W2EKyyp7J25HfTp20UiUDThu7z3mWYI l7iJKwfCD9JqdPbyR6Rop7fl6CruCM9QvxXF+rTgXfUaP3Uw9zxPri54Vm7/VGMZlO1D 7vAGeOrcoFS7wROJIqlISNep5DUGPIm6plQJguk62t5JVuOX4XXaQRkTfMxkQ8qFD42y zPvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516792; x=1701121592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3q7Wv0ykBXfyqStd9azoeaEamTJsEK38bA0+KKsVDzQ=; b=LMuB4Cmhy94dHa0FslrGE7iuqF4feHxI11biZlzCi1iBfP4j8ffrhqMmoOMb/q9iCh SS42TIeR2+zgP1vGgzbTFmq+zTTSPyYVvvgk4msdVxk4D8qQEB3TakYxPjKJfftY8NSx qTvsMdAfLdJY45bYO2CyFemhfUvrBDJWfeZQrGjcQdv8Kn/BcYz3NZ2AA+dw/waZ3He4 noHIQdVxfLGjM+DkDotee/8O2/ObbMeKXU3HiVU/kkiE8VfdHWC2FHr+MaNpVFlLU0oW auwZG0cNjeaRQRttohObeufgj/4xu9fsCiicNtJPRymnMAiGwIrhRfogcpcRRnClPx+2 mRDw== X-Gm-Message-State: AOJu0Yxk1ngP7tbDArJfqpgxhXpSSSTGG2j/CZEoJn4c1D+0DEjrG6dg 165+5YGf4J2g8C+tWdalXA8= X-Google-Smtp-Source: AGHT+IE22PcDp7LHr0bveTlzIwiDDweuP3YXTMT1Ylh4ts3pme+8jKLYvs372KUXsQfXq+9sxxC5eQ== X-Received: by 2002:a05:6000:1543:b0:32f:869e:b24b with SMTP id 3-20020a056000154300b0032f869eb24bmr6908763wry.14.1700516792331; Mon, 20 Nov 2023 13:46:32 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:31 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Subject: [PATCH v4 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:08 +0100 Message-ID: <20231120214624.9378-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- v3: - fix compile error --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 15 +++++---------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c index e2e4705e3..bb048e14b 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_template = }; static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class = class; b->adapter.algo_data = &b->bac; b->adapter.dev.parent = &minfo->pcidev->dev; b->bac = matrox_i2c_algo_template; @@ -160,27 +158,24 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) { case MGA_2164: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err = i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err = i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err = i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u #1"); if (err == -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.\n"); } else if (err) printk(KERN_INFO "i2c-matroxfb: Could not register secondary output i2c bus. Continuing anyway.\n"); /* Register maven bus even on G450/G550 */ - err = i2c_bus_reg(&m2info->maven, minfo, - MAT_DATA, MAT_CLK, "MAVEN:fb%u", 0); + err = i2c_bus_reg(&m2info->maven, minfo, MAT_DATA, MAT_CLK, "MAVEN:fb%u"); if (err) printk(KERN_INFO "i2c-matroxfb: Could not register Maven i2c bus. Continuing anyway.\n"); else { diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; par->ddc_algo.setsda = s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_chan *chan, const char *name, strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner = THIS_MODULE; - chan->adapter.class = I2C_CLASS_DDC; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = dev; chan->algo.setsda = tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner = THIS_MODULE; - par->ddc_adapter.class = I2C_CLASS_DDC; par->ddc_adapter.algo_data = &par->ddc_algo; par->ddc_adapter.dev.parent = info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ From patchwork Mon Nov 20 21:46:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13E7EC197A0 for ; Mon, 20 Nov 2023 21:47:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A67A910E1B5; Mon, 20 Nov 2023 21:47:36 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7083010E1EA for ; Mon, 20 Nov 2023 21:46:35 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40859c466efso20392835e9.3 for ; Mon, 20 Nov 2023 13:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516794; x=1701121594; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Upu++zhA/RZdGnIiB8rFAnP6PssgAuOHlFea851Ots=; b=B561az9zpITMzqfwePegggn0xfpUK1KGzMTPx0Ob+83Oa4mL0vKKEBxjyw4CkkjOEQ AJlFpUw0azVqoW1NAKrfZu8yAlrNe37LXA5kO4IvXonBHXI8QPwy1FWoEMgu+CZ4e7pF i9Xi4XDJfhgoqe+EAgHdFHbQE33UM1YCS/VpNDZzBl1wXQfdXyF7soHUuLbP3EzmLUxt 4QC0MOkcaoaIXuzgVM1q1x40ho1Kq2N2i5ngfCaMGTEM1aLC8HS/pUs1VIfX3OXCMUbQ tTiOw9VdqKuxEKLpohGO7z+WcRvLb9QeXjMcdzcZgA7YvGRWbEHZtgZPirINplNhCBOe S9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516794; x=1701121594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Upu++zhA/RZdGnIiB8rFAnP6PssgAuOHlFea851Ots=; b=fFRdVdFklE4P3fKZRQ9xcaX4cMxR+1W3vM/GBDBPDUEefNQZg78Vfpl7OXwHUdffzF h8+/mfynsPpDs5CYh4OjZ5d+row7pZqpamFfFUTbVp3gBEY91dOxFAGNtXF01UbOhI8x 4Y69oFtV/1+JcTJOvxa+qm3eM59t6bT9bI5UHch3xrZOnQH627PG+c5i3A8GKWk8amfR XOzQ5m9wmZDQPrAmh/0ThVAtxnnhFdTQcGWtw47uzuFEZXBL5Izv9aziwgEUdU6gRa0a qeEJ8iiceGJ4bgahfWSLv402RBNvbyRwogfTFXbEFnG6XPf0+ThJ60mzjAi1OxHG6Qfy P5hg== X-Gm-Message-State: AOJu0Yy75c8JuZD2B5p5+zVqI9cm5jdSeAM6EaDniUua7y30s8LkejvQ 2JzulYfmff125p9vgSnOK2M= X-Google-Smtp-Source: AGHT+IGShYbCS8GN/5rAfdvOMeC0Rmm3E5GPr3cI5QbDT98zWYVN+PfkHaKPIKb7avI0dpivwWZpug== X-Received: by 2002:a05:600c:4f81:b0:405:39c1:a98b with SMTP id n1-20020a05600c4f8100b0040539c1a98bmr7120058wmq.20.1700516793380; Mon, 20 Nov 2023 13:46:33 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:32 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Subject: [PATCH v4 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:09 +0100 Message-ID: <20231120214624.9378-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); - adapter->class |= I2C_CLASS_DDC; return edid; } From patchwork Mon Nov 20 21:46:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A437CC197A0 for ; Mon, 20 Nov 2023 21:46:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D57110E1EE; Mon, 20 Nov 2023 21:46:54 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDA6610E1EB; Mon, 20 Nov 2023 21:46:35 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3316bd84749so2239049f8f.2; Mon, 20 Nov 2023 13:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516794; x=1701121594; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=OUjqezwNzLTw9a90IORROGGoNEA7m9rMC0lzGaFKiwVrv5O/mlYTbYryrydyj98ulX YbQHYkCHQ5SVRtyaWOp2KDXzC5FultVVjM0MaVIbOgbCEVPaII176hnkf0X9whw6oBwh i3AyKaRxKhQSr/AN0gzJU8Muo8yT+nWP+6kUfxLMJgM2vMw25nR3P+PlrofIaF7R9+KS A5NgHhfxrK9GDCAJrxOj7HasuxHB75XMqYDo2ECBo2QU2xOYu5XTTKkcCYDepYj81Jac mkebLpLTbAEodCzz0LmBtH6kBuvjk5aekno+pFZXnOmLO+jLEQ6fuRcrCMIFwlqr3OMX Eysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516794; x=1701121594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnYU9L0SxzpQBJjG8833LUnrTfJuWwdCW2h6rtJH0c=; b=dT1upyKmpe/D/b3npW2BALZz1IrREQn13gQfkC853vHdhhdWBAgbiQ7pcD9rUPjGgP UMSdS/wHoivhcEDTS0YJd8B5KqM2XMNsRjPGWngnYNktBHUAEOI7Y81J9l29fwgb1GxW ZUiwG90uPwB7jr8k1ubzydsMsV/g1zcGoKFbzEYHGeSpR1u9unX2njp3J2yVwzGn1RX9 TNTc4n2OKPFdrvzXvpHouCNZyE+88RdNxvX/qIN6cAMvgk+RONWcVkHh4YHn/JFHdFiP jmNSLFRdjGiREteBdejn3yIrtFdbkGprr9qkizoieis87QczL+Y3VjOl1/8f+ArnYo5O Ib2g== X-Gm-Message-State: AOJu0Yy9VADIS1vrAmxUuOh13kyotSQy63EQneiknMPW+Dk71/chFaqx 71MelmHwMZS1LZ41Bpy63xw= X-Google-Smtp-Source: AGHT+IG7oJFy7m7GTxwuKt8k7oUtMWjUdpocB0tG7v5Jyio1SAIq6jBjcVPqQfsuIcvy5PtuzIb31g== X-Received: by 2002:a05:6000:186d:b0:32f:80cf:c3cd with SMTP id d13-20020a056000186d00b0032f80cfc3cdmr7426776wri.4.1700516794213; Mon, 20 Nov 2023 13:46:34 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:33 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Subject: [PATCH v4 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:10 +0100 Message-ID: <20231120214624.9378-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org, =?utf-8?q?Christian_K=C3=B6nig?= , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 20 21:46:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72463C54E76 for ; Mon, 20 Nov 2023 21:46:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E45CA10E1EB; Mon, 20 Nov 2023 21:46:47 +0000 (UTC) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9FB010E1BB for ; Mon, 20 Nov 2023 21:46:36 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40b23aeb9d9so10553655e9.3 for ; Mon, 20 Nov 2023 13:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516795; x=1701121595; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=QqvHd47Suo6+q+iNOr9S8bXMSRUvM0dGxBTyOoKmQNfIt6c8p6Tk8WC13sZt7PdmhU 9Q8VFKEHQTNobmUaWIGSFRebo4rsY8K+RVZid1edBgVZ5wp5tcvmraz8YnmU2pzK1R19 A4CWRGT+Qd1vJWiQ56UlFH05Dn6MF4wdjqRcwnoxwdfL8osrUfqM/HOTySn4m5/4fx1i LZVqth+VK51RXultzQfYx2bWldLvOCzpQ/LQ8jevwj2c0ZmhYcNI1WsS+1NheijMsdV5 OukKq+kUUGFvF6zs4TajctCivIrQ1g46Ekll9NrDeuF+TTGUjp5ODoJMKjvaH9CFEsqk voPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516795; x=1701121595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=suS4LCfsusePiDPKTqW40E2H77s8OXx5HVyNs+o+yDE=; b=N+mLGXghCEKsfXmMI6tTpmy6OOb0K1Bt06aNrW3c+hKmj3l2lc5AB0rTsdZxIcnMD1 kd7bQKEjG7DGDewtH/xAfd2ncDw2kJn/CiF1UaBNBxfhMLzyu51rtboPn4dkiV36WJ30 F1MDiIYv3WlwtRznr5rdEWSXNkf9rfDmchk6YT5hAWOzkI1sWbwwzm6wimrfnKzUcFRb X+I2c/lNKlkUFM9Jcc7G96pU6v56hlcz3AqX+RpOj/z57bQKBbOHyNDqLcfQPelXC/Rx p91kGQ8IBReVDKsyUwEZwOEYBFdUwfg0kH3Iexe+g8PqZ0LuP0m45+eLwcImhm1Adzci 0/7Q== X-Gm-Message-State: AOJu0YzccwxaPWodjoHKY7/RLTM6kqBbUnx/IehHLg+Kgv7AEpFOqLUb 2atTzVCEl2nynOmi8VIUHOc= X-Google-Smtp-Source: AGHT+IFWapLuFxCSewhtGN5+SzhD5+H3LCSt/zm2fnp0PaW4rmMLvzE2JdtHwPvZpR+N8k/OW58kcw== X-Received: by 2002:adf:b318:0:b0:331:69a2:ceab with SMTP id j24-20020adfb318000000b0033169a2ceabmr6977633wrd.19.1700516795084; Mon, 20 Nov 2023 13:46:35 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:34 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Subject: [PATCH v4 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:11 +0100 Message-ID: <20231120214624.9378-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson/lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter = &li2c->adapter; adapter->algo_data = &li2c->bit; adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->dev.parent = ddev->dev; adapter->nr = -1; From patchwork Mon Nov 20 21:46:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462131 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 126F5C2BB3F for ; Mon, 20 Nov 2023 21:46:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 063E710E1DB; Mon, 20 Nov 2023 21:46:47 +0000 (UTC) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF49F10E1E5 for ; Mon, 20 Nov 2023 21:46:37 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-332c82400a5so915867f8f.0 for ; Mon, 20 Nov 2023 13:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516796; x=1701121596; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bq7nwej1uXJ8BJR7pdDi87hSI0E9HenTuebLuXr0HrY=; b=QWuNKXeQf3D0GGW8+Gdj518w3fTpwgI8QRz7W297uc+DBRh/eEvclVmERcl5EuPNOe RGu4QRml+tFrLqBO2pJ83hRFiWe6qaPovmkhv4Y8mPIm4HiBsA45tTHHv/XyhnARiEis N90NCxZBg+SRPVDVUm9FbaddriJLhVdan/sRrtNocsiuMCSIAusEfqgIflqLhImt5/CC ZgxhZYgLoI7gBoDIp/+eLSRUT3RfOedvlJ4NVuPKTypO4NS6+3h1L+7b6jwg14XaGva/ n5bp3ADExqXvirMf85Fe0oU7G1xBhXbnmQ3J+DCKZ5DUUQB+zhOWVucSXDuG4WD5h2pk Z2cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516796; x=1701121596; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bq7nwej1uXJ8BJR7pdDi87hSI0E9HenTuebLuXr0HrY=; b=t+z92eQXm7ljfyCZpvCXnwGERn1vuzkvAoU9iwQxdTO3AQ4QP/Bwvym1xNg0Q+RaoD EaOVRApSfiZmBmai6czTkXHayRFycqEuWcobHXA8IcEGd55SJLv2HTMOgSfUzCN/hAV6 lSbwKNreeLlgl88tJdrdM5jidDLrzYJolEOKT+RkUb0lxOpF6aPe9V/C3WugVOLMg9hq IU3TkcLQWFdssWpU1Anxf9lLzBVhvswTAzalGo4v2hCqVa06iApX0PF/HkMgTJqyIshw a98Ic1XlWQe2AXTfGBp4HfmmfPGJXzXnOLYrCHOMl3P5ohQk0UIg6Jis5w0qjNVRztrt HHWA== X-Gm-Message-State: AOJu0YytEHWaCg0+5V7U3+V7QWcrRbkV+FSVLRDwTJU71qBdf+iALQX8 iUxEi4FR6BhMukIRLFFfDTM= X-Google-Smtp-Source: AGHT+IH1S4/fJsobtHJJPWdqFrJEAF5OXQoLCltzpm8iDTMOYpJCpPVCKnhW9kW09x82/VjIEFaoPg== X-Received: by 2002:a05:6000:381:b0:332:c65a:8f1f with SMTP id u1-20020a056000038100b00332c65a8f1fmr4065388wrf.47.1700516796157; Mon, 20 Nov 2023 13:46:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:35 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Subject: [PATCH v4 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:12 +0100 Message-ID: <20231120214624.9378-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/via_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner = THIS_MODULE; - adapter->class = I2C_CLASS_DDC; adapter->algo_data = algo; if (pdev) adapter->dev.parent = &pdev->dev; From patchwork Mon Nov 20 21:46:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEAFFC54E76 for ; Mon, 20 Nov 2023 21:46:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABB0810E1EA; Mon, 20 Nov 2023 21:46:49 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0388D10E1ED for ; Mon, 20 Nov 2023 21:46:38 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4084b0223ccso20388065e9.2 for ; Mon, 20 Nov 2023 13:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516797; x=1701121597; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=05TjyImSoTBVtC1xNXeArH35uiTcm8HxTuw7Nbu59W0=; b=JfRuFzSabu2Hkk+KhBgXGOLQKTktYV2ZtFLbMr3nHK56w9L9LQ8wNvrKrBYNWUI5R2 s57Tv76LjQBCyLZxQGZPgyEBf8ISz/S9MdCO9sOpFqxBqczGXB89cSgpwyHbaiI/mdlv KZ5rxCOgxIwjC4OJDccqZSrlnDujGK0v1b1167R4h8sY+YzXcQoR49UDyalOnTfGOIe1 JBJk7MZvfD/ook+rVC/9DyPohM4GKAnLJFJjDA2ME8xguehralfS0vcwL1iVyeA4g6p8 1DCToy6mGMKkLiTOM2Cb1VYa44qES21U/maloNAPNyiFk7hUO9BskRFhCkyS3wHOv7vv hu6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516797; x=1701121597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=05TjyImSoTBVtC1xNXeArH35uiTcm8HxTuw7Nbu59W0=; b=wrxpHJH17cUqDspfSycvw0Z4J6+U/wmk9VUqF/MRVBv7preXH2Cae2kpBm5hcficKy sFr/ReWAJFa4spodeS9Nt+zHmP1oYYYGmX8JGTaEvvykEmW02TPP2h+3j4ZSgQg5AlEo T6qKoRfuvFLpr1+lUP5p0mKSWWmowy9g0y8Hoad6RCRdUKCUaDF1LRzRbu6x6bprMoev SbNJwAo6iEBwV/kZryJ7oRacDYnGvbCZPgrO9J9X5pPTEMHLXqXR6m7gOoDt0KWAABg8 1kuekjA+0EqXWbZcq+lpysBxcorcoIiIiFSb3eVhcug2azXRk9PaQB3Q0CLUCq3J7Zwr Ns5A== X-Gm-Message-State: AOJu0YwnpZeLP9ebgGbK1btsnc4ADGAv4nnkQLQbacGH87rjuuAv4yyO nHpSQw/zk+ie5zYMPuUDJB0= X-Google-Smtp-Source: AGHT+IHJoVgqVgRHUKYiAlqB4jK5099Vv0cVK0mL31SC+jI+u/8+HbpYjQSSsu7PjIpJalcA1ZWpRA== X-Received: by 2002:a5d:64e8:0:b0:332:ca10:388 with SMTP id g8-20020a5d64e8000000b00332ca100388mr2882898wri.45.1700516796963; Mon, 20 Nov 2023 13:46:36 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:36 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Subject: [PATCH v4 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:13 +0100 Message-ID: <20231120214624.9378-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner = THIS_MODULE; - cfb->ddc_adapter.class = I2C_CLASS_DDC; cfb->ddc_adapter.algo_data = &cfb->ddc_algo; cfb->ddc_adapter.dev.parent = cfb->fb.device; cfb->ddc_algo.setsda = cyber2000fb_ddc_setsda; From patchwork Mon Nov 20 21:46:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462154 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0250C197A0 for ; Mon, 20 Nov 2023 21:47:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6A9110E1FC; Mon, 20 Nov 2023 21:47:50 +0000 (UTC) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 969B810E1EE for ; Mon, 20 Nov 2023 21:46:39 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32d9effe314so3483845f8f.3 for ; Mon, 20 Nov 2023 13:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516798; x=1701121598; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MYIXvkWgZP3jTqRawAZ0bvfdTUgjzQkomxaiR6ITIUY=; b=J4B7dyBFtBmUMg2SwGCewhTR8H1oqwFa6tMqoGjJtovYExgAkztMcfCdArDklFRgh3 3hUDgcFGRmIgMkMEOawtvxpsLEg6W+kQLHAS1TzcBScZp2RiJBKO7dT0xp542XAZoNkG TFEzBMywRLND/mk7MFQo3XlXk842N/M4rRN9kHnY/VgydNwItMr06PCm8fRUuQyFq6ty xKHvXxrf+soJnFbrPdUNYKOmWAujgPmECMnhZGze91qgvEqgsbtB+n15cFBlv3zK2Xtk QAyT7QRn+Wkyv3s97HBGo4M8U/q/pXnD4pWvc1MSTqvs83QDgj7r1At8L3nCGw+FTbqw 6gbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516798; x=1701121598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MYIXvkWgZP3jTqRawAZ0bvfdTUgjzQkomxaiR6ITIUY=; b=hnOEKS8127E7FC1TiJjfDPDE2ypOXTbwM3XQT4RMferDZW+UW5vfyppeWo7lIvBj4y +XZFLWjMsyHYvunKHLKho78jk8L2a7v9bc8qU5pANJOg5f4ZJDKUA/vDy4d34iooiDyG s+pnsS88eON6oVaALwZICv4Bnf6O3ILhPbZS5woh2nfnNEtPjJgdhZMmFVtbjrZ5cS/R IWNmf8GRRoX28zxr0MZvfccMe9q8DTDWrBMU5ucEnWlu6NKNy7v7z0SDpsMJpuskjczT 2pOoOsVCoq9dK6TMbxGG9rnSM/cBri92O6nxC0YjVfPmJVU5q7Fg3J66g1zIasOdUakD 37+w== X-Gm-Message-State: AOJu0YwtkDXya2h3W7ZfYhnHNvdSKOt808ZzRZI8x2OtuXkYEicz4PEA lR9YYR/5BW2OgwP43Xlx8zA= X-Google-Smtp-Source: AGHT+IFKwgcCGvl+3GjRXi3JOaMzRX6/rxJnUMyqVb00sOOqmTwTqVycHrl5HKcsMJsrsDJpaUNpzw== X-Received: by 2002:a5d:574e:0:b0:32f:810e:8a3f with SMTP id q14-20020a5d574e000000b0032f810e8a3fmr5245352wrw.14.1700516797921; Mon, 20 Nov 2023 13:46:37 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:37 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Subject: [PATCH v4 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:14 +0100 Message-ID: <20231120214624.9378-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Neil Armstrong , Robert Foss , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Neil Armstrong Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi) init_completion(&i2c->cmp); adap = &i2c->adap; - adap->class = I2C_CLASS_DDC; adap->owner = THIS_MODULE; adap->dev.parent = hdmi->dev; adap->algo = &dw_hdmi_algorithm; From patchwork Mon Nov 20 21:46:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462140 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B25F9C197A0 for ; Mon, 20 Nov 2023 21:47:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1959210E1F3; Mon, 20 Nov 2023 21:46:56 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B49510E1DB for ; Mon, 20 Nov 2023 21:46:40 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-331733acbacso2126129f8f.1 for ; Mon, 20 Nov 2023 13:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516799; x=1701121599; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IHtXO9XtiC85W+x/HW1S1eU0VwIPJlyCXEkRfSi7Djs=; b=F4vraOWgEaNZjYu18ZuG5SogdIvOrQjUixCAyxo+/Q4kVSfh0iwRgGGaLClmE/lXo9 6MLEAXW2bPOBqPNCyK0sKtkH9cfNqlV5O4b7DsC+zqvpWZ0ltBEVXcBVTTgWH0wXsz8u MkBqepBZeE4ksTZNTrK8HZMZe/6isiRKccI05Ns0RDeFVmo3XunJDUBKq3d0Sx8lBjgP 1PqVgXRy0uSeTv6tLMBB+jcSZlXPhFGU7bJ9HeBEKqDJIeMMrGmZydfF1mOhUTmhEnIW kcQmwVqJPknABPTCbBcaqfcYPmOLBV4AwDhcaH1x51bMjnCqTpCqNcLNhGwW21o7g22B HXig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516799; x=1701121599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IHtXO9XtiC85W+x/HW1S1eU0VwIPJlyCXEkRfSi7Djs=; b=Y1t3aKgn0m98Z7CtNcFtkI5c78p+kfpkzt+pBKGyoXESWwdraqh6Dh8DNE5UQnSsvj NvOc1ufamzFFUcFbeS9ibrSHTe5YaFWHwkN3iNc4pg894EQeJ3LId0V1ZpCey/WPAm4q ItbtcyFzZwCZoAA5/MLm0Sz6aius2gyhqn4MPlZ13Ykn+E+m+ZehCfvpNpxSSJIfQe9m 4jKsc6KZokdiQEguis8QB2Q174WgY43+670uQXY+EvOLuHG7ipY44WJbRn12izZG5Xr/ XlL8wMHofVzLQYZyA6KaZtZf5YvxUfoyAfeWuIUiObkIFA53NixOJOwJH311HBLiJldc dTWg== X-Gm-Message-State: AOJu0YwcqUIIgbHucFW4MH0wxXpWPEhRjuYC53tqLBNqAQsGVh6PvIYU PmcUMBkzWEtDEf5LZPRi+Nw= X-Google-Smtp-Source: AGHT+IEPEt13Bi9UDLuM7ucKuA1EJUrPpC7p/7AqpQmlWfFXaZtyMu7XxxZkwo1OTgJaGb+DXzLqfg== X-Received: by 2002:a5d:4531:0:b0:331:6df2:3603 with SMTP id j17-20020a5d4531000000b003316df23603mr4725750wra.61.1700516798842; Mon, 20 Nov 2023 13:46:38 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:38 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Subject: [PATCH v4 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:15 +0100 Message-ID: <20231120214624.9378-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev) strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner = THIS_MODULE; - ddc->adap.class = I2C_CLASS_DDC; ddc->adap.algo = &mtk_hdmi_ddc_algorithm; ddc->adap.retries = 3; ddc->adap.dev.of_node = dev->of_node; From patchwork Mon Nov 20 21:46:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD70BC54E76 for ; Mon, 20 Nov 2023 21:47:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D81B10E1F4; Mon, 20 Nov 2023 21:47:50 +0000 (UTC) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by gabe.freedesktop.org (Postfix) with ESMTPS id 562F410E1F3 for ; Mon, 20 Nov 2023 21:46:41 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40906fc54fdso20452485e9.0 for ; Mon, 20 Nov 2023 13:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516800; x=1701121600; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YucjSL5i0nwNQb8TgcsZe7VSoyFWTM6YGwWJl941dgc=; b=QzQnLomIhk/qC8fQ2LJv6C1eVLgUT2x/bJ6NxvpxZY5BS8+DilwA+ZJKUnO9HDooze DrHsf7MphmCY+4uH6dM8oz6E8xxPU+LluqdZaJtjhWan+8YQlA68c6CHTPlzZncbIPIu 7Uiyp4YtJ1q5Z444V1WEZYJjuNOU36N0x6HSoiDvppQntoAxIoH8zuFxR5cYXyflkZIW gYEl7BJRELb4d8h2dQJbNMcMGD2IeHWn0TEq7IiYwfed1EOONMRRjVzP3SZTs2XVnZMf m6dNXYfxBqy9yEZpA2CYEvleBXNrbC1L2hNXUq/6Mtmuqutmjl0n2MYPq1h+fvXDRuOg VdDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516800; x=1701121600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YucjSL5i0nwNQb8TgcsZe7VSoyFWTM6YGwWJl941dgc=; b=RIJz26Sm2Ij9qPZLG3CzYNejB2ujRH2BNehlfn4N0sQ6SYQznx/rTq4s5clObV07Qk jjBrrpCYgE97gHxqLFKpAdrTbrUw2ChdZQlMhBc2GSoZpla35e5Dib+1qGNewNCQBiUf 1QGuwdANkmghPkhKkx3jBZ66THyPm2bivQcSr0GLSX7Rai5TJYdY1pHPtqlWMWiEEr4j 1beoYKK6pyvtg3hObAk6R1dQh9IYbdBMQ5YJxg0qPI99sVYT1nPHRPPI4Zs8cYFPrad9 ai5hd/fGo9fdPZpjJJDl8+aslfRdtuRHZZ0M5vH1hwFBj12r/I+F598kMyJyzQ+PcgZ3 8PDQ== X-Gm-Message-State: AOJu0YxR9t7G77snFX4RzpLGI4mo/iJ1LCHQzo7d8qiTQUYdEcczi8g2 S8nfwAMg/ZcWbXARVTLZ5uZzyrCYmRw= X-Google-Smtp-Source: AGHT+IHI1MXMavn+Gq00D5IWRHVWhxn647ptsSuePBK36r3qhuByg6Z/4wSKnRhzWG0O01cnuBnrlQ== X-Received: by 2002:a05:6000:18cc:b0:331:6b5d:84d2 with SMTP id w12-20020a05600018cc00b003316b5d84d2mr5455372wrq.19.1700516799569; Mon, 20 Nov 2023 13:46:39 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:39 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Subject: [PATCH v4 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:16 +0100 Message-ID: <20231120214624.9378-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From patchwork Mon Nov 20 21:46:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1554CC54E76 for ; Mon, 20 Nov 2023 21:47:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83B4310E1F8; Mon, 20 Nov 2023 21:46:57 +0000 (UTC) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id 57E2410E1F4; Mon, 20 Nov 2023 21:46:42 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4083dbc43cfso16966675e9.3; Mon, 20 Nov 2023 13:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516801; x=1701121601; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EQ/FEK2mYsIsrLAMj1ftUkEFHG7z/MaBn+ksqWZD4+o=; b=g2VGKZCHnM9MRIzFnsZO74hK3fBmdQCXooZU1YNvCMJsOqBDcyf42H1V8kUmhtjsRd KvivgzT4f9lv2Tf0fNUqBBo5PrZcS36IYeukbuiSpqalfnf1tL/PMrWzSOXNv98i2ZWS ofWerhdRyCY+yYvQTZNEVivjxPBGGBrRSbhO/CXDGfU0DY00Yli6Otf6PvCmiBJnrTP4 IvyMitwqVuVKfHPq6mESIPq+BcxHubDmwkyU/D10uUDGA2k4Xd6OuP50uNhArUMFeOqy Mpjb/LkQiJTZLneTWkmeamaeBF+lIpZdqVFHGwgWUCtlSaFFVYgvrWAE69BLAT2V6Mck LlUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516801; x=1701121601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EQ/FEK2mYsIsrLAMj1ftUkEFHG7z/MaBn+ksqWZD4+o=; b=v3NeBmzy9nLYjwT6FZWjl7D2blMkRZFoYB24ZvZqbGoPJ5HmMb+iQ3RF5KxaH/3gA6 W7DC4I/Fx5vTPLZ9H1u1/IPDD0HIZ97504SD74hCpb4OY5EbNDbDaZ7ImubVzgMqWLf6 RHIvTjEFyKl05XTXI7ObhGF04jn9oY8AofYM0zSqV8C+hcJwoNM1xTz51krzqqwFSocT cyMThxT6YC8bR0e5Ptkfl19OoHVLQ5MZQs45Xu+qkEC5dmuknfH1Zf6KCU4EcTIHWk95 TdbmFuEZkJ9l2Aksh4T1vJYiH5KXqDVuzYLf/+Jqru5fQm5jdRprSr6vn0fp+mPT/2Md 7iew== X-Gm-Message-State: AOJu0Yy/XXdut0v6rVfP7U8sYXZ/9KZCZZ92BlmLUMhWq/7KjnUaEyJ7 S/s1k41iUMKohNVMXIWaxOw= X-Google-Smtp-Source: AGHT+IEJmFFE3EHKXQ4RGWFBYumObm40aSlus52AgE+TXXlh+CCacbrX+eglWn0cbPoyet+nNAcCRg== X-Received: by 2002:a05:6000:4010:b0:332:c1da:4cca with SMTP id cp16-20020a056000401000b00332c1da4ccamr4845981wrb.14.1700516800595; Mon, 20 Nov 2023 13:46:40 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:40 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Subject: [PATCH v4 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:17 +0100 Message-ID: <20231120214624.9378-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , Sean Paul , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Dmitry Baryshkov Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm; From patchwork Mon Nov 20 21:46:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462142 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48D39C2BB3F for ; Mon, 20 Nov 2023 21:47:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66EEF10E1FB; Mon, 20 Nov 2023 21:46:58 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E9FB10E1EA; Mon, 20 Nov 2023 21:46:43 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-32f8441dfb5so3793642f8f.0; Mon, 20 Nov 2023 13:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516801; x=1701121601; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=ftJU3xlmKd+/dCyQa3geV3tioPxXtjhY873yhc0O5faglDmKZ776dHSOZeGxF3O4ph X9SLs8124MxNt5ZYdoFTIJXM2oX7wMrjZ/aMGYLYNkkTh5/MVXukFp45QKwzFQ/hHvL9 c3M4qeMnlBlSWzxgSPeMqwrABJjGl5o4jI8fIK7aDB3GoJJyyB9Zo9zZ2BV5wQ2HclF7 ygEgilxeUsFKYiw8BRbLzNXUfq2c/FtKHAg2NTN/Jkbx3u+MUujVkc5gGDyY5WMvz7vk DNOV8TfquQW35L91Ei4OHQfYgpYmvXQ+7/Ywo2/3Z8ks2ijFkwp7joyOU9wmvVbFkwdG GiIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516801; x=1701121601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwY3dw5n8Qn4ucno1MuBuADAhIYe/cj92x0CcIZXqhc=; b=NlzeSawDxcT9BCoFy8/paJ0JGws6Ao2/XZThBKDdoFHp8G+ipFyGYdCBXpePSxwrtJ /lw0ISF1VBbvkzyUv7qSpzS7SZ0ZEcBNjJSNeuR/l4cfIqJ24Nk+ku+LSn5CXahH1pnf ud7RZ8NoJWPaxvxfwZVStWQDdQV8ShqdzAhv9MZnQzM3FtVSpH2vUK+3UO+VBYUZBn8T glbWamJwo0ebKtGfXw00TKSpO6aTsmrSotFpsxUMs/L0GF8vjhf5QNlBFCsrtYglmhm9 X4zhRJuqW/+wbuKoyMvgLHOk10mZPI2wAMkNLiX9/6VIiBiToZV1/HIbxgtHC8XsnNci Bx0w== X-Gm-Message-State: AOJu0Yyy7czctxOOmfaNk1f6T6mIVsGV44aQO1wBDoY+5Ado2kTWrrQB +u3HChWAeA7PyWU6AZzePAs= X-Google-Smtp-Source: AGHT+IH3/XFzq2U/6agtXbj1oqhLy7Jth3QoBz9Hz0FwIflN3vy7qQTcPG492HCCqk1aqFe8zNZYvA== X-Received: by 2002:a5d:6d87:0:b0:332:c49d:28f6 with SMTP id l7-20020a5d6d87000000b00332c49d28f6mr3843056wrs.13.1700516801468; Mon, 20 Nov 2023 13:46:41 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:41 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Subject: [PATCH v4 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:18 +0100 Message-ID: <20231120214624.9378-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Rodrigo Vivi , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus = ddc_bus; ddc->ddc.owner = THIS_MODULE; - ddc->ddc.class = I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent = &pdev->dev; From patchwork Mon Nov 20 21:46:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462138 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10A49C54E76 for ; Mon, 20 Nov 2023 21:47:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F158D10E1EC; Mon, 20 Nov 2023 21:46:53 +0000 (UTC) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B47910E1DB for ; Mon, 20 Nov 2023 21:46:44 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-32d81864e3fso3103238f8f.2 for ; Mon, 20 Nov 2023 13:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516802; x=1701121602; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=I/1/HWsbncYSki75Nj9m4nADbZeazAnBOk7fy6FDcRRvjUsHG1xoO+a7dC2LejeZUo j7tP4iv/02RCHgZsassF1G6yITYrCQeJOEc5cAkQS0SoHpGzjqjeYuajfkArRMSh9Met Kh1y5mq4X6lPsyVL/A6bY+Rk6IjetRoO7/pgE2IQyMsObFspi0nxu/p05bEGjclxEhMa OGXoyeyvYtHYSoarwMvV+RUIvBN9RW2hidsj/aEdNahwQ/vRI5F7qC8+xrrz4wdIjDOs PrOeFS21dSmooPzvyW7Vntznrm5Hw1Xx6/ces7FZ0f7adULRwv65fEYcuDrFRFseGXj6 kDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516802; x=1701121602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anw5D9jgaSVgoYwRFPH2zMk9qB9A7j/26DqujJWuba0=; b=oztpl1nNC4lJeDBWlGguXEHOqJFBQf3JPzAKb0N+gMlPb5KRXSDT6RcQnPcfM3vSYb 8uGlB9mN7xELph+C845/J+ydLCATRhCp8SxwxRB9R2Dge0ioOZBlvuDaNlSw7jkxN5zY sv/O3RrQdw6bBT7Hdw5iT6YnoVCUVdhLh/yHUXnqWNXcLnyjNW/t43Kbd8l451HR/4is 4RkOVxS8nypgYgXWdzJthAsQn+WKBHLkpLGPR+bVNCY5IPt7r9S+xFgxbz7xGZOjTIJH 8+h+p2Z1D6PDYs44zY0sZStrUbPu0h28r8n8aTgqZLJhE1tzV6wbsCHWc5YTmvjGJsPO pejQ== X-Gm-Message-State: AOJu0YyRZwhCKRJj/VhrR0yreK5RuFVGpXJxd9psSFJWf1Wl1gId2Iz5 5XUBPB3YFYKlrEjPtCXJrd4= X-Google-Smtp-Source: AGHT+IGCNvJ+s9QKyAFCEyfQzE+WdN1YcyTEOm5eawrcWLv+hW9plFQx2WrzNQnxKdHkttv2+45PsA== X-Received: by 2002:adf:ed45:0:b0:331:41ab:22ad with SMTP id u5-20020adfed45000000b0033141ab22admr5898305wro.20.1700516802375; Mon, 20 Nov 2023 13:46:42 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Subject: [PATCH v4 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:19 +0100 Message-ID: <20231120214624.9378-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , John Stultz , Xinwei Kong , Yongqin Liu , linux-i2c@vger.kernel.org, Thomas Zimmermann , Tian Tao , Sumit Semwal , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From patchwork Mon Nov 20 21:46:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462136 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40837C54E76 for ; Mon, 20 Nov 2023 21:46:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F19BD10E1F1; Mon, 20 Nov 2023 21:46:53 +0000 (UTC) Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by gabe.freedesktop.org (Postfix) with ESMTPS id E580710E1FC for ; Mon, 20 Nov 2023 21:46:44 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-332ca7f95e1so703344f8f.0 for ; Mon, 20 Nov 2023 13:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516803; x=1701121603; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bqROwQG7N3qrkO1+o2zNL4maIfyYwDDg69jSMCtjk0o=; b=dJFydR3k47bYm5j/972jfDk2rPq3pUQpMCrZKLTf8jXNemtFfjwSFUXED60kA5oQV6 LlIyIlv4m0fReA0m2MLO6BKG8JOQpgarkuI60K0oVBOF0qkcW7mRDxEwzTV6UPYNTtEJ r3OIWPRTQZaAggmTg+S3C2IekVwoXuXU2K3c6bWprnNDUWXpYhI3vqYCvnFmFoALB6YT ZwBKa0cgzZ9N+1DXy5ppN/wq1wFL/EszdCTRFEt2pRJmOMnnEchdU6p2otxcRhKbF6A4 eXraulf6fsNe7CDB3BIE3BNFKUkLXSaADkGBjoqK/rcz8gtrB7LwFKP5xWzuZZEFwden aAlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516803; x=1701121603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bqROwQG7N3qrkO1+o2zNL4maIfyYwDDg69jSMCtjk0o=; b=LHMSTwTM9wK0K/5jO1tqDvIWKOZYbD6IAgDHYxKWJD9fRphU8UoB8Bv3sfzTCyOXDH yXdXinVyj1wRUPQVqx2Q1nInvNzW/sjQaKz/ZaC5bk662pwB+NnH6hMxSO1tEFbY9YVd cPw4VaGoDIhoE0zXvmi6mEaW0v3VnhgTE1jviFsZkFzjqQz4irLQW2GvBOKRWIS7AVjH 3jwYa8tIUWw5O9LLryXfB7xAypQcfSG+YJwAlEnVgcneOs9t8/H40fJyXJnWWJWReTLv XGESMKwh99lMDaASCVyhAGU2S1m+1LhLbd94EYIPGs9nxs1r+DOMWai8uWr+tw9ZIyZl 22tg== X-Gm-Message-State: AOJu0YzTw+rNn/CtrviJeMlR5ZCC6oUL4CgVRpd4xKsvIx0iohh7F/Vv 5n5DsXWeTQc99dgjgkCFNUg= X-Google-Smtp-Source: AGHT+IHzZWuP7fUYMd2+O3OBOSCHQpJLAk+VbHkWWjSpa7kQzX5njoZWRysEH9t0PNmhOAIArQoRaQ== X-Received: by 2002:adf:a353:0:b0:332:c4e3:9b09 with SMTP id d19-20020adfa353000000b00332c4e39b09mr3466448wrb.30.1700516803239; Mon, 20 Nov 2023 13:46:43 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:42 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Subject: [PATCH v4 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:20 +0100 Message-ID: <20231120214624.9378-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jocelyn Falempe , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *dev) return NULL; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; i2c->adapter.dev.parent = dev->dev; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); From patchwork Mon Nov 20 21:46:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F271C5AE5C for ; Mon, 20 Nov 2023 21:47:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E18610E1ED; Mon, 20 Nov 2023 21:46:54 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCA5C10E1EC for ; Mon, 20 Nov 2023 21:46:45 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-32f78dcf036so3595672f8f.0 for ; Mon, 20 Nov 2023 13:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516804; x=1701121604; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=l5gx3bsnLR2CrgC77kM3UVXPuNe4v7bCj/vFwXfyp+yC0PqaY+/xupYtpmYzTOWQ53 1EvVXEI1zzMEBHDuBV1Z85DuYf7WC29We6mqsL24JhqCgl9q6aTffS2ouIla4/zNBGn5 mBuPoOV92VPZCmU7+gbjTXXFJfScKEocnSBHOU1uAGWPqT41z9tEUpXugUdkD4pQCqqi RP9RdNcaOOtnwpn7fFedTER8yMddrBe+0udB7htZP7lXL8/yaKWWBd/yftdEgYlRl3Mv N4kw3C0dkiyJDMEiyBWeW4d5/97zPXNrCxkNjK9UZ2m8tVrpFPRv64/uoIWmQkpSiGyM SSNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516804; x=1701121604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvYv7yv0Rz2qXj3RF4iM+eVeFbHCrgQ2kQmEmocPEPY=; b=nQnMGoLR/MdGAKCtSaNvdSO22A8Vb97SB8FazTta8Ob98DX0R5ypJNzLHYKkY+hQVx cp/67LOeZzuzeKxE9vJd2WHYWBbk7dCkDckbyiux9Kap8P+F8LLqX58jLK0ZgudKDnLI Qmz1kBSOV1bnr0lne2FR39scnw585CGmDcXV7/b5a3DZ0rmsAYvjrSno2eSlwPAbeIub GLkZJKLsi8RaO8Q/2KiyY+K4H6/Bc5k0G25VEea3yLDBvywN+BX03Qs6133FhWvv42q6 qcD+38bi9jCZnyJc8o/W8xjH2S9wRp5i5nW6foFa0EM+CJ+L5mkf1pfE6BnDvmuvmP7F 7xbQ== X-Gm-Message-State: AOJu0Yy7V06SsGKZKCyCDLRhGNt+5oNSuqp/xGhcRJDhzwkaTd5tkAd0 b2rk8IroQBo177U8ITerdDFQSxHcMTTNYw== X-Google-Smtp-Source: AGHT+IFhVjIKyJHoTFDY1S25E30i9YBHBvrq3sray80zY0SoXNdaGxfljpNF4jtOS6XdTV+AbxDGhw== X-Received: by 2002:a5d:6da6:0:b0:32d:a366:7073 with SMTP id u6-20020a5d6da6000000b0032da3667073mr659505wrs.14.1700516804106; Mon, 20 Nov 2023 13:46:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:43 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Subject: [PATCH v4 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:21 +0100 Message-ID: <20231120214624.9378-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Thomas Zimmermann , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner = THIS_MODULE; - intel_dp->adapter.class = I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0'; intel_dp->adapter.algo_data = &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus = &dev_priv->gmbus[i]; bus->adapter.owner = THIS_MODULE; - bus->adapter.class = I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter = { .name = "oaktrail_hdmi_i2c", .nr = 3, .owner = THIS_MODULE, - .class = I2C_CLASS_DDC, .algo = &oaktrail_hdmi_i2c_algorithm, }; diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *sdvo, struct drm_device *dev) { sdvo->ddc.owner = THIS_MODULE; - sdvo->ddc.class = I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent = dev->dev; sdvo->ddc.algo_data = sdvo; From patchwork Mon Nov 20 21:46:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13462152 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50FFCC54E76 for ; Mon, 20 Nov 2023 21:47:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E281110E154; Mon, 20 Nov 2023 21:47:35 +0000 (UTC) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id B1AF810E1BB for ; Mon, 20 Nov 2023 21:46:46 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32ddfb38c02so3238162f8f.3 for ; Mon, 20 Nov 2023 13:46:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700516805; x=1701121605; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=JpDKwaBWcRFV9YDHF73bdmc8pA2whsFlozTFx6bwaxa60bWaj4cXV8vVA90DIW1Gza xUmIxhoj0X908zeolGYs6yXSFoW9FlSx7KGnU3kkSjBAdlkWW5JxHlQmMe867fj3BgPx k/vbEn8GUWbAGiemTBfcie+gGamCvZn1p6bNhvoGvaSNZNBtuGfZyLiCgPTuy6YwgUM9 YUpbE1cG00RiOUSwXTvkdbIkhvG4SHHGLRVMuAdQPS2qMCgDMAGFnrRmGcJcL04fVolz w7dIykVUyhCEuiR4axfUQi+ga0imMXvKn37sYtiUG0zM3RjmsC4A1atkiHMXcEhwnRxi pprA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516805; x=1701121605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFB7iCk0Bd2syBjc9Ptoymcq6fnpGc3VauDL49PiFhg=; b=fqR92jh2PizWU1nzvBS8E0tAVLU9ZTTPM2W2Rll0lvz+5//D09F8QG/30WGc0iwfvC dCGagFNDQ8G3RhUqa86V0xz112/4qvkCnV0K0eGL5fDS1fiKwkMnTXFfeJcPoxD0pNeo 8cUZSbRLXGsYITBV2QYTB1nlGFoUSd+U0G7Lxu3cdBc+qSROhm+i9TFZjCLq5CLtqOpw POSs/Iaf63H84F73/H/MnuGRu9VRL9+BjlLw2HOLLRw7xVm23n43E5+LWq3qixkK+yYU NvpkoVxG8S3hu/7yg/p7TMiMGjO9q/9mjPR5ujmNkHsBKD2q34/XTBsNjApDn6N6muNT fzUQ== X-Gm-Message-State: AOJu0YzyNr3c9s2IPi1z+abFQnVHd7sYVNERXcuZfQqyFnzonx44suQv 5Y2npAIkcsh270OwoIq1gKAwFRDkZRi7AQ== X-Google-Smtp-Source: AGHT+IFO9ZmrSbH6A+/A5LyWdCeKfgaeedlrEYc7qHHXqeUF8v+awr8pU44qCeg4rV4R9MhiuP768w== X-Received: by 2002:a05:6000:18ad:b0:32d:b06c:d30b with SMTP id b13-20020a05600018ad00b0032db06cd30bmr6861142wri.55.1700516804962; Mon, 20 Nov 2023 13:46:44 -0800 (PST) Received: from zotac.lan. (dynamic-2a02-3100-9030-5a00-2223-08ff-fe18-0310.310.pool.telefonica.de. [2a02:3100:9030:5a00:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id i13-20020a5d584d000000b00332cb0937f4sm2667052wrf.33.2023.11.20.13.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 13:46:44 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Subject: [PATCH v4 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Mon, 20 Nov 2023 22:46:22 +0100 Message-ID: <20231120214624.9378-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231120214624.9378-1-hkallweit1@gmail.com> References: <20231120214624.9378-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , linux-i2c@vger.kernel.org, Alex Deucher , Heiner Kallweit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; aux->ddc.dev.parent = aux->dev; diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port) aux->ddc.algo_data = aux; aux->ddc.retries = 3; - aux->ddc.class = I2C_CLASS_DDC; aux->ddc.owner = THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent = parent_dev;