From patchwork Fri Nov 24 14:03:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467704 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6C9CC61DF4 for ; Fri, 24 Nov 2023 14:05:46 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640732.999372 (Exim 4.92) (envelope-from ) id 1r6WnU-0005Qq-90; Fri, 24 Nov 2023 14:04:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640732.999372; Fri, 24 Nov 2023 14:04:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnU-0005PS-2w; Fri, 24 Nov 2023 14:04:44 +0000 Received: by outflank-mailman (input) for mailman id 640732; Fri, 24 Nov 2023 14:04:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnS-0005N0-Ea for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:42 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 693b14e9-8ad2-11ee-98e2-6d05b1d4d9a1; Fri, 24 Nov 2023 15:04:41 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id DE3034EE0C8B; Fri, 24 Nov 2023 15:04:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 693b14e9-8ad2-11ee-98e2-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 01/11] xen/console: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:16 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/drivers/char/console.c | 4 ++-- xen/include/xen/console.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 946af5e625..0666564ec9 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -393,9 +393,9 @@ long read_console_ring(struct xen_sysctl_readconsole *op) static char serial_rx_ring[SERIAL_RX_SIZE]; static unsigned int serial_rx_cons, serial_rx_prod; -static void (*serial_steal_fn)(const char *, size_t nr) = early_puts; +static void (*serial_steal_fn)(const char *str, size_t nr) = early_puts; -int console_steal(int handle, void (*fn)(const char *, size_t nr)) +int console_steal(int handle, void (*fn)(const char *str, size_t nr)) { if ( (handle == -1) || (handle != sercon_handle) ) return 0; diff --git a/xen/include/xen/console.h b/xen/include/xen/console.h index ab5c30c0da..68759862e8 100644 --- a/xen/include/xen/console.h +++ b/xen/include/xen/console.h @@ -36,7 +36,7 @@ struct domain *console_input_domain(void); * Steal output from the console. Returns +ve identifier, else -ve error. * Takes the handle of the serial line to steal, and steal callback function. */ -int console_steal(int handle, void (*fn)(const char *, size_t nr)); +int console_steal(int handle, void (*fn)(const char *str, size_t nr)); /* Give back stolen console. Takes the identifier returned by console_steal. */ void console_giveback(int id); From patchwork Fri Nov 24 14:03:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1CADC636D0 for ; Fri, 24 Nov 2023 14:05:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640733.999375 (Exim 4.92) (envelope-from ) id 1r6WnU-0005Xa-Gi; Fri, 24 Nov 2023 14:04:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640733.999375; Fri, 24 Nov 2023 14:04:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnU-0005Wd-Cw; Fri, 24 Nov 2023 14:04:44 +0000 Received: by outflank-mailman (input) for mailman id 640733; Fri, 24 Nov 2023 14:04:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnT-0005N1-17 for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69982414-8ad2-11ee-9b0e-b553b5be7939; Fri, 24 Nov 2023 15:04:41 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id DD6024EE0C91; Fri, 24 Nov 2023 15:04:40 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69982414-8ad2-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich Subject: [XEN PATCH 02/11] xen/aclinux: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:17 +0100 Message-Id: <98eabdc58a458188157765fd9ca8c9d4d4f6b11c.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/include/acpi/platform/aclinux.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/acpi/platform/aclinux.h b/xen/include/acpi/platform/aclinux.h index 9e572460dc..f5e0a6108e 100644 --- a/xen/include/acpi/platform/aclinux.h +++ b/xen/include/acpi/platform/aclinux.h @@ -75,9 +75,9 @@ #define acpi_thread_id struct vcpu * -void *acpi_os_alloc_memory(size_t); -void *acpi_os_zalloc_memory(size_t); -void acpi_os_free_memory(void *); +void *acpi_os_alloc_memory(size_t sz); +void *acpi_os_zalloc_memory(size_t sz); +void acpi_os_free_memory(void *ptr); #define ACPI_ALLOCATE(a) acpi_os_alloc_memory(a) #define ACPI_ALLOCATE_ZEROED(a) acpi_os_zalloc_memory(a) From patchwork Fri Nov 24 14:03:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3931EC61DF4 for ; Fri, 24 Nov 2023 14:05:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640734.999386 (Exim 4.92) (envelope-from ) id 1r6WnV-0005kh-40; Fri, 24 Nov 2023 14:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640734.999386; Fri, 24 Nov 2023 14:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnU-0005iL-RK; Fri, 24 Nov 2023 14:04:44 +0000 Received: by outflank-mailman (input) for mailman id 640734; Fri, 24 Nov 2023 14:04:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnT-0005N1-Tz for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a1d49dd-8ad2-11ee-9b0e-b553b5be7939; Fri, 24 Nov 2023 15:04:42 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 85B054EE0C8F; Fri, 24 Nov 2023 15:04:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a1d49dd-8ad2-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 03/11] xen/cpumask: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:18 +0100 Message-Id: <0ea3c74ef2e5524d0a9726b6e0795d50dfc32eb8.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/include/xen/cpumask.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/cpumask.h b/xen/include/xen/cpumask.h index 9826707909..145e140481 100644 --- a/xen/include/xen/cpumask.h +++ b/xen/include/xen/cpumask.h @@ -460,7 +460,9 @@ extern cpumask_t cpu_present_map; /* Copy to/from cpumap provided by control tools. */ struct xenctl_bitmap; -int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *, const cpumask_t *); -int xenctl_bitmap_to_cpumask(cpumask_var_t *, const struct xenctl_bitmap *); +int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap, + const cpumask_t *cpumask); +int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask, + const struct xenctl_bitmap *xenctl_cpumap); #endif /* __XEN_CPUMASK_H */ From patchwork Fri Nov 24 14:03:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F621C624B4 for ; Fri, 24 Nov 2023 14:05:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640735.999405 (Exim 4.92) (envelope-from ) id 1r6WnX-0006Lq-9e; Fri, 24 Nov 2023 14:04:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640735.999405; Fri, 24 Nov 2023 14:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnX-0006Lj-5M; Fri, 24 Nov 2023 14:04:47 +0000 Received: by outflank-mailman (input) for mailman id 640735; Fri, 24 Nov 2023 14:04:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnU-0005N1-Ve for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ac27968-8ad2-11ee-9b0e-b553b5be7939; Fri, 24 Nov 2023 15:04:43 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 682354EE0C8A; Fri, 24 Nov 2023 15:04:42 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ac27968-8ad2-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 04/11] xen/dmi: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:19 +0100 Message-Id: <0eaa7a31011dc3b2f22217d2c7389570d5634549.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/include/xen/dmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/dmi.h b/xen/include/xen/dmi.h index 71a5c46dc6..0fef41842e 100644 --- a/xen/include/xen/dmi.h +++ b/xen/include/xen/dmi.h @@ -24,7 +24,7 @@ struct dmi_strmatch { }; struct dmi_system_id { - int (*callback)(const struct dmi_system_id *); + int (*callback)(const struct dmi_system_id *d); const char *ident; struct dmi_strmatch matches[4]; void *driver_data; From patchwork Fri Nov 24 14:03:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 988B3C624B4 for ; Fri, 24 Nov 2023 14:05:10 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640736.999409 (Exim 4.92) (envelope-from ) id 1r6WnX-0006PI-IJ; Fri, 24 Nov 2023 14:04:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640736.999409; Fri, 24 Nov 2023 14:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnX-0006Nq-DG; Fri, 24 Nov 2023 14:04:47 +0000 Received: by outflank-mailman (input) for mailman id 640736; Fri, 24 Nov 2023 14:04:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnV-0005N1-VZ for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:45 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b5493b8-8ad2-11ee-9b0e-b553b5be7939; Fri, 24 Nov 2023 15:04:44 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 768CB4EE0C96; Fri, 24 Nov 2023 15:04:43 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b5493b8-8ad2-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 05/11] xen/domain: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:20 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/include/xen/domain.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 460c8c3d27..d345278b71 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -25,7 +25,7 @@ unsigned int dom0_max_vcpus(void); int parse_arch_dom0_param(const char *s, const char *e); struct vcpu *alloc_dom0_vcpu0(struct domain *dom0); -int vcpu_reset(struct vcpu *); +int vcpu_reset(struct vcpu *v); int vcpu_up(struct vcpu *v); void setup_system_domains(void); @@ -65,9 +65,9 @@ void free_vcpu_struct(struct vcpu *v); /* Allocate/free a PIRQ structure. */ #ifndef alloc_pirq_struct -struct pirq *alloc_pirq_struct(struct domain *); +struct pirq *alloc_pirq_struct(struct domain *d); #endif -void cf_check free_pirq_struct(void *); +void cf_check free_pirq_struct(void *ptr); /* * Initialise/destroy arch-specific details of a VCPU. @@ -103,8 +103,8 @@ void arch_domain_creation_finished(struct domain *d); void arch_p2m_set_access_required(struct domain *d, bool access_required); -int arch_set_info_guest(struct vcpu *, vcpu_guest_context_u); -void arch_get_info_guest(struct vcpu *, vcpu_guest_context_u); +int arch_set_info_guest(struct vcpu *v, vcpu_guest_context_u c); +void arch_get_info_guest(struct vcpu *v, vcpu_guest_context_u c); int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); @@ -112,7 +112,7 @@ int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); int arch_get_paging_mempool_size(struct domain *d, uint64_t *size /* bytes */); int arch_set_paging_mempool_size(struct domain *d, uint64_t size /* bytes */); -bool update_runstate_area(struct vcpu *); +bool update_runstate_area(struct vcpu *v); int domain_relinquish_resources(struct domain *d); @@ -122,7 +122,7 @@ void arch_dump_vcpu_info(struct vcpu *v); void arch_dump_domain_info(struct domain *d); -int arch_vcpu_reset(struct vcpu *); +int arch_vcpu_reset(struct vcpu *v); bool domctl_lock_acquire(void); void domctl_lock_release(void); From patchwork Fri Nov 24 14:03:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467698 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 581C1C61D97 for ; Fri, 24 Nov 2023 14:05:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640737.999415 (Exim 4.92) (envelope-from ) id 1r6WnX-0006WF-U2; Fri, 24 Nov 2023 14:04:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640737.999415; Fri, 24 Nov 2023 14:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnX-0006VD-Pr; Fri, 24 Nov 2023 14:04:47 +0000 Received: by outflank-mailman (input) for mailman id 640737; Fri, 24 Nov 2023 14:04:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnW-0005N0-2S for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:46 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6beddff9-8ad2-11ee-98e2-6d05b1d4d9a1; Fri, 24 Nov 2023 15:04:45 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 6F9B94EE0C97; Fri, 24 Nov 2023 15:04:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6beddff9-8ad2-11ee-98e2-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 06/11] xen/notifier: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:21 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/include/xen/notifier.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/include/xen/notifier.h b/xen/include/xen/notifier.h index 51453c1552..2a952484df 100644 --- a/xen/include/xen/notifier.h +++ b/xen/include/xen/notifier.h @@ -23,7 +23,8 @@ */ struct notifier_block { - int (*notifier_call)(struct notifier_block *, unsigned long, void *); + int (*notifier_call)(struct notifier_block *nfb, unsigned long action, + void *hcpu); struct list_head chain; int priority; }; From patchwork Fri Nov 24 14:03:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467701 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FE09C61D97 for ; Fri, 24 Nov 2023 14:05:13 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640738.999434 (Exim 4.92) (envelope-from ) id 1r6WnZ-00071b-G5; Fri, 24 Nov 2023 14:04:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640738.999434; Fri, 24 Nov 2023 14:04:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnZ-0006zl-4u; Fri, 24 Nov 2023 14:04:49 +0000 Received: by outflank-mailman (input) for mailman id 640738; Fri, 24 Nov 2023 14:04:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnX-0005N1-S4 for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c72c5f2-8ad2-11ee-9b0e-b553b5be7939; Fri, 24 Nov 2023 15:04:46 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 87C9C4EE0C92; Fri, 24 Nov 2023 15:04:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c72c5f2-8ad2-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Paul Durrant , =?utf-8?q?Rog?= =?utf-8?q?er_Pau_Monn=C3=A9?= Subject: [XEN PATCH 07/11] xen/iommu: address violations of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:22 +0100 Message-Id: <85581b19ffe10276639683aff56d04f3f74abd6f.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter names to address violations of MISRA C:2012 Rule 8.2 and remove uses of u{8,16,32} in favor of C standard types. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich --- xen/include/xen/iommu.h | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index d5c2577091..69d572543c 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -262,14 +262,15 @@ struct iommu_ops { int (*init)(struct domain *d); void (*hwdom_init)(struct domain *d); int (*quarantine_init)(device_t *dev, bool scratch_page); - int (*add_device)(u8 devfn, device_t *dev); + int (*add_device)(uint8_t devfn, device_t *dev); int (*enable_device)(device_t *dev); - int (*remove_device)(u8 devfn, device_t *dev); - int (*assign_device)(struct domain *, u8 devfn, device_t *dev, u32 flag); + int (*remove_device)(uint8_t devfn, device_t *dev); + int (*assign_device)(struct domain *d, uint8_t devfn, device_t *dev, + uint32_t flag); int (*reassign_device)(struct domain *s, struct domain *t, - u8 devfn, device_t *dev); + uint8_t devfn, device_t *dev); #ifdef CONFIG_HAS_PCI - int (*get_device_group_id)(u16 seg, u8 bus, u8 devfn); + int (*get_device_group_id)(uint16_t seg, uint8_t bus, uint8_t devfn); #endif /* HAS_PCI */ void (*teardown)(struct domain *d); @@ -308,7 +309,7 @@ struct iommu_ops { int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn, unsigned long page_count, unsigned int flush_flags); - int (*get_reserved_device_memory)(iommu_grdm_t *, void *); + int (*get_reserved_device_memory)(iommu_grdm_t *func, void *ctxt); void (*dump_page_tables)(struct domain *d); #ifdef CONFIG_HAS_DEVICE_TREE From patchwork Fri Nov 24 14:03:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467694 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BFCBC61D97 for ; Fri, 24 Nov 2023 14:05:01 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640739.999438 (Exim 4.92) (envelope-from ) id 1r6WnZ-00078r-RQ; Fri, 24 Nov 2023 14:04:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640739.999438; Fri, 24 Nov 2023 14:04:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnZ-000776-J8; Fri, 24 Nov 2023 14:04:49 +0000 Received: by outflank-mailman (input) for mailman id 640739; Fri, 24 Nov 2023 14:04:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnX-0005N0-TT for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d14d466-8ad2-11ee-98e2-6d05b1d4d9a1; Fri, 24 Nov 2023 15:04:47 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 4B65A4EE0C98; Fri, 24 Nov 2023 15:04:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d14d466-8ad2-11ee-98e2-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 08/11] xen/kernel: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:23 +0100 Message-Id: <2f551139ef5a26b203c6c089947ca4bc5bd29d5a.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/include/xen/kernel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h index 560b1c2832..6bbd4a2827 100644 --- a/xen/include/xen/kernel.h +++ b/xen/include/xen/kernel.h @@ -112,7 +112,7 @@ struct vcpu; void show_execution_state(const struct cpu_user_regs *regs); void cf_check show_execution_state_nonconst(struct cpu_user_regs *regs); -void vcpu_show_execution_state(struct vcpu *); +void vcpu_show_execution_state(struct vcpu *v); #endif /* _LINUX_KERNEL_H */ From patchwork Fri Nov 24 14:03:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ABF0C61DF4 for ; Fri, 24 Nov 2023 14:05:10 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640740.999448 (Exim 4.92) (envelope-from ) id 1r6Wna-0007L5-H3; Fri, 24 Nov 2023 14:04:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640740.999448; Fri, 24 Nov 2023 14:04:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6Wna-0007Gt-3q; Fri, 24 Nov 2023 14:04:50 +0000 Received: by outflank-mailman (input) for mailman id 640740; Fri, 24 Nov 2023 14:04:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6WnY-0005N0-Th for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:48 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6db036a9-8ad2-11ee-98e2-6d05b1d4d9a1; Fri, 24 Nov 2023 15:04:48 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 5FCFD4EE073C; Fri, 24 Nov 2023 15:04:47 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6db036a9-8ad2-11ee-98e2-6d05b1d4d9a1 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 09/11] xen/param: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:24 +0100 Message-Id: <2ef34f3beec85dac126a89c6da1bbbdfaa00727d.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/include/xen/param.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/param.h b/xen/include/xen/param.h index 93c3fe7cb7..9170455cde 100644 --- a/xen/include/xen/param.h +++ b/xen/include/xen/param.h @@ -22,7 +22,7 @@ struct kernel_param { unsigned int len; union { void *var; - int (*func)(const char *); + int (*func)(const char *s); } par; }; From patchwork Fri Nov 24 14:03:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467696 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 379F1C636CB for ; Fri, 24 Nov 2023 14:05:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640741.999465 (Exim 4.92) (envelope-from ) id 1r6Wnc-0007zr-Jk; Fri, 24 Nov 2023 14:04:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640741.999465; Fri, 24 Nov 2023 14:04:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6Wnc-0007zf-Fc; Fri, 24 Nov 2023 14:04:52 +0000 Received: by outflank-mailman (input) for mailman id 640741; Fri, 24 Nov 2023 14:04:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6Wna-0005N1-UF for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:50 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e4b893d-8ad2-11ee-9b0e-b553b5be7939; Fri, 24 Nov 2023 15:04:49 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 67F414EE0C8A; Fri, 24 Nov 2023 15:04:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e4b893d-8ad2-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 10/11] xen/perfc: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:25 +0100 Message-Id: <642bcf2ea2147c797d102a12d51b7eee90f0e5a6.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/include/xen/perfc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/perfc.h b/xen/include/xen/perfc.h index 96022c0748..f9009dc388 100644 --- a/xen/include/xen/perfc.h +++ b/xen/include/xen/perfc.h @@ -94,7 +94,7 @@ DECLARE_PER_CPU(perfc_t[NUM_PERFCOUNTERS], perfcounters); #endif struct xen_sysctl_perfc_op; -int perfc_control(struct xen_sysctl_perfc_op *); +int perfc_control(struct xen_sysctl_perfc_op *pc); extern void cf_check perfc_printall(unsigned char key); extern void cf_check perfc_reset(unsigned char key); From patchwork Fri Nov 24 14:03:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13467702 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0DD2C61DF4 for ; Fri, 24 Nov 2023 14:05:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.640742.999474 (Exim 4.92) (envelope-from ) id 1r6Wne-0008G1-0w; Fri, 24 Nov 2023 14:04:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 640742.999474; Fri, 24 Nov 2023 14:04:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6Wnd-0008FY-P9; Fri, 24 Nov 2023 14:04:53 +0000 Received: by outflank-mailman (input) for mailman id 640742; Fri, 24 Nov 2023 14:04:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r6Wnb-0005N1-V1 for xen-devel@lists.xenproject.org; Fri, 24 Nov 2023 14:04:51 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ee7ebbb-8ad2-11ee-9b0e-b553b5be7939; Fri, 24 Nov 2023 15:04:50 +0100 (CET) Received: from Dell.bugseng.com (unknown [37.161.237.167]) by support.bugseng.com (Postfix) with ESMTPSA id 6379C4EE0C91; Fri, 24 Nov 2023 15:04:49 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ee7ebbb-8ad2-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 11/11] xen/serial: address a violation of MISRA C:2012 Rule 8.2 Date: Fri, 24 Nov 2023 15:03:26 +0100 Message-Id: <4f831a5441ac699b50783fb0559daabaa37b8e50.1700832962.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Add missing parameter name. No functional change. Signed-off-by: Federico Serafini Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- In my previous patch for serial.h I missed one parameter: sorry for that. --- xen/include/xen/serial.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 8d64fb5e86..870ca2f6eb 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -181,7 +181,7 @@ static void inline xhci_dbc_uart_init(void) {}; void arm_uart_init(void); struct physdev_dbgp_op; -int dbgp_op(const struct physdev_dbgp_op *); +int dbgp_op(const struct physdev_dbgp_op *op); /* Baud rate was pre-configured before invoking the UART driver. */ #define BAUD_AUTO (-1)