From patchwork Thu Feb 14 17:36:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10813377 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B762713A4 for ; Thu, 14 Feb 2019 17:36:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A45842ED33 for ; Thu, 14 Feb 2019 17:36:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 961322ED5D; Thu, 14 Feb 2019 17:36:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D8C02ED33 for ; Thu, 14 Feb 2019 17:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437375AbfBNRgq (ORCPT ); Thu, 14 Feb 2019 12:36:46 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46843 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437326AbfBNRgq (ORCPT ); Thu, 14 Feb 2019 12:36:46 -0500 Received: by mail-pf1-f195.google.com with SMTP id g6so3417555pfh.13 for ; Thu, 14 Feb 2019 09:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ylrEXYb2RrtRUg8WjKUyI2ifEoHdKrFAjIqfk9zh86o=; b=aMkMSW3e56BZlwQqOLMerl+LiZUDV6Rvm+PfawEG6X+SdiN6eKD1FbU5Zk+3T89CGY O+93wM1kcvIaLLomwEbCRhDK14s39NShkb7Lv1wZQ6FtwCC/QoxTIRZcJV22R4BywGh1 LnM5O/PD4SIuzRdbBs6juWJMyrZfpitSMXIZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ylrEXYb2RrtRUg8WjKUyI2ifEoHdKrFAjIqfk9zh86o=; b=KjvdvYe5MPbMo9ta75TgKUe4f5AFntl9WGE22DbRGoC3lS4ZeGNWJkJVCmFJs4BiIX 5MB6LB2r5Hm1xUjQZeePZtRpJ/8SPauZeDqygVgNrHjVv26kRfz8cbQ07SpvvLPsdEMN bEo7NSkNkV3sBzuxYXnYROiZvfYyazyXUvI6j1n76Zs2Y6mYcIi5zZAEpaxayXKCzhgc BKrDIMJfRFL6zwe+da2mDr+Ap6Xi6cgWrpgzRpGOVFHDalRuPPhEQlFg8hDDyJ2UTy8y c+Cg6lAJd1zC+SVPFIo+2kbTwchvm8PSxxTEDpmgiw4mMKnM6iGRB+vewfY5S4bN5BfE 3q1Q== X-Gm-Message-State: AHQUAuY/GxwzbhQlmTQ8bEIo5Cz132TipuHtCab0Pf2MdcSewr/vWUsU EVxQeU5Ta9XYV6Hf2d/e1Wbf1g== X-Google-Smtp-Source: AHgI3Ib72prjejBMWCV1UusrijBT8/MogLNJUNDdwIEGmPJA7wlc+RgAoBR17O0NDAyPo9ZyDVHY1A== X-Received: by 2002:a63:7f46:: with SMTP id p6mr4868262pgn.54.1550165805896; Thu, 14 Feb 2019 09:36:45 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id p12sm7618529pfj.81.2019.02.14.09.36.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 09:36:45 -0800 (PST) From: Douglas Anderson To: Andy Gross , Bjorn Andersson , Rajendra Nayak Cc: Stephen Boyd , Douglas Anderson , linux-arm-msm@vger.kernel.org, David Brown , linux-kernel@vger.kernel.org Subject: [PATCH] soc: qcom: rpmhpd: Set 'active_only' for active only power domains Date: Thu, 14 Feb 2019 09:36:33 -0800 Message-Id: <20190214173633.211000-1-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'active_only' attribute was accidentally never set to true for any power domains meaning that all the code handling this attribute was dead. NOTE that the RPM power domain code (as opposed to the RPMh one) gets this right. Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd Acked-by: Rajendra Nayak --- drivers/soc/qcom/rpmhpd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c index 5741ec3fa814..51850cc68b70 100644 --- a/drivers/soc/qcom/rpmhpd.c +++ b/drivers/soc/qcom/rpmhpd.c @@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = { static struct rpmhpd sdm845_mx_ao = { .pd = { .name = "mx_ao", }, + .active_only = true, .peer = &sdm845_mx, .res_name = "mx.lvl", }; @@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = { static struct rpmhpd sdm845_cx_ao = { .pd = { .name = "cx_ao", }, + .active_only = true, .peer = &sdm845_cx, .parent = &sdm845_mx_ao.pd, .res_name = "cx.lvl",