From patchwork Mon Nov 27 06:05:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Bahadur, Sachin" X-Patchwork-Id: 13469081 X-Patchwork-Delegate: kuba@kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DV7ku2DI" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE31D13D; Sun, 26 Nov 2023 22:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701065119; x=1732601119; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jl2n3DOTd1DIka9IKBM+HJnvzYRs320kDKrmGMGFtSM=; b=DV7ku2DI0sYRh0xc32QFihO9/M4fFD51OQzJa7I7SLSO/mK33Jcisb7y KqMag0Xcnq6c3+GpYDmk7YzxkEdttrHmQk9C9ego3B+AxLX3ktS/Y7OmR 6I1CHlzovNt/4QXDNXsv54EdhiYygwduNmeZ2zZ1fjFeM4CIYtgnJsJAb G1IiK19qinE+QUN8IU5qAWb2szfc2Wc6VOsfr3RPyeypkb0MXLZtpx1ae eHrfo1PvdiS89m+En22mS/8dGzJdjg79bVn+oZd/Psr1KD4YVQFz+Y8PE 1NOMXE8Q+ZXLB1hIUf3B/hFMtTXJQEnvx2ZY1Rgi9EsedwLC5y/YL6hLj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10906"; a="11341583" X-IronPort-AV: E=Sophos;i="6.04,230,1695711600"; d="scan'208";a="11341583" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2023 22:05:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10906"; a="717933496" X-IronPort-AV: E=Sophos;i="6.04,230,1695711600"; d="scan'208";a="717933496" Received: from sbahadur1-bxdsw.sj.intel.com ([10.232.237.139]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2023 22:05:17 -0800 From: Sachin Bahadur To: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond Date: Sun, 26 Nov 2023 22:05:12 -0800 Message-Id: <20231127060512.1283336-1-sachin.bahadur@intel.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org PF interface part of Bond should not allow driver reinit via devlink. Bond config will be lost due to PF reinit. PF needs to be re-added to Bond after PF reinit. ice_devlink_reload_down is called before PF driver reinit. If PF is attached to bond, ice_devlink_reload_down returns error. Fixes: trailer Reviewed-by: Jacob Keller Signed-off-by: Sachin Bahadur --- drivers/net/ethernet/intel/ice/ice_devlink.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.25.1 diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c index f4e24d11ebd0..5fe88e949b09 100644 --- a/drivers/net/ethernet/intel/ice/ice_devlink.c +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c @@ -457,6 +457,10 @@ ice_devlink_reload_down(struct devlink *devlink, bool netns_change, "Remove all VFs before doing reinit\n"); return -EOPNOTSUPP; } + if (pf->lag && pf->lag->bonded) { + NL_SET_ERR_MSG_MOD(extack, "Remove all associated Bonds before doing reinit"); + return -EBUSY; + } ice_unload(pf); return 0; case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: