From patchwork Thu Nov 30 16:00:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donald Robson X-Patchwork-Id: 13474668 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8747EC10DC2 for ; Thu, 30 Nov 2023 16:01:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 107D210E723; Thu, 30 Nov 2023 16:01:25 +0000 (UTC) Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2E7C10E723 for ; Thu, 30 Nov 2023 16:01:22 +0000 (UTC) Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3AUDP2tJ019919; Thu, 30 Nov 2023 16:01:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:content-transfer-encoding :content-type:mime-version; s=dk201812; bh=EYK1KqUTDTPl4Z7U8TQ5r WJ9PaZ//BMXEk0Dmej3Mv0=; b=brB+2qiMjxuIGZ8OwyGA1sIEz72wk5X9cneAw nj+mhDptvTxO1AqHWBaGNjAhw3KY9krQZwoKvyaRo8t8vC3usbfakNblbJqi/cgR qadxpDkvGeWgBpdX2jxCRmZ2qDPt43qUb6kKcZEp2Fewinw7bn2YCURlIs0ijNiq 7TwKZ/QNQ7skRQSZv2myOBbSoEO2KOB5i0RNSMpSeVG+PB9/cCarEQP3UbwLy38R pHwDCCTkooKClP7bAupGnF+yVVXiWJ1RQYOeBQKZ60Af9RcLgP40wZgIr3KbgYXr k3ncmPkkPnbXSaZuhrCFvuQwK5vybhSNg6UyXHotaBCWPnrww== Received: from hhmail04.hh.imgtec.org ([217.156.249.195]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 3upgr70nh9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 30 Nov 2023 16:01:02 +0000 (GMT) Received: from HHMAIL05.hh.imgtec.org (10.100.10.120) by HHMAIL04.hh.imgtec.org (10.100.10.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 30 Nov 2023 16:01:01 +0000 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (104.47.85.40) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 30 Nov 2023 16:01:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7GtfIBnrWx8AKfaGyM/sZEY+lK+GneWubR9/USTX28HD+FMzZ5HLXJGtlZegwWHAaHYNoBUU/4GWwRGOwcdrxdRk0PXe0hbTHrj4ECPnRzWCsQFalv7cUknq+mTygeZOs0/hWl0McNf1q59zuNpFKh0250VZA/fd/4MpTnzpOaDoBTxwgs9C31DAozxE0PqXhl69EpSYtA/mSxGTroNtT2A6uOH0VXcLU1o8aiR4tlKr6vL6xIB1+j7Etu13fivMAv09aJkUqeGYpZMxVquFk5YSGz2BBztgY6+hP29njStrRdrLuo+H9UY3fQCw5H6y7gP2iPs660d5KSNxcOWVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EYK1KqUTDTPl4Z7U8TQ5rWJ9PaZ//BMXEk0Dmej3Mv0=; b=BxMsQKgJCi6L8EQDBw8jY5HngNUyja8QEoAo6XvMY1gq+gCKXqDlX/Gf54bv/u6WBOo7KAwlkgdHZYn36n8zTxdOcDcvxkzn5Q5kbsgJj7oupabMq161qK0o0uFiR3Y3BXOkbHhLWs9MPjx6DHX1BhxbQ3SHSWQ+0Y6hwGXLZyxXUyiyvdoAgSlgPqmVmK1Zj+Km54CTYQ+KDE+uYVEPZnZvy5u50QUgI13H7U0vMa1XWsUWcFLOV+vbmiNnh2F7fdU05IRWiaryfX/kOnAels5sCzHDXzorh/Ntxc9JKE/dgCFBeC/9jr+bf2lKFeOhMRotMCXR1lgPUcN6arASgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EYK1KqUTDTPl4Z7U8TQ5rWJ9PaZ//BMXEk0Dmej3Mv0=; b=c39FrDSpG9m6hh9cUiNuGcg9CQt+Hj5gfYA8Xzv7m6pN6WyWfi54TO3tqDpPK1MUQ1K4GnAJqadHuN8TdUchdT5bqM9fEtH0lUm0e555tRZW/uhaBjjyhEhNBH1H843eX0vh4wUOgvn9BUxl/slMVH2426Tl81JHWFK0osmpqaU= Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) by LO3P265MB2410.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Thu, 30 Nov 2023 16:00:59 +0000 Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34]) by CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34%3]) with mapi id 15.20.7046.024; Thu, 30 Nov 2023 16:00:59 +0000 From: Donald Robson To: , Subject: [PATCH v2 1/5] drm/imagination: Fixed warning due to implicit cast to bool Date: Thu, 30 Nov 2023 16:00:13 +0000 Message-Id: <20231130160017.259902-1-donald.robson@imgtec.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: LO3P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::11) To CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP265MB5770:EE_|LO3P265MB2410:EE_ X-MS-Office365-Filtering-Correlation-Id: 248372c1-1e13-456d-173f-08dbf1bd8b94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FMPyjV6qRfpCbdiGlydpIPlCrCebRK/zeGUw3Od1KzBWC6m7inobQHZFiOW1iXFROMrNO/1NnjRqHzHgBizKAbocINjxyzVwRlJ7RCSzdp937d9mpngfXV6TnS4FSZu4nHO6gdIMmp12ZQtnhJC7iAlXk/Mkj7fuNEC7Sb4oc69j0eGDVMYOn5AU3JK/fzLBHmuEe/tFu4Ox3E+1vKmGbF4uEJ/uHvYKHH/5FCHb0I696MBqcysFZctYzlsXB2eoqZQnJZSNE/n/kqtz7u0f0HlDTgCTR9QeXsryr2iZD+BFQFgBptKFZ52LXvDbeiM6FduRmqnGlFSsD0bF0mEo/0mlV6tZO2HCa22gs343iAvAOvUkGsf2BG2U6Y+tGh9sRum8RfB/BWOXaCJdjwQ2hLleDhb7cCMyMBby6aUARiZ1B6+qSBd8Eqqr9ommhsKVgBcDla6Ohk8k/Sr0OxBcy45fwBbOw3JobT8FcO4vJP1HarwtT/sDzXVaoOY/lb11Bs51/z5WRewDmz/DQHH+ocWrxalbxy/oymiIZCLhtLOo3mOXr/zsGELE+vM4pK0pm/fqtHt4hURWkCop1/i4Nr/uEZ6P6niVqjAXbnzYM3WPAyNVAf+RBAhObF2fwgCQjxDjoX+AZshC7SFjq10X2g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(39850400004)(346002)(396003)(230922051799003)(230173577357003)(230273577357003)(186009)(64100799003)(451199024)(1800799012)(83380400001)(26005)(1076003)(2616005)(38350700005)(66946007)(316002)(66476007)(66556008)(2906002)(5660300002)(4326008)(44832011)(8936002)(8676002)(86362001)(478600001)(6506007)(52116002)(6512007)(36756003)(41300700001)(6486002)(966005)(6666004)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rvFEvx1ENBv2d2XnrV+ydSRxxaxFiJ788T/MrE8Vk8CDiKMGH6kAG8keF33XBNTITO374YgG/jN1xK/0zHI1LnI7SZ0UfWfSu7E6vMrNpZEbp/eNSR7vSDuZJlV7i3Q/f+oY8GoMTEwPEzC6RMJEyW9BrsOatHmkGlMHszXCdgpYKrL1g7oee+HugB/ESVVMzuvhatV+VChGGWHkLiswN3cBjqarQSj+0eNJh36X0zmm2dOq/UJGPI4TR59vX1IIHempiwX8GVr1uFDEq5Qt6uGQ0M/T0WTbi1oCQZsRprc3DvE7MI76FlvGeDwvIjGWmL35Oi0td9JzbnVSh1rbSvjptZo8YtIzjYIoxeessO3ry5v2VBYj46+K6QSgUza32kNjNQ7RmIavE0IVsUWh307aqACDGVPdqPf65XPepfaYM5m7cZmHe0gnbrLI+bKFr3GDuXkbhd8/oXc6YMapLmrVJi+6rUvbf7ApzlxdytrcYNiz7aO1pkFnvnzfGuCgscCT2Bsmsjl6PlIZsRrD23gKINBLgOzWV7qTqVT+/4Q7+zlbBJDtxJwzh1I/KNVZK0pbIkOFtXKbEPi7xg99oOdqDL77gDUkKomCGPb1Asa1gLA+w9bf333ZSwBbcMExtOmicQKVVZ8f5XZyNO85jztxn0VKWYPNqQ5o9K2XonqhPQdbx94+643S281UbH9GkU4/GvaRhbZMmmbbHQNTb4h7qrdZ4vHqIaGtQwfLQuryGCdOi4ViG4NMgFGmgW/Klz8IKKTVrY4TH04AtSU/2SPy6FoSufndryQhd9fmLLAikeRybyVBui7MKsaODRcQIV0Deh7mwaUMb4xArco8Fcq8u487NZOl5iypEUv/HinJ0goK9koVrSMUoVLeaebkfghs6BfNs+nAx8EXnwlrsmb1WJD8EjnsihNQGppu/LtlHtIFH2jpYOg8tY0rFAxF3PNlndTVyHMZ6n7qQnG9J34YlrARKJNe65IZkOXC/tIXyP1Fgy37OiBrz+tSOoBftmH/Swxx0oDhNddvEMrUjPusi7xnGH37lUi6qDpS20tZcrDeVOoUUYA6PeTOj0Br7dd0zO7NCLdoNNDs1OFw5Agc64gfS7HfekAvKfKZzw3p7cAGWYSP/SU6cbeiFcvZNU73HUXc/8kV8JZs6wkmTo/qnjRuSo0FjgrKM9YmMwv+nJw7vIbHjIfU5yjXSJYxN7KPdpzq4vxz2CL/wKp+1dIVH8DstfNGzrWr9eA5kDlFJcyBbuxXUrLNt86APvT54ukUMleAKuUVy28IV+Arhpv21RNo90o0g/X4v+XW6iMW8Kh+tVJXZ0ms7L/WktX1Q/+450XDOFAjVVY7EOHJpaLjnTcmgevLqFjxSZqyPQCpkyqY+IvmE+pqZW+fBwpAuZWwB2yGWlO31ntXHHZ13OMYMThEYyDDyUb+LZ/NWk6GSUlFeMAwPGpKwREC01BqFrFg0J/Z45v4IM8XmVbcu704oPzkkAr9qE+6z2aXPwYeNUFK3vtvaauXAzj1rwnBv/9T197mnKQkmrpnJTCZCQLEe8gETSPS1WiovJWja6cPM8eNv4mJd/3mvqgVRkdg5JB8slPpSdTLIbbmiGuYQA== X-MS-Exchange-CrossTenant-Network-Message-Id: 248372c1-1e13-456d-173f-08dbf1bd8b94 X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:00:59.7579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JF7Uc0WMzcRkDpOMzvCEFOEMzGwlnYjX2/wKkQ0vgMNIeG50IrOP9ZJnQF5gOhbel/tk44ErFWfmsuVHuowm4UhQrzT/rTwIuNKrKX78YEQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB2410 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-ORIG-GUID: rLKPciWTK4LyM_Akzqp-J86nkaU1v3da X-Proofpoint-GUID: rLKPciWTK4LyM_Akzqp-J86nkaU1v3da X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mripard@kernel.org, matt.coster@imgtec.com, boris.brezillon@collabora.com, donald.robson@imgtec.com, tzimmermann@suse.de, kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This line appears to confuse the compiler and had been noticed previously in clang-tidy output. There isn't anything fundamentally wrong that I can see. I suspect that it just looks like a mistake - hence the first note. By making the second operand an actual bool result, const correctness can be preserved while silencing the warning. >> drivers/gpu/drm/imagination/pvr_device_info.c:230:47: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] 230 | } else if (features_size == mapping_max_size && (mapping_max & 63)) { | ^ ~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_device_info.c:230:47: note: use '&' for a bitwise operation 230 | } else if (features_size == mapping_max_size && (mapping_max & 63)) { | ^~ | & drivers/gpu/drm/imagination/pvr_device_info.c:230:47: note: remove constant to silence this warning 230 | } else if (features_size == mapping_max_size && (mapping_max & 63)) { | ~^~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311241752.3iLyyFcA-lkp@intel.com/ Fixes: 1ff76f7a5b45 ("drm/imagination: Add GPU ID parsing and firmware loading") Signed-off-by: Donald Robson --- drivers/gpu/drm/imagination/pvr_device_info.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_device_info.c b/drivers/gpu/drm/imagination/pvr_device_info.c index 11e6bef52ecd..d3301cde7d11 100644 --- a/drivers/gpu/drm/imagination/pvr_device_info.c +++ b/drivers/gpu/drm/imagination/pvr_device_info.c @@ -227,7 +227,8 @@ int pvr_device_info_set_features(struct pvr_device *pvr_dev, const u64 *features /* Verify no unsupported values in the bitmask. */ if (features_size > mapping_max_size) { drm_warn(from_pvr_device(pvr_dev), "Unsupported features in firmware image"); - } else if (features_size == mapping_max_size && (mapping_max & 63)) { + } else if (features_size == mapping_max_size && + ((mapping_max & 63) != 0)) { u64 invalid_mask = ~0ull << (mapping_max & 63); if (features[features_size - 1] & invalid_mask) From patchwork Thu Nov 30 16:00:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donald Robson X-Patchwork-Id: 13474670 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC3E9C4167B for ; Thu, 30 Nov 2023 16:01:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5622510E729; Thu, 30 Nov 2023 16:01:33 +0000 (UTC) Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5B4910E728 for ; Thu, 30 Nov 2023 16:01:28 +0000 (UTC) Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3AUCeVEx029829; Thu, 30 Nov 2023 16:01:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= dk201812; bh=f/ESO+IR4Dvt6ZwtVsmSAXfO0zfyDZ0UtbvZktsUoPc=; b=GSK 6VHzuZcOWwGngbMrsXsso5FUdhf+Q0GWzJWgZwUZr7Qy259BRgU+AwmoK6fJMWa3 0Q//Y4f/7VIHdhA4Z9p2AfzVW5vfB9N03OxZ/XWn1Z+hFPHneI/umUhawu1C/yft zJwtgxcXLsAdRSNJHK46AkobnkAqqoigComkEeYn4d66vJXkGiLGADuVUTIX+9Hq sceR9WAMFP/MFBxdrC/7sm9HWPCrMlDH4YMMmIUqWjNYQzkTBRPdK2s3ZukCSUrE p4L7rLmbrGkgSmky/OdaCnN9E5EtgS37oULya1KCHVySidR3txikYzJKC2cChxuq L17XZX20894oa5JsDfw== Received: from hhmail04.hh.imgtec.org ([217.156.249.195]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 3upgv6rktk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 30 Nov 2023 16:01:03 +0000 (GMT) Received: from HHMAIL05.hh.imgtec.org (10.100.10.120) by HHMAIL04.hh.imgtec.org (10.100.10.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 30 Nov 2023 16:01:03 +0000 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (104.47.85.41) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 30 Nov 2023 16:01:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GGYHp/9X4jHH43Zy2jaI3gugXnDo73HuDlI2bqjrASpHGsyLQjcX+/2XEpGAVvsjPe4P6m4iX8hLVufBXuYgQZtyxEDfTpex/3gt5oouWPVVj/Vu4uhFbLdBa5C8NC05ScBXnpCh0qGoDCbxT7rNZGQlJ6gCK7xeLXLHC/tcbu8Ro7FIJiuDdUZFhGjcoVsedo+md5QNs3lB26hVQsFuR5mW3DrTK61emr9J+3ej6fg2+eCHzARYiQPTycDTjaZ9TDvr7y9yg37Yzmxtl3KUj3aTRw9j5dQKw2k25iwU9FUnv0oUQeaTX1JhEzzwv59w0ObNfj/YkfejKO6jewsi1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f/ESO+IR4Dvt6ZwtVsmSAXfO0zfyDZ0UtbvZktsUoPc=; b=maTjSGt/EfXZkb+qNl+Cvd8GidHABxFnL8Wj/wOnCbTqXzmMOgJgQcToM/sUqKcJf8QIsuaY5IGWvWkYV5/Rf/zJZMh+JKU+BFdksYghDv2WmyQQ1achm1zvC+w9l34NHYKWOiCAgtv2WvQ0B8hy+NVPb5cYtnj6W/we8jhDl7tON0uhyfZzUVwUlr8fQatyjvYuEnuBsVj3+CL0j/qthThC6Vkb9nGKMmrd/0iqkNSOFojMVRbE//0xoG/zN15NTpKS2yOgin/wLKIUPb7fzkyvSLJVyOl4TFbd3opBsq3qkomRL6Ban6RXZwvo9UDtr563CszQoSAkuUIrmU9Zew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f/ESO+IR4Dvt6ZwtVsmSAXfO0zfyDZ0UtbvZktsUoPc=; b=l5iXOF8JDQe5YVJsG8ZdgFrxaRwxjN1/RyiS2lOVwjPuL7+ZGqlFEEHMXPaZTqZcR2U6W18/YDQIhLYJK3xfDHEl7kLKW/ul8rVEnk8TjWNt2kdccYJv34Kephy10qiiJfzgxPsH7TM/gN7soOGZNQTgHGgoFMD0PqDBUBJxx44= Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) by LO3P265MB2410.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Thu, 30 Nov 2023 16:01:02 +0000 Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34]) by CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34%3]) with mapi id 15.20.7046.024; Thu, 30 Nov 2023 16:01:02 +0000 From: Donald Robson To: , Subject: [PATCH v2 2/5] drm/imagination: Fixed missing header in pvr_fw_meta Date: Thu, 30 Nov 2023 16:00:14 +0000 Message-Id: <20231130160017.259902-2-donald.robson@imgtec.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231130160017.259902-1-donald.robson@imgtec.com> References: <20231130160017.259902-1-donald.robson@imgtec.com> X-ClientProxiedBy: LO3P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::11) To CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP265MB5770:EE_|LO3P265MB2410:EE_ X-MS-Office365-Filtering-Correlation-Id: b40dfe32-ccb8-4b33-a585-08dbf1bd8d05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xRK9qDlaQCy1RKBQF2oLm0hIQLMBtHXdAOARqHWtPy2VcIu1FDDH+OJ3p6xih7UXd+pbbaBV+leo2YXcv+BzgpYTG0oRvUh8CBee4HQy4rPy6vdtTI9bv7JC2PHo5pVjQzLn5x/AFanzazT7rpZmHLKC0Ka1ByFVJ48U4IsxHwyexuFQ1EKJpnf7sYnYMUddPLFfna7Jd11D+Kaqy3eJASjxVlJuKMDvQ0dGhFw+PVAiI+hjXPFxz5WfnwSkI182Q7vtUEp0j9sxGiVNikRFDVZn6nBwawyW4BHtfP4ep5hVgHm8KzYbFhAag2qzrLqwyGFSgDa4zwmeeez76Z+l38k4UNIXV184cX0MmXPWUCmF45Lcmma202ockQtlUzWhH1REM3+JR6SJXgCh76CRu/8OunGAXA0mnTgydFfbr6PGxN2JF41ix26o5UWEAQIc9DNqczsEbYSb3jcSul6Yb4nMPH+CxkJT0D1FKfaM7SNhR22hmS9VVkWgYObsWJisXe7m7Uek3DDbuE0yzrN/5zL3lP4kleZiZ0wQA7u9gnuCuAiNnw3MiUc/Q6k6USrqFDXADF0MsvMSBgMQ8EKeMymSddAMS5/+CXIZWhiRjFatKsKeoZCnaXQEAOVIOpCeZa1Mx+uhYOYufgK6FU+WfA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(39850400004)(346002)(396003)(230922051799003)(230173577357003)(230273577357003)(186009)(64100799003)(451199024)(1800799012)(83380400001)(26005)(1076003)(2616005)(38350700005)(66946007)(316002)(66476007)(54906003)(7416002)(66556008)(2906002)(5660300002)(4326008)(44832011)(8936002)(8676002)(86362001)(478600001)(6506007)(52116002)(6512007)(36756003)(41300700001)(6486002)(966005)(6666004)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8hgHos+JUJJ0DIXzQh6Q38EQgY3PMimOgjrHeP/1QqQypbJoLFdw0ZKNC7Ye05tZXKErHfq1+RXhWZeCl613EssEE2iawTdgkckMMAI5j9WdzUlyigOerx0ASLrpAeAhGe7Vfwzf2XcGy7sByU5aUX2FR1VTKj/rwQcUs+Wn4+kUGZ93j2dQtAPHlhw2hMeRHWE9Dhi0j7xdFGi+Tv0z/IEeW+ETDk3ndsIP/pI7RhFOhPdBmTVPd4xEoC9UMB38Yjq3swst9z4VLYPN3oUmcZnRK+n1Wd0el0N3BeMLEFSRm9u1LOUt+dNG0lMljzc5fNitcYK/WBO56LbhjIeij3c00LYZb0UlqtQ4lAoPCqfvBEYXRxZkDq2mVtvrhy/o6wne4xiPMIJhoZgR8Ym84sb81Awfor5+mhFoaukD0o/TwvbEIgKBkkmkEgRdyO1WmEY4L3QMbd4pVceAwHDvTOLc368IAjRoTxnwLXq2gTDNXLqrsEljGCImfx0r9NrSFZlxaFywdYrNx8oWYhJi4cHSSlPoOKWtziyzXlVkqpcqwPJxcawlx6aczBRcFW1foc3QY9g+KeRdkCdU05WV8HokvOYmehcj6EVBYkXZMvrGRMwDb/lpVtqjlKg2rh1SSyvkq4gLzsMqhTMmxXfCAdHxBJ1U7wVrlWGO2kpZVfNzLkBxyTpWT94u9bKuLeKBaF587vtJUx7NPLgsZiec4BRD+IOXheApEYPa4HxicsnlLQBWjUKsjiUatv6PyBkplJGJJjEGtFf7vYrfdp3W16tbl+oKjesie14bmb77Ni7xWnpRM1d56SQoz0AooOGBV+ACD+hlWbN1nwbJKuqLZ/BgKVNTevuwh01IN5fGCJocNw0m9Wta/rTpK3uiFPp6wBZ7tKtAcHqU/NuWsw/+8jwYTg18uS+4NSD22DT+iQe/Py+W6VpLRQZFRtpUQRib9ylcR3xA+Rwnfm29wX8s5XXzor3zD7OSM+2BlcbjiN8UNvLCm4T1gNpNr0I4yG7YER/29jTcu/KfxLR5kxuUj8Eh7rjQyvOqsIiPfV65yuBNKpBRDs2jofGZLRgkCXvkSS8zvBLVdknbWW46wA23I+KEhlelEQ5UT2lt0iv8p/oBT/qqKdxHLE1Su0ZmQZHW1NtFgjgEMqyGaTGv6AjgYBOYBjzylecfoXodRkoaJIgldpv5QHIOSh9Sr37eXZ0OFiMVURksklupcJ48vxeYPHxArcX34IglOZVhJ+KMIB+UVZfYQ1vAPpxlXdaxmpjGgRjj3ZhMDfnKjcXkELDYL3d+LrKqY58Ehk2Qrn9CoU0zSFGbW/9+iDgkaY7NqZL9tPUtVlNXKAf69QrevgDee9oK6wKZEjtOvicX0aQSbQ2ycBKdW3bX/X/ATRayKCCqr+5AyX0BDx+pfANbshUJ4ldXReVsq2D6ed6MqwLuWIXOTo5CjnELNfsvD/+xoI6hWMjCIIUjsPn4ezl65EwF2SC/J+3Jsujs53tPowa6z41mwVKwtfkPbXG/rVXo+7b1fePeaa6UVAiVvPxlGBd274ao1hMY0mHUfZ0NXo1z/0siop9kI3q7oJlzAE5FNXmHJwhdauHK6QBFc6Qre3vMEA== X-MS-Exchange-CrossTenant-Network-Message-Id: b40dfe32-ccb8-4b33-a585-08dbf1bd8d05 X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:01:02.1333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q6w32yHbcNZVgRVFfe30rptIrbDKIRC9DBOj1XcgUQVFA3TUJU3BAo6p/Ay5S/HXWgK/3ez5cZEn3//nt7DJnzXMEQS7vLgDuWQ65XnsPtY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB2410 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-GUID: RyEW2BchtIfUQ9tgvQAXs0xA0F6iXxGZ X-Proofpoint-ORIG-GUID: RyEW2BchtIfUQ9tgvQAXs0xA0F6iXxGZ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , mripard@kernel.org, matt.coster@imgtec.com, boris.brezillon@collabora.com, donald.robson@imgtec.com, tzimmermann@suse.de, kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" A missing header causes the compiler to warn that the function below is not forward declared. >> drivers/gpu/drm/imagination/pvr_fw_meta.c:33:1: warning: no previous prototype for function 'pvr_meta_cr_read32' [-Wmissing-prototypes] 33 | pvr_meta_cr_read32(struct pvr_device *pvr_dev, u32 reg_addr, u32 *reg_value_out) | ^ drivers/gpu/drm/imagination/pvr_fw_meta.c:32:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 32 | int | ^ | static 1 warning generated. Include the correct header. Reported-by: Arnd Bergmann Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311250226.Da2yiSKp-lkp@intel.com/ Fixes: bb52a8dc84f2 ("drm/imagination: Implement firmware infrastructure and META FW support") Signed-off-by: Donald Robson --- drivers/gpu/drm/imagination/pvr_fw_meta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/imagination/pvr_fw_meta.c b/drivers/gpu/drm/imagination/pvr_fw_meta.c index 119934c36184..c39beb70c317 100644 --- a/drivers/gpu/drm/imagination/pvr_fw_meta.c +++ b/drivers/gpu/drm/imagination/pvr_fw_meta.c @@ -4,6 +4,7 @@ #include "pvr_device.h" #include "pvr_fw.h" #include "pvr_fw_info.h" +#include "pvr_fw_meta.h" #include "pvr_gem.h" #include "pvr_rogue_cr_defs.h" #include "pvr_rogue_meta.h" From patchwork Thu Nov 30 16:00:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donald Robson X-Patchwork-Id: 13474669 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFCA1C4167B for ; Thu, 30 Nov 2023 16:01:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 42F5C10E728; Thu, 30 Nov 2023 16:01:29 +0000 (UTC) Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) by gabe.freedesktop.org (Postfix) with ESMTPS id D567310E728 for ; Thu, 30 Nov 2023 16:01:26 +0000 (UTC) Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3AU802vs013880; Thu, 30 Nov 2023 16:01:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= dk201812; bh=GjLYn+xc45MkLKwkxAhfqk6uUXp3h46M5oX8BDxJ5s0=; b=mAE QGXfS31L5LROPH/x3Xzh4ltjFCngEd+SH78ralvtakcten1LS1df/DPDQFDoRuoS zh5jAT4FssgfOu1H3gMsMWb5YFNqt4bA6lp5kedq6FmnmD2mMAmCLI86q8ijhzwS gdCNzHoX1Ux8CRv0DE7niHbSEWAbV+u2+gU5FWKO+3cB60qzPX0KIxsRHfC5ia+D 4fNSs/D3li0qxIK36qbGQCmXfcDHDsfk4aaSfg5wMympdl/jgEAz4TsguhyT+D4O OWbCrGwyoY815+Uys6lx7IYaHslDg3MbOTDdb9zgdyCQKNnU8Uuf5Rsbeqli8rkz VfNIggexDBwAZ8uD4og== Received: from hhmail04.hh.imgtec.org ([217.156.249.195]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 3upgr70nhc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 30 Nov 2023 16:01:05 +0000 (GMT) Received: from HHMAIL05.hh.imgtec.org (10.100.10.120) by HHMAIL04.hh.imgtec.org (10.100.10.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 30 Nov 2023 16:01:05 +0000 Received: from GBR01-LO4-obe.outbound.protection.outlook.com (104.47.85.105) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 30 Nov 2023 16:01:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jswq3P3ZWNKRWYrM1PzNPVeRjKUnZcGWMo+24NUX+PB+MjYaWapoHpgKulOXTtPrYnbl+IWdyLoDVOE9oPNNS7lP+87a8goZgkNiKZV9zNl/cXJOP7MLHSpuuFUoI68amIBxFaaqJnUf3pNkiLeHMqeoIorWXpUUIeOC7u2N7kSHEfKeNVLUbiMiLyCXolQyCzPnYl0aTDxA3XkR6o0/2IQMAF+tkn4EPiiaZmOor0EkRJaKPjpQc/S+S3r3QLXKzghK7mwH2XSfzeJPhlLl2LRXTtws09ukBjiJhZNiBZ6MPXMXACp2d/U4THwy0TtwJt00iEIVVqjmEN/Ej8ihLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GjLYn+xc45MkLKwkxAhfqk6uUXp3h46M5oX8BDxJ5s0=; b=BfoPa9UpW8w5ZWDXoWzSfNJqBDxU41pWTEvDRw5EZyvSBLWpozKAd2X3pgviI7bTKKmpBnzQlmb/+64vRIzL7d7lumLizYJFr1Q7ABJYt1ftvMtWDvh6ftjFLPveSyu07/dLUQ9Wew3BV5vG64NJVZX/4Qb805N6vIli53pyCJS9hq10bEoS12PD79+orEVgqYWkkPrqL9TId/zX8Phe5t12VwP587EijJqSH/AH4ECL3eNE0FByZoFQOUYIA9r3/tm24gbdjrwVcW8O3HC/eMhwRL3sqDBacY5OphqF6tFAle3pGe0gXe/otkGT8Em33JikQ8u9CZABhXKiH4Ad3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GjLYn+xc45MkLKwkxAhfqk6uUXp3h46M5oX8BDxJ5s0=; b=cwhsyqM42XHoDJpNeFl+J1HO1ppNN9Y+9zfgXQTee01AMDnd68oPlXeYV9oftXf9WrXPVWsU+4LF8h4sAb8gjfam0IzhnNPqBCUaTVFzFQ4R0lJ/aSNYjucTp9XUYb94x//8O/UlTM41UjhW6nd3j7HsvVHN8HuCiewZ9qgNXvs= Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) by LO3P265MB2410.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Thu, 30 Nov 2023 16:01:04 +0000 Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34]) by CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34%3]) with mapi id 15.20.7046.024; Thu, 30 Nov 2023 16:01:04 +0000 From: Donald Robson To: , Subject: [PATCH v2 3/5] drm/imagination: pvr_device_process_active_queues now static Date: Thu, 30 Nov 2023 16:00:15 +0000 Message-Id: <20231130160017.259902-3-donald.robson@imgtec.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231130160017.259902-1-donald.robson@imgtec.com> References: <20231130160017.259902-1-donald.robson@imgtec.com> X-ClientProxiedBy: LO3P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::11) To CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP265MB5770:EE_|LO3P265MB2410:EE_ X-MS-Office365-Filtering-Correlation-Id: e27b8734-8b99-46ee-37ed-08dbf1bd8e1a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NurumudLd5fzmbajAmF+W6tcLKSeerr312zUZATwVwL1FJ1uFv3oaGESxWxKJEH0WA5P671I2ehQZPavRxSH06x/NzwNr+1CGldHxLgZQ1j1hCYITkYjLULBE6MIkgm86PBzKK+7hv5xOA1OU+mllCcsfx7kauqyvRn53lLKAunWAFv6qLwhdVWZqMbp2EPPYofzchmEAv0okSeipqpcu/Am7SBsT5Iu5TQqIG41Mmjs1E8zCYt2nnGsXwV43/v5sXrq+OVGtF9yBZ2S2K94KDQSLJIg31o8cuIPLv/oHgv1jsq5ILvrRxU56IW7wd7Vh6HCmXirmE2UlgajVhgkINA2kg3ddPMGVB+UBHNDnocwBZoyuu7FZki1JK5/vx0AAsVLSlYTtNXcnm+J+WIltXUXp5kb2XWZoUd4hoW2t37mKFq3CA4Re0ZD3A8uxq4II421n2CK+b5wHtSXAL3Y4yDdQ40qcBLKLYFs+2jkd9RZyYjtT+ntXFWned5tS4kj+9MNuQK627yqv1mjb/eaxyeQfueorMuSZF2FBemz2rfa6ALmiwL8J92U055p4SF0zLIi8abJWlBGrvqJoZssyVYreFTEOoKqkraDA7m+qGoURlgiamUqpovtXwoEwc9FLpQ43qpFRzIN48opw7y3MA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(39850400004)(346002)(396003)(230922051799003)(230173577357003)(230273577357003)(186009)(64100799003)(451199024)(1800799012)(83380400001)(26005)(1076003)(2616005)(38350700005)(66946007)(316002)(66476007)(54906003)(7416002)(66556008)(2906002)(5660300002)(4326008)(44832011)(8936002)(8676002)(86362001)(478600001)(6506007)(52116002)(6512007)(36756003)(41300700001)(6486002)(966005)(6666004)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jKMP+vJqX8H6rVdktp02TfhDeFbe0Cmx6IJd1Kb6Xf6pHLzeGeXJeVFpxe2oIdQu1EPCm8zCn0xcsNu/Ct8yhuUaSItEzVZVxTAH7JRrTwIedeoTdYaw4w6SvAvAhlcBlYgo64PcCBolid88UYAqbX5a/qStVMRGh9YNohuYLiLXX7KUNhAiXdqgU/D5itV423nAcJA4jaJQdvbE7J9QSO0PrSOfkmbiaRteO+FzvYfx5Lx0A1kmI3HJqLfzshcJ9z6PRdhWcrBuYNYt/YgAgpKH0rfFKFEdAA6teb66LbWl77yODUCs88wVCd8eAfQqKyWV7r+udG2IHsLm0hl4tdcUhuz1vu2ZHmH1C182bF26rVjLPZ1ZvLwCmZjRe+Qq82qTPE4NK0e1Y6p0pUSxbd7QJACozkjFpqqlDjrxqRLYcjo5rb6BXThKO6N44CxlWvCId9jVATF2ROBrrJClGqvV8GQWeS1aCYt8XROarw5sz9MRuGAb/u5sA5AYCdBvtZZvCk9HFlnAIxUc+aKK4rL7xcyZ/F6a3lnirXXIWqQbEBymi5VREUXtvKOpUGUXla/cdPODne/wQaRAtUn26z8KWAahwWC/ZYg5sAXSO98c0iAH1ywQfsnJVHIyPs5mpSS+yoJgB6rAMQRv2QG/1r/J8rtzsbiYhTvGrBGxPpTZs6NvyjvmKe92FWb+ZbVsXbI38XXt5mOGmogKktgFiJ5mWaMulaUTUUzvTXw99MR8HwrMrKLviO/4nKchKwbIGhBQEu2j7bhU7NkDry+MMZyJZ9XBBmMgGB+VOYVm+n6E9FEjp/thOP+NUSgMiuAcerM86NtiOx2aKbIFOXpcoi0nPARBBElk4RL3NOFWN49ar8TSChz8akdR9cVxshiGmDc1X5RtGADhQ4T+BLBVjukVGo/X0s+fZQVUpp0H9xfM7b/YIH2qNnm0P6gWF8KwK6vYM+6nJA5LTfDEr7QbygmBIqjzDAkYk6ylbJwdv4BHQfWP1UWeaR0skrwnPga5mMjXbE6ExHRGQgSQOeOXBSN23otX/WTXl3VPJ/EOQ60pNUadU1ncnbF78o9VI0Gozc8AHPdAu+MYZZOFWfNZ4rvv06L6SJrN8i3dG7XQW3jV+Wszgtjs4mWUaPL0P6Oc/39Q5RD0NBJ4QGA6fia4WrpQN4iSOBkhZdX+bx8jQiEITQPKRE61OeUVxVvCskRWjugGlH6JlKPJXeh5RDW5q39VyfAT8TKBJhizVM2H6s+CUoSoPr9bMIqksE3cmE5EyR8LrGrEnYFdKNOh99hInijOX4vJQBN8evCHeDKi4R0XD/Lnd6+MiQhBG+4JzChJiu1xEdTBP5LZdnhMslVcG+MT17XktWxVBR98hC+jMgG8GYFeh6Ojdw2v2QiJwCd02fuImhxFbR3FO7uUyF2BAKxOQfSpvG3uohqa2JGFll2YipzMTd3b1NRoMmej8wQQImkLjowp5LEjCcHrH2IhL8mhZTBdtjlmEIaIg9rXoB5m9tJPPk0bHkG8pH0fbmqSYqd4p+zvnOprcYrENefFgmqy8NXtefY47Tmp4SwRpW9PMA2yqFLV3xEkWENgPowkiTLB0t4jcqU0wadG7tbrDg== X-MS-Exchange-CrossTenant-Network-Message-Id: e27b8734-8b99-46ee-37ed-08dbf1bd8e1a X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:01:04.0188 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UuWFxZvTMFuCn6i9J0k3ElLVS/qtA5KoBepCIW80R6N/Ejmbx4NxQdZUyrAZB2Wa5e97Mm9cvGbG0jt6YIri+68vvHkQ2E8aazPWXFm2f5A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB2410 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-ORIG-GUID: Q5128QbsUAxBhDNJX2n8Gw3tuiXdkRjV X-Proofpoint-GUID: Q5128QbsUAxBhDNJX2n8Gw3tuiXdkRjV X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , mripard@kernel.org, matt.coster@imgtec.com, boris.brezillon@collabora.com, donald.robson@imgtec.com, tzimmermann@suse.de, kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The function below is used only within this source file, but is not static. >> drivers/gpu/drm/imagination/pvr_device.c:129:6: warning: no previous prototype for function 'pvr_device_process_active_queues' [-Wmissing-prototypes] 129 | void pvr_device_process_active_queues(struct pvr_device *pvr_dev) | ^ drivers/gpu/drm/imagination/pvr_device.c:129:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 129 | void pvr_device_process_active_queues(struct pvr_device *pvr_dev) | ^ | static 1 warning generated. Make it static. Reported-by: Arnd Bergmann Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311250632.giVEx7MU-lkp@intel.com/ Fixes: c98dab7a5f5f ("drm/imagination: Implement job submission and scheduling") Signed-off-by: Donald Robson --- drivers/gpu/drm/imagination/pvr_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c index 8499becf4fbb..048eba776cf2 100644 --- a/drivers/gpu/drm/imagination/pvr_device.c +++ b/drivers/gpu/drm/imagination/pvr_device.c @@ -127,7 +127,7 @@ static int pvr_device_clk_init(struct pvr_device *pvr_dev) * This is called any time we receive a FW event. It iterates over all * active queues and calls pvr_queue_process() on them. */ -void pvr_device_process_active_queues(struct pvr_device *pvr_dev) +static void pvr_device_process_active_queues(struct pvr_device *pvr_dev) { struct pvr_queue *queue, *tmp_queue; LIST_HEAD(active_queues); From patchwork Thu Nov 30 16:00:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donald Robson X-Patchwork-Id: 13474672 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0030BC07CA9 for ; Thu, 30 Nov 2023 16:01:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32F3010E72A; Thu, 30 Nov 2023 16:01:44 +0000 (UTC) Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12D9A10E72A for ; Thu, 30 Nov 2023 16:01:33 +0000 (UTC) Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3AUCeVF1029829; Thu, 30 Nov 2023 16:01:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= dk201812; bh=4hZNetOs8eSwBOMBCT02ypcuSEAX0q/GkCf3Jofd48E=; b=sUh FCjRl/qoNfaWzpT+tbzfr096zWRfEmnNuKaCyInLqastmIBNG+AsOOXcaijVKiTj sQV1ggAQ8mymUM/W1fXEdNYCzoCnMs4qCFIyDMzwxTTH+nJ68N1N8mi+XBNOAqJO YRz5bv4nO9SyvTv/tKQG3rVRioUh5Hxdl/Hgzke61cahN/nOxNJQHy0OdLEpO7hL hliwfEYCjz/izHyO2Fg0kk6/QjLSrxdkYLAScMC/dUL+8Bbvi4fmhA+Ki4IC9ESW hBt+4JM345qItQJUt3hSAkmNWX3OD8gCuHyt6UV35zvJTYCS6YSUIpRAdPIhsiU+ zXJpCN8CtUe/a6u8ndg== Received: from hhmail04.hh.imgtec.org ([217.156.249.195]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 3upgv6rktp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 30 Nov 2023 16:01:13 +0000 (GMT) Received: from HHMAIL05.hh.imgtec.org (10.100.10.120) by HHMAIL04.hh.imgtec.org (10.100.10.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 30 Nov 2023 16:01:12 +0000 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (104.47.85.41) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 30 Nov 2023 16:01:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZ+B1nYOpX6Y54SuEs0/To3pDrsU8K9eVq4MrpZW9XKcgNlMWCR6jBY2fmA68xZqsgdKrK+vHl4WGlfnmdsaWR/edsbYjgEBWxq3WoHPakwR/psemaURCSttbFQce2/VRYht5JB1ivXbAJ1qQ5bPyyQHJTFUjTi5XjoOPb4YOZS2fBeZkUL94IzTl9iZFxFOm+/dIwc6QaBfU2dyPaYc5hd6Bvxe/wgtAi+nbrjV8bySfL13wL2O5S6VADejfsjeqttU46pmyLCb0qh0/JSQwJZffE4+Wz1eFPWpv9sCVblG8qhQD+LTEKAJcOzfnCP/+6DmUdcWbNc5CooZHoeQBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4hZNetOs8eSwBOMBCT02ypcuSEAX0q/GkCf3Jofd48E=; b=daT5SPzLDkDM2AZnVfNBl9xo+SprgnaY+gzQ4DpdB5nt52gt3At9X8OPpwwowgVbdsjaYNV1CgcnXypTM+lLzYxw+E1w3i1O8+LCNicJ5yoNo1QEbJOVFrGu4rvbF+nRK08+KYtsJAcWTWCgo2mnF440n/DbQ03FniwQM3DkzKhyo4x5JN43cD97r9754M+4s0jwNfZoNQ8ZjsYuFoTGb9Kj9DWgLGsQHHkCsBWahPo1bR23mJO9vkIDVLsdVfMbpzfIXdQ51kxpRNpRegKUOk2JthB8zggkWu830Q0f/WeTzTflJJ5FIeGpxKcrV2rqupMZZDODJaKdkNz8e+NfIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4hZNetOs8eSwBOMBCT02ypcuSEAX0q/GkCf3Jofd48E=; b=laSq1JhlgjpwkvEzZzWnG3UTTsTOwpmjjw6IMRNVw7QCeaciFPeNcdV7+dn3X+jPB1VUru9kUVnjREe/U3VQDWsajz+zKhfYT0QbZ85RCLuDG69J8mXxmmktkuLOSQEOy892B3Y5yq1W/iEb+pryFmRX7Fw9JuCBV2A4VHOZ0aA= Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) by LO3P265MB2410.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Thu, 30 Nov 2023 16:01:06 +0000 Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34]) by CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34%3]) with mapi id 15.20.7046.024; Thu, 30 Nov 2023 16:01:06 +0000 From: Donald Robson To: , Subject: [PATCH v2 4/5] drm/imagination: pvr_gpuvm_free() now static Date: Thu, 30 Nov 2023 16:00:16 +0000 Message-Id: <20231130160017.259902-4-donald.robson@imgtec.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231130160017.259902-1-donald.robson@imgtec.com> References: <20231130160017.259902-1-donald.robson@imgtec.com> X-ClientProxiedBy: LO3P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::11) To CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP265MB5770:EE_|LO3P265MB2410:EE_ X-MS-Office365-Filtering-Correlation-Id: fd67838b-bb71-42a2-b380-08dbf1bd8f78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iNrKgTJ1hHoiv/8khq1Rpzz0jr0+pvlCUe3mSlyUeKwvT0/ouCpPgdQcdd7w6G0G9VfMNlnTBS9kC1Th04blrchC8GzlmRfzBuxepcJd4X2lySAHVFD0I/6SBcnYv6hbenTHasJEGSljY/XiumT2jtzuq2AS9kuVcKT2WwscQLrTjzaqTEVOnFg6oNFiM+J44DV2JBGO7yX7WU3ahqT7/ST73mQ9QLxpyMC9n4EBVYZZA0UoaljK3r0NVn5ULozsf/QrIYtr+M04/+TTi6ucCuo9CN+opp9wZCEmxjwcDky8rMRs3E4TFr4QTzE0wwMtru/41SugWAvPcsLlutb8UBKktnqR26WBn3oGjSQsGx1/0inrMvY0QD3kN+6ZpVIQn0DHjevzGX/jVrG2liD75f8vZDRKQ4LtmVx+/zSz5WAzUEj7HACXDmVLGXLirTW7DNy9X7GeFjfRd9hJrCHVDWW2lZf24dEsZa+pItM2V/YhLnC2zM/dJj1KoVjxjiUt8BygLmY/EGc6mukGf5NSA5kP6wrNL53xbdbcZ2ZLHiysgFbMIOsKUnByOf9SMjWB4nxcr/BsixpgxnV+g3fdtISZm2DsH3Xwf6ckGtXdp6U= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(39850400004)(346002)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(83380400001)(26005)(1076003)(2616005)(38350700005)(66946007)(316002)(66476007)(54906003)(7416002)(66556008)(2906002)(5660300002)(4326008)(44832011)(8936002)(8676002)(86362001)(478600001)(6506007)(52116002)(6512007)(36756003)(41300700001)(6486002)(966005)(6666004)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1uc0d6Ei1j/RxwKbrJNydozEInn4HASyKbg6qt1Qj4UjEtzDHAdv/8ItNDDU2sYOrFAgN6IWJnUS57yFBsxcYWFHimbmHxdMZ1skq/Mp0KRR4t5oHfHjFaXyC24+LooRcPg3z7oL6sYarF/skmRBA9KZHdq/qt4zQ4SuqEbdPynEGhoMFbY5RA5h8IsI+fc/ixC/v4ObVX0U9bVzxx9vgpyLccwV4Z9sy+0R9LpZjpxKdBiCztJXJ21yyhjVpRgmN0bIRSv1Kw8vXKp/N8JvSNAir7rs1NY1gmxM9ozie2zRqr/W1rKefapp4KlcXh7tmRQGTXkwQ7mhGj3QjLoB/RoKOgQp+fmG6KIN1+EnQ3panlX+CsmoDCcsIrZwm3phK4qxKay/vRJlQS2iqwS6OYkYnSL+DEZmCZgzrtjfXBsgADSrhwtHyn5npAaFORM5prW+pNqLub1ER83s8zD7QkWlLJMC7Iaghdmv4qINBJ0ldX+HF3QvMc64DZbsnat0dgLUAB/LIpNVQYIkZ7D0cjhZA9N9Rvq4BrpXz8w5+iWrwMpnXAB5nXnBTlE6rWCStR3H3TEpAOs1xW9ByRGGY/MWVtx+sf9w2azWEXLgcEsXOOmTfmi8sRQVCx+f+c+BA90poYdP4lB2ci5Y66Jgo1wLbPACYqBBA9t8CtmwZ58dxBnSzFkKG2cOTZ8i0148LmPKZrnUUy/uGeOOwxDIRTkvkUHK4aPH1AtNvR/NnfvHFN2CGGtnXznwdPUAyQEOLPrykjWGNuEr9WtUSctjo+dfwvuV4XP+G/mbgwqBgX4TOMhK+mZkDOkdTuoxjVbJFzmRvZTgQdCGyYACBddNBY/OjkDm+HbH9jGDm9i/utNec+TKSwO7LQtNHCdVzU6wAwNL5lJJOCdbQoO26Dzl9/NpX8s/JKO0zW2PrPqN4WIu3V4j4gFhWbVmqYSogZHJq8ONBeV2omqB8GNqxO7tB+k2IxNkm+GkLwSoco5JIkJETrbTLzbr/yPS4QU5sjfUoNW1x/BMXA8Ya2xh1P6n7L/jFz8VDPOKzowJgGexeyU2S2plEJod0tCNhQ1/TkuzJ6JomExM9BpNQoxasTUh6zWJk7Ijs4cmJuVAz0HfotJpCxBF/JlRhOnUsHM0kq0KCV63x3p7GHFmSJlr+gTUN/5W8nPwxeFz7i+3Jbnt/V/V48Plh+yAwO4uOl5ao8dcfSGqHCP9ZmvZPD0pxua6FFCNqhq1QQRzXtBiFGpZLcSl0eVEk8lklFRBcCqxpKJCpkpMkEwXbviGWVXMYXg4wL3iAu29vtBXjzROlSiCBTYMLXxjX7NZF6BoguPRRaRXoS1ty/xCL8Ix05bI0N5czXIBXImrNuhY+VvufU4/YuE608PF8xzvz1RZJ5Y2OJp7ipBPMFojyylMHPgSwrwYaKPdn8ObFjU8eynFsbOwfdGKcG9QAp6esd0NuY2jRC+3yy+ywgpRJ4Zf9SrALe2+1VL/s7i0y3Vhpj6V4GhaH45y1Ie1Hrhu94jrt1mt7wXQKkd9JPpkDULTeFdCY8ygH8Xu6xEr4vAPKvaGBaUqriNRlbNIPgzVSDvxWW5IEx3+N9mZ3IuHv174NTd/TJmxnA== X-MS-Exchange-CrossTenant-Network-Message-Id: fd67838b-bb71-42a2-b380-08dbf1bd8f78 X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:01:06.2686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hqSnXDuxuoZKpnN+7OQTpel3J/Bvenko4G5wZfUrAfzlgAeMXjK5ycCCKTc9SAMjlJ43CueFvVYuOUlMpuMTOWnv1odT7k5ELk30Gb8jUR4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB2410 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-GUID: J_ptqdC_YBwTErol0LwBiNr3Uc1BCP4n X-Proofpoint-ORIG-GUID: J_ptqdC_YBwTErol0LwBiNr3Uc1BCP4n X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , mripard@kernel.org, matt.coster@imgtec.com, boris.brezillon@collabora.com, donald.robson@imgtec.com, tzimmermann@suse.de, kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The function below is used only within this source file, but is not static. drivers/gpu/drm/imagination/pvr_vm.c:542:6: error: no previous prototype for 'pvr_gpuvm_free' [-Werror=missing-prototypes] 542 | void pvr_gpuvm_free(struct drm_gpuvm *gpuvm) Make it static. Reported-by: Arnd Bergmann Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311242159.hh8MWiAm-lkp@intel.com/ Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code") Signed-off-by: Donald Robson --- drivers/gpu/drm/imagination/pvr_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c index 04f7d0cf4188..89eb6ee1bbcf 100644 --- a/drivers/gpu/drm/imagination/pvr_vm.c +++ b/drivers/gpu/drm/imagination/pvr_vm.c @@ -528,7 +528,7 @@ pvr_device_addr_and_size_are_valid(u64 device_addr, u64 size) (device_addr + size <= PVR_PAGE_TABLE_ADDR_SPACE_SIZE); } -void pvr_gpuvm_free(struct drm_gpuvm *gpuvm) +static void pvr_gpuvm_free(struct drm_gpuvm *gpuvm) { } From patchwork Thu Nov 30 16:00:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donald Robson X-Patchwork-Id: 13474671 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2930C07CA9 for ; Thu, 30 Nov 2023 16:01:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 597BF10E72B; Thu, 30 Nov 2023 16:01:34 +0000 (UTC) Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) by gabe.freedesktop.org (Postfix) with ESMTPS id C632710E729 for ; Thu, 30 Nov 2023 16:01:28 +0000 (UTC) Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3AUCeVF2029829; Thu, 30 Nov 2023 16:01:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= dk201812; bh=h3RV2x5k1HOGTrlJIY8d/m7gbws6MahuRj8Fe/I1AEg=; b=clq arNNpnMPn735MY3ZLUW/2sGS4uX6bQH+QPm0c+3/HLYl5aKpV2cpVtvzntxY+HLo z2oudgOVxjWPIwYfYPrz8qVLpv9YalYmzr9PeCCxBRug7f9j+LjJuQZY9y3WujiP vR8mi6KZfoCCJ50ScLlCZ6bDqfbzyIfFnhT03fCIopsVRjaNz0eC+YSEbKzane7M ue95YcECmBgTiunFzmoXFRpJDFW1v6UJYTNzQj+zCp08qjGQ1i7zkR9OqwJk/uBx pa4eIJBzcVsiItCUNqemPEDTFejWllW8iaImrjqtQZ1AUS7axXoLPvPGeZslAUwn infnqKOI2/G+SoQd9sg== Received: from hhmail04.hh.imgtec.org ([217.156.249.195]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 3upgv6rktp-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 30 Nov 2023 16:01:14 +0000 (GMT) Received: from HHMAIL05.hh.imgtec.org (10.100.10.120) by HHMAIL04.hh.imgtec.org (10.100.10.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 30 Nov 2023 16:01:12 +0000 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (104.47.85.41) by email.imgtec.com (10.100.10.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 30 Nov 2023 16:01:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=maYqYoN+nWe4Dji7zPcAr4BqrViqBh/7Av68PfYcbEsBPuqsrETOOVcJWyT2P/P/zLq+rPNrbthn7wwoeN3FxIkHGZouV8HtT4lKbqm6/NXTX2H1OsZMT4w9aBJ3QYpndROVWuWhc9m6DFsph6QCxxqk97VXeq9GSXPuI7LLQOV6wqKpj28f8EAjEdwv9iK0QB22Mmzo2HnNHFlU8TjEDp/dl9KonjOsQyi3i/fQxRgY/GQLSahZ1rPIk4STCH6Lal5dZMv6aqDwR1npR2qn/L5LXuqag57LszBLHTBvTx388w+QPjxrN37G+Mi/OoOWk2rwN0W4C3Zga9ZpJ8QSew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h3RV2x5k1HOGTrlJIY8d/m7gbws6MahuRj8Fe/I1AEg=; b=My9UUA+xVq2x/6XzSZ02iemmMhE6JENqFbXO5mhiPgCavqsIGpT8jXGYIACXghSbUc329u2TzwjbTnG0WRKT2ay8e06SGjUgWSLabsv7Mm+UtjqGoH9nmzk70py55HMYdFgqpMaMd2wENtJNc4g5UtXcb+117yVHMUM7E5s9O4xaJXuSAnfg6z2XBxKW4mNf0pIFCY5onWWukSfB0PGMXstmFe9FJcsmLtyn+GeBAk8LBtsav7Zny0QD3Wck9nWNpCNCJnBqsfiG6jXGEDQto0Et9l2A2eC2AqJeQhHzJYU2J4XWQ3qJLny3sER+jGgY9xtrHc0Cfi3Ogd3F1gT26g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3RV2x5k1HOGTrlJIY8d/m7gbws6MahuRj8Fe/I1AEg=; b=dZt2lc3d614gyFKfkbLcxuioGUVtmOwrSOzOBTlQhIznAfht4aUp4q0SvDoFoG41hVZmGRaKbAANqrGGZi9bRIc5rRWpLon/mTh7MmTvG/491g/sYAwMnuCvHRCllIoQzhKX8Dr9e08SjoW75lLyIrDfPTC0qkyggaZ4Q49B5Eo= Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) by LO3P265MB2410.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Thu, 30 Nov 2023 16:01:08 +0000 Received: from CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34]) by CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM ([fe80::a85a:76f7:c085:2b34%3]) with mapi id 15.20.7046.024; Thu, 30 Nov 2023 16:01:08 +0000 From: Donald Robson To: , Subject: [PATCH v2 5/5] drm/imagination: Removed unused function to_pvr_vm_gpuva() Date: Thu, 30 Nov 2023 16:00:17 +0000 Message-Id: <20231130160017.259902-5-donald.robson@imgtec.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231130160017.259902-1-donald.robson@imgtec.com> References: <20231130160017.259902-1-donald.robson@imgtec.com> X-ClientProxiedBy: LO3P123CA0033.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::11) To CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:1a0::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP265MB5770:EE_|LO3P265MB2410:EE_ X-MS-Office365-Filtering-Correlation-Id: ca20fb62-570a-4038-7fcd-08dbf1bd90a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GLufWT7vxGsL5tltaiQUl0/PLxkY+izuYOpoAGq/CUk+ltGWj95TAMDgCkqoUA8gVofvw40dzUGqrmjTuUA1vnxQomd1guJzpcIyM2WQYLv/vrATEdcHxiVKofJernbc4yZjEvV5D7RzZ+OoxtenYdvxJ1SBN1LlcAYCTVAlAlczOgGkPihIfKlj3GCjW1DMPxislUZeZ8UNJ0JlT9NoTIExHPkg9u6p//A5ntVLD4qGLivi1gQFVgnXqUMpz5FfzAJGJeAMiaenPHkDR0gereXrRFz4aqjFNKK+RpUqByhN3QcgzcmTUJ6nSV2nljCzRBRWtVQbpB1Ar1a5DrHTXVMGJC2Te5jPpiLdKAliFLYkwF1ROx1IaJqsDGPbj6u3cgpMwpFrN6ndZ7Z+0M2EHPh3eLXautBQEkNEakXEefZrjw6ODnhEBV4n3ho4RhAoIP5OO80LhKLZcYiifepVafvZx9tCJGqsqb7lu2YbYkwjrVY1CW5eB6CVB0IBKuJWvByF0WcEca+JSh1vPxd96QBP6kD6sn/Colp+3P4y/6IqGeUrZv+YDz4pQXIduN/qPu+4D76Mm7SQVJ9V/Hv3pNMy1VzcmQfadIUGhr1oK94wPCISggK/+PdjFZggtUpJiejLAMwtKbik89lUDEgBeA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(39850400004)(346002)(396003)(230922051799003)(230173577357003)(230273577357003)(186009)(64100799003)(451199024)(1800799012)(83380400001)(26005)(1076003)(2616005)(38350700005)(66946007)(316002)(66476007)(66556008)(2906002)(5660300002)(4326008)(44832011)(8936002)(8676002)(86362001)(478600001)(6506007)(52116002)(6512007)(36756003)(41300700001)(6486002)(966005)(6666004)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZIrAEnWO/Y9zZSg6zySEF9P+v5Qt4HmFUORA3Ds/ar5THzVq1obAAxDEarsC80mJbhnAPFyIQ3QLEenejvvefsz6neEtBrh95QjuY9Nb4KhZ4aEQnBdsQVngU81F6fS34UcJcr95NGXNkCRRI5AheHt0VxzYyutKXkodh64L41+GzsSoOvYF547C5qJnNn8KbZonCROoOiSYS6BZeBdYMQbb9y3ITbaCAfqTpGFf/KcbTfVihnhPWjmrjyj7w/3jSbcQ79DikA658qXKQkX6Eb2UntzqUJ7WDJ2q1iscZekP+Dpp6YT7Eb+ZE8sAcy3Ntct6FDtG2VXtH5xriYineUnpKqNbcr6SI+3EJQRQ+S09Rck/qmmbjL4eYPoSkX7mahusaGIuW+hSJiq/fR8vOgTZpvTkQDwxOKS0n5kgIsq+AX+Tw8G9gGTswzMlC7cdX00cZkgOisVXEoMo1Oj055CUlhGv8mK3BllVTFb9cy2BsU5OMsQnYbqAEte6XY2KC5KeXw8LEgBi0l+Dd/E3q1SKdRGLo7vnm7QRppRuW5lu7z1akdfgU6bRCLHkcpjnrfHdhgVr8dWONXUqcy1MEOTfLTDnsUbpQZdy3cDLdaQxty9OTuZD01LySeOYB7yugSsxQ/+i+tVQ0rbp1gAYUFYK/X0mp1bQcmkNQLcGOsvf/26d6MNK6bU5fZ0YcHryTDgIQEZPGZgNeVgI0BP3ZvoOGLj39OGQSKTIUKdRbIdeNet/PfDdOtO8ukSbyVKtj1aUY7m4Q/aEMA2svwFMt1FZMbYWqdtoegmMC5yyPZNz4+UyT2sJtW9qjmWWbxLG7ceufh+1l6xWqKbNkNkKvfcjUCcoqGzdUwj8w62XMWTonk5mnxVybE0qZLUEvIuYhyclecs2wr9RzeWS3VTGRewCKbsZQt+BHWIZm/iQDN/k8wnusNWT8ahMqVrai43gXAIz7F79H2bVZJivtD9sGjdvoMHSqi7qn7X/7e9glzqzh/G/MJsZBoPFDm2lBFQsJrxGx3uqeHD6d6+RaXLWXcxZkftLtN+wNp26xWjJfOEhHte6MSmwVRBSDePSTBPk258K0w4LTNYoNj/E1JofzBmABiUwiOHhlOGz6tkjseXS6C1KxrHUNY1AIYufNLxDpV2T7bx/zEmOSf4dYmgo1aUEn56MBATtMkwKYTT4vwk3vqGqZ+CckKPRjUU33R5VpRGrvesMPymImlZst9oxKItfl6eAmkS3/w20LA232jzgwJeTrAWkd1dkBjWbjEwy+QjyH5Qig1Eh+Ft3eAEVL/gRi9gZYIah+w9i2hq/q77CGSmS3zMUlHODIYXSuy/BMioE6hUdnJm23mqrjd0dyJ9igidW81cpyG2ka4ijvaqXKIPASusnVZskU7rZJoPvroagI6oxH9eBLdpz5/+dr6yJ70+MsjJOO3V9AFPKGPGUKnOVy765qm7NQ4risZIY79JxT+rS+0dD4EAF+SmlMy04llYPhW8Lr8lPvxcEr5ILWREbJbMy/ORVRPtBxD/JUrX2D8yqJbf4lwx2zRDSTfVHoEMwqhfwjbayU8DAMs+6pl5QqV5115WuSUU6gkAiSz097j2ZdxEZ8RrBmHNkXg== X-MS-Exchange-CrossTenant-Network-Message-Id: ca20fb62-570a-4038-7fcd-08dbf1bd90a7 X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:01:08.2146 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fpilt6KN9Xr1h4ZFTzqb6CFCsiyRXW8R8dTllqI1zncXjwxDyQolhDqmevsa39v8qX6RvVv34tpgmi8OBdrMyr0WraOwdhUVTbdW1Rn8p6Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB2410 X-OriginatorOrg: imgtec.com X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631 X-Proofpoint-GUID: ztB_vfYQslCbDsobH-k1sAMMq0G_loR9 X-Proofpoint-ORIG-GUID: ztB_vfYQslCbDsobH-k1sAMMq0G_loR9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mripard@kernel.org, matt.coster@imgtec.com, boris.brezillon@collabora.com, donald.robson@imgtec.com, tzimmermann@suse.de, kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This function is now unused, hence it causes a compiler warning. drivers/gpu/drm/imagination/pvr_vm.c:112:22: warning: unused function 'to_pvr_vm_gpuva' [-Wunused-function] 112 | struct pvr_vm_gpuva *to_pvr_vm_gpuva(struct drm_gpuva *gpuva) | ^ Remove the function for now. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311242159.hh8MWiAm-lkp@intel.com/ Fixes: 3c96dd170efe ("drm/imagination: Add GEM and VM related code") Signed-off-by: Donald Robson --- drivers/gpu/drm/imagination/pvr_vm.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c index 89eb6ee1bbcf..375a03707f4e 100644 --- a/drivers/gpu/drm/imagination/pvr_vm.c +++ b/drivers/gpu/drm/imagination/pvr_vm.c @@ -108,12 +108,6 @@ struct pvr_vm_gpuva { struct drm_gpuva base; }; -static __always_inline -struct pvr_vm_gpuva *to_pvr_vm_gpuva(struct drm_gpuva *gpuva) -{ - return container_of(gpuva, struct pvr_vm_gpuva, base); -} - enum pvr_vm_bind_type { PVR_VM_BIND_TYPE_MAP, PVR_VM_BIND_TYPE_UNMAP,