From patchwork Fri Dec 1 13:20:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475822 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8505C07E97 for ; Fri, 1 Dec 2023 13:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dUHu2w4QGndFdXWuw1+ns2Sy/J07KZ2IqKdX3xUXihg=; b=wn9M8a0DJvn6Ha 1telMNWu1H6Oq8B7kEeY7ypgA+UdpaRZm0TxLqk/4gLfIBX/6AN4d6GGZ5coFUsKOVpzoSr+GVycB /JELit8gAhcIdotg0MKEJ15T3XYwSKJN2jT1kcYXPWASVGkoy7mSSNKwrHAnXl84pDOG/paN+QwSo q2HHVO64KRMoDPtdGNj/NkFfvua3OyL9tc3WdWt76sKm1h8VQzj1RHdZ8lTlQoi7Oow0DGRfTvjrC 3YZ3HuODLvDoHLhMVo1DJamwAJmWu7G7rOWWLxFvv0tEKvGnHGR9OX5+YZTL+c5LszOu+1tjZpSMV WdCL3xGDztW0VjSEJHLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93bz-00DoJp-0K; Fri, 01 Dec 2023 13:31:19 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rc-00DjQW-0l for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:37 +0000 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50bbfad8758so2887852e87.3 for ; Fri, 01 Dec 2023 05:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436833; x=1702041633; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6nBS0qEXkMT109HJpJHOUn0za4cdp5UY2TNq9aMO3Co=; b=W/ZcJN7Y18MGhaemz2YdqZGc52tqNuIqwzSfxG91yn3w11Lz7LEZZj5N6qHfXdyUT/ 7E1BY813hS8By4Sxi2oeYQ5VjzzdpvMgWuZGLUyYEiPw1qe9weCQv+t0xqBmpH7UG2uP E+4oyViC/uPQE+XdIaR/NHnqespcFQTIa+Leu+wdImbC/40CRk63Jreb8C6mVgALxYn2 oH5BTAdKnfCapRBsLvdC8pIF70VpndeX0a3lxudQyfau6g5icjmuaFN8my/MQh+hCYEk vwH85+gf6hHBMbnUnry8MoA6Dgty8UaqjeyyUA3UNInlEuQcW7CL1WtYk3i3/A7ns7hW H0Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436833; x=1702041633; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6nBS0qEXkMT109HJpJHOUn0za4cdp5UY2TNq9aMO3Co=; b=ZMWYw9pKeWQ1//b8cMnGZLRN1TIbOQFygp18G/yf2t+zReDttczbwSQ/yJVgZVMJuH s4GJ2RfN2croxgmx7nJZ5ty+VlxkYiIG7y0cjOB+4PvUoy+uiR3l/Aqsv87mUG4jIW7G qfZvq31u7fLcq0GrPK26ypN2l+6iaMK7hJYU0qNaBIl4WTOQi+l057WW4Ad5IH6lFIHS IUNLOM79+Jb0vjcc6Gwt44vHEdpm18fZUVHf8jr0WkR6+KfKyAc4OTO1/kvaq5PnRN0k UMEeeSau+luRSRom3wzIzGP7cobVVQQVVpw4DMnvdkD7KmT/JXiw3+Yiatl0YBihx4Qh WGLQ== X-Gm-Message-State: AOJu0Yxsyo86gB0m319Zi2yBFn6wG6JBD3K55AvHl622QohtyAQiMgKO BuzqXKXWyVA7lBwRk1nuGuieFQ== X-Google-Smtp-Source: AGHT+IEZBoALYT2AI/HvZGmMjYehDRhxvtPlZru/apoTdsAj69LXnriJmkSP9pMwuY+NY+SyLAK8qw== X-Received: by 2002:ac2:46db:0:b0:50b:d764:8e5f with SMTP id p27-20020ac246db000000b0050bd7648e5fmr446890lfo.113.1701436832963; Fri, 01 Dec 2023 05:20:32 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:32 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:30 +0100 Subject: [PATCH v2 01/10] ASoC: cs35l32: Drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-1-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052036_279526_E2E6EE98 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 138040618438..d1350ffbf3bd 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475818 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31A57C4167B for ; Fri, 1 Dec 2023 13:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pIvF1lKldyfiG002BqS+9yoSsgfv9vDSeOz66bwsGow=; b=E4HsEHxMuIXYHN 5eRePjXX04XTpEx+scIaGeUfV4KilvoArl7a7nLZ1lTt1UerkJ/HukMeDA9dkG/UjhK/TdqO3uiBA bFqUALsKxKzVdGtXQTgcuZIy8Ml76RUo9tDXBI5UUrW/gGMLhj5nOh2Q6xkmXgM4nbFp9/zHjHNuq pRfOsnbILvu8DpZADcKsaAtFaNkR5pE0S5/ClBEhvOsJqp8Q4lg/4uxcgAmrU7/VKNE4rj+B8q93L gZArU0vtitu2GaraeuGXcZzpP1i+9AMO4wpErKZlKhMoM92i4OYSAjn53yv8mutmm61odsz5Si1kZ phHHa2XAOW5ZiqPfJV7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c0-00DoKU-0V; Fri, 01 Dec 2023 13:31:20 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Re-00DjQs-04 for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:39 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-50bc22c836bso3028908e87.0 for ; Fri, 01 Dec 2023 05:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436834; x=1702041634; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hvwEnfEWC7X3PkrakUYA7rH73mlgP4mcx3Rphz/0vOk=; b=Y3bhb1UWtscc7A2UvJzODi504UcRk0++YiK2IG17Xiv98MnhwQU4vX5RT8x+lPzVxM maSxKQbK5ZWyQ5nv+EPA4qYvHGsMYydILqUTxrPkFfrowYTt/MTBv2c7LR9zcr/xlsCd ybbOLNa2lk7LCTpLExBv14qzaO9zOxMQZtDd/GYwxjjkvMuKuS73TC09RrpZiubAvABY Cw+31fUT6wm6oiK1/FtrIF4zXUboeBxozGikB0yNaU17jwLWN1EiIXis6Sf09ZgS7YHP WvI0duo6AzYfyl3u/FpPux9w0PUyJCw5APX0kqyh8oIUjVPHpGmB+JfKUcmKvLQBJIeD nxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436834; x=1702041634; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hvwEnfEWC7X3PkrakUYA7rH73mlgP4mcx3Rphz/0vOk=; b=G08N8MMlE5Fuwgl64LAQVCIOOb+scoNRLQUFqrs+82avq5CMZ0Iiz1VTErNjg90MXK qrkDQfdxzHgvzxIAo4S/jBw+dsDoQ1ENJtmOP8tYvPofczbWYa00VSDMmz1xNBFTxDdr 1o3JjymzNGaQ97d34zV02M8Yu4p0jZWlZ8vjj3oMef6rC8SAs+R3CH5tdj6El4qCqM4X Da6LpCZawEGhp0EE5hDjfMIvw6XRxi5t8T3gahBC8PPBrq5s1ZkRK8xYl3zSvIYyDgHY yjykvLDl+rgEzRNGFdFDq0sjJUFZzAckJgDTImcl+tGjNXCOrrUMMdClwAB7oosA+/AT b7Tg== X-Gm-Message-State: AOJu0YxbZSV0DcAGE3JuPaS9hq1OCu7FlIivLb9xy0eJ9oPpCmVxIPHH NZEyR3nHMjtiTbi+01docj9mwA== X-Google-Smtp-Source: AGHT+IHy8r+VGJLhcKYulz95n0Llz8QkGNwo3fVIlOQzYeCx6OX80VUxPFF/MbvUz9dVuCcnHSKjPw== X-Received: by 2002:a05:6512:36d2:b0:50b:d764:6ec8 with SMTP id e18-20020a05651236d200b0050bd7646ec8mr745977lfs.120.1701436834148; Fri, 01 Dec 2023 05:20:34 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:33 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:31 +0100 Subject: [PATCH v2 02/10] ASoC: cs35l33: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-2-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052038_059231_7184F320 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "reset" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l33.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 4010a2d33a33..a19a2bafb37c 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -22,13 +22,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include "cs35l33.h" @@ -1165,7 +1163,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client) /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__); From patchwork Fri Dec 1 13:20:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475820 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6272C46CA0 for ; Fri, 1 Dec 2023 13:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EpXIjXZDql0TgHdQi8SpukTlrkMVfbJz8Mal4UjXDo0=; b=hpcdWBV/CgTp+j UKXTQDwvPe29LmUq1OIzYf4mO4ZRqv+VeMBwJGp805fRkzC+7EsFIyeiL46tTha+66WxMEGgTYAqe TtEg8LctIh8abkO8952f7oofdQS2Z0msEz0EJz5butJFkRqY1e1o1sP+KLnC3zC1lYJbp9+KQpu8k 6jzBd8moa3B1Hmwtg3HTs/Fi2NfVMGEFnZ5+1/ZBfZld9RJXoK/53Ws3k53djHqxV2bUyKgKeURjn nRyKUt++TX8aQtl558vsMZh3vJTnW8yR936JpJw7Osln04sfi5BFyWX7fLa33pwAG7fwkowTlSm6N MFmwH8bLtMPfdNHV/lmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c1-00DoLS-19; Fri, 01 Dec 2023 13:31:21 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rf-00DjRS-0v for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:40 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50bc4fe8158so3001576e87.0 for ; Fri, 01 Dec 2023 05:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436835; x=1702041635; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lDKFgSOaPuVFur80bPhP3dFYnn3zUMFtVllkw5He9o4=; b=pDN7HPTCFHiImK3hdzaQu5GtFcvxSXHk2CBUIk0rQbrHK2Ur1MxRTL9DmZO9M4qqs0 e8Qn3PN2zJpX3IbD6c7NIE4x9knBIhAxhpAPAb8Clxf8xanL3g7tivLXIUdMx6igi2S9 RWZjkxuaohQ0JJEvZsf7c+1qdqWDQdys1N0jGymUXk9ovu/6DDd96bFaigPyfma3vavW hO+bYFXhM6LrI42qC9l06PdrKOJwy7x5QpUN1b5OWvJkOPUu+nPMbFaI1uU3KvT4JcgB V7D3jLU1kqEvuUAwhfRjU6huiEMoAXRG+x0S7ffxbFTZjnhNLIwQROFqGFJg8Trz3Gqu eM4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436835; x=1702041635; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lDKFgSOaPuVFur80bPhP3dFYnn3zUMFtVllkw5He9o4=; b=mP/45UOxDv/Q8OaPZXLJ4jvL1Mo7QZ/6G21mpNbPr+tgRfe2PMfTGZeh4kpjH9ThS3 jOlQyPRiSshkAbkFRU5T5skAFt3VnzX72Np0M7QwYgLLZvOyX/wiJ0oy0JuO0D4QP0C3 fp5CCT+nFNwUWr4ed5TtO1gGJgHtbJ6Cobmr46QZR+PQUNVpOYU3sX2O3LN+H46jzuIN l4l6oMeFYEEct5zEN+ih6Qv9xogzRlwfsLe0m+9tCw9gufBSm+Ai0K2KatWciJXPIGD9 ozz0v/00lSHoWRzCx6lNrurUG1dk5uYd/mbaQ2BH6XAZ7FXVjAaKUOgwoVS7ec+bMlXn w4XA== X-Gm-Message-State: AOJu0Yy7Ie05KT734ZmaXIaetJNe3TP9lfoAasGdsn0MzkI9u/FcRow8 C7M2Kzq5SobaiprHvoRsJ26G1A== X-Google-Smtp-Source: AGHT+IHPhwhCcZemWJXPkwH3F0g8I2ogdr+dlRUEBR2WBwxAYjUakxV0jDfSRYYeCIC7/cyqXFUOUQ== X-Received: by 2002:a05:6512:615:b0:50b:d764:9683 with SMTP id b21-20020a056512061500b0050bd7649683mr765669lfe.103.1701436835426; Fri, 01 Dec 2023 05:20:35 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:34 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:32 +0100 Subject: [PATCH v2 03/10] ASoC: cs35l34: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-3-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052039_352506_112D68A6 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "reset" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.") Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l34.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index e5871736fa29..cca59de66b73 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -20,14 +20,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -1061,7 +1059,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret); cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_LOW); + "reset", GPIOD_OUT_LOW); if (IS_ERR(cs35l34->reset_gpio)) { ret = PTR_ERR(cs35l34->reset_gpio); goto err_regulator; From patchwork Fri Dec 1 13:20:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475819 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCEF3C4167B for ; Fri, 1 Dec 2023 13:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3n3cuMR8SaIz0cQkiwhRXb9F1eohvJE1KfQr4HqMa0Y=; b=X4G1AP+8FUOukA +xdla5x3cZoZ0c/6YjmGZ90Fwr5MnFI+eJeM8VftSGLDcUPdDLmx1SWEssXnpCvf+8/khN9vedCm8 vEkkkMyC+IStd0A4roxq7FUAxhaEEUgyxRAyD2ibw/3dJxa63AXurapg4Y00ULazcVLXovXEQ+s7L 8hSfSDwI+BymwO3bRQq/aSASKfoGXR62Uk7YtH6n6xhQ4GWbmhJnngNxTJszC6GL3HtBS80kqr26s UBuo7F2k68dXtGrvF+l+b127UHazvhwMkCyu0XndzJYnrZf08tldSBBKJ66VimfqBX2Q7JI0qB11u RPwBswCPChUuCfSs6LRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c1-00DoLv-31; Fri, 01 Dec 2023 13:31:21 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rg-00DjSM-1L for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:41 +0000 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50bccc2e3efso2696128e87.0 for ; Fri, 01 Dec 2023 05:20:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436836; x=1702041636; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QXDjDPaMbvQx1bg37W4jgjJHDDiGcy2tlOvY5Yp+dBc=; b=GHZcbbrbBJ0eOtqSIWq2Y5mZ2QsATsvydp/rAlsU+EoG9zqpPGRyu0dzEYxxkl4aKY q+kYoNChjONmDxLbFFt6Tm99o7chlqIkZHk3+FrCFfUQIUznb4mE8UXCRZfjY8nX7aZr QtmnUxJhqQvz4FIt4sc9nPdlxdu788T4WSsHgSZzJUPbapDjDr+arQ+MnfOftIdzhal1 YOf5ccOndglUfH7h47U9oeMnuLqQb2Qubt2yNJPY3R5NPLA2wxhN36XghSib6u0GwK/W DU4wepBOXxpsEpbvIWBOidpJLVt3TNeEzpNvBlXSl3aqkgE5W2x6KGNL6nf52qpiSR7V lcZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436836; x=1702041636; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QXDjDPaMbvQx1bg37W4jgjJHDDiGcy2tlOvY5Yp+dBc=; b=XlbPqd7wOXruLtmo5Am4oavN//HmTtp48lQRxudZlvuzu0BdZziWgB600y5i9jmdTx YeRNx8TWVTnf6jJRWVorJ088EQxXv57YyR7SWgHS6QpvJt0oGnx7rhDA3PxEbvlOLoO0 f7oJpzhYjfjPvCkhiAeoGLxuqD25mj6s8ywgVvcHhYoa7jQmYDv4dKEEaztqROiLuP2R u+FYb7wluBnLPHU76uXLJZbf9W4n81y/CpGofo59IHKCV8zqiPExKdusolR7Nem/4Pmw RpkWmlQu7nr51JTdDRXb5Qe08wkpmEyKWTM8nl5PJZDRYhuBvnC39CAhsK/5yP5JciYZ 14dw== X-Gm-Message-State: AOJu0YwkQP9fox9HyUq7/AwHU9TB6e/OWjD3pMmms+7qsb69F6+//ecN JPDeNDvHAwralfO2QwMasu6T4g== X-Google-Smtp-Source: AGHT+IGIItJJwYORlQRXrQG7gfQ5ooIDSNWEgNp2rLh/rkXJ7icDeuvVSqIoEojB48neS29HuUSSVw== X-Received: by 2002:a05:6512:239f:b0:50b:c2f4:ad44 with SMTP id c31-20020a056512239f00b0050bc2f4ad44mr1028231lfv.29.1701436836629; Fri, 01 Dec 2023 05:20:36 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:36 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:33 +0100 Subject: [PATCH v2 04/10] ASoC: cs35l35: Drop legacy includes MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-4-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052040_456097_CB0EEF8D X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l35.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index 63a538f747d3..ddb7d63213a3 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -18,14 +18,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475824 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41202C10F07 for ; Fri, 1 Dec 2023 13:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=spAmzlVFo+xKmxuUiH0G61EXeuVdnRnne9p9glJSpzY=; b=gQhQk8/qvhSMXu L/Kq1gXml7X61ItKCu0WVVu/eOMxGU/2jYqTKNJ8ufQgP2BhTIbIGFflSfKBNqZeMHIKPV2phCMCI jqxbrGAl/rticMSRWRAP2y4FhgCPmuCiJawnaWUyCP9cc91fgvqwn2P8ons7ik/+o75VSVKMtSVc2 dSI3EappJet60lUv+1UQcRNLTiK5X0YThBe7lWr3AJQ+ReJCgUQvBVDmdZ4VG6t+N+cTdEUiRqLkM GAFAO6sJcq3qA19tK4j8tSUwu10h1PGhOe1jyUFzfhtxMJGJqMoctMIdDkO1s3fd9oN4bZ8ZgG6h1 ul1aHIGLl81uXgXRunng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c2-00DoMN-1d; Fri, 01 Dec 2023 13:31:22 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rh-00DjTW-1s for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:43 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50bc39dcbcbso2932726e87.1 for ; Fri, 01 Dec 2023 05:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436837; x=1702041637; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tmhoeNK2XrxfkfGdL3xKNy/HfoA09+0EnEv8OOqmFiw=; b=RbAcAeTgGg5TDjbjORbF8sLTHGa95C27Hcov30Ao1ONNkw/lc3lv+43K10yok1pmsg 5gHeohfFzr5K4eEWGXD4WOuWCtwUykjoMp2O8p4c2b/mj89dFCs09HCWebKAL/v/xNnh r9RUXca1mm20Yrr/kWkMUCN//zeKJ9rqmmR4jz5lv/VOq49uUtRVYrbAq+6nW3q7tD9r 9sp16Fx39WGvPCp3rWg5ifTFEsNGrGGipukDLIv8pznK/e6SF7ZlFihwWxD4Hj7r8kWP cohtHEfm1eKOXM4otEYTxXpuQTy+Eh/PfmUZyEelZs7thoT0wZBFsRgmE+9SduGNS78o HSEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436837; x=1702041637; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tmhoeNK2XrxfkfGdL3xKNy/HfoA09+0EnEv8OOqmFiw=; b=FSJgc0baoqtyqxLw53xn91lm+M8KF5KEkM2o/tJsrAida4FOfGC6fhxafJ8iZEiujc YaTzGUcecVAtLz0uNQn+uBZADSaB/PmBllA4rUSMlfFJk5IdL7+kyZJ1o2qNtccN0nef r9DJTVUWFLPTKw1eI+Pd9Vsj26KiDjOxnVcgN74v5IPgbgbSCjqHqMijk0Y6t3IMuTK0 jWDmdMNlasgDC8GgDF2rvpEDHmLmBrRIvWu+JoH+p4QO4oXbN3he/F+5RsSTfWBor+Ll VUJHrqY3GliQ+4GHDfL67QbAIRyq8Lkndnnm8qv4VGHnBZmoiGffivMmUL2LFLECgDB1 8JNA== X-Gm-Message-State: AOJu0Yyg0W9nnlMKubFf+ueymXLddOp3FycvOiI+qAvd2O9t82batz7s 06PDQDSJTNHJmfdr6QJjyQZQtA== X-Google-Smtp-Source: AGHT+IFSgPDic86kEaX7pw26R4wwmabuIQgTcHwgTfrqNNG5jSVMDDG459yzdd7DusaO3vXR73bQLQ== X-Received: by 2002:a19:7906:0:b0:50b:d764:8819 with SMTP id u6-20020a197906000000b0050bd7648819mr784054lfc.101.1701436837631; Fri, 01 Dec 2023 05:20:37 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:37 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:34 +0100 Subject: [PATCH v2 05/10] ASoC: cs35l36: Drop legacy includes MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-5-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052041_616593_10C5A4E9 X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Add include, apparently the driver relied on this being implicitly included from --- sound/soc/codecs/cs35l36.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c index f2fde6e652b9..f5bd32e434a0 100644 --- a/sound/soc/codecs/cs35l36.c +++ b/sound/soc/codecs/cs35l36.c @@ -17,15 +17,14 @@ #include #include #include +#include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE6A8C07E97 for ; Fri, 1 Dec 2023 13:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kT8BfV7KeW2/1ByvuoJ4l+33uGSVP+VTI3qZiglYLDQ=; b=sa2LYaN7AcmkER T0FcVg/KH6LzYF/XvOw7bsK9QGQW/C0od8HKfH6w/4haWCAeTKAJ3keVnDlJdzKKaNAd66nE3Lsn2 yj2JSek+qmUFEUvvOWkNRlIpXiSSeofvRspAKnCY6WSxs2bT6P6kV8DJO0z2IARTwkOn9sQKTZy1K qIU014Lmi39+1hOWDzvYRfRaMMPS99HqqB/zGFT9dnVpIYenUpFRxji26udIrh307Urmy5/PRt3oe lDyIdc6h96fJH4OEM9txEq7IMUuukcGzmR9+gNleD5KmTTTCr7A+aQIGFvbeN3W1CNRaN+NAelmqf 4x83z9NAhngLhNEtIwjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c3-00DoN0-0L; Fri, 01 Dec 2023 13:31:23 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rh-00DjTs-1b for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:43 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50bd4fcbde1so1726562e87.1 for ; Fri, 01 Dec 2023 05:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436838; x=1702041638; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5WhXxuLZNgkWwHrPw1QLUfir5/y69DK46Q+annr/jjk=; b=ESyMXftJ0Qkn0Yn9JYGfvU1kgeNcNo4tKSPR9ALtgaDeo2kG/hxnBog6BYxn7I+GAH uy21zdadnjqL/A+h1SC9gWywmkJV3jPlta7cODTjiW2kJka5l7TfXR8QaYp/GZN4Gqvd mFgI+kf6MvH/BYiwQu0lm1xMUSHLKcMlpI5uazBhinizb97LgWE4mTw9cI1lhd+6PJdA HHCLlqdYJp5ajwwUNEoX84enSBYA4ef9L4F7lSc2klChwXzHE8SOGUsTfCIGSLrSeH7W ga7RBZ5a6SeBWMXFneQqAKnq+mLc8N0kWmbDhN6IiNF3fseu74fEqxWUW6gZObtysEn5 2xKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436838; x=1702041638; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5WhXxuLZNgkWwHrPw1QLUfir5/y69DK46Q+annr/jjk=; b=ETF1r41WlYRpwbMhbCeHRQCM4dK/exFxowGLGJZLzh1QbTc1QNASA4SB5MqsKsSBi9 lEFQ1y9UqKM5HbI4rT6FJ8SdZW4lrgYoDUuUJZ+6IV5hOzeYBwpLMsqjArLUvBwRX9kE tZP65ljrsS4VijZ/iaDOlVC0h6GXqM0GNhtwr0uqG2Dlmgih5mNjXwBAwB6FmjekQOv7 udGdeved28wi1mUGKbX3Qyhv2OlbhbOFuapMxX4pUcqaJbn0za8XdPM0p/ypTkbTJ/HI Vch9Qsju3H7ctxq9ZI/QYtA61XTdlSWyAHqFmSr39jVTIJptOLcSFGHf9Du5v7qzAqYQ x1aA== X-Gm-Message-State: AOJu0Ywq9yd9yuIh3NdS5LQ9liFVF1CmYmC3ydQmeM/X9oi28sb0ai7r QVhKK56Bpxn5C06MGd0cbmZPN7tvUSWY8e8d6xc= X-Google-Smtp-Source: AGHT+IHsLRMMFCTZlDmh+/PBoPEELtq/DFrM73vYAwtEFpAp1w/UNgpsq/nwT/BE4N79+osG9ZAmHQ== X-Received: by 2002:ac2:5586:0:b0:50b:c9e7:2949 with SMTP id v6-20020ac25586000000b0050bc9e72949mr792476lfg.40.1701436838667; Fri, 01 Dec 2023 05:20:38 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:38 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:35 +0100 Subject: [PATCH v2 06/10] ASoC: cs4271: Convert to GPIO descriptors MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-6-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052041_538332_B4F32864 X-CRM114-Status: GOOD ( 26.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This converts the Cirrus CS4271 ASoC codec driver to use GPIO descriptors. It turns out that there are two in-kernel users of the platform data passing mechanism so these are switched over as well. One locally defined GPIO "gpio_disabled" is declared in the state struct but completely unused in the driver, so we delete it. Reviewed-by: Alexander Sverdlin Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- NB: the affected platform EP93xx is being converted to device tree I don't know if that is happening in this merge window, but the colission should be manageable. --- arch/arm/mach-ep93xx/edb93xx.c | 32 +++++++++++++++++++++++++---- arch/arm/mach-ep93xx/vision_ep9307.c | 12 ++++++++++- include/sound/cs4271.h | 1 - sound/soc/codecs/cs4271.c | 39 ++++++++++++------------------------ 4 files changed, 52 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c index 4b90899a66e9..dbdb822a0100 100644 --- a/arch/arm/mach-ep93xx/edb93xx.c +++ b/arch/arm/mach-ep93xx/edb93xx.c @@ -88,7 +88,7 @@ static void __init edb93xx_register_i2c(void) * EDB93xx SPI peripheral handling *************************************************************************/ static struct cs4271_platform_data edb93xx_cs4271_data = { - .gpio_nreset = -EINVAL, /* filled in later */ + /* Intentionally left blank */ }; static struct spi_board_info edb93xx_spi_board_info[] __initdata = { @@ -114,14 +114,38 @@ static struct ep93xx_spi_info edb93xx_spi_info __initdata = { /* Intentionally left blank */ }; +static struct gpiod_lookup_table edb93xx_cs4272_edb9301_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("A", 1, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9302_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("H", 2, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9315_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("B", 6, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + static void __init edb93xx_register_spi(void) { if (machine_is_edb9301() || machine_is_edb9302()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO1; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9301_gpio_table); else if (machine_is_edb9302a() || machine_is_edb9307a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_H(2); + gpiod_add_lookup_table(&edb93xx_cs4272_edb9302_gpio_table); else if (machine_is_edb9315a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO14; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9315_gpio_table); gpiod_add_lookup_table(&edb93xx_spi_cs_gpio_table); ep93xx_register_spi(&edb93xx_spi_info, edb93xx_spi_board_info, diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c index 30d9cf3791eb..9471938df64c 100644 --- a/arch/arm/mach-ep93xx/vision_ep9307.c +++ b/arch/arm/mach-ep93xx/vision_ep9307.c @@ -164,7 +164,7 @@ static struct i2c_board_info vision_i2c_info[] __initdata = { * SPI CS4271 Audio Codec *************************************************************************/ static struct cs4271_platform_data vision_cs4271_data = { - .gpio_nreset = EP93XX_GPIO_LINE_H(2), + /* Intentionally left blank */ }; /************************************************************************* @@ -241,6 +241,15 @@ static struct spi_board_info vision_spi_board_info[] __initdata = { }, }; +static struct gpiod_lookup_table vision_spi_cs4271_gpio_table = { + .dev_id = "spi0.0", /* cs4271 @ CS0 */ + .table = { + /* RESET */ + GPIO_LOOKUP_IDX("H", 2, NULL, 0, GPIO_ACTIVE_LOW), + { }, + }, +}; + static struct gpiod_lookup_table vision_spi_cs_gpio_table = { .dev_id = "spi0", .table = { @@ -292,6 +301,7 @@ static void __init vision_init_machine(void) ep93xx_register_i2c(vision_i2c_info, ARRAY_SIZE(vision_i2c_info)); + gpiod_add_lookup_table(&vision_spi_cs4271_gpio_table); gpiod_add_lookup_table(&vision_spi_mmc_gpio_table); gpiod_add_lookup_table(&vision_spi_cs_gpio_table); ep93xx_register_spi(&vision_spi_master, vision_spi_board_info, diff --git a/include/sound/cs4271.h b/include/sound/cs4271.h index 6ff23ab48894..5a55d135bdea 100644 --- a/include/sound/cs4271.h +++ b/include/sound/cs4271.h @@ -9,7 +9,6 @@ #define __CS4271_H struct cs4271_platform_data { - int gpio_nreset; /* GPIO driving Reset pin, if any */ bool amutec_eq_bmutec; /* flag to enable AMUTEC=BMUTEC */ /* diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c index 9e6f8a048dd5..74a84832d958 100644 --- a/sound/soc/codecs/cs4271.c +++ b/sound/soc/codecs/cs4271.c @@ -13,9 +13,8 @@ #include #include #include -#include +#include #include -#include #include #include #include @@ -160,9 +159,7 @@ struct cs4271_private { /* Current sample rate for de-emphasis control */ int rate; /* GPIO driving Reset pin, if any */ - int gpio_nreset; - /* GPIO that disable serial bus, if any */ - int gpio_disable; + struct gpio_desc *reset; /* enable soft reset workaround */ bool enable_soft_reset; struct regulator_bulk_data supplies[ARRAY_SIZE(supply_names)]; @@ -487,12 +484,10 @@ static int cs4271_reset(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) { - gpio_direction_output(cs4271->gpio_nreset, 0); - mdelay(1); - gpio_set_value(cs4271->gpio_nreset, 1); - mdelay(1); - } + gpiod_direction_output(cs4271->reset, 1); + mdelay(1); + gpiod_set_value(cs4271->reset, 0); + mdelay(1); return 0; } @@ -612,9 +607,8 @@ static void cs4271_component_remove(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) - /* Set codec to the reset state */ - gpio_set_value(cs4271->gpio_nreset, 0); + /* Set codec to the reset state */ + gpiod_set_value(cs4271->reset, 1); regcache_mark_dirty(cs4271->regmap); regulator_bulk_disable(ARRAY_SIZE(cs4271->supplies), cs4271->supplies); @@ -639,7 +633,6 @@ static const struct snd_soc_component_driver soc_component_dev_cs4271 = { static int cs4271_common_probe(struct device *dev, struct cs4271_private **c) { - struct cs4271_platform_data *cs4271plat = dev->platform_data; struct cs4271_private *cs4271; int i, ret; @@ -647,17 +640,11 @@ static int cs4271_common_probe(struct device *dev, if (!cs4271) return -ENOMEM; - cs4271->gpio_nreset = of_get_named_gpio(dev->of_node, "reset-gpio", 0); - - if (cs4271plat) - cs4271->gpio_nreset = cs4271plat->gpio_nreset; - - if (gpio_is_valid(cs4271->gpio_nreset)) { - ret = devm_gpio_request(dev, cs4271->gpio_nreset, - "CS4271 Reset"); - if (ret < 0) - return ret; - } + cs4271->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_ASIS); + if (IS_ERR(cs4271->reset)) + return dev_err_probe(dev, PTR_ERR(cs4271->reset), + "error retrieveing RESET GPIO\n"); + gpiod_set_consumer_name(cs4271->reset, "CS4271 Reset"); for (i = 0; i < ARRAY_SIZE(supply_names); i++) cs4271->supplies[i].supply = supply_names[i]; From patchwork Fri Dec 1 13:20:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475826 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98B53C4167B for ; Fri, 1 Dec 2023 13:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ft/YHddgLCa7Zq52bmlkYj3PCpU7rLKQ91dFqWZALAU=; b=m9IsiSVOj4r5a7 wu9p0sEHJmPVDHnKq3rxGMf3xdmAng1q9GmtC9CIqdqrTRurhzbxTX6uOIJxWGdha1Qlj4xIxAW4r wMJbYHQsoO0tp6aT6tKTmVN4m2SjR1WI3BhiyniaiRie3EF7Ot5C2fnrIHcsz2mvA1yOrIznGJsUZ zTjx7uTMYkrYEn/L59ZGgbAG7R8XpCheXdTgIiajDgfDTBy1yu4CjFHQq9HXRJWw5rxSwXTwJxaWt C6SeYnxtxN1/7dO3Bxm3ILN/4zM3Mhvqq4OlFkUJq4uqUT1FioTUimx54791Ch6Pwv+zQla14+g8P sTYUvfbO4INgtD4jYyhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c4-00DoOF-0u; Fri, 01 Dec 2023 13:31:24 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rj-00DjUg-1s for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:44 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50bdebb1786so188481e87.1 for ; Fri, 01 Dec 2023 05:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436839; x=1702041639; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h1YwCm+XH2HIMFvp7NT2GALpzlzAqPDpRrGRX4ZS3D8=; b=epN27M0Rt/mMIGbrJlYc0OaCgWGOm/lL/jBVW61o6pgBbc5/C93D3EUtb/5KwXzWiu jr0LoA26GjzeUFh5BpfLYZ9UJ1EBXbY7Zg4DJRpD41amgpzVkLGWkBFp+bLaSRQ2SPSN +AqeV0QXY/9PzO7BiIvkUVVBHsbX3zPA99Kf0e4N6A59nqu8UMqUGLBmdCHyVpmQzn8D 3vWWLJNDEgPpVNcCpodOb2Y/EHjA+8ONxRtVwUZTrp2tInd4OFgPWLjqqJ6cls4Acnqk ygHTC4MhZYIXHfJtaoFeAWnSXdN7XZt+gfn9fNdOc7a++h0L+HWEFtDxKY61eKHOVoqQ maSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436839; x=1702041639; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h1YwCm+XH2HIMFvp7NT2GALpzlzAqPDpRrGRX4ZS3D8=; b=sF9f34C+3++TSPIanxzjylJCL6rEtF1EPjoZSjH1ivlXNj4byEHvoxE6vOKTentgSJ C21KKkxwINf4nMXxlgyNLu4so69Z9rnAn0cnrky5mo/UfEHsTyh+L/NkKwxJVyUD8AAk c6uQ+kVuBHXQDlZ+K4MYM4QjDn1Pi8Qgzy0DdbtTNRvQ4JIRmLcAXLA+8Ef+S6c1lzgk UkyVemEaNWQusWVd7XeJppg3Bfv20zAGeF22ir0sfDQDC8XxuitiKLzVX+FXuIlMj52W IiVYYIk1VJrtTXPPYqmF6ryig0mh5R7KH7sLYz4wM2dz9pdWIUhVJtSmkwv92YZ04LAr vHJw== X-Gm-Message-State: AOJu0YxhRBPnNallpmrcBxm/0DRjsaONMNxR8o/ANN0thrVT1YdU/ZpO 3frwbDsZzDHA0loa9sin8igUcg== X-Google-Smtp-Source: AGHT+IHz0vX9CqCj+qD3UQTWnTMff91+vQiG2xdvgEoaXCXAVJNAM8ut2DNGIFy42sB0tfaYdArJbQ== X-Received: by 2002:a05:6512:1597:b0:50b:c9c1:19ba with SMTP id bp23-20020a056512159700b0050bc9c119bamr868333lfb.63.1701436839678; Fri, 01 Dec 2023 05:20:39 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:39 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:36 +0100 Subject: [PATCH v2 07/10] ASoC: cirrus: edb93xx: Drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-7-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052043_645760_3F6756D8 X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Reviewed-by: Alexander Sverdlin Link: https://patchwork.kernel.org/project/alsa-devel/patch/20231122-ep93xx-v5-38-d59a76d5df29@maquefel.me/ Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/cirrus/edb93xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/cirrus/edb93xx.c b/sound/soc/cirrus/edb93xx.c index 6b6817256331..8bb67d7d2b4b 100644 --- a/sound/soc/cirrus/edb93xx.c +++ b/sound/soc/cirrus/edb93xx.c @@ -11,7 +11,6 @@ */ #include -#include #include #include #include From patchwork Fri Dec 1 13:20:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475823 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 294BFC10DCE for ; Fri, 1 Dec 2023 13:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2RT1wSWP+QtVFv71jGtYBOrF4rNJPc6PCLDUODmqzmg=; b=yIytkM2+IX7sr3 w823AKskzeqITkDm1BIXL/2bV/HefkCIK6aHlmVjfvpVmCtx23/+Cs1Ngw7NgusoP4s2pnmN2z4bC 5lx1Brb5IgaJN++8C2seG/jNDgk5Q2XED5x8gFZG3P9Jp1000PCi6cRBeVTACQcdvb9zDsmNVKvGC CMutLp+BbtS7+LzACeAtJ8ah1Wc1u3CviVY4f1GQvfiRyOrZFJwqpzu8zCyHCqOY/Zyh3wcDMomaR YFTTLh2WhbtXhdxsKXR1QrMSC+3EqW5UdiasB1Lz3UdJGt28f2lfPHOsyMhk3ARwlNws7AZIzaN+D 3YnxIq+oAUEILxmOD6Gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c3-00DoNb-2F; Fri, 01 Dec 2023 13:31:23 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Ri-00DjVM-0y for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:43 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50bc22c836bso3029054e87.0 for ; Fri, 01 Dec 2023 05:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436841; x=1702041641; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kJ+3Y6BEIrIf7qh9svq9OVzbI1CjxUGno02MCFoO1oo=; b=pNGNQWRXKB6CY+/PRzeuvndzjWZmWuUqTMTsoJN7b2xu5XMw9nbgEiodDXcCQwTiuX 4AhsvHJLl0axJJUbFDEi9rgiHKhp32C0Q2iF6scwtotMkZntZTy4IimHAQaOpGfLQ94h P+OiV6LxtJJ0KCzsPMMJCk0qItXvtmXj8AOCXCp46lZa8qrrR+2ECpy0XZ1m5FcUxzWT 7g1O7uJjdnsznRAAFptU9sPDuK3pEMJc7OsfvQCfl2cXBnaUx5HT+t76GZxXBv4KKB2Z 2h62ccGVa12sSKuQYslPUQlTNbnGr32dBVh7tVOZF4pdjYOP8X3u/gMNw5/m5LTFNEE3 YbZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436841; x=1702041641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kJ+3Y6BEIrIf7qh9svq9OVzbI1CjxUGno02MCFoO1oo=; b=CvnXQMzZoYVSvKVjxK6cadSGtDF0k3/PC3v7GA5/Hlhbs8dgGDEEAx5IUPKKwMMkfH YuPE9f2gmY6i09Zg45yF4silctPQuoFySmZJ1IsxnNAN2XwU643t/wbvnfh2hkhy5kQS BcxFpjEUg0Evn//qfFF/gwU4wT56llfXL/xyXSQzgvAy4kOClsmh055NF6RoVnVQIMBS 0sJyFrvfDY1PfR0c8J9UhY/fSXePEp/ZDI/xRKIsYjH09IDQphbY+FNDIpL+xkayGtoE R0SOfkXqV8VgGTsBmJwM4PtdPAnKRL1ezrsxztUW7hNaPpN8ARnEFG6axkckOSSzEu7/ UxWg== X-Gm-Message-State: AOJu0YxxTV9V7ZWqdwbRwqeHWkkrQzNwL3x72V7IcAbAl2SwnAfPsvQk ZDrP33jr7U9U3FSa78Eg6FqajA== X-Google-Smtp-Source: AGHT+IFCWkhwbCMo2Kf7qMaVHd44Tp9vXFDKbzrS0UCWqndYYop0TULKRfjWVlBGS5I0GO/2TXb3TQ== X-Received: by 2002:a19:915e:0:b0:50b:d764:6edb with SMTP id y30-20020a19915e000000b0050bd7646edbmr666344lfj.139.1701436840946; Fri, 01 Dec 2023 05:20:40 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:40 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:37 +0100 Subject: [PATCH v2 08/10] ASoC: cs42l42: Drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-8-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052042_340754_AAA37D77 X-CRM114-Status: GOOD ( 13.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs42l42.c | 1 - sound/soc/codecs/cs42l42.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 94bcab812629..2d11c5125f73 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/cs42l42.h b/sound/soc/codecs/cs42l42.h index 7785125b73ab..3d85ebc59489 100644 --- a/sound/soc/codecs/cs42l42.h +++ b/sound/soc/codecs/cs42l42.h @@ -14,7 +14,7 @@ #include #include -#include +#include #include #include #include From patchwork Fri Dec 1 13:20:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50490C4167B for ; Fri, 1 Dec 2023 13:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s6nYcU0NspBoAwpE/ePWB2npzr85q5impY3INk6vQj8=; b=TuNz7otWjHBjAw wR8VYndJ2povFHDDArcEcP6seDJJBlpDzb8cfNEdLur2zi+dbRB30QC5usjOePymMBIeJehaO+NL6 HWYTxS3a3Wtm+rVpAjyKLsdanXAnPIrG4jR6JXe4yc6NviuzISb5KrJCllbGx4YJskruiip3mnrdv xKOtbmF6UPYyyO0OhqO7lDUyuLzKUlGrSro2hsf01cEQ8j7ScqJXjIyQGKrnEAm8ZNGS4KhqVDDY4 kSRLITo70QbiT3vKbIHHARZ7qLayokBF5P8D+h0GjtH96F7mLLP5sJD7UJ9j0Mh3l4WKGprNT9YtZ F3M9zblxNQ0o3BRuoZdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c6-00DoQb-1P; Fri, 01 Dec 2023 13:31:26 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rl-00DjWR-2l for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:47 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50bc39dcbcbso2932825e87.1 for ; Fri, 01 Dec 2023 05:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436842; x=1702041642; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k2Zjl+ghnoX/3uQpkhvwTgBBfYBwCJ4hUzQ4RLGrPPQ=; b=y2/zqEk6e8Tvtn5My5pDNYwAJsyZaJ4XBec29gOJjB9GSO04eEGbUpffq/IETosvPn wngHOARfao2kz84VHPYZznpxVJl9nb3frKh7Az/Msk5bG2M1ATkZP9XeIg9cer/JuYrh Eprfk/+VPEnuazdc7HvSCz6bfwerRnS7PBCPPaaeAK03TaM/4TAVUBrBmPSHcRnUiHf0 6vo9yT1IDpvN6fTh7tZ3c+zGW8rAGulQgwalPSd9Kos981mlIhcEAUiu6nQBGz6ThpgU QH32vmSja3jSo4qd1YaRBfg0pzFV+ms2MS+MDvk/SDmxi5uKVYNAAaz1ISHPTaRvAG4H LiVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436842; x=1702041642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2Zjl+ghnoX/3uQpkhvwTgBBfYBwCJ4hUzQ4RLGrPPQ=; b=nd0dAaUn6E6SWnAx5LnAD9B7kPgN0p/Y9jlXHl/3NLmtpAKk+K2prP+Aw+57Q4YPEs Lmfntx+z9uSIbi1eLElA+rEkSTRmfnfUzIs8I84LTR2Uk8cKTzyPbet15/DmG30nXZN2 52FMJSwZS8uvb/HxZ7XpJ8PMIMGSFyA69QThMP+TUAPiQDSRQ/CLZNR5bsbLjUBh9a9Q OqVLXv4J0RhBpvcs11JUhQlg0zzMbR+RDQRmks+absrGnRRJB6kD5e4SUZS5SRY4iwZO e6+ZwoCLvn8C5XXU7D/nchfa25nzYziSVTZT/AF+XAyGcd4mjBpbxWxL1BeHS+KXrmQq bG0w== X-Gm-Message-State: AOJu0YzMnDlbqM9iqiS6mtlcx/FYUtA6Kj2p0wiFm+dM/bmDqAoTO+e/ NfjAeDeS6d8qiQQ8XD8GAb3YNg== X-Google-Smtp-Source: AGHT+IEP9YooEM6UIg2kUPyWgnGCZVy2TmLr2VGSLb6afACF8IimZsUAaROd3HdHHX8+hnBq6Qopkw== X-Received: by 2002:a05:6512:118f:b0:50b:c7b0:ecaf with SMTP id g15-20020a056512118f00b0050bc7b0ecafmr892089lfr.49.1701436842052; Fri, 01 Dec 2023 05:20:42 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:41 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:38 +0100 Subject: [PATCH v2 09/10] ASoC: cs43130: Drop legacy includes MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-9-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052045_899043_E76E002E X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs43130.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c index 0b40fdfb1825..18933bf04684 100644 --- a/sound/soc/codecs/cs43130.c +++ b/sound/soc/codecs/cs43130.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -26,7 +25,6 @@ #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475825 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C3B7C4167B for ; Fri, 1 Dec 2023 13:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GuygiZed49If0WhxH6HQuHfvaNPMTERVEuIjhXcMvhE=; b=sE0kMcAqwzNZIl 0v1NXYbUH98UuSqaGmWWQPM7FOYZkXMy71FpBpsSlm2kwoHWiqV8Wy7B8sz1x4A8BfTet11p9oUI+ Xj0IlEEzApiBfBEZw4XGKPB3JXp2pNoxhdgYoQ1BmhW9g0EIRbzmENSmlt2YfpXgnD9JoLa0TFT/U habOq50D4/7NwetZ2oIQPBSUexn8XUm9qgCfVpZ5QppWuvOCISO/m5S33a7DGz3YCASuu/rkbxj/X erm3/hNllGI1vtfe09jtFhP62h0lMKhICbwsr9+mBx/xKCYqByvMWlUvSacV/vbeRWSU0xM24ACVn ISfI96BYEN40SRu2egwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c5-00DoPg-1j; Fri, 01 Dec 2023 13:31:25 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rk-00DjWu-2I for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:46 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50bba815f30so2883064e87.2 for ; Fri, 01 Dec 2023 05:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436843; x=1702041643; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+fvbs0Xp4GpuorKL8Tfj6BakgsRgukno1Vk7LhvLiBQ=; b=wIziON1iYp4ERQBWtD22ZWwfSP9rSK7ePY3GaTGM8M4Q3Lcm30dK92exWApBwFmWhK JoVtEua2KoNzwCYLWFNECZcSVzCRCdM8pHqsNFhQGeIn0MRNyUYc7HFb9wlbdi19QbRH pxpKKYrpgttp0ENqq884Q1HMX96PZWuK4JvQ374EmH1YfWWbf6ZyDJThj6NwRulu1VDG CzrS71m82KjmrMjT1Ou83mvQp4LKvkkJy5AW2CyKPJw7Q3takKAr5RcJXztTQNhk+Uus crhIxMh66MkdO4s/9M0kLwiiY1OCqvMc7Dk8CzYAn2ZOVVFpAXAZN7m/oz97I3+qfWin R+9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436843; x=1702041643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fvbs0Xp4GpuorKL8Tfj6BakgsRgukno1Vk7LhvLiBQ=; b=MUL4+Vft8bofChLf79ixylrx83va+B1x/GPQcf+49AbSbCJFYQbTLStJD4S/OcEuCR jts4AbtvztyqBvC1zHqT5zty7bbAMljW9zfUdPVb/1t1EHpFog4xmR5F6UaIOdEFnpl3 HJ7ozKWRfwBaVF3gIvbfMrDNTbMP/yJoRongBN3bbohVWDgxl3/VDnxASZwvElDxthX4 1giBfi/sqWk+phT9OX2iT6nJVxL+5ULm5NZ9ddhYCilnIP+3yix0IYd+MQeLYX7j4hw7 qETGzTuXFNEgf8vM1uZvwKsLffke4uwzp0kb0Ax4+Us/qDtUQ7qUSUKInnBvEGmDwRqB mSdg== X-Gm-Message-State: AOJu0YwAT4gZZjXjR1AYu2lw/gyNHvc4uD1lDfvOy81ev1vxAIfe/own gHhX1tx385pBOy6fvhhs9XYZdA== X-Google-Smtp-Source: AGHT+IHtjQtt799xLpoVCezjOYP5wu/F6yl+pLI9Fcs3e2ywoijlCxrF0bm3T9nOT+wMNRQXj8UvwQ== X-Received: by 2002:a05:6512:1046:b0:50b:b9f3:9fc6 with SMTP id c6-20020a056512104600b0050bb9f39fc6mr534218lfb.54.1701436843083; Fri, 01 Dec 2023 05:20:43 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:42 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:39 +0100 Subject: [PATCH v2 10/10] ASoC: cs4349: Drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-10-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052045_130516_E387E246 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs4349.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs4349.c b/sound/soc/codecs/cs4349.c index 9083228495d4..ca8f21aa4837 100644 --- a/sound/soc/codecs/cs4349.c +++ b/sound/soc/codecs/cs4349.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include