From patchwork Tue Dec 5 08:52:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nirmoy Das X-Patchwork-Id: 13479589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2CCAC4167B for ; Tue, 5 Dec 2023 09:05:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C58810E4BD; Tue, 5 Dec 2023 09:05:48 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61CDB10E4BD; Tue, 5 Dec 2023 09:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701767147; x=1733303147; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Bct7twb9lZj4S2IbQNME6rHyvO9QAWywg4pODCJR70k=; b=VJxmTMrFVkqRwtZFdjTAy2LnDrA5Pcx+H4C6HorCnXXaDxLW5w8drzsJ LdoDCzkqJ2mzVp5BOQhAAD8ZHQV2aDEBTkgOYpNqMMtY9kBgLCZGVaqnR eZiYR1/xMClBmpdfwM2d4/qF7p78PvC2gOznY+NqDO1+WjSvSdQZ2ysJh 4vn064nmNMAeax22n/CgVe24bitRB06kcYnm39yGGZ0Hzo0Fr3c+Kl7TQ qRJiU73sbqYvn4FRflxjnhSHyt1uVurP1xa+PK8TxrmQMUaYboSf/crHK dQzrPE7Kx6zMc4va2FQ8zxpYyFX5DtkvEl5qSeY/1OvTRznfFN4hp7DS5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="708380" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="708380" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 01:05:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="774566592" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="774566592" Received: from nirmoyda-desk.igk.intel.com ([10.102.138.190]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 01:05:44 -0800 From: Nirmoy Das To: intel-gfx@lists.freedesktop.org Date: Tue, 5 Dec 2023 09:52:48 +0100 Message-ID: <20231205085248.2577-1-nirmoy.das@intel.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Organization: Intel Deutschland GmbH, Registered Address: Am Campeon 10, 85579 Neubiberg, Germany, Commercial Register: Amtsgericht Muenchen HRB 186928 Subject: [Intel-gfx] [PATCH v2] drm/i915/gt: Convert reset prepare failure log to trace X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Hajda , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Convert the log to a trace log for debugging without triggering unnecessary concerns in CI or for end-users during non-fatal scenarios. v2: Improve commit message(Tvrtko) Cc: Tvrtko Ursulin Cc: John Harrison Cc: Andi Shyti Cc: Andrzej Hajda Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591 Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_reset.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index d5ed904f355d..e6fbc6202c80 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -593,10 +593,10 @@ static int gen8_engine_reset_prepare(struct intel_engine_cs *engine) ret = __intel_wait_for_register_fw(uncore, reg, mask, ack, 700, 0, NULL); if (ret) - gt_err(engine->gt, - "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", - engine->name, request, - intel_uncore_read_fw(uncore, reg)); + GT_TRACE(engine->gt, + "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", + engine->name, request, + intel_uncore_read_fw(uncore, reg)); return ret; }