From patchwork Wed Dec 6 11:17:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13481569 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F39C31593; Wed, 6 Dec 2023 11:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dc6MzjIq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9E42C433CC; Wed, 6 Dec 2023 11:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701861462; bh=wLgR6MqTrL0B4AsUWLMzOT2VikZmtlYBcwK7nvTkcP0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dc6MzjIqCRFIBpCJfXIlNh6FPSx1TfNtsw1Ls8kAazTIq7mWZqd1OR2h+YsBT0FNy MGnDROFTefdq2hFjR2ok5K1iY+02ui/JiRNNCIXbbJW56cHlKnWpuGmWR5Q+cm2Ym2 jKsWsE+GiLpnBMoJB1OnrIclQDLJBstAaYvsx7UBU//NhXTqp62rqDXJ2tDFBWByNO EJbtxom2GoA0RBfo3Fw9GhMad1gL6PV0/KQLE34JCr0reDqNwjtREOT3socN/5fzbk H9O6yXOel5Gxo/0Vhq6i7kqYDZdlJB/eloWDnnY1HNiMohqWVgLU5ofZ+XLq3Irw6g 78SY5OnCgwFTQ== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rApvA-0001wE-1T; Wed, 06 Dec 2023 12:18:28 +0100 From: Johan Hovold To: Lee Jones Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski Subject: [PATCH v3 1/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix up binding reference Date: Wed, 6 Dec 2023 12:17:51 +0100 Message-ID: <20231206111754.7410-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231206111754.7410-1-johan+linaro@kernel.org> References: <20231206111754.7410-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fix up the SPMI PMIC binding document free text reference which erroneously referred to itself rather than the parent SPMI controller binding as intended. Fixes: 9e5917288545 ("dt: document HiSilicon SPMI controller and mfd/regulator properties") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Johan Hovold --- .../devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml index bdff5b653453..e36e5ce58136 100644 --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml @@ -17,7 +17,7 @@ description: | node. The SPMI controller part is provided by - Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml + Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml properties: $nodename: From patchwork Wed Dec 6 11:17:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13481570 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5662E3172A; Wed, 6 Dec 2023 11:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kkWOUTBE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEC36C433C7; Wed, 6 Dec 2023 11:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701861461; bh=SGDDtanpuy2F23oyCza+p5DlVsIoWTxJOOMzvs5zlaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kkWOUTBEiXapYrbVBAwbZ4TRaU50H/SRZeVWkIsHXxrJrrqpudu9m/shx+NPO9/7w Ocvr/C6SnwgIkgEWxC/f+2kfViekOgLNi+zlP/N9ugGlxEJbVtEJdPaDE/efW9o35T 1kxdCrtiZzK2HuryahEBS0/chuQCzSzTl9WkV0CLOaDPtBwIZy0HK6238DjL9MaGVV L5rGuAVGERlCQvbTHzXnWqDVFOYhIjFz/OV8PeLS5667rzR9onPgo/iXGGlDXIeHqy oRSa0UnpiuwPjwdgpgGRwXDcfRJwgYIECfej++iAOgqHiCmhARuX0vNE12fAiZ6QDX g9PpsR97PDp5A== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rApvA-0001wG-1i; Wed, 06 Dec 2023 12:18:28 +0100 From: Johan Hovold To: Lee Jones Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Johan Hovold , Rob Herring Subject: [PATCH v3 2/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix regulator binding Date: Wed, 6 Dec 2023 12:17:52 +0100 Message-ID: <20231206111754.7410-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231206111754.7410-1-johan+linaro@kernel.org> References: <20231206111754.7410-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The regulator child nodes do not have unit addresses so drop the incorrect '#address-cells' and '#size-cells' properties from the parent 'regulators' node. Fixes: 352335a6aced ("staging: hikey9xx: hisilicon, hi6421-spmi-pmic.yaml: simplify props") Reviewed-by: Rob Herring Signed-off-by: Johan Hovold --- .../bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml index e36e5ce58136..45cd6a613a91 100644 --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml @@ -42,13 +42,6 @@ properties: additionalProperties: false - properties: - '#address-cells': - const: 1 - - '#size-cells': - const: 0 - patternProperties: '^ldo[0-9]+$': type: object @@ -77,9 +70,6 @@ examples: interrupts = <0 0>; regulators { - #address-cells = <1>; - #size-cells = <0>; - ldo3: ldo3 { regulator-name = "ldo3"; regulator-min-microvolt = <1500000>; From patchwork Wed Dec 6 11:17:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13481571 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 565DD31728; Wed, 6 Dec 2023 11:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E8Xs7Mf+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2A45C433C9; Wed, 6 Dec 2023 11:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701861462; bh=T2z/FCGOZTuZvMKsnWedFJwmDPaovLjYsoXHwnzGLm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E8Xs7Mf+yvYVbVgFDPG70M+BYfmM74f+VGjl4MWCtc9wpqmklDMyBPQLNQoo/jqGZ wprvZuPGoIlM/8o+g0+KK0EfcN8KljesIR4dFSekWdx+TV3aOlXusdZnSfrQ7dK7aL Jh5u3wAhwxHG4MDRhf++92RJWKxWxyLFIRf4DcUbC9f2LXn4x30UnqxUbzn6aK5V7r 2rVbuR2T6AulcvObV+gJVlSw+dmqvJ42djabqP6kuu8/xH59dlcdSykF7rM8WQ5d4L U2vrvWJBR+/+9wB9e5JI4ArtfubCotW7mXnykiWosnimjFnBszO7kNdn1wE662nJyT UQKYLLbdLcZgw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rApvA-0001wI-1w; Wed, 06 Dec 2023 12:18:28 +0100 From: Johan Hovold To: Lee Jones Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski Subject: [PATCH v3 3/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: clean up example Date: Wed, 6 Dec 2023 12:17:53 +0100 Message-ID: <20231206111754.7410-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231206111754.7410-1-johan+linaro@kernel.org> References: <20231206111754.7410-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The SPMI PMIC sits on an SPMI bus which and has two address cells with no size. Clean up the example by adding a parent SPMI bus node with proper '#address-cells' and '#size-cells' properties, using a define for the second register value, dropping the unnecessary label and increasing the indentation to four spaces. Acked-by: Krzysztof Kozlowski Signed-off-by: Johan Hovold --- .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 134 +++++++++--------- 1 file changed, 70 insertions(+), 64 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml index 45cd6a613a91..6a824351834e 100644 --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml @@ -59,69 +59,75 @@ additionalProperties: false examples: - | - - pmic: pmic@0 { - compatible = "hisilicon,hi6421v600-spmi"; - reg = <0 0>; - - #interrupt-cells = <2>; - interrupt-controller; - interrupt-parent = <&gpio28>; - interrupts = <0 0>; - - regulators { - ldo3: ldo3 { - regulator-name = "ldo3"; - regulator-min-microvolt = <1500000>; - regulator-max-microvolt = <2000000>; - regulator-boot-on; - }; - - ldo4: ldo4 { - regulator-name = "ldo4"; - regulator-min-microvolt = <1725000>; - regulator-max-microvolt = <1900000>; - regulator-boot-on; - }; - - ldo9: ldo9 { - regulator-name = "ldo9"; - regulator-min-microvolt = <1750000>; - regulator-max-microvolt = <3300000>; - regulator-boot-on; - }; - - ldo15: ldo15 { - regulator-name = "ldo15"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3000000>; - regulator-always-on; - }; - - ldo16: ldo16 { - regulator-name = "ldo16"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3000000>; - regulator-boot-on; - }; - - ldo17: ldo17 { - regulator-name = "ldo17"; - regulator-min-microvolt = <2500000>; - regulator-max-microvolt = <3300000>; - }; - - ldo33: ldo33 { - regulator-name = "ldo33"; - regulator-min-microvolt = <2500000>; - regulator-max-microvolt = <3300000>; - regulator-boot-on; - }; - - ldo34: ldo34 { - regulator-name = "ldo34"; - regulator-min-microvolt = <2600000>; - regulator-max-microvolt = <3300000>; + #include + + spmi { + #address-cells = <2>; + #size-cells = <0>; + + pmic@0 { + compatible = "hisilicon,hi6421v600-spmi"; + reg = <0 SPMI_USID>; + + #interrupt-cells = <2>; + interrupt-controller; + interrupt-parent = <&gpio28>; + interrupts = <0 0>; + + regulators { + ldo3 { + regulator-name = "ldo3"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <2000000>; + regulator-boot-on; + }; + + ldo4 { + regulator-name = "ldo4"; + regulator-min-microvolt = <1725000>; + regulator-max-microvolt = <1900000>; + regulator-boot-on; + }; + + ldo9 { + regulator-name = "ldo9"; + regulator-min-microvolt = <1750000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + }; + + ldo15 { + regulator-name = "ldo15"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3000000>; + regulator-always-on; + }; + + ldo16 { + regulator-name = "ldo16"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3000000>; + regulator-boot-on; + }; + + ldo17 { + regulator-name = "ldo17"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <3300000>; + }; + + ldo33 { + regulator-name = "ldo33"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + }; + + ldo34 { + regulator-name = "ldo34"; + regulator-min-microvolt = <2600000>; + regulator-max-microvolt = <3300000>; + }; + }; }; - }; }; From patchwork Wed Dec 6 11:17:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 13481573 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 568273172E; Wed, 6 Dec 2023 11:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SL/gPgdT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7946C433CB; Wed, 6 Dec 2023 11:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701861462; bh=wMWsV85NWCSegh0Gab+O0xc9mK0JLvIvAXgKFlqRUBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SL/gPgdTsF/7MmxwofVLR1UAmX6VOKajZh25GWG12l+G1HsiDNJNNgd98MRd8v9kH jFW1puRE8Multrki2iGnJDBp7SPDsWiSsGZHnvRcVY/4vGCVVhDBBNYOIqBvqtumPk j3Fw4azh5uV+04vKi+WfOL53fyClkx+t+ZZfEfjHIv64du1LWd5Dc+SJbfDYfIsxUj xsC1RcJGM5eu344Pfvsl7owaBcqoGpDNo208uTDkAkOziVDiVejgyfSp9qSpqF2nAK tphXvD4GC0VRAuGt/20YGWoSzEFnxtScrgSdCeFgSnivRzdOe0uSqD4TZA6zeGnrBl 8RphkmcOKeGZQ== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rApvA-0001wK-2D; Wed, 06 Dec 2023 12:18:28 +0100 From: Johan Hovold To: Lee Jones Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Johan Hovold , Conor Dooley Subject: [PATCH v3 4/4] dt-bindings: mfd: pm8008: clean up example node names Date: Wed, 6 Dec 2023 12:17:54 +0100 Message-ID: <20231206111754.7410-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231206111754.7410-1-johan+linaro@kernel.org> References: <20231206111754.7410-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Devicetree node names should be generic; fix up the pm8008 binding example accordingly. Acked-by: Conor Dooley Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml index 9e4eed34dae8..0c75d8bde568 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml @@ -99,10 +99,12 @@ examples: - | #include #include - qupv3_se13_i2c { + + i2c { #address-cells = <1>; #size-cells = <0>; - pm8008i@8 { + + pmic@8 { compatible = "qcom,pm8008"; reg = <0x8>; #address-cells = <1>;