From patchwork Thu Dec 7 09:12:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 13482997 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="CQ5OKXtB" Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AEAE10E3 for ; Thu, 7 Dec 2023 01:12:12 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40c19f5f822so3741465e9.1 for ; Thu, 07 Dec 2023 01:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1701940331; x=1702545131; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kNLG30CN2zegE/M7jl95INA4rCvQrv07QBb0d7Gkeww=; b=CQ5OKXtBgoLI7WRNq+gepaxQthGmLKGMx/xDCrEKKseT6EmHhNOF1vEOQLq2E9WTOP MKu0hz6n9mKExAoQ4PqKoFynIwUdWJg9vgrMA1WUn2566fcgBFrPPbZLVFSE7QVdaCGw DASzFHMY05UvH7Bh0+qnv50ZQoX1ec4Dy0evFsX4GfltgaC3ZNfrHgDV16GLJgLyN4DD kuhEpFoXt4Btqsl9kroFcOhC6mZxdNJj7VUgC3g+Fi3Jx/WJj962PuljGcoXuzufHJgb +wlD9p5igrvKvDmiFS8dNvnsqlF20MoeYZ34bP9c5keQsE9xvV+GFyXHdtC7+p+zjvXk HG1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701940331; x=1702545131; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kNLG30CN2zegE/M7jl95INA4rCvQrv07QBb0d7Gkeww=; b=bQZ3e2HjXxuKN7bBRAdCEzext3cpjfSrT30orvdyNZ3Fihta82uOP0bBDzk8clZZa6 hNqZ6I3P5McUnzMK7C5HCLaFuX1ia/KLQNhBnTF19bEEwdYOR3tIUYcQaNzAo0BYUcEq fXswhE9CaiqQrIKjK1r9jpvCeAEc7Hf2s7QXLUJoXq4XnJCHC6Xl6o/ySZYtNH5TI3PY lhvqAQtSQmYsJDs1uvQ/IoifAgZGu98N/aAI5RmuuoQH7iazqaHF7T39loo77wWdjx5P dBLRRhgMC8CzriF5t3DPRFMSl2RNRiDd9SI9CczEjWlC5FznM2pViZpEHBfp5+ebdmaA hDxw== X-Gm-Message-State: AOJu0YyDaW9uMU5B9rTkdNYq8M9iO4yGOwyT+/GbcJme0yPVt7LFiwiM 4V3vnnXHlq+1W7lYDTGM1EYPig== X-Google-Smtp-Source: AGHT+IErPK+hX/Ij8xcH1pt2rolGWBmbdJU42c/YHeF/TrT7Ywo/oD5Kt5AujnyiPUZWxwdSbkeY5w== X-Received: by 2002:a05:600c:3553:b0:40b:27b4:b4eb with SMTP id i19-20020a05600c355300b0040b27b4b4ebmr2418920wmq.4.1701940330981; Thu, 07 Dec 2023 01:12:10 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:de32:8b0f:dc9a:4dce]) by smtp.gmail.com with ESMTPSA id y3-20020adff6c3000000b0033334c3acb6sm896009wrp.98.2023.12.07.01.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 01:12:10 -0800 (PST) From: Bartosz Golaszewski To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Alex Elder , Srini Kandagatla , Bjorn Andersson Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 1/3] dt-bindings: net: bluetooth: qualcomm: fix a typo Date: Thu, 7 Dec 2023 10:12:00 +0100 Message-Id: <20231207091202.19231-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231207091202.19231-1-brgl@bgdev.pl> References: <20231207091202.19231-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bartosz Golaszewski Spell supply correctly. Signed-off-by: Bartosz Golaszewski --- .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index eba2f3026ab0..ba8205f88e5f 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -69,7 +69,7 @@ properties: description: VDD_RFA_CMN supply regulator handle vddrfa0p8-supply: - description: VDD_RFA_0P8 suppply regulator handle + description: VDD_RFA_0P8 supply regulator handle vddrfa1p7-supply: description: VDD_RFA_1P7 supply regulator handle From patchwork Thu Dec 7 09:12:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 13482999 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="BTbq9mDE" Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2E7910CE for ; Thu, 7 Dec 2023 01:12:13 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40c1e3ea2f2so7363375e9.2 for ; Thu, 07 Dec 2023 01:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1701940332; x=1702545132; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P8Iep3f8IbW9XJUviPCyqs/DBfreAlewexDEpMRvmDo=; b=BTbq9mDEYAiL+96ZzZApuWxeAFQS2d2PpPPZocNBP0JD1fGNZctkJM+Qj8Hep/dnbz Lc8KXrR9os6zyQ9D991DGCHLU/XwG+OIcguXabvTEjJLRYgmeCbsBG7QlNdyPVRnOE27 sJuWfLTZZs7uuS8Qw6RvsLx84MhJfKXfqferDtHQIxvX/eB/3pQNlWdBpcmQqCtarYFL JCawR9jdlfgBc1WrKTXzPWrbgyv3HUe3/eWi8pjsoLf23NGGRTMSUDFP981F9tdEppAr 6XITsS241i+2TXYOM+k8lcuFj9h8PVgd1ZbaXtwr4ywbdBb/Wahceqh3zfMIA7aFTxQt GmCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701940332; x=1702545132; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P8Iep3f8IbW9XJUviPCyqs/DBfreAlewexDEpMRvmDo=; b=kUctMOXtx70S/LCEifu1qCflQ5fdTLh624TU202Wxa2GNgB8wkJEIKZnRQ2WF11DNA rJhtMgrkxgUBQ56PfzV/Iz7kUMP7ScS5slifOA2UoQFfTnh3FswHo7zu2yyCb1aZhsNA KPaGmus2xWIgzxr4nNJ5jRRdnfYKYkECz38N50EWZQA27eKh2Rex3qKybpIsMjh5PDz0 JkVQHBMKqxgwf9LloJ8lcXq/xxBhHbUITttGWkxuZSErk1eTfxKFWhyf4xP8p3bMzxNo L+PCcywwx+Zng/tDuAinF8Bo1bdUhdP6R8PR0UdFKHwAOv32UHwP6VX+JOGvcwXNfERO MFnw== X-Gm-Message-State: AOJu0YwVcHhBUQGfp9CZqR96Bye2oL9o+Fm2j1PVaS7E6QeWhvPVWWhg ohEDDfOledsg7+NkdcwU71L1Hw== X-Google-Smtp-Source: AGHT+IH20Zn1uTIOUuW+48Vx0oVF0nDTgMGZyFOdUjShve7iw+aZCG1zm/jU7hRgv5pnJr3guxbQ8Q== X-Received: by 2002:a05:600c:3b1f:b0:40b:2a18:f1be with SMTP id m31-20020a05600c3b1f00b0040b2a18f1bemr1427841wms.1.1701940332105; Thu, 07 Dec 2023 01:12:12 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:de32:8b0f:dc9a:4dce]) by smtp.gmail.com with ESMTPSA id y3-20020adff6c3000000b0033334c3acb6sm896009wrp.98.2023.12.07.01.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 01:12:11 -0800 (PST) From: Bartosz Golaszewski To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Alex Elder , Srini Kandagatla , Bjorn Andersson Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 2/3] dt-bindings: net: bluetooth: qualcomm: add regulators for QCA6390 Date: Thu, 7 Dec 2023 10:12:01 +0100 Message-Id: <20231207091202.19231-3-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231207091202.19231-1-brgl@bgdev.pl> References: <20231207091202.19231-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bartosz Golaszewski Add regulator properties for QCA6390 that are missing from the bindings and enforce required properties for this model as well. Signed-off-by: Bartosz Golaszewski --- .../net/bluetooth/qualcomm-bluetooth.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index ba8205f88e5f..861663f280eb 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -65,12 +65,21 @@ properties: vddbtcxmx-supply: description: VDD_BT_CXMX supply regulator handle + vddpmu-supply: + description: VDD_PMU supply regulator handle + vddrfacmn-supply: description: VDD_RFA_CMN supply regulator handle vddrfa0p8-supply: description: VDD_RFA_0P8 supply regulator handle + vddrfa0p9-supply: + description: VDD_RFA_0P9 supply regulator handle + + vddrfa1p3-supply: + description: VDD_RFA1P3 supply regulator handle + vddrfa1p7-supply: description: VDD_RFA_1P7 supply regulator handle @@ -180,6 +189,21 @@ allOf: - vddrfa0p8-supply - vddrfa1p2-supply - vddrfa1p9-supply + - if: + properties: + compatible: + contains: + enum: + - qcom,qca6390-bt + then: + required: + - enable-gpios + - vddio-supply + - vddpmu-supply + - vddaon-supply + - vddrfa0p9-supply + - vddrfa1p3-supply + - vddrfa1p9-supply examples: - | From patchwork Thu Dec 7 09:12:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 13483000 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="NUWxowhs" Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2563610EC for ; Thu, 7 Dec 2023 01:12:15 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40b397793aaso3875995e9.0 for ; Thu, 07 Dec 2023 01:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1701940333; x=1702545133; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=abIGam56kSZ3DhSDuEO3BjQb5HXWW5MMfEQ3kw2b1bA=; b=NUWxowhsMgLiuMreM/JfPoF26hF9hNWz1eKHez7UJrpbNzRFYPqmxs9o8vI9dOaO/7 lU7aSIjQH8z5bUabkqqE6rHOYOouLQiRtdFjEKgknz9Nef+2RimeEwBKf6nSyT6bbRPa 66gKuDlvx/ozQncRf1OFY8NmHY3cINfSv8C/LqClbTc2c5NGsk2nuLrQKSMnkvWSSmcK PRaw1ufVLFi+qhoJQwRpmAz/4Tc0G1oQJV7fdwGitT9fm7XMqJczogIrdEXZArWPnWNR nvGZCex9xmgU66Oxnu52SbB60nlC9FfRoRWRDousEuYcC0QL309Icmj8/iIOvL0uS4IA LZTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701940333; x=1702545133; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abIGam56kSZ3DhSDuEO3BjQb5HXWW5MMfEQ3kw2b1bA=; b=HJjPOeWsvREZ2uFZ20OoNWVbU0KF2E9WqXIRQF2paizEdFC06r6RNoaCFTfFfwau1M SmSJdH9IIVB4rgJszQwKi2M3wnYafuzepikD1SREzxgi27rqQrRD3tGS3ED1d2ccRpdl gMdPGXPCHQA0KR+hElUt7jaD30ZyvJz8E3CRw1VqOGjHYqK4gTwwzIUJYzPVc7Zo94HZ dxrkvKslqMpBSYREAegEP/xMvD2OWNqAb5OAPSEuWALjxxEyE17JOKVlTqCxgCzp90GF qk0YHgJ7EX1AWShtVGkjzyJpTMWWwhDfYtFerBlP5g8JwHS6zNSvPBl9dBtgZycpl+3F uwbw== X-Gm-Message-State: AOJu0YzYROEwxONd0sqJoi5Br2TmHFJ65aiULRCQzi6lCcICf8+uPaA3 MuYlTfp/8obBK/Swh9CnfZ3S4w== X-Google-Smtp-Source: AGHT+IFPy6rDPC84jLuaSGV9bgwyFSV/vFR4KlGp8lebRYr+5pOBmJ32Bs+S3ip1jKFNvcx/lCuWyQ== X-Received: by 2002:a7b:ca4c:0:b0:40c:2c2d:78da with SMTP id m12-20020a7bca4c000000b0040c2c2d78damr154975wml.170.1701940333379; Thu, 07 Dec 2023 01:12:13 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:de32:8b0f:dc9a:4dce]) by smtp.gmail.com with ESMTPSA id y3-20020adff6c3000000b0033334c3acb6sm896009wrp.98.2023.12.07.01.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 01:12:12 -0800 (PST) From: Bartosz Golaszewski To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Alex Elder , Srini Kandagatla , Bjorn Andersson Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 3/3] Bluetooth: qca: run the power-on/off sequence for QCA6390 too Date: Thu, 7 Dec 2023 10:12:02 +0100 Message-Id: <20231207091202.19231-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231207091202.19231-1-brgl@bgdev.pl> References: <20231207091202.19231-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bartosz Golaszewski The Bluetooth module on QCA6390 needs to be powered-on by enabling the relevant regulators and driving the enable GPIO high. We can reuse the power sequence for the WNC models if we add the list of required regulators to the OF match data. Signed-off-by: Bartosz Golaszewski --- drivers/bluetooth/hci_qca.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 35f74f209d1f..b27be08a1f6f 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1788,6 +1788,7 @@ static int qca_power_on(struct hci_dev *hdev) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: + case QCA_QCA6390: ret = qca_regulator_init(hu); break; @@ -2044,7 +2045,15 @@ static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = { static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = { .soc_type = QCA_QCA6390, - .num_vregs = 0, + .vregs = (struct qca_vreg []) { + { "vddio", 20000 }, + { "vddaon", 100000 }, + { "vddpmu", 1250000 }, + { "vddrfa0p9", 200000 }, + { "vddrfa1p3", 400000 }, + { "vddrfa1p9", 400000 }, + }, + .num_vregs = 6, }; static const struct qca_device_data qca_soc_data_wcn6750 __maybe_unused = { @@ -2129,6 +2138,7 @@ static void qca_power_shutdown(struct hci_uart *hu) case QCA_WCN6750: case QCA_WCN6855: + case QCA_QCA6390: gpiod_set_value_cansleep(qcadev->bt_en, 0); msleep(100); qca_regulator_disable(qcadev); @@ -2276,6 +2286,7 @@ static int qca_serdev_probe(struct serdev_device *serdev) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: + case QCA_QCA6390: qcadev->bt_power = devm_kzalloc(&serdev->dev, sizeof(struct qca_power), GFP_KERNEL); @@ -2386,6 +2397,7 @@ static void qca_serdev_remove(struct serdev_device *serdev) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: + case QCA_QCA6390: if (power->vregs_on) { qca_power_shutdown(&qcadev->serdev_hu); break;