From patchwork Thu Dec 7 18:55:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13483855 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BB16C10DCE for ; Thu, 7 Dec 2023 18:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=NM5TUOjOVfmZhf3RSzw3VUkxJVsoEF2HxGpVUR8SwO4=; b=1Rr2F0fvHeJBoz 1KGRqk5x4wklRjHT4JqNUdp93yBW+Jg4UXiXYjL+n1rYX12YTQEMeXCgkkJQvXmin1sKsCNFK11Td eou+9SHe8lxc4dDkazpUdkrFgo7ygEZ2IlpEUDW5gAQythBB2xXGIO5QQ+dCVWmWcMhW8+cvwG955 v0c8wUzMNBlYLV4MTkL9SxxWezaoKnVC81Vd28RcA67AMBNJYwRE7OVETLvKnBGiQkBBTxlrxzjHx aB8P+ypvd6+6WVFrk06RIuETUJ8kCQqUmx9aSKCQq40oTww+U1LYP69D7DTV7aHo4XQquJtUD8HWu 7jDSAyJBg8f6fuCLGxrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXQ-00Dgbd-1J; Thu, 07 Dec 2023 18:55:56 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXL-00DgaK-2G for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 18:55:54 +0000 Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-5c6910e93e3so175460a12.1 for ; Thu, 07 Dec 2023 10:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701975350; x=1702580150; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xo3qTdKmFmblf7WMfXpDJ0N3rJLoonf5rC1XRTnI03Q=; b=dDgZRcpU/vVc/tLKVL7E6nXCulcSTzYcJf5AI7gLOGmx/BkNABZfX6uZNCUFpg/6PD nJvSte05uJzuAD+AQVUdcl/RpSQyCxUyyzuqKBpPT8UG7d03LIyApr8w6PoKeEE8USM4 rTD58k43sKRw1K/H5M4Vu3lcqvfJNxZsOzEiQy7NVCkavROYPKn8+HP36MdeVa7aaCmR rIIoBYxKH41wtEScAJ3BehaONydy0bYUVV8U6j/+wRJxBsoCV+3PPkw4ufKsAR92t/FZ cWje/O4nmHsB1bNCUD/p2z7k1x63ZSyT61XjbGPRkCXb3WIpHD+0lwLex0QcA4Xrxthn 5n1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701975350; x=1702580150; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xo3qTdKmFmblf7WMfXpDJ0N3rJLoonf5rC1XRTnI03Q=; b=rFnSPlf0hu1d8v706kiuvjr62WscOQvyPaJBjpZkfj4nJEgdkV5TKr3eHjRAyOjHcx 7ozbI8A3tau6WuTUNpYs3IrywZP+WqQSMWa1msFHZbG7Shv2xGTBpMftNh+e3Xd7X4l8 SiA9gQhamOHIN32fvJqDFbm/Ai6ROHhEDjWKH5n9VuMxEBS35XmV73tMkUUk65yEL5bs WdSqQz4Eo7pnkpwlan8Z+pAd4iMnddR+RN8/CKaDON2ik7Jq+qoTk9RIb5bMl8QoisaQ zWnGejeVRlkT/SvtZXCKwuTmQagSU8GCOvFxRiR4u78BOorV6gdgGvLCV5hRFXjvHvgF ID5Q== X-Gm-Message-State: AOJu0Yy4azO2FHo6je3Be4mkPFtwbRrPCQKLyLJ4HeXzLww7CaYgGMea 47+VV0hK3cyQpkyzfNzenHQ= X-Google-Smtp-Source: AGHT+IG8WY7y2yXBDag879H2V0yG1dZLdTQCe8nMglkDZzghNxkjVV+ALRl/1wpIRD8uwRc5/2RxYQ== X-Received: by 2002:a17:90b:48ce:b0:283:5405:9e90 with SMTP id li14-20020a17090b48ce00b0028354059e90mr5865053pjb.3.1701975350443; Thu, 07 Dec 2023 10:55:50 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:492a:db3d:eb42:de92]) by smtp.gmail.com with ESMTPSA id hk13-20020a17090b224d00b0028699a25207sm1723732pjb.12.2023.12.07.10.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 10:55:49 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH 1/3] arm64: dts: imx8mp-verdin: Fix USB connector description Date: Thu, 7 Dec 2023 15:55:41 -0300 Message-Id: <20231207185543.2699697-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_105551_741455_35DD5927 X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-verdin-wifi-mallow.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml# Signed-off-by: Fabio Estevam --- .../boot/dts/freescale/imx8mp-verdin.dtsi | 30 +++++++++++++------ 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi index 04f2083c4ab2..c3305f0d4001 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi @@ -45,6 +45,23 @@ backlight_mezzanine: backlight-mezzanine { status = "disabled"; }; + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + id-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; + label = "Type-C"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb_1_id>; + self-powered; + type = "micro"; + vbus-supply = <®_usb1_vbus>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + gpio-keys { compatible = "gpio-keys"; pinctrl-names = "default"; @@ -835,15 +852,10 @@ &usb_dwc3_0 { srp-disable; usb-role-switch; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - id-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; - label = "Type-C"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usb_1_id>; - self-powered; - type = "micro"; - vbus-supply = <®_usb1_vbus>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; From patchwork Thu Dec 7 18:55:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13483856 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4099C4167B for ; Thu, 7 Dec 2023 18:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JOz+xeijikmXwu+gb9nGUMl+ehVOOcabNaybTgAvmz4=; b=rpQZW69beQhWg7 V6dCHMLHS8wB61Y7LDahIWwvJ09YlboZ1Li5UtqkWfyWT/6pNyWwKOM9N/5HOfollx3Yov8lj1fcS CkzJZc9njujlfmNJFDOPAIzoQ9VNILJvTTlBTq1zSluWYhoKvyc7uKKNwmtPYBfGCJIZJlj8VjHwR CNwuj58q1FH4QeEMuqlY8ehtSrI4quewPiBu55n+B6M/L+srgBRN1BB9IR6/47CsHbIQbypZHe2GI 9QVqt31aZpo96Hf7XVjA/3NQdZYq2tE33Qpsjyfut0Qm1pG6qStiCJsO44SXff98Ed8f0laKPgfG8 mm3PQE8s45P15OrQ94LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXT-00DgdJ-0H; Thu, 07 Dec 2023 18:55:59 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXO-00DgbE-1j for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 18:55:56 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2866b15b013so246809a91.0 for ; Thu, 07 Dec 2023 10:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701975353; x=1702580153; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f92ey//GX+Rbqx09COi87AZGGQWIeZfnPA8hrWm87UE=; b=SlVCEH/CA4OIvbAY2FEy973geYTiXfNqjjuUNTzk0Fzcf/eqFnciwOR/MEsE7NPCOg SZ2UGy9QMFe+dFz6HPSTmnHu4CP1MRDmq/s4couH0jec/+8QwBpIXSugpKvaW9habuUe douyOiQ7Mw5/OxwxUQqG5KO/2LBtHb+PJUsRbkBbVI1mgeEvNLWRS6MMy1PNBOMeQkyF oauAf0t77uMtPrq75USmtfUruRSVE6V3rAuK4aO0HCtXkHTgxNMoR9tlovwpVjc5rjGP Fbsoa8CrND/QOD2GUoazv9wNywqO04Im/cGq2ykb37Txkr5yWIVEun8OnGEX53db7MSQ Oacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701975353; x=1702580153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f92ey//GX+Rbqx09COi87AZGGQWIeZfnPA8hrWm87UE=; b=DD/Pz9FLaQvoQ26oaQBIfOh+d5YpPoN5exskOhVzg5bld5uusRl7aL+0k8yF30iHHu wsVUAmoxCafLv40Lo/NjiRNDhETbwFgZm4/UMweuGh+TpzQar0j8OB7v/Sc9/PtSkvy5 v/l0OX3QPvj4q2eY2krg8jIutk+jUicTccAik4teHsARWPkuHoJeyIQSMw+Ef5fN//PK WJLbZLa8ivztx63ILugDVglgZOPMIv6vmLY7RppE4wfsotrjlGM1krL/NwOs08jziIML /8Scf2ReMHfYoBasTaN9/+V2bl/pRHjtYUu2U8FiBZnkaREScemAr5VMkIJ6rs38/VbF eSBA== X-Gm-Message-State: AOJu0YyJQi1HEZS2MrjOCuhpsJKKwTg09qEZR0lG2VTAub9iemlwTGsd B3d9fBsEV6Jx4v8hbNWVH9w= X-Google-Smtp-Source: AGHT+IHaXNmeqVM91a7esXurTTlDnrjJb8+rGqD/j2O/OfpHDNZnGDW4vZuG2H/XIbXr6VhANvEYvA== X-Received: by 2002:a17:90a:d252:b0:286:f169:79f1 with SMTP id o18-20020a17090ad25200b00286f16979f1mr5849429pjw.2.1701975352922; Thu, 07 Dec 2023 10:55:52 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:492a:db3d:eb42:de92]) by smtp.gmail.com with ESMTPSA id hk13-20020a17090b224d00b0028699a25207sm1723732pjb.12.2023.12.07.10.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 10:55:52 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH 2/3] arm64: dts: imx8mp-venice: Fix USB connector description Date: Thu, 7 Dec 2023 15:55:42 -0300 Message-Id: <20231207185543.2699697-2-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231207185543.2699697-1-festevam@gmail.com> References: <20231207185543.2699697-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_105554_577774_DB498EAF X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-venice-gw72xx-2x.dtb: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# Signed-off-by: Fabio Estevam Acked-by: Tim Harvey --- .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 26 +++++++++++++----- .../dts/freescale/imx8mp-venice-gw72xx.dtsi | 27 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw73xx.dtsi | 27 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw74xx.dts | 27 ++++++++++++++----- 4 files changed, 79 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi index bf47b5e9dd8c..0e8d0f3c7ea8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -132,13 +147,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi index 28eb7c00a1d9..f8ad5ea96330 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi @@ -8,6 +8,22 @@ #include / { + + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -182,13 +198,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi index b0d42b18c5ce..0b89aa73998c 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi @@ -8,6 +8,22 @@ #include / { + + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -201,13 +217,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts index dcf9bababffc..b323711fa090 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts @@ -35,6 +35,22 @@ memory@40000000 { reg = <0x0 0x40000000 0 0x80000000>; }; + + connector { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -692,13 +708,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - compatible = "gpio-usb-b-connector", "usb-b-connector"; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; From patchwork Thu Dec 7 18:55:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13483857 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3C49C10F04 for ; Thu, 7 Dec 2023 18:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5LH0csuxMe50bxeoCHKe+4yNFlZN9eqFtvsokk/1GN8=; b=GONFkkc1B/giFS xXfnaoqtJ8HxvGblBSDjf5c9bGbCV/PkrH+Exyn2oGsQyXCDpOWSmjkabaFEKJ2xMm7Xx7QzXIfda Z/ribhVkJQeDKr4ckgLSfJKSEMRWcgmFTVXtkTrwdxKh9aLQT9KZLSCNJ490XDlWUWbmJDlW4BLGC fntMIyq0ylfYcRjYYoUEbK/yqgzyj4yNF6TLtcURyjfjlQn9wV0SDdmq4WU0zsBEUgGrmAk0nvBOx DlenUUuJdAzX6h7edt119oDpHgKAYCdpGYV0jgIG7tWq6mo/S0ZfNWxzw0cROZHdTql0X9VWFA9QT K7NKRPNkZ1sFh5ymTQBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXV-00Dger-2j; Thu, 07 Dec 2023 18:56:01 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXQ-00Dgbc-2E for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 18:55:58 +0000 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-286f3e0d010so326743a91.0 for ; Thu, 07 Dec 2023 10:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701975355; x=1702580155; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BojcaTl+dlN3l1hjjhDcQ41U7chb1ovivkDVmYwiv8s=; b=VAyd3kpin2Y8yxEMf67mjhXK1oXlpsNUukc1rEph64x4IyNUhoRN3nWKlUk1cYkdDM BsaPqEJpWDM4IV70vZsEhMlXS8WrmXvWkZNI9ZKzUQtzHwU7TgdjXN7xHgelLPyrVzzn 9wq00QojV9nlPEzJtjmBZ6LN96rPG0EBR4luKlm7846EsvL+ornbhR2PRNPBXvHIKmGk vgdJjCBDB0OTgcaJxR8HOQHN18wX4cCuLztjoYv9ojGxpOKLDopuREzkzMT/t0yGBLNa gZmwNXhXkZZ1cHCyYiI+bO28UZbuWa0facPp44iheN9/tVC/E3NDsLYJJe5kHjImdNHX HVww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701975355; x=1702580155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BojcaTl+dlN3l1hjjhDcQ41U7chb1ovivkDVmYwiv8s=; b=dmkRKNjne3AjQFEAwdvGJqjjVXcNKDB6BZ2zRwQacuOQtXL1A2H1Y0+WTvXUK2h2HG Hkxt9L5LYYFfycQVUAX7dHHRDrie7i2c/bxK/P7b54TNANW9LP12GPAhyMNPdCW5r3G9 mqPD7G5hwAqyfnSe4CNoROw5e8iN1Ijt+bHAxU0hmwB8pUuaPwT9XkjCZy0qewHUAf1V rSNkrYfvrBTrEdw2gI2I4TtvueTjBUpHn9XdDMhzT+xvkBUtKdnK3cgYWTrnTTQkzfE4 rtQ85+Cl/1qA/dV1pY+P3bqWx9ZHIKppHfxqCtQJlPKrjFvtEaH9Vuq+7Bb/FXXYCfjL HZrw== X-Gm-Message-State: AOJu0YxGX4V6uXr2gPXdYGu45Q6rclwa44GOh0qrOlZ6wdyrDx6g4TQH h6lUHW9PS+03LygexF9ings= X-Google-Smtp-Source: AGHT+IHmKUsFRUuw1n/m9tPE9g2GK3cX+CTdzQu/+B8uuUDxiQcmiP1JV//DS+yawJHYkk63d1mKSw== X-Received: by 2002:a17:90b:1648:b0:286:bf9e:a6 with SMTP id il8-20020a17090b164800b00286bf9e00a6mr5859113pjb.4.1701975355486; Thu, 07 Dec 2023 10:55:55 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:492a:db3d:eb42:de92]) by smtp.gmail.com with ESMTPSA id hk13-20020a17090b224d00b0028699a25207sm1723732pjb.12.2023.12.07.10.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 10:55:54 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH 3/3] arm64: dts: imx8mp-tqma8mpql-mba8mpxl: Fix USB connector description Date: Thu, 7 Dec 2023 15:55:43 -0300 Message-Id: <20231207185543.2699697-3-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231207185543.2699697-1-festevam@gmail.com> References: <20231207185543.2699697-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_105556_733036_17726066 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-tqma8mpql-mba8mpxl.dtb: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# Signed-off-by: Fabio Estevam Reviewed-by: Alexander Stein Tested-by: Alexander Stein --- .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 26 ++++++++++++++----- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index 4b161564a284..505b70cb2bd7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts @@ -55,6 +55,21 @@ clk_xtal25: clk-xtal25 { clock-frequency = <25000000>; }; + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "X29"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon0>; + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + fan0: pwm-fan { compatible = "pwm-fan"; pinctrl-names = "default"; @@ -625,13 +640,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - type = "micro"; - label = "X29"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon0>; - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; };