From patchwork Tue Dec 12 02:27:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 13488390 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F179FC4167D for ; Tue, 12 Dec 2023 02:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sOowI7lXobioy3Evs7VyAIVAFuuXKrwfsWFdu3mLKK8=; b=FiqvJWXajuvq2w jCrg6SQTZLSUpfOAjN2fFP86TmohcciQzttrGIFH1y5l936LGZ+y2pJbhe9OgNji269WF2UB5SSbQ bBmgxmapoekPJ3PBRr2uId5Ialxdw5qtNWqSAVbQ551NFFFcVrexj6Uiu3C3heIs8Kg7F4eJt0XSN +M5ugUF2ekqoeFpqZahxEXRcsrX/5WJmkvIr8+oAQjF/4zjBjwFM5J2CB42JtC9R31yA2xRnJ6Bcn RQ6gI7p6HLv8BJ/c8wrfyq6Q3Lgq1JoLiPivp/4WfL1y+xthjZXqz3NHvg+Q0/xMRw+AgBIVqYL4p UDshF6zPUVXhTRitEdqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCsVO-00AWZs-0c; Tue, 12 Dec 2023 02:28:18 +0000 Received: from mail-yw1-x112f.google.com ([2607:f8b0:4864:20::112f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCsVE-00AWQ1-03 for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 02:28:11 +0000 Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-5e1a2253045so6489467b3.2 for ; Mon, 11 Dec 2023 18:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702348086; x=1702952886; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UGJ1SciKtb7P2PBkuK7lu9/Kujw3Tca15jzLy63keqo=; b=kEdvrnAFZGUVLq1QbOmD4JI++XkVBZMmO1LKYOU5PmNG23Dtq1Zk0vts3lxTdXDjgQ b6X1/q273fQTwCtsnMdMRO68k80zlA52PB9GxG+QDuAfAi6XWKfjezqsCX3f2CBJNtKk Ax3g6savOlf9PU73A0rtVR51vl6w0EULOfMqkDBNn6JEK6e68crwLd6aliDm3ISoQ3oH Peo6WWXSWfyCKuq86bijSNPDe3uiGjX75rx6BOMt+RYvUpX0xU6kBzEMBksBvac0zwjU ycAy0B8NFfRrG835ugcBzjEseIgTHcjeHN0gEbefIOJjqJ1lZ1pVDBLbOpAbp6A/582z 8lyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702348086; x=1702952886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UGJ1SciKtb7P2PBkuK7lu9/Kujw3Tca15jzLy63keqo=; b=rCRP0XJG89UwkhlJYRD7GmMjYVhl/OdQL9ahGWBAuRgomGtaBwPGJsZPekmh7zaNpX 9vbd9t5kjyRnfrCvFfUjOuGyogt0Tsmfm9QJRFAj/L8/KCcD02gaGSZa0W1tWPK0YWOo L2tgWlbePqKyNj9Rt8fGRIDr71W6XPA3SExksxdgPS2CYys38Z9H0OALtVLP5vVIIoD/ EYh8c12Zm3vbbE71BgUfZS9385WOPO1HTX7t10wS2kkUGmSm+/Vh2hzCvbdQuM/u31wu qzJy7xRtk+SYQvmC3LlQW4upbgZ7UH58o6omfXzFEB1aiVSke0+QGomlmMERxrCwYEow yfzg== X-Gm-Message-State: AOJu0YxB4c9ndEFWQ/FDc6hxhU6n2yeKimFvd/JaMij6qwb9GQuE1Ts0 0QLW3srEnc0ckbGfj0pQxsA= X-Google-Smtp-Source: AGHT+IEcQE9vIyfnFhCFzm+TBrntNSUln0laqng4P6N0+UfSZTYtWtqpOoUM0PVXePl69yPwn5kBMw== X-Received: by 2002:a81:4fd6:0:b0:5e1:e94c:9e3c with SMTP id d205-20020a814fd6000000b005e1e94c9e3cmr174797ywb.14.1702348086183; Mon, 11 Dec 2023 18:28:06 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:38aa:1c88:df05:9b73]) by smtp.gmail.com with ESMTPSA id u13-20020a81a50d000000b005cc8b377fe9sm3395635ywg.121.2023.12.11.18.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 18:28:05 -0800 (PST) From: Yury Norov To: linux-kernel@vger.kernel.org, Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: Yury Norov , Jan Kara , Mirsad Todorovac , Matthew Wilcox , Rasmus Villemoes , Andy Shevchenko , Maxim Kuvyrkov , Alexey Klimov , Bart Van Assche , Sergey Shtylyov Subject: [PATCH v3 08/35] perf/arm: use atomic find_bit() API Date: Mon, 11 Dec 2023 18:27:22 -0800 Message-Id: <20231212022749.625238-9-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212022749.625238-1-yury.norov@gmail.com> References: <20231212022749.625238-1-yury.norov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_182808_133941_802DCDC8 X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Simplify subsystem by use atomic find_bit() or atomic API where applicable. CC: Will Deacon Signed-off-by: Yury Norov --- drivers/perf/arm-cci.c | 24 ++++++------------------ drivers/perf/arm-ccn.c | 10 ++-------- drivers/perf/arm_dmc620_pmu.c | 9 ++------- drivers/perf/arm_pmuv3.c | 8 ++------ 4 files changed, 12 insertions(+), 39 deletions(-) diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c index 61de861eaf91..cb15b4cee5f7 100644 --- a/drivers/perf/arm-cci.c +++ b/drivers/perf/arm-cci.c @@ -320,12 +320,9 @@ static int cci400_get_event_idx(struct cci_pmu *cci_pmu, return CCI400_PMU_CYCLE_CNTR_IDX; } - for (idx = CCI400_PMU_CNTR0_IDX; idx <= CCI_PMU_CNTR_LAST(cci_pmu); ++idx) - if (!test_and_set_bit(idx, hw->used_mask)) - return idx; - - /* No counters available */ - return -EAGAIN; + idx = find_and_set_next_bit(hw->used_mask, CCI_PMU_CNTR_LAST(cci_pmu) + 1, + CCI400_PMU_CNTR0_IDX); + return idx < CCI_PMU_CNTR_LAST(cci_pmu) + 1 ? idx : -EAGAIN; } static int cci400_validate_hw_event(struct cci_pmu *cci_pmu, unsigned long hw_event) @@ -802,13 +799,8 @@ static int pmu_get_event_idx(struct cci_pmu_hw_events *hw, struct perf_event *ev if (cci_pmu->model->get_event_idx) return cci_pmu->model->get_event_idx(cci_pmu, hw, cci_event); - /* Generic code to find an unused idx from the mask */ - for (idx = 0; idx <= CCI_PMU_CNTR_LAST(cci_pmu); idx++) - if (!test_and_set_bit(idx, hw->used_mask)) - return idx; - - /* No counters available */ - return -EAGAIN; + idx = find_and_set_bit(hw->used_mask, CCI_PMU_CNTR_LAST(cci_pmu) + 1); + return idx < CCI_PMU_CNTR_LAST(cci_pmu) + 1 ? idx : -EAGAIN; } static int pmu_map_event(struct perf_event *event) @@ -861,12 +853,8 @@ static void pmu_free_irq(struct cci_pmu *cci_pmu) { int i; - for (i = 0; i < cci_pmu->nr_irqs; i++) { - if (!test_and_clear_bit(i, &cci_pmu->active_irqs)) - continue; - + for_each_test_and_clear_bit(i, &cci_pmu->active_irqs, cci_pmu->nr_irqs) free_irq(cci_pmu->irqs[i], cci_pmu); - } } static u32 pmu_read_counter(struct perf_event *event) diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c index 728d13d8e98a..d657701b1f23 100644 --- a/drivers/perf/arm-ccn.c +++ b/drivers/perf/arm-ccn.c @@ -589,15 +589,9 @@ static const struct attribute_group *arm_ccn_pmu_attr_groups[] = { static int arm_ccn_pmu_alloc_bit(unsigned long *bitmap, unsigned long size) { - int bit; - - do { - bit = find_first_zero_bit(bitmap, size); - if (bit >= size) - return -EAGAIN; - } while (test_and_set_bit(bit, bitmap)); + int bit = find_and_set_bit(bitmap, size); - return bit; + return bit < size ? bit : -EAGAIN; } /* All RN-I and RN-D nodes have identical PMUs */ diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c index 30cea6859574..e41c84dabc3e 100644 --- a/drivers/perf/arm_dmc620_pmu.c +++ b/drivers/perf/arm_dmc620_pmu.c @@ -303,13 +303,8 @@ static int dmc620_get_event_idx(struct perf_event *event) end_idx = DMC620_PMU_MAX_COUNTERS; } - for (idx = start_idx; idx < end_idx; ++idx) { - if (!test_and_set_bit(idx, dmc620_pmu->used_mask)) - return idx; - } - - /* The counters are all in use. */ - return -EAGAIN; + idx = find_and_set_next_bit(dmc620_pmu->used_mask, end_idx, start_idx); + return idx < end_idx ? idx : -EAGAIN; } static inline diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index 6ca7be05229c..f046ad9e71f1 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -825,13 +825,9 @@ static irqreturn_t armv8pmu_handle_irq(struct arm_pmu *cpu_pmu) static int armv8pmu_get_single_idx(struct pmu_hw_events *cpuc, struct arm_pmu *cpu_pmu) { - int idx; + int idx = find_and_set_next_bit(cpuc->used_mask, cpu_pmu->num_events, ARMV8_IDX_COUNTER0); - for (idx = ARMV8_IDX_COUNTER0; idx < cpu_pmu->num_events; idx++) { - if (!test_and_set_bit(idx, cpuc->used_mask)) - return idx; - } - return -EAGAIN; + return idx < cpu_pmu->num_events ? idx : -EAGAIN; } static int armv8pmu_get_chain_idx(struct pmu_hw_events *cpuc, From patchwork Tue Dec 12 02:27:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 13488389 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58295C4167B for ; Tue, 12 Dec 2023 02:28:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t62fQ26j44P9FWgebRPfzPEhUmZkBYy7N0zDfJbY3eo=; b=JxZUQ5FJfH778+ y4THlby3jF359Jl0iZ44wzbKGttgehIDhMLjJz8Yx0W9yeXmbPZoCJ51R8qy2ERhybXWprfxikgPd GbResv4wHml6maTppcN3f213DN1JoOdt+iSw/AotMepQxQgAxI1iWSbx+WF++6hBWy2ZY2LvLMnBN zvoB55vHlZYhh9aehqXSjcZaXmEI2mu3Ud6p9/PrSyjMBbtaafexkNdIyLK1XCsp0JsTB9R5Zw9jv ENNlGfqyc2hzTvNb1ucsvmfkHVTf5GIVI8Ts5l//Yo3sojFg9es4HVoscUCXSvE2oKegBKHNSuDJn Yh1c3JYrz3P9CcoqbjHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCsVN-00AWYr-0B; Tue, 12 Dec 2023 02:28:17 +0000 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCsVE-00AWRC-17 for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 02:28:10 +0000 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5e1e656d019so1708247b3.1 for ; Mon, 11 Dec 2023 18:28:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702348087; x=1702952887; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wOtgtWtIwGwJ1G9iBa8c13QOAAJ/9MITwOIhxFkc4ng=; b=AaCYffX2rm8r9++709fwh4mu3nCO6lDTR36QYP5mBIycqXAdEpP40rFagpkO81oO8k MJMpJrv7qmX0XZsD5QjWrGkEH9EyloLxdyu1dGNSBqsQif2dL1uUIyzVkep66p7IqsC4 q3Rnd12qozkVLF98NqCdHZnEHJufdcwnQ4RteGTM+YC5d2CJZTBUAhSonh7UG8FeDws/ 5UKlTHaSdJT2ovPtrA6opfeL3uyAiBxOSfm12nDA1Dsos3d7sLeGN7mVjSdNF4ujV3u2 sn8xWPkKGTR8gfIz+C02hwZoiq0Jw0Mvrkdx+7umD3Fg8LEQxAjSzY73nylDvPTpXsEI MHjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702348087; x=1702952887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wOtgtWtIwGwJ1G9iBa8c13QOAAJ/9MITwOIhxFkc4ng=; b=aDQBacpKZ3XnJqsL78i7hJLSowo8pNQni3eeCL4wN8J1n6BZJzYiAhxcGsGJ9T0jxq y91QzFbcVak58IQ8IvssciXSMzr8dVTM4EOTashd66M1nGSxKUzHD3hUbrd+TlnzLqFX 6LLXeJUyskhnEv6yYTBSIDSfEsPw9Ip5eA/rRUqaVDmexHknHw8PIPqoNupVsv7o5E47 9uNQu2vK3YSyMnlYKlGQgKvOEuyJNUcEKyaO/f1qauMmNJWIRX9vcLZ/QhHrdfGde9ss ClQSTfgZGDsMRYE0XBUw13xY4/GgcYxkjgZVqdm6ZL9WQNF/e64Uxbn4Q3SP0wCcoSgc IemQ== X-Gm-Message-State: AOJu0YxLngFt9qZo8AvdutHu6yHGpSC6JXOEA9J9GmExqQTuSRdoBN0e gEAVTFPsxuYYvWh9weOKIsg= X-Google-Smtp-Source: AGHT+IG3JcQqqXUlvmV9E4Jq3lvTw/W0aG3auxyNSagyZtjyoh921YIZwuIwFilGsSDgtbh9RCNWpQ== X-Received: by 2002:a81:7c89:0:b0:5d7:1941:2c2f with SMTP id x131-20020a817c89000000b005d719412c2fmr4754793ywc.92.1702348087359; Mon, 11 Dec 2023 18:28:07 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:38aa:1c88:df05:9b73]) by smtp.gmail.com with ESMTPSA id a200-20020a0dd8d1000000b005d35a952324sm3449101ywe.56.2023.12.11.18.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 18:28:07 -0800 (PST) From: Yury Norov To: linux-kernel@vger.kernel.org, Shuai Xue , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: Yury Norov , Jan Kara , Mirsad Todorovac , Matthew Wilcox , Rasmus Villemoes , Andy Shevchenko , Maxim Kuvyrkov , Alexey Klimov , Bart Van Assche , Sergey Shtylyov Subject: [PATCH v3 09/35] drivers/perf: optimize ali_drw_get_counter_idx() by using find_and_set_bit() Date: Mon, 11 Dec 2023 18:27:23 -0800 Message-Id: <20231212022749.625238-10-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212022749.625238-1-yury.norov@gmail.com> References: <20231212022749.625238-1-yury.norov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_182808_460202_C2C11EF5 X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The function searches used_mask for a set bit in a for-loop bit by bit. Simplify it by using atomic find_and_set_bit(). Signed-off-by: Yury Norov Acked-by: Will Deacon --- drivers/perf/alibaba_uncore_drw_pmu.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c index 19d459a36be5..2a3b7701d568 100644 --- a/drivers/perf/alibaba_uncore_drw_pmu.c +++ b/drivers/perf/alibaba_uncore_drw_pmu.c @@ -274,15 +274,9 @@ static const struct attribute_group *ali_drw_pmu_attr_groups[] = { static int ali_drw_get_counter_idx(struct perf_event *event) { struct ali_drw_pmu *drw_pmu = to_ali_drw_pmu(event->pmu); - int idx; + int idx = find_and_set_bit(drw_pmu->used_mask, ALI_DRW_PMU_COMMON_MAX_COUNTERS); - for (idx = 0; idx < ALI_DRW_PMU_COMMON_MAX_COUNTERS; ++idx) { - if (!test_and_set_bit(idx, drw_pmu->used_mask)) - return idx; - } - - /* The counters are all in use. */ - return -EBUSY; + return idx < ALI_DRW_PMU_COMMON_MAX_COUNTERS ? idx : -EBUSY; } static u64 ali_drw_pmu_read_counter(struct perf_event *event) From patchwork Tue Dec 12 02:27:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 13488391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58363C4167B for ; Tue, 12 Dec 2023 02:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vT5Xq2YWIVG1IBNbVYZOUtXtn0pIsBrEXLugzQVZWAA=; b=J0Rxe1RKSUntM4 ElKbDRVE3vVhj2Svej7/kXQ2E3B7ZD+DNnti/tn4+Q+6cDh0jsdRrlYM6bfkVsdylNspkbetR/fR3 qEU8l30JWuJbNgqW3ywaVovaXtfZXJ+hDjBPgrZjwScD94F3sQ9+EQskyXZ3743g5e/XmgSy8Vw1o oqvekSYohfWyL0TMHx21vVaXAZC6ULXXQExJIeFc9Gcjyt/LoTTxHnTtF+Ji4u4hCh48GSu3Om/v5 GQYoqIbUZHZERNaLbX4v4Ml23kQF7PZ+w8MEq+0FM32O1G/kXs1dnvb5ii2aKJ0VsvrQ6Lg0cE9qh G5GuL1hdX44GAvMVCf3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCsVa-00AWl7-0U; Tue, 12 Dec 2023 02:28:30 +0000 Received: from mail-yw1-x112a.google.com ([2607:f8b0:4864:20::112a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCsVT-00AWdn-11 for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 02:28:24 +0000 Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-5e1a2253045so6491067b3.2 for ; Mon, 11 Dec 2023 18:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702348102; x=1702952902; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GRgDjRdiQ3wMwyUy9FFnN6Mv3fA6CH+t16OZs0Rwzhk=; b=hb8bJzm0YV8Y8NuvxheqHEDnG+9QkW1p9ZE0Re6wT52RjrEQp+/ee865ajAIU7z6GU hD8KkEkjly1mttGHoXHwLvT60CA+rbPItsS6tdWCFTrx2v9IEsnkGa5tkIus33a3n4cZ tguIbp6CEfC6er7cbk7QCb9df2lsuOkt6tIXFfP011G829qoIRZxltAn65Dd7ES2lhqE N25u5aO1uCYCy/6FgORU/7LphLOau9rVaWHv8F/O4KGj3SVsMiQPWctV7Y3s03+THfx9 xBFinr57e+wUSr+gkGg/TTfj8Crg1jWkCRHTup+yIuP/B1x9Hr4y5rXLgIF9LJ22HURo vxcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702348102; x=1702952902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GRgDjRdiQ3wMwyUy9FFnN6Mv3fA6CH+t16OZs0Rwzhk=; b=SdaHmaOSy16FNxHGHSq9ii+4JF7sKbFyPiddTRNrIZtccs4JGG3MYlm/TwYyxpz9gj Mtc2PJYf2ba/Ni27krIpb664RyHXHJYUegveE1O5bVpzwgpaA8mXDqOovEKIlFu6B1fN lDPUfbv8oc+QRT8d7fRBsCuOF2AhN7hylSaAVPLOKfkc/JNV1AC7h6KAcYvIyjGA0Kyl BR4JOPSi9/zcmDAPWfCq6pcporjSnspS2uuDZGKGiPl795+zuI4lgUzGPGDQHU8dk7lF lC/JFzBJ2OMw7aXzxrCgdJaOo9CtSfSDu23L6JepHoyOVOR90q+Lg548k4obgtgSWK3r gehw== X-Gm-Message-State: AOJu0Yz7FlI/v72q470rDrLSJ/lqrcxO7jkDltCsQ6hoFkR5+bgSrVff x00agyh6M/5zTJiiIC3O+xk= X-Google-Smtp-Source: AGHT+IGMwceB9+j1udge1W4cal0kKbCSQgG5Yh316/EdKS360cK7bZCjDy7dckWdtEwCMNE+mk/JJA== X-Received: by 2002:a05:690c:2c0a:b0:5e1:8405:8b3e with SMTP id eo10-20020a05690c2c0a00b005e184058b3emr1116070ywb.44.1702348101890; Mon, 11 Dec 2023 18:28:21 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:38aa:1c88:df05:9b73]) by smtp.gmail.com with ESMTPSA id ff9-20020a05690c320900b005e184771849sm519809ywb.93.2023.12.11.18.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 18:28:21 -0800 (PST) From: Yury Norov To: linux-kernel@vger.kernel.org, Will Deacon , Robin Murphy , Joerg Roedel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Yury Norov , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org Cc: Jan Kara , Mirsad Todorovac , Matthew Wilcox , Rasmus Villemoes , Andy Shevchenko , Maxim Kuvyrkov , Alexey Klimov , Bart Van Assche , Sergey Shtylyov Subject: [PATCH v3 19/35] iommu: optimize subsystem by using atomic find_bit() API Date: Mon, 11 Dec 2023 18:27:33 -0800 Message-Id: <20231212022749.625238-20-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212022749.625238-1-yury.norov@gmail.com> References: <20231212022749.625238-1-yury.norov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_182823_390900_42194A1B X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Simplify __arm_smmu_alloc_bitmap() and msm_iommu_alloc_ctx() by using a dedicated API, and make them nice one-liner wrappers. While here, refactor msm_iommu_attach_dev() and msm_iommu_alloc_ctx() so that error codes don't mismatch. Signed-off-by: Yury Norov --- drivers/iommu/arm/arm-smmu/arm-smmu.h | 10 ++-------- drivers/iommu/msm_iommu.c | 18 ++++-------------- 2 files changed, 6 insertions(+), 22 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.h b/drivers/iommu/arm/arm-smmu/arm-smmu.h index 703fd5817ec1..004a4704ebf1 100644 --- a/drivers/iommu/arm/arm-smmu/arm-smmu.h +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.h @@ -453,15 +453,9 @@ struct arm_smmu_impl { static inline int __arm_smmu_alloc_bitmap(unsigned long *map, int start, int end) { - int idx; + int idx = find_and_set_next_bit(map, end, start); - do { - idx = find_next_zero_bit(map, end, start); - if (idx == end) - return -ENOSPC; - } while (test_and_set_bit(idx, map)); - - return idx; + return idx < end ? idx : -ENOSPC; } static inline void __iomem *arm_smmu_page(struct arm_smmu_device *smmu, int n) diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c index f86af9815d6f..67124f4228b1 100644 --- a/drivers/iommu/msm_iommu.c +++ b/drivers/iommu/msm_iommu.c @@ -185,17 +185,9 @@ static const struct iommu_flush_ops msm_iommu_flush_ops = { .tlb_add_page = __flush_iotlb_page, }; -static int msm_iommu_alloc_ctx(unsigned long *map, int start, int end) +static int msm_iommu_alloc_ctx(struct msm_iommu_dev *iommu) { - int idx; - - do { - idx = find_next_zero_bit(map, end, start); - if (idx == end) - return -ENOSPC; - } while (test_and_set_bit(idx, map)); - - return idx; + return find_and_set_bit(iommu->context_map, iommu->ncb); } static void msm_iommu_free_ctx(unsigned long *map, int idx) @@ -418,10 +410,8 @@ static int msm_iommu_attach_dev(struct iommu_domain *domain, struct device *dev) ret = -EEXIST; goto fail; } - master->num = - msm_iommu_alloc_ctx(iommu->context_map, - 0, iommu->ncb); - if (IS_ERR_VALUE(master->num)) { + master->num = msm_iommu_alloc_ctx(iommu); + if (master->num >= iommu->ncb) { ret = -ENODEV; goto fail; }