From patchwork Tue Dec 12 17:34:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neeraj upadhyay X-Patchwork-Id: 13489731 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lHWQAdTX" Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 894FF8E; Tue, 12 Dec 2023 09:34:25 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-28abd1ecb85so602476a91.0; Tue, 12 Dec 2023 09:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702402464; x=1703007264; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kOjHx9AciPI0bIXgcXZ7IgsUeZnP8qbNbJ9CPNPXPQE=; b=lHWQAdTXFMDmV/UPQDigQ/B08OhulArDOg8M+HDT7yHh7mIp/ksVoYLE8jYPITDQza J8lWRrDDn4ezQdvsm49m1eaYNe+PO+HOdAXmnJHFDl/yvwkjBl8QGeOQurUNfkA6zEKw 7A+lB/xA1EquCDk7wKtVLVCWGYAxy6K9Z9tT/B8550VQF2zwH/lSAUgK1Sjl4p8bxMy0 tsmAYgTH5YlxFCvzW+pS3nmxlEaqPcO02IQsRoYgtjHsWCaqra97vBgTdppH25VKvxfp At1ylBOnSUAiDbTKAeSMDkrDpCoD/66dTFU7dP1pw0dsnhesk70wgIyE33tTvPCY/xj+ QlOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702402464; x=1703007264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kOjHx9AciPI0bIXgcXZ7IgsUeZnP8qbNbJ9CPNPXPQE=; b=Ol9FjyM4DgdpixGtRzFBXEvCC3GcebbpL/tS4ueNCHtKUKqL07bZXIoea3AWDpgSq5 P+gwanrpm6Nev4xFeVaFlwDj6OgBXUei5QQ+UhCK2m23ECIHgveo5fdDwz6dfZIFkbOV 13YrD1ght5ucZRyjVLs+JSBneXUxShIaXLli/N1zhOn97TbCiwTAdog/cmWfPLSyIx+u EgJ5onp6eGKl1qEMT8PWcYYrI0W/vh2AAPkCrNw7CXB/bYBYQ2gKHJKdU9Vy4JkiYpKr Ej3Cw5wwwFbXTqA2RcGvWLkVPnm6zKPh5bI6EWREDgqosPi/Db/pB1j4+nIVdBKMBW8C Gmyg== X-Gm-Message-State: AOJu0YxbQjYw5cgnMVgO4bg2S3Nzy6e7XPU3Xp1lX8C8E1IG8RDe0mfU NZMrXEIdsIDe1yHnAfasuDx1u8l+w5qRGifM X-Google-Smtp-Source: AGHT+IE4wTs42pptzmoD3ldD3SBz8bD8IWZocjwoJa+8yqUeJ3f9fVmRfb++MOlvMkmXmtizjwyDVg== X-Received: by 2002:a17:90b:b14:b0:286:c399:7c16 with SMTP id bf20-20020a17090b0b1400b00286c3997c16mr3097304pjb.44.1702402463875; Tue, 12 Dec 2023 09:34:23 -0800 (PST) Received: from localhost.localdomain ([101.0.63.152]) by smtp.gmail.com with ESMTPSA id nc4-20020a17090b37c400b00285545ac9d2sm9213862pjb.47.2023.12.12.09.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:34:23 -0800 (PST) From: "Neeraj Upadhyay (AMD)" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, paulmck@kernel.org, Neeraj.Upadhyay@amd.com, Dan Carpenter , Neeraj Upadhyay Subject: [PATCH rcu 1/4] locktorture: Increase Hamming distance between call_rcu_chain and rcu_call_chains Date: Tue, 12 Dec 2023 23:04:11 +0530 Message-Id: <20231212173414.11602-1-neeraj.iitr10@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212173334.GA11572@neeraj.linux> References: <20231212173334.GA11572@neeraj.linux> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Paul E. McKenney" One letter difference is really not enough, so this commit changes call_rcu_chain to call_rcu_chain_list. Reported-by: Dan Carpenter Signed-off-by: Paul E. McKenney Signed-off-by: Neeraj Upadhyay (AMD) --- kernel/locking/locktorture.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c index 69d3cd2cfc3b..415d81e6ce70 100644 --- a/kernel/locking/locktorture.c +++ b/kernel/locking/locktorture.c @@ -124,7 +124,7 @@ struct call_rcu_chain { struct rcu_head crc_rh; bool crc_stop; }; -struct call_rcu_chain *call_rcu_chain; +struct call_rcu_chain *call_rcu_chain_list; /* Forward reference. */ static void lock_torture_cleanup(void); @@ -1074,12 +1074,12 @@ static int call_rcu_chain_init(void) if (call_rcu_chains <= 0) return 0; - call_rcu_chain = kcalloc(call_rcu_chains, sizeof(*call_rcu_chain), GFP_KERNEL); - if (!call_rcu_chain) + call_rcu_chain_list = kcalloc(call_rcu_chains, sizeof(*call_rcu_chain_list), GFP_KERNEL); + if (!call_rcu_chain_list) return -ENOMEM; for (i = 0; i < call_rcu_chains; i++) { - call_rcu_chain[i].crc_stop = false; - call_rcu(&call_rcu_chain[i].crc_rh, call_rcu_chain_cb); + call_rcu_chain_list[i].crc_stop = false; + call_rcu(&call_rcu_chain_list[i].crc_rh, call_rcu_chain_cb); } return 0; } @@ -1089,13 +1089,13 @@ static void call_rcu_chain_cleanup(void) { int i; - if (!call_rcu_chain) + if (!call_rcu_chain_list) return; for (i = 0; i < call_rcu_chains; i++) - smp_store_release(&call_rcu_chain[i].crc_stop, true); + smp_store_release(&call_rcu_chain_list[i].crc_stop, true); rcu_barrier(); - kfree(call_rcu_chain); - call_rcu_chain = NULL; + kfree(call_rcu_chain_list); + call_rcu_chain_list = NULL; } static void lock_torture_cleanup(void) From patchwork Tue Dec 12 17:34:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Neeraj upadhyay X-Patchwork-Id: 13489732 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A8NqHMCk" Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9081BE3; Tue, 12 Dec 2023 09:34:32 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso4851481a12.3; Tue, 12 Dec 2023 09:34:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702402471; x=1703007271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U7WPnTXwcd9ZzcvpmJ6cfpBxVRJlaEYkuDj4m5TKSZY=; b=A8NqHMCkM+oLrxx1u2ACtPDJ1Mlo3p6cF24tlvsX83FHvgbRnSuNaLW0L9TyAlW0ii JhzbVrSrxzqs2Pg+HPlm6okgifwT6421Kx0V74FKZWFUINqxO1LVk69R5aXMZyZowZC1 LvF26omnNoZb/m2hB+BSuuNRdhNxUG7ewgwk7MUEYBGrRmW9AdeYyuo/LLnzVzAGwydK emVCIOPIcxP89vqNDMlcD9P/tLXxF6sWSAY18oY1V7sp1zuNKT2JRjnr+qeaX3FLOoQH Bpi4GF3u/FNM3QTpvSyFrioqShY3KqzyOdMJyPpc+P605/fvxOa65oSxSEVRqRgR3QBA 2iiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702402471; x=1703007271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U7WPnTXwcd9ZzcvpmJ6cfpBxVRJlaEYkuDj4m5TKSZY=; b=mxYsWHvBLwP5HLePVIaoMm6xCJ/T2sWVXMeff8w6ECJ9reFnT/MFtB9XjA6JJV+8Yx ig4fdKxuuDy6BFNODt31K/Uc7CvR0rlepv32lI8V7i9o/W4hlqi+aGzGyEbxZNNZRG9N JMIOyxOb0ec9JoafTHxLggZ7FHaVA048LIuB3Yaf/o/K5j6Qvzlb3QwrgLWCxM0coCWc uKUUEwiJq6wOGRJcYj7Ii1heUUfEMgMTcSlyfHgyrXbFc/dCeFEZ/ZPd8yncNUzDY+R3 b0wO0nNep1EYAz8stOEmW7sC3fbnLnOd3z5taOfOoZmxD5y09AuwqRBqdCFax/6F1tzn 7vEA== X-Gm-Message-State: AOJu0YyoURuxhHE259YivMCAEW4qv+4Hb89W6XOXOEqenCGvsPNuJNti NT8NsBPMT1iWMhW9+2tWjXlxGD35/w3gUFre X-Google-Smtp-Source: AGHT+IHUtxJgDQUDQl+GLeIkzxxRnkvxeDT917Z0smPcbhO/8giuU84BrdU+h8qclux8NObObKkCrg== X-Received: by 2002:a17:90b:11c8:b0:286:6cc0:cabb with SMTP id gv8-20020a17090b11c800b002866cc0cabbmr5231012pjb.50.1702402471068; Tue, 12 Dec 2023 09:34:31 -0800 (PST) Received: from localhost.localdomain ([101.0.63.152]) by smtp.gmail.com with ESMTPSA id nc4-20020a17090b37c400b00285545ac9d2sm9213862pjb.47.2023.12.12.09.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:34:30 -0800 (PST) From: "Neeraj Upadhyay (AMD)" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, paulmck@kernel.org, Neeraj.Upadhyay@amd.com, =?utf-8?q?Thomas_Wei=C3=9Fschu?= =?utf-8?q?h?= , Neeraj Upadhyay Subject: [PATCH rcu 2/4] rcutorture: add nolibc init support for mips, ppc and rv64 Date: Tue, 12 Dec 2023 23:04:12 +0530 Message-Id: <20231212173414.11602-2-neeraj.iitr10@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212173334.GA11572@neeraj.linux> References: <20231212173334.GA11572@neeraj.linux> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Thomas Weißschuh Use nolibc for all support architectures. Signed-off-by: Thomas Weißschuh Signed-off-by: Paul E. McKenney Signed-off-by: Neeraj Upadhyay (AMD) --- tools/testing/selftests/rcutorture/bin/mkinitrd.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/rcutorture/bin/mkinitrd.sh b/tools/testing/selftests/rcutorture/bin/mkinitrd.sh index 212c52ca90b5..f3f867129560 100755 --- a/tools/testing/selftests/rcutorture/bin/mkinitrd.sh +++ b/tools/testing/selftests/rcutorture/bin/mkinitrd.sh @@ -67,7 +67,10 @@ ___EOF___ # build using nolibc on supported archs (smaller executable) and fall # back to regular glibc on other ones. if echo -e "#if __x86_64__||__i386__||__i486__||__i586__||__i686__" \ - "||__ARM_EABI__||__aarch64__||__s390x__||__loongarch__\nyes\n#endif" \ + "||__ARM_EABI__||__aarch64__||(__mips__ && _ABIO32)" \ + "||__powerpc__||(__riscv && __riscv_xlen == 64)" \ + "||__s390x__||__loongarch__" \ + "\nyes\n#endif" \ | ${CROSS_COMPILE}gcc -E -nostdlib -xc - \ | grep -q '^yes'; then # architecture supported by nolibc From patchwork Tue Dec 12 17:34:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neeraj upadhyay X-Patchwork-Id: 13489733 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DlavEJZG" Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2920CB9; Tue, 12 Dec 2023 09:34:37 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-28ac11407cfso360952a91.1; Tue, 12 Dec 2023 09:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702402475; x=1703007275; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iw+CIAg8alL2TfLLUR0OkhwDoqn5kHDhii4hhgbuJek=; b=DlavEJZGBXl+5cmGgQwEmIbxX3ePKQdO3tVf57LJ3ea6fpNAsL0uxMoBj0x/6JuVON IAFaw6Obb553wk4DkVLxVM2/Z3u2+dWQVC3gbvs8Od5Ng3clkQX0RUXmYyy56hv5A2kH LxbImWu9cXjKxj2OCoqpVgAVIyTWZVMliqbGzMjD5962ZmTfjQiQzAx6QkIqIOe047zT lwNFe++RtlMFaaawzqgjN8jZOtFH+/F8OUIEMqDYk5NS5AKWf9FswTyjnW7clLFDM49N eyucsIMCYaJ5Cqpuh1EI0CQ4yZC0H4rfHz24CLMslbhG/9pjzxaVRSwmiNuSkKMkcFYW JPSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702402475; x=1703007275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iw+CIAg8alL2TfLLUR0OkhwDoqn5kHDhii4hhgbuJek=; b=lcbk5Um76aqpLyEVKqaY4AOORtdJ3fhdQDrx3uO1x82rbxg1SlB2C2HibfJspQrM0Q 9o8Yy+Kw8OihtJwnStsmIPK3yNR6Bxu3jOPjSEIr2pcGsv6xBqlk29ryJPG9BFjFwmqE t1pSFj0PFe0cb65iCGrDIPj/Y8F253pJo6uE56Lr2KrpdlNuTHr3/Uf2VkYzXSmYlYeo w9KFaiTTN2mDRBUql4ITzqBtBUZBYdL/+JGln6Ug8CiKw/6Hd6ql3Wtrs2+ZF16CxMTu RK3OO3LH2UxEsBFj6LofEGhTr6JZYMBA9SMKAGo8J38O+kYTe93BO9VXPOK7xdSUl38o mx8A== X-Gm-Message-State: AOJu0YxoC/i5CMRrpRdR1VnbXviX5fp0/8kbYC4zwdooDDCAxupCcrcf Z/B8Hjnr0ApnD3AhGeIh7lC8+QDgC8CVyOsx X-Google-Smtp-Source: AGHT+IHdSW8OwThXU0yHzXVEdO4UM7Avlxx8V/jJBruEaZYEjcx6lbfWkqXbvpFhgg4PBpvW+oFCQQ== X-Received: by 2002:a17:90a:3ec1:b0:280:24c7:509 with SMTP id k59-20020a17090a3ec100b0028024c70509mr2932704pjc.46.1702402474615; Tue, 12 Dec 2023 09:34:34 -0800 (PST) Received: from localhost.localdomain ([101.0.63.152]) by smtp.gmail.com with ESMTPSA id nc4-20020a17090b37c400b00285545ac9d2sm9213862pjb.47.2023.12.12.09.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:34:34 -0800 (PST) From: "Neeraj Upadhyay (AMD)" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, paulmck@kernel.org, Neeraj.Upadhyay@amd.com, Neeraj Upadhyay Subject: [PATCH rcu 3/4] rcutorture: Add mid-sized stall to TREE07 Date: Tue, 12 Dec 2023 23:04:13 +0530 Message-Id: <20231212173414.11602-3-neeraj.iitr10@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212173334.GA11572@neeraj.linux> References: <20231212173334.GA11572@neeraj.linux> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Paul E. McKenney" There is code in rcu_implicit_dynticks_qs() that checks for the current grace period being halfway to the RCU CPU stall timeout, but rcutorture currently does not test this code. This commit therefore adds a 14-second stall to the TREE07 scenario in order to test this code given the default RCU CPU stall warning timeout of 21 seconds. Signed-off-by: Paul E. McKenney Signed-off-by: Neeraj Upadhyay (AMD) --- tools/testing/selftests/rcutorture/configs/rcu/TREE07.boot | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE07.boot b/tools/testing/selftests/rcutorture/configs/rcu/TREE07.boot index d44609937503..979edbf4c820 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/TREE07.boot +++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE07.boot @@ -1 +1,4 @@ nohz_full=2-9 +rcutorture.stall_cpu=14 +rcutorture.stall_cpu_holdoff=90 +rcutorture.fwd_progress=0 From patchwork Tue Dec 12 17:34:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neeraj upadhyay X-Patchwork-Id: 13489734 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C2efV6wn" Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2302CF; Tue, 12 Dec 2023 09:34:39 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5bdb0be3591so4932404a12.2; Tue, 12 Dec 2023 09:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702402479; x=1703007279; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LjqNPmTsqEqqrVWfas3u5VADPjrH7KEM9DoAzSldHo8=; b=C2efV6wnQoeNuG1XKhWn2EH7YE8h3aRgl0xJBF4kyooXrLhdy2PlNb+G+Jm2GRlJWK hmwtgBLvJgKYQ0csInWxFSh0nl77YYQ2uttXKsCjvUJruJG/CZQlLMxBKGp+fRO7qWJZ bztBfZqlK4RRejx5+/ricNkNK6sq0gka1j9emqOQ3AgGQZJD/+jqDmofRBNsVA/A39rX 2rJLbQ1Vr2wnwS/7YfVSEXV4t6dnQijanazZJJM3w0HxIKCgfqbUkYilN7TD3eyVOsda HXeaUrAYZBpujWINircmBTHZkNIN9zpgROgy6MF9Hc5iQdgTLLGJvhUi8rDUcr8AWVMa pBxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702402479; x=1703007279; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LjqNPmTsqEqqrVWfas3u5VADPjrH7KEM9DoAzSldHo8=; b=QP/PsPXD3S/a4mPZ943bXuMeoWJrmNJQ+r/8VMRKtuAaYv/tnR6RSS9Q1Ccp06m/AB KifxfFhHS6P8mCpCxzfsTzI0NqCNCk4mcd7tEDu7XBrzbxbPXCzOJ4AkIg9C4/n0msBZ kXJsYzq9RZLTLPFJJd10cIQQKAEgE1dO3ilDMyl49uytY92ppCT/sc4iEdBN6HhxXVSC twuLXsLBpNAaRdgF4FiggsLDEP1BRqjw82i8OGDi1T9fTWEH4qLpvTshu4FHTqZ0M/pr fV4er5VNHqPsOxmUOQ2q/Auwd4E2oKoKavYaW23AGhdj8ImJ3YN+vOzXsAwJV3wTV+TE Wjcw== X-Gm-Message-State: AOJu0YwTQnq0BxjSFgIgyorOVTrQlCgNxzmYH6z8lQJTniMMea4AZC8R u7Rn2pFrXfexWHVpFltem2t5O/uNTB2331NG X-Google-Smtp-Source: AGHT+IGPcGz2GH8gwSM0o4jUtojz2k0rG0D390xUpeft6LaUWb2w/7moy+DHRW/sVfpXmxn2uNBtDg== X-Received: by 2002:a17:90b:1e07:b0:286:6cc1:3f25 with SMTP id pg7-20020a17090b1e0700b002866cc13f25mr5109756pjb.92.1702402478556; Tue, 12 Dec 2023 09:34:38 -0800 (PST) Received: from localhost.localdomain ([101.0.63.152]) by smtp.gmail.com with ESMTPSA id nc4-20020a17090b37c400b00285545ac9d2sm9213862pjb.47.2023.12.12.09.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 09:34:38 -0800 (PST) From: "Neeraj Upadhyay (AMD)" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, paulmck@kernel.org, Neeraj.Upadhyay@amd.com, Zqiang , Neeraj Upadhyay Subject: [PATCH rcu 4/4] rcutorture: Add fqs_holdoff check before fqs_task is created Date: Tue, 12 Dec 2023 23:04:14 +0530 Message-Id: <20231212173414.11602-4-neeraj.iitr10@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231212173334.GA11572@neeraj.linux> References: <20231212173334.GA11572@neeraj.linux> Precedence: bulk X-Mailing-List: rcu@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Zqiang For rcutorture tests on RCU implementations that support force-quiescent-state operations and that set the fqs_duration module parameter greater than zero, the fqs_task kthread will be created. However, if the fqs_holdoff module parameter is not set, then its default value of zero will cause fqs_task enter a long-term busy loop until stopped by kthread_stop(). This commit therefore adds a fqs_holdoff check before the fqs_task is created, making sure that whenever the fqs_task is created, the fqs_holdoff will be greater than zero. Signed-off-by: Zqiang Signed-off-by: Paul E. McKenney Signed-off-by: Neeraj Upadhyay (AMD) --- kernel/rcu/rcutorture.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 30fc9d34e329..a0b2520bd32b 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -3872,7 +3872,9 @@ rcu_torture_init(void) } if (fqs_duration < 0) fqs_duration = 0; - if (fqs_duration) { + if (fqs_holdoff < 0) + fqs_holdoff = 0; + if (fqs_duration && fqs_holdoff) { /* Create the fqs thread */ firsterr = torture_create_kthread(rcu_torture_fqs, NULL, fqs_task);