From patchwork Wed Dec 13 21:18:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13491883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EF62C4332F for ; Wed, 13 Dec 2023 21:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=sMEG6YVQfFHwIL4tOrQIGprVRXGn/QCJgRWxDd8G+y0=; b=eanuQbptfEbsgN QW3GZli8ThaqNt0/gXKJE/A9mkJ7zkxCTi9ALV0NVnEn3Xz3RaWeIV9CHSrlop1gQn9TgoQUwISeF ZpgFwxHujQsp5qr3E+L/zM2RBHIwBT59n/uuOfdjcMj9X5MLzKIMjridPa8Bb3h2Xla/2vlfWw/7/ v5NB5RAWG7wBCWWJ0FlwsZYR2PzPwKw2cecgeS5MRnhYaZmuFYJ4+/fWucVH9iIFtQroplT5fk0on a7I2l0JGHwe+YgM9NL/b0rKZHhDNwnTmCPsrHW3IkQyBAzLPlMrfY8DfDpgUMa8DbKpyxmz6N1Ap0 pvVGs5TfmY2W11UK2vBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDWdD-00G2ca-0K; Wed, 13 Dec 2023 21:19:03 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDWd9-00G2bx-2J for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 21:19:01 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-58962bf3f89so599471a12.0 for ; Wed, 13 Dec 2023 13:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702502336; x=1703107136; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x4h/T+9Kq9l0CDJcSfDl00S/lS0ziGHTuKV2XRv/UXQ=; b=MR9yhb/iInlz5bjoCfi0/6dQo9WHcC2NQHpvEen+3UnCSkS/FbE/TYfozKYZlmfbCp jPzhyKM2XVzrpvkZr3MEO1f2Msvl0YzHSYRmX14tuudGUlJA/5mEUqIlIK2FAGDBPGGD dtiDd7jCaEjIIlnYp0TEiqHZn/Ah8KLJlYOE9V29KZZO03ZwMaIf7MT3F60WA4/I1wlI /GmoXhE1Vnaj+tWuPju4jdpH3GRu2tVW6Iu+BghkMkTDJG0b1wp/5YcAz/eH1QzR6iiH oQSdfIqUUHnEkkbIUaZp92r0zN0n+oBbR7P5rFIyJJr+I/As3SwjPKFrvbe/qMPtdnwX /Q9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702502336; x=1703107136; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x4h/T+9Kq9l0CDJcSfDl00S/lS0ziGHTuKV2XRv/UXQ=; b=LtDotraRBalvPGAJNAzqRttATVDe9Qa2KlJghpOzueVW4VXvLUgrWuJZjSntAk7AbP 5SsZKsbleJ/KHRkqABwvtjz3OJAMw3cM+pRTtEebutUbhaYtwG0X1F+CJhJkgA0loqLY x1RO8MPaAH7UL0Lpn6WfF2PUKY4XbVJ+r/YBbtkKvNJid4a+HWt16MfRTML4J2jTML7u rkOwYNdjrmeYeOUibHqJ6D+DG5k18en9zSfuesT+bCN9cBSvtx8VLbXPjQMRN9nPLk/2 76ChC9zriv32eI66WFRizpUB8DpV5Ce11O5c7OLhstNrmrfaaovOKUTIChWYZV2K1+Dq TRiQ== X-Gm-Message-State: AOJu0YweAMuVCX9Dhn69f/j/cTxPxs48srJ779K+CDyFC+8TFhnVXUPD OowugyIUAP8cgyarJiRd0/Q= X-Google-Smtp-Source: AGHT+IFFiyRXJ7OQHYwpO5hG1+Wzoi8bytB9ONGIJx5BE44dwZjxHOV85JmSEuQr9O0RT6U2znXqiQ== X-Received: by 2002:a17:90b:1055:b0:28a:f2f2:331f with SMTP id gq21-20020a17090b105500b0028af2f2331fmr1821144pjb.4.1702502336280; Wed, 13 Dec 2023 13:18:56 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:a61c:8373:8743:d180]) by smtp.gmail.com with ESMTPSA id j15-20020a170903024f00b001d0b080c7e6sm10957310plh.208.2023.12.13.13.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 13:18:55 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH v2 1/3] arm64: dts: imx8mp-verdin: Fix USB connector description Date: Wed, 13 Dec 2023 18:18:45 -0300 Message-Id: <20231213211847.1096033-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_131859_756143_B5BA1683 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-verdin-wifi-mallow.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml# Signed-off-by: Fabio Estevam --- Changes since v1: - None .../boot/dts/freescale/imx8mp-verdin.dtsi | 30 +++++++++++++------ 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi index 04f2083c4ab2..c3305f0d4001 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi @@ -45,6 +45,23 @@ backlight_mezzanine: backlight-mezzanine { status = "disabled"; }; + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + id-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; + label = "Type-C"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb_1_id>; + self-powered; + type = "micro"; + vbus-supply = <®_usb1_vbus>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + gpio-keys { compatible = "gpio-keys"; pinctrl-names = "default"; @@ -835,15 +852,10 @@ &usb_dwc3_0 { srp-disable; usb-role-switch; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - id-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; - label = "Type-C"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usb_1_id>; - self-powered; - type = "micro"; - vbus-supply = <®_usb1_vbus>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; From patchwork Wed Dec 13 21:18:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13491885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35733C4332F for ; Wed, 13 Dec 2023 21:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gJVL32Vq6uItYaRhBcO6hIuBfy2kOEyVBdLpxR6Wvxw=; b=N+NzJ4+vvEUooj 3QAZNRZ2yFAcaK14gihIARkemQtUaQJ50eq0pN8mCzcPf3WUWDQ7aeE0PtQbahQdWwj0wDjjacSZs gM/rjalO3Y8IgdRyJfXZMx0IAh7rEqeHVdo2WIe4pMd7OmhjC54/9bt+KgYljO9Rgr9o36AoXWO/W q88B/fz+j+P+hITV/XtU94fWJLylIVo3qUkJgPvjijfP3pKQWCNK+aPUGJMq/oXA4upQAY0zp+ujs W/q8ycP93HHBthMJn1vEQKbws6p0pfrEZOkDRD4VP6iGVSaHYfuhmbdQPITCjf/XsGYyRi0new/QL eY5qkEi4z1XNso/u2KGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDWdI-00G2dN-2e; Wed, 13 Dec 2023 21:19:08 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDWdB-00G2c0-2K for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 21:19:03 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5c67fdbe7d4so1067263a12.0 for ; Wed, 13 Dec 2023 13:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702502339; x=1703107139; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jQW63/FoQmulr1Lm6mD+QofbEapeexg5XilPGXLeaWM=; b=mCu2YhhkHjgZdwfjIvLr7KRuGVXPv88Q78O7a6BF9hTKmKHmDVi6dCHOXSQD39nwOI CTcel562GXLeXe8r8K8W3a0aGXEWLbDYioWVuLkXVZuXnR6s+9sQR7yRJh0uQRf39IVD NhmBUPO7fqvj7Z3VSBK3Bb+PNIL/DtXriCh5bNm6rS/YZe66n28CQGDmbdIfV60cNday ipzP68G5t5TRvz0cMcYgEOFs5cyLLl25OceJDnEwYCeDh2HXV/uw0i3xN8RkzRsRapA5 T6sYBnOoZ/o5yX53un6ZNFZalXSRS/HM/K7BVuFGjax9LHgBJbkY5PjJPRhifdj88PFD HTEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702502339; x=1703107139; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jQW63/FoQmulr1Lm6mD+QofbEapeexg5XilPGXLeaWM=; b=QyO8vso5ovF2tMBab2L2EcU06BxVR9HxX8fMZUCrj3cUvTvskrahoveZkKr+Mgo5Il zxn30b5Cd6QVD2va7wnOg98yN8pZVjKZzN3llIvKZjx7tOkjvUEMGHTK2/T4GhGj5XAU m5lIYqcAgFYTzXXQGe9Z0jPoj8IRuPal8eUu8xredMnVeB+VXwsrm//oc+trZPnLzezz DJHU+6Z7asGcsyWrBtjwv8OmlGhl5QIk7+tuQrVzxUUSnOVlbATCibRYBBXA5cRqspxW dDHwlgm9rRhJktBxe+Y5cynIdDcXanksbthhkDOOsHixWwV1f5vdlrIj53eHBbIK8Ubs ErQA== X-Gm-Message-State: AOJu0YzBGEnzDhyciITrzlowPRlzdBNPgOACZ8AWM4pn0+iRnA/Ypo4i uennyBrZmIN7sHQWA5QjQ/Y= X-Google-Smtp-Source: AGHT+IGo3kiYDgv/6q6u3ANWXf/4Thd2lkAnfQMJq8elWiIIbJIM9sL5reWouMDymE7Uo1BCZjqJ6Q== X-Received: by 2002:a17:902:ab0e:b0:1d3:6255:6c8c with SMTP id ik14-20020a170902ab0e00b001d362556c8cmr1156693plb.2.1702502338672; Wed, 13 Dec 2023 13:18:58 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:a61c:8373:8743:d180]) by smtp.gmail.com with ESMTPSA id j15-20020a170903024f00b001d0b080c7e6sm10957310plh.208.2023.12.13.13.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 13:18:58 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH v2 2/3] arm64: dts: imx8mp-venice: Fix USB connector description Date: Wed, 13 Dec 2023 18:18:46 -0300 Message-Id: <20231213211847.1096033-2-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231213211847.1096033-1-festevam@gmail.com> References: <20231213211847.1096033-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_131901_759381_E6716019 X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-venice-gw72xx-2x.dtb: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# Signed-off-by: Fabio Estevam Acked-by: Tim Harvey --- Changes since v1: - Removed blank lines. (Tim) - Collected Tim's ACK. .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 26 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw72xx.dtsi | 26 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw73xx.dtsi | 26 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw74xx.dts | 26 ++++++++++++++----- 4 files changed, 76 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi index bf47b5e9dd8c..0e8d0f3c7ea8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -132,13 +147,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi index 28eb7c00a1d9..c24587c895e1 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -182,13 +197,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi index b0d42b18c5ce..628ffba69862 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -201,13 +216,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts index dcf9bababffc..9caf7ca25444 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts @@ -35,6 +35,21 @@ memory@40000000 { reg = <0x0 0x40000000 0 0x80000000>; }; + connector { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -692,13 +707,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - compatible = "gpio-usb-b-connector", "usb-b-connector"; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; From patchwork Wed Dec 13 21:18:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13491884 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2134C4167B for ; Wed, 13 Dec 2023 21:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EQRUpzAMFgiTileGz6TXKJewnuAQzJL+3+Gci4RM8n4=; b=Bzme/BO9CVMCZ6 115gf0Po+z0WIPTW8WqaKAQyKoGLJVs6XJmyKU0qe4kW90DkB25F+lKzmRgBjjPVtbdk3PZzEaxZO gV68enzGtsVDGemoLSAFh7faUxFTZvTRZGNiLiUvqtMJMB0oSigq3JAj4k/QVqYpM2eHumNGeZwgo NZJZR0XzP4JDH4kW63yIS+U7oI9R+SttVS/zAvp6eM8HzVDeaJI/577EfgFmoXuBO7Q9TMgFXIGZ/ AVyuyg47Z+UhVcKUrO/HwQ+RmS0vEEZydVsKWszzRvuW98HNr+AY5bI+bCDEXp17NL2AIsKnCVbqQ pTbg5zrOpPx1rHG9hUqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDWdJ-00G2de-19; Wed, 13 Dec 2023 21:19:09 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDWdD-00G2cL-0X for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 21:19:04 +0000 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-55b5a37acb6so1218890a12.0 for ; Wed, 13 Dec 2023 13:19:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702502341; x=1703107141; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UJs/JYA5kTmsUjzLP8xXNyg1oi28f2O+ki0O3+nNRNE=; b=U5cSu5W5btHPIXcrRpurfcnYoB1Zf2mQ9aP4f1Tq3Y2FMAlCZVF0kNhtgtvNZz/HMv lJcCavBOoGy//TtzbkBBKTA/gSp2XEYsFRrQzUl67GHmNoerXv1TWt0iOWEChh9FRogD h+w2I55SOjarn2c8QFx3GD8hgugLVdaDGi4AwCGrE0g6gfDuhbn1chdFQ0bnSWJadUFx oh4PasOlxtWbV9HbKBi/5OLwkBu5PrZTRKhS4tQgdqBe1RchL42SKc7lbiR0DKrYSdTV MKPGJEGuyvXEYwPwLHyzXsB8TjHAlXWBtYAFFld6nlVs/iTzTC6moGDKw9OWvH8scAji f0Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702502341; x=1703107141; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UJs/JYA5kTmsUjzLP8xXNyg1oi28f2O+ki0O3+nNRNE=; b=N0U/MwYAcu51AtEZb46G81UQmzT9279gexVWpS3kSNDNirslbgjNT64JHsE5owtsf6 E0sSDU2O3i/sQoBbrQHrR5q+cAUiszhWFkxvty2NO/SbDOn7xMlkoicwbj0ncY4FB2Pa fOdQXuNRCdiZk5/g//TCL53w1l4NqVh5h3BCcfUr3q/jgLPJ0wf2wES7elrDlLb9rVi1 paLgdhwCD8TjBlHPWXzK5ZGYjaS1cklz5kp2gJmIN1DLW3NhCSIhW6uzzyCZuCBE/RP9 A8LUpWAvnf9oWHLttFrASYAPMIwttt4opaz75GAPanhHtB3MT3Tfk6/2eKXuPP/wTpYl UDHQ== X-Gm-Message-State: AOJu0YzvqmSY7Sz1t8xKDT9HHrgsrbbTWSkRpM63Sl/RyPJagpxlaRhp FWH++ZbPaX7G9Ag0YHrCJxE= X-Google-Smtp-Source: AGHT+IHq4bJzo5xCjXjeaRHYW3+7Eh6G6TXFPfM0Rd/uHy81UJMM/y9G6d0WRYTaDr+jELhNlPIA+w== X-Received: by 2002:a17:902:d4c3:b0:1d0:45b2:d8b0 with SMTP id o3-20020a170902d4c300b001d045b2d8b0mr16092073plg.5.1702502341101; Wed, 13 Dec 2023 13:19:01 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:a61c:8373:8743:d180]) by smtp.gmail.com with ESMTPSA id j15-20020a170903024f00b001d0b080c7e6sm10957310plh.208.2023.12.13.13.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 13:19:00 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH v2 3/3] arm64: dts: imx8mp-tqma8mpql-mba8mpxl: Fix USB connector description Date: Wed, 13 Dec 2023 18:18:47 -0300 Message-Id: <20231213211847.1096033-3-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231213211847.1096033-1-festevam@gmail.com> References: <20231213211847.1096033-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_131903_213840_D8BBFFD6 X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-tqma8mpql-mba8mpxl.dtb: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# Signed-off-by: Fabio Estevam Reviewed-by: Alexander Stein Tested-by: Alexander Stein --- Changes since v1: - Collected Alexander's tags. .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 26 ++++++++++++++----- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index 4b161564a284..505b70cb2bd7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts @@ -55,6 +55,21 @@ clk_xtal25: clk-xtal25 { clock-frequency = <25000000>; }; + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "X29"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon0>; + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + fan0: pwm-fan { compatible = "pwm-fan"; pinctrl-names = "default"; @@ -625,13 +640,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - type = "micro"; - label = "X29"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon0>; - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; };