From patchwork Mon Dec 18 07:51:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lai Peter Jun Ann X-Patchwork-Id: 13496335 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6339C35274 for ; Mon, 18 Dec 2023 07:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=EaQS4XmaY7rF1afxSJGJi8NaQW2Tiv4Ree06MLLtgME=; b=iCOYbOdMkxYdR8 OIRqpWa6GPnq48PxoRv0fOphwXrXfBAS75IZ/OmwnJv72ojpumnBASq6P4evy0W3q5qAxk7QD9Ll3 cwR5CuzPFfmhyBXoc2F7W6QeewB43m0Emp/FJf7LgyV/eemYArXA6kP1swRC3tEfPee08AwqrdHmg zjTh0/ZYknIaNMUIYwH5/LXbT2K6DpzqAab2/LAGHmm/XzDtca30hj5VnYDwqfiaCqEb5fWOyi1BZ qFH6xZV/nJfxRCwdyqw0gEuu+5RkKMPyNkfcuLilPJuiW0IIUzB0NKYsWcVNGPTsryF0YWvatL5wq wsNUFzSOir9b5ZR5w8VQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rF8Pl-009PBx-0c; Mon, 18 Dec 2023 07:51:49 +0000 Received: from mgamail.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rF8Ph-009PAh-14 for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 07:51:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702885905; x=1734421905; h=from:to:cc:subject:date:message-id; bh=BdJBRBUvWJhAlj87MALaZbhkeiFmNqv5A5ngqArXaRY=; b=YPk81bF05OTa2kyGnM0AaBMljRC6DLxwWJfBq22PCJStdrCaSMbgbseI spS1AL10NrIWIJ954PPqU03/7aDHBE755/Qpkfui1gH2po5hEEexkclWG z0njCEgMX4awp/6rN6avfKwJgz0tEE1KUP6h3gpZAGeZKbNQoKuI34jIE 4E1mGB28CS6vzmv+rhbQkz0KY0azCEnePtuoSv8CYHj9eroLcGaESV7Xm 9/o7Ux18ykmyYIWOxrcgimU1MT3scI6ZotsS1p4l56BwJSQiffI0i/r5F +u18zYP72tUU+zm+TVxU0txO6YT+BTs8zvc4CdgkD2ahzZtR4hY2nvwwf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="461921483" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="461921483" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2023 23:51:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="778999082" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="778999082" Received: from ssid-ilbpg3.png.intel.com ([10.88.227.111]) by fmsmga007.fm.intel.com with ESMTP; 17 Dec 2023 23:51:36 -0800 From: Lai Peter Jun Ann To: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Song Yoong Siang , Lai Peter Jun Ann Subject: [PATCH net v2 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt Date: Mon, 18 Dec 2023 15:51:32 +0800 Message-Id: <1702885892-30369-1-git-send-email-jun.ann.lai@intel.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231217_235145_432371_F2355660 X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver should continue get the timestamp if STMMAC_FLAG_EXT_SNAPSHOT_EN flag is set. Fixes: aa5513f5d95f ("net: stmmac: replace the ext_snapshot_en field with a flag") Cc: # 6.6 Signed-off-by: Song Yoong Siang Signed-off-by: Lai Peter Jun Ann Reviewed-by: Jacob Keller Reviewed-by: Serge Semin --- v2 changelog: - Add fix tag and stable@vger.kernel.org in email cc list. --- drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c index 540f6a4..f05bd75 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c @@ -237,7 +237,7 @@ static void timestamp_interrupt(struct stmmac_priv *priv) */ ts_status = readl(priv->ioaddr + GMAC_TIMESTAMP_STATUS); - if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN) + if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)) return; num_snapshot = (ts_status & GMAC_TIMESTAMP_ATSNS_MASK) >>