From patchwork Mon Dec 18 10:57:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26B6BC35274 for ; Mon, 18 Dec 2023 10:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zSZHdS/RHneKmAjDsAf+dE6+35eOpJMARKOCTccnqOY=; b=GknHAKg/eEuWH5 YB57BerANICQ/72CXLKmVjq2ZSDEE8YfQ97/YhrvG4eVnLvQmN8FnFU36YljMGaZJI43m/mOLXn9B hSSL5aTwbuG3ag6LHlZA44Bg+jxiKgPYHU7ZMvL89FNY3fTv10Dv7IeGtJ1HsAXXEzFpkF3iywGKo otolAVqQ5dxIGubQBnKe/tBOHsQ1QpYSOxWVvI92Ml8YFqX8HoC2DdEO98bsOhMz+3NGMfacO9FrE 3koWPcH5FfiYtwdIKjVLLmAWCquc6bP7W4/52DUmFmPs+9vj8d6G+tMCjPPuxxyyqQFmSApofz3C4 H5JxftVYg3bOHBoOVPuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJQ-009wdY-2L; Mon, 18 Dec 2023 10:57:28 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJM-009wai-2u for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:57:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702897044; x=1734433044; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=f6bpzhwW9R8BYF0pBX9Lwvsu/ntZ/dkI6vpAeUOsKdA=; b=bwvFij7Q191JDS9BBk8RKhD0+zSdTVgndBHXFW9xg8CyAi2jDMYgPGsj J67xAXxn0+xOjp8oZJrJcLbxbw/YPjalnHCk7OGnWz+Z0gP5rCF3uYKJg u8n8bPpivARwbkNfiWXKVIOPOZTHV2S7j1VK70nHZRCL9Sq1IGxyxzUoG s3dsGS0nJOqNH+ZdStwESE/+2wzVOva5hqpmObYVi/A9/A/f2l8FBY/3d 3HK8r+NLMIZ0wrzafRP82/IkhJ5prXmjTKCVLq6PtpnzVdHdnNVywvB8a Qrn+QmlpFzITv5Q/8mu11tvpG5VUqaXTIoX16owqQOZmsbFNovE+h+a0c g==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34559830" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 11:57:21 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id BDD10280084; Mon, 18 Dec 2023 11:57:20 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/6] drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe Date: Mon, 18 Dec 2023 11:57:13 +0100 Message-Id: <20231218105718.2445136-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_025725_322612_1A1A8FA4 X-CRM114-Status: GOOD ( 10.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This simplifies the code and gives additional information upon deferral. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 26 ++++++-------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c index 4a886cb808ca..3a1d5795d002 100644 --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c @@ -403,20 +403,12 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev) return -ENOMEM; p2d->regmap = syscon_node_to_regmap(np->parent); - if (IS_ERR(p2d->regmap)) { - ret = PTR_ERR(p2d->regmap); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, "failed to get regmap: %d\n", ret); - return ret; - } + if (IS_ERR(p2d->regmap)) + return dev_err_probe(dev, ret, "failed to get regmap\n"); ret = imx_scu_get_handle(&p2d->ipc_handle); - if (ret) { - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, "failed to get SCU ipc handle: %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to get SCU ipc handle\n"); p2d->dev = dev; @@ -427,13 +419,9 @@ static int imx8qxp_pxl2dpi_bridge_probe(struct platform_device *pdev) } p2d->next_bridge = imx8qxp_pxl2dpi_find_next_bridge(p2d); - if (IS_ERR(p2d->next_bridge)) { - ret = PTR_ERR(p2d->next_bridge); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, "failed to find next bridge: %d\n", - ret); - return ret; - } + if (IS_ERR(p2d->next_bridge)) + return dev_err_probe(dev, PTR_ERR(p2d->next_bridge), + "failed to find next bridge\n"); ret = imx8qxp_pxl2dpi_set_pixel_link_sel(p2d); if (ret) From patchwork Mon Dec 18 10:57:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E7EAC35274 for ; Mon, 18 Dec 2023 10:58:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ckbKdZlpmiVZeJe2rigKncWmkt6hW0AyGI6xzHyLmZQ=; b=pIw/UHQEIPFain /r53LYe6g8auuoNKQ0LHLIeG014J62eD750yo+wYa+Uy+d/81bE9W8x2+AAxsGZDludIxVnWhihjz fDEyf0hM55TwtnBo+bsbmxAjP38nK4ay9r2QbvgWJFz7v71t1u1Fv+5OMH1pPgZdDejsE4uVDkzcF xUspk8vqqQAae+mKyhQG1qpzbcB8yticv6cM3zlUwIsZEbJq0Vf+idyNdeCRZlEeAkpCTrghnsyzr bCvouYnoOCxFw40mmu6TnEEE5Ckf0+cPXbdkZnKXl8LBnYmzbkfdFvLKpUx4b0B4SPPBqeDCx8Yqx pi7GeT58DEyNtmnX1bDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJb-009wkK-16; Mon, 18 Dec 2023 10:57:39 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJM-009wav-2u for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:57:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702897044; x=1734433044; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gAuxvxpZNby/nD/WwNhshNTVTgcfNR7TyfNbdg9IQig=; b=MQXXjCu1h66QxILu1n/o1K5whstHMdAzbyounZmjLFjS4jgtDZflq/Yr 4+BZNqp11Hdt/UxYCepltidGghLt16iDuQL0k+CrXM+bIUDpigIAxk/ga cOxSP1Q50hHyQHvbjsqvrkTU49W5fYkkRmxDlkQ6BUKw6JcLT70bAG//I sJc8bemI0fw9RIAFvzb+TeYp1JpNklzIWNxRaa79EwTVhoVp6Gi6X0+AK 8wTlPtU/OgfnfyQY76mmTT2sWrIIBGzAyZhBfEXdEH6CkbURUwPe0DU7y Z86e6SkSoTs92GNNRBLRffi7Wq0Bm1r4xueyy1TVW8PyKbz7+/74gnAcZ Q==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34559831" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 11:57:21 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 1E73E280075; Mon, 18 Dec 2023 11:57:21 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/6] drm/bridge: imx: imx8qxp-ldb: Use dev_err_probe Date: Mon, 18 Dec 2023 11:57:14 +0100 Message-Id: <20231218105718.2445136-3-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_025725_322616_28901BD4 X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This simplifies the code and gives additional information upon deferral. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 37 ++++++++---------------- 1 file changed, 12 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c index 7984da9c0a35..423196d2204d 100644 --- a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c @@ -557,10 +557,8 @@ static int imx8qxp_ldb_parse_dt_companion(struct imx8qxp_ldb *imx8qxp_ldb) imx8qxp_ldb->companion = of_drm_find_bridge(companion_port); if (!imx8qxp_ldb->companion) { - ret = -EPROBE_DEFER; - DRM_DEV_DEBUG_DRIVER(dev, - "failed to find bridge for companion bridge: %d\n", - ret); + ret = dev_err_probe(dev, -EPROBE_DEFER, + "failed to find bridge for companion bridge\n"); goto out; } @@ -590,22 +588,14 @@ static int imx8qxp_ldb_probe(struct platform_device *pdev) return -ENOMEM; imx8qxp_ldb->clk_pixel = devm_clk_get(dev, "pixel"); - if (IS_ERR(imx8qxp_ldb->clk_pixel)) { - ret = PTR_ERR(imx8qxp_ldb->clk_pixel); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, - "failed to get pixel clock: %d\n", ret); - return ret; - } + if (IS_ERR(imx8qxp_ldb->clk_pixel)) + return dev_err_probe(dev, PTR_ERR(imx8qxp_ldb->clk_pixel), + "failed to get pixel clock\n"); imx8qxp_ldb->clk_bypass = devm_clk_get(dev, "bypass"); - if (IS_ERR(imx8qxp_ldb->clk_bypass)) { - ret = PTR_ERR(imx8qxp_ldb->clk_bypass); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, - "failed to get bypass clock: %d\n", ret); - return ret; - } + if (IS_ERR(imx8qxp_ldb->clk_bypass)) + return dev_err_probe(dev, PTR_ERR(imx8qxp_ldb->clk_bypass), + "failed to get bypass clock\n"); imx8qxp_ldb->dev = dev; @@ -640,13 +630,10 @@ static int imx8qxp_ldb_probe(struct platform_device *pdev) } imx8qxp_ldb_ch->phy = devm_of_phy_get(dev, ldb_ch->np, "lvds_phy"); - if (IS_ERR(imx8qxp_ldb_ch->phy)) { - ret = PTR_ERR(imx8qxp_ldb_ch->phy); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, "failed to get channel%d PHY: %d\n", - imx8qxp_ldb->active_chno, ret); - return ret; - } + if (IS_ERR(imx8qxp_ldb_ch->phy)) + return dev_err_probe(dev, PTR_ERR(imx8qxp_ldb_ch->phy), + "failed to get channel%d PHY\n", + imx8qxp_ldb->active_chno); ret = ldb_find_next_bridge_helper(ldb); if (ret) From patchwork Mon Dec 18 10:57:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9F0BC35274 for ; Mon, 18 Dec 2023 10:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cMVuJQSxBD7ZZGFdkTTEQ9ihiN+DnXvP3+DsS4zYFjg=; b=m+/IxpVeZSiV6v siH1iwPVgpDyHPpaQ6lMwMM19PnGFxUJUnOOJO0WhTrJyjqcD//30q4QOhOFXAbd3Zq6UJs7rg5xz DoCvPMxpUL+zEDsD8iVZqKBS4nAJMGvH80E4cvzKZ7WycovijVnvsoFUF+scajUCvFiIUuR9dA4gC IlQOCRWozCCQbRvXVfRxuHvEhZ89SE5Iw+7GKs5ifEF8FCAdWMcOVE4gO20/XK0ROTd57uh2vmqnB jtIb7lEgSfvdJpqtfuEMgz2PdE1XNtT2pUGRKeSJy1EO5ePjwA7xGVBrFJY3QfmWA2EajorqTCuKC fFNkz3w6u0X14GNctvaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJb-009wke-31; Mon, 18 Dec 2023 10:57:39 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJP-009waQ-0T for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:57:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702897047; x=1734433047; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2lv189ze1HjPcTpyti3gs1HfX3zuxk+ObuRHYy8a0Yc=; b=LvZrt/fBZKJtYKzLq+QgB6+Spm2bpfqDn8YPoIytW49HqaO+Q9JkWyLv W0ITv/d0CN/pGZqlukffX3tpC51zYYYaclmez3ZbKv508P2j2lQBlubSp RQZ69UwKouA/7es9Wj5gy61EjNqnjCg3yu2EwvbJVXEibGgSaObfkUiSn PXPAHN6ljL+HMZIsi7Mia8Hu4xBH7Ufb5Y91hYrkCGgKz+GUMLELPEULc 2H5adVunz+psrAoB+2FSKW74g9HHDZwgWNztGbnr6kgvzNf7cjsxse3wW d9CMtBDP5gQGCEcuLQqj57J8sGBcgcBKrF76rfJabYQVmgsvaalrZP2BN w==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34559832" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 11:57:21 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 71814280084; Mon, 18 Dec 2023 11:57:21 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe Date: Mon, 18 Dec 2023 11:57:15 +0100 Message-Id: <20231218105718.2445136-4-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_025727_479872_E16C8DA8 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This simplifies the code and gives additional information upon deferral. Signed-off-by: Alexander Stein Reviewed-by: Francesco Dolcini --- drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c b/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c index 6967325cd8ee..9b872cfb849c 100644 --- a/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c +++ b/drivers/gpu/drm/bridge/imx/imx-ldb-helper.c @@ -172,7 +172,7 @@ int ldb_find_next_bridge_helper(struct ldb *ldb) { struct device *dev = ldb->dev; struct ldb_channel *ldb_ch; - int ret, i; + int i; for (i = 0; i < MAX_LDB_CHAN_NUM; i++) { ldb_ch = ldb->channel[i]; @@ -182,14 +182,9 @@ int ldb_find_next_bridge_helper(struct ldb *ldb) ldb_ch->next_bridge = devm_drm_of_get_bridge(dev, ldb_ch->np, 1, 0); - if (IS_ERR(ldb_ch->next_bridge)) { - ret = PTR_ERR(ldb_ch->next_bridge); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, - "failed to get next bridge: %d\n", - ret); - return ret; - } + if (IS_ERR(ldb_ch->next_bridge)) + return dev_err_probe(dev, PTR_ERR(ldb_ch->next_bridge), + "failed to find next bridge\n"); } return 0; From patchwork Mon Dec 18 10:57:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60DCCC35274 for ; Mon, 18 Dec 2023 10:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hb8Dwv1z1pqzK75/ogVwTNDD8vpp/FLR5dCdzUkRFLE=; b=3WRCprb0dWY7+t KYOxiYIm94ZZOtxrpCgDQ8CGsUl+iuGaJkQg/suGczTZAwlEmH7/spC+UdSQMVSJYmpPSiE8MqgKw ONNUU+N6j/L57CXm7REcQNG1bHaxVbCUGVHS51GHnkXm0wOYJnqCBCMwNtpHpWouOcskMTPOitkMB QqsU07SsaDo5gsEqNUExMcK7o8KMVA/WQgLL48D49mTe9BpavEe5YfxD2dXT+Drf0VmtjWv7Ri35T 6/I6hwX5DGpoKVohcW/XLYV1DpNC8X9ZGFJMOEcRZkGNHVe20V7YhuZpjOis+Ggv133ICG8sfjE18 RERxzhgyW21LAYpjQOMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJc-009wl9-1z; Mon, 18 Dec 2023 10:57:40 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJP-009wai-0X for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:57:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702897047; x=1734433047; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ues8RonNkqtXNeQTmjHWB7sVdRAozhdTlsj5rYeL0Go=; b=aTEcJJYB3+Xox6MivWXvbPO0qyOnjLOKL5UmhIp8vA66qFPf29twnHo5 G5hIjYG+TO8nw0rAMrTnXpgausf14oXAUw7u4AvvxRH5jL0CdhoF0mMPd vdTsU6P6hX15sJ3mnOaHKdAIIcoLkGy3JZXMfmge59bffaGe9YVmXfEXv WxTsspQYYOei86WUJA9A00pr3QUHapI8khzt1xFiARdsRzs2z1nft3Ns3 rbPULbilb806xBt799lnxgwj4aEBUAgGMUm2vqCHF39fbVTtk0FPanDKF qTBnLozXHPDBovBZtcynSnYz5fAquX3Gysp5/H9Bp56O72CsWnHIAh0DQ g==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34559833" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 11:57:22 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id C4F08280075; Mon, 18 Dec 2023 11:57:21 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/6] drm/bridge: imx8qxp-pixel-link: Use dev_err_probe Date: Mon, 18 Dec 2023 11:57:16 +0100 Message-Id: <20231218105718.2445136-5-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_025727_504586_F3C8F4C9 X-CRM114-Status: GOOD ( 10.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This simplifies the code and gives additional information upon deferral. Signed-off-by: Alexander Stein --- .../gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c index ed8b7a4e0e11..b8cc1df3e572 100644 --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c @@ -338,12 +338,9 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev) return -ENOMEM; ret = imx_scu_get_handle(&pl->ipc_handle); - if (ret) { - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, "failed to get SCU ipc handle: %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to get SCU ipc handle\n"); ret = of_property_read_u8(np, "fsl,dc-id", &pl->dc_id); if (ret) { @@ -379,13 +376,9 @@ static int imx8qxp_pixel_link_bridge_probe(struct platform_device *pdev) return ret; pl->next_bridge = imx8qxp_pixel_link_find_next_bridge(pl); - if (IS_ERR(pl->next_bridge)) { - ret = PTR_ERR(pl->next_bridge); - if (ret != -EPROBE_DEFER) - DRM_DEV_ERROR(dev, "failed to find next bridge: %d\n", - ret); - return ret; - } + if (IS_ERR(pl->next_bridge)) + return dev_err_probe(dev, PTR_ERR(pl->next_bridge), + "failed to find next bridge\n"); platform_set_drvdata(pdev, pl); From patchwork Mon Dec 18 10:57:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EA15C46CA2 for ; Mon, 18 Dec 2023 10:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KkPXxQN4mkk8Wq9qxgRMercmcAE4l8NM7jCzQv/6j1k=; b=1t32wFTRw1Jd8F AAoED8aNREK7+akDbDHz2Qz1HMJ0/Iw28i0db2eGOYs2gs5GuiElLieaZ3b4K3zAV1dCU05IHpZ5G NmgBjcbrVj+Xb/nO82pmi4DNVjYMjgYHj9FDQsbBs/Vwz2Pmmo/p/gMp6cg2GqhsDCduEg41j4MtM t7e4wNuFQ2FG8wGPR9p43BXT4DH/vSiBbs/wZfXaxhBbTom+NAltWgJRJ9L1YE2P2rfM15gyLsEuU oIbVt1SPxl0ZAsQ8Rid2iSExArDEAF+MVp7++ClfGg51OZJ8kUJJ46EnJlo5oJSDrws8R2g04rgkO Xpzl3FflW2SAqWcu6q/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJd-009wlf-1R; Mon, 18 Dec 2023 10:57:41 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJQ-009wav-1N for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:57:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702897048; x=1734433048; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LF02UyNK/xpkLqe9tr31YIzv+kTaNRG9vqb7cPz4ldI=; b=PujiWEdUo7x+KHBTp+bqG2GdGM7t2mV0Nd4xtMbwDZ/gxiPZXJBZzOgy TkZHQi+WSIdUBmHYDHEHLeebxavPdHttwaBMbAaYPSLssbFiK8Y8CMdP3 /7SrfuYE7L6kMV6eT/rSZ7wSveTbmM/bt2i7oJXpw98eBNiPfScUMi01j 7igO/92tJEm9vr7EL4vndL3hScjTkEbYA+W6R95cbILM6yBnljOV5q4Zh IvFppxDOnQw8pk68LdEFt1JSvVYZuyxJ8AdnKA1iGNEIBmEHRjIE7jsSV Dk3MNH2cjw0970CsFOPADCu1qvtVgKgwgYVeqyacwl/youI5mE8o9vuKA g==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34559834" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 11:57:22 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 24E1F280084; Mon, 18 Dec 2023 11:57:22 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/6] drm/bridge: dpu-dprc: Use dev_err_probe Date: Mon, 18 Dec 2023 11:57:17 +0100 Message-Id: <20231218105718.2445136-6-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_025728_786498_DC00B340 X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This simplifies the code and gives additional information upon deferral. Signed-off-by: Alexander Stein --- drivers/gpu/drm/imx/dpu/dpu-dprc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/imx/dpu/dpu-dprc.c b/drivers/gpu/drm/imx/dpu/dpu-dprc.c index 261c9566721e..6467ad960080 100644 --- a/drivers/gpu/drm/imx/dpu/dpu-dprc.c +++ b/drivers/gpu/drm/imx/dpu/dpu-dprc.c @@ -612,7 +612,8 @@ static int dpu_dprc_probe(struct platform_device *pdev) dprc->prgs[i] = dpu_prg_lookup_by_phandle(dev, "fsl,prgs", i); if (!dprc->prgs[i]) - return -EPROBE_DEFER; + return dev_err_probe(dev, -EPROBE_DEFER, + "Failed to lookup fsl,prgs\n"); if (i == 1) dpu_prg_set_auxiliary(dprc->prgs[i]); @@ -623,11 +624,10 @@ static int dpu_dprc_probe(struct platform_device *pdev) ret = devm_request_irq(dev, wrap_irq, dpu_dprc_wrap_irq_handler, IRQF_SHARED, dev_name(dev), dprc); - if (ret < 0) { - dev_err(dev, "failed to request dpr_wrap irq(%u): %d\n", - wrap_irq, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, + "failed to request dpr_wrap irq(%u)\n", + wrap_irq); platform_set_drvdata(pdev, dprc); From patchwork Mon Dec 18 10:57:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13496610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15EEDC46CCD for ; Mon, 18 Dec 2023 10:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MBnoYjOzPYl7CMI6V3VlAjmYg3ecnPvpXByqzmcwxfE=; b=sYYB7teYVd56Dz qm5zAdzhnsoktSbziU2gOI7JU8Vp+2P5bF/j8WINnrIADC96GJxc1Czobqd2InWHsLonp8p+QWaSy jPEzgtIGFe2NXVJGCUCVUQlO7EhrtwEIFJf9TctdY1imLPK1td1UStLKnTioQquJBEh+6pUi1YCAV P2cpWBhwWgCjF51MY1/vpnUyGae8wEptJrg8ELCBKD3G8x/Du83lrvZysQvT1C54cpwizjrT2R9X8 wtWGvT69V4DEOmh3LDy1ci6hJwfzKSsPzsHYSDADahrH/u01NZmjgBDE/Y87fqZQv9WiuX8ryK+Cn XGZPHcPoLVZm7v58NrEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJe-009wmK-0L; Mon, 18 Dec 2023 10:57:42 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFBJR-009waQ-0h for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:57:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1702897049; x=1734433049; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fddthYdTBT69uFgmETEmEISCHIBOg8BtXB5X4yHA0g8=; b=WUY50ZUFc4JS4YuCUp10P5oVzaN1o+WucYxFmSDOFSumcPvz9wR9p8K8 but06QN4eBjX7gyMWxvkBqOzyNZ1iw8yACxLjOAJtHpWuYNlGoE6CZTZJ rPwpHodocW74K3RIS9zzhP0E6DP29YoDN0H5bIhiRSrovv/WCiUyoYrII xycJR7fQgLAFCb5orUONIxC6B6302caj+aGC+VP8jzYKQ/d8BK/M2zKRY 93x3vjt0mH6/BAUa3bA4tYcCdWFL6vAU/6ZroyGmqPW5X7Kbt12NbdCVH 8mbleDLdbIw35TJh5jb7YV95qV5TGufHoIGE/TKFymH68/lcxDjSJ5tLx Q==; X-IronPort-AV: E=Sophos;i="6.04,285,1695679200"; d="scan'208";a="34559835" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 18 Dec 2023 11:57:22 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 7ABC4280075; Mon, 18 Dec 2023 11:57:22 +0100 (CET) From: Alexander Stein To: Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER Date: Mon, 18 Dec 2023 11:57:18 +0100 Message-Id: <20231218105718.2445136-7-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> References: <20231218105718.2445136-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_025729_578553_E463C691 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org -517 errors are just annoying. dev_err_probe can't be used here either as this would hide the error message already set in us->init. Signed-off-by: Alexander Stein --- drivers/gpu/drm/imx/dpu/dpu-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imx/dpu/dpu-core.c b/drivers/gpu/drm/imx/dpu/dpu-core.c index d6116b3e4ed7..ea2558a14a6c 100644 --- a/drivers/gpu/drm/imx/dpu/dpu-core.c +++ b/drivers/gpu/drm/imx/dpu/dpu-core.c @@ -592,9 +592,10 @@ static int dpu_submodules_init(struct dpu_soc *dpu, unsigned long dpu_base) ret = us->init(dpu, j, us->ids[j], us->types[j], pec_ofs, dpu_base + us->ofss[j]); if (ret) { - dev_err(dpu->dev, - "failed to initialize %s%d: %d\n", - us->name, us->ids[j], ret); + if (ret != -EPROBE_DEFER) + dev_err(dpu->dev, + "failed to initialize %s%d: %d\n", + us->name, us->ids[j], ret); return ret; } }