From patchwork Tue Dec 19 08:41:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498042 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 883D91170E for ; Tue, 19 Dec 2023 08:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MOjKIILD" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40d190df5d0so24802665e9.3 for ; Tue, 19 Dec 2023 00:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975321; x=1703580121; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=AcI2SqQQB4Jltt9lH8a1zFwnKso4M1EWV/+giKCyLKc=; b=MOjKIILDRBvy8YV+n/HbLDcN9AeEJR5XiCnytQdljiQq0S4FIy5raUGB8DbYDPPv+c 7H6T1itmXqazcTwJ+agP9WKQ6w18FixB8qhbph79uuWIxaQa9vBCMQWzNYyU3La9d2Vf VSkIUch6Q7L2Qcp8nJ0XbOmcgEWa8B/JqNDnFGXZHki0yNIG0vpGff1/nUnCQJqy9MIQ TaVSV99oKQXjcaQIl9wd15evWfLTHVW3dwjur3DyxfoCsbYxl7i7BuZF+xxhWcePdL8U XOazBKQuNP/HLsEevLptTvwIa4GIH2DPe7JkrkOLgfRrfaLW65USFV6qr2o0/agxATfU 29qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975321; x=1703580121; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AcI2SqQQB4Jltt9lH8a1zFwnKso4M1EWV/+giKCyLKc=; b=fSejz8GDyshvenDgHS1+OncbyDQLJK45zBLZ1hSdTdSAolndZFvDh+6mXOeuCV6VQy eFQPLTbfRCWGJVTRv+rmP8lgUWiALt+hS0pbH47gn+cmSfTdzcIPIeyBaEAv6L0LAmfF rppdUbdMaRM7/gNyEk7gkA2UrqPmU5knDrvescvSJNYqmvH1FwTrHZQwFBN2VMugE0Wk WF7Lj0Rsm64HVk6hve2ujimlNkeRc6cfR6CPZxtBLV4FwJH3O+vNK683u7C0R7mxRiMg Jx1pAnBFAs6H45fvbX3A5MiywvG1JmRcp/DzpUWw7KM9iUsPCIFfhTd/LeMmGBFUU8aK qUHw== X-Gm-Message-State: AOJu0YxMaQHhU3cQraHDICSIdLBq25/Rsn4S2h7fA8izBXkyEUaqXUcV orbo0woQF4eVQrMyOke/3te9zJkmQAg= X-Google-Smtp-Source: AGHT+IGbAT07fA+oijPLQoZelS6rOOZ2XGfUC6R5Mr0bsh/6Mu6A4OLA8c9LU9WvaCcWLlCwr7MT8g== X-Received: by 2002:a7b:c3d5:0:b0:40c:3774:8ae9 with SMTP id t21-20020a7bc3d5000000b0040c37748ae9mr9936102wmj.7.1702975321325; Tue, 19 Dec 2023 00:42:01 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id m39-20020a05600c3b2700b0040d23cea7bcsm615527wms.1.2023.12.19.00.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:01 -0800 (PST) Message-ID: In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:52 +0000 Subject: [PATCH 1/8] CodingGuidelines: move period inside parentheses Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref The contents within parenthesis should be omittable without resulting in broken text. Eliding the parenthesis left a period to end a run without any content. Signed-off-by: Josh Soref --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 8ed517a5ca0..af94ed3a75d 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -450,7 +450,7 @@ For C programs: one of the approved headers that includes it first for you. (The approved headers currently include "builtin.h", "t/helper/test-tool.h", "xdiff/xinclude.h", or - "reftable/system.h"). You do not have to include more than one of + "reftable/system.h".) You do not have to include more than one of these. - A C file must directly include the header files that declare the From patchwork Tue Dec 19 08:41:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498043 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E00711725 for ; Tue, 19 Dec 2023 08:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d47Iq/V6" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40d190df5d0so24802825e9.3 for ; Tue, 19 Dec 2023 00:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975322; x=1703580122; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=RZ+mRYR4ZuIXNnMs9/cNBaByPR4a4sdcF8Ik2YtQRXM=; b=d47Iq/V6P31+nUVDnnXuQ3iLl+DSwRO7V5DqpjedMImcztg8fy7S+meRP3iUAIygWm cYjaMC1PwpF+145czgNV2K3G7mkf+eRkYslzdtuKUEC6Rc1tsyokwGzj1NyIDVwRnHCX BWxPp/xsrT5+7+lZv1AXJvNR/DOrkZHK26ZDr7Bp1wj52QZrAnDZ1K0o1o3bVcTg+Oi6 8amZn4gXuIDrVmnEwzTJax/Jyt15lP+UnSyBSbOOqgcokBgNe3/B9iYOB1jSBG0+0pS6 +AQurXpsaqwitX0fjXYWfZkgD/bnB9pcB1/NB5VJPbdmRAt9TeHz3+rJaezW304MMJab 0VGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975322; x=1703580122; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RZ+mRYR4ZuIXNnMs9/cNBaByPR4a4sdcF8Ik2YtQRXM=; b=ijMCaJsixwHuvs4q8vf6qoSUllG6FAk8afxXR54+oVOgvEcyH2lWgCZKnIouNbXr3D cYVB5GgHV5L3Z/OXK0IH8TzpWyLo6M3q9omY0hTNf634B7Qyp5Kye7lkvqsQR66DvFDO i5Iu054yoKwqIwQrYj604U5jhO4n2MWEdYzmETLUrWwtbEkpHlown4Sphb90XJ0nhl44 oFAbXhIHGMiYN2ulDt09CLfN6PiZLIoVgrvl5DNDDSeWbRRCoxFV0JHl9SufGLqqkm5M p8sw9yfAjdNXdUMLXIB00WLNCMdcR4aNYRUOvw/qLDjaE6cUPmPwer7RM5nhIvW2/qtz 2ilQ== X-Gm-Message-State: AOJu0YxG8Hhy13ltDVsfankQvUKGpqSov3T9dEU/iPUWx6OOcknBfYqH /WB9D2lFAsRIueDkkXlLo47pFVpiBNA= X-Google-Smtp-Source: AGHT+IHB5GSStbJWfrSeYCgQZ2nFDNcwp4T1kx+4mm9qwuHV5CCZUNS5Ph+oa1LeIHhobIXYickXSQ== X-Received: by 2002:a05:600c:5487:b0:40c:6e33:c1e8 with SMTP id iv7-20020a05600c548700b0040c6e33c1e8mr3349329wmb.168.1702975322307; Tue, 19 Dec 2023 00:42:02 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id m26-20020a05600c3b1a00b0040b2b38a1fasm1779447wms.4.2023.12.19.00.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:01 -0800 (PST) Message-ID: In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:53 +0000 Subject: [PATCH 2/8] CodingGuidelines: write punctuation marks Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref - Match style in Release Notes Signed-off-by: Josh Soref --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index af94ed3a75d..578587a4715 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -578,7 +578,7 @@ Externally Visible Names . The variable name describes the effect of tweaking this knob. The section and variable names that consist of multiple words are - formed by concatenating the words without punctuations (e.g. `-`), + formed by concatenating the words without punctuation marks (e.g. `-`), and are broken using bumpyCaps in documentation as a hint to the reader. From patchwork Tue Dec 19 08:41:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498044 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F2B125A8 for ; Tue, 19 Dec 2023 08:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B6uePAS/" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-40c3fe6c08fso49052075e9.1 for ; Tue, 19 Dec 2023 00:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975323; x=1703580123; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=7IvwM4W/NlDHwNbKAl3tiFP3CE30lrBYpPWWZEMxuUY=; b=B6uePAS/LnayCuaUTKXjTrAqLW9e2lqU30sq1fLbF1rYx7jRzPmt0W1E9HK8YQN0cK aPgnz8iX9gv/D9ULNPj1aWcGYoroQWs6vjSN8OYvWaHRpamDZyNhloq+f7BHY4HSbeeg b0Io99w4Yxghk8ab/XZ1N6ZCfF1bnxoHnKWfP4H0cqaiOKQs4sVzCiDcbuZpohYvM32q xSRKl/CAP3U9S3NX9n9eJ4WtvolZPwUFNGBUahRy29OQAhGkdJ4LOjQIGjJLUC/Tgpp1 DD8SFktCWF/87DW143Clws9V62o+CweevmccOxU6ma1YaOZd6QQssPogLoNm66HIV0CP mzuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975323; x=1703580123; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7IvwM4W/NlDHwNbKAl3tiFP3CE30lrBYpPWWZEMxuUY=; b=iG50Ly6XT3nyhS+Ehmbu9x6V7Qzb+aPpHsoDzlQ4pUUy5iNuOyNNzk2fOp895cWDIA bN/S4wXxkjKyrT5jAhf43ZNecBLLPW7Zr7Q+xFDGKPZKwM2cPtiCXjKuOdnNN5zirtvx Ir9LL+Y9hDQVk28zSZt22pdN/WGHoZthjfstzu+QicpWefpB4JPY9VRsjXj+Yp6Xv5Ea Yo/PV/g0yHFZgdfv/OmduGk1rPx3IH2dbqE0x3dkQjtPwwtKzqYobhzqLnCcTBnGu3ER iP8EsXvotHCtEmvY47TJOMXXrpBQWAVuqd+HqqKjFArqLkNr9J4MeSb272Af4HwqJMQo ZfBw== X-Gm-Message-State: AOJu0YzpWn3LZohT0FvLeG8QUUbBWuHWbOQBH7gFmmyaulCoYu2Y644T SnQ6BTNh+Wv67tByPYw8Ze0qfOumf8k= X-Google-Smtp-Source: AGHT+IHZf96ImVRheKihFUkxuYBnLRQeBvO3Vp8DL+xuu7OoXs3k7mx/dnTo6tOx+KXenoyASdiAlQ== X-Received: by 2002:a05:600c:c1b:b0:40b:3fc7:c88a with SMTP id fm27-20020a05600c0c1b00b0040b3fc7c88amr6073775wmb.39.1702975323386; Tue, 19 Dec 2023 00:42:03 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id jb2-20020a05600c54e200b0040c4afa027csm1719404wmb.13.2023.12.19.00.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:02 -0800 (PST) Message-ID: <22d66c5b78a6930e195141df848266cac099ca08.1702975320.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:54 +0000 Subject: [PATCH 3/8] SubmittingPatches: drop ref to "What's in git.git" Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref "What's in git.git" was last seen in 2010: https://lore.kernel.org/git/?q=%22what%27s+in+git.git%22 https://lore.kernel.org/git/7vaavikg72.fsf@alter.siamese.dyndns.org/ Signed-off-by: Josh Soref --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index bce7f97815c..32e90238777 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -570,7 +570,7 @@ their trees themselves. master). * Read the Git mailing list, the maintainer regularly posts messages - entitled "What's cooking in git.git" and "What's in git.git" giving + entitled "What's cooking in git.git" giving the status of various proposed changes. == GitHub CI[[GHCI]] From patchwork Tue Dec 19 08:41:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498045 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2858C12B70 for ; Tue, 19 Dec 2023 08:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bYi1TBP0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40d190df5d0so24803185e9.3 for ; Tue, 19 Dec 2023 00:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975325; x=1703580125; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=b/ZL9NM/c0Cbe4DjhVVMZWaNRupuk8zUqiiLwtorE2s=; b=bYi1TBP0hZU+tZnKAEf6a1ubqbd7KpETyy8r8pjVzoLZ5eKld4O4Ac6Wv/CLJv94yv TJuYqqmVcTQT+02mSksBbLunNYtcqrewufyZfbwIs0as6pCyenqJMWuvqFu7wUj1EH5R y2qPy6kCF3yhxwTgwEdTLhjkpBOEMO+LdzTlceX4zQa5yctJGCZ8lvxlkEjProrrbV4Y HIwTcIIqnIo+PdN+12Y7Fk0vrtdsdVDak8wuX2dH2jjhOlLP46DD9aIYO36p0tMtUjXf zvNEpMUVkR/8B4gME3pPN3Iy6piK3TDjuKjruBsJaxCYlfH7cleP1YGlWE5gvZpnr8Ds WlmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975325; x=1703580125; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b/ZL9NM/c0Cbe4DjhVVMZWaNRupuk8zUqiiLwtorE2s=; b=PvYEZ3jXtoIl6r/SR/hWL/4XrNhSCIlhu0JG76d4IuO6Gfw8H8CiJvc101SxpLxqPh PdihjLYVelDDK/wVz54O3eipLeAu+hZF/nN5KsmNa51CsBk9kUQ6SF3mPjSit+dQRuSq xYb+Q6FlLxRPxFE8Mdfeha8nkveqjEjVwXRgRYUXwo35lMiA2qNjUlUTkBlnl+yYysM4 exyEk/bju30Ofh4aIc8h2v10bpGxB2M/D8om4gV8j30VaGw1TeHDpRQ3LGVi9yJLYGLo Sj/xB8mjyuAnpX2VQSVThRdtRoszJOmwT/WxJvKDzPCXxXsEOhAxsNQrue4bRTbr68eq Kpfg== X-Gm-Message-State: AOJu0YzbHI+lJJ0N3LDO60ZIdz/UWs8GVTkFf1TZLUG0IfulBb8X9UdB /Yy0dKJr6sF/rnE/v1NW+s7Gil5rG8A= X-Google-Smtp-Source: AGHT+IEfFqijo+O7z7GPQ4IgTmNQQ17rXzsCr89nz2X7wPbWl7dzYnxIkqHtoun6BwBKj2Asb0VtLA== X-Received: by 2002:a05:600c:4384:b0:40b:5e1e:cf7 with SMTP id e4-20020a05600c438400b0040b5e1e0cf7mr9013512wmn.50.1702975324568; Tue, 19 Dec 2023 00:42:04 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id n33-20020a05600c502100b004030e8ff964sm1812267wmr.34.2023.12.19.00.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:03 -0800 (PST) Message-ID: In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:55 +0000 Subject: [PATCH 4/8] SubmittingPatches: update extra tags list Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref Add items with at least 100 uses: - Co-authored-by - Helped-by - Mentored-by - Suggested-by Updating the create suggestion to something less commonly used. git log | perl -ne 'next unless /^\s+[A-Z][a-z]+-\S+:/;s/^\s+//;s/:.*/:/;print'| sort|uniq -c|sort -n|grep '[0-9][0-9] ' 11 Helped-By: 13 Message-ID: 14 Reported-By: 22 Acked-By: 27 Inspired-by: 29 Requested-by: 35 Original-patch-by: 43 Contributions-by: 47 Signed-Off-By: 65 Based-on-patch-by: 68 Thanks-to: 88 Improved-by: 145 Co-authored-by: 171 Noticed-by: 182 Tested-by: 361 Suggested-by: 469 Mentored-by: 1196 Reported-by: 1727 Helped-by: 2177 Reviewed-by: 2202 Acked-by: 95313 Signed-off-by: Signed-off-by: Josh Soref --- Documentation/SubmittingPatches | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 32e90238777..694a7bafb68 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -348,6 +348,8 @@ If you like, you can put extra tags at the end: . `Reported-by:` is used to credit someone who found the bug that the patch attempts to fix. +. `Noticed-by:` liked `Reported-by:` indicates someone who noticed + the item being fixed. . `Acked-by:` says that the person who is more familiar with the area the patch attempts to modify liked the patch. . `Reviewed-by:`, unlike the other tags, can only be offered by the @@ -355,9 +357,17 @@ If you like, you can put extra tags at the end: patch after a detailed analysis. . `Tested-by:` is used to indicate that the person applied the patch and found it to have the desired effect. +. `Co-authored-by:` is used to indicate that multiple people + contributed to the work of a patch. +. `Helped-by:` is used to credit someone with helping develop a + patch. +. `Mentored-by:` is used to credit someone with helping develop a + patch. +. `Suggested-by:` is used to credit someone with suggesting the idea + for a patch. You can also create your own tag or use one that's in common usage -such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:". +such as "Thanks-to:", "Based-on-patch-by:", or "Improved-by:". [[git-tools]] === Generate your patch using Git tools out of your commits. From patchwork Tue Dec 19 08:41:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498046 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B059D12B80 for ; Tue, 19 Dec 2023 08:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MfQY9hMP" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40d13e4f7abso24936075e9.2 for ; Tue, 19 Dec 2023 00:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975326; x=1703580126; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=GvKhy32dP9r4we7s5Og96tKp8wPOp+8SHwgf4ZtHLMM=; b=MfQY9hMPQc3lNsjlK79/fYTrfxMKxnAZ8zBXkq+X7HFvbRdQkquS2JJ3keFaSSCPgv 6jHG5SRM6NtgHhhamR3Fd5QFiK7sk+14455k9HOhfEfLfpneWriELDNGI3TzFVnn/oWA hpcCaMroPQmTVNVhWRl+8fC/JhcTRYsI1/gTkBbrEzULN/w0VAE07Ik+nlNo3XhFytaJ ox++s5DI5A6vpuVUCrffmT2d48/k8PYlOLNUQ+VF+dp6GLLyRsG7SCdR5E6DOShWO2A9 VhYQGVG45a0zR9xUeR2+WD9N+Bh0pyVkOEsOJaouZz+rzR4GeOYOOr2777i1/q/QwgNI KUAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975326; x=1703580126; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GvKhy32dP9r4we7s5Og96tKp8wPOp+8SHwgf4ZtHLMM=; b=asJBD2MMwoqAnqo15xXhZIPo9InYe8NPIsLBgrsVbt4lMg9TfmqSQdOUKD0PUCnenZ FF0TUjPP4VIP26XPK/mAjsEd1yXNP+hqcTlGlqYjfniVWV0k8ruoXJ0J1sfzLZ0Vgelz aSFN05gsRWuYsBEhyPfWH/LOxnhHkug7RqZzLZAD7f93lJJsNVa5N9F41z0PuK8rOLzD kNcYOGSEcKS3oEaDXK60t41ox31E/pKKuT919PxUf6rLNg5ZhSdneOSHkuyTtfiTonRq WDEaZD9bLJlXXyNt8VNqx89143D5VKrauzXN/osqFii3pLvdF16dlU4qgffYQvF7lS3a L5Gg== X-Gm-Message-State: AOJu0YxR9hiyc2uzOK+s+z8Ol9kj2/Yqi2HGUShiZpFCKg5JFbpKD6ae RUz4tCah3VGIri5S2EL5u0hnd4Uv8JI= X-Google-Smtp-Source: AGHT+IEi273O9gBUu7USSxDwTUXQnSI6d9pNLdpoSdq3vbqXltIKWHjQFRr5YPX2JoBVs3xhHPWGFA== X-Received: by 2002:a05:600c:450e:b0:40c:2b4c:ea8 with SMTP id t14-20020a05600c450e00b0040c2b4c0ea8mr10833563wmo.113.1702975325877; Tue, 19 Dec 2023 00:42:05 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id ay10-20020a05600c1e0a00b0040d1bd0e716sm1794304wmb.9.2023.12.19.00.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:05 -0800 (PST) Message-ID: <11688e4360c1698e56b3485e3df4e171397d3c3c.1702975320.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:56 +0000 Subject: [PATCH 5/8] SubmittingPatches: improve extra tags advice Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref Current statistics show a strong preference to only capitalize the first letter in a hyphenated tag, but that some guidance would be helpful: git log | perl -ne 'next unless /^\s+(?:Signed-[oO]ff|Acked)-[bB]y:/; s/^\s+//;s/:.*/:/;print'| sort|uniq -c|sort -n 2 Signed-off-By: 4 Signed-Off-by: 22 Acked-By: 47 Signed-Off-By: 2202 Acked-by: 95315 Signed-off-by: Signed-off-by: Josh Soref --- Documentation/SubmittingPatches | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 694a7bafb68..d7a84f59478 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -369,6 +369,9 @@ If you like, you can put extra tags at the end: You can also create your own tag or use one that's in common usage such as "Thanks-to:", "Based-on-patch-by:", or "Improved-by:". +Extra tags should only capitalize the very first letter, i.e. favor +"Signed-off-by" over "Signed-Off-By" and "Acked-by:" over "Acked-By". + [[git-tools]] === Generate your patch using Git tools out of your commits. From patchwork Tue Dec 19 08:41:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498047 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE2A612E73 for ; Tue, 19 Dec 2023 08:42:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ivHYkXGs" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40c39e936b4so48884575e9.1 for ; Tue, 19 Dec 2023 00:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975326; x=1703580126; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=EEk8w6zLthh6eU9WJj7lAhdI382V9ytLfLho6ibFBNY=; b=ivHYkXGshNqPZcCM8NnWpefkb+T8VXXfmk92IF7fcy7INJSt7pc83uhxQBj/ows7+h blS81dJFta4k10jjBwj6qDISlc1fTcsLA7LV2USrv8hvCQ/tYknHF9Z44dBKDQvTyLmx BoI/Wwe+YOAg6F1U0Km3NUkTyF2P6j5z+FjQmSJ5m2VB/4SWJvY0lDP/e15XIeOT6Gjr daQQoMh/iIoOC9o7eF6dm/cCo5dxakxjlSFym+FvPdj3V3q6COjKptol2/W16QlhDPH6 AU47ASnxyCOn07qiI5NCBDImpS59x7fbRG+SHcIzIfzgolFf8LmBsCHDKLUo7jiuty5p Cz8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975326; x=1703580126; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EEk8w6zLthh6eU9WJj7lAhdI382V9ytLfLho6ibFBNY=; b=cU1LDlmoxs+F2y4fswqoCLyoIrGpUBxpWXkL5eAW4+GgsvJk5Q/AdLHnZKTUatiFhh eMv6FOcJ91z+gtFlhoobXBwUbgf4ivFGIPHHimNdAKm6xoGcYZDsDKipBqY/y5t/3hH4 5i6VxqfmnNHK06Zv3MY+NpNKOYKSSdbbJCLZngGo9LiQKOwgP3GyRUnLhmqKq92k4biA 90wGuNk7CDjlqgvrCIfBBseP4c30GGQwIB15fHaZAmNM2BREO3gysr68GZODJ8Yo64gh nvmgN/NVwPbsnEF3G5f9snrIPE/E9m+OQ12UBv6B0EuPe6UyyR1Q8q4zaXi2mTIRCKhz PdpQ== X-Gm-Message-State: AOJu0YyXNzoJ76DTjjXDqLoEHLHNm77ZsRqOVmCpkYCEqg0ntph3GeTP 0PbW0bjhVE8HRUCVxQ+Dn4Q6Qt4URSE= X-Google-Smtp-Source: AGHT+IH4QcgqA5ComtUB2X/5KHm11JelDX54Aj+D0nPwQXwAyg+ZzS2TWx+vRPQPLmg9ObV2XiQxDw== X-Received: by 2002:a7b:c40d:0:b0:40c:31f1:144c with SMTP id k13-20020a7bc40d000000b0040c31f1144cmr4425366wmi.87.1702975326536; Tue, 19 Dec 2023 00:42:06 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id i7-20020a05600c354700b0040d2805d158sm1260537wmq.48.2023.12.19.00.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:06 -0800 (PST) Message-ID: <043d2a24202d39c5564e4a4369c86ae4648dd721.1702975320.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:57 +0000 Subject: [PATCH 6/8] SubmittingPatches: clarify GitHub visual Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref Some people would expect a cross to be upright, and potentially have unequal lengths... GitHub uses a white x overlaying a solid red circle to indicate failure. Signed-off-by: Josh Soref --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index d7a84f59478..8e19c7f82e4 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -604,7 +604,7 @@ to your fork of Git on GitHub. You can monitor the test state of all your branches here: `https://github.com//git/actions/workflows/main.yml` If a branch did not pass all test cases then it is marked with a red -cross. In that case you can click on the failing job and navigate to ++x+. In that case you can click on the failing job and navigate to "ci/run-build-and-tests.sh" and/or "ci/print-test-failures.sh". You can also download "Artifacts" which are tarred (or zipped) archives with test data relevant for debugging. From patchwork Tue Dec 19 08:41:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498048 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED3F213AC8 for ; Tue, 19 Dec 2023 08:42:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CBCtFeah" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40d05ebe642so13734355e9.0 for ; Tue, 19 Dec 2023 00:42:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975328; x=1703580128; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=1PNPnnb/Kuw34DNa1XdNAhVkgbvuzzdqVxI5hHzFh0M=; b=CBCtFeah3CH2dLLEFFxEv0a4FJGlhn+eAkt5aG5U3+LbTuosCgu93fOnoj1aujIhwX j7oYW6Y+4xoB0h8UKKvRqf4Cmt+spB2tvUyJPC4dXi035vCXSqfte2fpiYn0YoEqvQ7a Ishloy8pnPcZswIgC5qK2Q9hBK63twmP7FO6Y2d6AAiIflo/o2CR96RUlyBQtrzOrnlL gFjawKYkvI9VCFUC8HDzzqjfnsBq6KkUtoAVAoZ1rSJpxP0pxWzxiJTCIswBH29d1iEM Ad3Yt4t5ZipdhsrtpApVl+YFpHY2MMZ6o2lN2fXxlRzgyFID9RA59u/NiJa4z+TN5We8 uhHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975328; x=1703580128; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1PNPnnb/Kuw34DNa1XdNAhVkgbvuzzdqVxI5hHzFh0M=; b=Ay8XyF8I0q/AwLfNnsTBGwVIOM1jTplZR7ViOjc+PUe02WK4CltuhYrTixE8IGXsIy FUmdR+Xtpqf1HggsP5RmAU8o0vSbV1+OyABRn0NVlbkgQae0MQRfAJJBGExOGDaM+MhH UopPh5RP8/2V+TvPnZ795RMzJPRE5247EeNlZb6YSsV5HxYOYJsQ3ZIcJhLG4ylO39sb 7RIoszPRY4QlAnp+65wPhU1u8MbrtYcfcMH6LjVk1b4A1kYVzvX2AR24kHg2bI1dSaux M/t+yJIA1nmZeZ9c47sLqagQoXiezwDNb30K9wPt+PAoKCAk1fKhjk6kTUIQrGugFDSe bFOA== X-Gm-Message-State: AOJu0Yy8Zl1RBg/Fvs5Lh8JFEkidhjFErfHzj2BoTvmxQn0G5CCrlTbK B/o2q6Ruy4PEMSJUe+YeTsZMvlI5vWY= X-Google-Smtp-Source: AGHT+IHkaFnxqtpAddfrKCz6h+mombbca39GRL6+yPWjj9OM9jPWlyQ5JDlJsGS+1Lk9ZhrEvhC1Gg== X-Received: by 2002:a05:600c:2d47:b0:40c:a76b:6212 with SMTP id a7-20020a05600c2d4700b0040ca76b6212mr310970wmg.161.1702975327585; Tue, 19 Dec 2023 00:42:07 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id f10-20020adffcca000000b003364bb3e989sm13052871wrs.110.2023.12.19.00.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:06 -0800 (PST) Message-ID: In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:58 +0000 Subject: [PATCH 7/8] SubmittingPatches: clarify GitHub artifact format Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref GitHub wraps artifacts generated by workflows in a .zip file. Internally workflows can package anything they like in them. A recently generated failure artifact had the form: windows-artifacts.zip Length Date Time Name --------- ---------- ----- ---- 76001695 12-19-2023 01:35 artifacts.tar.gz 11005650 12-19-2023 01:35 tracked.tar.gz --------- ------- 87007345 2 files Signed-off-by: Josh Soref --- Documentation/SubmittingPatches | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 8e19c7f82e4..b4fa52ae348 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -606,7 +606,8 @@ branches here: `https://github.com//git/actions/workflows/ma If a branch did not pass all test cases then it is marked with a red +x+. In that case you can click on the failing job and navigate to "ci/run-build-and-tests.sh" and/or "ci/print-test-failures.sh". You -can also download "Artifacts" which are tarred (or zipped) archives +can also download "Artifacts" which are zip archives containing +tarred (or zipped) archives with test data relevant for debugging. Then fix the problem and push your fix to your GitHub fork. This will From patchwork Tue Dec 19 08:41:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Soref X-Patchwork-Id: 13498049 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 656C513ADE for ; Tue, 19 Dec 2023 08:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XbGgwN75" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40d12b56a38so33258295e9.2 for ; Tue, 19 Dec 2023 00:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702975328; x=1703580128; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=cgKA2Zz3ci6RKvd4YBkO6M/PwiKD3KRRYNdreB/ehfI=; b=XbGgwN75z94Ds+GamPGn+dVZbhG80gWQhqgeuqBIWDBVNkWhyTiv5Y+WpJ/6g8hw6o 2drZUw+xx2tWT6aSWuFNfzm+ocktj3Dvm06K/X4AJwd+yRphnr0wxNWBoOctdVT6azg7 cmuHCTz+wv6P9U6iWG/5eJ/MUqYAZ/7EbNNJ/zayg9cTwOc1Dzm9sUlsxzQ+faO27fsY /w01bIRPfm9C51sChaO+sXwPk51MME/hGpUknB8eFHKnKIVcrc5K2haFi/CgMYm1JjVI O73gABaHBpIBeawb+cQmifFzzon127oVWpVVvWKVeXgaOWkY3dMGm3lxdK4IISg+X5Ly BRTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702975328; x=1703580128; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cgKA2Zz3ci6RKvd4YBkO6M/PwiKD3KRRYNdreB/ehfI=; b=oYbUKnYRowZtp4ghNi+1Jivlqjia3zhxO15+voPBJflX3w5cOLtGjKPlS0OdL7v40o B1sinWiZqZwgVWOijaPM2EZPbRnU9zaweYZ85mdNGAYckHYjQNc5EpksBf14T0/NioAB gAvkua0oAobX0J7WaRzIWszBr7FaFMZj1QBtSzg41W5rAhXEGMLXpy3g3Zu/kTzfsjRJ xDNMT4QaXT9MFHQSOTYpD6ni96IUdawwNAJs1qxM4TUDrDQMnmjHAhoFAEFqknkijBZC vK4xVcHTcCmQyVMe+qBfJDOcf90U3nfniVf0d5mA2u2huIaaV43PfeREl3CipV39wBuI 3xqw== X-Gm-Message-State: AOJu0Yws2q2brfhFWoKC5aP9YHg6YFaTV6FtHsykJB6mvdI6y326ODYe BuNA2f7jlVqlr8icQAGLuZuhpuednmA= X-Google-Smtp-Source: AGHT+IEihPhnblG3clHAMvAA04Lyl91jwFu56rvCC0Hvt5fH943rbbJDJRSmeevJsXL0LTv8YXAU2Q== X-Received: by 2002:a05:600c:4d0e:b0:40b:5e1c:2fac with SMTP id u14-20020a05600c4d0e00b0040b5e1c2facmr4285628wmp.60.1702975328117; Tue, 19 Dec 2023 00:42:08 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id m34-20020a05600c3b2200b004042dbb8925sm1764231wms.38.2023.12.19.00.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 00:42:07 -0800 (PST) Message-ID: <92469324813702418a9db0b2e760580518b225cd.1702975320.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 19 Dec 2023 08:41:59 +0000 Subject: [PATCH 8/8] SubmittingPatches: hyphenate non-ASCII Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Elijah Newren , Josh Soref , Josh Soref From: Josh Soref From: Josh Soref Git documentation does this with the exception of ancient release notes. Signed-off-by: Josh Soref --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index b4fa52ae348..3c53592cfc8 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -700,7 +700,7 @@ message to an external program, and this is a handy way to drive `git am`. However, if the message is MIME encoded, what is piped into the program is the representation you see in your `*Article*` buffer after unwrapping MIME. This is often not what -you would want for two reasons. It tends to screw up non ASCII +you would want for two reasons. It tends to screw up non-ASCII characters (most notably in people's names), and also whitespaces (fatal in patches). Running "C-u g" to display the message in raw form before using "|" to run the pipe can work