From patchwork Thu Dec 21 02:25:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hangyu Hua X-Patchwork-Id: 13500897 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2571843; Thu, 21 Dec 2023 02:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eAuycK6U" Received: by mail-pj1-f66.google.com with SMTP id 98e67ed59e1d1-28b99bca6easo66007a91.1; Wed, 20 Dec 2023 18:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703125585; x=1703730385; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MJpfC3kc2UL6o363XO7Gt4DaAH8UXw1+4tDspztGViQ=; b=eAuycK6Uktob4M92iES8O1fUzJTm7+Mc7W1i7nDV04cS4aSFVbxP/GBecqpROod5QL zljk4XtXlJDtqndSQN1rHiIscW1sGrN9etkWMuQGKqQqA9sMFlJXUayul+jd/juMrhiZ wIdN6JP/Z8zvHEiTLTaCD4Onku2loFBuKcR2W14aats19AUw9wvjnD3jnbwm9sPuY+pK 0yR+sIDav27ciraCej5EPSypykfP69Tx5EDuVloqOv3EDesCjh5UKh1q8hLlMXzIa0Ti xxg3zqjCbbz9EsZd5V29YJlBcymfUCJjofBike/SEwWc2ecFdU/iNkrWrb9iTeULRMWS JdDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703125585; x=1703730385; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MJpfC3kc2UL6o363XO7Gt4DaAH8UXw1+4tDspztGViQ=; b=SKsQu/LTk8cepFovJuZ72wAuM65oDq6grhKMHiJQ3loiEBfqfeD3hxWzFS+wbYLF+c bHb7vwZ39GlK799VfvONspNzOgkGrut/c2eVkMT72YwnJ0XvTrBWhGiOwz1NPXcuWf7R XfuFZv+aemijnS7/cDZW6MLZjYeB7rQDu8u/T+7DuHbaioCAB0AOSkTczVIHokZQYMFh EeNNPCYnOrThZ43gcmEXXAEYNelCBO+jbCoTKF9dtHKxcIckcwtAVaDKyledU0ZyS+cO AdBrT+scvSSNzh5y27O3S6WdOGGAToVjMPatPqEtKw1zt9xWza2ZGy0+YxuA2tXWOdj+ 1c0A== X-Gm-Message-State: AOJu0Yy+up59mhopQ/bpF0Dws/4RoQuihDwr8TLXJOepJZWOWHUNxid/ fxEXiQGSzoj0PUikDu7tUoCZgPAHqfNAbVe+ X-Google-Smtp-Source: AGHT+IHkBuUQpGqS3DVr2KGUl3jagO1YFuspC5zC5APjTftv6Oj5rVsVVEeqXf9QueneaHe8XuBBQw== X-Received: by 2002:a17:90a:fd85:b0:28b:c22f:b1c1 with SMTP id cx5-20020a17090afd8500b0028bc22fb1c1mr5322596pjb.1.1703125585307; Wed, 20 Dec 2023 18:26:25 -0800 (PST) Received: from hbh25y.mshome.net (061239074230.ctinets.com. [61.239.74.230]) by smtp.gmail.com with ESMTPSA id 17-20020a17090a195100b0028b1fce7c01sm4691716pjh.37.2023.12.20.18.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 18:26:24 -0800 (PST) From: Hangyu Hua To: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tgraf@suug.ch Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hangyu Hua Subject: [PATCH v2] net: sched: em_text: fix possible memory leak in em_text_destroy() Date: Thu, 21 Dec 2023 10:25:31 +0800 Message-Id: <20231221022531.9772-1-hbh25y@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org m->data needs to be freed when em_text_destroy is called. Fixes: d675c989ed2d ("[PKT_SCHED]: Packet classification based on textsearch (ematch)") Acked-by: Jamal Hadi Salim Signed-off-by: Hangyu Hua Reviewed-by: Simon Horman --- v2: fix a type usage error net/sched/em_text.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sched/em_text.c b/net/sched/em_text.c index 6f3c1fb2fb44..f176afb70559 100644 --- a/net/sched/em_text.c +++ b/net/sched/em_text.c @@ -97,8 +97,10 @@ static int em_text_change(struct net *net, void *data, int len, static void em_text_destroy(struct tcf_ematch *m) { - if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) + if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) { textsearch_destroy(EM_TEXT_PRIV(m)->config); + kfree(EM_TEXT_PRIV(m)); + } } static int em_text_dump(struct sk_buff *skb, struct tcf_ematch *m)