From patchwork Tue Dec 26 17:33:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 13504916 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0444FC46CD3 for ; Tue, 26 Dec 2023 17:34:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DD7410E09B; Tue, 26 Dec 2023 17:34:21 +0000 (UTC) Received: from mout.web.de (mout.web.de [217.72.192.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2EB810E09B for ; Tue, 26 Dec 2023 17:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703612004; x=1704216804; i=markus.elfring@web.de; bh=AuhcszHwHjGP9Acn89BVl5MLLXrMpR0aVvDveRatoik=; h=X-UI-Sender-Class:Date:To:Cc:From:Subject; b=bG5SFJ+bYfMdlpGE1cElBR5x1ijpvWLrkp6loXWkOoDmOoBXR0L53mMfHRgyu1v2 RrVDJqRD9hd6SX+zDKcIjeq77aF3DPWOogjNATijcmLPRbqn8bMO8tqucz3Ndz6JK 3IYE/RQgrbtSIijS9YSHaveF+38NNWHbb55wi6bgiOujYezqxmIITs3Vqh468A7mn nCfwUKWtqf4aGEJ469/wks35vDHZ1oZ9TsfMmEcRlEAR8wj1VOGSIQpRP2vfwOANe FMjGchaP6nVU2vm1F/G/kQCr3CN/Vstyf0BaFKXJVbDeP2K+cxsy5FRhzYVhmZLC8 2bkjcKS04SntJZ0o1g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MElV3-1rSOi72PWd-00GAan; Tue, 26 Dec 2023 18:33:24 +0100 Message-ID: <189166d6-b76a-412a-bfcf-8ba14578a317@web.de> Date: Tue, 26 Dec 2023 18:33:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann From: Markus Elfring Subject: [PATCH] drm/vc4: Improve exception handling in vc4_validate_shader() X-Provags-ID: V03:K1:cqYAChBIlAwDCrpDesRT8Rcxu7TED955U2F15R9o1Lvz0JJr2FN uTKhH5RtR8P3nvpkDaA6FP3Z3AbzDluXJ9BYxHm7kZw+Wsl6SUnXMBcxkzReBqCZJWFYIZD +qKKAvP4dAuXEx9vhylypm1hlJdFyORz9GujswISk/AkMx8D9gvS82GVer/xy+zvDsQstS6 U9M8IklMQJXMOEO59DWqA== UI-OutboundReport: notjunk:1;M01:P0:riS9T522lis=;57fc1AQoeN3UHWwK3JukaIDA71E oQuOiPMRZaDTXd0YVGVRZE+jXL0z8W6Bujhd0Q9IZ5uRgiedPwsqmvoKDuW37PaceJ6sRPCpG D9/G21S0YOVs/dUqtHHm1uaJKuVXYwqaiDSFeiu9dkywsjC2ZLP1iSSb00Gxfj35YRtH8R1k5 HEY3Q5yST+1Y1SkCN92+dxUsOe8FkGKOUyUBAwN4bgfanTwcVZNjHwGy4IFAP1MZeHJQl/iv7 OXuLrgiqUBG0OW+goOGFqXiZtFnQgpbXEIBFdoMJ93uTUetUCOQJLY9AqrUrqZjQeulaAzK8U 4DKjLvIt908q0FbLhPffo4sOGBIMOmqvw9/ZM4W1pi6KrlqCCn69asLMstQcLwRoqcl3VcNyE wUIzIRa5SDAJ6/adhbIQJUu0vJLB8cYfmQFwz2XVOS8feiujbhaxruhTDUdWrQwAsibSunSWr EDOFHdlqumaLo0HoLHhH1fIrrmPw3gdn3q66xrqPxGMO7iT6azfn3+RgKVwOmk9Kd/2dXP5ml 2/a3S9zs4LF7GDVYN7U9RDmY5GsIyCzxdBjaWwc2Fvs2hCmrHT5GDVNiU1eAIUZ3uEnrSR1hT QBf7vNXjqE7lO2qZEg8hANyH3xR2wJpL4RuZ+w9rDLT+96EIpWdsghb99ljNFB4uSOdVYqsAB PQyCLQcYNadkiurQTQ6rL5QnuKTBEznJ5Qh8+vjvSaiFvMtLksunegF9uF1/8f5T2fRmAOsKK QegbLA3QlO62jPozlTViu3vNSxP5mlJQDFqjqQld6cN8kHgXgifllQsotBPf6JGllZ7NToWOi L+gghKSFDbhLQGhWd64phzNSbrkSJYhTBaFvPZV9ywHCsjQPlVtIQyyM4hB5AjZpjwApcFhpp o/4ct1Fi/qDO81XIE9h8bIYrfK5uvPCE5AlHoZmF9ebd/Oc+Pr6pqwZjZ+dveKVLpv5YPZdjd qMj77gRzkgSUok4y7iyPo6/3pQ0= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LKML , cocci@inria.fr Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Markus Elfring Date: Tue, 26 Dec 2023 18:22:54 +0100 Memory releases were triggered during error handling only over the label “fail”. 1. Return directly after a call of the function “kcalloc” failed at the beginning. 2. Reduce the data processing at the end to a required kfree() call order also by adjusting jump targets. 3. Delete an initialisation for the variable “validated_shader” which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/gpu/drm/vc4/vc4_validate_shaders.c | 42 +++++++++++----------- 1 file changed, 21 insertions(+), 21 deletions(-) -- 2.43.0 diff --git a/drivers/gpu/drm/vc4/vc4_validate_shaders.c b/drivers/gpu/drm/vc4/vc4_validate_shaders.c index 9745f8810eca..d76787bb7d51 100644 --- a/drivers/gpu/drm/vc4/vc4_validate_shaders.c +++ b/drivers/gpu/drm/vc4/vc4_validate_shaders.c @@ -783,7 +783,7 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) int shader_end_ip = 0; uint32_t last_thread_switch_ip = -3; uint32_t ip; - struct vc4_validated_shader_info *validated_shader = NULL; + struct vc4_validated_shader_info *validated_shader; struct vc4_shader_validation_state validation_state; if (WARN_ON_ONCE(vc4->is_vc5)) @@ -799,14 +799,14 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) kcalloc(BITS_TO_LONGS(validation_state.max_ip), sizeof(unsigned long), GFP_KERNEL); if (!validation_state.branch_targets) - goto fail; + return NULL; validated_shader = kcalloc(1, sizeof(*validated_shader), GFP_KERNEL); if (!validated_shader) - goto fail; + goto free_targets; if (!vc4_validate_branches(&validation_state)) - goto fail; + goto free_shader; for (ip = 0; ip < validation_state.max_ip; ip++) { uint64_t inst = validation_state.shader[ip]; @@ -815,7 +815,7 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) validation_state.ip = ip; if (!vc4_handle_branch_target(&validation_state)) - goto fail; + goto free_offsets; if (ip == last_thread_switch_ip + 3) { /* Reset r0-r3 live clamp data */ @@ -842,12 +842,12 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) if (!check_instruction_writes(validated_shader, &validation_state)) { DRM_DEBUG("Bad write at ip %d\n", ip); - goto fail; + goto free_offsets; } if (!check_instruction_reads(validated_shader, &validation_state)) - goto fail; + goto free_offsets; if (sig == QPU_SIG_PROG_END) { found_shader_end = true; @@ -861,7 +861,7 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) if (ip < last_thread_switch_ip + 3) { DRM_DEBUG("Thread switch too soon after " "last switch at ip %d\n", ip); - goto fail; + goto free_offsets; } last_thread_switch_ip = ip; } @@ -872,26 +872,26 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) if (!check_instruction_writes(validated_shader, &validation_state)) { DRM_DEBUG("Bad LOAD_IMM write at ip %d\n", ip); - goto fail; + goto free_offsets; } break; case QPU_SIG_BRANCH: if (!check_branch(inst, validated_shader, &validation_state, ip)) - goto fail; + goto free_offsets; if (ip < last_thread_switch_ip + 3) { DRM_DEBUG("Branch in thread switch at ip %d", ip); - goto fail; + goto free_offsets; } break; default: DRM_DEBUG("Unsupported QPU signal %d at " "instruction %d\n", sig, ip); - goto fail; + goto free_offsets; } /* There are two delay slots after program end is signaled @@ -905,7 +905,7 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) DRM_DEBUG("shader failed to terminate before " "shader BO end at %zd\n", shader_obj->base.size); - goto fail; + goto free_offsets; } /* Might corrupt other thread */ @@ -913,7 +913,7 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) validation_state.all_registers_used) { DRM_DEBUG("Shader uses threading, but uses the upper " "half of the registers, too\n"); - goto fail; + goto free_offsets; } /* If we did a backwards branch and we haven't emitted a uniforms @@ -927,7 +927,7 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) */ if (validation_state.needs_uniform_address_for_loop) { if (!require_uniform_address_uniform(validated_shader)) - goto fail; + goto free_offsets; validated_shader->uniforms_size += 4; } @@ -943,12 +943,12 @@ vc4_validate_shader(struct drm_gem_dma_object *shader_obj) return validated_shader; -fail: +free_offsets: + kfree(validated_shader->uniform_addr_offsets); + kfree(validated_shader->texture_samples); +free_shader: + kfree(validated_shader); +free_targets: kfree(validation_state.branch_targets); - if (validated_shader) { - kfree(validated_shader->uniform_addr_offsets); - kfree(validated_shader->texture_samples); - kfree(validated_shader); - } return NULL; }