From patchwork Tue Dec 26 19:21:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34B0AC46CD3 for ; Tue, 26 Dec 2023 19:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=puHXfPbAEsUmvi1NlYD0tmOc1nxJYed2mJqKePyWpxk=; b=iFcDyy0oyEPUZA fbj9DQeYzkmDKowkNh+ruQFFoyXt1TE0K8monc+ObW4j9e19EU4Pw0B/gR98ZCF0jpZSwvGSwp/fA efiuYhPuS9km6dAX7YaykppNAjaUphV5n93IF2FCE5B7Dqj59W6aRJrFHfnD0GJOvI/pTXWl6dDJ9 rwqsuBypO1EVWGprGwQ2ASRbaFaozOIL2frQ0A8ungr20Jv/LS3cDGqxIQuzJFQ/VMs+YyzrZMw3U YvEPOq/Zb9RpC3ld8iZ9v4UXbQ7C5a0PEa7aHFAaopaVukOzi3iMMtHeJ/+YwOsdqMST1+H580QPh ER65Nc8C7LtW8rgO3m9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0G-00DPka-0O; Tue, 26 Dec 2023 19:22:12 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0C-00DPhX-1x for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:10 +0000 Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7bb0af58134so4669039f.3 for ; Tue, 26 Dec 2023 11:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618527; x=1704223327; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0beT1lRwobeT/udVDQveaOigS7b6fLoDcuD/SsK5GZQ=; b=BC/ps7Xha3YFCWIXZLPEC/AU1X5geLC/fH0mToiHic1YJUzqRi4+u1E9Nj0UqaThCU dK3zjEDaeCrMNiu9AxvTBDLZriuavI/3GMLc7TKjyg2r8rftrPWOTCyeHTuefv8THjs2 5eFYvATM94v+ss4w/4pGcGi64kvw4j7W9zoKY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618527; x=1704223327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0beT1lRwobeT/udVDQveaOigS7b6fLoDcuD/SsK5GZQ=; b=iOs3F1ZcG8RZyQFr2eENqtt+QaC8qj1R0j1422iCHiKkg7W7XKfUrR6uKv9BNZaiKu yvZ7ErjRrWEMtwmH0CI3Hz0N/7n99OnziuJ4zWl0Bky33VTP5LtZ87Cf2uc6BhXmEFsC +nwEH8PhIl+X6RB23E5YGtXmfJPBFnx9DywqFUFfdZeC77HuQx6cs1nijgxB+nbN7YZ4 pjPTM0d8wmG3PUZbCUvT5BwubuYo+PyLEeqltVp1wLEf66jPWUmG1CoOHGRc62tC3mY1 sRrCmDxxtILlg0G1KIeyvxCnvHMnzDQdNPnuFy4DQWrFML+KUF2t3NN1UEnnvFPeKQso Ywyg== X-Gm-Message-State: AOJu0Yxctv0P7UdvTppbst3Mufnn3MbCgomWnncYLyJ10WRF7CmmGpUF NC94eM07ndf65yL+zq4ItMSi7VxNBTQ5 X-Google-Smtp-Source: AGHT+IGADxqOdqzCrh+kKQobH0CySQymMukyoXwB9KeUWYmRE9fqJHH6xGioz00eswrRyG6LPpu5FQ== X-Received: by 2002:a6b:5a15:0:b0:7ba:b0d7:20e5 with SMTP id o21-20020a6b5a15000000b007bab0d720e5mr9733427iob.0.1703618527498; Tue, 26 Dec 2023 11:22:07 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:07 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v3 06/24] ARM: dts: rockchip: rk3288: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:10 -0700 Message-ID: <20231226122113.v3.6.I8249df4df0b7d12fb68ea1e69f84ca589c574bb1@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112208_646115_0535D5CF X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi index 092316be67f74..1554fe36e60fe 100644 --- a/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi +++ b/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi @@ -112,6 +112,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&ec_int>; spi-max-frequency = <3000000>; + wakeup-source; i2c_tunnel: i2c-tunnel { compatible = "google,cros-ec-i2c-tunnel"; From patchwork Tue Dec 26 19:21:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 275BFC46CD3 for ; Tue, 26 Dec 2023 19:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MlrYMTSk4br0V1Tt7N7uAtOX/WnIQv8TSvP0Rb7Cgts=; b=HegqQGsVxvA9Iq 8ubWSGWu5hO8CHmycuutE1MDklz6CmBbGpBYIPOehHk5ueLQDRKfgcfPqY7eR/UfSfbBJrlI7ivuI uLQ6azhBKNFNmHZlj1B+nGTgCAVqbG0Kg7fpqvqs6X5/WwxX1g/CeCXWvHcKEhTGb8WBbliW/5hGY LQYQ38HFQZp+E29bat+Ij6qza+rrdhEA1nJw/WVaAnvU7cZQkVUsaHTl63gZ4EFu3ie7omZSvLHWv LN1droYqNr60TkvglNVtv90opqOwgD5PR8WzeUYLcKBcq2D8St5Ioe3AvFPY8yZTCNnbZqe0ind/a 3M+IH4vOGqx6m7C/1z5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0G-00DPl6-36; Tue, 26 Dec 2023 19:22:12 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0C-00DPi5-32 for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:11 +0000 Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7b7f6caf047so205865639f.3 for ; Tue, 26 Dec 2023 11:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618528; x=1704223328; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=thrF0ILWTbiGFQaiH41yQtWJ81V5Pd2rM8k0MkABtdQ=; b=P52Ib+Ro0Ggw4P25oVe4ru0U3RbSLa4Lfh9DylV6m6RVbrtRTRr/rNtjPrdPjD9pu2 Vs6xKcKVzqOViaVT5t+f7lbjWIMO7CJzbenEvDOagfJAG3AVxhy926Umgy+icqJdZTBJ Mt7JYdsbCn3YESnWGt4G01KZ8jRvcXo2c1bWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618528; x=1704223328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=thrF0ILWTbiGFQaiH41yQtWJ81V5Pd2rM8k0MkABtdQ=; b=QSAH4tmEHaNHDNAc8MNBNN+97S/poMcOEy9X4xVfeEF93t1kyS52qUuqdlFBSv2XzI SV7RfroLjczJsy+QlYo+Dp7NK5jK9xH6B5YH6lzsS4hFVfCRsU6pGvvPuvppwJj7nVzp PQVbMLqLxkP99WMsOr0wqdxLezRndFuDPvCUFaakIZZYu56ErPQi18toXuV0IKkQUpA2 65bpACvh+MATL+dUZpNnZdtAJU7NRErWLNSOI5p5u86x5t5W2eD1cGVVslfxOPabTSCi 6SV/WkBZv9QJcg+P48BAaRNhMYG3TNnNWLYpkIDvpxFiBQJfHG8seMk193rNg8YMi2SZ oc5A== X-Gm-Message-State: AOJu0Yyh1pMmm8iiQA0PmYn4EyQLNQ8krdS0NGSGlnF8Iy51Uc2g4p4e rZUKxPTG03GUlLe62XyLcJOelspt6xA3 X-Google-Smtp-Source: AGHT+IHP3cqF61lIxGXtlQrM4I81aWrz2Mcja1UYOJWo/ufdUqAFWvhIXG2CTqcyA9nGB6m/VVxrbw== X-Received: by 2002:a05:6602:3f8f:b0:7ba:9784:d96f with SMTP id fb15-20020a0566023f8f00b007ba9784d96fmr11764777iob.20.1703618528314; Tue, 26 Dec 2023 11:22:08 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:08 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Alim Akhtar , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH v3 07/24] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:11 -0700 Message-ID: <20231226122113.v3.7.I06b059021de1bf6103e60a73211f078f2af75d17@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112208_996190_30816A3B X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts index 4e757b6e28e1c..3759742d38cac 100644 --- a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts @@ -967,6 +967,7 @@ cros_ec: cros-ec@0 { reg = <0>; spi-max-frequency = <3125000>; google,has-vbc-nvram; + wakeup-source; controller-data { samsung,spi-feedback-delay = <1>; From patchwork Tue Dec 26 19:21:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504988 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7D10C47072 for ; Tue, 26 Dec 2023 19:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2enojP05zKS8VLJBoc543Y6mSckMJXzHqLtyAxfUbx4=; b=H1SAcNifJhpyvy +xr6fVS6/lCP4mrGOVkNeO8ZAtRn33+ZoX+P1zw2DaMXh5xjRRzaSqZlvSzvjZCT93htCOMgjj06G VmtMd6Q47BJYj2U/fb9afR3WcwFQwlDkEzxTJ33A0k7AzMGKF4W1674p0iy6NTNx1LSJ29xQjArVH us13aeLnQy0tZ94XvdI65s2F0Fm/vxwA693vk5SBKIpTlZQi5C032SoJ2w8PKdCZHLFM/cbM+Gs// 7vNdS/cyP3lToA6OspJK/k5r6kO8ktbAK0xbgIgeVyKgESGCZ7fPIe0QM+6AaKUfNY8Yn8kzt15jT mNAqHIEClr94KoCJmpiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0H-00DPlz-2N; Tue, 26 Dec 2023 19:22:13 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0E-00DPig-1J for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:11 +0000 Received: by mail-il1-x134.google.com with SMTP id e9e14a558f8ab-35fd0154368so22936725ab.0 for ; Tue, 26 Dec 2023 11:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618529; x=1704223329; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VEODyyeyprVfJRUjUtUcn0PH/jJY9TEHe0bos5Y4zHc=; b=OMOVwnBKhbe2zAP8ueuTgMCEkB0SNKyP5Za1NxUcl0AvcaYiEsVoyjFT/jcefQ7GFw iofHSahYeD+Tqk2EUtmNmrh8Bhd0fKEHA29vtmTtGtH7Hb05A2JWG2zhL41Mbo4/pxiP 0yDuAxq7PXd7HMxpl1iZywpiZSRl+/14Rx1Og= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618529; x=1704223329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VEODyyeyprVfJRUjUtUcn0PH/jJY9TEHe0bos5Y4zHc=; b=uUhzJ+HXj7xoXbz//hVH7aD1umd++thNRpwKmLiKIAcxaxmnbq+Ro522JSJ7JgLT9T hrPhIA+nt9aHm9GfbRrs47glFbIcLIXOchFp831S4aLVOXotdVAs3pfE4f842n4hND/2 mLn1acjT4QpCC7NoNbKy4/182G7DNrUuSrKzB/9ixnc7tG7r9eeoP83WwPE3Izjb8RUo K8RUFBRUg2cqlThiFxTRiC/ldAQpLB/VGUtGb7A57C+E/eqAAQS8HiRC+fQg842qKY5w StMlu3OrxhEioGaTDqWtvYW6YlUfyBOpUYUYCaepjT+8hkk/iXmQgg2cKPI1pqjzqQNa Bq7g== X-Gm-Message-State: AOJu0YxJ2aPeD294RjNxRGxyaDEejws8KjrVQbYeWeJ84fau/nIqcCx3 oYdQepjjCDzgBwJ4I70wRhv91tIBOAn/ X-Google-Smtp-Source: AGHT+IHa/0vFINH4R7TOUcFlOypJ6/So3v6QYpByaNG5AzpKzcz2ODJE44ZeU7zukq+ljzKdNZ5lIA== X-Received: by 2002:a05:6e02:1528:b0:360:17a7:1f28 with SMTP id i8-20020a056e02152800b0036017a71f28mr963152ilu.15.1703618529143; Tue, 26 Dec 2023 11:22:09 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:08 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Alim Akhtar , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH v3 08/24] ARM: dts: samsung: exynos5800: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:12 -0700 Message-ID: <20231226122113.v3.8.Idc995ce08a52ba4c5fde0685118ddf2873fc8acd@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112210_441822_11E0F3BF X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts b/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts index f91bc4ae008e4..9bbbdce9103a6 100644 --- a/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts @@ -949,6 +949,7 @@ cros_ec: cros-ec@0 { reg = <0>; spi-max-frequency = <3125000>; google,has-vbc-nvram; + wakeup-source; controller-data { samsung,spi-feedback-delay = <1>; From patchwork Tue Dec 26 19:21:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504993 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DB8FC46CD3 for ; Tue, 26 Dec 2023 19:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HNGka5WXhj+FGYQEehNXLbG8rIA2ghbJZJAa3OphqJw=; b=VjCifdl6Q7Biuc 5nKj85XM8z2zxZByIdfyKRjwL80cW7jewgIB1fbYbVGOHgWLwXpTxEEzbwTydjEjhg4eZJvCk6fAx 9vJ3ew6R8PrRpfq6M/Z0/U5zaL0cSCF6jIqSZkGHPbeeFPD9nOytXsQ0AieFDGWV3BUua3tDs/+mu RC7vCCxOSgQmELNWOmSfoUCS318DjPS/jjmu+4BhrkEB5V0tEVln/P19XlFilhEGwNdLwIgHsBBpR MWokQuvRImLHEYXnl9DJRzqQvQy3UiDUyOUhZMK2V+RR9J0y1lpddfMHW1/NdgGbxFyt2Qn9/0CIo 8nTWwCvbN0GkSZ9npV9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0v-00DQ86-0R; Tue, 26 Dec 2023 19:22:53 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0F-00DPj0-0C for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:12 +0000 Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7b7fdde8b54so249161339f.1 for ; Tue, 26 Dec 2023 11:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618530; x=1704223330; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=72Y9hKrM6wg7C/dkdJ1azVBKmo9vO5yjLJYb3Lbo8g8=; b=E8kZ3h+jaPMk4CLZGtQEyZ+3mFaqyakfo6uZnsd9vPuvOoktZDAUK1tZurDEnTBVc0 YoVY8K8MS2T4xR8TubJRwtpseaDLpcfsnfV3djKpWU7fJ4sYXNioqIrTRB0/QdvjS/+1 IqA0ZmLX8a7H/O8rclSJKUlPMEt74iV1k0FR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618530; x=1704223330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=72Y9hKrM6wg7C/dkdJ1azVBKmo9vO5yjLJYb3Lbo8g8=; b=YmrA9Os5575OthoTgJzaZFyuFZDHePH+7TkIBZC0DwiXJtF8+1xauEvCArqPe52PjD 6P4jg03JkkFcOa8FrH6jl19oUZ5aoT1la5w+GE5Gv4DMEw4FMp+pPulA2JmetGktPtPj 0h7YDJ9S6FUTjaNQbSlKrd/Tei7UAJpfpVPPfExms+NkXHnsDbGKd/xtwOBDxeblx7kf UVKpkHI3X804LmWShdxLd2QbVfQIeUKgjNIOhOwsgShVCaQrY/JvwMgG/1jCwXy4tB8M YpmATUkJ33OThaSaGSfMNbp9r3Sw+MMlgCn8SqRqzBnd/H3T3w0jzDbhdlEluBOq9p1z /9XQ== X-Gm-Message-State: AOJu0Yz/Ume8lsviyja/qedm5BcoRrOaC/MAbLise2nEQjqLJEbo0tIK e627UJudG2RnCdWVgPtXE7nIZ5lHd4+g X-Google-Smtp-Source: AGHT+IF6JaIjJ+4nkw3XKAI7b2qhT+RLQRJF93my4pWqagV6xX2LpANA+cbIE30OOMeWGip9I5fCQg== X-Received: by 2002:a6b:d807:0:b0:7ba:9ad0:657f with SMTP id y7-20020a6bd807000000b007ba9ad0657fmr10906914iob.0.1703618529969; Tue, 26 Dec 2023 11:22:09 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:09 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 09/24] arm64: dts: mediatek: mt8173: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:13 -0700 Message-ID: <20231226122113.v3.9.Ic09ebe116c18e83cc1161f4bb073fea8043f03f3@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112211_098653_61EA6537 X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index 8d614ac2c58ed..335aed42dc9e3 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -1155,6 +1155,7 @@ cros_ec: ec@0 { spi-max-frequency = <12000000>; interrupts-extended = <&pio 0 IRQ_TYPE_LEVEL_LOW>; google,cros-ec-spi-msg-delay = <500>; + wakeup-source; i2c_tunnel: i2c-tunnel0 { compatible = "google,cros-ec-i2c-tunnel"; From patchwork Tue Dec 26 19:21:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504990 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B51EEC4706F for ; Tue, 26 Dec 2023 19:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zBiwWE9k1fv3Jq77YXXcjs/qbOdX3j66qVmKli0Wm+k=; b=moeRA1X9sP9g6b M83r1gPZYYCwU7uGIJRHx7rGCkXW3Py4NksxeG008hbfx8mOVzevSOFTx9DnbaaeyWD8R8N3s4Z6P d3OJFS/QoRJxUGBCUKc3S7t3/S2pch6IZPY9b8iHJiQgCwUe6i7Fk8VFcsR0QoyPR8FNU52PcT55e NBW+NiHY/QZnYMfXIJFJXSXYg72rYs2Zsi5DQFaDMDH0GcdR2B+cgEnLz7AcpsmLP8uNtWEHdG+nJ SFfN4pT1v5jekNgf5kYrPUX4th6Wcs6iBgQAyDG47WC/4kD+QOYLnqMbHlQnDYKOM7GCM9Gle3Qlb lfJzilh3zGpD9hSjJFbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0e-00DQ1D-10; Tue, 26 Dec 2023 19:22:36 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0F-00DPjb-2q for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:13 +0000 Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7ba8e33dd0cso199193539f.0 for ; Tue, 26 Dec 2023 11:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618530; x=1704223330; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h7Ja8Mbk0Dn0paAcqtccJazS/+ZwMfvgkX5xOL8nKJI=; b=H1DauJUMC3Gh9rYUBbcV2phHhOxzUC3pf+1qVDrTgLCGwsdCSnuKv+/Us1ofqcc8wn Pmlu1Mnz/At3zC2Yyny7/Fnsx2FNlHQddVH6ih0nbFSWhiQV0sJhMJJDKbO+CjisCFbz BI+EmJEoFb4Hw0wirbHNmc2oyFK4XXL7ak7d8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618530; x=1704223330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h7Ja8Mbk0Dn0paAcqtccJazS/+ZwMfvgkX5xOL8nKJI=; b=AH23D/oN7i7D9SlkVDdni4b3+La6fSpFwDlLLXYHPmeDbRRKUGbdrCvEcPt0X0epZ3 O7Pa8XMGVNFiAwIouZ6TSDyhYXpi/83bxONDJ0yJhAUsJmnBYdsb0qayiPE4rQ7ppgJe Pfdhyse52S5LtWOzKIpyzjYicAN+YCYmgfW2N/d/lq6tNZb3WCzVhr5h4anRaYUn3gKj XeaZeZqh13OlMmD4NV2c9gk2Du7mogu8rNFzaK0nzpkMBBby3M4m0E3hqwMk8h9LkvHJ KSyjYS2u+nFFXtMQDi+YeWQtj7cgGf0hiug/nJYm3LWdlOXGbSLhI47ZMbSH4kYkmqfS DbdA== X-Gm-Message-State: AOJu0YzeyZQAC59tUBeNpSW0ejOuVAbVfKBYdxKn7gf9Q7xZcypctJhI F8mpgfi6cgbu9dJWzcexUV4qJpxV2d7/ X-Google-Smtp-Source: AGHT+IG8helE4u9r3GeIgnMcwM3YERloc3FZd47BOCTyom2igtFIusFh5HNKk7KvOaUbVJAxoSn/Dw== X-Received: by 2002:a05:6602:3e8b:b0:7ba:a650:13d1 with SMTP id el11-20020a0566023e8b00b007baa65013d1mr9133258iob.10.1703618530770; Tue, 26 Dec 2023 11:22:10 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:10 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 10/24] arm64: dts: mediatek: mt8183: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:14 -0700 Message-ID: <20231226122113.v3.10.Iba4a8b7e908989e57f7838a80013a4062be5e614@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112211_958962_5AD6392E X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index 5506de83f61d4..08261164ab18d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -924,6 +924,7 @@ cros_ec: cros-ec@0 { interrupts-extended = <&pio 151 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&ec_ap_int_odl>; + wakeup-source; i2c_tunnel: i2c-tunnel { compatible = "google,cros-ec-i2c-tunnel"; From patchwork Tue Dec 26 19:21:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504991 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D28A5C4706F for ; Tue, 26 Dec 2023 19:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I31TPopLRVvhopAXedAabLXI12kBeL/t6YQVjIh7NaQ=; b=gNCrZ8+vwwqt8J S+DYRZXDf2jDvSfz7k23UMKpwkqKBra/MT49hjaGvOkbi93BpzY2HjT2oFL5yCBZbwhJSQDb9fqfE LgAN5Cii9luaEjurhSZsRGnHK8Ivk/drSX3qWsBLknIiVHpd96tzKJasKOwRdfeVu3CsM5Tc3Tyzc WN0AGF7j9HGHtr24bRW3SNkRhCYFoUTthbHb0HcDisOr0vS4Fqm6jfRLlKHCoIGrt8Q9bbNIn7pJ6 xDswJn5aH79olhBD3SOz2KcIDwhCS2cWxxuxihW0yQaUSAuwp9Vn5tyRxdl+1rPsmi5OxZvAs1BE1 uHAEqP0N1gvENjkRk6/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0n-00DQ5G-0M; Tue, 26 Dec 2023 19:22:45 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0H-00DPkZ-1q for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:16 +0000 Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7b7d55d7717so215336739f.2 for ; Tue, 26 Dec 2023 11:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618531; x=1704223331; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ESf+HP/4Pbj+l15SV7DO/QREg1e8QVEjr0ahdi8QujY=; b=EBPAIw0iJJN0kPOuRDDRJ+F4q3IbS6DM40MsuozEaIyMTZkl+5VBme8be+rRHHGFEL DAH7JyY/4JaAnSfTb1a6GzbglQGA4akJod71i5/URXh9u5oxuRixJXCvWG2F3jYFjf9C cW/ZZYJFS0JlC4RH614ehzLdhddn2CdCeGGe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618531; x=1704223331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ESf+HP/4Pbj+l15SV7DO/QREg1e8QVEjr0ahdi8QujY=; b=hnfe2q5kVwVKOyxKS/wqaQUFtRUrUEBNCoH0ZRR8ECev4A9y5agIvNvT7PoPyseGQj t4AI9o5x+Ij46GMqte9A569vuDKqH+8iwfV184IixsIsjctRuYFfZODga/plEoEc16Pa iYRZFmFPVSSaUktJcyz8Za2B9HAAi99kyqp208jb3g0Ia9+t5sTHnK5wSOIQXXfh1N24 BsJpg5M1/sdGioLB8sxyWiG9JF0l4f+bS4haaofYaQTz4gI+EkTXiTHPRIKTVHzYaSeD zq+LDEJ97I88E43qjxsUqO2Z1bON4Hf09TFaX9RipljpKrmk5JnCQdTChf6ahjD1OsWX utWA== X-Gm-Message-State: AOJu0YyApcQED47VBc6gVQuEwfXpv5IFwjnxIGNYeFWp+HzQjtCqt8eW 17BAsHn52IOEAxTbKpQdSvkAu5wI7f8k X-Google-Smtp-Source: AGHT+IHL8LG5CIj6VbEuHzPAo+E1eayG3+anqUkueUhwD4N1X/1qk2RhdEsAN0sRAt9MtvhT5qjugA== X-Received: by 2002:a6b:e714:0:b0:7ba:94cb:aa23 with SMTP id b20-20020a6be714000000b007ba94cbaa23mr8299937ioh.21.1703618531662; Tue, 26 Dec 2023 11:22:11 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:11 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 11/24] arm64: dts: mediatek: mt8192: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:15 -0700 Message-ID: <20231226122113.v3.11.Ibd330d26a00f5e219a7e448452769124833a9762@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112213_611195_0666A073 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi index f2281250ac35d..ab44d382f757e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi @@ -1332,6 +1332,7 @@ cros_ec: ec@0 { spi-max-frequency = <3000000>; pinctrl-names = "default"; pinctrl-0 = <&cros_ec_int>; + wakeup-source; #address-cells = <1>; #size-cells = <0>; From patchwork Tue Dec 26 19:21:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504994 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D36BDC4706F for ; Tue, 26 Dec 2023 19:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IRBbMLZMKEYf/nob0NYOzqU3qdjQyjSoNA/LlruHRCE=; b=Cez1f25Q1aAa9L HvIJmmtq9xtEvy9CeyVV0P7O6XBagghflpw2HVW35S57u2czixDGiCOnpxdnmlMa3o28TQovLn3+E DkevlAnylwi679pbd8AD5l54Fo+dsTg90NVBX27DckssQUuDuY+UdbwhUr4qH/2Tomy8NV5Lax48H YHjCBFHku1WtEPHW3lhPKXYWRyXFzTxjRGRz/ZwEIh75I7LObC4WdHv7/u9K5iA1k4BiV4Q9tVcGv g1z3a8tW7qPfFGCgMb2SvUDhsQSiIClpbOylvuoOKfp0ZbIZlFnKl8nXPpTh/Mpiq9JhaILMUueVZ S3hx5Dff7cgYV4zTsfWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0w-00DQ8v-04; Tue, 26 Dec 2023 19:22:54 +0000 Received: from mail-il1-x12c.google.com ([2607:f8b0:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0H-00DPl9-2N for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:17 +0000 Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-35fc6eb9075so11377515ab.1 for ; Tue, 26 Dec 2023 11:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618532; x=1704223332; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0O8RtIP4pYk/I1CB5YssfqNJgeBGU8rziw+9z/3E58g=; b=daZFaTYFqt/WrzOwCMvMoKgbfWXuG6+3vxzgIf5CicoDa6eXrcnYfg5UsL6IpWtLd6 Xv6ua7HtD09Ey10qzIEOcrNpz7XmeC6v2rd3IR4/8QVFhc4n/xBOfSYNNlNnmsx6ZQNZ X07CxPnH9YFGd7uFZWBgjfraDqv9ohkJInVj8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618532; x=1704223332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0O8RtIP4pYk/I1CB5YssfqNJgeBGU8rziw+9z/3E58g=; b=vw35crkhtvcnxu+V4J1Rx5bgZzIYSEcYfpysOPGIj8LST8XKUBneNzjujOP2BiRg4p j39qN05yeAnv3PVbmcq6ywNP5F0mHLt54JRtJt882mJfZOnLDkRpK903rS5mv5uUW6ps VxqqPNweBS/uP95VfVP3Oebhnu7pUrS2Ah6NtUxbgfq57P0XowIBt+fleC5qdD8Z8R25 +8kuJigWGz6AsvG8zddHK2EPEAofV1l5PjXZQxgWJoo8UkFkEytuIGQW0LICe+wqJJT2 JEEY339IhJFRkQnHVb4M4jiL4eOkhMRRNkrXwTN6uf9DHyf+HKRPZMvsq6+Ny8AN6hNu dC7Q== X-Gm-Message-State: AOJu0YwQ6QpGRMe9xkxC46Id/ornGo2Zbi7bw3UI/seEyDhVQYmWRwod jwtsVm3r88HOOJbZvO9kqeXmKLCocgxE X-Google-Smtp-Source: AGHT+IEPvjdPgLWnim9CRScF1zgDLSQesNC/8qGs5BHhtwyK/zW05fi43O35+h7z9keU2BUHrJr/5Q== X-Received: by 2002:a05:6e02:1a08:b0:35f:eceb:f845 with SMTP id s8-20020a056e021a0800b0035fecebf845mr4107785ild.8.1703618532594; Tue, 26 Dec 2023 11:22:12 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:12 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 12/24] arm64: dts: mediatek: mt8195: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:16 -0700 Message-ID: <20231226122113.v3.12.Iee33a7f1f991408cef372744199026f936bf54e2@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112213_794594_D99A3BEC X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi index bbdcd441c049d..2edb270d0bc2f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi @@ -1149,6 +1149,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&cros_ec_int>; spi-max-frequency = <3000000>; + wakeup-source; keyboard-backlight { compatible = "google,cros-kbd-led-backlight"; From patchwork Tue Dec 26 19:21:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 13504992 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14F57C4706F for ; Tue, 26 Dec 2023 19:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/eZaJ+40s3LWeYzNZUC5ubTUdvznwi8syO2moJtJ75A=; b=iVhMg3hdutnoUh RJG8EmDm6IZd7hSxCLnFKkCmMnXRdwdI/D5rSnpCub/3oO+1bBRYFV5zjVfAOVZsSAUjm3nHQUsp9 sazyl6/1aMwSwdcPdpa488EPUItMUZb5GlP3MGhUbJPLknm6ejcB975bT9AO7JDeKBAQByNXSWjXJ xAfcmfR+oB4tHyVVjmDk2fIMP3XymBjeBJey+DqE60fdPisRpNP4CwHvWdKtKHGZGoYiEddioYS+C X8qPoDm1wtWpGNmGTcO+nOdq1XexXGoLbiy/svqSc1RrVyelJ4dJhJUDDjwlaCRf6qbAAQi4xvoGm 9DeDAtNZiFCjjUxamNxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rID0x-00DQAX-39; Tue, 26 Dec 2023 19:22:56 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rID0M-00DPoU-0A for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:22:21 +0000 Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-7bb0af58134so4677539f.3 for ; Tue, 26 Dec 2023 11:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703618537; x=1704223337; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JesGzUfVYG0N52lEpA2lp9jd0GztoHz5e+Bd1oSHbfw=; b=iLTjqx1Exbn6ZYUpHWqveO8SJd3ORVZs4sOfEXJhipHbdOPx77hxuwXmeOSHqMENao dVjB0AAV7YBCNCvSmnICdelhVDQbgWJf+gDK46DA8Nqte+WUm+8AufInKNp0YMN2BdIq bXzaEQ0oz4Pk7qhivc6PGLSYjuVgIr8MIAM4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618537; x=1704223337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JesGzUfVYG0N52lEpA2lp9jd0GztoHz5e+Bd1oSHbfw=; b=lrUzBeNspDiJEa/D0r7EHeoi7vx18NSH5wW5SBQGnoaZG9LDOuQ1D5cC6bArv98dgz ZzH3TeXKnDLpZQTLr/pbkLZvQ4dIAo/QtM2RbzXpAEHuaeVuVelBwn+qjEBOwZR5hwDp v/Vft04s+NiEr6VTEz2mrnc3xBvED8sZsK6H/3H3K1u6B14nsHpq47EtRYnijuASUxJ+ 3D9KbIOR5vnrqvJGeXwj7zqAEZDosnvNIjVwENA2s90vjwkcutuidmKbRAvamLzfDpCM h6UD718MUi7/N/n6+I1vZR9T8MJRPhad3RIoyD4NERCYdea17Dfi8ZtR7LvdtDEe/UcV hHUw== X-Gm-Message-State: AOJu0YzmVt5hZYJxijh5Ueh4HOro19nTFL4qcqpk+5BuqjsLv1Kj/R/I f/ynx5UtUF//2ymWjePEIn+lnjMe1LqB X-Google-Smtp-Source: AGHT+IFnfa01wzCJ7D5u8Art1oX5WIoaHFxESiLKFBDqaU10ovAtJY7dB+V8ZDbbIOFqYtTxSN7xWQ== X-Received: by 2002:a5d:9718:0:b0:7ba:b7da:3cd8 with SMTP id h24-20020a5d9718000000b007bab7da3cd8mr8956064iol.17.1703618536940; Tue, 26 Dec 2023 11:22:16 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id gw3-20020a0566381ee300b0046b692e719esm3207609jab.150.2023.12.26.11.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 11:22:16 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Andy Shevchenko , Raul Rangel , Tzung-Bi Shih , Mark Hasemeyer , Conor Dooley , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v3 17/24] arm64: dts: rockchip: rk3399: Enable cros-ec-spi as wake source Date: Tue, 26 Dec 2023 12:21:21 -0700 Message-ID: <20231226122113.v3.17.Ice617703aded22ad4c806459129e1ae693eb57af@changeid> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20231226192149.1830592-1-markhas@chromium.org> References: <20231226192149.1830592-1-markhas@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_112218_137717_2B7AFAA7 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake. Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source. -Commit-changes: 3 -Update commit message to provide details of the motivation behind the change Signed-off-by: Mark Hasemeyer --- (no changes since v2) Changes in v2: -Split by arch/soc arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index 789fd0dcc88ba..b5734e056aef1 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi @@ -603,6 +603,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&ec_ap_int_l>; spi-max-frequency = <3000000>; + wakeup-source; i2c_tunnel: i2c-tunnel { compatible = "google,cros-ec-i2c-tunnel";