From patchwork Fri Dec 29 06:30:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pratikmanvar09@gmail.com X-Patchwork-Id: 13506322 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CEBDC46CD4 for ; Fri, 29 Dec 2023 06:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uzoat3zAYVol+kGSGuYMk7ViWlOKUIVT9yn4h+6zYfs=; b=JGNvRha/BFI6Kz 1yZVeWoF7OpMjQYKAGAGWcA8dJY09JNLBdJ2HeshnEyHrOLsCQNe46HJ9mXMGs2fYVufsY1FqCKEj Y0IjHaANprAzyS0LFzEq2F86mJ6Vz3cwkMjDB3iDNDEhW7vtvtQ3HqjPoDLUMtdj2re7MzR4uKDHt 015N1AudNPGAMQmp58JmQp+N7gYthb0/kpjVqOsCWUwpEgd7R/Z4DiItIcof5CEiyQFNqIHgRhDLh vjPd181GPbvCW5OjHajozv5vf7jbbFuVM+bYO748WsdYr3+uJxJc5zY4GI5UvQ3uhBaBbqzN0RgyO +JI5+6ogok51IQuFWUSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rJ6P4-000Ifb-33; Fri, 29 Dec 2023 06:31:30 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rJ6Oz-000If8-07 for linux-arm-kernel@lists.infradead.org; Fri, 29 Dec 2023 06:31:28 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1d4006b251aso54152565ad.0 for ; Thu, 28 Dec 2023 22:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703831482; x=1704436282; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ls3yrjrYy9eVz9esBcykVo8gEjuUhZ/hfePG/jTt1JE=; b=OtrSk3Fqq0U5GqbRjBpvQnN69cEKNRCWZgdx28fPr1Ei21lx6AsUpOWLI97m3rFVWa t/8cIIq/ruVLR1Vbn1Z3j3XzhSQGdSMS7YLDLHmH4ZgFoDZBlcahxcl7krWX5NxW4g/9 IR4O+KK/gyTRnfL0a/d0Xy9X0AHAVZcBI3EtfdkPdeuATehWd3bLuwPc5DruxVKD7YbF CSyWNtDwL0zl1Mkm1ohw7JUAdpEiBSUIAM6GvJcIKQB0T4ltRagflHUMk0OiRDrm/+NX NOI+ilvsEZQD5MZLCDAhuPVygQmtEJ9Hr/Y4fZEYue/jn2xWTuvLWUibkjtyfClWIVvt luMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703831482; x=1704436282; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ls3yrjrYy9eVz9esBcykVo8gEjuUhZ/hfePG/jTt1JE=; b=hBFcXCiZKab+lAklfDCgbxXP5fQuXw4ZI5BmgtN5jnFDGlRk7AH4TctzhQ48D/RA2W lPZm4YQFIvxKxbYQUnBrvOLB+xt/MdkmcD1eBDu2KURh1q5PLO0ivlcWlBP5+AsKivLh cY+YDloSZMEVbxX/7wO5uoDHEebNC7rpMwmoGLeyxJ0ycSpdmI4avG+0/Sgr1klF9tiM TmfXIanBv5BbviesBGQET+8fWLUTl/nsaqDS0xDrnqNr4x+nTj+wX6G6wi1iHeERLDFA OXh4hn6Z2awE4Cz33vpKRB6GtsCtJQnJgNeM8Pj1PBE1gN1qYE7H9VAN+T810WSaNlz4 1KSw== X-Gm-Message-State: AOJu0YzTYlStPq6r8BpyFu/xVDUuN0gyT0WnjAt9H6Xjv8UDg+3Tg44I 3TPVF7yq6zpD6D4VgkXjGm0= X-Google-Smtp-Source: AGHT+IHR73hXbo8VTreL7pUXsGoZkNaRlHW8GJU+rM6EglxVXZbDVGKRLQrbU0OUMfWwx6xoLXaL4Q== X-Received: by 2002:a17:902:ce91:b0:1cf:f506:c98e with SMTP id f17-20020a170902ce9100b001cff506c98emr13315749plg.16.1703831481535; Thu, 28 Dec 2023 22:31:21 -0800 (PST) Received: from localhost.localdomain ([2402:3a80:87c:f9e1:4c4c:39e1:4807:8b2c]) by smtp.gmail.com with ESMTPSA id jc14-20020a17090325ce00b001d07d83fdd0sm15009499plb.238.2023.12.28.22.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 22:31:21 -0800 (PST) From: pratikmanvar09@gmail.com To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Clark Wang , Jun Li , Pratik Manvar Subject: [PATCH] pwm: imx27: workaround of the pwm output bug Date: Fri, 29 Dec 2023 12:00:07 +0530 Message-ID: <20231229063013.1786-1-pratikmanvar09@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231228_223125_097835_BC6F98AB X-CRM114-Status: GOOD ( 25.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Clark Wang This fixes the pwm output bug when decrease the duty cycle. This is a limited workaround for the PWM IP issue TKT0577206. Root cause: When the SAR FIFO is empty, the new write value will be directly applied to SAR even the current period is not over. If the new SAR value is less than the old one, and the counter is greater than the new SAR value, the current period will not filp the level. This will result in a pulse with a duty cycle of 100%. Workaround: Add an old value SAR write before updating the new duty cycle to SAR. This will keep the new value is always in a not empty fifo, and can be wait to update after a period finished. Limitation: This workaround can only solve this issue when the PWM period is longer than 2us(or <500KHz). Reviewed-by: Jun Li Signed-off-by: Clark Wang Link: https://github.com/nxp-imx/linux-imx/commit/16181cc4eee61d87cbaba0e5a479990507816317 Tested-by: Pratik Manvar --- drivers/pwm/pwm-imx27.c | 67 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 62 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index 29a3089c534c..c21b2a9f02ae 100644 --- a/drivers/pwm/pwm-imx27.c +++ b/drivers/pwm/pwm-imx27.c @@ -21,11 +21,13 @@ #include #include #include +#include #define MX3_PWMCR 0x00 /* PWM Control Register */ #define MX3_PWMSR 0x04 /* PWM Status Register */ #define MX3_PWMSAR 0x0C /* PWM Sample Register */ #define MX3_PWMPR 0x10 /* PWM Period Register */ +#define MX3_PWMCNR 0x14 /* PWM Counter Register */ #define MX3_PWMCR_FWM GENMASK(27, 26) #define MX3_PWMCR_STOPEN BIT(25) @@ -91,6 +93,7 @@ struct pwm_imx27_chip { * value to return in that case. */ unsigned int duty_cycle; + spinlock_t lock; }; #define to_pwm_imx27_chip(chip) container_of(chip, struct pwm_imx27_chip, chip) @@ -203,10 +206,10 @@ static void pwm_imx27_wait_fifo_slot(struct pwm_chip *chip, sr = readl(imx->mmio_base + MX3_PWMSR); fifoav = FIELD_GET(MX3_PWMSR_FIFOAV, sr); - if (fifoav == MX3_PWMSR_FIFOAV_4WORDS) { + if (fifoav >= MX3_PWMSR_FIFOAV_3WORDS) { period_ms = DIV_ROUND_UP_ULL(pwm_get_period(pwm), NSEC_PER_MSEC); - msleep(period_ms); + msleep(period_ms * (fifoav - 2)); sr = readl(imx->mmio_base + MX3_PWMSR); if (fifoav == FIELD_GET(MX3_PWMSR_FIFOAV, sr)) @@ -217,13 +220,15 @@ static void pwm_imx27_wait_fifo_slot(struct pwm_chip *chip, static int pwm_imx27_apply(struct pwm_chip *chip, struct pwm_device *pwm, const struct pwm_state *state) { - unsigned long period_cycles, duty_cycles, prescale; + unsigned long period_cycles, duty_cycles, prescale, counter_check, flags; struct pwm_imx27_chip *imx = to_pwm_imx27_chip(chip); + void __iomem *reg_sar = imx->mmio_base + MX3_PWMSAR; + __force u32 sar_last, sar_current; struct pwm_state cstate; unsigned long long c; unsigned long long clkrate; int ret; - u32 cr; + u32 cr, timeout = 1000; pwm_get_state(pwm, &cstate); @@ -264,7 +269,57 @@ static int pwm_imx27_apply(struct pwm_chip *chip, struct pwm_device *pwm, pwm_imx27_sw_reset(chip); } - writel(duty_cycles, imx->mmio_base + MX3_PWMSAR); + /* + * This is a limited workaround. When the SAR FIFO is empty, the new + * write value will be directly applied to SAR even the current period + * is not over. + * If the new SAR value is less than the old one, and the counter is + * greater than the new SAR value, the current period will not filp + * the level. This will result in a pulse with a duty cycle of 100%. + * So, writing the current value of the SAR to SAR here before updating + * the new SAR value can avoid this issue. + * + * Add a spin lock and turn off the interrupt to ensure that the + * real-time performance can be guaranteed as much as possible when + * operating the following operations. + * + * 1. Add a threshold of 1.5us. If the time T between the read current + * count value CNR and the end of the cycle is less than 1.5us, wait + * for T to be longer than 1.5us before updating the SAR register. + * This is to avoid the situation that when the first SAR is written, + * the current cycle just ends and the SAR FIFO that just be written + * is emptied again. + * + * 2. Use __raw_writel() to minimize the interval between two writes to + * the SAR register to increase the fastest pwm frequency supported. + * + * When the PWM period is longer than 2us(or <500KHz), this workaround + * can solve this problem. + */ + if (duty_cycles < imx->duty_cycle) { + c = clkrate * 1500; + do_div(c, NSEC_PER_SEC); + counter_check = c; + sar_last = cpu_to_le32(imx->duty_cycle); + sar_current = cpu_to_le32(duty_cycles); + + spin_lock_irqsave(&imx->lock, flags); + if (state->period >= 2000) { + while ((period_cycles - + readl_relaxed(imx->mmio_base + MX3_PWMCNR)) + < counter_check) { + if (!--timeout) + break; + }; + } + if (!(MX3_PWMSR_FIFOAV & + readl_relaxed(imx->mmio_base + MX3_PWMSR))) + __raw_writel(sar_last, reg_sar); + __raw_writel(sar_current, reg_sar); + spin_unlock_irqrestore(&imx->lock, flags); + } else + writel(duty_cycles, imx->mmio_base + MX3_PWMSAR); + writel(period_cycles, imx->mmio_base + MX3_PWMPR); /* @@ -325,6 +380,8 @@ static int pwm_imx27_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_per), "failed to get peripheral clock\n"); + spin_lock_init(&imx->lock); + imx->duty_cycle = 0; imx->chip.ops = &pwm_imx27_ops; imx->chip.dev = &pdev->dev; imx->chip.npwm = 1;