From patchwork Mon Jan 1 21:00:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13508719 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3C34DF49; Mon, 1 Jan 2024 21:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WK37HL4r" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ccbbb5eb77so66940541fa.2; Mon, 01 Jan 2024 13:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704142823; x=1704747623; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G+XZ4nybj4bZroxHF/K5QreEHMx55uD+jWsZAAJ9ETE=; b=WK37HL4r+gTQvY23IpoSw+hKZ4lvn4bNDnbu99ofb3udtT3rqRmrQWL70Xpq5NLf2j 1nIE2G0EeM52a9oS5VcHqqkIeiHsLzFVyy8Slvh4MQF12qb2sRCUlZrBPd7o0qq1qeFw XvYwESLG7xycaGEMjwtWAAecxcjf5RMdSXE3FA+21BcVaPqygakRI1KyqtszlT5rbOf+ 9ou+ZWY7rwsnajKKWObHdpUaf6lzpEMNpLYdfkx/Q79D57Y5ItbULlRHPdxo9AmQKtBX TgpufY8w1vEwJm/bP/6xE1vl94Y69146xpslKYDaK45pe0AA+TeR3YoDjJHLRiaoCqSm 7Jvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704142823; x=1704747623; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G+XZ4nybj4bZroxHF/K5QreEHMx55uD+jWsZAAJ9ETE=; b=NaxbANyOKtFcp2XgQrJ3QArywmoMj/4h64Y/J7IOMccW4B2ZKicrB3NMfP+0IaVcRo oEvCamSDLRDNF+X1A9+2tXRyzbvStSEdRU2V8mTpCWELsBRU1Ej2tOSl4BpfPymIs4Ab NR13Txyd2WB/YVTi1gUaRFTVbsYnTNaIouTw0tYpw+F4hrVj+tpjk2erthucdSuuukUl zUJlnkOKb62XZ4qTL9zTU2gYKodlTgUylGKKWxaA2N2pXL/T3YVdAZYV1DEVofPJd/0i eTb5UOvQYK/27oJhqKYlhpM7HlZzDJXX25wrtDdr6X8thozPgwfHF7iihz3rNT02/Yz8 A+OQ== X-Gm-Message-State: AOJu0YznA9OqZM7PGtXoLH/xkTMSO9ICtQfi6d3fZxdYstfL9Cwf5+Ww PTYYvnlp6IFJDo855fls3TA= X-Google-Smtp-Source: AGHT+IEyt54Orz1g1iSdDIT58gjh8S+dJZUEQWPhmkpP2Zw9GRBQBsp4FnO+/E+W4japXdG6IOsJrg== X-Received: by 2002:a2e:a229:0:b0:2cc:df75:79b3 with SMTP id i9-20020a2ea229000000b002ccdf7579b3mr3727095ljm.12.1704142822801; Mon, 01 Jan 2024 13:00:22 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id i15-20020a05640200cf00b0055404e08589sm15122045edu.85.2024.01.01.13.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 13:00:22 -0800 (PST) From: Artur Weber Date: Mon, 01 Jan 2024 22:00:15 +0100 Subject: [PATCH 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240101-tab3-display-fixes-v1-1-887ba4dbd16b@gmail.com> References: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> In-Reply-To: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704142819; l=781; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=kgQ6hReH0wzI/acEF9QXTsrDq3bCAXF+wc7FhUZWg+4=; b=7ohf2QoqecR3WiauAHzQUR3+ckbuzk8rHVISPaWwZek5KfK2snxhjEVFaYXEd/XhZKmMWgcbW mL7cAAnGc+uCDAIE86dOdGOy9C0Y9j499m3IgkJ5UnsF480rkJKSsaU X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= After more investigation, I've found that it's not the panel driver config that needs to be modified to invert the data polarity, but the FIMD config. Add the missing invert-vclk option that is required to get the display to work correctly. Signed-off-by: Artur Weber --- arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index d7954ff466b4..e5254e32aa8f 100644 --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi @@ -434,6 +434,7 @@ &exynos_usbphy { }; &fimd { + samsung,invert-vclk; status = "okay"; }; From patchwork Mon Jan 1 21:00:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13508720 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB9E9E57E; Mon, 1 Jan 2024 21:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f15NnXGY" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50e72e3d435so6359302e87.2; Mon, 01 Jan 2024 13:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704142824; x=1704747624; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZKO7t2hG9wQZbOuOZ2OBdmSsh90rgqQlCZCF6Y6YFcg=; b=f15NnXGY2amTPPRVFmkx73O2jPiSy5A0/x6aY9zqj5tsmdb/sC6s+o3MBCTtjkaSN9 y3e/Pwm9/mGeipR5sGBBZp7xIyekzoW5IrLJ9cCMKkNeVOiIdtN959DoDkXapiOt2p8w 2s2ndjJe0wHBbvvS857oLsxS6ElJfDqfckY68aK460nBMYvcIUCBbBWt4FSz10fJFF7T myl7sgBWQb/qui+2GiESmwwWJGZH5cFWct4ollcRfm/y+XlJz0sIs6chpiHjZ843vDgv wNv8ee40/8CB0CmzkQV2UJn5rSoMvEYcXgdR7SP2ON7n34HkG/XkaibJl+dUSo5P99Do C1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704142824; x=1704747624; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZKO7t2hG9wQZbOuOZ2OBdmSsh90rgqQlCZCF6Y6YFcg=; b=HFrsanv+B5rgk0j2t6FMOaI6Yqx6Gg2dBclEY6ZyDKUxpt79xGbhOHCArRwjAzM7fG GwSWl97yhdXkYwdl+vX5ea854ySCPducuuZzkoirD+/rquuiq0Mtu3nfQ5tTrS8fFLD+ 5kniih7d8RpRWWOjyMLDJBvHMQ7+F/vcss4W0ARddgl06iSj/ks6gbAJoHMp8zyy1Um7 BTlaAHlGJY+38eHVdoPWa5J3zE3vDyXf/V+spH9wuCDQohIu0UOOBpXVTSDZ4bhi4X9i G2I+FTKOBPi4x8lCHU2k0gBPvo23KEKPZx0OGptK3qxCA4w7aQBg/I1y13w9OAsQXlQn V9og== X-Gm-Message-State: AOJu0YwgbFaWHTnlSZQUM+Y4lFt4YekrlXh/hH2ukLELjJLs64qfTmaf n5iWFeRcIjTkJbdMq51LmFI= X-Google-Smtp-Source: AGHT+IE86fSR+lttAonljpboKktMB8Ji41vcG9rV4MNjyxOno5Zp8U6svFT8fnkFNZxZ561m0wvtBA== X-Received: by 2002:a05:6512:33d5:b0:50e:7e1c:9049 with SMTP id d21-20020a05651233d500b0050e7e1c9049mr4083434lfg.70.1704142824646; Mon, 01 Jan 2024 13:00:24 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id i15-20020a05640200cf00b0055404e08589sm15122045edu.85.2024.01.01.13.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 13:00:23 -0800 (PST) From: Artur Weber Date: Mon, 01 Jan 2024 22:00:16 +0100 Subject: [PATCH 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02 Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240101-tab3-display-fixes-v1-2-887ba4dbd16b@gmail.com> References: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> In-Reply-To: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704142819; l=1047; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=pg28sLvX5GdC5bOF/yyzGASGCCoIgKs1qHIpKvHG7pQ=; b=V1bj5lEkTVkRcuqmS/0vog/IRKcLOnQ/VyKrfKyWkMBtEXBwTIYRhz1D8Isd2VzvjtsLbDXb0 DvkWU1R5FlRBed5qaJ/SpcpwyEMKCETBnjzMpeIDR9/2JAqKyROVfsf X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Signed-off-by: Artur Weber Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c index ea5a85779382..f23d8832a1ad 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { .off_func = s6d7aa0_lsl080al02_off, .drm_mode = &s6d7aa0_lsl080al02_mode, .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, - .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .bus_flags = 0, .has_backlight = false, .use_passwd3 = false,