From patchwork Mon Feb 18 02:08:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shengjiu Wang X-Patchwork-Id: 10817431 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0C08922 for ; Mon, 18 Feb 2019 08:04:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9FCF2522B for ; Mon, 18 Feb 2019 08:04:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B93512A180; Mon, 18 Feb 2019 08:04:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A97662A175 for ; Mon, 18 Feb 2019 08:04:06 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A3042267488; Mon, 18 Feb 2019 09:04:05 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 36E6E2674C9; Mon, 18 Feb 2019 09:04:03 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140052.outbound.protection.outlook.com [40.107.14.52]) by alsa0.perex.cz (Postfix) with ESMTP id 07F0B267495 for ; Mon, 18 Feb 2019 09:03:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+iQlMXXjIvloclGzWosZB9XBmOnE23A7TU25Ts488XM=; b=vnxAbPEB0c/WiQSU37eISluS1Zh/Eypj00plYy2gz801OkII5y6/UJOz9zH3usARZwbrelNV47JdQqk06ImdOTvsnKNoYspb2IllKkibFZL9EQkku4jWNTKCpZeXGvmjfI2bDki9LBYrq9fop8+p0RU7iMZq8MyMM+fE4HU9dII= Received: from AM0PR0402MB3379.eurprd04.prod.outlook.com (52.133.45.12) by AM0PR0402MB3698.eurprd04.prod.outlook.com (52.133.38.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.16; Mon, 18 Feb 2019 02:08:52 +0000 Received: from AM0PR0402MB3379.eurprd04.prod.outlook.com ([fe80::d41a:d251:f86b:d114]) by AM0PR0402MB3379.eurprd04.prod.outlook.com ([fe80::d41a:d251:f86b:d114%2]) with mapi id 15.20.1622.018; Mon, 18 Feb 2019 02:08:52 +0000 From: "S.j. Wang" To: "timur@kernel.org" , "nicoleotsuka@gmail.com" , "Xiubo.Lee@gmail.com" , "festevam@gmail.com" , "broonie@kernel.org" , "alsa-devel@alsa-project.org" Thread-Topic: [PATCH V2] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode Thread-Index: AQHUxy7krEjmtZwkZU2ieefZbngvWg== Date: Mon, 18 Feb 2019 02:08:52 +0000 Message-ID: <2a1997c2cd213ebfde70a2b325644de51e77d159.1550455620.git.shengjiu.wang@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 1.9.1 x-clientproxiedby: HK0PR03CA0006.apcprd03.prod.outlook.com (2603:1096:203:2e::18) To AM0PR0402MB3379.eurprd04.prod.outlook.com (2603:10a6:208:1a::12) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shengjiu.wang@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 035676a0-7de4-4ec1-bf16-08d69546073c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR0402MB3698; x-ms-traffictypediagnostic: AM0PR0402MB3698: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR0402MB3698; 23:vF5Y1aQwz4s1xzse9daAupH2zbaMEmyk5htJH?= =?iso-8859-1?q?PlMza7ne6gTu3J9Lb?= =?iso-8859-1?q?uvnS4fJOyh4JkXvmQO9PsKV1T6IhNTKoKynyfp1MNgGs2PpmWG1pijCzcVCN?= =?iso-8859-1?q?zOkD598TkdZwrsTgzNaki4fOp1GW3+xcnIidSJ9pf9bczfWGS4Usm/oYYRiX?= =?iso-8859-1?q?lAnneBQjuiyArL3vXqkeu2lT4Acnlfuwo8SCh3wfKyvIrL89+8KK01ft/KtM?= =?iso-8859-1?q?OfzvpEP7L/9r8NsULxgN91uAXi6tFXLT/k0SjBjrKsWRQUIhQxfJoDP15NbB?= =?iso-8859-1?q?kFth+9074AxJClApmkIOMUsu1YOA0h4I/07N2WZfRRNRuW7ekWTKh8IZxum9?= =?iso-8859-1?q?XTrChB6cx2DpzzV30fkXjHZ8H8ayhNz6d4bWigAaptqPc6GgY0K8kJOa/+zX?= =?iso-8859-1?q?0h17a9kUQZ7iOKGcAEeEbmKTr1LbON+Ep19jjWKTvCulK8BeK91tDANQj9e6?= =?iso-8859-1?q?VSUm2yZmYiDW1Jv3n+864+ErllEzsJ5ai4bQtUFDebNU7oA13FbO8X5KiaoS?= =?iso-8859-1?q?Uu23DdpdFfZD25QLEjHstQv09gmNS+fQiWsXSketqKSqb1b2VcrFnPZFpl83?= =?iso-8859-1?q?9glDdUpgkBBWaE6gMG95CkPgPEcNV7ZhQU+3dHtFNZP7RGtHk/pFO4V+GoT8?= =?iso-8859-1?q?TRsDtf8xqik+84BkLZ7ySOPgTMhe57WnTm80uZX9STZDUffdzQbdzuVeyE96?= =?iso-8859-1?q?Ch4LOnMXUGaiiI7k59BPS8au1z/ZE1Ydyoauk1OWlGjWbTtKadHhVYRdCeds?= =?iso-8859-1?q?p08l8lc5CR+N6RBgpzhu/3LUvdy724XL4XrLNfx4ielonBJsiHPFKmKsySQ2?= =?iso-8859-1?q?aWSLAj+MlWLE0IiOwZJhq1NFhLnK3eWxibzJWQESnqH/XjW9uT+NaqrjOHPg?= =?iso-8859-1?q?i3tUvNvYCuCevkh3by0WubLQw/aggoY8jac4oy/gcgQxgYWFk3yf7h5dd9HV?= =?iso-8859-1?q?UNsfBseZfLfAvvVw3E1+Cpcb+kWDIpJrQS8kCaMCbooC03cc9De47jeTKufk?= =?iso-8859-1?q?LgheLzQAlk7HXb5PmFERzJb4YCvw0+y4nW8hAziWXRKfXaXZW5+ST3VdWXwE?= =?iso-8859-1?q?SKU+1NLWCub/huUAadHFeSBp7IuoHjjYeXK+qqvbGfQLT6HzZzM6ZJzIn6vR?= =?iso-8859-1?q?W4Jv2ixuCL3KQTLNQka8M+XTt/ChvL0Ga5yr6f4KCmmma9lK6JUk1IOICUnK?= =?iso-8859-1?q?w1+NE/e7Peeum7ja89kY2T?= x-microsoft-antispam-prvs: x-forefront-prvs: 09525C61DB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(396003)(136003)(376002)(39860400002)(199004)(189003)(105586002)(6436002)(6486002)(86362001)(102836004)(66066001)(186003)(25786009)(97736004)(6512007)(478600001)(2616005)(476003)(8676002)(8936002)(81166006)(2201001)(81156014)(305945005)(106356001)(68736007)(53936002)(26005)(50226002)(52116002)(99286004)(486006)(316002)(36756003)(54906003)(6116002)(7736002)(3846002)(2906002)(5660300002)(14444005)(71200400001)(110136005)(71190400001)(386003)(6506007)(4326008)(14454004)(118296001)(2501003)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0402MB3698; H:AM0PR0402MB3379.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: j3K+JReCXYJmdA3pGKOmE57TvZpPS0u0WF/5PI+qtZuT3SF6EkEBMMPB3UfU0xicpV2YBPUuKSKQUj41pqlHJfHAz8OuDtPScHxlh6QVNfAXUfxsz9EslplZTCLToXweTz4MSG1y3fh57wOlQJS2S6ohFPrsflgkYThzP4FUEPeAVxMMP6OjkwsVlupVKFGQv+6sHc1onvL8T0kjajkoFCVXIUyavoD2IBtbxl0RfeQBxJQjgvEjj1la97bXoObeajBTvKmYT5Q2s9fuG8hOtjcspaVmAisEqIcsobkaybsD/1m1kgTDoOB2khTbxlSyz/LMKfZRGm0cfwMLimQHwMavbZUDrnrRplw9OjMPuuLu2BJ0kbtNEKHGKBD1v14wytX598VOe6YuJd0QO/LaXxC5goswm3x4XsLxV9iDO5o= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 035676a0-7de4-4ec1-bf16-08d69546073c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2019 02:08:49.1624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3698 Cc: "linuxppc-dev@lists.ozlabs.org" , "stable@vger.kernel.org" Subject: [alsa-devel] [PATCH V2] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes commit 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to wrong register, correct it. Signed-off-by: Shengjiu Wang Reviewed-by: Fabio Estevam Ackedy-by: Nicolin Chen --- Changes in v2 - add Fixes tag and cc stable kernel. sound/soc/fsl/fsl_esai.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 57b484768a58..afe67c865330 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -398,7 +398,8 @@ static int fsl_esai_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) break; case SND_SOC_DAIFMT_RIGHT_J: /* Data on rising edge of bclk, frame high, right aligned */ - xccr |= ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP | ESAI_xCR_xWA; + xccr |= ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP; + xcr |= ESAI_xCR_xWA; break; case SND_SOC_DAIFMT_DSP_A: /* Data on rising edge of bclk, frame high, 1clk before data */ @@ -455,12 +456,12 @@ static int fsl_esai_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } - mask = ESAI_xCR_xFSL | ESAI_xCR_xFSR; + mask = ESAI_xCR_xFSL | ESAI_xCR_xFSR | ESAI_xCR_xWA; regmap_update_bits(esai_priv->regmap, REG_ESAI_TCR, mask, xcr); regmap_update_bits(esai_priv->regmap, REG_ESAI_RCR, mask, xcr); mask = ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP | ESAI_xCCR_xFSP | - ESAI_xCCR_xFSD | ESAI_xCCR_xCKD | ESAI_xCR_xWA; + ESAI_xCCR_xFSD | ESAI_xCCR_xCKD; regmap_update_bits(esai_priv->regmap, REG_ESAI_TCCR, mask, xccr); regmap_update_bits(esai_priv->regmap, REG_ESAI_RCCR, mask, xccr);