From patchwork Tue Jan 9 07:56:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13514390 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D825224FC; Tue, 9 Jan 2024 07:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pYDd13yT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E61DBC43390; Tue, 9 Jan 2024 07:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704787024; bh=osEjPHFSBRRETsdDQv26/OIMeyS5BBWg439/b7Ob4A8=; h=From:To:Cc:Subject:Date:From; b=pYDd13yTLCtkfqQoESXCMcWnOzWulKNk0gNlddCa0aVZUdp73YdTPb6zOa+NDYu1U wk2QrfUSBUKYmJwDUkE4hZqOPiU4drhPMeWxRInBVCN3gGpEw3ciEFBE4eZPyhuz+t 5WPB7o7I+QxEc8szDmNMOYcylAEOHfuPQ10YKp2Kj0a1znltyenmmV10G5PDlnlTsh /By3rMemiSg4sqV1FMX8O68Q1wbv0HZUCQ5TV3GuTTzTGncFjtQCKyQ+ibFpU9LMPg S6XzseCo2sbnJU0JJFJVEAbT3dHoVSXz602LCHPpGksRYIx7bbxbZQXHT2th40jGKN b5f99I1NdcA3w== From: Arnd Bergmann To: Jiawen Wu , Mengyuan Lou , Jakub Kicinski Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , Andrew Lunn , Maciej Fijalkowski , Andy Shevchenko , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wangxunx: select CONFIG_PHYLINK where needed Date: Tue, 9 Jan 2024 08:56:21 +0100 Message-Id: <20240109075656.2656359-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Arnd Bergmann The ngbe driver needs phylink: arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset': wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove': ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open': ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init': ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create' Add the missing Kconfig description for this. Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink") Signed-off-by: Arnd Bergmann Reviewed-by: Jiawen Wu --- drivers/net/ethernet/wangxun/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig index 23cd610bd376..46630f05d8dd 100644 --- a/drivers/net/ethernet/wangxun/Kconfig +++ b/drivers/net/ethernet/wangxun/Kconfig @@ -26,6 +26,7 @@ config NGBE tristate "Wangxun(R) GbE PCI Express adapters support" depends on PCI select LIBWX + select PHYLINK select PHYLIB help This driver supports Wangxun(R) GbE PCI Express family of