From patchwork Wed Jan 10 15:37:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ceclan, Dumitru" X-Patchwork-Id: 13516277 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DFE4C3AA; Wed, 10 Jan 2024 15:38:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eXmSLf1K" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3368d1c7b23so3950247f8f.0; Wed, 10 Jan 2024 07:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704901084; x=1705505884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wi4dOBb6Axd3K1La6gwJO0i7zhXXojoDHVTLnsVvmuc=; b=eXmSLf1KhC6+qaALLR6dhmVAz8jE22SGRfsme7bDG8rkEsu+zP/lP2fSNmZeXI3Li6 4XtKEFBqFTdowONOQyttLHHSngO1eVv8AmHRyy6RDObKEzeol3gmIRQjE3nXjppZ00KK Q6h17bEuHqGAt5ho5KBmA8jO8CzcY9claSJyi4jEJ3bv+ASw+scOZ4ENAg1njSp0wgQ6 6OmZfdZiGuLo6Nyu2QIZOGdfvHRYElgI9UlY9f22HKXWL3WRNz2jLm5OaE0K9RspoxVW D1pFTOBJukkklnGan6vqcMOXYiGGaY2wupVNaWxgHm0uKAYp0XVIdbl5hSDqHxM9+VsZ RS2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704901084; x=1705505884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wi4dOBb6Axd3K1La6gwJO0i7zhXXojoDHVTLnsVvmuc=; b=WEyS/KZxJGzi+9VIQelaw9zSU+V6HNCfUofgaQUbVWB9aMN6CGG07CyrzZyV9LDzwA 3rvbbpN0oTMjiDKMNOaYZUv2vqzN/hP1wQhQH4+6Rl2yapj69OMJf7GmK2uR3hANsCfE oBhuLw56yyXQWqBgbDuTxHhWGJhq1sgUb3BObcgrdESQKSOtw8XpKx6EDkmyzIYBneMX jj84CTPZPirew6vUdnG43dAzQU7/yIa88eaf71SCdfGGyOawUKTRIxMpWAyajVghdWID oZQl5OIg2RX5++nRA0C/oGFUeWWyZzoC8SSkHYrLgfYyLgZI1tQ1JmWUww2G39Z3nylN jN0A== X-Gm-Message-State: AOJu0YzFt+vSm5THKYMKRrVUnv6x9hkXShl7/XkC/HfckGbBYDt8lXEH W0NrdyCvPPrd/VM/h8QRAbc= X-Google-Smtp-Source: AGHT+IGEKVKhMT8VoltD6U+QHciCX9rfJpoTZz8Q4SWLuKZrlBxGN91+AVrqJP1rrGO+408P9WoaOQ== X-Received: by 2002:adf:e750:0:b0:336:9c9b:a9f7 with SMTP id c16-20020adfe750000000b003369c9ba9f7mr654020wrn.4.1704901084483; Wed, 10 Jan 2024 07:38:04 -0800 (PST) Received: from HYB-hhAwRlzzMZb.ad.analog.com ([86.125.72.218]) by smtp.gmail.com with ESMTPSA id e30-20020a5d595e000000b0033776a50472sm4179907wri.10.2024.01.10.07.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:38:04 -0800 (PST) From: Dumitru Ceclan To: Cc: Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ceclan Dumitru , Dumitru Ceclan Subject: [PATCH v2 1/4] dt-bindings: iio: hmc425a: add conditional GPIO array size constraints Date: Wed, 10 Jan 2024 17:37:09 +0200 Message-ID: <20240110153757.5754-2-mitrutzceclan@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240110153757.5754-1-mitrutzceclan@gmail.com> References: <20240110153757.5754-1-mitrutzceclan@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 ADRF5740 and HMC540S have a 4 bit parallel interface. Update ctr-gpios description and min/maxItems values depending on the matched compatible to correctly reflect the hardware properties. Signed-off-by: Dumitru Ceclan Acked-by: Conor Dooley Acked-by: Conor Dooley --- .../bindings/iio/amplifiers/adi,hmc425a.yaml | 33 +++++++++++++++++-- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml index 67de9d4e3a1d..a434cb8ddcc9 100644 --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml @@ -33,11 +33,38 @@ properties: ctrl-gpios: description: - Must contain an array of 6 GPIO specifiers, referring to the GPIO pins - connected to the control pins V1-V6. - minItems: 6 + Must contain an array of GPIO specifiers, referring to the GPIO pins + connected to the control pins. + ADRF5740 - 4 GPIO connected to D2-D5 + HMC540S - 4 GPIO connected to V1-V4 + HMC425A - 6 GPIO connected to V1-V6 + minItems: 1 maxItems: 6 +allOf: + - if: + properties: + compatible: + contains: + const: adi,hmc425a + then: + properties: + ctrl-gpios: + minItems: 6 + maxItems: 6 + - if: + properties: + compatible: + contains: + anyOf: + - const: adi,adrf5740 + - const: adi,hmc540s + then: + properties: + ctrl-gpios: + minItems: 4 + maxItems: 4 + required: - compatible - ctrl-gpios From patchwork Wed Jan 10 15:37:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ceclan, Dumitru" X-Patchwork-Id: 13516278 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2D444CB33; Wed, 10 Jan 2024 15:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nYpg6nSr" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3376d424a79so2654764f8f.1; Wed, 10 Jan 2024 07:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704901086; x=1705505886; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HU7PZJBE6Sseq9pTkM57wZJByEMMVutTUH+OD/JSNY0=; b=nYpg6nSr05fmnppjJ+7y16mhAZT6qDg1YULMecpbIZGU8H4looSu9BnpB8ODb7D1w4 EjS7qq5azrj9voMqXgUAEmNuByHQSIFX6XDLzFysGMAJmX11SaFO727Xvv6maUoPVias /Ss2s+mh+G43HdY4DolW+goaEjfMKpFKaxnt+GlYAKezKauK6goiCJbEzHuKU2nVonKn gXtRV9PGf/xlAb5nm5MQF+S4LoNe8vGSNaEvZhIHr/B8dvHx4IJ1ZBHeIH0R3KX7ABSk Wxob2crEx+e954DfAYDeM9FDmvBv1jWBGx2WcXFtj4x2OsmddH44JGz3aq/87LRORnjw 8kwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704901086; x=1705505886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HU7PZJBE6Sseq9pTkM57wZJByEMMVutTUH+OD/JSNY0=; b=cL38gwUkmcYXyadwd2wijCtaJjncbWwLCNjV/ySRKldGmj4x7JPlJtfOuLR4NdDICb Hx+Ok4k5B81mo0I/Zl+b2XgHQ+fhoWAOyjr+zoA1AiNmUXGUyi9aIHfqPOFmT0N544Bx l8dMY5BCYQjpAwHsMFxZPswOEV9OI2/7QYq/gBr74brHGCDO4HatFN7Eg2KFPUkiMOLs JbFT19buQw5L25VDqRG2VpD/Eztd5sSRQzG1XREdu3aI5FRlDDSorOePkJX5I1WeIjHO BC8AC9wV0dbz6fk4GzcwBOXtOYXQ4ferFUPtysbr9tFeJsm/bccdXLzacTKujvtXgar7 qOYA== X-Gm-Message-State: AOJu0YyJ1bBpJuJrGFNVWBWzeRdKK+ymHTCeGWwpXLcGoxnWUeUfxhvA cw7n9vlQiVRbsAiPnJuTczk= X-Google-Smtp-Source: AGHT+IGaZi4NmK/WhibLzOFBizcbJ2jZKTk/kN4W4RsX7/+aT7kmh7jzKjhuBwzsQJUmLsMypEBZFA== X-Received: by 2002:a05:6000:912:b0:336:614b:5326 with SMTP id cw18-20020a056000091200b00336614b5326mr748221wrb.82.1704901085667; Wed, 10 Jan 2024 07:38:05 -0800 (PST) Received: from HYB-hhAwRlzzMZb.ad.analog.com ([86.125.72.218]) by smtp.gmail.com with ESMTPSA id e30-20020a5d595e000000b0033776a50472sm4179907wri.10.2024.01.10.07.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:38:05 -0800 (PST) From: Dumitru Ceclan To: Cc: Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ceclan Dumitru , Dumitru Ceclan Subject: [PATCH v2 2/4] dt-bindings: iio: hmc425a: add entry for LTC6373 Date: Wed, 10 Jan 2024 17:37:10 +0200 Message-ID: <20240110153757.5754-3-mitrutzceclan@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240110153757.5754-1-mitrutzceclan@gmail.com> References: <20240110153757.5754-1-mitrutzceclan@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The LTC6373 is a silicon, 3-bit Fully-Differential digital instrumentation amplifier that supports the following programmable gains (Vout/Vin): G = 0.25, 0.5, 1, 2, 4, 8, 16 + Shutdown. Signed-off-by: Dumitru Ceclan Acked-by: Conor Dooley --- .../bindings/iio/amplifiers/adi,hmc425a.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml index a434cb8ddcc9..3a470459b965 100644 --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml @@ -21,6 +21,8 @@ description: | HMC540S 1 dB LSB Silicon MMIC 4-Bit Digital Positive Control Attenuator, 0.1 - 8 GHz https://www.analog.com/media/en/technical-documentation/data-sheets/hmc540s.pdf + LTC6373 is a 3-Bit precision instrumentation amplifier with fully differential outputs + https://www.analog.com/media/en/technical-documentation/data-sheets/ltc6373.pdf properties: compatible: @@ -28,6 +30,7 @@ properties: - adi,adrf5740 - adi,hmc425a - adi,hmc540s + - adi,ltc6373 vcc-supply: true @@ -38,6 +41,7 @@ properties: ADRF5740 - 4 GPIO connected to D2-D5 HMC540S - 4 GPIO connected to V1-V4 HMC425A - 6 GPIO connected to V1-V6 + LTC6373 - 3 GPIO connected to A0-A2 minItems: 1 maxItems: 6 @@ -64,6 +68,16 @@ allOf: ctrl-gpios: minItems: 4 maxItems: 4 + - if: + properties: + compatible: + contains: + const: adi,ltc6373 + then: + properties: + ctrl-gpios: + minItems: 3 + maxItems: 3 required: - compatible From patchwork Wed Jan 10 15:37:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ceclan, Dumitru" X-Patchwork-Id: 13516279 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 149DA4CB2E; Wed, 10 Jan 2024 15:38:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fAb1HznO" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-33694bf8835so3651398f8f.3; Wed, 10 Jan 2024 07:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704901087; x=1705505887; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z0/TYd/8rVyUf11DYs46AxL5K7um2W7Rvs+jbNKoDFo=; b=fAb1HznOPJ/GJdfbCg43IEkSKbemVgE4hmw7GoxTqTPxetdFwu2yXLuNEee6HlFPCu 6S+5jkyP2kxyUDlg2CYs3CLVdn4/0zjZoY8PuThHgWhaY+7A5KsP6p2AM9ovoJIW4Xy9 +SUqEUOuXRacG7AtXwRyJUA6YJEnn9QvzhWBKLFLmmr91P57FUqZ4JGoxox2IyeiYUyK /t7gykykgFnOSDxbJAwKpR3nlFByCErepPdWicO0zd7ARNmURj2h480btqSTVTbFjvra 8Ae4zQC1U3NTHVzRmmzH5DDNn+rdOEk2jz1K9OhDthLJo17bDg9EYgf3tzFOHXcqbQMG D67g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704901087; x=1705505887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z0/TYd/8rVyUf11DYs46AxL5K7um2W7Rvs+jbNKoDFo=; b=Pav2CLKgz73D7x0hdxQfP03tzQC17VCONEq4/03LhpVUpoalF5ElDoqDYJMzPLI8yZ AATC12eIeibBOLpXd9EU//VMUUBzsjdLbNPiOLawzpZb1Tg2+CDUCfBy6qCHuSrQF+wA SmPhAh4N9KWf9dWNi9nAIb2JH6y92/kYHBccQ4SntD1J05wOG3OEYHjEMuKpNQokzhew aThaG/EAgymY/l2djxWKhXtkNg9jpEyQu7oAQx5RNs3/S/NjWysoXLfLLd+zI9gxaYtF ZjdN2h2Tct0LESWKilkqQ/r7RxOQyiOdUhdZntfQmo7xmUvBl+lX2ASCBgCz2pMInDav nqPw== X-Gm-Message-State: AOJu0Ywp0faarNeHy7BBTyNrHaPoFhbcwD5uYZY8mNhpz/jSzjg6OOn9 Ubimuq8z9KhYKWFjXtS5ppk= X-Google-Smtp-Source: AGHT+IFqvQsL+DTp2axD0PBfim+O6DZbpg//OkpBTPX6uGG1RloTjz+kw0cRTCOjXfk5+c8qzaJktQ== X-Received: by 2002:a5d:498e:0:b0:336:7754:6909 with SMTP id r14-20020a5d498e000000b0033677546909mr642344wrq.111.1704901087033; Wed, 10 Jan 2024 07:38:07 -0800 (PST) Received: from HYB-hhAwRlzzMZb.ad.analog.com ([86.125.72.218]) by smtp.gmail.com with ESMTPSA id e30-20020a5d595e000000b0033776a50472sm4179907wri.10.2024.01.10.07.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:38:06 -0800 (PST) From: Dumitru Ceclan To: Cc: Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ceclan Dumitru , Dumitru Ceclan Subject: [PATCH v2 3/4] iio: amplifiers: hmc425a: move conversion logic Date: Wed, 10 Jan 2024 17:37:11 +0200 Message-ID: <20240110153757.5754-4-mitrutzceclan@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240110153757.5754-1-mitrutzceclan@gmail.com> References: <20240110153757.5754-1-mitrutzceclan@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Move gain-dB<->code conversion logic from read_raw and write_raw to hmc425a_gain_dB_to_code() and hmc425a_code_to_gain_dB(). Signed-off-by: Dumitru Ceclan --- drivers/iio/amplifiers/hmc425a.c | 100 ++++++++++++++++++------------- 1 file changed, 57 insertions(+), 43 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index ed4d72922696..b5fd19403d15 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -56,35 +56,70 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) return 0; } +static int hmc425a_gain_dB_to_code(struct hmc425a_state *st, int val, int val2, int *code) +{ + struct hmc425a_chip_info *inf = st->chip_info; + int gain, temp; + + if (val < 0) + gain = (val * 1000) - (val2 / 1000); + else + gain = (val * 1000) + (val2 / 1000); + + if (gain > inf->gain_max || gain < inf->gain_min) + return -EINVAL; + + switch (st->type) { + case ID_HMC425A: + *code = ~((abs(gain) / 500) & 0x3F); + break; + case ID_HMC540S: + *code = ~((abs(gain) / 1000) & 0xF); + break; + case ID_ADRF5740: + temp = (abs(gain) / 2000) & 0xF; + *code = temp & BIT(3) ? temp | BIT(2) : temp; + break; + } + return 0; +} + +static int hmc425a_code_to_gain_dB(struct hmc425a_state *st, int *val, int *val2) +{ + int code, gain; + + code = st->gain; + switch (st->type) { + case ID_HMC425A: + gain = ~code * -500; + break; + case ID_HMC540S: + gain = ~code * -1000; + break; + case ID_ADRF5740: + code = code & BIT(3) ? code & ~BIT(2) : code; + gain = code * -2000; + break; + } + + *val = gain / 1000; + *val2 = (gain % 1000) * 1000; + return 0; +} + static int hmc425a_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, long m) { struct hmc425a_state *st = iio_priv(indio_dev); - int code, gain = 0; int ret; mutex_lock(&st->lock); switch (m) { case IIO_CHAN_INFO_HARDWAREGAIN: - code = st->gain; - - switch (st->type) { - case ID_HMC425A: - gain = ~code * -500; - break; - case ID_HMC540S: - gain = ~code * -1000; - break; - case ID_ADRF5740: - code = code & BIT(3) ? code & ~BIT(2) : code; - gain = code * -2000; + ret = hmc425a_code_to_gain_dB(st, val, val2); + if (ret) break; - } - - *val = gain / 1000; - *val2 = (gain % 1000) * 1000; - ret = IIO_VAL_INT_PLUS_MICRO_DB; break; default: @@ -100,36 +135,15 @@ static int hmc425a_write_raw(struct iio_dev *indio_dev, int val2, long mask) { struct hmc425a_state *st = iio_priv(indio_dev); - struct hmc425a_chip_info *inf = st->chip_info; - int code = 0, gain; - int ret; - - if (val < 0) - gain = (val * 1000) - (val2 / 1000); - else - gain = (val * 1000) + (val2 / 1000); - - if (gain > inf->gain_max || gain < inf->gain_min) - return -EINVAL; - - switch (st->type) { - case ID_HMC425A: - code = ~((abs(gain) / 500) & 0x3F); - break; - case ID_HMC540S: - code = ~((abs(gain) / 1000) & 0xF); - break; - case ID_ADRF5740: - code = (abs(gain) / 2000) & 0xF; - code = code & BIT(3) ? code | BIT(2) : code; - break; - } + int code = 0, ret; mutex_lock(&st->lock); switch (mask) { case IIO_CHAN_INFO_HARDWAREGAIN: + ret = hmc425a_gain_dB_to_code(st, val, val2, &code); + if (ret) + break; st->gain = code; - ret = hmc425a_write(indio_dev, st->gain); break; default: From patchwork Wed Jan 10 15:37:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ceclan, Dumitru" X-Patchwork-Id: 13516280 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ABA24CDF8; Wed, 10 Jan 2024 15:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eR0nGKcO" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40d88fff7faso44082865e9.3; Wed, 10 Jan 2024 07:38:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704901088; x=1705505888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LTMaMXmqDjo2TjzKR4Go+S5q8z7l19GhbUs2M7Oy3ZA=; b=eR0nGKcOQ+YuEdFaxzChDvNPXcRUEWA9uQx72HTw0sOUrmdAqRfVjzWO5Hd6qmCdrQ tWkDjQERqMvQoHup3a7L0oyAkrb/QMKqpqjAUjI6g/p0xzVSt7cf9q43CaQHpkaXkAm4 dUj+80clyRIxv2n1+0JvBdNw718qX+6CFeLS4meFUpJ0T+rHy8hgD6ccnVMMi2oAxOH9 r+Znsk1ZEPzIZARgVzv3XyX3upbwB0c2xgFZZevvUQZOWpACDt57TjTP/+fDdXn58qjy zhM+/HrDzhi9PoyFtnbk9M5Nb6fa62TmV6g7iqpEGj+lCfR+yvUg+d7A9LZVvrcueu3c 3sbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704901088; x=1705505888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LTMaMXmqDjo2TjzKR4Go+S5q8z7l19GhbUs2M7Oy3ZA=; b=uXHQx8/SyvBCDPviaCapGp2eMZf0iYHYB6suMH+dJiFA4IojQQGsSesu5A51Yazg9G iVJI+xTETW7nT0yIRdvdGtqbNbDsKrzAua3M6/OE7yJenC3d8B0SSxyDj4jpvWK16B5d lxHi+rbG92FRe9qHwytFCEXS0omEUPDqlWeWQK4WWwBBrRGZMoNBETD5ymvkJWjphOqL dqYh10RaVqF2zH/qdHi2itXRHk6UERK2/T1hCUkPNdVFNTbbNqriBhIPuom+mW2tJR4r QBfu8jumk8o/JS2pwkBt2WgLdVpjrULACYGgRKg6gbxaSh7q+PeA/NrOy+FTsvq9R3c5 m90g== X-Gm-Message-State: AOJu0YxCju8Y3XyMYjYI9hgGawu6ywxRFKfUoyVl6HN6ED3HKvK4sL8Z 1ix0zZ3JIqk7SiIoC43l2TE= X-Google-Smtp-Source: AGHT+IE1DTMf17Awc4OzMIOaBNuqw77o/Z5yZIP7lqm/WzjKuPT7HZWhOh2YvdzcCF9/NrOUnk5whQ== X-Received: by 2002:a05:600c:4755:b0:40d:3be1:daaf with SMTP id w21-20020a05600c475500b0040d3be1daafmr356022wmo.51.1704901088400; Wed, 10 Jan 2024 07:38:08 -0800 (PST) Received: from HYB-hhAwRlzzMZb.ad.analog.com ([86.125.72.218]) by smtp.gmail.com with ESMTPSA id e30-20020a5d595e000000b0033776a50472sm4179907wri.10.2024.01.10.07.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:38:07 -0800 (PST) From: Dumitru Ceclan To: Cc: Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ceclan Dumitru , Dumitru Ceclan Subject: [PATCH v2 4/4] iio: amplifiers: hmc425a: add support for LTC6373 Instrumentation Amplifier Date: Wed, 10 Jan 2024 17:37:12 +0200 Message-ID: <20240110153757.5754-5-mitrutzceclan@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240110153757.5754-1-mitrutzceclan@gmail.com> References: <20240110153757.5754-1-mitrutzceclan@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This adds support for LTC6373 36 V Fully-Differential Programmable-Gain Instrumentation Amplifier with 25 pA Input Bias Current. The user can program the gain to one of seven available settings through a 3-bit parallel interface (A2 to A0). Signed-off-by: Dumitru Ceclan --- drivers/iio/amplifiers/hmc425a.c | 104 ++++++++++++++++++++++++++++++- 1 file changed, 102 insertions(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index b5fd19403d15..2048bf9e0343 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -2,9 +2,10 @@ /* * HMC425A and similar Gain Amplifiers * - * Copyright 2020 Analog Devices Inc. + * Copyright 2020, 2023 Analog Devices Inc. */ +#include #include #include #include @@ -20,10 +21,24 @@ #include #include +/* + * The LTC6373 amplifier supports configuring gain using GPIO's with the following + * values (OUTPUT_V / INPUT_V): 0(shutdown), 0.25, 0.5, 1, 2, 4, 8, 16 + * + * Except for the shutdown value, all can be converted to dB using 20 * log10(x) + * From here, it is observed that all values are multiples of the '2' gain setting, + * with the correspondent of 6.020dB. + */ +#define LTC6373_CONVERSION_CONSTANT 6020 +#define LTC6373_MIN_GAIN_CODE 0x6 +#define LTC6373_CONVERSION_MASK GENMASK(2, 0) +#define LTC6373_SHUTDOWN GENMASK(2, 0) + enum hmc425a_type { ID_HMC425A, ID_HMC540S, - ID_ADRF5740 + ID_ADRF5740, + ID_LTC6373, }; struct hmc425a_chip_info { @@ -42,6 +57,7 @@ struct hmc425a_state { struct gpio_descs *gpios; enum hmc425a_type type; u32 gain; + bool powerdown; }; static int hmc425a_write(struct iio_dev *indio_dev, u32 value) @@ -80,6 +96,17 @@ static int hmc425a_gain_dB_to_code(struct hmc425a_state *st, int val, int val2, temp = (abs(gain) / 2000) & 0xF; *code = temp & BIT(3) ? temp | BIT(2) : temp; break; + case ID_LTC6373: + if (st->powerdown) + return -EPERM; + + /* add half of the value for rounding */ + temp = LTC6373_CONVERSION_CONSTANT / 2; + if (val < 0) + temp *= -1; + *code = ~((gain + temp) / LTC6373_CONVERSION_CONSTANT + 3) + & LTC6373_CONVERSION_MASK; + break; } return 0; } @@ -100,6 +127,12 @@ static int hmc425a_code_to_gain_dB(struct hmc425a_state *st, int *val, int *val2 code = code & BIT(3) ? code & ~BIT(2) : code; gain = code * -2000; break; + case ID_LTC6373: + if (st->powerdown) + return -EPERM; + gain = ((~code & LTC6373_CONVERSION_MASK) - 3) * + LTC6373_CONVERSION_CONSTANT; + break; } *val = gain / 1000; @@ -172,6 +205,44 @@ static const struct iio_info hmc425a_info = { .write_raw_get_fmt = &hmc425a_write_raw_get_fmt, }; +static ssize_t ltc6373_read_powerdown(struct iio_dev *indio_dev, + uintptr_t private, const struct iio_chan_spec *chan, char *buf) +{ + struct hmc425a_state *st = iio_priv(indio_dev); + + return sysfs_emit(buf, "%d\n", st->powerdown); +} + +static ssize_t ltc6373_write_powerdown(struct iio_dev *indio_dev, + uintptr_t private, const struct iio_chan_spec *chan, const char *buf, + size_t len) +{ + struct hmc425a_state *st = iio_priv(indio_dev); + bool powerdown; + int code, ret; + + ret = kstrtobool(buf, &powerdown); + if (ret) + return ret; + + mutex_lock(&st->lock); + st->powerdown = powerdown; + code = (powerdown) ? LTC6373_SHUTDOWN : st->gain; + ret = hmc425a_write(indio_dev, code); + mutex_unlock(&st->lock); + return len; +} + +static const struct iio_chan_spec_ext_info ltc6373_ext_info[] = { + { + .name = "powerdown", + .read = ltc6373_read_powerdown, + .write = ltc6373_write_powerdown, + .shared = IIO_SEPARATE, + }, + {}, +}; + #define HMC425A_CHAN(_channel) \ { \ .type = IIO_VOLTAGE, \ @@ -181,15 +252,30 @@ static const struct iio_info hmc425a_info = { .info_mask_separate = BIT(IIO_CHAN_INFO_HARDWAREGAIN), \ } +#define LTC6373_CHAN(_channel) \ +{ \ + .type = IIO_VOLTAGE, \ + .output = 1, \ + .indexed = 1, \ + .channel = _channel, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_HARDWAREGAIN), \ + .ext_info = ltc6373_ext_info, \ +} + static const struct iio_chan_spec hmc425a_channels[] = { HMC425A_CHAN(0), }; +static const struct iio_chan_spec ltc6373_channels[] = { + LTC6373_CHAN(0), +}; + /* Match table for of_platform binding */ static const struct of_device_id hmc425a_of_match[] = { { .compatible = "adi,hmc425a", .data = (void *)ID_HMC425A }, { .compatible = "adi,hmc540s", .data = (void *)ID_HMC540S }, { .compatible = "adi,adrf5740", .data = (void *)ID_ADRF5740 }, + { .compatible = "adi,ltc6373", .data = (void *)ID_LTC6373 }, {}, }; MODULE_DEVICE_TABLE(of, hmc425a_of_match); @@ -222,6 +308,15 @@ static struct hmc425a_chip_info hmc425a_chip_info_tbl[] = { .gain_max = 0, .default_gain = 0xF, /* set default gain -22.0db*/ }, + [ID_LTC6373] = { + .name = "ltc6373", + .channels = ltc6373_channels, + .num_channels = ARRAY_SIZE(ltc6373_channels), + .num_gpios = 3, + .gain_min = -12041, /* gain setting x0.25*/ + .gain_max = 24082, /* gain setting x16 */ + .default_gain = LTC6373_SHUTDOWN, + }, }; static int hmc425a_probe(struct platform_device *pdev) @@ -266,6 +361,11 @@ static int hmc425a_probe(struct platform_device *pdev) /* Set default gain */ hmc425a_write(indio_dev, st->gain); + if (st->type == ID_LTC6373) { + st->powerdown = true; + st->gain = LTC6373_MIN_GAIN_CODE; + } + return devm_iio_device_register(&pdev->dev, indio_dev); }