From patchwork Fri Jan 12 04:21:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Su Hui X-Patchwork-Id: 13517930 Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id E937A1B290; Fri, 12 Jan 2024 04:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id CC6B9604F047A; Fri, 12 Jan 2024 12:21:37 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: nathan@kernel.org, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com Cc: Su Hui , akpm@linux-foundation.org, mudongliangabcd@gmail.com, hch@tuxera.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH] fs: hfsplus: fix an error code problem in hfsplus_sync_fs Date: Fri, 12 Jan 2024 12:21:27 +0800 Message-Id: <20240112042125.3930667-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Clang static checker wanrning: Value stored to 'error2' is never read. Fix this typo error by assigning 'error2' to 'error'. Fixes: 52399b171dfa ("hfsplus: use raw bio access for the volume headers") Signed-off-by: Su Hui --- fs/hfsplus/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index 1986b4f18a90..9f45582faf36 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c @@ -233,7 +233,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait) sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE | REQ_SYNC); if (!error) - error2 = error; + error = error2; out: mutex_unlock(&sbi->alloc_mutex); mutex_unlock(&sbi->vh_mutex);