From patchwork Fri Jan 12 10:46:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 13518283 X-Patchwork-Delegate: kvalo@adurom.com Received: from de-smtp-delivery-113.mimecast.com (de-smtp-delivery-113.mimecast.com [194.104.109.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28A6E5821D for ; Fri, 12 Jan 2024 10:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=toradex.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=toradex.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=toradex.com header.i=@toradex.com header.b="bU9amGv0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=toradex-com; t=1705056801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MdiF4Za2X8olyzZgMH46w4U0I+IHImQTppMzxr36mdw=; b=bU9amGv02OYW9D1/WqSTteHsj9VqhFsbkkS/pN+12RWE6SBS26AOwjuyvw1Y7pVCCeyli9 c9T7/30nl8GPsNUvhGYlD6NKg5OtEQ7u3vAGT+bmdnIV1fLOYJoUyJuPZk1Tg8DeFWUD/k YsPZHst4sRN1ipQKir0CjazU04xiu9I= Received: from CHE01-GV0-obe.outbound.protection.outlook.com (mail-gv0che01lp2040.outbound.protection.outlook.com [104.47.22.40]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-54-I9MjTVx1PmKOzU6mp4eyNg-1; Fri, 12 Jan 2024 11:46:39 +0100 X-MC-Unique: I9MjTVx1PmKOzU6mp4eyNg-1 Received: from ZR0P278MB0683.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:3b::9) by ZRAP278MB0738.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:4a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Fri, 12 Jan 2024 10:46:37 +0000 Received: from ZR0P278MB0683.CHEP278.PROD.OUTLOOK.COM ([fe80::8a78:db00:599:55ae]) by ZR0P278MB0683.CHEP278.PROD.OUTLOOK.COM ([fe80::8a78:db00:599:55ae%6]) with mapi id 15.20.7181.020; Fri, 12 Jan 2024 10:46:37 +0000 From: Marcel Ziswiler To: "linux-wireless@vger.kernel.org" CC: "arend.vanspriel@broadcom.com" , "andy@warmcat.com" , "angus@akkea.ca" , "franky.lin@broadcom.com" , "wiagn233@outlook.com" Subject: SparkLAN WNFB-265AXI (AP6275P) / bcm43752 pcie on mainline brcmfmac Thread-Topic: SparkLAN WNFB-265AXI (AP6275P) / bcm43752 pcie on mainline brcmfmac Thread-Index: AQHaRUSeTVMk9T4H20ug1qLldsvsHA== Date: Fri, 12 Jan 2024 10:46:37 +0000 Message-ID: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: ZR0P278MB0683:EE_|ZRAP278MB0738:EE_ x-ms-office365-filtering-correlation-id: 18ea91c1-6085-4783-3dae-08dc135bc0b1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: P3rHsTHTf7zCksULR4pmw8RpBXQDGdLSHCQ+Q8r+MPrgc++uXeqW7/C4xxkhgXGS9raJ4Q6lgPFlsqBNfqU94rqGa8z5MYNao6oesMSfdPUyw0RN7Sd9Fb9TKSqNiZzBSXxHtZU4b1dzSwoZi/6dYfamUlM2P73J1tlKuYJ9zpIs43j/E2j7NF2nsKdT5WCv4Q7WGgClM1C9sdalsxP3H2SS/30FdMxyjQ9TNBbmkS3CTDnjkPByNUjJYeEttnX2pY7bxUYtk/Ye10wh/3HTxn8v45Yww1wrt10+p/OWvhYkLsdhfd04daQrZ4sfKJN3CS3zr/DVP9nM3wJSWBmtXApBd+ojygMimzActny4COicQoVIqbx6gtoRwUnuvVnRnAxnUk+Bp181rE8eqVKPgTtjPlQoT+/mf7u0z6e0JoCLbnOUPLGxjzZ1CRp7LGDeqBNLm+uumDlwq4jQnz0cjClelq10l/5NJ5jilNDAZ2zK8whiEhQtIe8gzz4u6XxOg4alOlIYzrU3Xc0NT9vWTdLtBFuCrYvWTxkp99IoUMkoQwg5Hl84kowMJr01HjB2937aFyiBzPdZKpwJm1MonQqZtU2qaQarCzSmupmeZ+7aT89JwnHO5EhIJDkduFIw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ZR0P278MB0683.CHEP278.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(136003)(39850400004)(346002)(376002)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(83380400001)(19627235002)(41300700001)(91956017)(76116006)(40140700001)(36756003)(86362001)(38070700009)(66946007)(38100700002)(122000001)(26005)(2616005)(6512007)(966005)(6486002)(2906002)(8936002)(6916009)(66556008)(66476007)(66446008)(64756008)(316002)(5660300002)(6506007)(478600001)(54906003)(71200400001)(44832011)(8676002)(4326008)(156123004);DIR:OUT;SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?0i5UPVvNJ96e+Mp+6b54hDoouwEo?= =?utf-8?q?a8Oqu6NXVjJf7vS6Nd6XIvNr/XES+mgfiuUtd0/B6Gcul2Zu0NWdYWJA6Fsx9OtJ5?= =?utf-8?q?JFtIoqPeLSkwdVEFj2yTQ1vIFQnlmy6fXsIazjhxZ9ilBTr623xnD/SnESuD9MngX?= =?utf-8?q?ZIMPwJ0RBNDpOcbFmaTvVQ30E3c9bGS/O1SGfE5Eo8tDaa1xP1Q+j8sp/gUocXzEu?= =?utf-8?q?pbqLq5uMy7Fb/xmBDy9wZLNNRJomhonA9pgs0Igu10Y94UQULL3Y62XatNc/XsQfa?= =?utf-8?q?C0NV411GeYG4bGsKveiE9dLXMxDb//WEWfhxfphKOspocCK2/gpGs0KiDDfzmw3ZJ?= =?utf-8?q?kQN6Cdhv0AEIyUMbA7MrgMyJbnd+UiajOdeM6CHDIEieawj98mkWhMM446scKWVGR?= =?utf-8?q?mSObRAhE7wdWucvlpjT59Y7erwD5HsA1TmDg66xAWOrqtdj9e9Uf8QX1Sfu/67GLZ?= =?utf-8?q?AWjgUJaQTE1kb6DI97RWHLDIpj7ieeWyNsyO7x2dspGv95bi8nvhC3GvmqRC/HRnI?= =?utf-8?q?gScKK1myIW/177T9JjyoQWObgyZCKGn8yTKuZJsLdloPGhAsvLrTtpOELGEmFuIjj?= =?utf-8?q?yogxa7NBihg4RZ/+mwfruejQ0U1BeaWNJvyWKZqOTDQQlRegDVRoRXfAZJrBDSTPa?= =?utf-8?q?rVj7PP26yY/OCuUGj/vMgnDLC6+NO62tW00lbLgj3f4hwMcP2kStMoAmiGrcmuumw?= =?utf-8?q?UlE/1Wy1+/d+1yaQGAV5j5zVZdTKtOyAkbBcoqaga6g6wyiTDVcbZtTPD3QmVSZn4?= =?utf-8?q?SWHMIS21VFkNXrbzPKx6pc3iM3BcyFfSOmwB0TQpzBDgWjwgPSKyaCvefzkao0yla?= =?utf-8?q?t6biEL0m5kRREQFnrUyQCynmZrpO66adNFdlXoftzSZzBxlkgfuMs8F5tvYqpWc68?= =?utf-8?q?AgXiGu1nYj6lMkgOt7RVUqvgo6tiZWMgLUUhI0VGurAPCefRpgcSYsKBSKlQavD6u?= =?utf-8?q?gbKayy69yPnVO+RPCxMAWHUqAlkGyGcx6cqUzye+m8ERLdtYDpMs0x1kkUxEveWcf?= =?utf-8?q?YqhTWKbP9cX7x2u2DrPEDfqtKtZfr99CEs+xrpyT9LC3Gmf6LNyJg7Ws/Ef/28yk9?= =?utf-8?q?L20aq0JrPlB1hZ8HxKwyHRvCvo9aEcdhTfB2lO1uR9AJlR3JbCStpeGvPP/qb4njC?= =?utf-8?q?V/lObWlmx0RmbEwQbz3RBAq94Kq5Kh+JujH7CCxLNaUxkCD8afUXKEgsRvO2LVWGt?= =?utf-8?q?pg8jXv+zbIvRD49qdfzFTCN8vRv21Aqyvs20Ed54gXmZe92MQPwQ4Y8gJMejnUscY?= =?utf-8?q?HE5a3O3RlciG5JWqleJJHX2fp03I6F+znOT+Fa2F1W4D4tnJJ72iphOJ3lV6ZzKuD?= =?utf-8?q?GJBMmUTp1WxwlDkRr9XTK2JeLM/g12wQTyg5DU7fVMXVdRDWm5lJwP4i5hR2+hKHH?= =?utf-8?q?zwP1+kQefogZQBVTJKZVKzGgIXhovgR2dO2W2uPRSopKkBtAwa54amZWoKRg04jI+?= =?utf-8?q?IKOdImAkyv/fIzkPMW14dP18o/ijy3og63sLsNrgIMAdrmbvVCnpnug2UEiOYEWsU?= =?utf-8?q?TrfoolBNf7yIw+5BtlaoUzowExwRU3PjlFtapJg3mFrMoJdzopnB1A4=3D?= Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: ZR0P278MB0683.CHEP278.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 18ea91c1-6085-4783-3dae-08dc135bc0b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2024 10:46:37.5302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2zkPvvV/dBqyN/CkR8IvrtGwlHsa0qA1VNtGFpmAitaMn0cq35CeDeP+bof2z/Udx/UwYjiKs2uAzF11UV6rwMIYFgJeqjTiomayVW3TKfU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZRAP278MB0738 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: toradex.com Content-Language: en-US Content-ID: Hi guys I stumbled over this thread from a little over a year ago [1]. I lately tried my take at this, however, initially even on latest linux-next it did not even recognise my card. 0000:01:00.0 Network controller: Broadcom Inc. and subsidiaries Device 449d (rev 02) Once I added that PCI device ID to drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c the driver at least picked it up: [ 27.712436] brcmfmac 0000:01:00.0: enabling device (0000 -> 0002) [ 27.826371] brcmfmac 0000:01:00.0: brcmf_pcie_probe: failed to parse OTP [ 27.833126] brcmfmac: brcmf_pcie_probe: failed 14e4:449d [ 27.838498] brcmfmac: probe of 0000:01:00.0 failed with error -22 Looks like it needs more information but I am unsure to what exactly to add where. Last I got the following (git diff at the very end): [ 412.947747] brcmfmac 0000:01:00.0: enabling device (0000 -> 0002) [ 413.059831] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac43752-pcie for chip BCM43752/2 [ 413.096587] brcmfmac 0000:01:00.0: Direct firmware load for brcm/brcmfmac43752-pcie.txcap_blob failed with error -2 [ 419.211343] brcmfmac 0000:01:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize [ 419.219481] brcmfmac 0000:01:00.0: brcmf_pcie_setup: Dongle setup failed [ 419.226214] ieee80211 phy0: brcmf_fw_crashed: Firmware has halted or crashed Not sure what exact firmware I would need to use. From SparkLAN I got the following: Archive: FW_AP6275P_101_v2.zip Length Date Time Name --------- ---------- ----- ---- 80602 07-01-2021 15:01 FW_AP6275P_101_v2/BCM4362A2_001.003.006.1012.1017.hcd 30993 11-12-2021 20:16 FW_AP6275P_101_v2/clm_bcm43752a2_pcie_ag.blob 936074 07-13-2022 14:28 FW_AP6275P_101_v2/fw_bcm43752a2_pcie_ag.bin 7458 01-10-2022 12:11 FW_AP6275P_101_v2/nvram_ap6275p.txt 7808 08-30-2022 15:53 FW_AP6275P_101_v2/nvram_ap6275p_m2.txt 8576 02-25-2021 14:51 FW_AP6275P_101_v2/nvram_ap6275p_mp.txt 673 04-21-2023 16:32 FW_AP6275P_101_v2/ReadMe.txt --------- ------- 1072184 7 files Did anybody ever progress on getting this to work? Any help would be much appreciated. Thanks! [1] https://lore.kernel.org/all/2db80338-c92d-b006-c281-dab943029168@warmcat.com/T Cheers Marcel diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index 80220685f5e4..b596762a1cd2 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -66,6 +66,7 @@ BRCMF_FW_DEF(4365C, "brcmfmac4365c-pcie"); BRCMF_FW_DEF(4366B, "brcmfmac4366b-pcie"); BRCMF_FW_DEF(4366C, "brcmfmac4366c-pcie"); BRCMF_FW_DEF(4371, "brcmfmac4371-pcie"); +BRCMF_FW_CLM_DEF(43752, "brcmfmac43752-pcie"); BRCMF_FW_CLM_DEF(4377B3, "brcmfmac4377b3-pcie"); BRCMF_FW_CLM_DEF(4378B1, "brcmfmac4378b1-pcie"); BRCMF_FW_CLM_DEF(4378B3, "brcmfmac4378b3-pcie"); @@ -104,6 +105,7 @@ static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = { BRCMF_FW_ENTRY(BRCM_CC_43664_CHIP_ID, 0xFFFFFFF0, 4366C), BRCMF_FW_ENTRY(BRCM_CC_43666_CHIP_ID, 0xFFFFFFF0, 4366C), BRCMF_FW_ENTRY(BRCM_CC_4371_CHIP_ID, 0xFFFFFFFF, 4371), + BRCMF_FW_ENTRY(BRCM_CC_43752_CHIP_ID, 0xFFFFFFFF, 43752), BRCMF_FW_ENTRY(BRCM_CC_4377_CHIP_ID, 0xFFFFFFFF, 4377B3), /* revision ID 4 */ BRCMF_FW_ENTRY(BRCM_CC_4378_CHIP_ID, 0x0000000F, 4378B1), /* revision ID 3 */ BRCMF_FW_ENTRY(BRCM_CC_4378_CHIP_ID, 0xFFFFFFE0, 4378B3), /* revision ID 5 */ @@ -2062,6 +2064,8 @@ static int brcmf_pcie_read_otp(struct brcmf_pciedev_info *devinfo) words = 0x170; break; case BRCM_CC_4387_CHIP_ID: +//brcmf_pcie_probe: failed to parse OTP +// case BRCM_CC_43752_CHIP_ID: coreid = BCMA_CORE_GCI; base = 0x113c; words = 0x170; @@ -2694,6 +2698,7 @@ static const struct pci_device_id brcmf_pcie_devid_table[] = { BRCMF_PCIE_DEVICE(BRCM_PCIE_4366_2G_DEVICE_ID, BCA), BRCMF_PCIE_DEVICE(BRCM_PCIE_4366_5G_DEVICE_ID, BCA), BRCMF_PCIE_DEVICE(BRCM_PCIE_4371_DEVICE_ID, WCC), + BRCMF_PCIE_DEVICE(BRCM_PCIE_43752_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_43596_DEVICE_ID, CYW), BRCMF_PCIE_DEVICE(BRCM_PCIE_4377_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_4378_DEVICE_ID, WCC), diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h index 44684bf1b9ac..b97b4c640d1b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h @@ -59,6 +59,7 @@ #define CY_CC_43012_CHIP_ID 43012 #define CY_CC_43439_CHIP_ID 43439 #define CY_CC_43752_CHIP_ID 43752 +#define BRCM_CC_43752_CHIP_ID 43752 /* USB Device IDs */ #define BRCM_USB_43143_DEVICE_ID 0xbd1e @@ -93,6 +94,7 @@ #define BRCM_PCIE_4366_2G_DEVICE_ID 0x43c4 #define BRCM_PCIE_4366_5G_DEVICE_ID 0x43c5 #define BRCM_PCIE_4371_DEVICE_ID 0x440d +#define BRCM_PCIE_43752_DEVICE_ID 0x449d #define BRCM_PCIE_43596_DEVICE_ID 0x4415 #define BRCM_PCIE_4377_DEVICE_ID 0x4488 #define BRCM_PCIE_4378_DEVICE_ID 0x4425