From patchwork Tue Jan 16 16:54:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 13520957 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D2E1CD0A for ; Tue, 16 Jan 2024 16:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="I+my0cxs" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7bb06f56fe9so98523639f.0 for ; Tue, 16 Jan 2024 08:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705424300; x=1706029100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Us45EoP25PqlqiZBckfWl0io3JKyu/1sn8OlAK1lBWM=; b=I+my0cxsgf7Pt3Xq6rzI3dM7tpTCVqWJjpmdoUpJWNf88xSvvbT5oAqDPXYEUl3OU8 QoyXzH7j0lVESwBxxoP81NBXyHmr01GH/1h1718zc/9fZpRP3xFrDMlLl9pRehkHOk0S P9BGapHygKPrkBWR3pMKWsO3X2JvqCoRlQILcn7LE3/pcXRv2XdMRTm+Mqo6o+yIMDwu /krdceq+NLOVHBEsbWhEZPP+D/FCUE0ZI5sS3sIpObL0JKUGzdplaCfCAulO5Iodkntl 3Pyhjqk1bdHmNr/6ayM/KBxZXY9ULWFd9ElKoLMqMEITBbqFCM4eaqs1mvfgwOqoaRSe l+vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705424300; x=1706029100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Us45EoP25PqlqiZBckfWl0io3JKyu/1sn8OlAK1lBWM=; b=DyLTjAthVjixEkFNFcpicPyV6xzYWdWqI92U/VWopQ9kczGsjHzC9URYbRflnRxSYC bRdBB3sN0C+DiyM+p/2SdKQW8i4TvDFwTSBQCDiDUC+bhTDFMFYLIZ97WpstRwcVcdhe WcVpjmEPD/fzzBbClvQK1IT41bFgWQ0pk9JctBNWD7Oe+QhRIEgshnQXRDLBIfROzOuX uUa2xWxz/aVAEc8AAWhTwS+tQ1ZqAiAW0ZZlrHes0udULfVKYRLOCgdQmaajDX00IhYv hKaPi7qIBlEOukLXj2NmCQkpD82AGQtBHhhOSzFyL/4wR5n4LflwLbVrxLqQIrAdgiou /ReA== X-Gm-Message-State: AOJu0YyR/eY5Wfedd+Fn+Tc7h7XV4iG93TnEJ4b/G7mpTLvzJ06hV1sI Y1rxuQcn52qlorX9YyvP1wJyEwayiz4Z/n//VPS87ETXeM6Mig== X-Google-Smtp-Source: AGHT+IG9KHqIzPcFecs+DKN0Ozjew9tfAFuE0nFXpimF9zas42MlYcCBx+KZU/kcu4xKyM4DePW65g== X-Received: by 2002:a05:6602:2c95:b0:7be:e080:6869 with SMTP id i21-20020a0566022c9500b007bee0806869mr13179823iow.1.1705424299653; Tue, 16 Jan 2024 08:58:19 -0800 (PST) Received: from localhost.localdomain ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id c14-20020a02a60e000000b0046ea43e4d0csm71744jam.168.2024.01.16.08.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 08:58:18 -0800 (PST) From: Jens Axboe To: linux-block@vger.kernel.org Cc: kbusch@kernel.org, joshi.k@samsung.com, Jens Axboe Subject: [PATCH 1/5] block: add blk_time_get_ns() helper Date: Tue, 16 Jan 2024 09:54:22 -0700 Message-ID: <20240116165814.236767-2-axboe@kernel.dk> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116165814.236767-1-axboe@kernel.dk> References: <20240116165814.236767-1-axboe@kernel.dk> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert any user of ktime_get_ns() to use blk_time_get_ns(), so we have a unified API for querying the current time in nanoseconds. No functional changes intended, this patch just wraps ktime_get_ns() with a block helper. Signed-off-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- block/bfq-cgroup.c | 14 +++++++------- block/bfq-iosched.c | 22 +++++++++++----------- block/blk-cgroup.c | 2 +- block/blk-flush.c | 2 +- block/blk-iocost.c | 6 +++--- block/blk-iolatency.c | 6 +++--- block/blk-mq.c | 16 ++++++++-------- block/blk-throttle.c | 6 +++--- block/blk-wbt.c | 5 ++--- include/linux/blkdev.h | 5 +++++ 10 files changed, 44 insertions(+), 40 deletions(-) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index 2c90e5de0acd..d442ee358fc2 100644 --- a/block/bfq-cgroup.c +++ b/block/bfq-cgroup.c @@ -127,7 +127,7 @@ static void bfqg_stats_update_group_wait_time(struct bfqg_stats *stats) if (!bfqg_stats_waiting(stats)) return; - now = ktime_get_ns(); + now = blk_time_get_ns(); if (now > stats->start_group_wait_time) bfq_stat_add(&stats->group_wait_time, now - stats->start_group_wait_time); @@ -144,7 +144,7 @@ static void bfqg_stats_set_start_group_wait_time(struct bfq_group *bfqg, return; if (bfqg == curr_bfqg) return; - stats->start_group_wait_time = ktime_get_ns(); + stats->start_group_wait_time = blk_time_get_ns(); bfqg_stats_mark_waiting(stats); } @@ -156,7 +156,7 @@ static void bfqg_stats_end_empty_time(struct bfqg_stats *stats) if (!bfqg_stats_empty(stats)) return; - now = ktime_get_ns(); + now = blk_time_get_ns(); if (now > stats->start_empty_time) bfq_stat_add(&stats->empty_time, now - stats->start_empty_time); @@ -183,7 +183,7 @@ void bfqg_stats_set_start_empty_time(struct bfq_group *bfqg) if (bfqg_stats_empty(stats)) return; - stats->start_empty_time = ktime_get_ns(); + stats->start_empty_time = blk_time_get_ns(); bfqg_stats_mark_empty(stats); } @@ -192,7 +192,7 @@ void bfqg_stats_update_idle_time(struct bfq_group *bfqg) struct bfqg_stats *stats = &bfqg->stats; if (bfqg_stats_idling(stats)) { - u64 now = ktime_get_ns(); + u64 now = blk_time_get_ns(); if (now > stats->start_idle_time) bfq_stat_add(&stats->idle_time, @@ -205,7 +205,7 @@ void bfqg_stats_set_start_idle_time(struct bfq_group *bfqg) { struct bfqg_stats *stats = &bfqg->stats; - stats->start_idle_time = ktime_get_ns(); + stats->start_idle_time = blk_time_get_ns(); bfqg_stats_mark_idling(stats); } @@ -242,7 +242,7 @@ void bfqg_stats_update_completion(struct bfq_group *bfqg, u64 start_time_ns, u64 io_start_time_ns, blk_opf_t opf) { struct bfqg_stats *stats = &bfqg->stats; - u64 now = ktime_get_ns(); + u64 now = blk_time_get_ns(); if (now > io_start_time_ns) blkg_rwstat_add(&stats->service_time, opf, diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 3cce6de464a7..1922574e1c0d 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -1005,7 +1005,7 @@ static struct request *bfq_check_fifo(struct bfq_queue *bfqq, rq = rq_entry_fifo(bfqq->fifo.next); - if (rq == last || ktime_get_ns() < rq->fifo_time) + if (rq == last || blk_time_get_ns() < rq->fifo_time) return NULL; bfq_log_bfqq(bfqq->bfqd, bfqq, "check_fifo: returned %p", rq); @@ -1829,7 +1829,7 @@ static void bfq_bfqq_handle_idle_busy_switch(struct bfq_data *bfqd, * bfq_bfqq_update_budg_for_activation for * details on the usage of the next variable. */ - arrived_in_time = ktime_get_ns() <= + arrived_in_time = blk_time_get_ns() <= bfqq->ttime.last_end_request + bfqd->bfq_slice_idle * 3; unsigned int act_idx = bfq_actuator_index(bfqd, rq->bio); @@ -2208,7 +2208,7 @@ static void bfq_add_request(struct request *rq) struct request *next_rq, *prev; unsigned int old_wr_coeff = bfqq->wr_coeff; bool interactive = false; - u64 now_ns = ktime_get_ns(); + u64 now_ns = blk_time_get_ns(); bfq_log_bfqq(bfqd, bfqq, "add_request %d", rq_is_sync(rq)); bfqq->queued[rq_is_sync(rq)]++; @@ -2262,7 +2262,7 @@ static void bfq_add_request(struct request *rq) bfqd->rqs_injected && bfqd->tot_rq_in_driver > 0)) && time_is_before_eq_jiffies(bfqq->decrease_time_jif + msecs_to_jiffies(10))) { - bfqd->last_empty_occupied_ns = ktime_get_ns(); + bfqd->last_empty_occupied_ns = blk_time_get_ns(); /* * Start the state machine for measuring the * total service time of rq: setting @@ -3433,7 +3433,7 @@ static void bfq_reset_rate_computation(struct bfq_data *bfqd, struct request *rq) { if (rq != NULL) { /* new rq dispatch now, reset accordingly */ - bfqd->last_dispatch = bfqd->first_dispatch = ktime_get_ns(); + bfqd->last_dispatch = bfqd->first_dispatch = blk_time_get_ns(); bfqd->peak_rate_samples = 1; bfqd->sequential_samples = 0; bfqd->tot_sectors_dispatched = bfqd->last_rq_max_size = @@ -3590,7 +3590,7 @@ static void bfq_update_rate_reset(struct bfq_data *bfqd, struct request *rq) */ static void bfq_update_peak_rate(struct bfq_data *bfqd, struct request *rq) { - u64 now_ns = ktime_get_ns(); + u64 now_ns = blk_time_get_ns(); if (bfqd->peak_rate_samples == 0) { /* first dispatch */ bfq_log(bfqd, "update_peak_rate: goto reset, samples %d", @@ -5591,7 +5591,7 @@ static void bfq_init_bfqq(struct bfq_data *bfqd, struct bfq_queue *bfqq, struct bfq_io_cq *bic, pid_t pid, int is_sync, unsigned int act_idx) { - u64 now_ns = ktime_get_ns(); + u64 now_ns = blk_time_get_ns(); bfqq->actuator_idx = act_idx; RB_CLEAR_NODE(&bfqq->entity.rb_node); @@ -5903,7 +5903,7 @@ static void bfq_update_io_thinktime(struct bfq_data *bfqd, */ if (bfqq->dispatched || bfq_bfqq_busy(bfqq)) return; - elapsed = ktime_get_ns() - bfqq->ttime.last_end_request; + elapsed = blk_time_get_ns() - bfqq->ttime.last_end_request; elapsed = min_t(u64, elapsed, 2ULL * bfqd->bfq_slice_idle); ttime->ttime_samples = (7*ttime->ttime_samples + 256) / 8; @@ -6194,7 +6194,7 @@ static bool __bfq_insert_request(struct bfq_data *bfqd, struct request *rq) bfq_add_request(rq); idle_timer_disabled = waiting && !bfq_bfqq_wait_request(bfqq); - rq->fifo_time = ktime_get_ns() + bfqd->bfq_fifo_expire[rq_is_sync(rq)]; + rq->fifo_time = blk_time_get_ns() + bfqd->bfq_fifo_expire[rq_is_sync(rq)]; list_add_tail(&rq->queuelist, &bfqq->fifo); bfq_rq_enqueued(bfqd, bfqq, rq); @@ -6370,7 +6370,7 @@ static void bfq_completed_request(struct bfq_queue *bfqq, struct bfq_data *bfqd) bfq_weights_tree_remove(bfqq); } - now_ns = ktime_get_ns(); + now_ns = blk_time_get_ns(); bfqq->ttime.last_end_request = now_ns; @@ -6585,7 +6585,7 @@ static void bfq_completed_request(struct bfq_queue *bfqq, struct bfq_data *bfqd) static void bfq_update_inject_limit(struct bfq_data *bfqd, struct bfq_queue *bfqq) { - u64 tot_time_ns = ktime_get_ns() - bfqd->last_empty_occupied_ns; + u64 tot_time_ns = blk_time_get_ns() - bfqd->last_empty_occupied_ns; unsigned int old_limit = bfqq->inject_limit; if (bfqq->last_serv_time_ns > 0 && bfqd->rqs_injected) { diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index ff93c385ba5a..bdbb557feb5a 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1846,7 +1846,7 @@ static void blkcg_maybe_throttle_blkg(struct blkcg_gq *blkg, bool use_memdelay) { unsigned long pflags; bool clamp; - u64 now = ktime_to_ns(ktime_get()); + u64 now = blk_time_get_ns(); u64 exp; u64 delay_nsec = 0; int tok; diff --git a/block/blk-flush.c b/block/blk-flush.c index 3f4d41952ef2..b0f314f4bc14 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -143,7 +143,7 @@ static void blk_account_io_flush(struct request *rq) part_stat_lock(); part_stat_inc(part, ios[STAT_FLUSH]); part_stat_add(part, nsecs[STAT_FLUSH], - ktime_get_ns() - rq->start_time_ns); + blk_time_get_ns() - rq->start_time_ns); part_stat_unlock(); } diff --git a/block/blk-iocost.c b/block/blk-iocost.c index c8beec6d7df0..e54b17261d96 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -829,7 +829,7 @@ static int ioc_autop_idx(struct ioc *ioc, struct gendisk *disk) /* step up/down based on the vrate */ vrate_pct = div64_u64(ioc->vtime_base_rate * 100, VTIME_PER_USEC); - now_ns = ktime_get_ns(); + now_ns = blk_time_get_ns(); if (p->too_fast_vrate_pct && p->too_fast_vrate_pct <= vrate_pct) { if (!ioc->autop_too_fast_at) @@ -1044,7 +1044,7 @@ static void ioc_now(struct ioc *ioc, struct ioc_now *now) unsigned seq; u64 vrate; - now->now_ns = ktime_get(); + now->now_ns = blk_time_get_ns(); now->now = ktime_to_us(now->now_ns); vrate = atomic64_read(&ioc->vtime_rate); @@ -2810,7 +2810,7 @@ static void ioc_rqos_done(struct rq_qos *rqos, struct request *rq) return; } - on_q_ns = ktime_get_ns() - rq->alloc_time_ns; + on_q_ns = blk_time_get_ns() - rq->alloc_time_ns; rq_wait_ns = rq->start_time_ns - rq->alloc_time_ns; size_nsec = div64_u64(calc_size_vtime_cost(rq, ioc), VTIME_PER_NSEC); diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index c1a6aba1d59e..ebb522788d97 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -609,7 +609,7 @@ static void blkcg_iolatency_done_bio(struct rq_qos *rqos, struct bio *bio) if (!iolat->blkiolat->enabled) return; - now = ktime_to_ns(ktime_get()); + now = blk_time_get_ns(); while (blkg && blkg->parent) { iolat = blkg_to_lat(blkg); if (!iolat) { @@ -661,7 +661,7 @@ static void blkiolatency_timer_fn(struct timer_list *t) struct blk_iolatency *blkiolat = from_timer(blkiolat, t, timer); struct blkcg_gq *blkg; struct cgroup_subsys_state *pos_css; - u64 now = ktime_to_ns(ktime_get()); + u64 now = blk_time_get_ns(); rcu_read_lock(); blkg_for_each_descendant_pre(blkg, pos_css, @@ -985,7 +985,7 @@ static void iolatency_pd_init(struct blkg_policy_data *pd) struct blkcg_gq *blkg = lat_to_blkg(iolat); struct rq_qos *rqos = iolat_rq_qos(blkg->q); struct blk_iolatency *blkiolat = BLKIOLATENCY(rqos); - u64 now = ktime_to_ns(ktime_get()); + u64 now = blk_time_get_ns(); int cpu; if (blk_queue_nonrot(blkg->q)) diff --git a/block/blk-mq.c b/block/blk-mq.c index aa87fcfda1ec..aff9e9492f59 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -323,7 +323,7 @@ void blk_rq_init(struct request_queue *q, struct request *rq) RB_CLEAR_NODE(&rq->rb_node); rq->tag = BLK_MQ_NO_TAG; rq->internal_tag = BLK_MQ_NO_TAG; - rq->start_time_ns = ktime_get_ns(); + rq->start_time_ns = blk_time_get_ns(); rq->part = NULL; blk_crypto_rq_set_defaults(rq); } @@ -333,7 +333,7 @@ EXPORT_SYMBOL(blk_rq_init); static inline void blk_mq_rq_time_init(struct request *rq, u64 alloc_time_ns) { if (blk_mq_need_time_stamp(rq)) - rq->start_time_ns = ktime_get_ns(); + rq->start_time_ns = blk_time_get_ns(); else rq->start_time_ns = 0; @@ -444,7 +444,7 @@ static struct request *__blk_mq_alloc_requests(struct blk_mq_alloc_data *data) /* alloc_time includes depth and tag waits */ if (blk_queue_rq_alloc_time(q)) - alloc_time_ns = ktime_get_ns(); + alloc_time_ns = blk_time_get_ns(); if (data->cmd_flags & REQ_NOWAIT) data->flags |= BLK_MQ_REQ_NOWAIT; @@ -629,7 +629,7 @@ struct request *blk_mq_alloc_request_hctx(struct request_queue *q, /* alloc_time includes depth and tag waits */ if (blk_queue_rq_alloc_time(q)) - alloc_time_ns = ktime_get_ns(); + alloc_time_ns = blk_time_get_ns(); /* * If the tag allocator sleeps we could get an allocation for a @@ -1042,7 +1042,7 @@ static inline void __blk_mq_end_request_acct(struct request *rq, u64 now) inline void __blk_mq_end_request(struct request *rq, blk_status_t error) { if (blk_mq_need_time_stamp(rq)) - __blk_mq_end_request_acct(rq, ktime_get_ns()); + __blk_mq_end_request_acct(rq, blk_time_get_ns()); blk_mq_finish_request(rq); @@ -1085,7 +1085,7 @@ void blk_mq_end_request_batch(struct io_comp_batch *iob) u64 now = 0; if (iob->need_ts) - now = ktime_get_ns(); + now = blk_time_get_ns(); while ((rq = rq_list_pop(&iob->req_list)) != NULL) { prefetch(rq->bio); @@ -1255,7 +1255,7 @@ void blk_mq_start_request(struct request *rq) if (test_bit(QUEUE_FLAG_STATS, &q->queue_flags) && !blk_rq_is_passthrough(rq)) { - rq->io_start_time_ns = ktime_get_ns(); + rq->io_start_time_ns = blk_time_get_ns(); rq->stats_sectors = blk_rq_sectors(rq); rq->rq_flags |= RQF_STATS; rq_qos_issue(q, rq); @@ -3107,7 +3107,7 @@ blk_status_t blk_insert_cloned_request(struct request *rq) blk_mq_run_dispatch_ops(q, ret = blk_mq_request_issue_directly(rq, true)); if (ret) - blk_account_io_done(rq, ktime_get_ns()); + blk_account_io_done(rq, blk_time_get_ns()); return ret; } EXPORT_SYMBOL_GPL(blk_insert_cloned_request); diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 16f5766620a4..da9dc1f793c3 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1815,7 +1815,7 @@ static bool throtl_tg_is_idle(struct throtl_grp *tg) time = min_t(unsigned long, MAX_IDLE_TIME, 4 * tg->idletime_threshold); ret = tg->latency_target == DFL_LATENCY_TARGET || tg->idletime_threshold == DFL_IDLE_THRESHOLD || - (ktime_get_ns() >> 10) - tg->last_finish_time > time || + (blk_time_get_ns() >> 10) - tg->last_finish_time > time || tg->avg_idletime > tg->idletime_threshold || (tg->latency_target && tg->bio_cnt && tg->bad_bio_cnt * 5 < tg->bio_cnt); @@ -2060,7 +2060,7 @@ static void blk_throtl_update_idletime(struct throtl_grp *tg) if (last_finish_time == 0) return; - now = ktime_get_ns() >> 10; + now = blk_time_get_ns() >> 10; if (now <= last_finish_time || last_finish_time == tg->checked_last_finish_time) return; @@ -2327,7 +2327,7 @@ void blk_throtl_bio_endio(struct bio *bio) if (!tg->td->limit_valid[LIMIT_LOW]) return; - finish_time_ns = ktime_get_ns(); + finish_time_ns = blk_time_get_ns(); tg->last_finish_time = finish_time_ns >> 10; start_time = bio_issue_time(&bio->bi_issue) >> 10; diff --git a/block/blk-wbt.c b/block/blk-wbt.c index 5ba3cd574eac..4c1c04345040 100644 --- a/block/blk-wbt.c +++ b/block/blk-wbt.c @@ -274,13 +274,12 @@ static inline bool stat_sample_valid(struct blk_rq_stat *stat) static u64 rwb_sync_issue_lat(struct rq_wb *rwb) { - u64 now, issue = READ_ONCE(rwb->sync_issue); + u64 issue = READ_ONCE(rwb->sync_issue); if (!issue || !rwb->sync_cookie) return 0; - now = ktime_to_ns(ktime_get()); - return now - issue; + return blk_time_get_ns() - issue; } static inline unsigned int wbt_inflight(struct rq_wb *rwb) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 99e4f5e72213..2f9ceea0e23b 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -974,6 +974,11 @@ static inline void blk_flush_plug(struct blk_plug *plug, bool async) int blkdev_issue_flush(struct block_device *bdev); long nr_blockdev_pages(void); + +static inline u64 blk_time_get_ns(void) +{ + return ktime_get_ns(); +} #else /* CONFIG_BLOCK */ struct blk_plug { }; From patchwork Tue Jan 16 16:54:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 13520958 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E90A61CF8A for ; Tue, 16 Jan 2024 16:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="owIvX4xs" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-7bbdd28a52aso69759039f.1 for ; Tue, 16 Jan 2024 08:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705424301; x=1706029101; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zDwQsQA3hkrp55OhYNyh1i/vP5KE9MQ17MazH2WqV6M=; b=owIvX4xsq6op9rGtK0gbPBaGCx72hC8obEhkR2q17l2KwHJfZtN/JivmRL/pVEBv3e zwA+nUSqbrDt46Z+KQMEgRNsZDbqkd8ngRukYyHwLgQbamg7cDvKruEF3ZemrE+5YUx6 t2JYJegZBvjUC5iLVVLh+Ajy9D3vpeq1YUYO0NbSjEb7GrTgXe6JRGm4GoXiRhnf3FNJ EFRpHFWmpKPnM8666cFFIb637NiAiTiWTgVZrBcPfN/9hygzX+BW6S91/WW3BIvR0R0S UylryzP3ipKxiAGDVIRBKdaFnG6+EaidZmHptQ/z44qrcYI3dUO0nN6759wTx892syQt nVow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705424301; x=1706029101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zDwQsQA3hkrp55OhYNyh1i/vP5KE9MQ17MazH2WqV6M=; b=fDQ11EpDuJTSZZFOVEN9uH3E3qJ6iQPJFulBV0ht6P6xIMC70oNa7Tj2e5aEWejKtN yisR7pU8JcOjc1qV1F8C/vkwEjWsfDzSrdSHeB/m8cmcei+bgoT2GF61jAYDoRUGP0cn OkFXws2YRtMxNiGWtTwlP2ZXMYoUfTAtSD89S3ZYURfuiluvZK5QLOVoZVe0dGVC6Aww JgaAd+vX+aabZJ9Ys6z6s2gvr1/1mIK/JT0FGgZk6T3rxVpSQQfrGHY1cws/yyP9FZ3Q UW0psPd1tlZqxyd2fiD58CHGuCe+VXd24YquYAdQV6MvWorGtmMDDpJNY0s300vKamjD OfIg== X-Gm-Message-State: AOJu0YzB5O5/S1bkX6ozLIjhwhDNdLQlbK2i3/0YTuDJH6bqIrRKGJ3k Myoamz5DU7546m3tcLm+MTU03Oz70x3HXZis1HY97kKaoweKBQ== X-Google-Smtp-Source: AGHT+IFiJXR7sSD2hYGXtzufxPNLROXFEsJvNVZ72a2vQhxn8SnCuGx1RmLXQunSsXEFHq/pqLCKdw== X-Received: by 2002:a05:6602:1799:b0:7bf:f20:2c78 with SMTP id y25-20020a056602179900b007bf0f202c78mr12414747iox.1.1705424301644; Tue, 16 Jan 2024 08:58:21 -0800 (PST) Received: from localhost.localdomain ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id c14-20020a02a60e000000b0046ea43e4d0csm71744jam.168.2024.01.16.08.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 08:58:20 -0800 (PST) From: Jens Axboe To: linux-block@vger.kernel.org Cc: kbusch@kernel.org, joshi.k@samsung.com, Jens Axboe Subject: [PATCH 2/5] block: cache current nsec time in struct blk_plug Date: Tue, 16 Jan 2024 09:54:23 -0700 Message-ID: <20240116165814.236767-3-axboe@kernel.dk> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116165814.236767-1-axboe@kernel.dk> References: <20240116165814.236767-1-axboe@kernel.dk> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Querying the current time is the most costly thing we do in the block layer per IO, and depending on kernel config settings, we may do it many times per IO. None of the callers actually need nsec granularity. Take advantage of that by caching the current time in the plug, with the assumption here being that any time checking will be temporally close enough that the slight loss of precision doesn't matter. If the block plug gets flushed, eg on preempt or schedule out, then we invalidate the cached clock. On a basic peak IOPS test case with iostats enabled, this changes the performance from: IOPS=108.41M, BW=52.93GiB/s, IOS/call=31/31 IOPS=108.43M, BW=52.94GiB/s, IOS/call=32/32 IOPS=108.29M, BW=52.88GiB/s, IOS/call=31/32 IOPS=108.35M, BW=52.91GiB/s, IOS/call=32/32 IOPS=108.42M, BW=52.94GiB/s, IOS/call=31/31 IOPS=108.40M, BW=52.93GiB/s, IOS/call=32/32 IOPS=108.31M, BW=52.89GiB/s, IOS/call=32/31 to IOPS=118.79M, BW=58.00GiB/s, IOS/call=31/32 IOPS=118.62M, BW=57.92GiB/s, IOS/call=31/31 IOPS=118.80M, BW=58.01GiB/s, IOS/call=32/31 IOPS=118.78M, BW=58.00GiB/s, IOS/call=32/32 IOPS=118.69M, BW=57.95GiB/s, IOS/call=32/31 IOPS=118.62M, BW=57.92GiB/s, IOS/call=32/31 IOPS=118.63M, BW=57.92GiB/s, IOS/call=31/32 which is more than a 9% improvement in performance. Looking at perf diff, we can see a huge reduction in time overhead: 10.55% -9.88% [kernel.vmlinux] [k] read_tsc 1.31% -1.22% [kernel.vmlinux] [k] ktime_get Note that since this relies on blk_plug for the caching, it's only applicable to the issue side. But this is where most of the time calls happen anyway. It's also worth nothing that the above testing doesn't enable any of the higher cost CPU items on the block layer side, like wbt, cgroups, iocost, etc, which all would add additional time querying. IOW, results would likely look even better in comparison with those enabled, as distros would do. Signed-off-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- block/blk-core.c | 1 + include/linux/blkdev.h | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 11342af420d0..cc4db4d92c75 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1073,6 +1073,7 @@ void blk_start_plug_nr_ios(struct blk_plug *plug, unsigned short nr_ios) if (tsk->plug) return; + plug->cur_ktime = 0; plug->mq_list = NULL; plug->cached_rq = NULL; plug->nr_ios = min_t(unsigned short, nr_ios, BLK_MAX_REQUEST_COUNT); diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 2f9ceea0e23b..2d5c94e99792 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -942,6 +942,7 @@ struct blk_plug { /* if ios_left is > 1, we can batch tag/rq allocations */ struct request *cached_rq; + u64 cur_ktime; unsigned short nr_ios; unsigned short rq_count; @@ -977,7 +978,19 @@ long nr_blockdev_pages(void); static inline u64 blk_time_get_ns(void) { - return ktime_get_ns(); + struct blk_plug *plug = current->plug; + + if (!plug) + return ktime_get_ns(); + + /* + * 0 could very well be a valid time, but rather than flag "this is + * a valid timestamp" separately, just accept that we'll do an extra + * ktime_get_ns() if we just happen to get 0 as the current time. + */ + if (!plug->cur_ktime) + plug->cur_ktime = ktime_get_ns(); + return plug->cur_ktime; } #else /* CONFIG_BLOCK */ struct blk_plug { From patchwork Tue Jan 16 16:54:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 13520959 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A0B1CF92 for ; Tue, 16 Jan 2024 16:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705424306; cv=none; b=We+rjJ/yBH6KkphkIXoByeWTBzwZ6G7K1Sr1SwsW7MQh6i1jMU+WKTfUiZkheSFLdvmvPESj3BjDgHVNH9QMWekgsF0ybnP7LbkZ6NkfAYjYfB2g4kH8NUyT7krEoEqVUivIrfrmhQpBp7Os5xOK0d+vWGEP945Ur+BkgoDlsKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705424306; c=relaxed/simple; bh=7SLxeynCNIOGxfRnllxkpIfue8vzgpQqvWGeqPpIRp8=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received:From: To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; b=EwT8N+iNKZguMXA/9HrxFRGkDaMkZ88sIuYHviuVmNcq0bWt6uyE8IbIAw4wk8UvOs1yLISwBG1MOrw9jCiR9D78hPn/99w1+t9zLVsWStU59NwDbX4mFlLfEaIPzKHKVvlqcGZJbooXb673WDZZHoQIAMyJ050Jduj21rmSjIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=Qb/h7mcS Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="Qb/h7mcS" Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-3608ec05dc2so4820235ab.1 for ; Tue, 16 Jan 2024 08:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705424303; x=1706029103; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sual2oOzcDgWB9m2hWR3owp6IlX6MibNTQZBGYSJ128=; b=Qb/h7mcSW5spvUAeC6GjMR4jaOY3C6DXChYVgrgVs7uLdnyP2gixxYpRvP0kZKinu+ mydax3unsr0uaIxkHtXBF5/fjN89Gy+CpGwl8lkxCjVUw1R04Np7cQDTm5Z9+ITweaCx krTdV/5GyCIiF3nbY5G2jaT8NRD/E46GvI+8yxC2mTgwlzIpH9uPVNTfvBg42FTNxRBZ 9J9M746+RpHwVHJxhbOekT/vI2/ZM7z5xzeiEzZLN+dynfg0lb0ivEt3YipyLhdG8V/8 0cKdAFXSq82ZRzgPVtb1tulJdXvSdURP212Jaimp9g6DnF2PMObZukBWjTJgsvHeYJ4E JIQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705424303; x=1706029103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sual2oOzcDgWB9m2hWR3owp6IlX6MibNTQZBGYSJ128=; b=a5Frx0QxH7B25BUNOaCcxgEQOskakxn3rUudn3+wSuv8zfDKO1SiMVWIGydtEzwREU ma6zV+TfG1iE1hU0Q+Pk+vulnZS5FUZaNA6Onfe5O/0ouNKsnbm/CuUfK73Ayaipwcs/ kiPHePyybnK54IWPTLqH3rWCp3jP5BtD6OWH7zqFvZd2V98a4plcoh1EihMClqC8Zyug uPH7K4Sf9JaTK7ukmQFAk1MIwCyDoTa4/OTiBslAfArAZLSRWzog3EuCFAMOfer077jZ VJm7EGjp3xljJhme3laZ/yvaBWyvdQmZxtIDje4YJ2JRW6qbtxl1fcNlHP/ntYFc8MbU EMlA== X-Gm-Message-State: AOJu0YxhZfYhEZ8SeWi5hvphliNUW5AKylUq04YgMivEMiNWLTNVjBPA jWVM205dwbAFHnGha57kWkOZv/wSqtRL85UyNYh3Eg5d2prOwg== X-Google-Smtp-Source: AGHT+IFQ4VxksXYerPgpKIkS/xKA/MNa/oMqYtflmkdkdF1mJ4t9lKhvsWps3fU88wyW2b91pP69PQ== X-Received: by 2002:a05:6e02:1d07:b0:35f:da7a:3797 with SMTP id i7-20020a056e021d0700b0035fda7a3797mr14778198ila.1.1705424303289; Tue, 16 Jan 2024 08:58:23 -0800 (PST) Received: from localhost.localdomain ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id c14-20020a02a60e000000b0046ea43e4d0csm71744jam.168.2024.01.16.08.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 08:58:22 -0800 (PST) From: Jens Axboe To: linux-block@vger.kernel.org Cc: kbusch@kernel.org, joshi.k@samsung.com, Jens Axboe Subject: [PATCH 3/5] block: update cached timestamp post schedule/preemption Date: Tue, 16 Jan 2024 09:54:24 -0700 Message-ID: <20240116165814.236767-4-axboe@kernel.dk> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116165814.236767-1-axboe@kernel.dk> References: <20240116165814.236767-1-axboe@kernel.dk> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Mark the task as having a cached timestamp when set assign it, so we can efficiently check if it needs updating post being scheduled back in. This covers both the actual schedule out case, which would've flushed the plug, and the preemption case which doesn't touch the plugged requests (for many reasons, one of them being then we'd need to have preemption disabled around plug state manipulation). Signed-off-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- include/linux/blkdev.h | 19 ++++++++++++++++++- include/linux/sched.h | 2 +- kernel/sched/core.c | 4 +++- 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 2d5c94e99792..81a7fca1b4f7 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -976,6 +976,17 @@ static inline void blk_flush_plug(struct blk_plug *plug, bool async) int blkdev_issue_flush(struct block_device *bdev); long nr_blockdev_pages(void); +/* + * tsk == current here + */ +static inline void blk_plug_invalidate_ts(struct task_struct *tsk) +{ + struct blk_plug *plug = tsk->plug; + + if (plug) + plug->cur_ktime = 0; +} + static inline u64 blk_time_get_ns(void) { struct blk_plug *plug = current->plug; @@ -988,8 +999,10 @@ static inline u64 blk_time_get_ns(void) * a valid timestamp" separately, just accept that we'll do an extra * ktime_get_ns() if we just happen to get 0 as the current time. */ - if (!plug->cur_ktime) + if (!plug->cur_ktime) { plug->cur_ktime = ktime_get_ns(); + current->flags |= PF_BLOCK_TS; + } return plug->cur_ktime; } #else /* CONFIG_BLOCK */ @@ -1013,6 +1026,10 @@ static inline void blk_flush_plug(struct blk_plug *plug, bool async) { } +static inline void blk_plug_invalidate_ts(struct task_struct *tsk) +{ +} + static inline int blkdev_issue_flush(struct block_device *bdev) { return 0; diff --git a/include/linux/sched.h b/include/linux/sched.h index 9a66147915b2..d8a073b06495 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1642,7 +1642,7 @@ extern struct pid *cad_pid; #define PF_NO_SETAFFINITY 0x04000000 /* Userland is not allowed to meddle with cpus_mask */ #define PF_MCE_EARLY 0x08000000 /* Early kill for mce process policy */ #define PF_MEMALLOC_PIN 0x10000000 /* Allocation context constrained to zones which allow long term pinning. */ -#define PF__HOLE__20000000 0x20000000 +#define PF_BLOCK_TS 0x20000000 /* plug has ts that needs updating */ #define PF__HOLE__40000000 0x40000000 #define PF_SUSPEND_TASK 0x80000000 /* This thread called freeze_processes() and should not be frozen */ diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 9116bcc90346..4675d59313ba 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6787,7 +6787,9 @@ static inline void sched_submit_work(struct task_struct *tsk) static void sched_update_worker(struct task_struct *tsk) { - if (tsk->flags & (PF_WQ_WORKER | PF_IO_WORKER)) { + if (tsk->flags & (PF_WQ_WORKER | PF_IO_WORKER | PF_BLOCK_TS)) { + if (tsk->flags & PF_BLOCK_TS) + blk_plug_invalidate_ts(tsk); if (tsk->flags & PF_WQ_WORKER) wq_worker_running(tsk); else From patchwork Tue Jan 16 16:54:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 13520960 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44FB11CF98 for ; Tue, 16 Jan 2024 16:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705424307; cv=none; b=FLYoYISgRZ6ilWwhUQX/u9KOz4TVgUmhvp7YESntAUWNXuPwfwoLHBfpupVlLdpTjng863j0OQJe2/dkw3UgyTbX3FhzddPmDQ47kXPGwvWkxd1otxTyfKMU6r8aQ/MrafQFai4/2S43Gv43Hl3YhigvjTMDVgW5G7kXPf4G3EM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705424307; c=relaxed/simple; bh=f0+WWJ5qeBZXZdXMfPSvE2O2XsNxVggq+PxMwxK+/Ww=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received:From: To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; b=FwkWWCAmJTtmGACvoO5qnPm6TBZFYCBboJUSnmH8D7kj4WkoM6KE+HgwfLDWn845EqIb0SpW929DzPlbC7f9mizgnGTaCNzfrzEaToFcfN1ZXu+hqUfsY3Q3ANFTNe4g15SIhDa7uN5uEOkbGw6a5JbIwjJkQP7W8aej+z+rEw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=CyUYxiar Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="CyUYxiar" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-360630beb7bso7915405ab.0 for ; Tue, 16 Jan 2024 08:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705424305; x=1706029105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4OQsqWA3wgPKqR98FS44Fcrdj5xBVdgVFItDpaqFekA=; b=CyUYxiarWmOBRSkRNdlvgttbrJ2gVeascE+3w9F5M4VF2botqASlWtCPhkV+NPyzR/ QxBVcg/DvBMzcwTRqRulqCivyVyb9MDciHRusTwEdkWsh8A3qFADZTuZCTmzXlKVoQb6 DHfPgnR7hvyb5800ODnPoHaXjMWhKgO5sVbOMKcYyE3f6qeMMDg9ONXyuPGZb9uU96v+ RoQoa70xQnbi1WaFcMgEwiw7sylcu/TH3yjapdSlQ32BIvC88GuVOqO0ZWk9kF0BhwSs feyb7h6b0xkws20QdQo4UX2KLDp9crIWMj3tYVyl0Yjwdglk0A3iii1+hbdz+UyY3RMB kx7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705424305; x=1706029105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4OQsqWA3wgPKqR98FS44Fcrdj5xBVdgVFItDpaqFekA=; b=fotmneO3SyWxWQoBEcVMdcO/JYwfkKBSZqWWC6G3H/M2dYsJMRq5AW2WsDGu/tlZv5 Vp7/PQoryoquHGGexrlsJRB3SKhSHImIlLSCmYEe0ea3LG7jC5Mex7i3Hs/uyO2gOXph o7BC6bynroJQjAl6F0c4mSHFK3RprxvQuqI7vkLG9PZ/mcDGSwtSh9mvO3LfHoMvnktN oHOkOoQLl7UsmnRDSmIkvn2JCusoFo1rJzXeFgKUN6mBzKMayiNC0QCUGHUMk0RGvjof p5YURho8i9uAoQ8ns6FtIPn5eXGMoKtRUQKkKSTgLeVbjkTP4zPovCdRw/+hh2VTwABJ Pdbw== X-Gm-Message-State: AOJu0YxzGmKD8surV2Pno2bOStFLE9Oa+eq0IPbFh4gDPb0WIppfVFLo iE4DexM6EuTlwfg1YNlkk0Xw2ek0OBY1l3hAYUkuTsb0hUWjGA== X-Google-Smtp-Source: AGHT+IEuWWsXm4QCBpM5jiQ+ALyDDo22ll6ytkkOLnvZ48HkyzlB8sdlQW/Mia7gbQxotZLyX3VyPw== X-Received: by 2002:a6b:680a:0:b0:7bf:60bc:7f1e with SMTP id d10-20020a6b680a000000b007bf60bc7f1emr952247ioc.1.1705424305037; Tue, 16 Jan 2024 08:58:25 -0800 (PST) Received: from localhost.localdomain ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id c14-20020a02a60e000000b0046ea43e4d0csm71744jam.168.2024.01.16.08.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 08:58:23 -0800 (PST) From: Jens Axboe To: linux-block@vger.kernel.org Cc: kbusch@kernel.org, joshi.k@samsung.com, Jens Axboe Subject: [PATCH 4/5] block: shrink plug->{nr_ios, rq_count} to unsigned char Date: Tue, 16 Jan 2024 09:54:25 -0700 Message-ID: <20240116165814.236767-5-axboe@kernel.dk> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116165814.236767-1-axboe@kernel.dk> References: <20240116165814.236767-1-axboe@kernel.dk> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 We never use more than 64 max in here, we can change them from unsigned short to just a byte. Add a BUILD_BUG_ON() check, in case the max plug count changes in the future. Signed-off-by: Jens Axboe --- block/blk-core.c | 4 ++-- block/blk-mq.c | 2 ++ include/linux/blkdev.h | 8 ++++---- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index cc4db4d92c75..902799f71a59 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1063,7 +1063,7 @@ int kblockd_mod_delayed_work_on(int cpu, struct delayed_work *dwork, } EXPORT_SYMBOL(kblockd_mod_delayed_work_on); -void blk_start_plug_nr_ios(struct blk_plug *plug, unsigned short nr_ios) +void blk_start_plug_nr_ios(struct blk_plug *plug, unsigned char nr_ios) { struct task_struct *tsk = current; @@ -1076,7 +1076,7 @@ void blk_start_plug_nr_ios(struct blk_plug *plug, unsigned short nr_ios) plug->cur_ktime = 0; plug->mq_list = NULL; plug->cached_rq = NULL; - plug->nr_ios = min_t(unsigned short, nr_ios, BLK_MAX_REQUEST_COUNT); + plug->nr_ios = min_t(unsigned char, nr_ios, BLK_MAX_REQUEST_COUNT); plug->rq_count = 0; plug->multiple_queues = false; plug->has_elevator = false; diff --git a/block/blk-mq.c b/block/blk-mq.c index aff9e9492f59..a9b4a66e1e13 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1283,6 +1283,8 @@ EXPORT_SYMBOL(blk_mq_start_request); */ static inline unsigned short blk_plug_max_rq_count(struct blk_plug *plug) { + BUILD_BUG_ON(2 * BLK_MAX_REQUEST_COUNT > U8_MAX); + if (plug->multiple_queues) return BLK_MAX_REQUEST_COUNT * 2; return BLK_MAX_REQUEST_COUNT; diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 81a7fca1b4f7..5b17d0e460e4 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -943,9 +943,9 @@ struct blk_plug { /* if ios_left is > 1, we can batch tag/rq allocations */ struct request *cached_rq; u64 cur_ktime; - unsigned short nr_ios; + unsigned char nr_ios; - unsigned short rq_count; + unsigned char rq_count; bool multiple_queues; bool has_elevator; @@ -963,7 +963,7 @@ struct blk_plug_cb { extern struct blk_plug_cb *blk_check_plugged(blk_plug_cb_fn unplug, void *data, int size); extern void blk_start_plug(struct blk_plug *); -extern void blk_start_plug_nr_ios(struct blk_plug *, unsigned short); +extern void blk_start_plug_nr_ios(struct blk_plug *, unsigned char); extern void blk_finish_plug(struct blk_plug *); void __blk_flush_plug(struct blk_plug *plug, bool from_schedule); @@ -1010,7 +1010,7 @@ struct blk_plug { }; static inline void blk_start_plug_nr_ios(struct blk_plug *plug, - unsigned short nr_ios) + unsigned char nr_ios) { } From patchwork Tue Jan 16 16:54:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 13520961 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8EC51CFA0 for ; Tue, 16 Jan 2024 16:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="k5my/WeK" Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7bb5be6742fso96697439f.1 for ; Tue, 16 Jan 2024 08:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705424307; x=1706029107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hysg6RovOTmIXu4nuJHgKMsuZrXXJOpIaO3GwxVeu3A=; b=k5my/WeKZU3f0nNY4egjB0PL0eZTjaER18DrBqUCeDOeJXiZqj46DU+HUT6yqx2FIE rzMuj3mD1719hdSSDmoT4cXmyZn7FR8tj1NjNOXXiWo+WRMg/gm4j8UBI+P9ZYYehS7A g9mmGHB/V4fk3ObEkkcsaaPGB5rG6ln9WrBYHRySBeHPXr8QUsSfl3+ZP8V85TPZxwJ5 Q2CD2swIp0F78DdDgUKFQBiNedNvZ/8fqT91rWiXuH0XYxKRTVmBHv2eqp0tH2dapGC5 za1WFLneXaUQ564XeTvI66cEMwvn1hrI4qALL5OnfWIH0Fnbdopw6qM2DDg/L8qbmaWQ fJUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705424307; x=1706029107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hysg6RovOTmIXu4nuJHgKMsuZrXXJOpIaO3GwxVeu3A=; b=RmT8BOkzLGpUdnvuidmT2njYf//YBbTI2VjyqiBHBK/NVM3+7N/0oOj7T6r5fpv4tO PQdVM6wOWcO9XIPerCEvkl01rlQYsHl9BdL1Ok5MRwCwzqkr+l2hjO23uOmny7/6Kzu5 S2Ztperj7892dlZw+7Y1o6nCzte9buHH9xHRxQ64MkJ5jHXdfP1IaEYF22ksyDDXpiYY nf4maL1tV8TRx6bLfkVnw9k/wWZ18iIZQ33QAxEnRuj5NyHFjEruq8/YVtbFTfIrjRex 1MNurv8nXEb1lwiYW/XZZVYHWuymcGyPaX/GlPDJgZ2cejblF8sXVM5XIgLum6ikn+bf vH3w== X-Gm-Message-State: AOJu0YxHpQOMIvFm82S8whYidY9S4qWntirMrQrhXySJHoULTrLj+5IL pd/YCzzcpaLdM5AIV06g7ZPN+KsuntVOSKvnqMYqyeQT+St0gQ== X-Google-Smtp-Source: AGHT+IGULg84pADbJMSwXNynNquAyw5GlWcscj23xjlTdycAgOrsC8es4ZEikPhQVN4fGNfBHEq2kw== X-Received: by 2002:a6b:6a1a:0:b0:7bf:356b:7a96 with SMTP id x26-20020a6b6a1a000000b007bf356b7a96mr7320136iog.2.1705424306829; Tue, 16 Jan 2024 08:58:26 -0800 (PST) Received: from localhost.localdomain ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id c14-20020a02a60e000000b0046ea43e4d0csm71744jam.168.2024.01.16.08.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 08:58:25 -0800 (PST) From: Jens Axboe To: linux-block@vger.kernel.org Cc: kbusch@kernel.org, joshi.k@samsung.com, Jens Axboe Subject: [PATCH 5/5] block: convert struct blk_plug callback list to hlists Date: Tue, 16 Jan 2024 09:54:26 -0700 Message-ID: <20240116165814.236767-6-axboe@kernel.dk> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116165814.236767-1-axboe@kernel.dk> References: <20240116165814.236767-1-axboe@kernel.dk> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 We currently use a doubly linked list, which means the head takes up 16 bytes. As any iteration goes over the full list by first splicing it to an on-stack copy, we never need to remove members from the middle of the list. Convert it to an hlist instead, saving 8 bytes in the blk_plug structure. This also helps save 40 bytes of text in the core block code, tested on arm64. Signed-off-by: Jens Axboe --- block/blk-core.c | 26 ++++++++++++++------------ include/linux/blkdev.h | 4 ++-- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 902799f71a59..a487881fe2a6 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1080,7 +1080,7 @@ void blk_start_plug_nr_ios(struct blk_plug *plug, unsigned char nr_ios) plug->rq_count = 0; plug->multiple_queues = false; plug->has_elevator = false; - INIT_LIST_HEAD(&plug->cb_list); + INIT_HLIST_HEAD(&plug->cb_list); /* * Store ordering should not be needed here, since a potential @@ -1120,16 +1120,18 @@ EXPORT_SYMBOL(blk_start_plug); static void flush_plug_callbacks(struct blk_plug *plug, bool from_schedule) { - LIST_HEAD(callbacks); + HLIST_HEAD(callbacks); - while (!list_empty(&plug->cb_list)) { - list_splice_init(&plug->cb_list, &callbacks); + while (!hlist_empty(&plug->cb_list)) { + struct hlist_node *entry, *tmp; - while (!list_empty(&callbacks)) { - struct blk_plug_cb *cb = list_first_entry(&callbacks, - struct blk_plug_cb, - list); - list_del(&cb->list); + hlist_move_list(&plug->cb_list, &callbacks); + + hlist_for_each_safe(entry, tmp, &callbacks) { + struct blk_plug_cb *cb; + + cb = hlist_entry(entry, struct blk_plug_cb, list); + hlist_del(&cb->list); cb->callback(cb, from_schedule); } } @@ -1144,7 +1146,7 @@ struct blk_plug_cb *blk_check_plugged(blk_plug_cb_fn unplug, void *data, if (!plug) return NULL; - list_for_each_entry(cb, &plug->cb_list, list) + hlist_for_each_entry(cb, &plug->cb_list, list) if (cb->callback == unplug && cb->data == data) return cb; @@ -1154,7 +1156,7 @@ struct blk_plug_cb *blk_check_plugged(blk_plug_cb_fn unplug, void *data, if (cb) { cb->data = data; cb->callback = unplug; - list_add(&cb->list, &plug->cb_list); + hlist_add_head(&cb->list, &plug->cb_list); } return cb; } @@ -1162,7 +1164,7 @@ EXPORT_SYMBOL(blk_check_plugged); void __blk_flush_plug(struct blk_plug *plug, bool from_schedule) { - if (!list_empty(&plug->cb_list)) + if (!hlist_empty(&plug->cb_list)) flush_plug_callbacks(plug, from_schedule); blk_mq_flush_plug_list(plug, from_schedule); /* diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 5b17d0e460e4..f339f856e44f 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -950,13 +950,13 @@ struct blk_plug { bool multiple_queues; bool has_elevator; - struct list_head cb_list; /* md requires an unplug callback */ + struct hlist_head cb_list; /* md requires an unplug callback */ }; struct blk_plug_cb; typedef void (*blk_plug_cb_fn)(struct blk_plug_cb *, bool); struct blk_plug_cb { - struct list_head list; + struct hlist_node list; blk_plug_cb_fn callback; void *data; };