From patchwork Fri Jan 19 00:13:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Huey X-Patchwork-Id: 13523267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60D7DC47422 for ; Fri, 19 Jan 2024 00:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgKrB3ia+HLUkhM57fpDMZuVBI1V3Uak8Ba9ziYJc8Y=; b=VRJmfCCpfPUUN6 CFyNFuEYrtGzo4a1rQB+khrv7sLSg3K1oWiDodxCme+vXS6IaypVyXQgpcqIhyGJLZN6r8WkmFDhf WzXT1RM+t+g4v2tyCOkWJMq77wFHQjVCQsxKAKB8TIJ2ZdSNphAJ2WtQVrSt/6k6PWf4BiwdloqEP PaUw1GgyOMjyg0ldI9IYTU5g86h91dKcilXisA1qlC5YdAcEhRlj1Nkog+tXIcH5/h73MW7iYlUjB llS3X+Y2DTFTdFpOlyqTDL2jbehZpiqft1N+GRWnXuRC18GlmufVff9DlEkbvQ/QI4puNP6VW5MyS g1kmPdRASVSnvCcqx7eA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQcWe-0047RM-0P; Fri, 19 Jan 2024 00:14:24 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQcWa-0047PR-0L for linux-arm-kernel@lists.infradead.org; Fri, 19 Jan 2024 00:14:23 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d480c6342dso1557415ad.2 for ; Thu, 18 Jan 2024 16:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kylehuey.com; s=google; t=1705623256; x=1706228056; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TZcU1eaajijXdHtIWhayAvoytSB02YbTVp/d9IoCpKI=; b=CygoLcAjqaUlXsTPqXLOTCLz0e84IDXxh9+F6l0H86S45KUgJfDoJlclrbO7qhqALA EIlBbmg+AlhMjK6OpoY83hWtlUKkUH4egcahDrjuKdw4lAF0GYwdHqDKTz0x39P8C7ZL nRpDe5CM+hIBxl4hd/xTPuOlPMqI5g5VZlVdCWeyaOnIyLNL59Tv0ar8QYsTPVj4Ny0l VrGZmIk4CnS2MNamIbKUOhofzkeNj+aoSwixT5jWkEP5FO3k6UHTAiF/1cs80Kg0cEPj F94ABKK0/zFPoScEoHIHlcsuFiaAWz+9xEu9SyJ6NhxjMufBjvfLKDMVNCRMjH08VFwn JiMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705623256; x=1706228056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TZcU1eaajijXdHtIWhayAvoytSB02YbTVp/d9IoCpKI=; b=e4x/sAOld7+zqaiftKmXeqUBGx/710Wg7RB643v21JutOp8wj6hQA99LhLqFf90kPp XSu/X6g1zNJ1L6vNPYw2cLWFosWwq3ROgXPjI2mkwllOZlHRw3pjMqvuaC6c8V14n8SK 8kELTI2fpMxJkjSK7+mFX6BCBtZKlTTRcf3BoxzXXMrjRZrFq1y7Yvg4iHJhqdqVedZH /eZySNlFgR0hSCDMMyhZfxwllamLcEzJVsqjZfRVvn+b8SiLo/4ig1tOiQ5Ebiw/REm0 45Pnzq1fPmeebIOphoVEXRmjGfhfjva8c689dPU5f/lJX8i95g5ZTxq45OrIPgkflRt4 wezg== X-Gm-Message-State: AOJu0YxTAmhn/LIrA8vrKww7XWDe0GXaqWvLGP/aURFHk2h/lN8L+VZU Hi8+e66O+TonrzZ8rxYI95QCifTKuiQmMr25tguLDuqtYa1/8Ew+zMC1lZc2bA== X-Google-Smtp-Source: AGHT+IEmEX9cgoOoLlXa/PdbiT/2i5lxpr6nzytvpqJqWne6DoYaTAYruERi3LVO2S0pdvC6eXPZjA== X-Received: by 2002:a17:902:d486:b0:1d7:1b54:8969 with SMTP id c6-20020a170902d48600b001d71b548969mr518993plg.11.1705623256601; Thu, 18 Jan 2024 16:14:16 -0800 (PST) Received: from zhadum.home.kylehuey.com (c-76-126-33-191.hsd1.ca.comcast.net. [76.126.33.191]) by smtp.gmail.com with ESMTPSA id mj7-20020a1709032b8700b001d1d1ef8be6sm1921238plb.267.2024.01.18.16.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 16:14:16 -0800 (PST) From: Kyle Huey X-Google-Original-From: Kyle Huey To: Kyle Huey , linux-kernel@vger.kernel.org, Andrii Nakryiko , Jiri Olsa , Namhyung Kim , Marco Elver , Yonghong Song , Song Liu Cc: Robert O'Callahan , Will Deacon , Mark Rutland , Russell King , Catalin Marinas , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Ian Rogers , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH v4 2/4] perf/bpf: Remove unneeded uses_default_overflow_handler. Date: Thu, 18 Jan 2024 16:13:49 -0800 Message-Id: <20240119001352.9396-3-khuey@kylehuey.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240119001352.9396-1-khuey@kylehuey.com> References: <20240119001352.9396-1-khuey@kylehuey.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240118_161420_144744_60688C07 X-CRM114-Status: GOOD ( 18.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that struct perf_event's orig_overflow_handler is gone, there's no need for the functions and macros to support looking past overflow_handler to orig_overflow_handler. This patch is solely a refactoring and results in no behavior change. Signed-off-by: Kyle Huey Acked-by: Will Deacon Acked-by: Song Liu --- arch/arm/kernel/hw_breakpoint.c | 8 ++++---- arch/arm64/kernel/hw_breakpoint.c | 4 ++-- include/linux/perf_event.h | 16 ++-------------- 3 files changed, 8 insertions(+), 20 deletions(-) diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c index dc0fb7a81371..054e9199f30d 100644 --- a/arch/arm/kernel/hw_breakpoint.c +++ b/arch/arm/kernel/hw_breakpoint.c @@ -626,7 +626,7 @@ int hw_breakpoint_arch_parse(struct perf_event *bp, hw->address &= ~alignment_mask; hw->ctrl.len <<= offset; - if (uses_default_overflow_handler(bp)) { + if (is_default_overflow_handler(bp)) { /* * Mismatch breakpoints are required for single-stepping * breakpoints. @@ -798,7 +798,7 @@ static void watchpoint_handler(unsigned long addr, unsigned int fsr, * Otherwise, insert a temporary mismatch breakpoint so that * we can single-step over the watchpoint trigger. */ - if (!uses_default_overflow_handler(wp)) + if (!is_default_overflow_handler(wp)) continue; step: enable_single_step(wp, instruction_pointer(regs)); @@ -811,7 +811,7 @@ static void watchpoint_handler(unsigned long addr, unsigned int fsr, info->trigger = addr; pr_debug("watchpoint fired: address = 0x%x\n", info->trigger); perf_bp_event(wp, regs); - if (uses_default_overflow_handler(wp)) + if (is_default_overflow_handler(wp)) enable_single_step(wp, instruction_pointer(regs)); } @@ -886,7 +886,7 @@ static void breakpoint_handler(unsigned long unknown, struct pt_regs *regs) info->trigger = addr; pr_debug("breakpoint fired: address = 0x%x\n", addr); perf_bp_event(bp, regs); - if (uses_default_overflow_handler(bp)) + if (is_default_overflow_handler(bp)) enable_single_step(bp, addr); goto unlock; } diff --git a/arch/arm64/kernel/hw_breakpoint.c b/arch/arm64/kernel/hw_breakpoint.c index 35225632d70a..db2a1861bb97 100644 --- a/arch/arm64/kernel/hw_breakpoint.c +++ b/arch/arm64/kernel/hw_breakpoint.c @@ -654,7 +654,7 @@ static int breakpoint_handler(unsigned long unused, unsigned long esr, perf_bp_event(bp, regs); /* Do we need to handle the stepping? */ - if (uses_default_overflow_handler(bp)) + if (is_default_overflow_handler(bp)) step = 1; unlock: rcu_read_unlock(); @@ -733,7 +733,7 @@ static u64 get_distance_from_watchpoint(unsigned long addr, u64 val, static int watchpoint_report(struct perf_event *wp, unsigned long addr, struct pt_regs *regs) { - int step = uses_default_overflow_handler(wp); + int step = is_default_overflow_handler(wp); struct arch_hw_breakpoint *info = counter_arch_bp(wp); info->trigger = addr; diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index c7f54fd74d89..c8bd5bb6610c 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1341,8 +1341,9 @@ extern int perf_event_output(struct perf_event *event, struct pt_regs *regs); static inline bool -__is_default_overflow_handler(perf_overflow_handler_t overflow_handler) +is_default_overflow_handler(struct perf_event *event) { + perf_overflow_handler_t overflow_handler = event->overflow_handler; if (likely(overflow_handler == perf_event_output_forward)) return true; if (unlikely(overflow_handler == perf_event_output_backward)) @@ -1350,19 +1351,6 @@ __is_default_overflow_handler(perf_overflow_handler_t overflow_handler) return false; } -#define is_default_overflow_handler(event) \ - __is_default_overflow_handler((event)->overflow_handler) - -#ifdef CONFIG_BPF_SYSCALL -static inline bool uses_default_overflow_handler(struct perf_event *event) -{ - return is_default_overflow_handler(event); -} -#else -#define uses_default_overflow_handler(event) \ - is_default_overflow_handler(event) -#endif - extern void perf_event_header__init_id(struct perf_event_header *header, struct perf_sample_data *data,