From patchwork Tue Jan 23 01:12:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 13526765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3C16C46CD2 for ; Tue, 23 Jan 2024 01:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=zpJLyaQX9mfVFMWZSBtr3YmHVzfKm4SzEyBa/7/Ct50=; b=GMQtDz8Ny6IxlQ 3SYljb3aL6xaklmPcmJdj35sfmX5k2p2Kf5hDUSGNvpud05kUJsNVtFbGeesLm+TEMR5m/gV7FEpv KFX8IwFeQ0OCGp8G14Gx9JrmEfbbyJVInNbmMM+SaiuZ9jLpCI1QnYM9boLQrmZvf2FfPygsH0a0r nVs5EyJIGKRirrUDcK+w5aEcAqDs0j3b8pjRSHmSGtAdTRfFcvxCLdheb5ZJV1i0O8C0iJRo5nv0+ Y16doWLtmehaww7aT4TP/88rGvnOs4wZVeM/SX8If33D1sifWUDTPA3yavK8jQO9oEs1Eeun8r4Qd MW9TmkJ9OOE5m8mTckWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rS5L5-00EhtH-0O; Tue, 23 Jan 2024 01:12:31 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rS5L2-00Ehpm-0A for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 01:12:29 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1d70a986c4aso14760475ad.2 for ; Mon, 22 Jan 2024 17:12:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705972338; x=1706577138; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4qH9Rf/zd/bFfsFZBAS2bb+VGZ3TWvzsYRdk9oqlfHE=; b=aPS0FGmaoltDzTEjq8TeqNh1U3pMFrNH9iWNWC0gNnzMUYLtqbXjz1fZpXHJ/HyBlz tiQOIxVb3TWxGIzXrFbbZNd5fRF30NvGKiC+ygLbEDGbowvl2SDRDIpi13/DSaBaoCtQ EsImOqEZPDLOPiJ4J590XPb9DDpO4/Z4XZkoA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705972338; x=1706577138; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4qH9Rf/zd/bFfsFZBAS2bb+VGZ3TWvzsYRdk9oqlfHE=; b=roK0XdnVoZrDbx9fp5LI8g2K4PmOPMUTwK7dBr6zRgWpRKtkYSFoqS7Rj69G5H4RjQ /WmmvJo32VcRf0YV70VmlKg0XNhmpK9LmM/avXKfynro5PChVPUYnDhAD6tvxp4rs87e 2HqjnGp+o8WJ1lxe0AfYt8wwEsNos5g9A+uv+/yZcu1OPj+iH4xXjAezoElq5ebTwIPx CVwmRf6/J49P53T2J1aS5gbwI/11WEkH9z1qSdNqco9R+5V+raG5pLGeK6v9YGqPQ679 4s6OMQlF3+aPPifQphib0W9a5DS+XQXHrnqX5iThSNpf+ahmUSj9vQMlboMVYsaqGD3+ aYow== X-Gm-Message-State: AOJu0Yyrq2PFUMKfX6KfBR2sJ4FDghfSieh8xK9/fY4jg1oks9QBpGmR 1uMgEw1dXw8YAW6WqV7wGqlNMXYfD+1PvLQnnqUyHqm1xLePQchbaq1tOUlxxA== X-Google-Smtp-Source: AGHT+IGNrTPrac7ISZlO2e5t99w9hTwrpumEwsfIdx7bdlG3ZBChA/j7c0HGByhiNohLx2kmMirFcQ== X-Received: by 2002:a17:902:da91:b0:1d7:4e2:592b with SMTP id j17-20020a170902da9100b001d704e2592bmr3161029plx.103.1705972338231; Mon, 22 Jan 2024 17:12:18 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id w2-20020a170902c78200b001d71f10aa42sm5968938pla.11.2024.01.22.17.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 17:12:16 -0800 (PST) From: Kees Cook To: "Russell King (Oracle)" Cc: Kees Cook , Ard Biesheuvel , Wang Kefeng , Ben Hutchings , linux-arm-kernel@lists.infradead.org, Russell King , Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH] ARM: fault: Add "cut here" line for prefetch aborts Date: Mon, 22 Jan 2024 17:12:15 -0800 Message-Id: <20240123011211.work.227-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=935; i=keescook@chromium.org; h=from:subject:message-id; bh=ZCXYUvRq5QkiujopZKa+oos+1nywJjGYg1IVAwcoHTU=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlrxJuxQakNaOdgA1fbKkrd9nBEjS8Bl0aB6r2y 6AtqY38AQuJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZa8SbgAKCRCJcvTf3G3A JnRTD/91aoq4t5Oh+w4+1avUipu20D+yzeP9E3R7zVZG/KmQyCAFUSLowG/5ggQFVkv7TN8Wit9 ZGNlfOuX8hBK0yLB6hYBGfOoHcsh1Gn7bcwBK6V5HkupzaTohUCDm28WaRM4GPvyx+Lt0sk9A6g 6HAcuu0GvPgX6ZpMW3G+OYfqnrXC+oDXw1JoWSZ6ByS0H3SiQBO1/3sspw9IPDLcxcce8B5/1dz 7lZ+PhKbqJ0ZUh+DmdS4UVbOrtzf9bFsdKAMO5NthlwHeeEDPtwbDYqqqRhyfikfds/k0jrcyYw mj8r4Ckh93ofW3TTufuvqoiLToS0cQ4joPsbbgKTnwBLQnu/Sovm1SV+2qPeG8CSrylxToPn66c VJUZjaLhI+vzE8HHhwfOqOtFIAC4d2uqY0lZu/tXbS0Jf4sWTNDr9R3DVlvsJ035PhLX7Jzfzt6 /yboV6QecaqFRqw2aPFwYL8F4LFLXCgrDrmms6oYk/+ibyVeOxxt0HAcZK1/C9pF1AAn5CBW+sD QZP/hxPvayNBRU2hgWSFhZCrPEm6Aa4GoXsGIqiMVQHMy1peVqURo24q89XsgK4LOQ9+HVURGJk WHNO5Xzhzh6evN0gwT+E+cf/LPul96AgTHVfftpVQLe/5AibJkCWT4fDM8VYAc/kgvx71nzhZEh ZZiuYLDe 2RO/4pw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_171228_126007_91391BEF X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The common pattern in arm is to emit a "8<--- cut here ---" line for faults, but it was missing for do_PrefetchAbort(). Add it. Cc: "Russell King (Oracle)" Cc: Ard Biesheuvel Cc: Wang Kefeng Cc: Ben Hutchings Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Kees Cook Acked-by: Ard Biesheuvel --- arch/arm/mm/fault.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c index e96fb40b9cc3..e804432e905e 100644 --- a/arch/arm/mm/fault.c +++ b/arch/arm/mm/fault.c @@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs) if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs)) return; + pr_alert("8<--- cut here ---\n"); pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n", inf->name, ifsr, addr);