From patchwork Tue Jan 23 03:49:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 13526814 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1740E811; Tue, 23 Jan 2024 03:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705981777; cv=none; b=ltq70h2RYCWJ5T9DpS7ID/wrJ1efTfBM6qdkaZbmpk5mwWjgKiwD4UMhhuCruB0PwEbrcPDPdmwr3+htir82MDYyQdFU5T6Cy0z8iz7kP2w7wOs+99D+mWd7lhgvpQRt2+S1NnfYMMnE8tcznEPjFGI/M4wJ6ul1G0ItrwbSo2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705981777; c=relaxed/simple; bh=9YGytayOyvrqM1UOlBPYGoFyU+G4vKpH8xTOAkYiBvo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=LRvu4/kh+bXP+oUHMMVhEnPYBouwrA5M8DHiLoq4/l4rFVaTvJWdnk6Q1mgozZwoHZmVXuWcJcakzkMn2Qe8uOyKElHUxEIXxmXeO/OqbsvSJfKr2w5ygGT3099YtZ93VCrKUNn6QeKyXpPMXrWoLhoBYgjvT72RQmNgrZOnLIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=t2/msMkv; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=t2/msMkv; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="t2/msMkv"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="t2/msMkv" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2D6701F460; Tue, 23 Jan 2024 03:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705981772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=U8VyKLogvYMD1rTctmZnd/alWyUFhnS8KG4rLLMbTjU=; b=t2/msMkvk8g2qOlvWBOOI3Y3G6pThghSVTc+0y0sAtYeqBqCZaJaRiZjhkchpR2sP77rsh kTUl1QMPNF2HAIVzqadFr/FGhyr2amS3SbGNX2dkNRwhj3CWZPZ1ua7lR4ESvczNh1iPzt OmHTJ+4U41DeoHQSOXUWJF6ctsbZapo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705981772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=U8VyKLogvYMD1rTctmZnd/alWyUFhnS8KG4rLLMbTjU=; b=t2/msMkvk8g2qOlvWBOOI3Y3G6pThghSVTc+0y0sAtYeqBqCZaJaRiZjhkchpR2sP77rsh kTUl1QMPNF2HAIVzqadFr/FGhyr2amS3SbGNX2dkNRwhj3CWZPZ1ua7lR4ESvczNh1iPzt OmHTJ+4U41DeoHQSOXUWJF6ctsbZapo= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA384136A4; Tue, 23 Jan 2024 03:49:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ykj7Iko3r2XjLAAAD6G6ig (envelope-from ); Tue, 23 Jan 2024 03:49:30 +0000 From: Qu Wenruo To: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH] fstests: btrfs: verify the read behavior of compressed inline extent Date: Tue, 23 Jan 2024 14:19:08 +1030 Message-ID: <20240123034908.25415-1-wqu@suse.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [1.90 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_TWO(0.00)[2]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: * X-Spam-Score: 1.90 X-Spam-Flag: NO [BUG] There is a report about reading a zstd compressed inline file extent would lead to either a VM_BUG_ON() crash, or lead to incorrect file content. [CAUSE] The root cause is a incorrect memcpy_to_page() call, which uses incorrect page offset, and can lead to either the VM_BUG_ON() as we may write beyond the page boundary, or writes into the incorrect offset of the page. [TEST CASE] The test case would: - Mount with the specified compress algorithm - Create a 4K file - Verify the 4K file is all inlined and compressed - Verify the content of the initial write - Cycle mount to drop all the page cache - Verify the content of the file again - Unmount and fsck the fs This workload would be applied to all supported compression algorithms. And it can catch the problem correctly by triggering VM_BUG_ON(), as our workload would result decompressed extent size to be 4K, and would trigger the VM_BUG_ON() 100%. And with the revert or the new fix, the test case can pass safely. Signed-off-by: Qu Wenruo Reviewed-by: David Disseldorp Reviewed-by: Neal Gompa --- tests/btrfs/310 | 81 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/310.out | 2 ++ 2 files changed, 83 insertions(+) create mode 100755 tests/btrfs/310 create mode 100644 tests/btrfs/310.out diff --git a/tests/btrfs/310 b/tests/btrfs/310 new file mode 100755 index 00000000..b514a8bc --- /dev/null +++ b/tests/btrfs/310 @@ -0,0 +1,81 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2024 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test 310 +# +# Make sure reading on an compressed inline extent is behaving correctly +# +. ./common/preamble +_begin_fstest auto quick compress + +# Import common functions. +# . ./common/filter + +# real QA test starts here + +# Modify as appropriate. +_supported_fs btrfs +_require_scratch + +# This test require inlined compressed extents creation, and all the writes +# are designed for 4K sector size. +_require_btrfs_inline_extents_creation +_require_btrfs_support_sectorsize 4096 + +_fixed_by_kernel_commit e01a83e12604 \ + "Revert \"btrfs: zstd: fix and simplify the inline extent decompression\"" + +# The correct md5 for the correct 4K file filled with "0xcd" +md5sum_correct="5fed275e7617a806f94c173746a2a723" + +workload() +{ + local algo="$1" + + echo "=== Testing compression algorithm ${algo} ===" >> $seqres.full + _scratch_mkfs >> $seqres.full + _scratch_mount -o compress=${algo} + + _pwrite_byte 0xcd 0 4k "$SCRATCH_MNT/inline_file" > /dev/null + result=$(_md5_checksum "$SCRATCH_MNT/inline_file") + echo "after initial write, md5sum=${result}" >> $seqres.full + if [ "$result" != "$md5sum_correct" ]; then + _fail "initial write results incorrect content for \"$algo\"" + fi + sync + + $XFS_IO_PROG -c "fiemap -v" $SCRATCH_MNT/inline_file | tail -n 1 > $tmp.fiemap + cat $tmp.fiemap >> $seqres.full + # Make sure we got an inlined compressed file extent. + # 0x200 means inlined, 0x100 means not block aligned, 0x8 means encoded + # (compressed in this case), and 0x1 means the last extent. + if ! grep -q "0x309" $tmp.fiemap; then + rm -f -- $tmp.fiemap + _notrun "No compressed inline extent created, maybe subpage?" + fi + rm -f -- $tmp.fiemap + + # Unmount to clear the page cache. + _scratch_cycle_mount + + # For v6.8-rc1 without the revert or the newer fix, this can + # crash or lead to incorrect contents for zstd. + result=$(_md5_checksum "$SCRATCH_MNT/inline_file") + echo "after cycle mount, md5sum=${result}" >> $seqres.full + if [ "$result" != "$md5sum_correct" ]; then + _fail "read for compressed inline extent failed for \"$algo\"" + fi + _scratch_unmount + _check_scratch_fs +} + +algo_list=($(_btrfs_compression_algos)) +for algo in ${algo_list[@]}; do + workload $algo +done + +echo "Silence is golden" + +status=0 +exit diff --git a/tests/btrfs/310.out b/tests/btrfs/310.out new file mode 100644 index 00000000..7b9eaf78 --- /dev/null +++ b/tests/btrfs/310.out @@ -0,0 +1,2 @@ +QA output created by 310 +Silence is golden