From patchwork Tue Jan 23 04:54:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13526829 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 664932107 for ; Tue, 23 Jan 2024 05:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986663; cv=none; b=Ps7YDeJ5DflP0wJWFfOo6c3me0yXurGXgJx3s3E5l4VnePcZb27/A12ri95HI3ESPjUlrAl49OrGUxSoRJYCaIj84RKRabOXhL/eyfdCyt5Y39naUyID1t+6Ah7B/vk54ewMH7HrQGOi0CrAUW390Un+b4f0UbQoUNVhb3Hfom4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986663; c=relaxed/simple; bh=oPlFMQxQQrOhIKPNrJEBdt7HteJBdgXPujVMnLaR/Tc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type; b=BphmdBkNDQEK1m7fLhiip0EzuGup5OI7G9fhXsmBz4rAGnjoyALjCtYvaveNxwusaHiF2/O2cNClo3FGsYj/BwxFKXtOA47hPiqCxX9Yyo5IRE/kdAlA5gwNb2ILuHQOVT7g/9WkWVzGP5bcbEH1/wd5KHMR2i6vWm93SBQY5Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hCG+mGk5; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hCG+mGk5" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6d9b37f4804so2932019b3a.1 for ; Mon, 22 Jan 2024 21:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1705986661; x=1706591461; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=kXBICfbYfWJUxTe/9TJQiNBgH7gv9zgKArM0s+kUelA=; b=hCG+mGk5NpBs+gqRUUkB/XuHDQVRbYIB6PP0GzD/ByXK3OjGmssm2x1/L3SVl64eWq hbLr4CarUbaYGx77m0IaWwIDF3uq8IAePkJARfC62RhPIuyuLkO1NWPTfZhFUNWZcmBE GvrWy/X+U1KHbTqIeBv4SX2SpUDoly4zo5fqc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705986661; x=1706591461; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kXBICfbYfWJUxTe/9TJQiNBgH7gv9zgKArM0s+kUelA=; b=aNFIlgKHFQq4BzUYLE0GYMr8FAo859TQdab3Ey8TkQDRqeVI8p15V6vSBvMa2cNbUq xYbSpwmSxjLAPbrZKTkCuq02LgD1LX7bAcwj3RqzLH4i3RGw/JwqVk/2BtSz3olFphjr UWe+if7fctD6mZtpjtoF2INv6TEzvlPyWKTGDs1e1Uu1zZyhRsjivGi5dKOxdgiH6B5P Iq2XgKHlThlp2RIMPsLHwHB2yJJR90cGTsuIqbIkrHZ4j+Eg7NDcNh/CkGgC+CapUiZh c4WrmQwZfCWlzRhRPwLWEaXlfA+/7cJGFWscuG7E1xNb6RY+lBYEQxS7n+LErkZYG94B oMrg== X-Gm-Message-State: AOJu0Yw1Z2ndoO7yiR5A8csNRYl+skOVX967B39APg+0Sv8VPj97iaj8 +u8+YOe1JgrVr+8KxnThjJNaq+jdYSKSBfn82dESkeVasGRpo49gPjxSZUVt0g== X-Google-Smtp-Source: AGHT+IHLU60oyrsgrSPO7yfvEQaCfD3MK+k3RtgALUqJBawIg8P0YaX7o5F+cjbHwjh4ZIZW2q5Ivw== X-Received: by 2002:a05:6a21:9210:b0:19a:9973:2b22 with SMTP id tl16-20020a056a21921000b0019a99732b22mr6113963pzb.40.1705986660723; Mon, 22 Jan 2024 21:11:00 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id lp4-20020a056a003d4400b006dce766903dsm672949pfb.90.2024.01.22.21.10.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 21:10:59 -0800 (PST) From: Selvin Xavier To: leon@kernel.org, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Kashyap Desai , Bhargava Chenna Marreddy , Selvin Xavier Subject: [PATCH for-rc 1/5] RDMA/bnxt_re: Avoid creating fence MR for newer adapters Date: Mon, 22 Jan 2024 20:54:33 -0800 Message-Id: <1705985677-15551-2-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> References: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Kalesh AP Limit the usage of fence MR to adapters older than Gen P5 products. Fixes: 1801d87b3598 ("RDMA/bnxt_re: Support new 5760X P7 devices") Signed-off-by: Kashyap Desai Signed-off-by: Bhargava Chenna Marreddy Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index 8243496..e1ea492 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -401,6 +401,10 @@ static void bnxt_re_create_fence_wqe(struct bnxt_re_pd *pd) struct bnxt_re_fence_data *fence = &pd->fence; struct ib_mr *ib_mr = &fence->mr->ib_mr; struct bnxt_qplib_swqe *wqe = &fence->bind_wqe; + struct bnxt_re_dev *rdev = pd->rdev; + + if (bnxt_qplib_is_chip_gen_p5_p7(rdev->chip_ctx)) + return; memset(wqe, 0, sizeof(*wqe)); wqe->type = BNXT_QPLIB_SWQE_TYPE_BIND_MW; @@ -455,6 +459,9 @@ static void bnxt_re_destroy_fence_mr(struct bnxt_re_pd *pd) struct device *dev = &rdev->en_dev->pdev->dev; struct bnxt_re_mr *mr = fence->mr; + if (bnxt_qplib_is_chip_gen_p5_p7(rdev->chip_ctx)) + return; + if (fence->mw) { bnxt_re_dealloc_mw(fence->mw); fence->mw = NULL; @@ -486,6 +493,9 @@ static int bnxt_re_create_fence_mr(struct bnxt_re_pd *pd) struct ib_mw *mw; int rc; + if (bnxt_qplib_is_chip_gen_p5_p7(rdev->chip_ctx)) + return 0; + dma_addr = dma_map_single(dev, fence->va, BNXT_RE_FENCE_BYTES, DMA_BIDIRECTIONAL); rc = dma_mapping_error(dev, dma_addr); From patchwork Tue Jan 23 04:54:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13526830 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A66E23BD for ; Tue, 23 Jan 2024 05:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986665; cv=none; b=hD5muHuhDoZuVS8nMEgR7bO04TKW2Oq9MZHwxnfYTkOsy7AVELCtffr0V8PQ0D835tWM/eDsw6/QLfcd2Kk7+SB3R1U6zEPW/mc06VcrjmqZMBJSMFFKsDTN5qxq4YmfuPpvF1nyGXkAu+SmcVUDBLlPpTDkF5+1ZmyLyED4BWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986665; c=relaxed/simple; bh=A5arZWr9xJV5x5MvfLh5jIONTcivfaZeQVD87XQvNa4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type; b=tQTIr8NGJPAOuMBSyhN1xifebKifRjjeZLstisG3Ts+YnHAk0UAdTV3oW2k4KMApmnFBSZubQpyhs2+hQo/qCS9sTWIoXFfZsgBQpvggSUoDM5gSP5W9Fjdb9mR1LC3O1+Av1OlRHs73D60ztQlW6yzwzlQiCdhVIIJZXlQZtRs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=LZnjuI0D; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="LZnjuI0D" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so3086136a12.1 for ; Mon, 22 Jan 2024 21:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1705986663; x=1706591463; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=08Gkj0hGhwJyOSLi8bHc3zMxs/YydU5TxSUGFcwHkXk=; b=LZnjuI0DDu3h31s4b1Hw17GCGrSaUFVUcvWJz/c8eRZLbzUXbFRzYumtsDJBIAFSqK 5ijJp8YDjd6PnwMGwVtfK9+VX1RCuKXxHQaKRLIkn+chhWfVJ19V4yNTTksZu+qL/KF8 aIgabYM3Cj5TInELhz7Nl/NB0t8SDYnvITPVg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705986663; x=1706591463; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=08Gkj0hGhwJyOSLi8bHc3zMxs/YydU5TxSUGFcwHkXk=; b=N94o1/jlpYCx18pTbFfxmEYp7kacClePyAf7RL78oJGP5PhCoumYPfEPrkKx6F4uWL N+dnQtd5UipqWg5cygoje3hmZOL3bOLZCt66e72EbgwjTpp+LZPmXjOwrjl0pDpjytQC biQgYlg0qfFsCCRMTtLVOlYTDA2u/TNf5SNm1Nc38q3bmPQUAJEBqfOuPebUE1T/D+ET sJlF3iMssGybNtSSco8O6gin+aFSeTdy8im1hP687xoYJnqX9BFgHaBvTcm4hAsUokk6 343Duafo/DeLHoSU228KLem2SszPWCImHG2cRHj6aayb4KMfCEqGnyrKqfjyxe30Vain I0tQ== X-Gm-Message-State: AOJu0YwSP7xQB5dCg10tXMkzoRbO6QKh3sBftMyRKILrtUfjJ7DVoSfO mxvyrLQB63xi+h7TF7yeG9OYGVTISGAPgKlXrSJB+VEbtac1mVuqkmM3IYKwxw7sO7rib+cBO7o = X-Google-Smtp-Source: AGHT+IHB4OBVR0UcDX+wBi3hC076SBzvubPBPfsfcbZv0GiR8g5NEJrHG5+EB9Wt1NBm8iQYTF1wUQ== X-Received: by 2002:a05:6a20:748a:b0:19c:5cdf:539 with SMTP id p10-20020a056a20748a00b0019c5cdf0539mr149127pzd.8.1705986663477; Mon, 22 Jan 2024 21:11:03 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id lp4-20020a056a003d4400b006dce766903dsm672949pfb.90.2024.01.22.21.11.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 21:11:02 -0800 (PST) From: Selvin Xavier To: leon@kernel.org, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Selvin Xavier Subject: [PATCH for-rc 2/5] RDMA/bnxt_re: Remove a redundant check inside bnxt_re_vf_res_config Date: Mon, 22 Jan 2024 20:54:34 -0800 Message-Id: <1705985677-15551-3-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> References: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Kalesh AP After the cited commit, there is no possibility that this check can return true. Remove it. Fixes: a43c26fa2e6c ("RDMA/bnxt_re: Remove the sriov config callback") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index f022c922..54b4d2f 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -280,9 +280,6 @@ static void bnxt_re_set_resource_limits(struct bnxt_re_dev *rdev) static void bnxt_re_vf_res_config(struct bnxt_re_dev *rdev) { - - if (test_bit(BNXT_RE_FLAG_ERR_DEVICE_DETACHED, &rdev->flags)) - return; rdev->num_vfs = pci_sriov_get_totalvfs(rdev->en_dev->pdev); if (!bnxt_qplib_is_chip_gen_p5_p7(rdev->chip_ctx)) { bnxt_re_set_resource_limits(rdev); From patchwork Tue Jan 23 04:54:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13526831 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 379DD23BD for ; Tue, 23 Jan 2024 05:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986668; cv=none; b=V3ze6gG1kxtl6XkJyoBsSWci6mz5PhEeNz6ytsXL3jMDZVeLub8/8GBY2wksmPoYF0BIzXL6fhxIcLAX4tTCP+nxdn4twYeejF5FV3xDo2QAt0At5id/kXzPHdlEJ1nUhD92ozRWj/svg1nec86sij+VUgcgjlkCkDvW2WNtYg0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986668; c=relaxed/simple; bh=5cVuwtaVLgoYIVnYKAKnWBKSfZiFw/ZtUhHN9FAKXaA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type; b=KKtlxTxd0Ke+eOJ+TShAWbc2CCC+ECmOZgB744V9Cjao22etCCfpVq4UaB+hXDwDFJCYpcVJ693FAue9g8uZf/y4C4gQMLRaU4ULQwFz9DP3u4KcP+dS25iY8SCFdaefDI07/zBs8tGYIB1IGb8wJbpqXhXkBWdcyXyt8pwOHQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=e+BB92kQ; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e+BB92kQ" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6d9f94b9186so3843921b3a.0 for ; Mon, 22 Jan 2024 21:11:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1705986666; x=1706591466; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=4YaZ0YdzS8TUbiDv9DkUyCiRYGLiis7g8Jj1PIYd/dY=; b=e+BB92kQ9xynzbtR23esjxlk1BzrqAtH1+eDjkDV2lURlWnQ7ZzHfbHVpGvUJhU5WF HUN4CaxTKoFfmu0sqVfFZejT6T8mioJI2mXiLvKt1rMKWd/Ub2lGqiNTOlnI3QkJjW58 7w0Yr2y3ipacN6/TKTocyCcwqDlb6VxTQ4TYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705986666; x=1706591466; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4YaZ0YdzS8TUbiDv9DkUyCiRYGLiis7g8Jj1PIYd/dY=; b=OXk0zNcM1ho3D6RhPonNklubXVlZgTRAkVkLhlSouCjr/OriPgtDWGCuGm9vmt0pI+ cNxaSEFtB5dFa0g3UnKPVH+S7KWEC7NNDbXFSqk69QE8XREwSDslfy/GqDlOlec7jK7U nD8LQmS75PcgGNBrH++TqEWcLGeOfeKHL0u28OO926ioP6kL6VHasGeBJ4lB4/FZeagH 1KYdrIsbchXGMHFGVj6iXlkUEKofbKadoY2Mf+nYufvpIVRgf6a7nd1tPvSO9eheMrLW txF8buMvmFYpt+QdSucOSBFi/d6jLkfYEHNYbYSFHwMKjJZQdOYu9z7qFBWo0lf6Iws5 CJAg== X-Gm-Message-State: AOJu0YwzMkgJW0b1QNpJ7LHIN2vXUiygCEE0xil5cfccbq0OaaH+jQFT NMM2GBun6YpgYEtNWsnUBgSoFsFd6KFMCoO0ZFYwC1nbGnpJyqbd+9qNBOEcRQ== X-Google-Smtp-Source: AGHT+IEYrPym4wXIN0g/+6QIqy6A/UELL+IwJVzoG+Pv/wXe46qSdJSIUG26sblLPg55qfjrY3mpGg== X-Received: by 2002:a05:6a20:548a:b0:199:a2a8:da72 with SMTP id i10-20020a056a20548a00b00199a2a8da72mr6691894pzk.10.1705986666503; Mon, 22 Jan 2024 21:11:06 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id lp4-20020a056a003d4400b006dce766903dsm672949pfb.90.2024.01.22.21.11.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 21:11:05 -0800 (PST) From: Selvin Xavier To: leon@kernel.org, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Kashyap Desai , Selvin Xavier Subject: [PATCH for-rc 3/5] RDMA/bnxt_re: Fix unconditional fence for newer adapters Date: Mon, 22 Jan 2024 20:54:35 -0800 Message-Id: <1705985677-15551-4-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> References: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Kalesh AP Older adapters required an unconditional fence for non-wire memory operations. Newer adapters doesn't require this and therefore, disabling the unconditional fence. Fixes: 1801d87b3598 ("RDMA/bnxt_re: Support new 5760X P7 devices") Signed-off-by: Kashyap Desai Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index e1ea492..fdb4fde 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -2566,11 +2566,6 @@ static int bnxt_re_build_inv_wqe(const struct ib_send_wr *wr, wqe->type = BNXT_QPLIB_SWQE_TYPE_LOCAL_INV; wqe->local_inv.inv_l_key = wr->ex.invalidate_rkey; - /* Need unconditional fence for local invalidate - * opcode to work as expected. - */ - wqe->flags |= BNXT_QPLIB_SWQE_FLAGS_UC_FENCE; - if (wr->send_flags & IB_SEND_SIGNALED) wqe->flags |= BNXT_QPLIB_SWQE_FLAGS_SIGNAL_COMP; if (wr->send_flags & IB_SEND_SOLICITED) @@ -2593,12 +2588,6 @@ static int bnxt_re_build_reg_wqe(const struct ib_reg_wr *wr, wqe->frmr.levels = qplib_frpl->hwq.level; wqe->type = BNXT_QPLIB_SWQE_TYPE_REG_MR; - /* Need unconditional fence for reg_mr - * opcode to function as expected. - */ - - wqe->flags |= BNXT_QPLIB_SWQE_FLAGS_UC_FENCE; - if (wr->wr.send_flags & IB_SEND_SIGNALED) wqe->flags |= BNXT_QPLIB_SWQE_FLAGS_SIGNAL_COMP; @@ -2729,6 +2718,18 @@ static int bnxt_re_post_send_shadow_qp(struct bnxt_re_dev *rdev, return rc; } +static void bnxt_re_legacy_set_uc_fence(struct bnxt_qplib_swqe *wqe) +{ + /* Need unconditional fence for non-wire memory opcode + * to work as expected. + */ + if (wqe->type == BNXT_QPLIB_SWQE_TYPE_LOCAL_INV || + wqe->type == BNXT_QPLIB_SWQE_TYPE_FAST_REG_MR || + wqe->type == BNXT_QPLIB_SWQE_TYPE_REG_MR || + wqe->type == BNXT_QPLIB_SWQE_TYPE_BIND_MW) + wqe->flags |= BNXT_QPLIB_SWQE_FLAGS_UC_FENCE; +} + int bnxt_re_post_send(struct ib_qp *ib_qp, const struct ib_send_wr *wr, const struct ib_send_wr **bad_wr) { @@ -2808,8 +2809,11 @@ int bnxt_re_post_send(struct ib_qp *ib_qp, const struct ib_send_wr *wr, rc = -EINVAL; goto bad; } - if (!rc) + if (!rc) { + if (!bnxt_qplib_is_chip_gen_p5_p7(qp->rdev->chip_ctx)) + bnxt_re_legacy_set_uc_fence(&wqe); rc = bnxt_qplib_post_send(&qp->qplib_qp, &wqe); + } bad: if (rc) { ibdev_err(&qp->rdev->ibdev, From patchwork Tue Jan 23 04:54:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13526832 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6422119 for ; Tue, 23 Jan 2024 05:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986671; cv=none; b=RL4VzUHm71xkYihFGGx5Ipl0W+K82+hRYK54abzrNRVdt+TXFLNRMapVxgAR7m/f93I0MGY2rYpXTK+Grj+fu89gbCRlkzXiRu+67Oeb9reckl2tLrWQC3EqrlfUFx2al+Z4SEB3CP3lTM3Pvt1qSy2xthrASfS1SGWMAZTDrXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986671; c=relaxed/simple; bh=U2AgML8H2hIWUHMt2OIgaQL/CiN4LEZc47uM1w5Dm6w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type; b=m0JzATGrv86urYDR1/2uE/oDrSL42CfexKVMAQFybrJzWa+aBMNQ7pNNUo8X86AEj893+7T68xULFan4wriH9/hYLDaAUs1n6YqiYsNTkYdjw/Ih4c3YTQwSmehqshwmtfktHDUD/zH5i3Y5NYhOiG3IfApmIuQF18cjut1MUtY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=G/RTZfdw; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="G/RTZfdw" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3bd562d17dcso3238815b6e.3 for ; Mon, 22 Jan 2024 21:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1705986669; x=1706591469; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=s3Pc2trzbgVJp5Sv1YqQCLIEKgAJYxLyXuRbWRoja6E=; b=G/RTZfdw04d/Npo6+3oxVGFsyn6DEM6UzDhUCbijXzA9FSNLw0MtdcFG81wIU4K/ub A44ZKwsojZI1a6viuYQHAzy4LcE/NQZJgkI1YXlv5ktuVlCf7k7OWOwYfJLITsGcZ053 zbR8EwgwzynLAdvlWogybjxON3d7VQR0PKw0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705986669; x=1706591469; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s3Pc2trzbgVJp5Sv1YqQCLIEKgAJYxLyXuRbWRoja6E=; b=BW3weZj6jgv/CrMP4X9JTQKlIXTvLv49Etlo4uEwiyzYij+EBohjIR/kw1f50eklm8 2evIsIbbI5XFX859WUdkrCYC0RvIhvmjaEOeOoMPp4D0SY031CRkZDpTctrsRBrleWHf 5da9yM3ZUjQawlIRCBLn9s48rW9c9+e51Xf3ycDXKI+r61QpYLRlK2haRZQb1I9DJFY8 sc+bH6FWz2WLZONJBV3ofwmBVS+SvE8iH2iT26VlDv7wF6zOKx4qLMzJ9qm12QYpyrqs TNjEhqSJsq2m3oXqoOKEFgPvkEbEg+1csBRZ+Akp9D/D5M6xTv4gCgxtiKiT/QYOt3pt WueQ== X-Gm-Message-State: AOJu0YyL0MHv3CPI4a/uOxYe+YdUWfF5zw7B2JrLrbRzJzqgFZ7gMqpx rXisges/5PGUKEBTPKjjVDjgY7wgMgziz2vWZkEGdex1fXGbO4f5o2nCnWYqtQ== X-Google-Smtp-Source: AGHT+IE8wDh1Br9cJAs6DGOt/gbUcLC49H3dfU9CncLUN48lKYAkC3w1WGm3GS9oO0dSwVUoq2wRYg== X-Received: by 2002:a05:6808:d4a:b0:3bd:c44d:da0e with SMTP id w10-20020a0568080d4a00b003bdc44dda0emr684929oik.108.1705986669206; Mon, 22 Jan 2024 21:11:09 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id lp4-20020a056a003d4400b006dce766903dsm672949pfb.90.2024.01.22.21.11.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 21:11:08 -0800 (PST) From: Selvin Xavier To: leon@kernel.org, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Selvin Xavier Subject: [PATCH for-rc 4/5] RDMA/bnxt_re: Return error for SRQ resize Date: Mon, 22 Jan 2024 20:54:36 -0800 Message-Id: <1705985677-15551-5-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> References: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Kalesh AP SRQ resize is not supported in the driver. But driver is not returning error from bnxt_re_modify_srq() for SRQ resize. Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index fdb4fde..ce9c5ba 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1827,7 +1827,7 @@ int bnxt_re_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr, switch (srq_attr_mask) { case IB_SRQ_MAX_WR: /* SRQ resize is not supported */ - break; + return -EINVAL; case IB_SRQ_LIMIT: /* Change the SRQ threshold */ if (srq_attr->srq_limit > srq->qplib_srq.max_wqe) @@ -1842,13 +1842,12 @@ int bnxt_re_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr, /* On success, update the shadow */ srq->srq_limit = srq_attr->srq_limit; /* No need to Build and send response back to udata */ - break; + return 0; default: ibdev_err(&rdev->ibdev, "Unsupported srq_attr_mask 0x%x", srq_attr_mask); return -EINVAL; } - return 0; } int bnxt_re_query_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr) From patchwork Tue Jan 23 04:54:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13526833 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB49F23BD for ; Tue, 23 Jan 2024 05:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986674; cv=none; b=vDJc0KOqZtLGP9CEkecGqcGXgPVOXBxh0NHvNRJvoXLzQX3eu0bDhixTCaS+3RC5S6MBdS0ZYONPfQiKqGgPXuGH8Nj2Lg+0cb0kYdbvjITmlNOX59inctwUwnfkjJzHhWgSX8UPAA+FH4hgOnjry1/rXWlPdPfZtqtXeFha2Iw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986674; c=relaxed/simple; bh=TP83NtJAGWQ5XwnOQ1rQQXAQavMDzE8Boh1IBjpSCfs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type; b=UoFOjAjVTmr2XsUTWjRHufOFMBIFDb7kvRJJGzrMxG+C/rI7SqgI3OTOfhXNksKmWUTU4e3nU8hy41P7B8LhT3wvNVUzaeS4erELzwzpBTrLYt4+dnylNsrAPzGN/D2ez4ZRwJQj0o6n7DJbrSeVGsds4gphxL8XdvlctM0k9yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=fBnoYSMV; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="fBnoYSMV" Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5957ede4deaso2387604eaf.1 for ; Mon, 22 Jan 2024 21:11:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1705986672; x=1706591472; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=wGnYINWTOc0yzlVaIlZsYBf72lF5TQri3tGhtHUrQEI=; b=fBnoYSMVVeuTaMslQcDF3RHWd+kpJC/Nv2LOrjlsEaW/LjiqbBNb2VSx4FFcHlEKXK Ip5oz2PCNEJAu1a9aQ9esfH7ddxUbR/0jsQP1H0TQK5IQDsDTm96qSAq3dA/DI6K+W1j oxOBax8GziU234vP5g5vvtWkVuyc3EyvqwGHQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705986672; x=1706591472; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wGnYINWTOc0yzlVaIlZsYBf72lF5TQri3tGhtHUrQEI=; b=bwoJrdrgcpAIyBpgaz8Wawd2Bf6D7Q2UXkWAAZdFub9Nj1pwyS4sagroi/1wOXQn4o NZ/VvB52l2/BPWYP2HYtsVQg8aq5e7/htNKbiS1r8VryVKS++gTDJtPx1XDwb4T6nmU4 RIrzs/3Y0uRvKg3g3+LJdVAThxaSfHoeKw7a73BUSUhxGw8n1n/Qu4gJKOOY8omkkua3 lhE9jpV8rpimT4tV32zmurNCrR2sSyvoePs/okokQQ27ivvy91QMRwkPmcqRBGSXn8BH MVf6+8w0CSdykFEfNif8eaj+BMf+vul2oyvjHqx5vBlwMAmCTH6H6URXjfcqaTDmkZAG tROA== X-Gm-Message-State: AOJu0YyLhsfzU2ForBbEHzSoYi6Am3ZvOMtmerHT9kMFviiAYPrePpkE +YLtbNBBDm7/GG7Ps5XzBywW6eUyglMpYh7QENpYmimHYs8RZYEylg4El0EMEQ== X-Google-Smtp-Source: AGHT+IETd/QCfXnqiY0fmj2qTSHQI/hT/GItsLBxuiO8/697D8Okk1KjXGg5b8qYg+gT3rHJcjNThw== X-Received: by 2002:a05:6358:7242:b0:175:f9b8:89bf with SMTP id i2-20020a056358724200b00175f9b889bfmr4504552rwa.22.1705986671848; Mon, 22 Jan 2024 21:11:11 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id lp4-20020a056a003d4400b006dce766903dsm672949pfb.90.2024.01.22.21.11.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 21:11:11 -0800 (PST) From: Selvin Xavier To: leon@kernel.org, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Selvin Xavier Subject: [PATCH for-rc 5/5] RDMA/bnxt_re: Add a missing check in bnxt_qplib_query_srq Date: Mon, 22 Jan 2024 20:54:37 -0800 Message-Id: <1705985677-15551-6-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> References: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Kalesh AP Before populating the response, driver has to check the status of HWRM command. Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index c98e04f..439d0c7 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -744,7 +744,8 @@ int bnxt_qplib_query_srq(struct bnxt_qplib_res *res, bnxt_qplib_fill_cmdqmsg(&msg, &req, &resp, &sbuf, sizeof(req), sizeof(resp), 0); rc = bnxt_qplib_rcfw_send_message(rcfw, &msg); - srq->threshold = le16_to_cpu(sb->srq_limit); + if (!rc) + srq->threshold = le16_to_cpu(sb->srq_limit); dma_free_coherent(&rcfw->pdev->dev, sbuf.size, sbuf.sb, sbuf.dma_addr);